Re: [Intel-gfx] [PATCH 4/7] mm: Introduce verify_page_range()

2021-04-14 Thread Peter Zijlstra
On Tue, Apr 13, 2021 at 08:01:08PM -0700, Kees Cook wrote: > So the addr can just be encoded in "int", and no structure is needed at: > > typedef bool (*vpr_fn_t)(pte_t pte); > > static int vpr_fn(pte_t *pte, unsigned long addr, void *data) > { > vpr_fn_t callback = data; > > if (!ca

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix an error code in intel_overlay_do_put_image()

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915: fix an error code in intel_overlay_do_put_image() URL : https://patchwork.freedesktop.org/series/89050/ State : success == Summary == CI Bug Log - changes from CI_DRM_9966 -> Patchwork_19931 Summary --

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-14 Thread Pekka Paalanen
On Tue, 13 Apr 2021 16:11:29 +0200 Daniel Vetter wrote: > On Tue, Apr 13, 2021 at 02:56:02PM +0300, Pekka Paalanen wrote: > > On Tue, 13 Apr 2021 11:49:03 +0200 > > Daniel Vetter wrote: > > > > > It's very confusing for userspace to have to deal with inconsistencies > > > here, and some drive

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Fix error code in intel_gvt_init_device()

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix error code in intel_gvt_init_device() URL : https://patchwork.freedesktop.org/series/89047/ State : success == Summary == CI Bug Log - changes from CI_DRM_9966_full -> Patchwork_19930_full Summ

Re: [Intel-gfx] [PATCH v2 00/12] drm/i915: Extend GEN renames to the rest of the driver

2021-04-14 Thread Jani Nikula
On Tue, 13 Apr 2021, Jani Nikula wrote: > On Mon, 12 Apr 2021, Lucas De Marchi wrote: >> Like was done for the display part that parted ways with INTEL_GEN(), >> replacing with DISPLAY_VER(), do a similar conversion for the rest of >> the driver. >> >> v1.1: Remove .ko that was incorrectly added

Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove useless function

2021-04-14 Thread Zhenyu Wang
On 2021.04.13 14:18:48 +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function > 'ppgtt_set_guest_root_entry' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 11/12] drm/vc4: Don't set allow_fb_modifiers explicitly

2021-04-14 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 11:49:02AM +0200, Daniel Vetter wrote: > Since > > commit 890880ddfdbe256083170866e49c87618b706ac7 > Author: Paul Kocialkowski > Date: Fri Jan 4 09:56:10 2019 +0100 > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > this is done automatical

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-14 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 11:49:03AM +0200, Daniel Vetter wrote: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some also m

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix an error code in intel_overlay_do_put_image()

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915: fix an error code in intel_overlay_do_put_image() URL : https://patchwork.freedesktop.org/series/89050/ State : success == Summary == CI Bug Log - changes from CI_DRM_9966_full -> Patchwork_19931_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4 URL : https://patchwork.freedesktop.org/series/89055/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function pa

[Intel-gfx] [PATCH] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-14 Thread Daniel Vetter
It's very confusing for userspace to have to deal with inconsistencies here, and some drivers screwed this up a bit. Most just ommitted the format list when they meant to say that only linear modifier is allowed, but some also meant that only implied modifiers are acceptable (because actually none

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 10:24:22AM +0800, Liu Ying wrote: > Hi Daniel, > > On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > > Am Dienstag, dem 13.04.2

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a

2021-04-14 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > We lost the FBC 16bpp 512byte stride requirement on glk when > we switched from display version 9 to 10. Restore the w/a to > avoid enabling FBC with a bad stride and thus display garbage. > > Cc: Matt Roper > Fixes: 2b5a4562edd

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a

2021-04-14 Thread Jani Nikula
On Wed, 14 Apr 2021, Jani Nikula wrote: > On Mon, 12 Apr 2021, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> We lost the FBC 16bpp 512byte stride requirement on glk when >> we switched from display version 9 to 10. Restore the w/a to >> avoid enabling FBC with a bad stride and thus display g

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a

2021-04-14 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > We lost a CCS related w/a on glk when the display version > became 10 instead of 9. Restore the correct check. > > Cc: Matt Roper > Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests") > Signed-off-by: Vi

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again

2021-04-14 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > The glk display version change is causing us to again attempt > LTTPR detection on glk. We must not do tha since glk doesn't > have a long enough AUX timeout. Restore the correct logic to > skip the detection. > > Cc: Matt Roper

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk

2021-04-14 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Just let bxt/glk fall back to intel_hpd_pin_default() instead > of using skl_hpd_pin() or cnl_hpd_pin(). Doesn't really matter > since both functions will end up returning the correct hpd pin > anyway, but I find it a bit less co

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks

2021-04-14 Thread Jani Nikula
On Mon, 12 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that glk display version is 10 we can drop a few more glk checks. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- > drivers/gpu/drm/i915/displa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4 URL : https://patchwork.freedesktop.org/series/89055/ State : success == Summary == CI Bug Log - changes from CI_DRM_9967 -> Patchwork_19932 Summar

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions

2021-04-14 Thread Jani Nikula
On Tue, 13 Apr 2021, Jani Nikula wrote: > On Mon, 12 Apr 2021, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Fix a couple of regressions due to the glk display version 9->10 >> change. I *think* all the ones that slipped through involved >> either DISPLAY_VER==9 or DISPLAY_VER<10 checks. The

Re: [Intel-gfx] [RFC PATCH 1/2] tests/core_hotunplug: Add perf health check

2021-04-14 Thread Marcin Bernatowicz
On Thu, 2021-04-08 at 10:31 +0200, Janusz Krzysztofik wrote: > Sometimes CI reports skips of perf subtests when run subsequently > after > core_hotunplug. That may be an indication of issues with restoring > device perf features on driver (hot)rebind. > > Detect device perf support at test start

Re: [Intel-gfx] [RFC PATCH 2/2] intel-ci: Unblock core_hotunplug@*hot*bind* subtests

2021-04-14 Thread Marcin Bernatowicz
On Thu, 2021-04-08 at 10:30 +0200, Janusz Krzysztofik wrote: > Commit be529747d8ea ("intel-ci: Broaden core_hotunplug blacklist") > blamed issues triggered by hot variants[*] as responsible for random > failures in subsequently executed tests, > > According to the issue history[*], last reported o

Re: [Intel-gfx] [PATCH v2 00/12] drm/i915: Extend GEN renames to the rest of the driver

2021-04-14 Thread Jani Nikula
On Wed, 14 Apr 2021, Jani Nikula wrote: > On Tue, 13 Apr 2021, Jani Nikula wrote: >> On Mon, 12 Apr 2021, Lucas De Marchi wrote: >>> Like was done for the display part that parted ways with INTEL_GEN(), >>> replacing with DISPLAY_VER(), do a similar conversion for the rest of >>> the driver. >>>

Re: [Intel-gfx] [RFC PATCH v2] drm/doc/rfc: i915 DG1 uAPI

2021-04-14 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 12:47:06PM +0100, Matthew Auld wrote: > Add an entry for the new uAPI needed for DG1. > > v2(Daniel): > - include the overall upstreaming plan > - add a note for mmap, there are differences here for TTM vs i915 > - bunch of other suggestions from Daniel > > Signed-of

Re: [Intel-gfx] [PATCH v2 00/12] drm/i915: Extend GEN renames to the rest of the driver

2021-04-14 Thread Joonas Lahtinen
+ Tvrtko Quoting Jani Nikula (2021-04-14 13:06:42) > On Wed, 14 Apr 2021, Jani Nikula wrote: > > On Tue, 13 Apr 2021, Jani Nikula wrote: > >> On Mon, 12 Apr 2021, Lucas De Marchi wrote: > >>> Like was done for the display part that parted ways with INTEL_GEN(), > >>> replacing with DISPLAY_VER(

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4 URL : https://patchwork.freedesktop.org/series/89055/ State : success == Summary == CI Bug Log - changes from CI_DRM_9967_full -> Patchwork_19932_full ==

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915: finish removal of gen_mask

2021-04-14 Thread Tvrtko Ursulin
On 13/04/2021 06:09, Lucas De Marchi wrote: Now that it's not used anywhere, remove it from struct intel_device_info. To allow a period in which code will be converted to the new macro, keep IS_GEN_RANGE() around, just redefining it to use the new fields. The size advantage from IS_GEN_RANGE()

[Intel-gfx] [RFC 00/28] Old platform/gen kconfig options series

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Triggered by the recent work around INTEL_GEN etc and probably just for historical reference since I can't remember if I ever sent it out. So sending now but unrebased. This series from early 2018 is the reason why I was converting to mask based check everywhere. There was a

[Intel-gfx] [RFC 02/28] drm/i915: Make I845G platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 7 +++ drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i915_pci.c| 4 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.

[Intel-gfx] [RFC 01/28] drm/i915: Make I830 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig | 5 + drivers/gpu/drm/i915/Kconfig.platforms | 6 ++ drivers/gpu/drm/i915/i915_drv.h| 5 - drivers/gpu/drm/i915/i915_pci.c| 4 4 files changed, 19 insertions(+), 1 del

[Intel-gfx] [RFC 03/28] drm/i915: Make I85X platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 7 +++ drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i915_pci.c| 4 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.

[Intel-gfx] [RFC 04/28] drm/i915: Make I865G platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 7 +++ drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i915_pci.c| 4 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.

[Intel-gfx] [RFC 07/28] drm/i915: Make Gen4 platforms support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 35 ++ drivers/gpu/drm/i915/i915_drv.h| 12 + drivers/gpu/drm/i915/i915_pci.c| 16 3 files changed, 58 insertions(+), 5 deletions(-) diff

[Intel-gfx] [RFC 05/28] drm/i915: Make GEN2 support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By adding a hidden Kconfig option selected by all Gen2 platforms, we can eliminate more code when none of those is selected. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 7 +++ drivers/gpu/drm/i915/i915_drv.h| 4 +++- 2 files chang

[Intel-gfx] [RFC 08/28] drm/i915: Make Ironlake/Gen5 platforms support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 11 +++ drivers/gpu/drm/i915/i915_drv.h| 7 +-- drivers/gpu/drm/i915/i915_pci.c| 4 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [RFC 09/28] drm/i915: Make Sandybridge/Gen6 platforms support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 12 drivers/gpu/drm/i915/i915_drv.h| 4 +++- drivers/gpu/drm/i915/i915_pci.c| 6 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [RFC 06/28] drm/i915: Make Gen3 platforms support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 51 ++ drivers/gpu/drm/i915/i915_drv.h| 22 ++- drivers/gpu/drm/i915/i915_pci.c| 28 +- 3 files changed, 90 insertions(+), 11 deletions(-)

[Intel-gfx] [RFC 10/28] drm/i915: Make Gen7/7.5 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 26 ++ drivers/gpu/drm/i915/i915_drv.h| 15 +-- drivers/gpu/drm/i915/i915_pci.c| 14 ++ 3 files changed, 49 insertions(+), 6 deletions(

[Intel-gfx] [RFC 12/28] drm/i915: Make Gen9 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 44 + drivers/gpu/drm/i915/i915_drv.h| 53 +++--- drivers/gpu/drm/i915/i915_pci.c| 22 +++ 3 files changed, 96 insertions(+), 23 deleti

[Intel-gfx] [RFC 14/28] drm/i915: Make Gen11 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 11 +++ drivers/gpu/drm/i915/i915_drv.h| 6 -- drivers/gpu/drm/i915/i915_pci.c| 2 ++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [RFC 11/28] drm/i915: Make Gen8 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 19 +++ drivers/gpu/drm/i915/i915_drv.h| 8 +--- drivers/gpu/drm/i915/i915_pci.c| 8 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/dri

[Intel-gfx] [RFC 15/28] drm/i915: Simplify IS_GEN macros

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 44 +++-- 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index fa5aa0e3a776..4f140e95207e 10064

[Intel-gfx] [RFC 16/28] drm/i915: Use INTEL_GEN everywhere

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Coccinelle patch: @@ identifier p; @@ -INTEL_INFO(p)->gen +INTEL_GEN(p) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- drivers/gpu/

[Intel-gfx] [RFC 17/28] drm/i915: Favour IS_GENx

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace INTEL_GEN (not-)equals with IS_GENx for more optimisation opportunities. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_device_info.c | 4 ++-- drivers/gpu/drm/i915/intel_fbc.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 6 +++--- drive

[Intel-gfx] [RFC 13/28] drm/i915: Make Gen10 platform support optional

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 11 +++ drivers/gpu/drm/i915/i915_drv.h| 6 -- drivers/gpu/drm/i915/i915_pci.c| 4 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [RFC 18/28] drm/i915: Use Gen Kconfig items in IS_GEN macro

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4f140e95207e..0e65e0bc3d09 100644 --

[Intel-gfx] [RFC 20/28] drm/i915: Use IS_GEN in execbuffer

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Stop caching the gen and use the macros to enable compile time optimisation. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbu

[Intel-gfx] [RFC 23/28] drm/i915: Use IS_GEN in intel_bios.c

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_bios.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index aa4df6548771..15c18d24e4e9 100644 --- a/drivers/gpu/

[Intel-gfx] [RFC 21/28] drm/i915: Allow render state to be compiled out

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Makefile| 8 drivers/gpu/drm/i915/i915_gem_render_state.c | 10 -- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/M

[Intel-gfx] [RFC 24/28] drm/i915: Use IS_GEN in intel_fb_pitch_limit

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f7a3cefaaaed..5d1d67a7c368 100644 --- a/

[Intel-gfx] [RFC 22/28] drm/i915: Use IS_GEN in stolen

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_stolen.c | 36 ++ 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c index 0afd50cf71de..4a9

[Intel-gfx] [RFC 25/28] drm/i915: Use IS_GEN in intel_engine_cs.c

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_engine_cs.c | 92 +++--- 1 file changed, 38 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c index 32a1fee719a0..3f9

[Intel-gfx] [RFC 27/28] drm/i915: Use IS_GEN in intel_lrc.c

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 55df19ec879e..63872514213c 100644

[Intel-gfx] [RFC 26/28] drm/i915: Use IS_GEN in intel_guc.c

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_guc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c index 21140ccd7a97..e67283947624 100644 --- a/drivers/gpu/dr

[Intel-gfx] [RFC 28/28] drm/i915: Enable dropping small cores when not enabled

2021-04-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig.platforms | 7 +++ drivers/gpu/drm/i915/i915_drv.h| 8 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/Kconfig.platforms b/drivers/gpu/drm/i915/Kconfig.

[Intel-gfx] [PATCH 1/1] drm/i915/gt: Fix a lockdep warnning on RT kernel

2021-04-14 Thread Jun Miao
Don`t simple disable all the HD-irq, should race the region in the intel_breadcrumbs_disarm_irq() only. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969 #0: 89c4c00ca970 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x1cf/0x6d0 #1: a433c1

Re: [Intel-gfx] [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
Hi Ville, On Tue, 13 Apr 2021 19:59:34 +0300 Ville Syrjälä wrote: > > > On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > > I met below error during boot with i915 builtin if pass > > "i915.mitigations=off": > > [0.015589] Booting kernel: `off' invalid for parameter > > `i9

[Intel-gfx] [PATCH 0/1] drm/i915/gt: Fix a lockdep warnning on RT kernel

2021-04-14 Thread Jun Miao
Hi,all This lockdep warning is only in the RT kernel. Which is introduced by this path:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c?h=v5.12-rc7&id=9d5612ca165a58aacc160465532e7998b9aab270 Fix it. Ju

[Intel-gfx] RT-BUG report: i915/gt/intel_breadcrumbs.c

2021-04-14 Thread jun.miao
kernel version: 5.10-rt BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969 [   57.899678] in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 281, name: kworker/3:3 [   57.899679] 5 locks held by kworker/3:3/281: [   57.899681]  #0: 89c4c00ca970 ((wq_co

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-14 Thread Liu Ying
Hi Daniel, On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > > Since > > > > > > >

[Intel-gfx] [PATCH 1/1] drm/i915/gt: Fix a lockdep warning on RT kernel

2021-04-14 Thread Jun Miao
Don`t simple disable all the HD-irq, should race the region in the intel_breadcrumbs_disarm_irq() only. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969 #0: 89c4c00ca970 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x1cf/0x6d0 #1: a433c1

Re: [Intel-gfx] [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
On Tue, 13 Apr 2021 19:59:34 +0300 Ville Syrjälä wrote: > > On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > > I met below error during boot with i915 builtin if pass > > "i915.mitigations=off": > > [0.015589] Booting kernel: `off' invalid for parameter > > `i915.mitigations

[Intel-gfx] [PATCH 0/1] drm/i915/gt: Fix a lockdep warnning on RT kernel

2021-04-14 Thread Jun Miao
Hi,all This lockdep warning is only in the RT kernel. Which is introduced by this path:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c?h=v5.12-rc7&id=9d5612ca165a58aacc160465532e7998b9aab270 Fix it. Ju

[Intel-gfx] [PATCH v2] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
I met below error during boot with i915 builtin if pass "i915.mitigations=off": [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' The reason is slab subsystem isn't ready at that time, so kstrdup() returns NULL. Fix this issue by using stack var instead of kstrdup(). F

Re: [Intel-gfx] [PATCH] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-14 Thread Pekka Paalanen
On Wed, 14 Apr 2021 11:08:15 +0200 Daniel Vetter wrote: > It's very confusing for userspace to have to deal with inconsistencies > here, and some drivers screwed this up a bit. Most just ommitted the > format list when they meant to say that only linear modifier is > allowed, but some also meant

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly (rev2)

2021-04-14 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/arm: Don't set allow_fb_modifiers explicitly (rev2) URL : https://patchwork.freedesktop.org/series/88999/ State : failure == Summary == Applying: drm/arm: Don't set allow_fb_modifiers explicitly Applying: drm/arm/malidp: Always lis

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Old platform/gen kconfig options series

2021-04-14 Thread Patchwork
== Series Details == Series: Old platform/gen kconfig options series URL : https://patchwork.freedesktop.org/series/89069/ State : failure == Summary == Applying: drm/i915: Make I830 platform support optional Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/Kconfig M

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Fix a lockdep warnning on RT kernel

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix a lockdep warnning on RT kernel URL : https://patchwork.freedesktop.org/series/89070/ State : failure == Summary == Applying: drm/i915/gt: Fix a lockdep warnning on RT kernel error: sha1 information is lacking or useless (drivers/gpu/drm/i915/gt/i

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Fix a lockdep warnning on RT kernel

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix a lockdep warnning on RT kernel URL : https://patchwork.freedesktop.org/series/89071/ State : failure == Summary == Applying: drm/i915/gt: Fix a lockdep warning on RT kernel error: sha1 information is lacking or useless (drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix "mitigations" parsing if i915 is builtin (rev2)

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Fix "mitigations" parsing if i915 is builtin (rev2) URL : https://patchwork.freedesktop.org/series/88998/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function para

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix "mitigations" parsing if i915 is builtin (rev2)

2021-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Fix "mitigations" parsing if i915 is builtin (rev2) URL : https://patchwork.freedesktop.org/series/88998/ State : success == Summary == CI Bug Log - changes from CI_DRM_9971 -> Patchwork_19937 Summary

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915: finish removal of gen_mask

2021-04-14 Thread Jani Nikula
On Wed, 14 Apr 2021, Tvrtko Ursulin wrote: > On 13/04/2021 06:09, Lucas De Marchi wrote: >> Now that it's not used anywhere, remove it from struct >> intel_device_info. To allow a period in which code will be converted to >> the new macro, keep IS_GEN_RANGE() around, just redefining it to use >> t

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915: finish removal of gen_mask

2021-04-14 Thread Tvrtko Ursulin
On 14/04/2021 14:13, Jani Nikula wrote: On Wed, 14 Apr 2021, Tvrtko Ursulin wrote: On 13/04/2021 06:09, Lucas De Marchi wrote: Now that it's not used anywhere, remove it from struct intel_device_info. To allow a period in which code will be converted to the new macro, keep IS_GEN_RANGE() aro

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Create stolen memory region from local memory

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only set

Re: [Intel-gfx] [PATCH 04/19] drm/i915/stolen: treat stolen local as normal local memory

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 05/19] drm/i915/stolen: enforce the min_page_size contract

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Rewrite the FBC tiling check a bit

2021-04-14 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Write the tiling check in a nicer form. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/displ

Re: [Intel-gfx] [PATCH 06/19] drm/i915/stolen: pass the allocation flags

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 10 ++ 1 file changed, 6 in

[Intel-gfx] [PATCH resend 0/9] drm: Add privacy-screen class and connector properties

2021-04-14 Thread Hans de Goede
Hi All, Here is the privacy-screen related code which I last posted in August of last year. To the best of my knowledge there is consensus about / everyone is in agreement with the new userspace API (2 connector properties) this patch-set add (patch 1 of the series). The blocker the last time was

[Intel-gfx] [PATCH resend 2/9] drm: Add privacy-screen class

2021-04-14 Thread Hans de Goede
On some new laptops the LCD panel has a builtin electronic privacy-screen. We want to export this functionality as a property on the drm connector object. But often this functionality is not exposed on the GPU but on some other (ACPI) device. This commit adds a privacy-screen class allowing the dr

[Intel-gfx] [PATCH resend 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-04-14 Thread Hans de Goede
Add X86 specific arch init code, which fills the privacy-screen lookup table by checking for various vendor specific ACPI interfaces for controlling the privacy-screen. This initial version only checks for the Lenovo Thinkpad specific ACPI methods for privacy-screen control. Signed-off-by: Hans d

[Intel-gfx] [PATCH resend 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-04-14 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices where the OS might be lo

[Intel-gfx] [PATCH resend 4/9] drm/privacy-screen: Add notifier support

2021-04-14 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include/drm/drm_privacy_screen_consume

[Intel-gfx] [PATCH resend 5/9] drm/connector: Add a drm_connector privacy-screen helper functions

2021-04-14 Thread Hans de Goede
Add 2 drm_connector privacy-screen helper functions: 1. drm_connector_attach_privacy_screen_provider(), this function creates and attaches the standard privacy-screen properties and registers a generic notifier for generating sysfs-connector-status-events on external changes to the privacy-screen

[Intel-gfx] [PATCH resend 6/9] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

2021-04-14 Thread Hans de Goede
Factor the extended hotkey handling out of hotkey_notify_hotkey() and into a new hotkey_notify_extended_hotkey() helper. This is a preparation patch for adding support the privacy-screen hotkey toggle (which needs some special handling, it should NOT send an evdev key-event to userspace...). Sign

[Intel-gfx] [PATCH resend 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2021-04-14 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/platform/

[Intel-gfx] [PATCH resend 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-04-14 Thread Hans de Goede
Register a privacy-screen device on laptops with a privacy-screen, this exports the PrivacyGuard features to user-space using a standardized vendor-agnostic sysfs interface. Note the sysfs interface is read-only. Registering a privacy-screen device with the new privacy-screen class code will also

[Intel-gfx] [PATCH resend 9/9] drm/i915: Add privacy-screen support

2021-04-14 Thread Hans de Goede
Add support for eDP panels with a built-in privacy screen using the new drm_privacy_screen class. One thing which stands out here is the addition of these 2 lines to intel_atomic_commit_tail: for_each_new_connector_in_state(&state->base, connector, ... drm_connector_update

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Add privacy-screen class and connector properties (rev2)

2021-04-14 Thread Patchwork
== Series Details == Series: drm: Add privacy-screen class and connector properties (rev2) URL : https://patchwork.freedesktop.org/series/79259/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generat

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Return error value when bo not in LMEM for discrete

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: Mohammed Khajapasha Return EREMOTE value when frame buffer object is not backed by LMEM for discrete. If Local memory is supported by hardware the framebuffer backing gem objects should be from local memory. Signed-off-by: Mohammed Khajapasha -

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: Venkata Sandeep Dhanalakota Determine the possible coherent map type based on object location, and if target has llc or if user requires an always coherent mapping. Cc: Matthew Auld Cc: CQ Tang Suggested-by: Michal Wajdeczko Signed-off-by: Ve

Re: [Intel-gfx] [PATCH 12/19] drm/i915/lmem: Bypass aperture when lmem is available

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: From: Anusha Srivatsa In the scenario where local memory is available, we have rely on CPU access via lmem directly instead of aperture. v2: gmch is only relevant for much older hw, therefore we can drop the has_aperture check since it should always be

Re: [Intel-gfx] [PATCH 19/19] drm/i915/gtt/dgfx: place the PD in LMEM

2021-04-14 Thread Tvrtko Ursulin
On 12/04/2021 10:05, Matthew Auld wrote: It's a requirement that for dgfx we place all the paging structures in device local-memory. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 - drivers/gpu/drm/i915/gt/intel_gtt.c | 27 +-- driv

[Intel-gfx] [PATCH 04/11] drm/i915/adl_p: ADL_P device info enabling

2021-04-14 Thread Imre Deak
From: Clinton Taylor Add ADL-P to the device_info table and support MACROS. Bspec: 49185, 55372, 55373 Cc: Matt Atwood Cc: Matt Roper Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- arch/x86/kernel/early-quirks.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 +

[Intel-gfx] [PATCH 02/11] drm/i915/xelpd: add XE_LPD display characteristics

2021-04-14 Thread Imre Deak
From: Matt Roper Let's start preparing for upcoming platforms that will use an XE_LPD design. v2: - Use the now-preferred "XE_LPD" term to refer to this design - Utilize DISPLAY_VER() rather than a feature flag - Drop unused mbus_size field (Lucas) Signed-off-by: Matt Roper --- drivers/gpu

[Intel-gfx] [PATCH 01/11] drm/i915: Pass intel_framebuffer instad of drm_framebuffer to intel_fill_fb_info()

2021-04-14 Thread Imre Deak
Make one step to pass intel_framebuffer to all intel_fb functions. Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fb.c | 63 ++-- drivers/gpu/drm/i915/display/intel_fb.h |

[Intel-gfx] [PATCH 05/11] drm/i915/xelpd: First stab at DPT support

2021-04-14 Thread Imre Deak
From: Ville Syrjälä Add support for DPT (display page table). DPT is a slightly peculiar two level page table scheme used for tiled scanout buffers (linear uses direct ggtt mapping still). The plane surface address will point at a page in the DPT which holds the PTEs for 512 actual pages. Thus we

[Intel-gfx] [PATCH 03/11] drm/i915/adl_p: Add PCI Devices IDs

2021-04-14 Thread Imre Deak
From: Clinton Taylor Add 18 known PCI device IDs Bspec: 55376 Cc: Caz Yokoyama Cc: Matt Atwood Cc: Matt Roper Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper Reviewed-by: Anusha Srivatsa --- include/drm/i915_pciids.h | 21 + 1 file changed, 21 insertions(+) di

[Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-14 Thread Imre Deak
Alder Lake-P adds a new Display Page Table hardware structure, mapping tiled framebuffer pages to the display engine, reducing the address space required in GGTT for these framebuffers. This patchset adds support for this taking a minimum set of dependency patches from the ADL_P enabling patchset

[Intel-gfx] [PATCH 06/11] drm/i915/xelpd: Fallback to plane stride limitations when using DPT

2021-04-14 Thread Imre Deak
From: José Roberto de Souza GTT remapping allow us to have planes with strides larger than HW supports but DPT + GTT remapping is still not properly handled so falling back to plane HW limitations for now. This patch can be dropped when DPT + GTT remapping is correctly handled but until then we

  1   2   >