[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission URL : https://patchwork.freedesktop.org/series/86603/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9720 -> Patchwork_19567

[Intel-gfx] [PATCH] drm/i915/gt: Move CS interrupt handler to the backend

2021-02-03 Thread Chris Wilson
The different submission backends each have their own preferred behaviour and interrupt setup. Let each handle their own interrupts. This becomes more useful later as we to extract the use of auxiliary state in the interrupt handler that is backend specific. v2: An overabundance of caution is alw

[Intel-gfx] [PATCH] drm/i915: Apply VT-d scanout adjustment to the VMA

2021-02-03 Thread Chris Wilson
Currently, we allocate exactly the VMA requested for the framebuffer and rely on filling the whole of the GGTT with scratch pages to catch when VT-d prefetches beyond the bounds of the surface. However, this means that we have to scrub the GGTT on startup and resume, and on recent HW this is made e

Re: [Intel-gfx] [PATCH] drm/i915: Apply VT-d scanout adjustment to the VMA

2021-02-03 Thread Ville Syrjälä
On Wed, Feb 03, 2021 at 08:38:41AM +, Chris Wilson wrote: > Currently, we allocate exactly the VMA requested for the framebuffer and > rely on filling the whole of the GGTT with scratch pages to catch when > VT-d prefetches beyond the bounds of the surface. However, this means > that we have to

[Intel-gfx] [CI 1/8] drm/i915/selftests: Set cache status for huge_gem_object

2021-02-03 Thread Chris Wilson
Set the cache coherency and status using the set-coherency helper. Otherwise, we forget to mark the new pages as cache dirty. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 14 +- 1 file changed, 5 insertions(+), 9 deletio

[Intel-gfx] [CI 3/8] drm/i915/selftests: Replace the unbounded set-domain with an explicit wait

2021-02-03 Thread Chris Wilson
After running client_blt, we flush the object by changing its domain. This causes us to wait forever instead of an bounded wait suitable for the selftest timeout. So do an explicit wait with a suitable timeout -- which in turn means we have to limit the size of the object/blit to run within reason.

[Intel-gfx] [CI 6/8] drm/i915/selftests: Replace an unbounded set-domain wait with a timeout

2021-02-03 Thread Chris Wilson
After the memory-region test completes, it flushes the test by calling set-to-cpu-domain. Use the igt_flush_test as it includes a timeout, recovery and reports and error for miscreant tests. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/selftests/intel_memory_re

[Intel-gfx] [CI 2/8] drm/i915/selftests: Use a coherent map to setup scratch batch buffers

2021-02-03 Thread Chris Wilson
Instead of manipulating the object's cache domain, just use the device coherent map to write the batch buffer. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- .../drm/i915/gem/selftests/i915_gem_context.c| 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff

[Intel-gfx] [CI 8/8] drm/i915/gem: Manage all set-domain waits explicitly

2021-02-03 Thread Chris Wilson
Only perform the domain transition under the object lock, and push the required waits to outside the lock. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 9 +- drivers/gpu/drm/i915/gem/i915_gem_clflush.h | 2 - drivers/gpu/drm/i91

[Intel-gfx] [CI 5/8] drm/i915/selftests: Replace unbound set-domain waits with explicit timeouts

2021-02-03 Thread Chris Wilson
Let's prefer to use explicit request tracking and bounded timeouts in our selftests. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- .../gpu/drm/i915/gt/selftest_workarounds.c| 106 +++--- 1 file changed, 40 insertions(+), 66 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [CI 7/8] drm/i915/selftests: Remove redundant set-to-gtt-domain before batch submission

2021-02-03 Thread Chris Wilson
In construction the rpcs_query batch we know that it is device coherent and ready for execution, the set-to-gtt-domain here is redudant. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 -- 1 file changed, 2 deletions(-) diff -

[Intel-gfx] [CI 4/8] drm/i915/selftests: Remove redundant set-to-gtt-domain

2021-02-03 Thread Chris Wilson
Since the vma's backing store is flushed upon first creation, remove the manual calls to set-to-gtt-domain. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- .../gpu/drm/i915/gem/selftests/i915_gem_mman.c | 16 drivers/gpu/drm/i915/selftests/i915_vma.c| 6 ---

[Intel-gfx] [PATCH] drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA

2021-02-03 Thread Anand Moon
As per Bspec: 53655 Update PCI ids for Mobile BGA. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Anand Moon diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index ebd0dd1c35b3..3be25768321d 100644 --- a/include/drm/i

Re: [Intel-gfx] [PATCH] drm/i915: Apply VT-d scanout adjustment to the VMA

2021-02-03 Thread Chris Wilson
Quoting Ville Syrjälä (2021-02-03 09:00:54) > On Wed, Feb 03, 2021 at 08:38:41AM +, Chris Wilson wrote: > > Currently, we allocate exactly the VMA requested for the framebuffer and > > rely on filling the whole of the GGTT with scratch pages to catch when > > VT-d prefetches beyond the bounds o

[Intel-gfx] [PATCH] drm/i915: Reject 446-480MHz HDMI clock on GLK

2021-02-03 Thread Ville Syrjala
From: Ville Syrjälä The BXT/GLK DPLL can't generate certain frequencies. We already reject the 233-240MHz range on both. But on GLK the DPLL max frequency was bumped from 300MHz to 594MHz, so now we get to also worry about the 446-480MHz range (double the original problem range). Reject any frequ

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission (rev2)

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission (rev2) URL : https://patchwork.freedesktop.org/series/86603/ State : success == Summary == CI Bug Log - changes from CI_DRM_9721 -> Patchwork_19568 =

Re: [Intel-gfx] [PATCH 1/3] i915/perf: Store a mask of valid OA formats for a platform

2021-02-03 Thread Lionel Landwerlin
On 02/02/2021 09:54, Umesh Nerlige Ramappa wrote: Validity of an OA format is checked by using a sparse array of formats per gen. Instead maintain a mask of supported formats for a platform in the perf object. Signed-off-by: Umesh Nerlige Ramappa Nice cleanup : Reviewed-by: Lionel Landwerlin

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel-fixes tree

2021-02-03 Thread Jani Nikula
On Wed, 03 Feb 2021, Stephen Rothwell wrote: > Hi all, > > Commit > > 44c5bd08518c ("*** HAX FOR CI *** Revert "rtc: mc146818: Detect and handle > broken RTCs"") > > is missing a Signed-off-by from its author and committer. > > Reverts are commits as well. It's a hack on top of the tree to unb

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Lift marking a lock as used to utils

2021-02-03 Thread Thomas Hellström
On Tue, 2021-02-02 at 15:43 +, Chris Wilson wrote: > After calling lock_set_subclass() the lock _must_ be used, or else > lockdep's internal nr_used_locks becomes unbalanced. Extract the > little > utility function to i915_utils.c > > Signed-off-by: Chris Wilson > Cc: Thomas Hellström > ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Apply VT-d scanout adjustment to the VMA

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Apply VT-d scanout adjustment to the VMA URL : https://patchwork.freedesktop.org/series/86625/ State : success == Summary == CI Bug Log - changes from CI_DRM_9721 -> Patchwork_19569 Summary ---

Re: [Intel-gfx] [RFC PATCH 0/9] cgroup support for GPU devices

2021-02-03 Thread Daniel Vetter
On Mon, Feb 01, 2021 at 03:21:35PM -0800, Brian Welty wrote: > > On 1/28/2021 7:00 PM, Xingyou Chen wrote: > > On 2021/1/27 上午5:46, Brian Welty wrote: > > > >> We'd like to revisit the proposal of a GPU cgroup controller for managing > >> GPU devices but with just a basic set of controls. This s

[Intel-gfx] [PATCH i-g-t] intel_gpu_top: Always sort the clients array after update

2021-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Walking the client "list" makes assumptions about the order of active and free slots which means we need to sort the array after every update. Patch is mostly just code movement with the only functional difference of eliminating two subsequent scans with no sort in between T

Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Wrap interactive header

2021-02-03 Thread Tvrtko Ursulin
On 01/02/2021 12:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-01 11:57:56) From: Tvrtko Ursulin Slight improvement with regards to wrapping header components to fit console width. If a single element is wider than max it can still overflow but it should now work better for practic

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/8] drm/i915/selftests: Set cache status for huge_gem_object

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/8] drm/i915/selftests: Set cache status for huge_gem_object URL : https://patchwork.freedesktop.org/series/86626/ State : success == Summary == CI Bug Log - changes from CI_DRM_9721 -> Patchwork_19570

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Wrap interactive header

2021-02-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-03 10:31:04) > > On 01/02/2021 12:07, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-01 11:57:56) > >> From: Tvrtko Ursulin > >> > >> Slight improvement with regards to wrapping header components to fit > >> console width. If a single element is wider than

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Always sort the clients array after update

2021-02-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-03 10:26:01) > From: Tvrtko Ursulin > > Walking the client "list" makes assumptions about the order of active and > free slots which means we need to sort the array after every update. > > Patch is mostly just code movement with the only functional difference of >

[Intel-gfx] [PATCH][next] drm/i915/display: fix spelling mistake "Couldnt" -> "Couldn't"

2021-02-03 Thread Colin King
From: Colin Ian King There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/i

[Intel-gfx] [CI 07/12] drm/i915/selftests: Exercise priority inheritance around an engine loop

2021-02-03 Thread Chris Wilson
Exercise rescheduling priority inheritance around a sequence of requests that wrap around all the engines. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../gpu/drm/i915/selftests/i915_scheduler.c | 215 ++ 1 file changed, 215 insertions(+) diff --git a/drivers/

[Intel-gfx] [CI 12/12] drm/i915: Extract the ability to defer and rerun a request later

2021-02-03 Thread Chris Wilson
Lift the ability to defer a request until later from execlists into the common layer. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execlists_submission.c | 57 +++-- drivers/gpu/drm/i915/i915_scheduler.c | 63 +-- drivers

[Intel-gfx] [CI 01/12] drm/i915/gt: Move engine setup out of set_default_submission

2021-02-03 Thread Chris Wilson
Now that we no longer switch back and forth between guc and execlists, we no longer need to restore the backend's vfunc and can leave them set after initialisation. The only catch is that we lose the submission on wedging and still need to reset the submit_request vfunc on unwedging. Signed-off-by

[Intel-gfx] [CI 08/12] drm/i915: Improve DFS for priority inheritance

2021-02-03 Thread Chris Wilson
The core of the scheduling algorithm is that we compute the topological order of the fence DAG. Knowing that we have a DAG, we should be able to use a DFS to compute the topological sort in linear time. However, during the conversion of the recursive algorithm into an iterative one, the memoization

[Intel-gfx] [CI 09/12] drm/i915: Extract request submission from execlists

2021-02-03 Thread Chris Wilson
In the process of preparing to reuse the request submission logic for other backends, lift it out of the execlists backend. It already operates on the common structs, so just a matter of moving and renaming. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execl

[Intel-gfx] [CI 05/12] drm/i915: Restructure priority inheritance

2021-02-03 Thread Chris Wilson
In anticipation of wanting to be able to call pi from underneath an engine's active.lock, rework the priority inheritance to primarily work along an engine's priority queue, delegating any other engine that the chain may traverse to a worker. This reduces the global spinlock from governing the enti

[Intel-gfx] [CI 10/12] drm/i915: Extract request rewinding from execlists

2021-02-03 Thread Chris Wilson
In the process of preparing to reuse the request submission logic for other backends, lift it out of the execlists backend. While this operates on the common structs, we do have a bit of backend knowledge, which is harmless for !lrc but still unsightly. Signed-off-by: Chris Wilson Reviewed-by: T

[Intel-gfx] [CI 06/12] drm/i915/selftests: Measure set-priority duration

2021-02-03 Thread Chris Wilson
As a topological sort, we expect it to run in linear graph time, O(V+E). In removing the recursion, it is no longer a DFS but rather a BFS, and performs as O(VE). Let's demonstrate how bad this is with a few examples, and build a few test cases to verify a potential fix. Signed-off-by: Chris Wilso

[Intel-gfx] [CI 03/12] drm/i915/gt: Move CS interrupt handler to the backend

2021-02-03 Thread Chris Wilson
The different submission backends each have their own preferred behaviour and interrupt setup. Let each handle their own interrupts. This becomes more useful later as we to extract the use of auxiliary state in the interrupt handler that is backend specific. v2: An overabundance of caution is alw

[Intel-gfx] [CI 11/12] drm/i915: Extract request suspension from the execlists

2021-02-03 Thread Chris Wilson
Make the ability to suspend and resume a request and its dependents generic. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execlists_submission.c | 167 +- drivers/gpu/drm/i915/gt/selftest_execlists.c | 8 +- drivers/gpu/drm/i915/i915_sche

[Intel-gfx] [CI 04/12] drm/i915: Replace engine->schedule() with a known request operation

2021-02-03 Thread Chris Wilson
Looking to the future, we want to set the scheduling attributes explicitly and so replace the generic engine->schedule() with the more direct i915_request_set_priority() What it loses in removing the 'schedule' name from the function, it gains in having an explicit entry point with a stated goal.

[Intel-gfx] [CI 02/12] drm/i915/gt: Move submission_method into intel_gt

2021-02-03 Thread Chris Wilson
Since we setup the submission method for the engines once, it is easy to assign an enum and use that instead of probing into the backends. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine.h | 8 +++- drivers/gpu/drm/i915/gt/inte

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission (rev2)

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/gt: Move engine setup out of set_default_submission (rev2) URL : https://patchwork.freedesktop.org/series/86603/ State : success == Summary == CI Bug Log - changes from CI_DRM_9721_full -> Patchwork_19568_full ===

Re: [Intel-gfx] [PATCH] drm/i915: Disable runtime power management during shutdown

2021-02-03 Thread Ville Syrjälä
On Thu, Jan 28, 2021 at 09:13:49PM +0200, Imre Deak wrote: > On Wed, Jan 27, 2021 at 08:19:09PM +0200, Imre Deak wrote: > > At least on some TGL platforms PUNIT wants to access some display HW > > registers, but it doesn't handle display power managment (disabling DC > > states as required) and so

Re: [Intel-gfx] [PATCH] drm/i915/rkl: Remove require_force_probe protection

2021-02-03 Thread Chris Wilson
Quoting Tejas Upadhyay (2020-11-30 12:48:55) > Removing force probe protection from RKL platform. Did > not observe warnings, errors, flickering or any visual > defects while doing ordinary tasks like browsing and > editing documents in a two monitor setup. > > Signed-off-by: Tejas Upadhyay We n

[Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Add option to sort by PID

2021-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Useful to mimick top view. Signed-off-by: Tvrtko Ursulin --- man/intel_gpu_top.rst | 2 +- tools/intel_gpu_top.c | 46 +++ 2 files changed, 34 insertions(+), 14 deletions(-) diff --git a/man/intel_gpu_top.rst b/man/intel_gpu_top.rs

[Intel-gfx] [PATCH i-g-t 1/2] intel_gpu_top: Show banner messages when cycling sort modes

2021-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is useful to let the user know what is the currently active sort mode. Signed-off-by: Tvrtko Ursulin --- tools/intel_gpu_top.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 584aa2

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] intel_gpu_top: Show banner messages when cycling sort modes

2021-02-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-03 11:44:55) > From: Tvrtko Ursulin > > It is useful to let the user know what is the currently active sort mode. > > Signed-off-by: Tvrtko Ursulin > --- > tools/intel_gpu_top.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff -

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] intel_gpu_top: Show banner messages when cycling sort modes

2021-02-03 Thread Tvrtko Ursulin
On 03/02/2021 11:47, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-03 11:44:55) From: Tvrtko Ursulin It is useful to let the user know what is the currently active sort mode. Signed-off-by: Tvrtko Ursulin --- tools/intel_gpu_top.c | 15 +-- 1 file changed, 13 insertion

Re: [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: Add option to sort by PID

2021-02-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-03 11:44:56) > From: Tvrtko Ursulin > > Useful to mimick top view. > > Signed-off-by: Tvrtko Ursulin > --- > man/intel_gpu_top.rst | 2 +- > tools/intel_gpu_top.c | 46 +++ > 2 files changed, 34 insertions(+), 14 deletion

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Apply VT-d scanout adjustment to the VMA

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Apply VT-d scanout adjustment to the VMA URL : https://patchwork.freedesktop.org/series/86625/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9721_full -> Patchwork_19569_full Summary -

[Intel-gfx] [PATCH 2/4] drm/i915/gtt/dg1: add PTE_LM plumbing for ppGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. v2: just use gen8_pte_encode for dg1 Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Venkata Sandeep Dhanalakota --

[Intel-gfx] [PATCH 3/4] drm/i915/gtt: make ggtt.insert_page depend on mappable aperture

2021-02-03 Thread Matthew Auld
The vm insert_page is useful to insert a vma-less page into the GGTT, which so far is always to map something through the mappable aperture, usually when the entire VMA doesn't fit, or if we specifically don't want to hog it, since it's generally quite limited in size. On platforms including DG1 t

[Intel-gfx] [PATCH 1/4] drm/i915: Distinction of memory regions

2021-02-03 Thread Matthew Auld
From: Zbigniew Kempczyński In preparation for Xe HP multi-tile architecture with multiple memory regions, we need to be able differentiate multiple instances of device local-memory. Signed-off-by: Zbigniew Kempczyński Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH 4/4] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. Based on a patch from Michel Thierry. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 19 --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gtt: make ggtt.insert_page depend on mappable aperture

2021-02-03 Thread Chris Wilson
Quoting Matthew Auld (2021-02-03 12:11:18) > The vm insert_page is useful to insert a vma-less page into the GGTT, > which so far is always to map something through the mappable aperture, > usually when the entire VMA doesn't fit, or if we specifically don't > want to hog it, since it's generally q

[Intel-gfx] [PATCH] drm/i915: Prevent waiting inside ring construction for critical sections

2021-02-03 Thread Chris Wilson
>From some contexts, we may not be allowed to wait during request construction. For example, in the powermanagement handler that should never block (as the engine was idle) and the driver would be crippled if we did. Similarly, the user may request that the execbuf does not block, and so would pref

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/8] drm/i915/selftests: Set cache status for huge_gem_object

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/8] drm/i915/selftests: Set cache status for huge_gem_object URL : https://patchwork.freedesktop.org/series/86626/ State : success == Summary == CI Bug Log - changes from CI_DRM_9721_full -> Patchwork_19570_full ==

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Wrap interactive header

2021-02-03 Thread Tvrtko Ursulin
On 03/02/2021 11:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-03 10:31:04) On 01/02/2021 12:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-01 11:57:56) From: Tvrtko Ursulin Slight improvement with regards to wrapping header components to fit console width. If a single

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Distinction of memory regions

2021-02-03 Thread Joonas Lahtinen
Quoting Matthew Auld (2021-02-03 14:11:16) > From: Zbigniew Kempczyński > > In preparation for Xe HP multi-tile architecture with multiple memory > regions, we need to be able differentiate multiple instances of device > local-memory. Would be good to comment here on where this name is used, and

Re: [Intel-gfx] [RFC PATCH 7/9] drmcg: Add initial support for tracking gpu time usage

2021-02-03 Thread Joonas Lahtinen
Quoting Brian Welty (2021-01-26 23:46:24) > Single control below is added to DRM cgroup controller in order to track > user execution time for GPU devices. It is up to device drivers to > charge execution time to the cgroup via drm_cgroup_try_charge(). > > sched.runtime > Read-only value,

[Intel-gfx] [PATCH v2 2/3] drm/i915/gtt/dg1: add PTE_LM plumbing for ppGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. v2: just use gen8_pte_encode for dg1 Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Venkata Sandeep Dhanalakota --

[Intel-gfx] [PATCH v2 1/3] drm/i915: Distinction of memory regions

2021-02-03 Thread Matthew Auld
From: Zbigniew Kempczyński In preparation for Xe HP multi-tile architecture with multiple memory regions, we need to be able differentiate multiple instances of device local-memory. Note that the region name is just to give it a human friendly identifier, instead of using class/instance which al

[Intel-gfx] [PATCH v2 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. Based on a patch from Michel Thierry. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 23 ++- drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/gtt/dg1: add PTE_LM plumbing for ppGTT

2021-02-03 Thread Chris Wilson
Quoting Matthew Auld (2021-02-03 14:13:12) > For the PTEs we get an LM bit, to signal whether the page resides in > SMEM or LMEM. > > v2: just use gen8_pte_encode for dg1 > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Niranjana Vi

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Chris Wilson
Quoting Matthew Auld (2021-02-03 14:13:13) > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h > b/drivers/gpu/drm/i915/gt/intel_gtt.h > index 4a1d9b5cc75b..55873663d37f 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gtt.h > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.h > @@ -85,7 +85,8 @@ typedef u64 ge

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Distinction of memory regions

2021-02-03 Thread Chris Wilson
Quoting Matthew Auld (2021-02-03 14:13:11) > From: Zbigniew Kempczyński > > In preparation for Xe HP multi-tile architecture with multiple memory > regions, we need to be able differentiate multiple instances of device > local-memory. > > Note that the region name is just to give it a human frie

[Intel-gfx] [PATCH v2] drm/i915: Prevent waiting inside ring construction for critical sections

2021-02-03 Thread Chris Wilson
>From some contexts, we may not be allowed to wait during request construction. For example, in the powermanagement handler that should never block (as the engine was idle) and the driver would be crippled if we did. Similarly, the user may request that the execbuf does not block, and so would pref

[Intel-gfx] [PATCH v3] drm/i915: Prevent waiting inside ring construction for critical sections

2021-02-03 Thread Chris Wilson
>From some contexts, we may not be allowed to wait during request construction. For example, in the powermanagement handler that should never block (as the engine was idle) and the driver would be crippled if we did. Similarly, the user may request that the execbuf does not block, and so would pref

[Intel-gfx] [PATCH v3 1/3] drm/i915: Distinction of memory regions

2021-02-03 Thread Matthew Auld
From: Zbigniew Kempczyński In preparation for Xe HP multi-tile architecture with multiple memory regions, we need to be able differentiate multiple instances of device local-memory. Note that the region name is just to give it a human friendly identifier, instead of using class/instance which al

[Intel-gfx] [PATCH v3 2/3] drm/i915/gtt/dg1: add PTE_LM plumbing for ppGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. v2: just use gen8_pte_encode for dg1 Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Venkata Sandeep Dhanalakota Re

[Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. Based on a patch from Michel Thierry. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 24 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA URL : https://patchwork.freedesktop.org/series/86627/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19571 Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Disable runtime power management during shutdown

2021-02-03 Thread Imre Deak
On Wed, Feb 03, 2021 at 01:40:05PM +0200, Ville Syrjälä wrote: > On Thu, Jan 28, 2021 at 09:13:49PM +0200, Imre Deak wrote: > > On Wed, Jan 27, 2021 at 08:19:09PM +0200, Imre Deak wrote: > > > At least on some TGL platforms PUNIT wants to access some display HW > > > registers, but it doesn't handl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject 446-480MHz HDMI clock on GLK

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Reject 446-480MHz HDMI clock on GLK URL : https://patchwork.freedesktop.org/series/86631/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19572 Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: fix spelling mistake "Couldnt" -> "Couldn't"

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915/display: fix spelling mistake "Couldnt" -> "Couldn't" URL : https://patchwork.freedesktop.org/series/86637/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19573 Summary

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Tang, CQ
> -Original Message- > From: Intel-gfx On Behalf Of > Matthew Auld > Sent: Wednesday, February 3, 2021 7:24 AM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson > Subject: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing > for GGTT > > For the PTEs we get an LM

[Intel-gfx] [CI 4/9] drm/i915/selftests: Exercise priority inheritance around an engine loop

2021-02-03 Thread Chris Wilson
Exercise rescheduling priority inheritance around a sequence of requests that wrap around all the engines. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../gpu/drm/i915/selftests/i915_scheduler.c | 215 ++ 1 file changed, 215 insertions(+) diff --git a/drivers/

[Intel-gfx] [CI 1/9] drm/i915: Replace engine->schedule() with a known request operation

2021-02-03 Thread Chris Wilson
Looking to the future, we want to set the scheduling attributes explicitly and so replace the generic engine->schedule() with the more direct i915_request_set_priority() What it loses in removing the 'schedule' name from the function, it gains in having an explicit entry point with a stated goal.

[Intel-gfx] [CI 9/9] drm/i915: Extract the ability to defer and rerun a request later

2021-02-03 Thread Chris Wilson
Lift the ability to defer a request until later from execlists into the common layer. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execlists_submission.c | 57 +++-- drivers/gpu/drm/i915/i915_scheduler.c | 63 +-- drivers

[Intel-gfx] [CI 8/9] drm/i915: Extract request suspension from the execlists

2021-02-03 Thread Chris Wilson
Make the ability to suspend and resume a request and its dependents generic. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execlists_submission.c | 167 +- drivers/gpu/drm/i915/gt/selftest_execlists.c | 8 +- drivers/gpu/drm/i915/i915_sche

[Intel-gfx] [CI 6/9] drm/i915: Extract request submission from execlists

2021-02-03 Thread Chris Wilson
In the process of preparing to reuse the request submission logic for other backends, lift it out of the execlists backend. It already operates on the common structs, so just a matter of moving and renaming. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execl

[Intel-gfx] [CI 2/9] drm/i915: Restructure priority inheritance

2021-02-03 Thread Chris Wilson
In anticipation of wanting to be able to call pi from underneath an engine's active.lock, rework the priority inheritance to primarily work along an engine's priority queue, delegating any other engine that the chain may traverse to a worker. This reduces the global spinlock from governing the enti

[Intel-gfx] [CI 3/9] drm/i915/selftests: Measure set-priority duration

2021-02-03 Thread Chris Wilson
As a topological sort, we expect it to run in linear graph time, O(V+E). In removing the recursion, it is no longer a DFS but rather a BFS, and performs as O(VE). Let's demonstrate how bad this is with a few examples, and build a few test cases to verify a potential fix. Signed-off-by: Chris Wilso

[Intel-gfx] [CI 5/9] drm/i915: Improve DFS for priority inheritance

2021-02-03 Thread Chris Wilson
The core of the scheduling algorithm is that we compute the topological order of the fence DAG. Knowing that we have a DAG, we should be able to use a DFS to compute the topological sort in linear time. However, during the conversion of the recursive algorithm into an iterative one, the memoization

[Intel-gfx] [CI 7/9] drm/i915: Extract request rewinding from execlists

2021-02-03 Thread Chris Wilson
In the process of preparing to reuse the request submission logic for other backends, lift it out of the execlists backend. While this operates on the common structs, we do have a bit of backend knowledge, which is harmless for !lrc but still unsightly. Signed-off-by: Chris Wilson Reviewed-by: T

Re: [Intel-gfx] [PATCH] drm/i915: Prevent waiting inside ring construction for critical sections

2021-02-03 Thread kernel test robot
'--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Prevent-waiting-inside-ring-construction-for-critical-sections/20210203-204914 base: git://anongit.freedesktop.org/drm-intel for-linux-next conf

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel_gpu_top: Wrap interactive header

2021-02-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2021-02-03 13:12:05) > > On 03/02/2021 11:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-03 10:31:04) > >> > >> On 01/02/2021 12:07, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2021-02-01 11:57:56) > From: Tvrtko Ursulin > > Slight improve

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
On Wed, 3 Feb 2021 at 16:51, Tang, CQ wrote: > > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Matthew Auld > > Sent: Wednesday, February 3, 2021 7:24 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson > > Subject: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1:

[Intel-gfx] [PATCH v4 1/3] drm/i915: Distinction of memory regions

2021-02-03 Thread Matthew Auld
From: Zbigniew Kempczyński In preparation for Xe HP multi-tile architecture with multiple memory regions, we need to be able differentiate multiple instances of device local-memory. Note that the region name is just to give it a human friendly identifier, instead of using class/instance which al

[Intel-gfx] [PATCH v4 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. Based on a patch from Michel Thierry. BSpec: 45015 Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 24

[Intel-gfx] [PATCH v4 2/3] drm/i915/gtt/dg1: add PTE_LM plumbing for ppGTT

2021-02-03 Thread Matthew Auld
For the PTEs we get an LM bit, to signal whether the page resides in SMEM or LMEM. BSpec: 45040 v2: just use gen8_pte_encode for dg1 Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Venkata Sandeep D

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,01/12] drm/i915/gt: Move engine setup out of set_default_submission

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915/gt: Move engine setup out of set_default_submission URL : https://patchwork.freedesktop.org/series/86639/ State : failure == Summary == Applying: drm/i915/gt: Move engine setup out of set_default_submission Using index info

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Prevent waiting inside ring construction for critical sections (rev3)

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Prevent waiting inside ring construction for critical sections (rev3) URL : https://patchwork.freedesktop.org/series/86644/ State : warning == Summary == $ dim checkpatch origin/drm-tip c2a787bb37c7 drm/i915: Prevent waiting inside ring construction for

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Prevent waiting inside ring construction for critical sections (rev3)

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Prevent waiting inside ring construction for critical sections (rev3) URL : https://patchwork.freedesktop.org/series/86644/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19575 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation URL : https://patchwork.freedesktop.org/series/86656/ State : warning == Summary == $ dim checkpatch origin/drm-tip 836be19c8de4 drm/i915: Replace engine->schedule()

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation URL : https://patchwork.freedesktop.org/series/86656/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each com

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Tang, CQ
> -Original Message- > From: Matthew Auld > Sent: Wednesday, February 3, 2021 9:03 AM > To: Tang, CQ > Cc: Auld, Matthew ; intel- > g...@lists.freedesktop.org; Chris Wilson > Subject: Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM > plumbing for GGTT > > On Wed, 3 Feb 20

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915: Replace engine->schedule() with a known request operation URL : https://patchwork.freedesktop.org/series/86656/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19576 =

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

2021-02-03 Thread Matthew Auld
On Wed, 3 Feb 2021 at 18:01, Tang, CQ wrote: > > > > > -Original Message- > > From: Matthew Auld > > Sent: Wednesday, February 3, 2021 9:03 AM > > To: Tang, CQ > > Cc: Auld, Matthew ; intel- > > g...@lists.freedesktop.org; Chris Wilson > > Subject: Re: [Intel-gfx] [PATCH v3 3/3] drm/i91

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915: Distinction of memory regions

2021-02-03 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: Distinction of memory regions URL : https://patchwork.freedesktop.org/series/86658/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725 -> Patchwork_19577

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915/adl_s: ADL-S platform Update PCI ids for Mobile BGA URL : https://patchwork.freedesktop.org/series/86627/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725_full -> Patchwork_19571_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reject 446-480MHz HDMI clock on GLK

2021-02-03 Thread Patchwork
== Series Details == Series: drm/i915: Reject 446-480MHz HDMI clock on GLK URL : https://patchwork.freedesktop.org/series/86631/ State : success == Summary == CI Bug Log - changes from CI_DRM_9725_full -> Patchwork_19572_full Summary --

  1   2   >