Re: [Intel-gfx] [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!

2021-01-20 Thread Lee Jones
On Tue, 19 Jan 2021, Zack Rusin wrote: > > > > On Jan 19, 2021, at 03:29, Lee Jones wrote: > > > > On Mon, 18 Jan 2021, Daniel Vetter wrote: > > > >> On Mon, Jan 18, 2021 at 03:09:45PM +, Lee Jones wrote: > >>> On Mon, 18 Jan 2021, Daniel Vetter wrote: > >>> > On Fri, Jan 15, 2021 a

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check for all subplatform bits

2021-01-20 Thread Tvrtko Ursulin
On 20/01/2021 01:21, Umesh Nerlige Ramappa wrote: Current code is checking only 2 bits in the subplatform, but actually 3 bits are allocated for the field. Check all 3 bits. Fixes: 805446c8347c9 (drm/i915: Introduce concept of a sub-platform) Cc: Tvrtko Ursulin Signed-off-by: Umesh Nerlige Ra

Re: [Intel-gfx] [PATCH] drm/i915/gt: Close race between enable_breadcrumbs and cancel_breadcrumbs

2021-01-20 Thread Tvrtko Ursulin
On 19/01/2021 16:20, Chris Wilson wrote: If we enable_breadcrumbs for a request while that request is being removed from HW; we may see that the request is active as we take the ce->signal_lock and proceed to attach the request to ce->signals. However, during unsubmission after marking the requ

[Intel-gfx] [PATCH v12 1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Gwan-gyeong Mun
It is a preliminary work for supporting multiple EDP PSR and DP PanelReplay. And it refactors singleton PSR to Multi Transcoder supportable PSR. And this moves and renames the i915_psr structure of drm_i915_private's to intel_dp's intel_psr structure. It also causes changes in PSR interrupt handlin

[Intel-gfx] [PATCH v12 2/2] drm/i915/display: Support Multiple Transcoders' PSR status on debugfs

2021-01-20 Thread Gwan-gyeong Mun
In order to support the PSR state of each transcoder, it adds i915_psr_status to sub-directory of each transcoder. v2: Change using of Symbolic permissions 'S_IRUGO' to using of octal permissions '0444' v5: Addressed JJani Nikula's review comments - Remove checking of Gen12 for i915_psr_statu

[Intel-gfx] ✓ Fi.CI.IGT: success for x86/gpu: add JSL stolen memory support (rev2)

2021-01-20 Thread Patchwork
== Series Details == Series: x86/gpu: add JSL stolen memory support (rev2) URL : https://patchwork.freedesktop.org/series/85983/ State : success == Summary == CI Bug Log - changes from CI_DRM_9647_full -> Patchwork_19418_full Summary --

Re: [Intel-gfx] [PATCH] drm/syncobj: Fix use-after-free

2021-01-20 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 02:08:12PM +0100, Christian König wrote: > Am 19.01.21 um 14:03 schrieb Daniel Vetter: > > While reviewing Christian's annotation patch I noticed that we have a > > user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj > > reference before we've completed the wai

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/hdcp: Fix uninitialized symbol

2021-01-20 Thread Nautiyal, Ankit K
On 1/19/2021 12:16 PM, Anshuman Gupta wrote: Move (num_hdcp_streams > 0) condition to stream_encryption() code block, where it actually belongs. This fixes the static analysis error of uninitialized symbol 'ret'. Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/displ

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/selftests: Exercise relative mmio paths to non-privileged registers

2021-01-20 Thread Chris Wilson
Quoting Matt Roper (2021-01-19 18:01:54) > On Thu, Jan 14, 2021 at 10:38:21AM +, Chris Wilson wrote: > > Verify that context isolation is also preserved when accessing > > context-local registers with relative-mmio commands. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH v2] [v2] x86/gpu: add JSL stolen memory support

2021-01-20 Thread Surendrakumar Upadhyay, TejaskumarX
Similar patch is already under review with x86 maintainers which I sent 1 month ago. Let that patch get done with review then we will not need this. Thanks, Tejas > -Original Message- > From: Intel-gfx On Behalf Of > William Tseng > Sent: 20 January 2021 12:30 > To: intel-gfx@lists.free

[Intel-gfx] [PATCH 2/4] drm/i915/pps: move pps code over from intel_display.c and refactor

2021-01-20 Thread Jani Nikula
intel_display.c has some pps functions that belong to intel_pps.c. Move them over. While at it, refactor the duplicate intel_pps_init() in intel_display.c into an orthogonal intel_pps_setup() in intel_pps.c, and call it earlier in intel_modeset_init_nogem(). Reviewed-by: Anshuman Gupta Signed-of

[Intel-gfx] [PATCH 1/4] drm/i915/pps: refactor init abstractions

2021-01-20 Thread Jani Nikula
Once you realize there is no need to hold the pps mutex when calling pps_init_timestamps() in intel_pps_init(), we can reuse intel_pps_encoder_reset() which has the same code. Since intel_dp_pps_init() is only called from one place now, move it inline to remove one "init" function altogether. Fin

[Intel-gfx] [PATCH 3/4] drm/i915/dp: abstract struct intel_dp pps members to a sub-struct

2021-01-20 Thread Jani Nikula
Add some namespacing to highlight what belongs where. No functional changes. Cc: Anshuman Gupta Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 8 +- .../drm/i915/display/intel_display_types.h| 61 +++--- drivers/gpu/drm/i915/display/intel_dp.c | 14

[Intel-gfx] [PATCH 4/4] drm/i915/dp: split out aux functionality to intel_dp_aux.c

2021-01-20 Thread Jani Nikula
Split out the DP aux functionality to a new intel_dp_aux.[ch]. This is a surprisingly clean cut. v2: - Remove intel_dp_pack_aux declaration from intel_dp.h (Anshuman) - Fixed some whitespace/comment checkpatch warnings Cc: Anshuman Gupta Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Make

Re: [Intel-gfx] [PATCH] drm/i915/uc: Add function to define defaults for GuC/HuC enable

2021-01-20 Thread Chris Wilson
Quoting John Harrison (2021-01-14 21:39:42) > On 1/13/2021 14:07, john.c.harri...@intel.com wrote: > > From: John Harrison > > There is a module parameter for controlling what GuC/HuC features are > enabled. Setting to -1 means 'use the default'. However, the default > was not we

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_parallel: Launch 1s worth of threads

2021-01-20 Thread Chris Wilson
Let's not assume that the thread execution is instantaneous, but apply a time limit as well as a maximum number so that the test should always run in bounded time. Also limit each thread to submitting only two pieces of outstanding work, to minimise over-saturation. We use two alternating batches

[Intel-gfx] [PATCH v2 2/2] drm/i915/hdcp: Fix uninitialized symbol

2021-01-20 Thread Anshuman Gupta
Move (num_hdcp_streams > 0) condition to stream_encryption() code block, where it actually belongs. This fixes the static analysis error of uninitialized symbol 'ret'. v2: - return 0 as the return value is already checked. [Ankit] Cc: Ramalingam C Reported-by: kernel test robot Reported-by: Dan

[Intel-gfx] [PATCH] drm/i915/region: don't leak the object on error

2021-01-20 Thread Matthew Auld
Sanity check the object size before allocating a new gem object. Fixes: 97d553963250 ("drm/i915/region: convert object_create into object_init") Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_region.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

Re: [Intel-gfx] [PATCH] drm/i915/region: don't leak the object on error

2021-01-20 Thread Chris Wilson
Quoting Matthew Auld (2021-01-20 10:47:14) > Sanity check the object size before allocating a new gem object. > > Fixes: 97d553963250 ("drm/i915/region: convert object_create into > object_init") > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/gem/i915_gem_region.c | 8 > 1

[Intel-gfx] [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Jani Nikula
Commit 7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based quirks"") removed drm_dp_get_edid_quirks() and changed the signature of drm_dp_has_quirk() while they were still being used in msm. Fix the breakage. Functionally, removing the EDID-based quirks has no impact on msm. [The above com

[Intel-gfx] [PATCH i-g-t 1/2] i915/gem_create: Check wrap condition for -1

2021-01-20 Thread Chris Wilson
Check that we correctly reject an object size that will intentionally wrap upon aligning to a page. Signed-off-by: Chris Wilson --- tests/i915/gem_create.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index bf653

[Intel-gfx] [PATCH i-g-t 2/2] i915/gem_create: Exercise an impossible allocation

2021-01-20 Thread Chris Wilson
The largest processor in the works can support 57b of address space, far more memory than we can afford to use in CI! It is safe to assume that we will not have 64b processors for some time, so we can use the top bit to exercise our oversized object detection. Signed-off-by: Chris Wilson --- tes

Re: [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_create: Check wrap condition for -1

2021-01-20 Thread Matthew Auld
On Wed, 20 Jan 2021 at 11:11, Chris Wilson wrote: > > Check that we correctly reject an object size that will intentionally > wrap upon aligning to a page. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@l

Re: [Intel-gfx] [PATCH i-g-t 2/2] i915/gem_create: Exercise an impossible allocation

2021-01-20 Thread Matthew Auld
On Wed, 20 Jan 2021 at 11:11, Chris Wilson wrote: > > The largest processor in the works can support 57b of address space, far > more memory than we can afford to use in CI! It is safe to assume that > we will not have 64b processors for some time, so we can use the top bit > to exercise our overs

Re: [Intel-gfx] [PATCH v8 2/3] drm/i915/gem: Add a helper to read data from a GEM object page

2021-01-20 Thread Chris Wilson
Quoting Imre Deak (2021-01-15 19:41:00) > Add a simple helper to read data with the CPU from the page of a GEM > object. Do the read either via a kmap if the object has struct pages > or an iomap otherwise. This is needed by the next patch, reading a u64 > value from the object (w/o requiring the o

[Intel-gfx] [PULL] drm-misc-fixes

2021-01-20 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-next. Best regards Thomas drm-misc-fixes-2021-01-20: Short summary of fixes pull (less than what git shortlog provides): * drm/atomic: Release state on error * drm/syncobj: Fix use-after-free * drm/ttm: Don't use GFP_TRANSHUGE_LIGTH * d

Re: [Intel-gfx] [PULL] drm-misc-next

2021-01-20 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 12:39:22PM +0100, Maarten Lankhorst wrote: > drm-misc-next-2021-01-19: > drm-misc-next for v5.12: > > UAPI Changes: > - Fix fourcc macro for amlogic video fbc. > > Cross-subsystem Changes: > - Export pci_rebar_bytes_to_size. > - Add a PCI quirk to increase bar0 for RX 5600

Re: [Intel-gfx] linux-next: build failure after merge of the drm tree

2021-01-20 Thread Daniel Vetter
On Mon, Jan 18, 2021 at 2:06 AM Dave Airlie wrote: > > On Mon, 18 Jan 2021 at 10:59, Stephen Rothwell wrote: > > > > Hi all, > > > > On Mon, 11 Jan 2021 10:56:54 +1100 Stephen Rothwell > > wrote: > > > > > > On Fri, 8 Jan 2021 12:25:40 +1100 Stephen Rothwell > > > wrote: > > > > > > > > On Fr

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-01-20 Thread Thomas Zimmermann
Am 20.01.21 um 13:09 schrieb Thomas Zimmermann: Hi Dave and Daniel, here's this week's PR for drm-misc-next. drm-misc-fixes Best regards Thomas drm-misc-fixes-2021-01-20: Short summary of fixes pull (less than what git shortlog provides): * drm/atomic: Release state on error * drm/s

[Intel-gfx] [PATCH 2/2] drm/i915: Remove I915_USER_PRIORITY_SHIFT

2021-01-20 Thread Chris Wilson
As we do not have any internal priority levels, the priority can be set directed from the user values. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/display/intel_display.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +-- .../i915/gem/selftests/i915_gem_object_blt.c | 4

[Intel-gfx] [PATCH 1/2] drm/i915: Strip out internal priorities

2021-01-20 Thread Chris Wilson
Since we are not using any internal priority levels, and in the next few patches will introduce a new index for which the optimisation is not so lear cut, discard the small table within the priolist. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 2 +- .../drm/i

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Chris Wilson
Treat the dependency between bonded requests as weak and leave the remainder of the pair on the GPU if one hangs. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Skip over completed active execlists, again

2021-01-20 Thread Chris Wilson
Now that we are careful to always force-restore contexts upon rewinding (where necessary), we can restore our optimisation to skip over completed active execlists when dequeuing. Referenecs: 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context") References: 8ab3a381

[Intel-gfx] [PATCH 01/10] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Chris Wilson
Treat the dependency between bonded requests as weak and leave the remainder of the pair on the GPU if one hangs. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists

[Intel-gfx] [PATCH 03/10] drm/i915: Strip out internal priorities

2021-01-20 Thread Chris Wilson
Since we are not using any internal priority levels, and in the next few patches will introduce a new index for which the optimisation is not so lear cut, discard the small table within the priolist. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 2 +- .../drm/i

[Intel-gfx] [PATCH 04/10] drm/i915: Remove I915_USER_PRIORITY_SHIFT

2021-01-20 Thread Chris Wilson
As we do not have any internal priority levels, the priority can be set directed from the user values. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/display/intel_display.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 +-- .../i915/gem/selftests/i915_gem_object_blt.c | 4

[Intel-gfx] [PATCH 08/10] drm/i915/selftests: Measure set-priority duration

2021-01-20 Thread Chris Wilson
As a topological sort, we expect it to run in linear graph time, O(V+E). In removing the recursion, it is no longer a DFS but rather a BFS, and performs as O(VE). Let's demonstrate how bad this is with a few examples, and build a few test cases to verify a potential fix. Signed-off-by: Chris Wilso

[Intel-gfx] [PATCH 10/10] drm/i915: Improve DFS for priority inheritance

2021-01-20 Thread Chris Wilson
The core of the scheduling algorithm is that we compute the topological order of the fence DAG. Knowing that we have a DAG, we should be able to use a DFS to compute the topological sort in linear time. However, during the conversion of the recursive algorithm into an iterative one, the memoization

Re: [Intel-gfx] [PULL] gvt-gt-next

2021-01-20 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2021-01-18 07:07:39) > > Hi, > > This is GVT next for 5.12 against drm-intel-gt-next which is mostly > for cmd parser enhancement which adds extra check on register load > depending on initial context and handles vGPU register state > accordingly. I think we were bit inconcl

[Intel-gfx] [PATCH 07/10] drm/i915: Restructure priority inheritance

2021-01-20 Thread Chris Wilson
In anticipation of wanting to be able to call pi from underneath an engine's active.lock, rework the priority inheritance to primarily work along an engine's priority queue, delegating any other engine that the chain may traverse to a worker. This reduces the global spinlock from governing the mult

[Intel-gfx] [PATCH 05/10] drm/i915: Replace engine->schedule() with a known request operation

2021-01-20 Thread Chris Wilson
Looking to the future, we want to set the scheduling attributes explicitly and so replace the generic engine->schedule() with the more direct i915_request_set_priority() What it loses in removing the 'schedule' name from the function, it gains in having an explicit entry point with a stated goal.

[Intel-gfx] [PATCH 06/10] drm/i915: Teach the i915_dependency to use a double-lock

2021-01-20 Thread Chris Wilson
Currently, we construct and teardown the i915_dependency chains using a global spinlock. As the lists are entirely local, it should be possible to use an double-lock with an explicit nesting [signaler -> waiter, always] and so avoid the costly convenience of a global spinlock. Signed-off-by: Chris

[Intel-gfx] [PATCH 09/10] drm/i915/selftests: Exercise priority inheritance around an engine loop

2021-01-20 Thread Chris Wilson
Exercise rescheduling priority inheritance around a sequence of requests that wrap around all the engines. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/selftests/i915_scheduler.c | 219 ++ 1 file changed, 219 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_s

[Intel-gfx] [PATCH 02/10] drm/i915/gt: Skip over completed active execlists, again

2021-01-20 Thread Chris Wilson
Now that we are careful to always force-restore contexts upon rewinding (where necessary), we can restore our optimisation to skip over completed active execlists when dequeuing. Referenecs: 35f3fd8182ba ("drm/i915/execlists: Workaround switching back to a completed context") References: 8ab3a381

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86072/ State : warning == Summary == $ dim checkpatch origin/drm-tip 25db9a3ad7a1 drm/i915/display: Support PSR Multiple Instances -:1259

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86072/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be check

Re: [Intel-gfx] [PATCH v6 16/64] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v5.

2021-01-20 Thread Intel
On 1/18/21 1:55 PM, Thomas Hellström (Intel) wrote: On 1/18/21 1:43 PM, Maarten Lankhorst wrote: Op 18-01-2021 om 12:30 schreef Thomas Hellström (Intel): Hi, On 1/5/21 4:35 PM, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the s

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86072/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19419 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/pps: refactor init abstractions

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pps: refactor init abstractions URL : https://patchwork.freedesktop.org/series/86076/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3210f99b0871 drm/i915/pps: refactor init abstractions b59f412b98d3 drm/i915/pps:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/pps: refactor init abstractions

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pps: refactor init abstractions URL : https://patchwork.freedesktop.org/series/86076/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately

[Intel-gfx] [PATCH v12 1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Gwan-gyeong Mun
It is a preliminary work for supporting multiple EDP PSR and DP PanelReplay. And it refactors singleton PSR to Multi Transcoder supportable PSR. And this moves and renames the i915_psr structure of drm_i915_private's to intel_dp's intel_psr structure. It also causes changes in PSR interrupt handlin

[Intel-gfx] [PATCH v12 2/2] drm/i915/display: Support Multiple Transcoders' PSR status on debugfs

2021-01-20 Thread Gwan-gyeong Mun
In order to support the PSR state of each transcoder, it adds i915_psr_status to sub-directory of each transcoder. v2: Change using of Symbolic permissions 'S_IRUGO' to using of octal permissions '0444' v5: Addressed JJani Nikula's review comments - Remove checking of Gen12 for i915_psr_statu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/pps: refactor init abstractions

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pps: refactor init abstractions URL : https://patchwork.freedesktop.org/series/86076/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19420 Su

[Intel-gfx] [PATCH 1/4] drm/i915: Nuke not needed members of dram_info

2021-01-20 Thread José Roberto de Souza
Valid, ranks and bandwidth_kbps are set into dram_info but are not used anywhere else so nuking it. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 3 -- drivers/gpu/drm/i915/intel_dram.c | 47 +++--

[Intel-gfx] [PATCH 2/4] drm/i915/gen11+: Only load DRAM information from pcode

2021-01-20 Thread José Roberto de Souza
Up to now we were reading some DRAM information from MCHBAR register and from pcode what is already not good but some GEN12(TGL-H and ADL-S) platforms have MCHBAR DRAM information in different offsets. This was notified to HW team that decided that the best alternative is always apply the 16gb_dim

[Intel-gfx] [PATCH 3/4] drm/i915: Fail driver probe when unable to load DRAM information

2021-01-20 Thread José Roberto de Souza
DRAM information is required to properly program display. Before "drm/i915/gen11+: Only load DRAM information from pcode" we were failing driver load if unable to fetch DRAM information from pcode form GEN11+ but we should also extend it to GEN9 plaforms. Signed-off-by: José Roberto de Souza ---

[Intel-gfx] [PATCH 4/4] drm/i915: Rename is_16gb_dimm to wm_lv_0_adjust_needed

2021-01-20 Thread José Roberto de Souza
As it now it is always required for GEN12+ the is_16gb_dimm name do not make sense for GEN12+. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_dram.c | 10 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 3 files changed, 7 inse

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86072/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19419_full =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2)

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2) URL : https://patchwork.freedesktop.org/series/86058/ State : warning == Summary == $ dim checkpatch origin/drm-tip 12342e09d0d8 drm/i915/gem: Almagamate clflushes on suspend -:24:

[Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-20 Thread Chris Wilson
If we import a shmemfs object between devices, for example from Tigerlake to DG1, we can simply reuse the native object and its backing store. Suggested-by: Imre Deak Signed-off-by: Chris Wilson Cc: Matthew Auld Cc: Imre Deak --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 7 +++ 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2)

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2) URL : https://patchwork.freedesktop.org/series/86058/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19421

Re: [Intel-gfx] [PULL] gvt-gt-next

2021-01-20 Thread Vivi, Rodrigo
On Wed, 2021-01-20 at 14:21 +0200, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2021-01-18 07:07:39) > > > > Hi, > > > > This is GVT next for 5.12 against drm-intel-gt-next which is mostly > > for cmd parser enhancement which adds extra check on register load > > depending on initial context and

[Intel-gfx] [PATCH] kbuild: use always-y instead of extra-y

2021-01-20 Thread Masahiro Yamada
As commit d0e628cd817f ("kbuild: doc: clarify the difference between extra-y and always-y") explained, extra-y should be used for listing the prerequsites of vmlinux. always-y is a better fix here. Signed-off-by: Masahiro Yamada --- Documentation/devicetree/bindings/Makefile | 8 driv

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/pps: refactor init abstractions

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/pps: refactor init abstractions URL : https://patchwork.freedesktop.org/series/86076/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19420_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP misc fixes (rev2)

2021-01-20 Thread Patchwork
== Series Details == Series: HDCP misc fixes (rev2) URL : https://patchwork.freedesktop.org/series/86025/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19422 Summary --- **SUCCESS** No regression

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/region: don't leak the object on error

2021-01-20 Thread Patchwork
== Series Details == Series: drm/i915/region: don't leak the object on error URL : https://patchwork.freedesktop.org/series/86077/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19423 Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Patchwork
== Series Details == Series: drm/msm/dp: fix build after dp quirk helper change URL : https://patchwork.freedesktop.org/series/86079/ State : warning == Summary == $ dim checkpatch origin/drm-tip 85c10923c0f6 drm/msm/dp: fix build after dp quirk helper change -:6: ERROR:GIT_COMMIT_ID: Please u

Re: [Intel-gfx] [CI 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-20 Thread Lucas De Marchi
Both patches applied to topic/adl-s-enabling branch. Lucas De Marchi On Tue, Jan 19, 2021 at 11:29:30AM -0800, Lucas De Marchi wrote: From: Aditya Swarup TGL adds another level of indirection for applying WA based on stepping information rather than PCI REVID. So change TGL_REVID enum into st

Re: [Intel-gfx] [PATCH] drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-01-20 at 13:07 +0200, Jani Nikula wrote: > Commit 7c553f8b5a7d ("drm/dp: Revert "drm/dp: Introduce EDID-based > quirks"") removed drm_dp_get_edid_quirks() and changed the signature of > drm_dp_has_quirk() while they were still being used in msm. Fix the > brea

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: abstract struct intel_dp pps members to a sub-struct

2021-01-20 Thread Rodrigo Vivi
On Wed, Jan 20, 2021 at 12:18:33PM +0200, Jani Nikula wrote: > Add some namespacing to highlight what belongs where. No functional > changes. > > Cc: Anshuman Gupta > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_debugfs.c | 8 +- > .../drm/i915/display/intel_display_

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dp: split out aux functionality to intel_dp_aux.c

2021-01-20 Thread Rodrigo Vivi
On Wed, Jan 20, 2021 at 12:18:34PM +0200, Jani Nikula wrote: > Split out the DP aux functionality to a new intel_dp_aux.[ch]. This is a > surprisingly clean cut. I had wondered about this split in the past... surprisingly clean cut indeed... > > v2: > - Remove intel_dp_pack_aux declaration from

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Patchwork
== Series Details == Series: drm/msm/dp: fix build after dp quirk helper change URL : https://patchwork.freedesktop.org/series/86079/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19424 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-20 Thread Matthew Auld
On Wed, 20 Jan 2021 at 15:40, Chris Wilson wrote: > > If we import a shmemfs object between devices, for example from > Tigerlake to DG1, we can simply reuse the native object and its backing > store. Hmmm interesting, so does that include re-using the actual sg mapping for the backing pages? Doe

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2)

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gem: Almagamate clflushes on suspend (rev2) URL : https://patchwork.freedesktop.org/series/86058/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19421_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86087/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19426 ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix ICL MG PHY vswing handling

2021-01-20 Thread Souza, Jose
On Mon, 2020-12-07 at 22:35 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The MH PHY vswing table does have all the entries these days. Get > rid of the old hacks in the code which claim otherwise. > > This hack was totally bogus anyway. The correct way to handle the > lack of those two

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86088/ State : warning == Summary == $ dim checkpatch origin/drm-tip ed0915405628 drm/i915/gt: Do not suspend bonded requests if on

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Unify the sanity checks for the buf trans tables

2021-01-20 Thread Souza, Jose
On Mon, 2020-12-07 at 22:35 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Get rid of the "I like my random new style best" approach and unify > the handling for the DDI buf trans table sanity checks once again. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä > ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86088/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: abstract struct intel_dp pps members to a sub-struct

2021-01-20 Thread Jani Nikula
On Wed, 20 Jan 2021, Rodrigo Vivi wrote: > On Wed, Jan 20, 2021 at 12:18:33PM +0200, Jani Nikula wrote: >> Add some namespacing to highlight what belongs where. No functional >> changes. >> >> Cc: Anshuman Gupta >> Signed-off-by: Jani Nikula >> --- >> .../drm/i915/display/intel_display_debugfs

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Nuke not needed members of dram_info

2021-01-20 Thread Souza, Jose
On Wed, 2021-01-20 at 10:52 -0800, Lucas De Marchi wrote: > On Wed, Jan 20, 2021 at 10:42:46AM -0800, Jose Souza wrote: > > On Wed, 2021-01-20 at 10:31 -0800, Lucas De Marchi wrote: > > > On Wed, Jan 20, 2021 at 07:16:08AM -0800, Jose Souza wrote: > > > > Valid, ranks and bandwidth_kbps are set int

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/region: don't leak the object on error

2021-01-20 Thread Patchwork
== Series Details == Series: drm/i915/region: don't leak the object on error URL : https://patchwork.freedesktop.org/series/86077/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19423_full Summary

Re: [Intel-gfx] [PATCH v8 2/3] drm/i915/gem: Add a helper to read data from a GEM object page

2021-01-20 Thread Imre Deak
On Wed, Jan 20, 2021 at 12:02:49PM +, Chris Wilson wrote: > Quoting Imre Deak (2021-01-15 19:41:00) > > Add a simple helper to read data with the CPU from the page of a GEM > > object. Do the read either via a kmap if the object has struct pages > > or an iomap otherwise. This is needed by the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86088/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19427 =

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dp: abstract struct intel_dp pps members to a sub-struct

2021-01-20 Thread Rodrigo Vivi
On Wed, Jan 20, 2021 at 09:25:10PM +0200, Jani Nikula wrote: > On Wed, 20 Jan 2021, Rodrigo Vivi wrote: > > On Wed, Jan 20, 2021 at 12:18:33PM +0200, Jani Nikula wrote: > >> Add some namespacing to highlight what belongs where. No functional > >> changes. > >> > >> Cc: Anshuman Gupta > >> Signed

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86091/ State : warning == Summary == $ dim checkpatch origin/drm-tip ca6ecae10b15 drm/i915/display: Support PSR Multiple Instances -:1682

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86091/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be check

[Intel-gfx] [PATCH] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-01-20 Thread John . C . Harrison
From: John Harrison The meaning of 'default' for the enable_guc module parameter has been updated to accurately reflect what is supported on current platforms. So start using the defaults instead of forcing everything off. Signed-off-by: John Harrison CC: Daniele Ceraolo Spurio --- drivers/gp

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/msm/dp: fix build after dp quirk helper change

2021-01-20 Thread Patchwork
== Series Details == Series: drm/msm/dp: fix build after dp quirk helper change URL : https://patchwork.freedesktop.org/series/86079/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19424_full Summary -

Re: [Intel-gfx] linux-next: build failure after merge of the drm tree

2021-01-20 Thread Stephen Rothwell
Hi Daniel, On Wed, 20 Jan 2021 13:12:21 +0100 Daniel Vetter wrote: > > I've pulled drm-misc-next into drm-next now, so as long as all other > drm trees are merged after drm, this should be solved now. > drm-intel-next also has their msm build breakage fixed (I acked the > patch already), so hopef

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-20 Thread kernel test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [v12,1/2] drm/i915/display: Support PSR Multiple Instances URL : https://patchwork.freedesktop.org/series/86091/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19428 ===

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-20 Thread Chris Wilson
Quoting Chris Wilson (2021-01-20 18:06:08) > Quoting Matthew Auld (2021-01-20 17:46:10) > > On Wed, 20 Jan 2021 at 15:40, Chris Wilson wrote: > > > > > > If we import a shmemfs object between devices, for example from > > > Tigerlake to DG1, we can simply reuse the native object and its backing >

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gem: Allow importing of shmemfs objects into any device

2021-01-20 Thread Patchwork
== Series Details == Series: drm/i915/gem: Allow importing of shmemfs objects into any device URL : https://patchwork.freedesktop.org/series/86093/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/gene

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Nuke not needed members of dram_info

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Nuke not needed members of dram_info URL : https://patchwork.freedesktop.org/series/86092/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19429 =

[Intel-gfx] [PATCH v9 2/3] drm/i915/gem: Add a helper to read data from a GEM object page

2021-01-20 Thread Imre Deak
Add a simple helper to read data with the CPU from the page of a GEM object. Do the read either via a kmap if the object has struct pages or an iomap otherwise. This is needed by the next patch, reading a u64 value from the object (w/o requiring the obj to be mapped to the GPU). Suggested by Chris

Re: [Intel-gfx] [PATCH] kbuild: use always-y instead of extra-y

2021-01-20 Thread Rob Herring
On Wed, Jan 20, 2021 at 03:23:51PM +0900, Masahiro Yamada wrote: > As commit d0e628cd817f ("kbuild: doc: clarify the difference between > extra-y and always-y") explained, extra-y should be used for listing > the prerequsites of vmlinux. always-y is a better fix here. prerequisites Glad to see th

[Intel-gfx] ✗ Fi.CI.BUILD: failure for kbuild: use always-y instead of extra-y

2021-01-20 Thread Patchwork
== Series Details == Series: kbuild: use always-y instead of extra-y URL : https://patchwork.freedesktop.org/series/86094/ State : failure == Summary == Applying: kbuild: use always-y instead of extra-y error: sha1 information is lacking or useless (scripts/Makefile.lib). error: could not buil

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs

2021-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Do not suspend bonded requests if one hangs URL : https://patchwork.freedesktop.org/series/86087/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650_full -> Patchwork_19426_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Use platform specific defaults for GuC/HuC enabling

2021-01-20 Thread Patchwork
== Series Details == Series: drm/i915/uc: Use platform specific defaults for GuC/HuC enabling URL : https://patchwork.freedesktop.org/series/86100/ State : success == Summary == CI Bug Log - changes from CI_DRM_9650 -> Patchwork_19432 Summa

  1   2   >