[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] dma-buf/sw_sync: Avoid recursive lock during fence signal

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] dma-buf/sw_sync: Avoid recursive lock during fence signal URL : https://patchwork.freedesktop.org/series/79510/ State : success == Summary == CI Bug Log - changes from CI_DRM_8748_full -> Patchwork_18173_full

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-15 Thread Tvrtko Ursulin
On 14/07/2020 10:47, Chris Wilson wrote: We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple waiters and then check to see if the request is already executing, we can remove the irq

Re: [Intel-gfx] [PATCH 2/2] dma-buf/dma-fence: Add quick tests before dma_fence_remove_callback

2020-07-15 Thread Chris Wilson
Quoting Chris Wilson (2020-07-15 13:21:43) > Quoting Daniel Vetter (2020-07-15 13:10:22) > > On Wed, Jul 15, 2020 at 11:49:05AM +0100, Chris Wilson wrote: > > > When waiting with a callback on the stack, we must remove the callback > > > upon wait completion. Since this will be notified by the fenc

Re: [Intel-gfx] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one

2020-07-15 Thread Arkadiusz Hiler
On Mon, Jun 22, 2020 at 01:37:55PM -0300, Melissa Wen wrote: > When a subtest fails, it skips the cleanup, and its pipe_crc remains > allocated. > As a consequence, the following subtest also fails (timeout) when trying to > create a new one. This patch releases any remaining pipe_crc to enable th

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-15 13:39:56) > > On 14/07/2020 10:47, Chris Wilson wrote: > > We are using the i915_request.lock to serialise adding an execution > > callback with __i915_request_submit. However, if we use an atomic > > llist_add to serialise multiple waiters and then check to see

Re: [Intel-gfx] [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path

2020-07-15 Thread Liviu Dudau
On Tue, Jul 07, 2020 at 10:12:12PM +0200, Daniel Vetter wrote: > Again needs to be put right after the call to > drm_atomic_helper_commit_hw_done(), since that's the last thing which > can hold up a subsequent atomic commit. > > No surprises here. I was (still am) hoping to do a testing for this

Re: [Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank

2020-07-15 Thread Arkadiusz Hiler
On Mon, Jun 22, 2020 at 01:38:26PM -0300, Melissa Wen wrote: > When running subtests in sequence using vkms, the beginning of CRC capture > process does not match the simulated vblank timing. This mismatch leads to > an endless busy wait and, consequently, timeout failures for the remaining > subte

[Intel-gfx] [PULL] drm-intel-fixes

2020-07-15 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2020-07-15: drm/i915 fixes for v5.8-rc6: - FBC w/a stride fix - Fix use-after-free fix on module reload - Ignore irq enabling on the virtual engines to fix device sleep - Use GTT when saving/restoring engine GPR - Fix selftest sort function BR, Jani. The follo

Re: [Intel-gfx] [PATCH i-g-t 0/2] minor improvements to the kms_cursor_crc doc and some comments cleanup

2020-07-15 Thread Arkadiusz Hiler
On Wed, Jun 24, 2020 at 06:54:00AM -0300, Melissa Wen wrote: > Hi, > > I was studying the code of kms_cursor_crc test, and I just adjusted some > comments > and added descriptions for subtests. > > Melissa Wen (2): > lib/igt_fb: change comments with fd description > test/kms_cursor_crc: upda

[Intel-gfx] Fixes that failed to apply to v5.8-rc5

2020-07-15 Thread Jani Nikula
Hi all - The following commits have been marked as Cc: stable or fixing something in v5.8-rc5 or earlier, but failed to cherry-pick to drm-intel-fixes. Please see if they are worth backporting, and please do so if they are. Failed to cherry-pick: e5ec1f954869 ("drm/i915/fbc: Use the correct pla

[Intel-gfx] [PULL] drm-intel-next

2020-07-15 Thread Jani Nikula
to fetch changes up to e57bd05ec0d2d82d63725dedf9f5a063f879de25: drm/i915: Update DRIVER_DATE to 20200715 (2020-07-15 14:18:02 +0300) drm/i915 features for v5.9, batch #2 Highlights: - Very early DG1 enabling (Abdiel, Lucas, Anu

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim checkpatch origin/drm-tip 91bde1c5e935 drm/i915: Reduce i915_request.lock con

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each comm

Re: [Intel-gfx] [PULL] drm-intel-next

2020-07-15 Thread Jani Nikula
Argh, failed to mention: On Wed, 15 Jul 2020, Jani Nikula wrote: > Lee Shawn C (1): > drm/i915/mst: filter out the display mode exceed sink's capability The above depends on: > Lyude Paul (1): > drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx Which has changes out

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-15 Thread Tvrtko Ursulin
On 15/07/2020 13:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-07-15 13:39:56) On 14/07/2020 10:47, Chris Wilson wrote: We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/display: Implement HOBL

2020-07-15 Thread Ville Syrjälä
On Mon, Jul 13, 2020 at 04:53:33PM -0700, José Roberto de Souza wrote: > Hours Of Battery Life is a new GEN12+ power-saving feature that allows > supported motherboards to use a special voltage swing table for eDP > panels that uses less power. > > So here if supported by HW, OEM will set it in VB

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] dma-buf/dma-fence: Trim dma_fence_add_callback()

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] dma-buf/dma-fence: Trim dma_fence_add_callback() URL : https://patchwork.freedesktop.org/series/79513/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8748_full -> Patchwork_18174_full =

Re: [Intel-gfx] [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 2:53 PM Liviu Dudau wrote: > > On Tue, Jul 07, 2020 at 10:12:12PM +0200, Daniel Vetter wrote: > > Again needs to be put right after the call to > > drm_atomic_helper_commit_hw_done(), since that's the last thing which > > can hold up a subsequent atomic commit. > > > > No s

[Intel-gfx] [PATCH v2] drm/i915: Remove i915_request.lock requirement for execution callbacks

2020-07-15 Thread Chris Wilson
We are using the i915_request.lock to serialise adding an execution callback with __i915_request_submit. However, if we use an atomic llist_add to serialise multiple waiters and then check to see if the request is already executing, we can remove the irq-spinlock. v2: Avoid using the irq_work when

Re: [Intel-gfx] [PATCH 2/2] dma-buf/dma-fence: Add quick tests before dma_fence_remove_callback

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 2:40 PM Chris Wilson wrote: > Quoting Chris Wilson (2020-07-15 13:21:43) > > Quoting Daniel Vetter (2020-07-15 13:10:22) > > > On Wed, Jul 15, 2020 at 11:49:05AM +0100, Chris Wilson wrote: > > > > When waiting with a callback on the stack, we must remove the callback > > >

Re: [Intel-gfx] [PULL] drm-intel-next

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 3:34 PM Jani Nikula wrote: > > > Argh, failed to mention: > > On Wed, 15 Jul 2020, Jani Nikula wrote: > > Lee Shawn C (1): > > drm/i915/mst: filter out the display mode exceed sink's capability > > The above depends on: > > > Lyude Paul (1): > > drm/probe_helpe

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/23] Revert "drm/i915/gem: Async GPU relocations only" (rev3)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/23] Revert "drm/i915/gem: Async GPU relocations only" (rev3) URL : https://patchwork.freedesktop.org/series/79470/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8748_full -> Patchwork_18175_full ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2) URL : https://patchwork.freedesktop.org/series/79467/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, ea

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait URL : https://patchwork.freedesktop.org/series/79517/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8750 -> Patchwork_18177 ==

Re: [Intel-gfx] [PATCH v2] drm/i915/fbc: Limit cfb to the first 256MiB of stolen on g4x+

2020-07-15 Thread Ville Syrjälä
On Tue, Jul 14, 2020 at 09:32:54PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2020-07-14 21:19:45) > > From: Ville Syrjälä > > > > Since g4x the CFB base only takes a 28bit offset into stolen. > > Not sure if the CFB is allowed to start below that limit but > > then extend beyond it. Let

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2) URL : https://patchwork.freedesktop.org/series/79467/ State : success == Summary == CI Bug Log - changes from CI_DRM_8750 -> Patchwork_18178 ===

Re: [Intel-gfx] [PATCH 2/2] dma-buf/dma-fence: Add quick tests before dma_fence_remove_callback

2020-07-15 Thread Chris Wilson
Quoting Daniel Vetter (2020-07-15 15:03:34) > On Wed, Jul 15, 2020 at 2:40 PM Chris Wilson wrote: > > There's a further problem in that we call INIT_LIST_HEAD on the > > dma_fence_cb before the signal callback. So even if list_empty_careful() > > confirms the dma_fence_cb to be completely decouple

Re: [Intel-gfx] [PATCH 2/2] dma-buf/dma-fence: Add quick tests before dma_fence_remove_callback

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 4:37 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2020-07-15 15:03:34) > > On Wed, Jul 15, 2020 at 2:40 PM Chris Wilson > > wrote: > > > There's a further problem in that we call INIT_LIST_HEAD on the > > > dma_fence_cb before the signal callback. So even if list_emp

Re: [Intel-gfx] [PATCH] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-07-15 13:26:23) > > On 15/07/2020 13:06, Tvrtko Ursulin wrote: > > > > On 15/07/2020 11:50, Chris Wilson wrote: > >> Currently, we use i915_request_completed() directly in > >> i915_request_wait() and follow up with a manual invocation of > >> dma_fence_signal(). This

Re: [Intel-gfx] [PATCH] drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Chris Wilson
Quoting Chris Wilson (2020-07-15 15:47:15) > Quoting Tvrtko Ursulin (2020-07-15 13:26:23) > > > > On 15/07/2020 13:06, Tvrtko Ursulin wrote: > > > > > > On 15/07/2020 11:50, Chris Wilson wrote: > > >> Currently, we use i915_request_completed() directly in > > >> i915_request_wait() and follow up

Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Daniel Vetter
Hi Anitha On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote: > This is a new DRM driver for Intel's KeemBay SOC. > The SoC couples an ARM Cortex A53 CPU with an Intel > Movidius VPU. > > This driver is tested with the KMB EVM board which is the refernce baord > for Keem Bay SOC.

Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 05:05:49PM +0200, Daniel Vetter wrote: > Hi Anitha > > On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote: > > This is a new DRM driver for Intel's KeemBay SOC. > > The SoC couples an ARM Cortex A53 CPU with an Intel > > Movidius VPU. > > > > This driver is

Re: [Intel-gfx] [PATCH v2] drm/i915/fbc: Limit cfb to the first 256MiB of stolen on g4x+

2020-07-15 Thread Chris Wilson
Quoting Ville Syrjälä (2020-07-15 15:22:24) > On Tue, Jul 14, 2020 at 09:32:54PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2020-07-14 21:19:45) > > > From: Ville Syrjälä > > > > > > Since g4x the CFB base only takes a 28bit offset into stolen. > > > Not sure if the CFB is allowed to s

[Intel-gfx] [PATCH] drm/i915: Fair low-latency scheduling

2020-07-15 Thread Chris Wilson
The first "scheduler" was a topographical sorting of requests into priority order. The execution order was deterministic, the earliest submitted, highest priority request would be executed first. Priority inherited ensured that inversions were kept at bay, and allowed us to dynamically boost priori

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, ea

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim checkpatch origin/drm-tip 130497fc98af drm/i915: Reduce i915_request.l

Re: [Intel-gfx] [PATCH 28/66] drm/i915/gem: Replace i915_gem_object.mm.mutex with reservation_ww_class

2020-07-15 Thread Maarten Lankhorst
Op 15-07-2020 om 13:51 schreef Chris Wilson: > Our goal is to pull all memory reservations (next iteration > obj->ops->get_pages()) under a ww_mutex, and to align those reservations > with other drivers, i.e. control all such allocations with the > reservation_ww_class. Currently, this is under the

[Intel-gfx] [PATCH] drm/i915/selftests: Mock the status_page.vma for the kernel_context

2020-07-15 Thread Chris Wilson
Since we assert that the kernel_context is using the perma-pinned HWSP, make it so. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/mock_engine.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/mock_engine.c b/drivers/gpu/drm/i915/gt/moc

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79517/ State : success == Summary == CI Bug Log - changes from CI_DRM_8750 -> Patchwork_18179 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/selftests: Mock the status_page.vma for the kernel_context

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mock the status_page.vma for the kernel_context URL : https://patchwork.freedesktop.org/series/79521/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reduce i915_request.lock contention for i915_request_wait

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request.lock contention for i915_request_wait URL : https://patchwork.freedesktop.org/series/79514/ State : success == Summary == CI Bug Log - changes from CI_DRM_8749_full -> Patchwork_18176_full ==

Re: [Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank

2020-07-15 Thread Melissa Wen
On 07/15, Arkadiusz Hiler wrote: > On Mon, Jun 22, 2020 at 01:38:26PM -0300, Melissa Wen wrote: > > When running subtests in sequence using vkms, the beginning of CRC capture > > process does not match the simulated vblank timing. This mismatch leads to > > an endless busy wait and, consequently, t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Mock the status_page.vma for the kernel_context

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mock the status_page.vma for the kernel_context URL : https://patchwork.freedesktop.org/series/79521/ State : success == Summary == CI Bug Log - changes from CI_DRM_8750 -> Patchwork_18180 Su

[Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Imre Deak
The problem the reverted patch revealed could've been fixed by commit 619ad4874585 ("drm/i915/ddi: Don't frob the DP link scramble disabling flag") in particular because the revealed problem (at least in one case) happened when switching to the TPS4 training pattern, which needs scrambling. Let's

Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Sam Ravnborg
Hi Anitha. On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote: > This is a new DRM driver for Intel's KeemBay SOC. > The SoC couples an ARM Cortex A53 CPU with an Intel > Movidius VPU. > > This driver is tested with the KMB EVM board which is the refernce baord > for Keem Bay SOC.

Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Sam Ravnborg
On Wed, Jul 15, 2020 at 05:05:49PM +0200, Daniel Vetter wrote: > Hi Anitha > > On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote: > > This is a new DRM driver for Intel's KeemBay SOC. > > The SoC couples an ARM Cortex A53 CPU with an Intel > > Movidius VPU. > > > > This driver is

[Intel-gfx] [PULL] drm-misc-fixes

2020-07-15 Thread Thomas Zimmermann
Hi Dave and Daniel, here is the PR for the current drm-misc-fixes. The aspeed fix is only about dmesg noise. The dmabuf locking appears to be a real bug. Best regards Thomas drm-misc-fixes-2020-07-15: * aspeed: setup fbdev console after registering device; avoids warning and stacktrace in dm

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"" URL : https://patchwork.freedesktop.org/series/79522/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"" URL : https://patchwork.freedesktop.org/series/79522/ State : warning == Summary == $ dim checkpatch origin/drm-tip 16afab03b437 Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"" -:

[Intel-gfx] [PATCH] drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-15 Thread Chris Wilson
One more complication of preempt-to-busy with respect to the virtual engine is that we may have retired the last request along the virtual engine at the same time as preparing to submit the completed request to a new engine. That submit will be shortcircuited, but not before we have updated the con

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"" URL : https://patchwork.freedesktop.org/series/79522/ State : success == Summary == CI Bug Log - changes from CI_DRM_8751 -> Patchwork_18181 Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Only transfer the virtual context to the new engine if active URL : https://patchwork.freedesktop.org/series/79524/ State : warning == Summary == $ dim checkpatch origin/drm-tip f736e550c1ab drm/i915/gt: Only transfer the virtual context to the new en

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Only transfer the virtual context to the new engine if active URL : https://patchwork.freedesktop.org/series/79524/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked se

[Intel-gfx] [PATCH CI] drm/i915/display: Implement HOBL

2020-07-15 Thread José Roberto de Souza
Hours Of Battery Life is a new GEN12+ power-saving feature that allows supported motherboards to use a special voltage swing table for eDP panels that uses less power. So here if supported by HW, OEM will set it in VBT and i915 will try to train link with HOBL vswing table if link training fails i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Only transfer the virtual context to the new engine if active URL : https://patchwork.freedesktop.org/series/79524/ State : success == Summary == CI Bug Log - changes from CI_DRM_8751 -> Patchwork_18182

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Implement HOBL

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement HOBL URL : https://patchwork.freedesktop.org/series/79525/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. ___

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Implement HOBL

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement HOBL URL : https://patchwork.freedesktop.org/series/79525/ State : success == Summary == CI Bug Log - changes from CI_DRM_8751 -> Patchwork_18183 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Chrisanthus, Anitha
Hi Sam and Daniel, Thank you very much for reviewing the code. I will squish all the commits and send version 3, so it will be easier for you to review. Anitha > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 15, 2020 10:07 AM > To: Daniel Vetter > Cc: Chrisanthus, Ani

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Remove i915_request.lock requirement for execution callbacks (rev2) URL : https://patchwork.freedesktop.org/series/79467/ State : success == Summary == CI Bug Log - changes from CI_DRM_8750_full -> Patchwork_18178_full =

Re: [Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Manasi Navare
On Wed, Jul 15, 2020 at 07:29:31PM +0300, Imre Deak wrote: > The problem the reverted patch revealed could've been fixed by commit > 619ad4874585 ("drm/i915/ddi: Don't frob the DP link scramble disabling flag") > in particular because the revealed problem (at least in one case) happened > when swit

Re: [Intel-gfx] [PATCH] drm/i915: Be wary of data races when reading the active execlists

2020-07-15 Thread Chris Wilson
Quoting Chris Wilson (2020-07-10 18:10:01) > [ 1413.563200] BUG: KCSAN: data-race in __await_execution+0x217/0x370 [i915] > [ 1413.563221] > [ 1413.563236] race at unknown origin, with read to 0x5bb6c478 of 8 > bytes by task 9654 on cpu 1: > [ 1413.563548] __await_execution+0x217/0x370 [i

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79517/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8750_full -> Patchwork_18179_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Mock the status_page.vma for the kernel_context

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mock the status_page.vma for the kernel_context URL : https://patchwork.freedesktop.org/series/79521/ State : success == Summary == CI Bug Log - changes from CI_DRM_8750_full -> Patchwork_18180_full ==

Re: [Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Imre Deak
On Wed, Jul 15, 2020 at 12:15:35PM -0700, Manasi Navare wrote: > On Wed, Jul 15, 2020 at 07:29:31PM +0300, Imre Deak wrote: > > The problem the reverted patch revealed could've been fixed by commit > > 619ad4874585 ("drm/i915/ddi: Don't frob the DP link scramble disabling > > flag") > > in particu

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+"" URL : https://patchwork.freedesktop.org/series/79522/ State : success == Summary == CI Bug Log - changes from CI_DRM_8751_full -> Patchwork_18181_full ===

[Intel-gfx] [PATCH v6 04/11] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Small changes to intel_dp_mode_valid(), allow listing modes that can only be supported in the bigjoiner configuration, which is not supported yet. eDP does not support bigjoiner, so do not expose bigjoiner only modes on the eDP port. v5: * Increase max plane width to sup

[Intel-gfx] [PATCH v6 08/11] drm/i915: Link planes in a bigjoiner configuration, v3.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Make sure that when a plane is set in a bigjoiner mode, we will add their counterpart to the atomic state as well. This will allow us to make sure all state is available when planes are checked. Because of the funny interactions with bigjoiner and planar YUV formats, w

[Intel-gfx] [PATCH v6 01/11] HAX to make DSC work on the icelake test system

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst DSC is available on the display emulator, but not set in DPCD. Override the entries to allow bigjoiner testing. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_dp_helper.c | 4 ++-- include/drm/drm_dp_helper.h | 1 + 2 files changed, 3 insertions(+), 2 dele

[Intel-gfx] [PATCH v6 02/11] drm/i915: Remove hw.mode

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst The members in hw.mode can be used from adjusted_mode as well, use that when available. Some places that use hw.mode can be converted to use adjusted_mode as well. v2: * Manual rebase (Manasi) * remove the use of pipe_mode defined in patch 3 (Manasi) v3: * Rebase on drm

[Intel-gfx] [PATCH v6 07/11] drm/i915: Make hardware readout work on i915.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Unfortunately I have no way to test this, but it should be correct if the bios sets up bigjoiner in a sane way. Skip iterating over bigjoiner slaves, only the master has the state we care about. Add the width of the bigjoiner slave to the reconstructed fb. Hide the bigj

[Intel-gfx] [PATCH v6 11/11] drm/i915: Add debugfs dumping for bigjoiner, v3.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Dump debugfs and planar links as well, this will make it easier to debug when things go wrong. v4: * Rebase Changes since v1: - Report planar slaves as such, now that we have the plane_state switch. Changes since v2: - Rebase on top of the new plane format dumping Signed

[Intel-gfx] [PATCH v6 05/11] drm/i915: Try to make bigjoiner work in atomic check

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst When the clock is higher than the dotclock, try with 2 pipes enabled. If we can enable 2, then we will go into big joiner mode, and steal the adjacent crtc. This only links the crtc's in software, no hardware or plane programming is done yet. Blobs are also copied fr

[Intel-gfx] [PATCH v6 06/11] drm/i915: Enable big joiner support in enable and disable sequences.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Make vdsc work when no output is enabled. The big joiner needs VDSC on the slave, so enable it and set the appropriate bits. Also update timestamping constants, because slave crtc's are not updated in drm_atomic_helper_update_legacy_modeset_state(). This should be enough

[Intel-gfx] [PATCH v6 03/11] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst v4: * Manual rebase (Manasi) v3: * Change state to crtc_state, fix rebase err (Manasi) v2: * Manual Rebase (Manasi) Signed-off-by: Maarten Lankhorst Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 61 --- .../drm/i915/displ

[Intel-gfx] [PATCH v6 09/11] drm/i915: Add bigjoiner aware plane clipping checks

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst We need to look at hw.fb for the framebuffer, and add the translation for the slave_plane_state. With these changes we set the correct rectangle on the bigjoiner slave, and don't set incorrect src/dst/visibility on the slave plane. v2: * Manual rebase (Manasi) Signed-off

[Intel-gfx] [PATCH v6 10/11] drm/i915: Add intel_update_bigjoiner handling.

2020-07-15 Thread Manasi Navare
From: Maarten Lankhorst Enabling is done in a special sequence and so should plane updates be. Ideally the end user never notices the second pipe is used, so use the vblank evasion to cover both pipes. This way ideally everything will be tear free, and updates are really atomic as userspace expe

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,01/11] HAX to make DSC work on the icelake test system

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system URL : https://patchwork.freedesktop.org/series/79534/ State : warning == Summary == $ dim checkpatch origin/drm-tip 97213337456c HAX to make DSC work on the icelake test system c5f13f6

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,01/11] HAX to make DSC work on the icelake test system

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system URL : https://patchwork.freedesktop.org/series/79534/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be check

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,01/11] HAX to make DSC work on the icelake test system

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system URL : https://patchwork.freedesktop.org/series/79534/ State : success == Summary == CI Bug Log - changes from CI_DRM_8752 -> Patchwork_18184 ===

Re: [Intel-gfx] [PATCH v7 3/5] drm/i915/rkl: Handle HTI

2020-07-15 Thread Matt Roper
On Tue, Jul 07, 2020 at 05:39:14PM -0700, Souza, Jose wrote: > On Tue, 2020-06-16 at 20:30 -0700, Matt Roper wrote: > > If HTI (also sometimes called HDPORT) is enabled at startup, it may be > > using some of the PHYs and DPLLs making them unavailable for general > > usage. Let's read out the HDPO

Re: [Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Matt Atwood
On Wed, Jul 15, 2020 at 11:27:15PM +0300, Imre Deak wrote: > On Wed, Jul 15, 2020 at 12:15:35PM -0700, Manasi Navare wrote: > > On Wed, Jul 15, 2020 at 07:29:31PM +0300, Imre Deak wrote: > > > The problem the reverted patch revealed could've been fixed by commit > > > 619ad4874585 ("drm/i915/ddi: D

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Only transfer the virtual context to the new engine if active

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Only transfer the virtual context to the new engine if active URL : https://patchwork.freedesktop.org/series/79524/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8751_full -> Patchwork_18182_full ==

Re: [Intel-gfx] [PATCH] Revert "Revert "drm/i915/dp: Correctly advertise HBR3 for GEN11+""

2020-07-15 Thread Imre Deak
On Wed, Jul 15, 2020 at 04:16:09PM -0700, Matt Atwood wrote: > On Wed, Jul 15, 2020 at 11:27:15PM +0300, Imre Deak wrote: > > On Wed, Jul 15, 2020 at 12:15:35PM -0700, Manasi Navare wrote: > > > On Wed, Jul 15, 2020 at 07:29:31PM +0300, Imre Deak wrote: > > > > The problem the reverted patch reveal

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Implement HOBL

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement HOBL URL : https://patchwork.freedesktop.org/series/79525/ State : success == Summary == CI Bug Log - changes from CI_DRM_8751_full -> Patchwork_18183_full Summary --- **SUCCES

Re: [Intel-gfx] [RFC 33/60] drm/i915/lmem: support pwrite

2020-07-15 Thread Dave Airlie
On Wed, 15 Jul 2020 at 00:35, Matthew Auld wrote: > > On 13/07/2020 06:09, Dave Airlie wrote: > > On Fri, 10 Jul 2020 at 22:00, Matthew Auld wrote: > >> > >> We need to add support for pwrite'ing an LMEM object. > > > > why? DG1 is a discrete GPU, these interfaces we already gross and > > overly

[Intel-gfx] [PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), ^~~ drivers/gpu/drm/i915/display/intel_combo_phy.c:261:10: note

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state URL : https://patchwork.freedesktop.org/series/79536/ State : warning == Summary == $ dim checkpatch origin/drm-tip b0efac00fd8c drm/i915/display: Ensure that ret is always initi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state URL : https://patchwork.freedesktop.org/series/79536/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8753 -> Patchwork_18185 =

Re: [Intel-gfx] [PATCH] drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state

2020-07-15 Thread Matt Roper
On Wed, Jul 15, 2020 at 09:27:42PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/i915/display/intel_combo_phy.c:268:3: warning: variable > 'ret' is uninitialized when used here [-Wuninitialized] > ret &= check_phy_reg(dev_priv, phy, ICL_PORT_TX_DW8_LN0(phy), >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,01/11] HAX to make DSC work on the icelake test system

2020-07-15 Thread Patchwork
== Series Details == Series: series starting with [v6,01/11] HAX to make DSC work on the icelake test system URL : https://patchwork.freedesktop.org/series/79534/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8752_full -> Patchwork_18184_full =

<    1   2