Re: [Intel-gfx] [PATCH] drm/i915/icl+: Fix hotplug interrupt disabling after storm detection

2020-06-15 Thread Imre Deak
On Fri, Jun 12, 2020 at 04:18:48PM +0300, Ville Syrjälä wrote: > On Fri, Jun 12, 2020 at 03:17:31PM +0300, Imre Deak wrote: > > Atm, hotplug interrupts on TypeC ports are left enabled after detecting > > an interrupt storm, fix this. > > > > Reported-by: Kunal Joshi > > References: https://gitlab

Re: [Intel-gfx] [PATCH 9/9] drm/shmem-helpers: Simplify dma-buf importing

2020-06-15 Thread Thomas Zimmermann
Hi Daniel this patch causes a segmentation fault. Am 11.05.20 um 11:35 schrieb Daniel Vetter: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add support for considering HDCP ver requested via debugfs

2020-06-15 Thread Nautiyal, Ankit K
Hi Anshuman, Thanks for the comments. Please find my response inline: On 6/15/2020 9:59 AM, Anshuman Gupta wrote: On 2020-06-08 at 15:31:02 +0530, Ankit Nautiyal wrote: For testing and debugging each HDCP version separately, a debugfs entry for requesting a specific version is required. The v

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Add a new debugfs to request HDCP version

2020-06-15 Thread Nautiyal, Ankit K
Hi Anshuman, Thanks for the review comments and suggestions. Please find my response inline: On 6/15/2020 10:15 AM, Anshuman Gupta wrote: On 2020-06-08 at 15:31:03 +0530, Ankit Nautiyal wrote: As per the current HDCP design, the driver selects the highest version of HDCP that can be used to s

[Intel-gfx] [PATCH 06/10] drm/i915/gt: ce->inflight updates are now serialised

2020-06-15 Thread Chris Wilson
Since schedule-in and schedule-out are now both always under the tasklet bitlock, we can reduce the individual atomic operations to simple instructions and worry less. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 43 - 1 file changed, 18 inser

[Intel-gfx] [PATCH 03/10] drm/i915/gt: Add a safety submission flush in the heartbeat

2020-06-15 Thread Chris Wilson
Just in case everything fails (like for example "missed interrupt syndrome" on Sandybridge), always flush the submission tasklet from the heartbeat. This papers over such issues, but will still appear as a second long glitch, and prevents us from detecting it unless we happen to be performing a tim

[Intel-gfx] [PATCH 09/10] drm/i915/gt: Decouple inflight virtual engines

2020-06-15 Thread Chris Wilson
Once a virtual engine has been bound to a sibling, it will remain bound until we finally schedule out the last active request. We can not rebind the context to a new sibling while it is inflight as the context save will conflict, hence we wait. As we cannot then use any other sibliing while the con

[Intel-gfx] [PATCH 01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Chris Wilson
Since the heartbeat may cause a preemption event, disable it over the preemption suppression tests. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/

[Intel-gfx] [PATCH 10/10] drm/i915/gt: Resubmit the virtual engine on schedule-out

2020-06-15 Thread Chris Wilson
Having recognised that we do not change the sibling until we schedule out, we can then defer the decision to resubmit the virtual engine from the unwind of the active queue to scheduling out of the virtual context. By keeping the unwind order intact on the local engine, we can preserve data depend

[Intel-gfx] [PATCH 05/10] drm/i915/execlists: Defer schedule_out until after the next dequeue

2020-06-15 Thread Chris Wilson
Inside schedule_out, we do extra work upon idling the context, such as updating the runtime, kicking off retires, kicking virtual engines. However, if we are in a series of processing single requests per contexts, we may find ourselves scheduling out the context, only to immediately schedule it bac

[Intel-gfx] [PATCH 07/10] drm/i915/gt: Drop atomic for engine->fw_active tracking

2020-06-15 Thread Chris Wilson
Since schedule-in/out is now entirely serialised by the tasklet bitlock, we do not need to worry about concurrent in/out operations and so reduce the atomic operations to plain instructions. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 02/10] drm/i915/selftests: Dump engine state and trace upon hanging after reset

2020-06-15 Thread Chris Wilson
If the engine dies after a reset, and so we fail to submit a request but need to be interrupted by the CI runner, dump the engine state. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gp

[Intel-gfx] [PATCH 08/10] drm/i915/gt: Use virtual_engine during execlists_dequeue

2020-06-15 Thread Chris Wilson
Rather than going back and forth between the rb_node entry and the virtual_engine type, store the ve local and reuse it. As the container_of conversion from rb_node to virtual_engine requires a variable offset, performing that conversion just once shaves off a bit of code. v2: Keep a single virtua

[Intel-gfx] [PATCH 04/10] drm/i915/execlists: Replace direct submit with direct call to tasklet

2020-06-15 Thread Chris Wilson
Rather than having special case code for opportunistically calling process_csb() and performing a direct submit while holding the engine spinlock for submitting the request, simply call the tasklet directly. This allows us to retain the direct submission path, including the CS draining to allow fas

Re: [Intel-gfx] [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value

2020-06-15 Thread Uwe Kleine-König
Hello Andy, On Fri, Jun 12, 2020 at 02:57:32PM +0300, Andy Shevchenko wrote: > On Fri, Jun 12, 2020 at 12:12:42AM +0200, Uwe Kleine-König wrote: > > I didn't follow the complete discussion but note that the general rule > > is: > > > > round period down to the next possible implementable peri

[Intel-gfx] [PATCH] drm/i915: remove unnecessary conversion to bool

2020-06-15 Thread Bernard Zhao
In function perform_bb_shadow, bb->ppgtt is bool, so maybe there is no need to convert the bool condition to bool. This change is to make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Intel-gfx] [PATCH] drm/i915/gt: Add a safety submission flush in the heartbeat

2020-06-15 Thread Chris Wilson
Just in case everything fails (like for example "missed interrupt syndrome" on Sandybridge), always flush the submission tasklet from the heartbeat. This papers over such issues, but will still appear as a second long glitch, and prevents us from detecting it unless we happen to be performing a tim

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove unnecessary conversion to bool

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: remove unnecessary conversion to bool URL : https://patchwork.freedesktop.org/series/78372/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17947 Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2) URL : https://patchwork.freedesktop.org/series/78371/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4a185d115cdb drm/i915/selftests: Disable

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2) URL : https://patchwork.freedesktop.org/series/78371/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used

[Intel-gfx] [PATCH] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin One i915_request_await_object is enough and we keep the one under the object lock so it is final. At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function. Signed-off-by: Tvrtko Ursulin Cc: Matthew Auld

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev2) URL : https://patchwork.freedesktop.org/series/78371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17948 ===

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-06-15 15:09:28) > From: Tvrtko Ursulin > > One i915_request_await_object is enough and we keep the one under the > object lock so it is final. > > At the same time move async clflushing setup under the same locked > section and consolidate common code into a helper f

[Intel-gfx] [PATCH] drm/i915/selftests: Dump engine state and trace upon hanging after reset

2020-06-15 Thread Chris Wilson
If the engine dies after a reset, and so we fail to submit a request but need to be interrupted by the CI runner, dump the engine state. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant i915_request_await_object in blit clears URL : https://patchwork.freedesktop.org/series/78374/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17949 Su

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Tvrtko Ursulin
On 15/06/2020 15:30, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-06-15 15:09:28) From: Tvrtko Ursulin One i915_request_await_object is enough and we keep the one under the object lock so it is final. At the same time move async clflushing setup under the same locked section and consoli

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3) URL : https://patchwork.freedesktop.org/series/78371/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5fa39ee36f3b drm/i915/selftests: Disable

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3) URL : https://patchwork.freedesktop.org/series/78371/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-06-15 15:54:56) > > On 15/06/2020 15:30, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-06-15 15:09:28) > >> From: Tvrtko Ursulin > >> > >> One i915_request_await_object is enough and we keep the one under the > >> object lock so it is final. > >> > >> At the sa

[Intel-gfx] [PATCH 2/3] drm/mm: optimize find_hole() as well

2020-06-15 Thread Christian König
Abort early if there isn't enough space to allocate from a subtree. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c| 11 +++ drivers/gpu/drm/selftests/test-drm_mm.c | 11 --- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH 3/3] drm/mm: cleanup and improve next_hole_*_addr()

2020-06-15 Thread Christian König
Skipping just one branch of the tree is not the most effective approach. Instead use a macro to define the traversal functions and sort out both branch sides. This improves the performance of the unit tests by a factor of more than 4. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c

[Intel-gfx] [PATCH 1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Christian König
Just some code cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 82d2888eb7fe..425fcd3590e8 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@

[Intel-gfx] [PATCH] drm/shmem-helper: Fix obj->filp derefence

2020-06-15 Thread Daniel Vetter
I broke that in my refactoring: commit 7d2cd72a9aa3df3604cafd169a2d4a525afb68ca Author: Daniel Vetter Date: Fri May 29 16:05:42 2020 +0200 drm/shmem-helpers: Simplify dma-buf importing Reported-by: Thomas Zimmermann Fixes: 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf importing") Cc

[Intel-gfx] [PATCH v2] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin One i915_request_await_object is enough and we keep the one under the object lock so it is final. At the same time move async clflushing setup under the same locked section and consolidate common code into a helper function. v2: * Emit initial breadcrumbs after aways are s

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3)

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests (rev3) URL : https://patchwork.freedesktop.org/series/78371/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17950 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/mm: remove unused rb_hole_size() URL : https://patchwork.freedesktop.org/series/78376/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4790c8cb3116 drm/mm: remove unused rb_hole_size() -:28: WARNING:NO_AUTHOR_SIGN_OFF: M

Re: [Intel-gfx] [PATCH 01/10] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Mika Kuoppala
Chris Wilson writes: > Since the heartbeat may cause a preemption event, disable it over the > preemption suppression tests. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 del

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/mm: remove unused rb_hole_size() URL : https://patchwork.freedesktop.org/series/78376/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17951 Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/shmem-helper: Fix obj->filp derefence

2020-06-15 Thread Patchwork
== Series Details == Series: drm/shmem-helper: Fix obj->filp derefence URL : https://patchwork.freedesktop.org/series/78378/ State : warning == Summary == $ dim checkpatch origin/drm-tip ce71e5b57288 drm/shmem-helper: Fix obj->filp derefence -:11: ERROR:GIT_COMMIT_ID: Please use git commit des

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Dump engine state and trace upon hanging after reset

2020-06-15 Thread Mika Kuoppala
Chris Wilson writes: > If the engine dies after a reset, and so we fail to submit a request > but need to be interrupted by the CI runner, dump the engine state. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 15 +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove unnecessary conversion to bool

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: remove unnecessary conversion to bool URL : https://patchwork.freedesktop.org/series/78372/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17947_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/shmem-helper: Fix obj->filp derefence

2020-06-15 Thread Patchwork
== Series Details == Series: drm/shmem-helper: Fix obj->filp derefence URL : https://patchwork.freedesktop.org/series/78378/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17952 Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Ruhl, Michael J
>-Original Message- >From: Tvrtko Ursulin >Sent: Monday, June 15, 2020 11:15 AM >To: Intel-gfx@lists.freedesktop.org >Cc: Ursulin, Tvrtko ; Auld, Matthew >; Chris Wilson ; Ruhl, >Michael J >Subject: [PATCH v2] drm/i915: Remove redundant i915_request_await_object >in blit clears > >From: T

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Tvrtko Ursulin
On 15/06/2020 17:11, Ruhl, Michael J wrote: -Original Message- From: Tvrtko Ursulin Sent: Monday, June 15, 2020 11:15 AM To: Intel-gfx@lists.freedesktop.org Cc: Ursulin, Tvrtko ; Auld, Matthew ; Chris Wilson ; Ruhl, Michael J Subject: [PATCH v2] drm/i915: Remove redundant i915_request_

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-06-15 16:14:49) > From: Tvrtko Ursulin > > One i915_request_await_object is enough and we keep the one under the > object lock so it is final. > > At the same time move async clflushing setup under the same locked > section and consolidate common code into a helper f

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add a safety submission flush in the heartbeat

2020-06-15 Thread Mika Kuoppala
Chris Wilson writes: > Just in case everything fails (like for example "missed interrupt > syndrome" on Sandybridge), always flush the submission tasklet from the > heartbeat. This papers over such issues, but will still appear as a > second long glitch, and prevents us from detecting it unless w

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-15 Thread Ville Syrjälä
On Fri, Jun 12, 2020 at 12:38:59PM -0700, Manasi Navare wrote: > On Fri, Jun 12, 2020 at 10:21:31PM +0300, Ville Syrjälä wrote: > > On Fri, Jun 12, 2020 at 12:12:25PM -0700, Manasi Navare wrote: > > > On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote: > > > > On Fri, Jun 12, 2020 at 11:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant i915_request_await_object in blit clears (rev2) URL : https://patchwork.freedesktop.org/series/78374/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17953

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Implement PSR2 selective fetch

2020-06-15 Thread Ville Syrjälä
On Fri, Jun 12, 2020 at 08:33:31PM +, Souza, Jose wrote: > On Fri, 2020-06-12 at 19:30 +0300, Ville Syrjälä wrote: > > On Tue, May 26, 2020 at 03:14:46PM -0700, José Roberto de Souza wrote: > > > All GEN12 platforms supports PSR2 selective fetch but not all GEN12 > > > platforms supports PSR2 h

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant i915_request_await_object in blit clears URL : https://patchwork.freedesktop.org/series/78374/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17949_full ==

[Intel-gfx] [CI 1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Chris Wilson
Since the heartbeat may cause a preemption event, disable it over the preemption suppression tests. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [CI 3/3] drm/i915/gt: Add a safety submission flush in the heartbeat

2020-06-15 Thread Chris Wilson
Just in case everything fails (like for example "missed interrupt syndrome" on Sandybridge), always flush the submission tasklet from the heartbeat. This papers over such issues, but will still appear as a second long glitch, and prevents us from detecting it unless we happen to be performing a tim

[Intel-gfx] [CI 2/3] drm/i915/selftests: Dump engine state and trace upon hanging after reset

2020-06-15 Thread Chris Wilson
If the engine dies after a reset, and so we fail to submit a request but need to be interrupted by the CI runner, dump the engine state. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 15 +++ 1 file changed, 15 insertions(+)

Re: [Intel-gfx] [PATCH 3/3] drm/mm: cleanup and improve next_hole_*_addr()

2020-06-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Skipping just one branch of the tree is not the most effective approach. Instead use a macro to define the traversal functions and sort out both branch sides. This improves the performance of the unit tests by a factor of more

Re: [Intel-gfx] [PATCH 1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Nirmoy
Reviewed-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Just some code cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 82d2888eb7fe..425fcd3590e

Re: [Intel-gfx] [PATCH 2/3] drm/mm: optimize find_hole() as well

2020-06-15 Thread Nirmoy
Acked-by: Nirmoy Das On 6/15/20 4:54 PM, Christian König wrote: Abort early if there isn't enough space to allocate from a subtree. Signed-off-by: Christian König --- drivers/gpu/drm/drm_mm.c| 11 +++ drivers/gpu/drm/selftests/test-drm_mm.c | 11 --- 2 file

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests URL : https://patchwork.freedesktop.org/series/78380/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5227b0190b79 drm/i915/selftests: Disable preem

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests URL : https://patchwork.freedesktop.org/series/78380/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests URL : https://patchwork.freedesktop.org/series/78380/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627 -> Patchwork_17954 =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/mm: remove unused rb_hole_size()

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/mm: remove unused rb_hole_size() URL : https://patchwork.freedesktop.org/series/78376/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17951_full ==

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove redundant i915_request_await_object in blit clears

2020-06-15 Thread Ruhl, Michael J
>-Original Message- >From: Tvrtko Ursulin >Sent: Monday, June 15, 2020 12:16 PM >To: Ruhl, Michael J ; Intel- >g...@lists.freedesktop.org >Cc: Ursulin, Tvrtko ; Auld, Matthew >; Chris Wilson >Subject: Re: [PATCH v2] drm/i915: Remove redundant >i915_request_await_object in blit clears > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/shmem-helper: Fix obj->filp derefence

2020-06-15 Thread Patchwork
== Series Details == Series: drm/shmem-helper: Fix obj->filp derefence URL : https://patchwork.freedesktop.org/series/78378/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17952_full Summary ---

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers

2020-06-15 Thread Mun, Gwan-gyeong
On Fri, 2020-06-12 at 21:49 +, Mun, Gwan-gyeong wrote: > On Fri, 2020-06-12 at 14:18 -0700, Souza, Jose wrote: > > On Fri, 2020-06-12 at 21:57 +0100, Mun, Gwan-gyeong wrote: > > > On Tue, 2020-05-26 at 15:14 -0700, José Roberto de Souza wrote: > > > > This registers will be used to implement PS

[Intel-gfx] [PATCH] drm/i915/gt: Don't flush the tasklet if not setup

2020-06-15 Thread Chris Wilson
If the tasklet is not being used, don't try and flush it. Fixes: 594893870044 ("drm/i915/gt: Add a safety submission flush in the heartbeat") Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drive

Re: [Intel-gfx] [PATCH] drm/i915/gt: Don't flush the tasklet if not setup

2020-06-15 Thread Mika Kuoppala
Chris Wilson writes: > If the tasklet is not being used, don't try and flush it. > > Fixes: 594893870044 ("drm/i915/gt: Add a safety submission flush in the > heartbeat") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_engi

Re: [Intel-gfx] [PATCH] drm/i915: Include asm sources for {ivb, hsw}_clear_kernel.c

2020-06-15 Thread Rodrigo Vivi
On Fri, Jun 12, 2020 at 02:15:02PM -0700, Bloomfield, Jon wrote: > > -Original Message- > > From: Intel-gfx On Behalf Of > > Rodrigo Vivi > > Sent: Wednesday, June 10, 2020 1:18 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Alexandre Oliva ; Nikula, Jani > > ; > > sta...@vger.kernel.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove redundant i915_request_await_object in blit clears (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant i915_request_await_object in blit clears (rev2) URL : https://patchwork.freedesktop.org/series/78374/ State : success == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17953_full ==

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers

2020-06-15 Thread Souza, Jose
On Mon, 2020-06-15 at 19:37 +0100, Mun, Gwan-gyeong wrote: > On Fri, 2020-06-12 at 21:49 +, Mun, Gwan-gyeong wrote: > > On Fri, 2020-06-12 at 14:18 -0700, Souza, Jose wrote: > > > On Fri, 2020-06-12 at 21:57 +0100, Mun, Gwan-gyeong wrote: > > > > On Tue, 2020-05-26 at 15:14 -0700, José Roberto

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests

2020-06-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Disable preemptive heartbeats over preemption tests URL : https://patchwork.freedesktop.org/series/78380/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8627_full -> Patchwork_17954_full ===

[Intel-gfx] [PATCH] drm/i915/selftests: Exercise far preemption rollbacks

2020-06-15 Thread Chris Wilson
Not too long ago, we realised we had issues with a rolling back a context so far for a preemption request we considered the resubmit not to be a rollback but a forward roll. This means we would issue a lite restore instead of forcing a full restore, continuing execution of the old requests rather t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Don't flush the tasklet if not setup

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Don't flush the tasklet if not setup URL : https://patchwork.freedesktop.org/series/78382/ State : success == Summary == CI Bug Log - changes from CI_DRM_8629 -> Patchwork_17955 Summary --- *

[Intel-gfx] [PATCH] drm/i915/selftests: Exercise far preemption rollbacks

2020-06-15 Thread Chris Wilson
Not too long ago, we realised we had issues with a rolling back a context so far for a preemption request we considered the resubmit not to be a rollback but a forward roll. This means we would issue a lite restore instead of forcing a full restore, continuing execution of the old requests rather t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise far preemption rollbacks

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise far preemption rollbacks URL : https://patchwork.freedesktop.org/series/78384/ State : warning == Summary == $ dim checkpatch origin/drm-tip 268ee667bc05 drm/i915/selftests: Exercise far preemption rollbacks -:19: ERROR:GIT_COMMIT_ID: P

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Exercise far preemption rollbacks

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise far preemption rollbacks URL : https://patchwork.freedesktop.org/series/78384/ State : success == Summary == CI Bug Log - changes from CI_DRM_8629 -> Patchwork_17956 Summary ---

Re: [Intel-gfx] [v3 6/8] drm/i915/display: Implement infoframes readback for LSPCON

2020-06-15 Thread Shankar, Uma
> -Original Message- > From: Ville Syrjälä > Sent: Thursday, June 11, 2020 9:31 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Mun, Gwan- > gyeong > Subject: Re: [v3 6/8] drm/i915/display: Implement infoframes readback for > LSPCON > > On Th

Re: [Intel-gfx] [v3 6/8] drm/i915/display: Implement infoframes readback for LSPCON

2020-06-15 Thread Ville Syrjälä
On Mon, Jun 15, 2020 at 08:39:55PM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: Thursday, June 11, 2020 9:31 PM > > To: Shankar, Uma > > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Mun, Gwan- > > gyeong > > Subject: Re: [

Re: [Intel-gfx] [v3 6/8] drm/i915/display: Implement infoframes readback for LSPCON

2020-06-15 Thread Shankar, Uma
> > > -Original Message- > > > From: Ville Syrjälä > > > Sent: Thursday, June 11, 2020 9:31 PM > > > To: Shankar, Uma > > > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; > > > Mun, Gwan- gyeong > > > Subject: Re: [v3 6/8] drm/i915/display: Implement infoframes > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise far preemption rollbacks (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise far preemption rollbacks (rev2) URL : https://patchwork.freedesktop.org/series/78384/ State : warning == Summary == $ dim checkpatch origin/drm-tip 39ae8f5dde72 drm/i915/selftests: Exercise far preemption rollbacks -:19: ERROR:GIT_COMMI

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-15 Thread Emil Velikov
Hi Daniel, On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote: > > The atomic helpers try really hard to not lose track of things, > duplicating enabled tracking in the driver is at best confusing. > Double-enabling or disabling is a bug in atomic helpers. > > In the fb_dirty function we can just

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-15 Thread Emil Velikov
Hi Manasi, On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote: > > From: Bhanuprakash Modem > > [Why] > It's useful to know the min and max vrr range for IGT testing. > > [How] > Expose the min and max vfreq for the connector via a debugfs file > on the connector, "vrr_range". > > Example usage:

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-15 Thread Manasi Navare
On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote: > Hi Manasi, > > On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote: > > > > From: Bhanuprakash Modem > > > > [Why] > > It's useful to know the min and max vrr range for IGT testing. > > > > [How] > > Expose the min and max vfreq for t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Exercise far preemption rollbacks (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise far preemption rollbacks (rev2) URL : https://patchwork.freedesktop.org/series/78384/ State : success == Summary == CI Bug Log - changes from CI_DRM_8630 -> Patchwork_17957 Summary -

[Intel-gfx] [drm-intel:for-linux-next-fixes 4/16] drivers/gpu/drm/i915/gt/selftest_lrc.c:1333:34: error: too few arguments to function call, expected 2, have 1

2020-06-15 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes head: add78d27d388520cbed6a7bf01d1e0afa183314d commit: 04dc41776145f539ab6da442cb633e45539bed9a [4/16] drm/i915/gt: Prevent timeslicing into unpreemptable requests config: x86_64-allyesconfig (attached as .config) compiler: cla

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Don't flush the tasklet if not setup

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Don't flush the tasklet if not setup URL : https://patchwork.freedesktop.org/series/78382/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8629_full -> Patchwork_17955_full Summary --

[Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2020-06-15 Thread Stephen Rothwell
Hi all, After merging the drm-intel-fixes tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5972: drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_nopreempt': drivers/gpu/drm/i915/gt/selftest_lrc.c:1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Exercise far preemption rollbacks (rev2)

2020-06-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise far preemption rollbacks (rev2) URL : https://patchwork.freedesktop.org/series/78384/ State : success == Summary == CI Bug Log - changes from CI_DRM_8630_full -> Patchwork_17957_full

[Intel-gfx] [drm-intel:for-linux-next-fixes 4/16] drivers/gpu/drm/i915/gt/selftest_lrc.c:1402:3: error: too few arguments to function 'engine_heartbeat_enable'

2020-06-15 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes head: add78d27d388520cbed6a7bf01d1e0afa183314d commit: 04dc41776145f539ab6da442cb633e45539bed9a [4/16] drm/i915/gt: Prevent timeslicing into unpreemptable requests config: i386-allmodconfig (attached as .config) compiler: gcc-9

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-15 Thread kernel test robot
Hi Manasi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next linus/master next-20200613] [cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next v5.7] [if your pat

Re: [Intel-gfx] [PATCH 7/8] drm/mipi-dbi: Remove ->enabled

2020-06-15 Thread Daniel Vetter
On Mon, Jun 15, 2020 at 11:35 PM Emil Velikov wrote: > > Hi Daniel, > > On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote: > > > > The atomic helpers try really hard to not lose track of things, > > duplicating enabled tracking in the driver is at best confusing. > > Double-enabling or disabling