On Mon, Apr 20, 2020 at 05:04:38PM +0300, Jani Nikula wrote:
> Remove a number of inlines from .c files, and let the compiler decide
> what's best. There's more to do, but need to start somewhere, and need
> to start setting the example.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i91
On Mon, Apr 20, 2020 at 05:04:37PM +0300, Jani Nikula wrote:
> Unused, hiding from the compiler warnings behind the inline keyword.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 6 --
> 1 file changed, 6 deletions(-)
>
> dif
== Series Details ==
Series: SAGV support for Gen12+ (rev26)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8328_full -> Patchwork_17381_full
Summary
---
**FAILURE
== Series Details ==
Series: series starting with [1/2] drm/i915/hdmi: remove unused
intel_hdmi_hdcp2_protocol()
URL : https://patchwork.freedesktop.org/series/76200/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8331 -> Patchwork_17385
===
igt_ppgtt_pin_update() invokes i915_gem_context_get_vm_rcu(), which
returns a reference of the i915_address_space object to "vm" with
increased refcount.
When igt_ppgtt_pin_update() returns, "vm" becomes invalid, so the
refcount should be decreased to keep refcount balanced.
The reference countin
If we can not manipulate the frequency with RPS, then comparing min/max
power consumption is pointless / misleading. We will leave the warning
about not being able to control the frequency selection via RPS to other
tests so as not to confuse this more specialised check.
Signed-off-by: Chris Wilso
If we encounter an error while scaling, read back the frequency tables
from the pcu.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 39 ++
1 file changed, 39 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest
After having testing all the RPS controls individually, we need to take
a step back and check how our RPS worker integrates them to perform
dynamic GPU reclocking. So do that by submitting a spinner and wait and
see what happens.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
---
driver
Check that the GPU does respond to our RPS frequency requests by setting
our desired frequency.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 1 +
drivers/gpu/drm/i915/gt/selftest_rps.c | 214 ---
drivers/gpu/drm/i9
Split the frequency measurement into two modes, so that we can judge the
impact of the llc setup on top of the pure CS frequency scaling.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 3 +-
drivers/gpu/drm/i915/gt/selftest_rps.c | 157
One of the core tenents of reclocking the GPU is that its throughput
scales with the clock frequency. We can observe this by incrementing a
loop counter on the GPU, and compare the different execution rates at
the notional RPS frequencies.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
-
== Series Details ==
Series: series starting with [CI,1/2] drm/dsc: use rc_model_size from DSC
config for PPS
URL : https://patchwork.freedesktop.org/series/76202/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8331 -> Patchwork_17386
==
Em seg, 2020-04-20 às 15:17 +0530, Karthik B S escreveu:
> Support added only for async flips on primary plane.
> If flip is requested on any other plane, reject it.
>
> Make sure there is no change in fbc, offset and framebuffer modifiers
> when async flip is requested.
>
> If any of these are m
Em seg, 2020-04-20 às 15:17 +0530, Karthik B S escreveu:
> Enable asynchronous flips in i915 for gen9+ platforms.
>
> v2: -Async flip enablement should be a stand alone patch (Paulo)
... and at the very end of the series.
If someone is bisecting the Kernel for some problem unrelated to async
fli
== Series Details ==
Series: series starting with [1/2] drm/i915/gem: Remove object_is_locked
assertion from unpin_from_display_plane
URL : https://patchwork.freedesktop.org/series/76194/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8328_full -> Patchwork_17382_full
== Series Details ==
Series: series starting with [CI,1/6] drm/i915/selftests: Verify frequency
scaling with RPS
URL : https://patchwork.freedesktop.org/series/76207/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
18dc228e78a3 drm/i915/selftests: Verify frequency scaling with R
On Mon, Apr 20, 2020 at 05:45:01PM +0300, Jani Nikula wrote:
> On Fri, 17 Apr 2020, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > No reason that I can see why we should enable TRANS_DDI_FUNC_CTL
> > before we set up the watermarks of confogiure the mbus stuff.
> > In fact reordering these
On Fri, Apr 17, 2020 at 02:51:39PM -0400, Lyude Paul wrote:
> Reviewed-by: Lyude Paul
>
Thanks. Series pushed to dinq.
> On Fri, 2020-04-17 at 18:27 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Make intel_dp_check_mst_status() somewhat legible by humans.
> >
> > Note that the
On Fri, Apr 17, 2020 at 08:51:35PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2020-04-17 14:47:19)
> > From: Ville Syrjälä
> >
> > Push the TRANS_DDI_FUNC_CTL into the encoder enable hook. The disable
> > is already there, and as a followup will enable us to pass the encoder
> > all the
== Series Details ==
Series: series starting with [CI,1/6] drm/i915/selftests: Verify frequency
scaling with RPS
URL : https://patchwork.freedesktop.org/series/76207/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8332 -> Patchwork_17387
===
Quoting Xiyu Yang (2020-04-20 06:41:54)
> igt_ppgtt_pin_update() invokes i915_gem_context_get_vm_rcu(), which
> returns a reference of the i915_address_space object to "vm" with
> increased refcount.
>
> When igt_ppgtt_pin_update() returns, "vm" becomes invalid, so the
> refcount should be decreas
== Series Details ==
Series: drm/i915/selftests: Fix i915_address_space refcnt leak
URL : https://patchwork.freedesktop.org/series/76209/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8333 -> Patchwork_17388
Summary
---
From: Ville Syrjälä
Sort out some of the mess between intel_ddi.c intel_dp.c by
introducing a .set_link_train() vfunc.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_ddi.c | 42 +
.../drm/i915/display/intel_display_types.h| 1 +
drivers/gpu/drm/i915/display
From: Ville Syrjälä
Sort out some of the mess between intel_ddi.c intel_dp.c by
introducing a .set_signal_levels() vfunc.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_ddi.c | 81 +++---
.../drm/i915/display/intel_display_types.h| 1 +
drivers/gpu/drm/i915
From: Ville Syrjälä
Relocate a binch of DDI specific code from intel_dp.c to intel_ddi.c
by introducing a .set_idle_link_train() vfunc.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_ddi.c | 29 +++
.../drm/i915/display/intel_display_types.h| 1 +
From: Ville Syrjälä
Split some overly long lines.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_ddi.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers/gpu/drm/i915/display/intel_ddi.c
index
On Wed, 2020-04-15 at 16:34 -0700, Matt Roper wrote:
> AUX power wells sometimes need additional handling besides just
> programming the specific power well registers:
> * Type-C PHY's also require additional Type-C register programming
> * ICL combo PHY's require additional workarounds
> * TGL
== Series Details ==
Series: series starting with [CI,1/6] drm/i915/selftests: Verify frequency
scaling with RPS
URL : https://patchwork.freedesktop.org/series/76210/
State : failure
== Summary ==
Applying: drm/i915/selftests: Verify frequency scaling with RPS
Using index info to reconstruct
We want to see the pstate limits whenever we fail to set the minimum
frequency as that may help for debugging.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c
b/drivers/gpu/drm/i9
== Series Details ==
Series: series starting with [1/2] drm/i915/hdmi: remove unused
intel_hdmi_hdcp2_protocol() (rev2)
URL : https://patchwork.freedesktop.org/series/76200/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8334 -> Patchwork_17390
== Series Details ==
Series: drm/i915/display: Fixed kernel taint in audio codec init
URL : https://patchwork.freedesktop.org/series/76195/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8329_full -> Patchwork_17383_full
Sum
Seems to be unrelated to SAGV, as it can't break module_reload only..
Best Regards,
Lisovskiy Stanislav
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
From: Patchwork
Sent: Monday, April 20, 2020 8:16:39 PM
To: Lisovskiy,
== Series Details ==
Series: series starting with [1/4] drm/i915: Introduce .set_link_train() vfunc
URL : https://patchwork.freedesktop.org/series/76213/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8334 -> Patchwork_17391
== Series Details ==
Series: SAGV support for Gen12+ (rev26)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8328_full -> Patchwork_17381_full
Summary
---
**SUCCESS
Stan, I have re-reported the results.
-Original Message-
From: Lisovskiy, Stanislav
Sent: Tuesday, April 21, 2020 12:05 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana
Subject: Re: ✗ Fi.CI.IGT: failure for SAGV support for Gen12+ (rev26)
Seems to be unrelated to SAGV, a
== Series Details ==
Series: drm/i915/audio: fix compressed_bpp check
URL : https://patchwork.freedesktop.org/series/76196/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8329_full -> Patchwork_17384_full
Summary
---
On Mon, 2020-04-20 at 23:06 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Sort out some of the mess between intel_ddi.c intel_dp.c by
> introducing a .set_link_train() vfunc.
>
Reviewed-by: José Roberto de Souza
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/int
== Series Details ==
Series: drm/i915/selftests: Show the pstate limits on any failure to reset min
URL : https://patchwork.freedesktop.org/series/76214/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8335 -> Patchwork_17392
== Series Details ==
Series: drm/i915/tgl: Wa_14011059788 (rev4)
URL : https://patchwork.freedesktop.org/series/75990/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8335 -> Patchwork_17393
Summary
---
**SUCCESS**
The RPS DOWN_TIMEOUT interrupt is signaled after a period of rc6, and
upon receipt of that interrupt we reprogram the GPU clocks down to the
next idle notch [to help convserve power during rc6]. However, on
execlists, we benefit from soft-rc6 immediately parking the GPU and
setting idle frequencies
== Series Details ==
Series: drm/i915/gt: Prefer soft-rc6 over RPS DOWN_TIMEOUT
URL : https://patchwork.freedesktop.org/series/76216/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.
== Series Details ==
Series: series starting with [CI,1/2] drm/dsc: use rc_model_size from DSC
config for PPS
URL : https://patchwork.freedesktop.org/series/76202/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8331_full -> Patchwork_17386_full
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:he drm-misc
tree with the drm-misc-fixes tree
drivers/gpu/drm/tidss/tidss_encoder.c
between commit:
9da67433f64e ("drm/tidss: fix crash related to accessing freed memory")
from the drm-misc-fixes tree and commit:
b
On 4/21/20 00:21, Ville Syrjälä wrote:
> On Mon, Apr 20, 2020 at 04:22:07PM +0800, Liwei Song wrote:
>> Import the kernel's i915_pciids.h, up to:
>>
>> commit 8717c6b7414ffb890672276dccc284c23078ac0e
>> Author: Lee Shawn C
>> Date: Tue Dec 10 23:04:15 2019 +0800
>>
>> drm/i915/cml: Separat
[rmk Cc'd]
On Fri, Apr 03, 2020 at 09:52:05PM +0100, Al Viro wrote:
> I can do a 5.7-rc1-based branch with that; depending upon what we end
> up doing for arm and s390 we can always change the calling conventions
> come next cycle ;-/
>
> My impressions after digging through arm side of things:
>
== Series Details ==
Series: drm/i915/selftests: Fix i915_address_space refcnt leak
URL : https://patchwork.freedesktop.org/series/76209/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8333_full -> Patchwork_17388_full
Summa
On Mon, Apr 20, 2020 at 01:09:05PM -0700, Souza, Jose wrote:
> On Wed, 2020-04-15 at 16:34 -0700, Matt Roper wrote:
> > AUX power wells sometimes need additional handling besides just
> > programming the specific power well registers:
> > * Type-C PHY's also require additional Type-C register prog
== Series Details ==
Series: series starting with [1/2] drm/i915/hdmi: remove unused
intel_hdmi_hdcp2_protocol() (rev2)
URL : https://patchwork.freedesktop.org/series/76200/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8334_full -> Patchwork_17390_full
==
On Mon, 20 Apr 2020, Ville Syrjälä wrote:
> On Mon, Apr 20, 2020 at 05:04:37PM +0300, Jani Nikula wrote:
>> Unused, hiding from the compiler warnings behind the inline keyword.
>>
>> Signed-off-by: Jani Nikula
>
> Reviewed-by: Ville Syrjälä
Thanks, pushed both.
BR,
Jani.
>
>> ---
>> driver
Hi,
On 21/04/2020 04:52, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:he drm-misc
tree with the drm-misc-fixes tree
drivers/gpu/drm/tidss/tidss_encoder.c
between commit:
9da67433f64e ("drm/tidss: fix crash related to accessing freed m
On Mon, 20 Apr 2020, "Shankar, Uma" wrote:
>> -Original Message-
>> From: Jani Nikula
>> Sent: Monday, April 20, 2020 6:47 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani ; Gupta, Anshuman
>> ; Shankar, Uma
>> Subject: [PATCH] drm/i915/audio: fix compressed_bpp check
>>
>>
Quoting Sultan Alsawaf (2020-04-20 19:15:14)
> On Mon, Apr 20, 2020 at 11:21:42AM +0300, Joonas Lahtinen wrote:
> > So it seems that the patch got pulled into v5.6 and has been backported
> > to v5.5 but not v5.4.
>
> You're right, that's my mistake.
Did applying the patch to v5.4 fix the issue a
On Mon, 06 Apr 2020, Pankaj Bharadiya
wrote:
> struct drm_device specific drm_WARN* macros include device information
> in the backtrace, so we know what device the warnings originate from.
>
> Prefer drm_WARN* over WARN* calls.
>
> Signed-off-by: Pankaj Bharadiya
> ---
> drivers/gpu/drm/i915/d
On Mon, 06 Apr 2020, Pankaj Bharadiya
wrote:
> struct drm_device specific drm_WARN* macros include device information
> in the backtrace, so we know what device the warnings originate from.
The patch no longer applies.
>
> Prefer drm_WARN* over WARN* at places where struct intel_dp struct
> poi
On Mon, 06 Apr 2020, Pankaj Bharadiya
wrote:
> struct drm_device specific drm_WARN* macros include device information
> in the backtrace, so we know what device the warnings originate from.
>
> Prefer drm_WARN_ON over WARN_ON.
>
> Conversion is done with below sementic patch:
>
> @@
> identifier
101 - 155 of 155 matches
Mail list logo
