Re: [Intel-gfx] [PATCH i-g-t v15] tests: Add a test for device hot unplug

2020-04-16 Thread Petri Latvala
On Wed, Apr 15, 2020 at 03:15:15PM +0200, Janusz Krzysztofik wrote: > From: Janusz Krzysztofik > > There is a test which verifies unloading of i915 driver module but no > test exists that checks how a driver behaves when it gets unbound from > a device or when the device gets unplugged. Implemen

Re: [Intel-gfx] [PATCH v4] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Shankar, Uma
> -Original Message- > From: Gupta, Anshuman > Sent: Tuesday, April 14, 2020 7:47 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; Vehmanen, Kai ; > jani.nik...@linux.intel.com > Subject: Re: [PATCH v4] drm/i915/display: Enable DP Display Audio WA > > On 2020-04-07 at 21:4

[Intel-gfx] [PATCH v2] drm/i915/gt: Move the batch buffer pool from the engine to the gt

2020-04-16 Thread Chris Wilson
Since the introduction of 'soft-rc6', we aim to park the device quickly and that results in frequent idling of the whole device. Currently upon idling we free the batch buffer pool, and so this renders the cache ineffective for many workloads. If we want to have an effective cache of recently alloc

[Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Uma Shankar
For certain DP VDSC bpp settings, hblank asserts before hblank_early, leading to a bad audio state. Driver need to program "hblank early enable" and "samples per line" parameters in AUDIO_CONFIG_BE register. This is Display Audio WA #1406928334 for 4k+VDSC usecase applicable on DP encoders. Implem

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2) URL : https://patchwork.freedesktop.org/series/75979/ State : warning == Summary == $ dim checkpatch origin/drm-tip d3fac4ed4941 drm/i915/gt: Move the batch buffer pool from the engine to the

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2) URL : https://patchwork.freedesktop.org/series/75979/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: dup

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the batch buffer pool from the engine to the gt (rev2) URL : https://patchwork.freedesktop.org/series/75979/ State : success == Summary == CI Bug Log - changes from CI_DRM_8307 -> Patchwork_17322 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for Per client engine busyness

2020-04-16 Thread Patchwork
== Series Details == Series: Per client engine busyness URL : https://patchwork.freedesktop.org/series/75967/ State : success == Summary == CI Bug Log - changes from CI_DRM_8300_full -> Patchwork_17306_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Enable DP Display Audio WA (rev5)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev5) URL : https://patchwork.freedesktop.org/series/75582/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i91

[Intel-gfx] [PATCH i-g-t v16] tests: Add a test for device hot unplug

2020-04-16 Thread Janusz Krzysztofik
From: Janusz Krzysztofik There is a test which verifies unloading of i915 driver module but no test exists that checks how a driver behaves when it gets unbound from a device or when the device gets unplugged. Implement such test using sysfs interface. Two minimalistic subtests - "unbind-rebind

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Enable DP Display Audio WA (rev5)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev5) URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8307 -> Patchwork_17323 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gt: remove redundant assignment to variable x

2020-04-16 Thread Dan Carpenter
On Wed, Apr 15, 2020 at 12:07:44PM +0300, Jani Nikula wrote: > On Tue, 14 Apr 2020, Colin Ian King wrote: > > Hi Dan, > > > > I'd post a revert, but I don't seem to see an upstream commit for this > > this to revert against. What's the revert policy in these cases? Or can > > the patch be just ign

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Adding YUV444 packed format support for skl+ (V15)

2020-04-16 Thread Jani Nikula
On Wed, 08 Apr 2020, Jani Nikula wrote: > On Tue, 07 Apr 2020, Bob Paauwe wrote: >> From: Stanislav Lisovskiy >> >> PLANE_CTL_FORMAT_AYUV is already supported, according to hardware >> specification. >> >> v2: Edited commit message, removed redundant whitespaces. >> >> v3: Fixed fallthrough log

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-04-16 Thread Maarten Lankhorst
Hey, Seems we're lacking error handling still when get fails? ~Maarten Op 13-04-2020 om 08:34 schreef Animesh Manna: > Pre-allocate command buffer in atomic_commit using intel_dsb_prepare > function which also includes pinning and map in cpu domain. > > No change is dsb write/commit functions. >

Re: [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check

2020-04-16 Thread Jani Nikula
On Sun, 29 Mar 2020, Ramalingam C wrote: > On 2020-03-28 at 11:41:00 +0100, Oliver Barta wrote: >> From: Oliver Barta >> >> The check was always succeeding even in case of a mismatch due to the >> HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. >> > Looks good to me: > > Re

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-04-16 Thread Manna, Animesh
On 16-04-2020 15:19, Maarten Lankhorst wrote: Hey, Seems we're lacking error handling still when get fails? Hi Maarten, Error handling is taken care by dsb-framework, if _prepare() is failed then dsb->cmd_buf will be null and during dsb-write() mmio-write will be used to program registers.

Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Anshuman Gupta
On 2020-04-16 at 13:17:21 +0530, Uma Shankar wrote: > For certain DP VDSC bpp settings, hblank asserts before hblank_early, > leading to a bad audio state. Driver need to program "hblank early > enable" and "samples per line" parameters in AUDIO_CONFIG_BE > register. > > This is Display Audio WA #

Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Anshuman Gupta wrote: > IMHO with control flow this function above initilization is not > required. > u may remove this initilization if u agree, while pushing the patch. I don't recommend anyone changing anything even remotely functional while pushing. I'm fine

Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Thursday, April 16, 2020 3:43 PM > To: Gupta, Anshuman ; Shankar, Uma > > Cc: intel-gfx@lists.freedesktop.org; Vehmanen, Kai > Subject: Re: [v5] drm/i915/display: Enable DP Display Audio WA > > On Thu, 16 Apr 2020, Anshuman Gupta wrot

[Intel-gfx] [v6] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Uma Shankar
For certain DP VDSC bpp settings, hblank asserts before hblank_early, leading to a bad audio state. Driver need to program "hblank early enable" and "samples per line" parameters in AUDIO_CONFIG_BE register. This is Display Audio WA #1406928334 for 4k+VDSC usecase applicable on DP encoders. Implem

[Intel-gfx] [PATCH] drm/i915/gt: Scrub execlists state on resume

2020-04-16 Thread Chris Wilson
Before we resume, we reset the HW so we restart from a known good state. However, as a part of the reset process, we drain our pending CS event queue -- and if we are resuming that does not correspond to internal state. On setup, we are scrubbing the CS pointers, but alas only on setup. Apply the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Move the batch buffer pool from the engine to the gt

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Move the batch buffer pool from the engine to the gt URL : https://patchwork.freedesktop.org/series/75979/ State : success == Summary == CI Bug Log - changes from CI_DRM_8301_full -> Patchwork_17310_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Enable DP Display Audio WA (rev6)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev6) URL : https://patchwork.freedesktop.org/series/75582/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i91

[Intel-gfx] [PATCH v2] drm/i915/perf: Enable application triggered OA reports

2020-04-16 Thread Lionel Landwerlin
Gen12 brought an important redesign of the OA unit, splitting it in 2 with a per context part (OAR) and a global part (OAG). OAR deals with per context counters and implements the MI_REPORT_PERF_COUNT command. OAG deals with global counters and the OA buffer. Unfortunately some of the counters a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Enable DP Display Audio WA (rev6)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Enable DP Display Audio WA (rev6) URL : https://patchwork.freedesktop.org/series/75582/ State : success == Summary == CI Bug Log - changes from CI_DRM_8309 -> Patchwork_17324 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for SAGV support for Gen12+ (rev21)

2020-04-16 Thread Patchwork
== Series Details == Series: SAGV support for Gen12+ (rev21) URL : https://patchwork.freedesktop.org/series/75129/ State : success == Summary == CI Bug Log - changes from CI_DRM_8301_full -> Patchwork_17312_full Summary --- **SUCCESS

Re: [Intel-gfx] [PULL] topic/phy-compliance

2020-04-16 Thread Joonas Lahtinen
Quoting Jani Nikula (2020-04-15 10:48:15) > On Wed, 15 Apr 2020, Daniel Vetter wrote: > > On Wed, Apr 15, 2020 at 8:40 AM Jani Nikula > > wrote: > >> > >> On Wed, 08 Apr 2020, Maarten Lankhorst > >> wrote: > >> > Hey, > >> > > >> > Here's a pull request to pull in the DP PHY Compliance series.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Scrub execlists state on resume

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Scrub execlists state on resume URL : https://patchwork.freedesktop.org/series/76026/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layou

Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2020-04-16 Thread Rodrigo Siqueira
Hi Maxime, First of all, thank you a lot for your review and for testing this patchset. I'm going to prepare a new version trying to address all issues highlight by you, Petri, and Simon (I'm already working in a new version). Just a note, I run this test on top of VKMS in a virtual machine (x86)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Scrub execlists state on resume

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Scrub execlists state on resume URL : https://patchwork.freedesktop.org/series/76026/ State : success == Summary == CI Bug Log - changes from CI_DRM_8310 -> Patchwork_17325 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Enable application triggered OA reports (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/perf: Enable application triggered OA reports (rev2) URL : https://patchwork.freedesktop.org/series/75310/ State : warning == Summary == $ dim checkpatch origin/drm-tip f12265d9a10d drm/i915/perf: Enable application triggered OA reports -:26: WARNING:COMMI

Re: [Intel-gfx] [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-16 Thread Alex Deucher
On Wed, Apr 15, 2020 at 6:05 AM Jani Nikula wrote: > > > Alex, Harry, Christian, can you please eyeball this series and see if it > makes sense for you? > Patches 4, 5 are: Acked-by: Alex Deucher Feel free to take them through whichever tree you want. Alex > Thanks, > Jani. > > > On Tue, 07 A

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/perf: Enable application triggered OA reports (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/perf: Enable application triggered OA reports (rev2) URL : https://patchwork.freedesktop.org/series/75310/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate labe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Enable application triggered OA reports (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/perf: Enable application triggered OA reports (rev2) URL : https://patchwork.freedesktop.org/series/75310/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17326 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/selftests: Exercise basic RPS interrupt generation

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/selftests: Exercise basic RPS interrupt generation URL : https://patchwork.freedesktop.org/series/75983/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8302_full -> Patchwork_17314_full ===

Re: [Intel-gfx] [PATCH v7 i-g-t 3/4] lib: Add function to hash a framebuffer

2020-04-16 Thread Maxime Ripard
Hi, On Thu, Apr 16, 2020 at 08:49:42AM -0400, Rodrigo Siqueira wrote: > First of all, thank you a lot for your review and for testing this > patchset. I'm going to prepare a new version trying to address all > issues highlight by you, Petri, and Simon (I'm already working in a new > version). Tha

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 lpsp support for lpsp igt (rev9)

2020-04-16 Thread Patchwork
== Series Details == Series: i915 lpsp support for lpsp igt (rev9) URL : https://patchwork.freedesktop.org/series/74648/ State : success == Summary == CI Bug Log - changes from CI_DRM_8302_full -> Patchwork_17315_full Summary --- **W

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Chris Wilson
For many configuration details within RC6 and RPS we are programming intervals for the internal clocks. From gen11, these clocks are configuration via the RPM_CONFIG and so for convenience, we would like to convert to/from more natural units (ns). Signed-off-by: Chris Wilson Cc: Andi Shyti Cc: M

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Trace RPS events

2020-04-16 Thread Chris Wilson
Add tracek to the RPS events (interrupts, worker, enabling, threshold selection, frequency setting), so that if we have to debug reticent HW we have some traces to start from. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_rps.c | 47 ++--- 1 file changed,

[Intel-gfx] [PATCH v2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Chris Wilson
For many configuration details within RC6 and RPS we are programming intervals for the internal clocks. From gen11, these clocks are configuration via the RPM_CONFIG and so for convenience, we would like to convert to/from more natural units (ns). Signed-off-by: Chris Wilson Cc: Andi Shyti Cc: M

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Trace RPS events

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events URL : https://patchwork.freedesktop.org/series/76036/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2aaa5fffbe7c drm/i915/gt: Trace RPS events 1e6b7b0ed0e3 drm/i915/gt: Use the RPM config regi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add missing deinitialization cases of load failure URL : https://patchwork.freedesktop.org/series/75987/ State : success == Summary == CI Bug Log - changes from CI_DRM_8302_full -> Patchwork_17316_full

Re: [Intel-gfx] [PATCH 1/3] drm/i915/display: Load DP_TP_CTL/STATUS offset before use it

2020-04-16 Thread Souza, Jose
On Wed, 2020-04-15 at 20:56 -0700, Matt Roper wrote: > On Tue, Apr 14, 2020 at 04:04:40PM -0700, José Roberto de Souza > wrote: > > Right now dp.regs.dp_tp_ctl/status are only set during the encoder > > pre_enable() hook, what is causing all reads and writes to those > > registers to go to offset 0

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/gt: Trace RPS events

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events URL : https://patchwork.freedesktop.org/series/76036/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gp

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/gt: Trace RPS events

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events URL : https://patchwork.freedesktop.org/series/76036/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17327 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Trace RPS events (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events (rev2) URL : https://patchwork.freedesktop.org/series/76036/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8557361fae6d drm/i915/gt: Trace RPS events 7a6ae457560a drm/i915/gt: Use the RPM conf

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Imre Deak
On Wed, Apr 15, 2020 at 12:14:08PM -0700, José Roberto de Souza wrote: > The intel_display_power_put_async() used in TC cold sequences made > easy to hit the missing deinitialization of driver in case of load > failure as seen in the stack trace bellow. > > intel_modeset_driver_remove_noirq() had

[Intel-gfx] [PATCH v2] drm/i915/icl: Update forcewake firmware ranges

2020-04-16 Thread Radhakrishna Sripada
Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1222 v2: Simplify the table and use 0 for some unused ranges(Matt) Cc: Matt Roper Sig

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/gt: Trace RPS events (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events (rev2) URL : https://patchwork.freedesktop.org/series/76036/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate la

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/gt: Trace RPS events (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events (rev2) URL : https://patchwork.freedesktop.org/series/76036/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17328 Summar

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Souza, Jose
On Thu, 2020-04-16 at 19:42 +0300, Imre Deak wrote: > On Wed, Apr 15, 2020 at 12:14:08PM -0700, José Roberto de Souza > wrote: > > The intel_display_power_put_async() used in TC cold sequences made > > easy to hit the missing deinitialization of driver in case of load > > failure as seen in the sta

[Intel-gfx] [PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Ville Syrjala
From: Ville Syrjälä Revert back to comparing fb->format->format instead fb->format for the page flip ioctl. This check was originally only here to disallow pixel format changes, but when we changed it to do the pointer comparison we potentially started to reject some (but definitely not all) modi

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Imre Deak
On Thu, Apr 16, 2020 at 08:03:39PM +0300, Souza, Jose wrote: > On Thu, 2020-04-16 at 19:42 +0300, Imre Deak wrote: > > On Wed, Apr 15, 2020 at 12:14:08PM -0700, José Roberto de Souza > > wrote: > > > The intel_display_power_put_async() used in TC cold sequences made > > > easy to hit the missing de

Re: [Intel-gfx] [PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Revert back to comparing fb->format->format instead fb->format for the > page flip ioctl. This check was originally only here to disallow pixel > format changes, but when

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam (rev2) URL : https://patchwork.freedesktop.org/series/75895/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate la

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Souza, Jose
On Thu, 2020-04-16 at 20:06 +0300, Imre Deak wrote: > On Thu, Apr 16, 2020 at 08:03:39PM +0300, Souza, Jose wrote: > > On Thu, 2020-04-16 at 19:42 +0300, Imre Deak wrote: > > > On Wed, Apr 15, 2020 at 12:14:08PM -0700, José Roberto de Souza > > > wrote: > > > > The intel_display_power_put_async() u

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam (rev2) URL : https://patchwork.freedesktop.org/series/75895/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17329 Summar

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Imre Deak
On Thu, Apr 16, 2020 at 08:20:23PM +0300, Souza, Jose wrote: > On Thu, 2020-04-16 at 20:06 +0300, Imre Deak wrote: > > On Thu, Apr 16, 2020 at 08:03:39PM +0300, Souza, Jose wrote: > > > On Thu, 2020-04-16 at 19:42 +0300, Imre Deak wrote: > > > > On Wed, Apr 15, 2020 at 12:14:08PM -0700, José Robert

Re: [Intel-gfx] [PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Ville Syrjälä
On Thu, Apr 16, 2020 at 08:08:14PM +0300, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Revert back to comparing fb->format->format instead fb->format for the > > page flip ioct

[Intel-gfx] [PATCH v2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Chris Wilson
For many configuration details within RC6 and RPS we are programming intervals for the internal clocks. From gen11, these clocks are configuration via the RPM_CONFIG and so for convenience, we would like to convert to/from more natural units (ns). Signed-off-by: Chris Wilson Cc: Andi Shyti Cc: M

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/icl: Update forcewake firmware ranges (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/icl: Update forcewake firmware ranges (rev2) URL : https://patchwork.freedesktop.org/series/75864/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i

[Intel-gfx] [PATCH] drm/i915/selftests: Add request throughput measurement to perf

2020-04-16 Thread Chris Wilson
Under ideal circumstances, the driver should be able to keep the GPU fully saturated with work. Measure how close to ideal we get under the harshest of conditions with no user payload. v2: Also measure throughput using only one thread. Signed-off-by: Chris Wilson --- .../drm/i915/selftests/i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Update forcewake firmware ranges (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/icl: Update forcewake firmware ranges (rev2) URL : https://patchwork.freedesktop.org/series/75864/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17330 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: Fix page flip ioctl format check

2020-04-16 Thread Patchwork
== Series Details == Series: drm: Fix page flip ioctl format check URL : https://patchwork.freedesktop.org/series/76040/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layout, othe

Re: [Intel-gfx] [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Alex Deucher wrote: > On Wed, Apr 15, 2020 at 6:05 AM Jani Nikula wrote: >> >> >> Alex, Harry, Christian, can you please eyeball this series and see if it >> makes sense for you? >> > > Patches 4, 5 are: > Acked-by: Alex Deucher > Feel free to take them through whichever tre

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/gt: Trace RPS events (rev3)

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Trace RPS events (rev3) URL : https://patchwork.freedesktop.org/series/76036/ State : failure == Summary == Applying: drm/i915/gt: Trace RPS events Applying: drm/i915/gt: Use the RPM config register to determine clk frequenci

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Fix page flip ioctl format check

2020-04-16 Thread Patchwork
== Series Details == Series: drm: Fix page flip ioctl format check URL : https://patchwork.freedesktop.org/series/76040/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17331 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib

2020-04-16 Thread Chris Wilson
Move the handy utility to measure the GPU energy consumption using RAPL msr into a common lib so that it can be reused easily. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile| 3 ++- drivers/gpu/drm/i915/gt/selftest_rc6.c | 25 +-- drivers/gpu/drm

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Check power consumption at min/max frequencies

2020-04-16 Thread Chris Wilson
A basic premise of RPS is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. For example, when idle, we set the minimum frequency just in case there is some residual current. Since the power curve should be a physical relationship, if we find no

Re: [Intel-gfx] [PATCH v5 8/8] drm/i915/tc: Do not warn when aux power well of static TC ports timeout

2020-04-16 Thread Imre Deak
On Tue, Apr 14, 2020 at 12:49:56PM -0700, José Roberto de Souza wrote: > This is a expected timeout of static TC ports not conneceted, so > not throwing warnings that would taint CI. > > v3: > - moved checks to tc_phy_aux_timeout_expected() > > v4: > - moved and add comments to tc_phy_aux_timeout

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Add request throughput measurement to perf (rev3)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add request throughput measurement to perf (rev3) URL : https://patchwork.freedesktop.org/series/73930/ State : warning == Summary == $ dim checkpatch origin/drm-tip a685a79c5061 drm/i915/selftests: Add request throughput measurement to perf -:9

[Intel-gfx] [PATCH v4] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread José Roberto de Souza
The intel_display_power_put_async() used in TC cold sequences made easy to hit the missing deinitialization of driver in case of load failure as seen in the stack trace bellow. intel_modeset_driver_remove_noirq() had to be removed from i915_driver_modeset_remove_noirq() as those are different init

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/selftests: Add request throughput measurement to perf (rev3)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add request throughput measurement to perf (rev3) URL : https://patchwork.freedesktop.org/series/73930/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplic

Re: [Intel-gfx] [PATCH v2] drm/i915: Add missing deinitialization cases of load failure

2020-04-16 Thread Souza, Jose
On Wed, 2020-04-15 at 20:36 +0100, Chris Wilson wrote: > Quoting José Roberto de Souza (2020-04-15 20:14:08) > > + i915_reset_error_state(i915); > > If you are bored, we should move this to unregister as that is the > last > point at which it can be accessed from userspace. Hopefully I > rem

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Add request throughput measurement to perf (rev3)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add request throughput measurement to perf (rev3) URL : https://patchwork.freedesktop.org/series/73930/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17333

Re: [Intel-gfx] [PATCH] drm/i915: Document locking guidelines

2020-04-16 Thread Dave Airlie
Acked-by: Dave Airlie On Tue, 5 Nov 2019 at 21:06, Joonas Lahtinen wrote: > > Dave, ping for Acked-by here so we can merge? You already gave an > early ack in IRC while travelling. > > Regards, Joonas > > Quoting Joonas Lahtinen (2019-08-30 13:50:53) > > To ensure cross-driver locking compatibil

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib URL : https://patchwork.freedesktop.org/series/76044/ State : warning == Summary == $ dim checkpatch origin/drm-tip 04da6c2d287e drm/i915/selftests: Move gpu energy

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib URL : https://patchwork.freedesktop.org/series/76044/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu

[Intel-gfx] [PATCH] drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Chris Wilson
It seems that although (perhaps because of the memory stall?) the spinner has signaled that it has started, it still takes some time to spin up to 100% utilisation of the HW. Since the test depends on the full utilisation of the HW to trigger the RPS interrupt, wait a little bit and flush the inter

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib URL : https://patchwork.freedesktop.org/series/76044/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17334

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add missing deinitialization cases of load failure (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add missing deinitialization cases of load failure (rev2) URL : https://patchwork.freedesktop.org/series/75987/ State : warning == Summary == $ dim checkpatch origin/drm-tip a685f486207f drm/i915: Add missing deinitialization cases of load failure -:17: W

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Add missing deinitialization cases of load failure (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add missing deinitialization cases of load failure (rev2) URL : https://patchwork.freedesktop.org/series/75987/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicat

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Andi Shyti
Hi Chris, > For many configuration details within RC6 and RPS we are programming > intervals for the internal clocks. From gen11, these clocks are > configuration via the RPM_CONFIG and so for convenience, we would like > to convert to/from more natural units (ns). > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Chris Wilson
Quoting Andi Shyti (2020-04-16 21:31:10) > Hi Chris, > > > For many configuration details within RC6 and RPS we are programming > > intervals for the internal clocks. From gen11, these clocks are > > configuration via the RPM_CONFIG and so for convenience, we would like > > to convert to/from more

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Andi Shyti
Hi Chris, On Thu, Apr 16, 2020 at 09:33:52PM +0100, Chris Wilson wrote: > Quoting Andi Shyti (2020-04-16 21:31:10) > > Hi Chris, > > > > > For many configuration details within RC6 and RPS we are programming > > > intervals for the internal clocks. From gen11, these clocks are > > > configuration

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing deinitialization cases of load failure (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add missing deinitialization cases of load failure (rev2) URL : https://patchwork.freedesktop.org/series/75987/ State : success == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17335 Su

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl: Wa_14011059788 (rev2)

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Wa_14011059788 (rev2) URL : https://patchwork.freedesktop.org/series/75990/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8304_full -> Patchwork_17318_full Summary --- **FAI

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: Check power consumption at min/max frequencies

2020-04-16 Thread Andi Shyti
Hi Chris, > +static u64 __measure_power(int duration_ms) > +{ > + u64 nrg, dt; > + > + dt = -ktime_get(); > + nrg = -st_energy_uJ(); > + msleep(5); usleep_range? Reviewed-by: Andi Shyti Thanks, Andi ___ Intel-gfx mailing list Intel-gf

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Delay spinner before waiting for an interrupt URL : https://patchwork.freedesktop.org/series/76049/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Delay spinner before waiting for an interrupt URL : https://patchwork.freedesktop.org/series/76049/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17336 Summ

[Intel-gfx] [PATCH 4/5] drm/i915/selftests: Move gpu energy measurement into its own little lib

2020-04-16 Thread Chris Wilson
Move the handy utility to measure the GPU energy consumption using RAPL msr into a common lib so that it can be reused easily. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile| 3 ++- drivers/gpu/drm/i915/gt/selftest_rc6.c | 25 +-- drivers/gpu/drm

[Intel-gfx] [PATCH 1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Chris Wilson
It seems that although (perhaps because of the memory stall?) the spinner has signaled that it has started, it still takes some time to spin up to 100% utilisation of the HW. Since the test depends on the full utilisation of the HW to trigger the RPS interrupt, wait a little bit and flush the inter

[Intel-gfx] [PATCH 2/5] drm/i915/gt: Trace RPS events

2020-04-16 Thread Chris Wilson
Add tracek to the RPS events (interrupts, worker, enabling, threshold selection, frequency setting), so that if we have to debug reticent HW we have some traces to start from. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_rps.c | 47 ++--- 1 file changed,

[Intel-gfx] [PATCH 5/5] drm/i915/selftests: Check power consumption at min/max frequencies

2020-04-16 Thread Chris Wilson
A basic premise of RPS is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. For example, when idle, we set the minimum frequency just in case there is some residual current. Since the power curve should be a physical relationship, if we find no

[Intel-gfx] [PATCH 3/5] drm/i915/gt: Use the RPM config register to determine clk frequencies

2020-04-16 Thread Chris Wilson
For many configuration details within RC6 and RPS we are programming intervals for the internal clocks. From gen11, these clocks are configuration via the RPM_CONFIG and so for convenience, we would like to convert to/from more natural units (ns). Signed-off-by: Chris Wilson Cc: Andi Shyti Cc: M

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt URL : https://patchwork.freedesktop.org/series/76052/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a7f8f2b844b drm/i915/selftests: Delay spinner before w

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt URL : https://patchwork.freedesktop.org/series/76052/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 /home/cidrm/kernel/Documentation/gpu/i915.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/selftests: Delay spinner before waiting for an interrupt URL : https://patchwork.freedesktop.org/series/76052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8311 -> Patchwork_17337 ==

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/tgl: TBT AUX should use TC power well ops

2020-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tgl: TBT AUX should use TC power well ops URL : https://patchwork.freedesktop.org/series/75998/ State : success == Summary == CI Bug Log - changes from CI_DRM_8305_full -> Patchwork_17319_full ===

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Adding YUV444 packed format support for skl+ (V15)

2020-04-16 Thread Paauwe, Bob J
> -Original Message- > From: Jani Nikula > Sent: Thursday, April 16, 2020 2:10 AM > To: Paauwe, Bob J ; intel-gfx g...@lists.freedesktop.org> > Cc: Daniel Vetter > Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Adding YUV444 packed format > support for skl+ (V15) > > On Wed, 08 Apr 2020

  1   2   >