Re: [Intel-gfx] [PATCH v2 03/17] drm: Nuke mode->vrefresh

2020-04-06 Thread Jani Nikula
On Fri, 03 Apr 2020, abhin...@codeaurora.org wrote: > On 2020-04-03 13:39, Ville Syrjala wrote: >> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c >> index fec1c33b3045..e3d5f011f7bd 100644 >> --- a/drivers/gpu/drm/drm_modes.c >> +++ b/drivers/gpu/drm/drm_modes.c >> @@ -759,9

[Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add the missing igt_dynamic to dynamic rcs* test selection

2020-04-06 Thread Chris Wilson
An important ingredient to using igt_subtest_with_dynamic is to include an igt_dynamic at some point. Reported-by: Petri Latvala Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests") Signed-off-by: Chris Wilson Cc: Petri Latvala --- tests/perf_pmu.c | 3 ++- 1 file changed, 2 inse

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add the missing igt_dynamic to dynamic rcs* test selection

2020-04-06 Thread Petri Latvala
On Mon, Apr 06, 2020 at 09:53:09AM +0100, Chris Wilson wrote: > An important ingredient to using igt_subtest_with_dynamic is to include > an igt_dynamic at some point. > > Reported-by: Petri Latvala > Fixes: 311cb1b360b7 ("i915/perf_pmu: Dynamic active engine tests") > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2 16/17] drm: Nuke mode->private_flags

2020-04-06 Thread Jani Nikula
On Fri, 03 Apr 2020, abhin...@codeaurora.org wrote: > Hi Ville > > Thanks for the patch. > > Our understanding of private_flags was that we can use it within our > drivers to handle vendor specific features. > Hence we do have several features in our downstream drivers as well as > some planned w

[Intel-gfx] [PATCH 1/5] drm/i915: Make exclusive awaits on i915_active optional

2020-04-06 Thread Chris Wilson
Later use will require asynchronous waits on the active timelines, but will not utilize an async wait on the exclusive channel. Make the await on the exclusive fence explicit in the selection flags. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 7 --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 4/5] drm/i915/gem: Assign context id for async work

2020-04-06 Thread Chris Wilson
Allocate a few dma fence context id that we can use to associate async work [for the CPU] launched on behalf of this context. For extra fun, we allow a configurable concurrency width. A current example would be that we spawn an unbound worker for every userptr get_pages. In the future, we wish to

[Intel-gfx] [PATCH 5/5] drm/i915: Export a preallocate variant of i915_active_acquire()

2020-04-06 Thread Chris Wilson
Sometimes we have to be very careful not to allocate underneath a mutex (or spinlock) and yet still want to track activity. Enter i915_active_acquire_for_context(). This raises the activity counter on i915_active prior to use and ensures that the fence-tree contains a slot for the context. Signed-

[Intel-gfx] [PATCH 2/5] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Chris Wilson
Allow the caller to also wait upon the barriers stored in i915_active. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 60 ++ drivers/gpu/drm/i915/i915_active.h | 1 + 2 files changed, 61 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_acti

[Intel-gfx] [PATCH 3/5] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-04-06 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. So wait until the

[Intel-gfx] [PATCH i-g-t] i915/suspend: Suspend once before taking forcewake to confirm suspend

2020-04-06 Thread Chris Wilson
If we take the user-forcewake and then exit, we find outselves in a deadlock as the atexit handlers wait for our own forcewake to be released. We could either not use the automatically attached exit handler (__drm_open_driver), more carefully unwind the exit handler, or simply avoid doing late requ

[Intel-gfx] [PATCH i-g-t] i915/gem_tiled_fence_blits: Trim workload

2020-04-06 Thread Chris Wilson
Similar to gem_tiled_blits and gem_linear_blits, we only need to just force the system to be thrashing the GTT for the test to be effective, so trim the working set to just a be one element larger than could fit, and parallelise the checking across multiple cpus. Closes: https://gitlab.freedesktop

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional URL : https://patchwork.freedesktop.org/series/75535/ State : success == Summary == CI Bug Log - changes from CI_DRM_8259 -> Patchwork_17215

[Intel-gfx] [PATCH i-g-t] i915/gem_busy: Drop i915_hangcheck_info

2020-04-06 Thread Chris Wilson
All the information for hangcheck is pulled into i915_engine_info so the separate dump is redundant. Signed-off-by: Chris Wilson Cc: Andi Shyti --- tests/i915/gem_busy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c index 64e6fe6bd..5e4e2d939 1

Re: [Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging

2020-04-06 Thread Bharadiya,Pankaj
On Thu, Apr 02, 2020 at 02:48:04PM +0300, Jani Nikula wrote: > Convert all the DRM_* logging macros to the struct drm_device based > macros to provide device specific logging. > > No functional changes. > > Generated using the following semantic patch, originally written by > Wambui Karuga , with

Re: [Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging

2020-04-06 Thread Jani Nikula
On Mon, 06 Apr 2020, "Bharadiya,Pankaj" wrote: > On Thu, Apr 02, 2020 at 02:48:04PM +0300, Jani Nikula wrote: >> Convert all the DRM_* logging macros to the struct drm_device based >> macros to provide device specific logging. >> >> No functional changes. >> >> Generated using the following sem

Re: [Intel-gfx] [PATCH 04/17] drm/i915/dp: use struct drm_device based logging

2020-04-06 Thread Bharadiya,Pankaj
On Thu, Apr 02, 2020 at 02:48:06PM +0300, Jani Nikula wrote: > Convert all the DRM_* logging macros to the struct drm_device based > macros to provide device specific logging. > > No functional changes. > > Generated using the following semantic patch, originally written by > Wambui Karuga , with

Re: [Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging

2020-04-06 Thread Bharadiya,Pankaj
On Mon, Apr 06, 2020 at 02:07:44PM +0300, Jani Nikula wrote: > On Mon, 06 Apr 2020, "Bharadiya,Pankaj" > wrote: > > On Thu, Apr 02, 2020 at 02:48:04PM +0300, Jani Nikula wrote: > >> Convert all the DRM_* logging macros to the struct drm_device based > >> macros to provide device specific logging.

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_busy: Drop i915_hangcheck_info

2020-04-06 Thread Andi Shyti
Hi Chris, On Mon, Apr 06, 2020 at 12:00:26PM +0100, Chris Wilson wrote: > All the information for hangcheck is pulled into i915_engine_info so the > separate dump is redundant. > > Signed-off-by: Chris Wilson > Cc: Andi Shyti Reviewed-by: Andi Shyti now we can get rid of i915_hangcheck_info.

[Intel-gfx] [PATCH 01/18] drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Intel-gfx] [PATCH 00/18] Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
Now we have struct drm_device specific drm_WARN* macros which include device information in the backtrace, so we know what device the warnings originate from. This series converts WARN* with drm_WARN* where struct drm_device pointer can be extracted. This series is the continuation of: https://pa

[Intel-gfx] [PATCH 02/18] drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 4 ++-- 1 file changed, 2 inserti

[Intel-gfx] [PATCH 03/18] drm/i915/display/ddi: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN* calls. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_ddi.c | 14 -- 1 file changed, 8 ins

[Intel-gfx] [PATCH 06/18] drm/i915/display/dp: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN* at places where struct intel_dp struct pointer is available. Conversion is done with below sementic patch: @@ identifier func,

[Intel-gfx] [PATCH 08/18] drm/i915/display/frontbuffer: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 -- 1 file changed, 4 insert

[Intel-gfx] [PATCH 07/18] drm/i915/display/dpll_mgr: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON at places where struct drm_device pointer can be extracted. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH 09/18] drm/i915/display/global_state: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN* calls. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_global_state.c | 4 ++-- 1 file changed, 2 inser

[Intel-gfx] [PATCH 12/18] drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Conversion is done with below sementic patch: @@ identifier func, T; @@ func(struct intel_digital_port *T,...) { <+... -WA

[Intel-gfx] [PATCH 10/18] drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_overlay.c | 6 +++--- 1 file changed, 3 insertions

[Intel-gfx] [PATCH 11/18] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN* calls. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_sdvo.c | 16 +--- 1 file changed, 9

[Intel-gfx] [PATCH 05/18] drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON at places where struct i915_power_domains struct is available. Conversion is done with below sementic patch: @@ identifier

[Intel-gfx] [PATCH 04/18] drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON at places where struct drm_device pointer can be extracted. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH 18/18] drm/i915/runtime_pm: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN*. Conversion is done with below semantic patch: @@ identifier func, T; @@ func(struct intel_runtime_pm *T,...) { + struct drm_i9

[Intel-gfx] [PATCH 14/18] drm/i915/gem: Prefer drm_WARN* over WARN*

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN* over WARN* at places where struct drm_device pointer can be extracted. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/gem/i915_

[Intel-gfx] [PATCH 17/18] drm/i915/pm: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Conversion is done with below sementic patch: @@ identifier func, T; @@ func(...) { ... struct intel_crtc *T = ...; <+...

[Intel-gfx] [PATCH 15/18] drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[Intel-gfx] [PATCH 13/18] drm/i915/display/vlv_dsi: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Intel-gfx] [PATCH 16/18] drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON

2020-04-06 Thread Pankaj Bharadiya
struct drm_device specific drm_WARN* macros include device information in the backtrace, so we know what device the warnings originate from. Prefer drm_WARN_ON over WARN_ON. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_pmu.c | 11 --- 1 file changed, 8 insertions(+), 3

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Make exclusive awaits on i915_active optional

2020-04-06 Thread Tvrtko Ursulin
On 06/04/2020 10:12, Chris Wilson wrote: Later use will require asynchronous waits on the active timelines, but will not utilize an async wait on the exclusive channel. Make the await on the exclusive fence explicit in the selection flags. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH] drm/i915/gem: Flush all the reloc_gpu batch

2020-04-06 Thread Chris Wilson
__i915_gem_object_flush_map() takes a byte range, so feed it the written bytes and do not mistake the u32 index as bytes! Fixes: a679f58d0510 ("drm/i915: Flush pages on acquisition") Signed-off-by: Chris Wilson Cc: Matthew Auld Cc: # v5.2+ --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8

Re: [Intel-gfx] [PATCH 16/44] drm/udl: don't set drm_device->dev_private

2020-04-06 Thread Thomas Zimmermann
Am 03.04.20 um 15:58 schrieb Daniel Vetter: > We're mostly there already, just a handful of places that didn't use > the to_udl container_of cast. To make sure no new appear, don't set > ->dev_private. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Sean Paul > Cc: Emil Velikov > Cc

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN*

2020-04-06 Thread Patchwork
== Series Details == Series: Prefer drm_WARN* over WARN* URL : https://patchwork.freedesktop.org/series/75543/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b3269120530 drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON ce36d1d4c808 drm/i915/display/atomic_plane: Prefer

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-06 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > The kerneldoc is only added for this new function. Existing kerneldoc > and examples will be udated at the very end, since once all drivers > are converted over to devm_drm_dev_alloc we can unexpo

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Tvrtko Ursulin
On 06/04/2020 10:12, Chris Wilson wrote: Allow the caller to also wait upon the barriers stored in i915_active. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 60 ++ drivers/gpu/drm/i915/i915_active.h | 1 + 2 files changed, 61 insertions

Re: [Intel-gfx] [PATCH 3/5] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-04-06 Thread Tvrtko Ursulin
On 06/04/2020 10:12, Chris Wilson wrote: If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-06 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 2:01 PM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > > The kerneldoc is only added for this new function. Existing kerneldoc > > and examples will be udated at the very end, since onc

[Intel-gfx] ✗ Fi.CI.BAT: failure for Prefer drm_WARN* over WARN*

2020-04-06 Thread Patchwork
== Series Details == Series: Prefer drm_WARN* over WARN* URL : https://patchwork.freedesktop.org/series/75543/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8259 -> Patchwork_17216 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-06 Thread Daniel Vetter
On Fri, Apr 3, 2020 at 3:58 PM Daniel Vetter wrote: > > In drm we've added nice drm_device (the main gpu driver thing, which > also represents the userspace interfaces and has everything else > dangling off it) init functions using devres, devm_drm_dev_init and > soon devm_drm_dev_alloc (this patc

[Intel-gfx] [PATCH] drm/i915/gem: Take DBG_FORCE_RELOC into account prior to using reloc_gpu

2020-04-06 Thread Chris Wilson
If we set the debug flag to force ourselves not to relocate via the gpu, do not relocate via the gpu. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_

Re: [Intel-gfx] [PATCH 02/17] drm/i915/panel: use struct drm_device based logging

2020-04-06 Thread Jani Nikula
On Mon, 06 Apr 2020, "Bharadiya,Pankaj" wrote: > Adding new i915 variable seems to be redundant here since we can > directly use "connector->base.dev" for getting struct drm_device > pointer. We could. However, struct drm_i915_private *i915 is widely used and needed throughout the driver, all o

Re: [Intel-gfx] [PATCH 04/17] drm/i915/dp: use struct drm_device based logging

2020-04-06 Thread Jani Nikula
On Mon, 06 Apr 2020, "Bharadiya,Pankaj" wrote: > On Thu, Apr 02, 2020 at 02:48:06PM +0300, Jani Nikula wrote: >> Convert all the DRM_* logging macros to the struct drm_device based >> macros to provide device specific logging. >> >> No functional changes. >> >> Generated using the following sem

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Flush all the reloc_gpu batch

2020-04-06 Thread Patchwork
== Series Details == Series: drm/i915/gem: Flush all the reloc_gpu batch URL : https://patchwork.freedesktop.org/series/75544/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8259 -> Patchwork_17217 Summary --- **FAILU

Re: [Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement TC cold sequences

2020-04-06 Thread Imre Deak
On Fri, Apr 03, 2020 at 04:18:54AM +0300, Souza, Jose wrote: > Hi Imre > > I guess I did all the requested changes but trybot got some > warnings that I will need more time to understand and fix it. > > If you have time please check if is this way that you are asking: > https://github.com/zehorti

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-04-06 13:06:03) > > On 06/04/2020 10:12, Chris Wilson wrote: > > Allow the caller to also wait upon the barriers stored in i915_active. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/i915_active.c | 60 ++ > > driv

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Chris Wilson
Quoting Chris Wilson (2020-04-06 14:09:44) > Quoting Tvrtko Ursulin (2020-04-06 13:06:03) > > > > On 06/04/2020 10:12, Chris Wilson wrote: > > > Allow the caller to also wait upon the barriers stored in i915_active. > > > > > > Signed-off-by: Chris Wilson > > > --- > > > drivers/gpu/drm/i915/i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Take DBG_FORCE_RELOC into account prior to using reloc_gpu

2020-04-06 Thread Patchwork
== Series Details == Series: drm/i915/gem: Take DBG_FORCE_RELOC into account prior to using reloc_gpu URL : https://patchwork.freedesktop.org/series/75546/ State : success == Summary == CI Bug Log - changes from CI_DRM_8259 -> Patchwork_17218 ===

[Intel-gfx] [PATCH v2] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Chris Wilson
Allow the caller to also wait upon the barriers stored in i915_active. v2: Hook up i915_request_await_active(I915_ACTIVE_AWAIT_BARRIER) as well for completeness, and avoid the lazy GEM_BUG_ON()! v3: Pull flush_lazy_signals() under the active-ref protection as it too walks the rbtree and so we mus

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional URL : https://patchwork.freedesktop.org/series/75535/ State : success == Summary == CI Bug Log - changes from CI_DRM_8259_full -> Patchwork_17215_full ==

Re: [Intel-gfx] [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-06 Thread Greg Kroah-Hartman
On Mon, Apr 06, 2020 at 02:32:51PM +0200, Daniel Vetter wrote: > On Fri, Apr 3, 2020 at 3:58 PM Daniel Vetter wrote: > > > > In drm we've added nice drm_device (the main gpu driver thing, which > > also represents the userspace interfaces and has everything else > > dangling off it) init functions

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Lionel Landwerlin
On 31/03/2020 21:08, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-03-31 12:48:21) Add 2 new properties to the i915-perf open ioctl to specify an array of GEM context handles as well as the length of the array. Hmm. The other thought is ctx->engine[] where one context may have more than o

[Intel-gfx] [PATCH 2/3] drm/i915/perf: prepare driver to receive multiple ctx handles

2020-04-06 Thread Lionel Landwerlin
Make all the internal necessary changes before we flip the switch. v2: Use an unlimited number of intel contexts (Chris) Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 587 +++-- drivers/gpu/drm/i915/i915_perf_types.h | 23 +- 2 files changed,

[Intel-gfx] [PATCH 1/3] drm/i915/perf: break OA config buffer object in 2

2020-04-06 Thread Lionel Landwerlin
We want to enable performance monitoring on multiple contexts to cover the Iris use case of using 2 GEM contexts (3D & compute). So start by breaking the OA configuration BO which contains global & per context register writes. NOA muxes & OA configurations are global, while FLEXEU register config

Re: [Intel-gfx] [PATCH 01/44] drivers/base: Always release devres on device_del

2020-04-06 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 3:38 PM Greg Kroah-Hartman wrote: > > On Mon, Apr 06, 2020 at 02:32:51PM +0200, Daniel Vetter wrote: > > On Fri, Apr 3, 2020 at 3:58 PM Daniel Vetter wrote: > > > > > > In drm we've added nice drm_device (the main gpu driver thing, which > > > also represents the userspace

[Intel-gfx] [PATCH 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Lionel Landwerlin
Add 2 new properties to the i915-perf open ioctl to specify an array of GEM context handles as well as the length of the array. This can be used by drivers using multiple GEM contexts to implement a single GL context. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 58 ++

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-06 14:54:38) > On 31/03/2020 21:08, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2020-03-31 12:48:21) > >> Add 2 new properties to the i915-perf open ioctl to specify an array > >> of GEM context handles as well as the length of the array. > > Hmm. The other

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Lionel Landwerlin
On 06/04/2020 16:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-06 14:54:38) On 31/03/2020 21:08, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-03-31 12:48:21) Add 2 new properties to the i915-perf open ioctl to specify an array of GEM context handles as well as the length of

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional (rev2)

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Make exclusive awaits on i915_active optional (rev2) URL : https://patchwork.freedesktop.org/series/75535/ State : success == Summary == CI Bug Log - changes from CI_DRM_8260 -> Patchwork_17219 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/perf: break OA config buffer object in 2

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75550/ State : warning == Summary == $ dim checkpatch origin/drm-tip d78a933fe510 drm/i915/perf: break OA config buffer object in 2 -:27: CH

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-06 15:07:30) > On 06/04/2020 16:59, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2020-04-06 14:54:38) > >> On 31/03/2020 21:08, Chris Wilson wrote: > >>> Quoting Lionel Landwerlin (2020-03-31 12:48:21) > Add 2 new properties to the i915-perf open ioctl

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Lionel Landwerlin
On 06/04/2020 17:27, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-06 15:07:30) On 06/04/2020 16:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-04-06 14:54:38) On 31/03/2020 21:08, Chris Wilson wrote: Quoting Lionel Landwerlin (2020-03-31 12:48:21) Add 2 new properties to t

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] drm/i915/perf: break OA config buffer object in 2

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75550/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Fun

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/perf: enable filtering on multiple contexts

2020-04-06 Thread Chris Wilson
Quoting Lionel Landwerlin (2020-04-06 15:30:38) > On 06/04/2020 17:27, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2020-04-06 15:07:30) > >> On 06/04/2020 16:59, Chris Wilson wrote: > >>> Quoting Lionel Landwerlin (2020-04-06 14:54:38) > On 31/03/2020 21:08, Chris Wilson wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/gem: Flush all the reloc_gpu batch

2020-04-06 Thread Matthew Auld
On Mon, 6 Apr 2020 at 12:48, Chris Wilson wrote: > > __i915_gem_object_flush_map() takes a byte range, so feed it the written > bytes and do not mistake the u32 index as bytes! > > Fixes: a679f58d0510 ("drm/i915: Flush pages on acquisition") > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/perf: break OA config buffer object in 2

2020-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/perf: break OA config buffer object in 2 URL : https://patchwork.freedesktop.org/series/75550/ State : success == Summary == CI Bug Log - changes from CI_DRM_8260 -> Patchwork_17220 ==

Re: [Intel-gfx] [PATCH] drm/i915/gem: Take DBG_FORCE_RELOC into account prior to using reloc_gpu

2020-04-06 Thread Matthew Auld
On Mon, 6 Apr 2020 at 13:36, Chris Wilson wrote: > > If we set the debug flag to force ourselves not to relocate via the gpu, > do not relocate via the gpu. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN* (rev2)

2020-04-06 Thread Patchwork
== Series Details == Series: Prefer drm_WARN* over WARN* (rev2) URL : https://patchwork.freedesktop.org/series/75543/ State : warning == Summary == $ dim checkpatch origin/drm-tip fd886b340869 drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON 5a021e68d20b drm/i915/display/atomic_plane:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Extend hotplug detect retry on TypeC connectors to 5 seconds

2020-04-06 Thread Imre Deak
On Mon, Mar 30, 2020 at 10:13:02PM +0300, Souza, Jose wrote: > On Mon, 2020-03-30 at 12:54 +0300, Imre Deak wrote: > > On TypeC ports if a sink deasserts/reasserts its HPD signal, > > generating > > a hotplug interrupt without the sink getting unplugged/replugged from > > the connector, there can b

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern

2020-04-06 Thread Manasi Navare
On Mon, Mar 16, 2020 at 04:07:59PM +0530, Animesh Manna wrote: > This patch process phy compliance request by programming requested > vswing, pre-emphasis and test pattern. > > v1: Initial patch. > v2: Fixes added during testing with test-scope. (Khaled/Clint/Manasi) > - pipe used as argument duri

[Intel-gfx] ✓ Fi.CI.BAT: success for Prefer drm_WARN* over WARN* (rev2)

2020-04-06 Thread Patchwork
== Series Details == Series: Prefer drm_WARN* over WARN* (rev2) URL : https://patchwork.freedesktop.org/series/75543/ State : success == Summary == CI Bug Log - changes from CI_DRM_8260 -> Patchwork_17221 Summary --- **SUCCESS** N

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Andreas Bergmeier
The problem of data transfer costs is not new in Cloud environments. At work we usually just opt for paying for it since dev time is scarser. For private projects though, I opt for aggressive (remote) caching. So you can setup a global cache in Google Cloud Storage and more local caches wherever yo

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Nicolas Dufresne
Le samedi 04 avril 2020 à 08:11 -0700, Rob Clark a écrit : > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion! I

Re: [Intel-gfx] [PATCH v3] drm/i915: Synchronize active and retire callbacks

2020-04-06 Thread Sultan Alsawaf
On Fri, Apr 03, 2020 at 03:35:15PM -0700, Sultan Alsawaf wrote: > + ref->retire(ref); > + mutex_unlock(&ref->callback_lock); Ugh, this patch is still wrong because the mutex unlock after ref->retire() is a use-after-free. Fun times... Sultan ___

Re: [Intel-gfx] [PATCH v8 12/12] doc/admin-guide: update kernel.rst with CAP_PERFMON information

2020-04-06 Thread Arnaldo Carvalho de Melo
Em Sun, Apr 05, 2020 at 05:54:37PM +0300, Alexey Budankov escreveu: > > On 05.04.2020 17:41, Alexey Budankov wrote: > > > > On 05.04.2020 17:10, Arnaldo Carvalho de Melo wrote: > >> Em Thu, Apr 02, 2020 at 11:54:39AM +0300, Alexey Budankov escreveu: > >>> > >>> Update kernel.rst documentation fil

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Peter Hutterer
On Sat, Apr 04, 2020 at 08:11:23AM -0700, Rob Clark wrote: > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion

Re: [Intel-gfx] [PATCH v8 12/12] doc/admin-guide: update kernel.rst with CAP_PERFMON information

2020-04-06 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 02, 2020 at 11:54:39AM +0300, Alexey Budankov escreveu: > > Update kernel.rst documentation file with the information > related to usage of CAP_PERFMON capability to secure performance > monitoring and observability operations in system. This one is failing in my perf/core branch, ple

Re: [Intel-gfx] [PATCH v2 5/5] uaccess: Rename user_access_begin/end() to user_full_access_begin/end()

2020-04-06 Thread Christophe Leroy
Le 03/04/2020 à 20:01, Linus Torvalds a écrit : On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy wrote: Now we have user_read_access_begin() and user_write_access_begin() in addition to user_access_begin(). I realize Al asked for this, but I don't think it really adds anything to the serie

[Intel-gfx] [PULL] drm-misc-next-fixes

2020-04-06 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week round of drm-misc-next fixes. Thanks! Maxime drm-misc-next-fixes-2020-04-04: A bunch of fixes to avoid null pointer dereference in fbcon, fix a return in xen, some DT bindings fixes, a vc4 issue with 1920x1200 mode validation, and a conflicting framebuffer in vb

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Peter Hutterer
On Sat, Apr 04, 2020 at 11:16:08AM -0700, Rob Clark wrote: > On Sat, Apr 4, 2020 at 10:47 AM Nicolas Dufresne wrote: > > > > Le samedi 04 avril 2020 à 08:11 -0700, Rob Clark a écrit : > > > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > >

Re: [Intel-gfx] [PATCH 2/6] i915/gvt/kvm: a NULL ->mm does not mean a thread is a kthread

2020-04-06 Thread Sergei Shtylyov
Hello! On 04.04.2020 12:40, Christoph Hellwig wrote: Use the proper API instead. Fixes: f440c8a572d7 ("drm/i915/gvt/kvmgt: read/write GPA via KVM API") Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Nicolas Dufresne
Le samedi 04 avril 2020 à 15:55 +0200, Andreas Bergmeier a écrit : > The problem of data transfer costs is not new in Cloud environments. At work > we usually just opt for paying for it since dev time is scarser. For private > projects though, I opt for aggressive (remote) caching. > So you can s

[Intel-gfx] [PATCH i-g-t] i915/i915_hangman: Drop last reference to bygone 'i915_error_state'

2020-04-06 Thread Chris Wilson
The test is looking at sysfs/error so dumping the old debugfs/i915_error_state looks quite silly. The only dilemma is whether it is worth replacing with a line-by-line dump. I propose we make that a future problem -- and leave it to whoever has to debug it next time. Signed-off-by: Chris Wilson -

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Adam Jackson
On Sat, 2020-04-04 at 08:11 -0700, Rob Clark wrote: > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion! I implem

Re: [Intel-gfx] [PATCH v2] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Tvrtko Ursulin
On 06/04/2020 14:21, Chris Wilson wrote: Allow the caller to also wait upon the barriers stored in i915_active. v2: Hook up i915_request_await_active(I915_ACTIVE_AWAIT_BARRIER) as well for completeness, and avoid the lazy GEM_BUG_ON()! v3: Pull flush_lazy_signals() under the active-ref protec

[Intel-gfx] [CI 1/3] drm/i915: Make exclusive awaits on i915_active optional

2020-04-06 Thread Chris Wilson
Later use will require asynchronous waits on the active timelines, but will not utilize an async wait on the exclusive channel. Make the await on the exclusive fence explicit in the selection flags. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_active.c |

[Intel-gfx] [CI 3/3] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-04-06 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. So wait until the

[Intel-gfx] [CI 2/3] drm/i915: Allow asynchronous waits on the i915_active barriers

2020-04-06 Thread Chris Wilson
Allow the caller to also wait upon the barriers stored in i915_active. v2: Hook up i915_request_await_active(I915_ACTIVE_AWAIT_BARRIER) as well for completeness, and avoid the lazy GEM_BUG_ON()! v3: Pull flush_lazy_signals() under the active-ref protection as it too walks the rbtree and so we mus

Re: [Intel-gfx] [PATCH 1/6] amdgpu: a NULL ->mm does not mean a thread is a kthread

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:40 a.m. schrieb Christoph Hellwig: > Use the proper API instead. > > Fixes: 70539bd795002 ("drm/amd: Update MEC HQD loading code for KFD") > Signed-off-by: Christoph Hellwig Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- > 1 file chan

Re: [Intel-gfx] [PATCH 4/6] kernel: move use_mm/unuse_mm to kthread.c

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:40 a.m. schrieb Christoph Hellwig: > These helpers are only for use with kernel threads, and I will tie them > more into the kthread infrastructure going forward. Also move the > prototypes to kthread.h - mmu_context.h was a little weird to start with > as it otherwise contains

Re: [Intel-gfx] [PATCH i-g-t] i915/i915_hangman: Drop last reference to bygone 'i915_error_state'

2020-04-06 Thread Andi Shyti
Hi Chris, On Mon, Apr 06, 2020 at 04:35:18PM +0100, Chris Wilson wrote: > The test is looking at sysfs/error so dumping the old > debugfs/i915_error_state looks quite silly. The only dilemma is whether > it is worth replacing with a line-by-line dump. I propose we make that a > future problem -- a

Re: [Intel-gfx] [PATCH 5/6] kernel: better document the use_mm/unuse_mm API contract

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:41 a.m. schrieb Christoph Hellwig: > Switch the function documentation to kerneldoc comments, and add > WARN_ON_ONCE asserts that the calling thread is a kernel thread and > does not have ->mm set (or has ->mm set in the case of unuse_mm). > > Also give the functions a kthread_ p

[Intel-gfx] [PATCH i-g-t 1/2] tests/gem_userptr_blits: Refresh readonly-mmap-unsync exercise

2020-04-06 Thread Janusz Krzysztofik
Upgrade the subtest to use MMAP_GTT API v4 (aka MMAP_OFFSET), dynamically examine each mapping type supported by i915 driver. Signed-off-by: Janusz Krzysztofik Reviewed-by: Zbigniew Kempczyński --- tests/i915/gem_userptr_blits.c | 21 - 1 file changed, 16 insertions(+), 5 de

  1   2   >