On 2020-04-01 at 16:03:46 +0300, Ville Syrjälä wrote:
> On Wed, Apr 01, 2020 at 05:42:24PM +0530, Jeevan B wrote:
> > Currently, downstream port type is only reported in debugfs. This
> > information should be considered important since it reflects the actual
> > physical connector type. Some users
== Series Details ==
Series: SAGV support for Gen12+ (rev10)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8243 -> Patchwork_17194
Summary
---
**SUCCESS**
No r
We use timer->expires == 0 to detect if a timer had been cancelled, but
it's a valid expiration we could set. Just skip using 0 and set the
expiry for the next jiffie.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Hi!
> > Hardware is thinkpad x220. I had this crash few days ago. And today I
> > have similar-looking one, with slightly newer kernel. (Will post
> > as a follow-up).
As part of quest for working system, I tried 5.7-rc0, based on
Merge: 50a5de895dbe b4d8ddf8356d
Author: Linus Torvalds
Date:
New test igt@i915_pm_lpsp@non-edp-lpsp is not yet available in CI bug log. So,
I can't create a filter for this skip yet. Otherwise other issues are
addressed.
Yesterday I have re-reported after addressing the issues but due to long queue
results are not yet updated.
Lakshmi.
-Original Mes
== Series Details ==
Series: drm/i915: Avoid setting timer->expires to 0
URL : https://patchwork.freedesktop.org/series/75447/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8243 -> Patchwork_17195
Summary
---
**SUCCE
Do an early rejection of a i915_vma_unbind() attempt if the i915_vma is
currently pinned, without waiting to see if the inflight operations may
unpin it. We see this problem with the shrinker trying to unbind the
active vma from inside its bind worker:
<6> [472.618968] Workqueue: events_unbound fe
== Series Details ==
Series: i915 lpsp support for lpsp igt (rev6)
URL : https://patchwork.freedesktop.org/series/74648/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8228_full -> Patchwork_17155_full
Summary
---
**F
== Series Details ==
Series: drm/i915/gem: Try allocating va from free space (rev3)
URL : https://patchwork.freedesktop.org/series/74748/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8233_full -> Patchwork_17171_full
Summa
Fixes: a88b6e4cbafd ("drm/i915: Allow specification of parallel execbuf")
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
Cc: Lionel Landwerlin
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 +++---
include/uapi/drm/i915_drm.h| 7 ---
2 files changed, 11 ins
Whenever we walk along the dma-fence-chain, we prune signaled links to
keep the chain nice and tidy. This leads to situations where we can
prune a link and report the earlier fence as the target seqno --
violating our own consistency checks that the seqno is not more advanced
than the last element
Allow the callers to supply a dma-fence-proxy for asynchronous waiting on
future fences.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_syncobj.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index 4
A few very simple testcases to exercise the dma-fence-chain API.
Signed-off-by: Chris Wilson
---
drivers/dma-buf/Makefile | 3 +-
drivers/dma-buf/selftests.h | 1 +
drivers/dma-buf/st-dma-fence-chain.c | 713 +++
3 files changed, 716 insertions(+)
Often we need to create a fence for a future event that has not yet been
associated with a fence. We can store a proxy fence, a placeholder, in
the timeline and replace it later when the real fence is known. Any
listeners that attach to the proxy fence will automatically be signaled
when the real f
Let userspace know if they can trust timeslicing by including it as part
of the I915_PARAM_HAS_SCHEDULER::I915_SCHEDULER_CAP_TIMESLICING
v2: Only declare timeslicing if we can safely preempt userspace.
Fixes: 8ee36e048c98 ("drm/i915/execlists: Minimalistic timeslicing")
Signed-off-by: Chris Wilso
Inside dma-fence-chain, we use a cmpxchg on an RCU-protected pointer. To
avoid the sparse warning for using the RCU pointer directly, we have to
cast away the __rcu annotation. However, we don't need to use void*
everywhere and can stick to the dma_fence*.
Signed-off-by: Chris Wilson
Reviewed-by:
If a syncobj has not yet been assigned, treat it as a future fence and
install and wait upon a dma-fence-proxy. The proxy will be replace by
the real fence later, and that fence will be responsible for signaling
our waiter.
Signed-off-by: Chris Wilson
---
.../gpu/drm/i915/gem/i915_gem_execbuffer
Under ideal circumstances, the driver should be able to keep the GPU
fully saturated with work. Measure how close to ideal we get under the
harshest of conditions with no user payload.
v2: Also measure throughput using only one thread.
Signed-off-by: Chris Wilson
---
.../drm/i915/selftests/i915
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the
user batch or in our own preamble, the engine raises a
GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so
respond to a semaphore wait by yielding the timeslice, if we have
another context to yield to!
The only
Hi!
> > > Hardware is thinkpad x220. I had this crash few days ago. And today I
> > > have similar-looking one, with slightly newer kernel. (Will post
> > > as a follow-up).
>
> As part of quest for working system, I tried 5.7-rc0, based on
>
> Merge: 50a5de895dbe b4d8ddf8356d
> Author: Linus To
Quoting Pavel Machek (2020-04-03 10:14:30)
> Hi!
>
> > > > Hardware is thinkpad x220. I had this crash few days ago. And today I
> > > > have similar-looking one, with slightly newer kernel. (Will post
> > > > as a follow-up).
> >
> > As part of quest for working system, I tried 5.7-rc0, based on
On Thu, Apr 02, 2020 at 10:53:36AM -0400, Giacomo Comes wrote:
> On Thu, Apr 02, 2020 at 04:52:03PM +0300, Ville Syrjälä wrote:
> > On Wed, Apr 01, 2020 at 06:53:17PM -0400, Giacomo Comes wrote:
> > > Hi,
> > > on my Intel Compute Stick STCK1 (baytrail hdmi audio)
> > > sound is not working with t
== Series Details ==
Series: i915 lpsp support for lpsp igt (rev6)
URL : https://patchwork.freedesktop.org/series/74648/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8228_full -> Patchwork_17155_full
Summary
---
**F
== Series Details ==
Series: drm/i915: Check current i915_vma.pin_count status first on unbind (rev4)
URL : https://patchwork.freedesktop.org/series/72529/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8243 -> Patchwork_17196
===
== Series Details ==
Series: series starting with [01/10] drm/i915/selftests: Add request throughput
measurement to perf
URL : https://patchwork.freedesktop.org/series/75452/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9b51ead71e1a drm/i915/selftests: Add request throughput
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/gt: Only wait for GPU activity
before unbinding a GGTT fence
URL : https://patchwork.freedesktop.org/series/75383/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8234_full -> Patchwork_17172_full
=
Hi!
> > > > Hardware is thinkpad x220. I had this crash few days ago. And today I
> > > > have similar-looking one, with slightly newer kernel. (Will post
> > > > as a follow-up).
> >
> > As part of quest for working system, I tried 5.7-rc0, based on
> >
> > Merge: 50a5de895dbe b4d8ddf8356d
> >
== Series Details ==
Series: series starting with [01/10] drm/i915/selftests: Add request throughput
measurement to perf
URL : https://patchwork.freedesktop.org/series/75452/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8243 -> Patchwork_17197
===
== Series Details ==
Series: drm/i915/gem: Drop cached obj->bind_count (rev3)
URL : https://patchwork.freedesktop.org/series/74593/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8235_full -> Patchwork_17173_full
Summary
---
Hi!
> > commit f365ab31efacb70bed1e821f7435626e0b2528a6
> > Merge: 4646de87d325 59e7a8cc2dcf
> > Author: Linus Torvalds
> > Date: Wed Apr 1 15:24:20 2020 -0700
> >
> > Merge tag 'drm-next-2020-04-01' of
> > git://anongit.freedesktop.org/drm/drm
> Any ideas, besides the b-word?
>
> Would
== Series Details ==
Series: drm/i915: Remove WARN_ON and WARN_ON_ONCE overrides.
URL : https://patchwork.freedesktop.org/series/75390/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8236_full -> Patchwork_17174_full
Summary
On Thu, Apr 02, 2020 at 11:47:35AM +0300, Alexey Budankov wrote:
>
> Extend error messages to mention CAP_PERFMON capability as an option
> to substitute CAP_SYS_ADMIN capability for secure system performance
> monitoring and observability operations. Make perf_event_paranoid_check()
> and __cmd_f
== Series Details ==
Series: Introduce CAP_PERFMON to secure system performance monitoring and
observability (rev5)
URL : https://patchwork.freedesktop.org/series/72273/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8236_full -> Patchwork_17177_full
==
== Series Details ==
Series: drm/i915: Check current i915_vma.pin_count status first on unbind (rev5)
URL : https://patchwork.freedesktop.org/series/72529/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8244 -> Patchwork_17198
===
Some effort is already taken to clean up previous content of device
lists before forced device rescan is performed but it is not
sufficient. An attempt to use forced device rescan in a test results
in that test crashing or spinning until being killed by OOM killer.
Fix it.
v2: Remove device from
Do an early rejection of a i915_vma_unbind() attempt if the i915_vma is
currently pinned, without waiting to see if the inflight operations may
unpin it. We see this problem with the shrinker trying to unbind the
active vma from inside its bind worker:
<6> [472.618968] Workqueue: events_unbound fe
== Series Details ==
Series: series starting with [01/17] drm/i915/audio: use struct drm_device
based logging
URL : https://patchwork.freedesktop.org/series/75414/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8237_full -> Patchwork_17179_full
Hi!
> > > commit f365ab31efacb70bed1e821f7435626e0b2528a6
> > > Merge: 4646de87d325 59e7a8cc2dcf
> > > Author: Linus Torvalds
> > > Date: Wed Apr 1 15:24:20 2020 -0700
> > >
> > > Merge tag 'drm-next-2020-04-01' of
> > > git://anongit.freedesktop.org/drm/drm
>
>
> > Any ideas, besides th
Hi!
7dc8f1143778a35b190f9413f228b3cf28f67f8d
drm/i915/gem: Drop relocation slowpath
Since the relocations are no longer performed under a global
struct_mutex, or any other lock, that is also held by pagefault handlers,
we can relax and allow our fast path to take a fault. As
== Series Details ==
Series: drm/i915/gem: Utilize rcu iteration of context engines (rev3)
URL : https://patchwork.freedesktop.org/series/75270/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17181_full
== Series Details ==
Series: drm/i915: Check current i915_vma.pin_count status first on unbind (rev6)
URL : https://patchwork.freedesktop.org/series/72529/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8244 -> Patchwork_17199
===
On 03.04.2020 14:08, Jiri Olsa wrote:
> On Thu, Apr 02, 2020 at 11:47:35AM +0300, Alexey Budankov wrote:
>>
>> Extend error messages to mention CAP_PERFMON capability as an option
>> to substitute CAP_SYS_ADMIN capability for secure system performance
>> monitoring and observability operations. M
== Series Details ==
Series: perf/core: Only copy-to-user after completely unlocking all locks, v2.
URL : https://patchwork.freedesktop.org/series/75422/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17183_full
===
We are dramatically underestimating the overhead for an active object
and its inodes.
Signed-off-by: Chris Wilson
---
lib/intel_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/intel_os.c b/lib/intel_os.c
index 8458d39a1..2bb0c981a 100644
--- a/lib/intel_os.c
+++ b/li
== Series Details ==
Series: drm/i915: Use per-engine request pools (rev8)
URL : https://patchwork.freedesktop.org/series/75415/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17187_full
Summary
--
In drm we've added nice drm_device (the main gpu driver thing, which
also represents the userspace interfaces and has everything else
dangling off it) init functions using devres, devm_drm_dev_init and
soon devm_drm_dev_alloc (this patch series adds that).
A slight trouble is that drm_device itsel
We use the baseclass pattern here, so lets to the proper (and more
typesafe) upcasting.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 1 -
drivers/gpu/drm/vboxvideo/vbox_drv.h | 1 +
drivers/gpu/drm/vboxvideo/vbox_irq.c | 2 +-
drivers/gpu/drm/v
Hi all,
Here's the promised follow-up to get rid of the drmm_add_final_kfree calls
from drivers. I've also sprinkled in a bunch of cleanups for the drivers
I've had to touch anyway. I think with devm_drm_dev_alloc we now have a
very neat and clean way to init the drm_device, and all the interim st
This means we also need to slightly restructure the exit code, so that
final cleanup of the drm_device is triggered by unregistering the
platform device. Note that devres is both clean up when the driver is
unbound (not the case for vkms, we don't bind), and also when unregistering
the device (very
Doesn't apply to upstream kernels since a rather long time.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_ttm.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_ttm.c
b/drivers/gpu/drm/vboxvideo/vbox_ttm.c
index
This means we also need to slightly restructure the exit code, so that
final cleanup of the drm_device is triggered by unregistering the
platform device. Note that devres is both clean up when the driver is
unbound (not the case for vgem, we don't bind), and also when unregistering
the device (very
We've had lots of conversions to embeddeding, but didn't stop using
->dev_private. Which defeats the point of this.
Signed-off-by: Daniel Vetter
---
include/drm/drm_device.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/drm/drm_device.h b/include/drm/drm_de
Allows us to drop the cleanup code on the floor.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++
drivers/gpu/drm/vboxvideo/vbox_main.c | 7 +--
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox
The kerneldoc is only added for this new function. Existing kerneldoc
and examples will be udated at the very end, since once all drivers
are converted over to devm_drm_dev_alloc we can unexport a lot of
interim functions and make the documentation for driver authors a lot
cleaner and less confusin
And switch the helper over to container_of, which is a bunch faster
than chasing a pointer. Plus allows gcc to see through this maze.
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 -
drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
2 files changed, 1 insertion(+), 2 de
Aside from deleting all the cleanup code we're now also setting a name
for the pool
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_main.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox
Straightforward conversion.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c
b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index d685ec1
Also init the fbdev emulation before we register the device, that way
we can rely on the auto-cleanup and simplify the probe error code even
more.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Sean Paul
Cc: Thomas Zimmermann
Cc: Daniel Vetter
Cc: Emil Velikov
Cc: Sam Ravnborg
Cc: Thomas
Already using devm_drm_dev_init, so very simple replacment.
Aside: There was an oddity in the old code, we allocated priv but in
the error path we've freed priv->dbidev ...
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/st7735r.c | 13 -
1 file changed, 4 i
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/tiny/hx8357d.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c
index af7
Also need to remove the drm_dev_put from the remove hook.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
Cc: spice-de...@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_drv.c | 15 ---
drivers/gpu/drm/qxl/qxl_drv.h |
On Thu, 2020-04-02 at 19:40 +0100, Chris Wilson wrote:
> Add a tiny per-engine request mempool so that we should always have a
> request available for powermanagement allocations from tricky
> contexts. This reserve is expected to be only used for kernel
> contexts when barriers must be emitted [al
We're mostly there already, just a handful of places that didn't use
the to_udl container_of cast. To make sure no new appear, don't set
->dev_private.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Sean Paul
Cc: Emil Velikov
Cc: Thomas Zimmermann
Cc: Daniel Vetter
Cc: Alexios Zavras
Cc:
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/mi0283qt.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
i
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
Cc: spice-de...@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_debugfs.c | 7 +
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/ili9225.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index 1
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_crtc.c | 16
drivers/gpu/drm/tidss/tidss_drv.c | 2 --
drivers/gpu/drm/tids
We already have it in v3d_dev->drm.dev with zero additional pointer
chasing. Personally I don't like duplicated pointers like this
because:
- reviewers need to check whether the pointer is for the same or
different objects if there's multiple
- compilers have an easier time too
But also a bit a
Also allows us to simplify the unroll code since the drm_dev_put
disappears.
Signed-off-by: Daniel Vetter
Cc: Eric Anholt
---
drivers/gpu/drm/v3d/v3d_drv.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drive
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Paul Cercueil
---
drivers/gpu/drm/ingenic/ingenic-drm.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
b/drivers/gpu/drm/ingen
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Linus Walleij
---
drivers/gpu/drm/mcde/mcde_display.c | 10 +-
drivers/gpu/drm/mcde/mcde_drm.h | 2 ++
drivers/gpu/drm/mcde/mcde_drv.c | 5 ++
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c
b/drivers/gpu
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
drivers/gpu/drm/tiny/st7586.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c
index c329
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Linus Walleij
---
drivers/gpu/drm/mcde/mcde_drv.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: David Lechner
---
drivers/gpu/drm/tiny/ili9341.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --g
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/tiny/gm12u320.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
inde
Not used anymore since the switch to suspend/resume helpers.
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.h
b/drivers/gpu/drm/tidss/tidss_drv.h
index b2
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Kamlesh Gurudasani
---
drivers/gpu/drm/tiny/ili9486.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
in
We already have it in v3d_dev->drm.dev with zero additional pointer
chasing. Personally I don't like duplicated pointers like this
because:
- reviewers need to check whether the pointer is for the same or
different objects if there's multiple
- compilers have an easier time too
To avoid having to
Entirely not used, just copypasta.
Signed-off-by: Daniel Vetter
Cc: Paul Cercueil
---
drivers/gpu/drm/ingenic/ingenic-drm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
b/drivers/gpu/drm/ingenic/ingenic-drm.c
index bb62d8e93985..3386270cb8a3 100644
-
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
---
drivers/gpu/drm/tiny/gm12u320.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/tiny/gm12u320
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/repaper.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
in
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: Eric Anholt
Cc: Thomas Zimmermann
Cc: virtualizat...@lists.linux
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Signed-off-by: Daniel Vetter
Cc: Russell King
---
drivers/gpu/drm/armada/armada_crtc.c| 4 ++--
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
drivers/gpu/drm/armada/armada_drm.h | 2
Following functions are only used internally, not by drivers:
- drm_dev_init
- devm_drm_dev_init
- drmm_add_final_kfree
Also, now that we have a very slick and polished way to allocate a
drm_device with devm_drm_dev_alloc, update all the docs to reflect the
new reality. Mostly this consists of del
Komeda uses the component framework, which does open/close a new
devres group around all the bind callbacks. Which means we can use
devm_ functions for managing the drm_device cleanup, with leaking
stuff in case of deferred probes or other reasons to unbind
components, or the component_master.
Als
Just some prep work before we rework the lifetime handling, which
requires replacing all the drm_dev_put in selftests by something else.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +-
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
dr
Also remove the now no longer needed build bug on since that's already
not needed anymore with drmm_add_final_kfree. Conversion to managed
drm_device cleanup is easy, the final drm_dev_put() is already the
last thing in both the bind unbind as in the unbind flow.
Also, this relies on component.c c
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: Sam Ravnborg
Cc: "Noralf Trønnes"
Cc: Rob Herring
Cc: Thomas Zimmermann
Cc: virtualizat...@lists.linux-foundation.org
Cc: Emil Velikov
---
driv
The big change is device_add so that device_del can auto-cleanup
devres resources. This allows us to use devm_drm_dev_alloc, which
removes the last user of drm_dev_init.
Signed-off-by: Daniel Vetter
---
.../gpu/drm/i915/selftests/mock_gem_device.c | 31 +--
.../gpu/drm/i915/self
Luckily we're already well set up in the main driver, with
drm_dev_put() being the last thing in both the unload error case and
the pci remove function.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.c | 17 -
drivers/gpu/drm/i915/i915_pci.c | 2 --
2 files chang
Quoting Janusz Krzysztofik (2020-04-03 14:58:47)
> On Thu, 2020-04-02 at 19:40 +0100, Chris Wilson wrote:
> > Add a tiny per-engine request mempool so that we should always have a
> > request available for powermanagement allocations from tricky
> > contexts. This reserve is expected to be only use
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev3)
URL : https://patchwork.freedesktop.org/series/75333/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17188_full
On 2020-03-01 6:46 a.m., Marek Olšák wrote:
> For Mesa, we could run CI only when Marge pushes, so that it's a strictly
> pre-merge CI.
Thanks for the suggestion! I implemented something like this for Mesa:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4432
--
Earthling Michel Dänz
== Series Details ==
Series: devm_drm_dev_alloc, no more drmm_add_final_kfree
URL : https://patchwork.freedesktop.org/series/75463/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> In drm we've added nice drm_device (the main gpu driver thing, which
> also represents the userspace interfaces and has everything else
> dangling off it) init functions using devres, devm_drm_dev_init and
> soon devm_drm_dev_alloc (t
== Series Details ==
Series: drm/i915: Keep a per-engine request pools (rev2)
URL : https://patchwork.freedesktop.org/series/75427/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17189_full
Summary
---
On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
wrote:
>
> On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > In drm we've added nice drm_device (the main gpu driver thing, which
> > also represents the userspace interfaces and has everything else
> > dangling off it) init functi
On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote:
>
> On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> wrote:
> >
> > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > In drm we've added nice drm_device (the main gpu driver thing, which
> > > also represents the userspace
On Fri, Apr 03, 2020 at 04:51:33PM +0200, Daniel Vetter wrote:
> On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote:
> >
> > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > > In drm we've added nice drm_
1 - 100 of 187 matches
Mail list logo
