[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/74822/ State : warning == Summary == $ dim checkpatch origin/drm-tip e340b247ca0e drm/dp: DRM DP helper for reading Ignore MSA from DPC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/74822/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145 -> Patchwork_17002 =

[Intel-gfx] ✓ Fi.CI.BAT: success for DP Phy compliance auto test (rev8)

2020-03-18 Thread Patchwork
== Series Details == Series: DP Phy compliance auto test (rev8) URL : https://patchwork.freedesktop.org/series/71121/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145 -> Patchwork_17003 Summary --- **SUCCESS** N

[Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off

2020-03-18 Thread Anshuman Gupta
Few edp panels like Sharp is triggering short and long hpd pulse after panel is getting powered off. Currently driver is already ignoring long pulse for eDP panel but in order to process the short pulse, it turns on the VDD which requires panel power_cycle_delay + panel_power_on_delay these delay o

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

2020-03-18 Thread Arkadiusz Hiler
On Tue, Mar 17, 2020 at 12:43:40PM +0200, Lisovskiy, Stanislav wrote: > What is this weird DOC warning about? "Error: Cannot open file ./drivers/gpu/ > drm/i915/i915_gem_fence_reg.c" > > - wondering, how is that related to this patch. Looks like you were unlucky and your series got tested with th

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

2020-03-18 Thread Lisovskiy, Stanislav
Wonder, how we end up merging _stuff_ with failed IGT and loads of warnings.. https://patchwork.freedesktop.org/series/74738/ ... while I get beaten for each and every single warning in my patches 😊 Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendin

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

2020-03-18 Thread Arkadiusz Hiler
On Wed, Mar 18, 2020 at 10:43:29AM +0200, Lisovskiy, Stanislav wrote: > Wonder, how we end up merging _stuff_ with failed IGT and loads of warnings.. > > https://patchwork.freedesktop.org/series/74738/ > > ... while I get beaten for each and every single warning in my patches 😊 True. This should

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Consider DBuf bandwidth when calculating CDCLK (rev2)

2020-03-18 Thread Lisovskiy, Stanislav
Remember when I have been working in Ericsson we had been using a gerrit review and you simply would not be able to merge anything until it has +2(r-b) and no tests failing. Or you have to exclude unstable tests at least until those are fixed. It was simply automated and no exceptions, no mat

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev3) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145 -> Patchwork_17004 Summary

Re: [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off

2020-03-18 Thread Jani Nikula
On Wed, 18 Mar 2020, Anshuman Gupta wrote: > Few edp panels like Sharp is triggering short and long > hpd pulse after panel is getting powered off. > Currently driver is already ignoring long pulse for eDP > panel but in order to process the short pulse, it turns on > the VDD which requires panel

Re: [Intel-gfx] [PATCH v8 2/3] drm/i915: set optimum eu/slice/sub-slice configuration based on load type

2020-03-18 Thread Tvrtko Ursulin
On 17/03/2020 10:29, Ankit Navik wrote: This patch will select optimum eu/slice/sub-slice configuration based on type of load (low, medium, high) as input. Based on our readings and experiments we have predefined set of optimum configuration for each platform(CHT, KBL). i915_gem_context_set_loa

[Intel-gfx] [PATCH v3] drm/i915: Enable non-contiguous pipe fusing

2020-03-18 Thread Anshuman Gupta
As we have already enabled supported infrastructure for non-contiguous pipe fusing in driver, we don't require non-contiguous pipe_mask check anymore. It is an unlike condition, it make sense to remove this condition. changes since RFC: - using intel_pipe_mask_is_valid() function to check integrit

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD URL : https://patchwork.freedesktop.org/series/74822/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145_full -> Patchwork_17002_full ===

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable non-contiguous pipe fusing

2020-03-18 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of > Anshuman > Gupta > Sent: Wednesday, March 18, 2020 3:15 PM > To: intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: [Intel-gfx] [PATCH v3] drm/i915: Enable non-contiguous pipe fusing > > As we have already enabled su

[Intel-gfx] ✓ Fi.CI.IGT: success for DP Phy compliance auto test (rev8)

2020-03-18 Thread Patchwork
== Series Details == Series: DP Phy compliance auto test (rev8) URL : https://patchwork.freedesktop.org/series/71121/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145_full -> Patchwork_17003_full Summary --- **SUCC

[Intel-gfx] [PATCH 8/9] drm/i915: Track context current active time

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not g

[Intel-gfx] [PATCH 4/9] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 13 - drivers/gpu/drm/i915/gem/i915_gem_con

[Intel-gfx] [PATCH 1/9] drm/i915: Update client name on context create

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some clients have the DRM fd passed to them over a socket by the X server. Grab the real client and pid when they create their first context and update the exposed data for more useful enumeration. To enable lockless access to client name and pid data from the following pat

[Intel-gfx] [PATCH 2/9] drm/i915: Make GEM contexts track DRM clients

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we make GEM contexts keep a reference to i915_drm_client for the whole of their lifetime, we can consolidate the current task pid and name usage by getting it from the client. v2: * Don't bother supporting selftests contexts from debugfs. (Chris) Signed-off-by: Tvrtko U

[Intel-gfx] [PATCH 3/9] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I need to keep the GEM context around a bit longer so adding an explicit flag for syncing execbuf with closed/abandonded contexts. v2: * Use already available context flags. (Chris) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 3 ++-

[Intel-gfx] [PATCH 7/9] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose per-client and per-engine busyness under the previously added sysfs client root. The new files are one per-engine instance and located under the 'busy' directory. Each contains a monotonically increasing nano-second resolution times each client's jobs were executing o

[Intel-gfx] [PATCH 5/9] drm/i915: Track runtime spent in closed GEM contexts

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 12 +++- drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 0/9] Per client engine busyness

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Another re-spin of the per-client engine busyness series. Highlights from this version: * Checkpatch cleanup and bits of review feedback only. Internally we track time spent on engines for each struct intel_context. This can serve as a building block for several features f

[Intel-gfx] [PATCH 6/9] drm/i915: Track all user contexts per client

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/ge

[Intel-gfx] [PATCH 9/9] drm/i915: Prefer software tracked context busyness

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When available prefer context tracked context busyness because it provides visibility into currently executing contexts as well. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drm_client.c | 68 -- 1 file changed, 63 insertions(+), 5 de

[Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Uma Shankar
If external monitors are connected during boot up, driver uses the same mode programmed by BIOS and avoids a full modeset. This results in display audio codec left uninitialized and display audio fails to work till user triggers a modeset. This patch fixes the same by triggering a modeset at boot.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev3) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145_full -> Patchwork_17004_full ===

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Per client engine busyness (rev8)

2020-03-18 Thread Patchwork
== Series Details == Series: Per client engine busyness (rev8) URL : https://patchwork.freedesktop.org/series/70977/ State : failure == Summary == Applying: drm/i915: Update client name on context create error: sha1 information is lacking or useless (drivers/gpu/drm/i915/i915_drm_client.c). e

Re: [Intel-gfx] [PATCH v19 4/8] drm/i915: Refactor intel_can_enable_sagv

2020-03-18 Thread Lisovskiy, Stanislav
>> @@ -5829,6 +6068,10 @@ skl_compute_wm(struct intel_atomic_state *state) >>return ret; >>} >> >> + ret = intel_compute_sagv_mask(state); >> + if (ret) >> + return ret; > This seems too early. We haven't even computed the ddb yet. I was thinki

[Intel-gfx] [PULL] drm-misc-fixes

2020-03-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-18: drm-misc-fixes for v5.6: - Fix AVI frame colorimetry in the dw-hdmi bridge. - Fix compiler warning in komeda by annotating functions as __maybe_unused. - Downgrade bochs pci_request_region failure from error to warning to workaround firmware fb. The following changes si

[Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 13 - drivers/gpu/drm/i915/gem/i915_gem_con

[Intel-gfx] [PATCH 03/10] drm/i915: Make GEM contexts track DRM clients

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we make GEM contexts keep a reference to i915_drm_client for the whole of their lifetime, we can consolidate the current task pid and name usage by getting it from the client. v2: * Don't bother supporting selftests contexts from debugfs. (Chris) Signed-off-by: Tvrtko U

[Intel-gfx] [PATCH 02/10] drm/i915: Update client name on context create

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some clients have the DRM fd passed to them over a socket by the X server. Grab the real client and pid when they create their first context and update the exposed data for more useful enumeration. To enable lockless access to client name and pid data from the following pat

[Intel-gfx] [PATCH 01/10] drm/i915: Expose list of clients in sysfs

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose a list of clients with open file handles in sysfs. This will be a basis for a top-like utility showing per-client and per- engine GPU load. Currently we only expose each client's pid and name under opaque numbered directories in /sys/class/drm/card0/clients/. For in

[Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose per-client and per-engine busyness under the previously added sysfs client root. The new files are one per-engine instance and located under the 'busy' directory. Each contains a monotonically increasing nano-second resolution times each client's jobs were executing o

[Intel-gfx] [PATCH 00/10] Per client engine busyness

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Another re-spin of the per-client engine busyness series. Highlights from this version: * Checkpatch cleanup and bits of review feedback only. Internally we track time spent on engines for each struct intel_context. This can serve as a building block for several features f

[Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I need to keep the GEM context around a bit longer so adding an explicit flag for syncing execbuf with closed/abandonded contexts. v2: * Use already available context flags. (Chris) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 3 ++-

[Intel-gfx] [PATCH 09/10] drm/i915: Track context current active time

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track context active (on hardware) status together with the start timestamp. This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime. The latter is only updated on context save so does not g

[Intel-gfx] [PATCH 07/10] drm/i915: Track all user contexts per client

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using. To enable this we start tracking all context belonging to a client on a separate list. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/ge

[Intel-gfx] [PATCH 06/10] drm/i915: Track runtime spent in closed GEM contexts

2020-03-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 12 +++- drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Maarten Lankhorst
Op 18-03-2020 om 12:30 schreef Uma Shankar: > If external monitors are connected during boot up, driver > uses the same mode programmed by BIOS and avoids a full modeset. > This results in display audio codec left uninitialized and > display audio fails to work till user triggers a modeset. > > Thi

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Anshuman Gupta
On 2020-03-18 at 17:00:09 +0530, Uma Shankar wrote: > If external monitors are connected during boot up, driver > uses the same mode programmed by BIOS and avoids a full modeset. > This results in display audio codec left uninitialized and > display audio fails to work till user triggers a modeset.

Re: [Intel-gfx] [PATCH 0/9] Per client engine busyness

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 11:01, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Another re-spin of the per-client engine busyness series. Highlights from this version: Broken version with one patch missing, apologies for the spam. Regards, Tvrtko * Checkpatch cleanup and bits of review feedback only.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Trigger Modeset at boot for audio codec init URL : https://patchwork.freedesktop.org/series/74828/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8146 -> Patchwork_17006 Summary

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display/fbc: Make fences a nice-to-have for GEN9+

2020-03-18 Thread Ville Syrjälä
On Thu, Mar 12, 2020 at 12:35:56AM +, Souza, Jose wrote: > On Thu, 2020-03-05 at 17:33 -0800, José Roberto de Souza wrote: > > On Thu, 2020-02-20 at 19:26 +0200, Ville Syrjälä wrote: > > > On Tue, Feb 18, 2020 at 05:42:30PM -0800, José Roberto de Souza > > > wrote: > > > > dGFX have local memor

Re: [Intel-gfx] [PATCH v19 4/8] drm/i915: Refactor intel_can_enable_sagv

2020-03-18 Thread Ville Syrjälä
On Wed, Mar 18, 2020 at 11:52:13AM +, Lisovskiy, Stanislav wrote: > >> @@ -5829,6 +6068,10 @@ skl_compute_wm(struct intel_atomic_state *state) > >>return ret; > >>} > >> > >> + ret = intel_compute_sagv_mask(state); > >> + if (ret) > >> + retur

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/display/fbc: Make fences a nice-to-have for GEN9+

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 06, 2020 at 01:32:12AM +, Souza, Jose wrote: > On Thu, 2020-02-20 at 19:26 +0200, Ville Syrjälä wrote: > > On Tue, Feb 18, 2020 at 05:42:30PM -0800, José Roberto de Souza > > wrote: > > > dGFX have local memory so it do not have aperture and do not > > > support > > > CPU fences but

[Intel-gfx] [PATCH] drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Chris Wilson
%pS includes the offset, which is useful for return addresses but noise when we are pretty printing a known (and expected) function entry point. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_sw_fence.c | 2 +- drivers/gpu/drm/i915/selftests/i915_active.c | 2 +- drivers/gpu

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Make GEM contexts track DRM clients

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:32) > From: Tvrtko Ursulin > > If we make GEM contexts keep a reference to i915_drm_client for the whole > of their lifetime, we can consolidate the current task pid and name usage > by getting it from the client. > > v2: > * Don't bother supporting self

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:33) > From: Tvrtko Ursulin > > I need to keep the GEM context around a bit longer so adding an explicit > flag for syncing execbuf with closed/abandonded contexts. > > v2: > * Use already available context flags. (Chris) > > Signed-off-by: Tvrtko Ursuli

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Use explicit flag to mark unreachable intel_context

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 13:49, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:33) From: Tvrtko Ursulin I need to keep the GEM context around a bit longer so adding an explicit flag for syncing execbuf with closed/abandonded contexts. v2: * Use already available context flags. (Chris)

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > From: Tvrtko Ursulin > > As contexts are abandoned we want to remember how much GPU time they used > (per class) so later we can used it for smarter purposes. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Track runtime spent in closed GEM contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:35) > From: Tvrtko Ursulin > > As GEM contexts are closed we want to have the DRM client remember how > much GPU time they used (per class) so later we can used it for smarter > purposes. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/ge

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 12:11:37) > +static u64 > +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) > +{ > + struct i915_gem_engines *engines = rcu_dereference(ctx->engines); > + struct i915_gem_engines_iter it; > + struct intel_context *ce; > + u

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Shankar, Uma
> -Original Message- > From: Gupta, Anshuman > Sent: Wednesday, March 18, 2020 5:37 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; Khor, Swee Aun > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot > for audio > codec init > > On 2020-03-18 at 1

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Chris Wilson
Quoting Andi Shyti (2020-03-18 13:58:37) > From: Andi Shyti > > The following interfaces: > > i915_wedged > i915_forcewake_user Ok. > i915_gem_interrupt More display really, not actually the primary info dump for GEM or GT. s/gem/ or just delete it, if we're not using, and display isn't, it's

[Intel-gfx] [PULL] drm-misc-fixes

2020-03-18 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-18-1: One more fix for v5.6: - drm/lease: fix WARNING in idr_destroy The following changes since commit 1b79cfd99ff5127e6a143767b51694a527b3ea38: drm: kirin: Revert "Fix for hikey620 display offset problem" (2020-03-04 13:29:05 +) are available in the Git repository

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 13:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:34) From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Andi Shyti
From: Andi Shyti The following interfaces: i915_wedged i915_forcewake_user i915_gem_interrupt i915_gem_drop_caches are dependent on gt values. Put them inside gt/ and drop the "i915_" prefix name. This would be the new structure: gt | +-- drop_caches | +-- forcewake_user | +-- in

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 14:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:37) +static u64 +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) +{ + struct i915_gem_engines *engines = rcu_dereference(ctx->engines); + struct i915_gem_engines_iter it; + str

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Prefer '%ps' for printing function symbol names URL : https://patchwork.freedesktop.org/series/74831/ State : success == Summary == CI Bug Log - changes from CI_DRM_8147 -> Patchwork_17007 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Andi Shyti
Hi Chris, On Wed, Mar 18, 2020 at 02:06:07PM +, Chris Wilson wrote: > Quoting Andi Shyti (2020-03-18 13:58:37) > > From: Andi Shyti > > > > The following interfaces: > > > > i915_wedged > > i915_forcewake_user > > Ok. > > > i915_gem_interrupt > > More display really, not actually the pri

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:13:14) > > On 18/03/2020 13:55, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > >> From: Tvrtko Ursulin > >> > >> As contexts are abandoned we want to remember how much GPU time they used > >> (per class) so later we can used it for sma

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Expose per-engine client busyness

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:15:31) > > On 18/03/2020 14:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 12:11:37) > >> +static u64 > >> +pphwsp_busy_add(struct i915_gem_context *ctx, unsigned int class) > >> +{ > >> + struct i915_gem_engines *engines = rcu_dereferenc

Re: [Intel-gfx] [PATCH] drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Chris Wilson
Quoting Andi Shyti (2020-03-18 14:13:13) > Hi Chris, > > On Wed, Mar 18, 2020 at 02:06:07PM +, Chris Wilson wrote: > > Quoting Andi Shyti (2020-03-18 13:58:37) > > > From: Andi Shyti > > > > > > The following interfaces: > > > > > > i915_wedged > > > i915_forcewake_user > > > > Ok. > > >

Re: [Intel-gfx] [PATCH] drm/i915/display: Trigger Modeset at boot for audio codec init

2020-03-18 Thread Shankar, Uma
> -Original Message- > From: Maarten Lankhorst > Sent: Wednesday, March 18, 2020 5:46 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä ; Kai Vehmanen > ; Khor, Swee Aun > Subject: Re: [PATCH] drm/i915/display: Trigger Modeset at boot for audio > codec init >

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Tvrtko Ursulin
On 18/03/2020 14:32, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 14:13:14) On 18/03/2020 13:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-03-18 12:11:34) From: Tvrtko Ursulin As contexts are abandoned we want to remember how much GPU time they used (per class) so later w

Re: [Intel-gfx] [PATCH 02/10] drm/i915/fbc: convert to drm_device based logging macros.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga This replaces the uses of the printk based drm logging macros with the struct drm_device based logging macros in i915/display/intel_fbc.c. This transformation was done using the following coccinelle semantic patch that matches base

Re: [Intel-gfx] [PATCH 03/10] drm/i915/fbdev: convert to drm_device based logging.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga Convert various instances of printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_fbdev.c. This also involves extracting the drm_i915_private device from various intel types. v2 by Ja

Re: [Intel-gfx] [PATCH 06/10] drm/i915/hdcp: convert to struct drm_device based logging.

2020-03-18 Thread Wambui Karuga
On Tue, 10 Mar 2020, Jani Nikula wrote: From: Wambui Karuga Converts various instances of the printk based drm logging macros to the struct drm_device based logging macros in i915/display/intel_hdcp.c. This also involves extracting the drm_i915_private device from the intel_connector type f

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-18 14:38:53) > > On 18/03/2020 14:32, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-03-18 14:13:14) > >> > >> On 18/03/2020 13:55, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2020-03-18 12:11:34) > From: Tvrtko Ursulin > > As contexts ar

[Intel-gfx] [PATCH] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate th

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Track runtime spent in unreachable intel_contexts

2020-03-18 Thread Chris Wilson
Quoting Chris Wilson (2020-03-18 14:48:05) > We do have a notification here for the context_retire we could listen to > instead of listening to the request idling. If we use > > i915_sw_fence_await_active(&engines->fence, >&ce->active, >

[Intel-gfx] [PATCH] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate th

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: move files more files into debugfs

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: move files more files into debugfs URL : https://patchwork.freedesktop.org/series/74834/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h

[Intel-gfx] [PATCH] drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä Currently a driver must not provide a .dumb_create() hook in the drm_driver structure if it wants to declare dumb buffers as not supported. So if the same driver wants to support both modeset and non-modeset devices it would require two distinct drm_driver structures in order

Re: [Intel-gfx] [PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-18 Thread Harry Wentland
On 2020-03-18 2:35 a.m., Manasi Navare wrote: > This patch adds a hook in drm_connector_helper_funcs to get the > support of the driver for adaptive sync functionality. > > This can be called in the connector probe helper function after > the connector detect() and get_modes() hooks to also > quer

Re: [Intel-gfx] [PATCH 1/9] drm: Constify topology id

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 13, 2020 at 04:05:00PM -0400, Alex Deucher wrote: > On Fri, Mar 13, 2020 at 12:21 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Make the topology id const since we don't want to change it. > > > > Signed-off-by: Ville Syrjälä > > Series is: > Reviewed-by: Alex Deuche

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Wait until the context is finally retired before releasing engines (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/gem: Wait until the context is finally retired before releasing engines (rev2) URL : https://patchwork.freedesktop.org/series/74836/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8148 -> Patchwork_17009 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Prefer '%ps' for printing function symbol names

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Prefer '%ps' for printing function symbol names URL : https://patchwork.freedesktop.org/series/74831/ State : success == Summary == CI Bug Log - changes from CI_DRM_8147_full -> Patchwork_17007_full Su

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/color: Extract icl_read_luts() URL : https://patchwork.freedesktop.org/series/74777/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8142_full -> Patchwork_16995_full Summary --- *

Re: [Intel-gfx] [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-03-18 Thread Ville Syrjälä
On Wed, Feb 12, 2020 at 10:08:49AM +0100, Daniel Vetter wrote: > On Wed, Feb 12, 2020 at 10:07:55AM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 07:14:51PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 11, 2020 at 06:

Re: [Intel-gfx] [PATCH] drm/i915: Enable non-contiguous pipe fusing

2020-03-18 Thread Ville Syrjälä
On Fri, Mar 13, 2020 at 12:39:17AM -0700, Lucas De Marchi wrote: > On Wed, Mar 11, 2020 at 02:06:32PM +0530, Anshuman Gupta wrote: > >Allow 3-display pipes SKU system with any combination > >in INTEL_INFO pipe mask. > >B.Spec:50075 > > > >changes since RFC: > >- using intel_pipe_mask_is_valid() fun

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915/color: Extract icl_read_luts() URL : https://patchwork.freedesktop.org/series/74777/ State : success == Summary == CI Bug Log - changes from CI_DRM_8142_full -> Patchwork_16995_full Summary --- *

[Intel-gfx] [PATCH v2 07/13] drm/i915: Store cpu_transcoder_mask in device info

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä We have a bunch of code that would like to know which CPU transcoders are actually present in the hardware. Rather than use various ad-hoc methods let's just include a full bitmask in the device info, alongside pipe_mask. v2: Rebase Signed-off-by: Ville Syrjälä --- drivers

Re: [Intel-gfx] [PATCH v9] drm/i915/color: Extract icl_read_luts()

2020-03-18 Thread Ville Syrjälä
On Tue, Mar 17, 2020 at 07:27:36PM +0530, Swati Sharma wrote: > For icl+, have hw read out to create hw blob of gamma > lut values. icl+ platforms supports multi segmented gamma > mode by default, add hw lut creation for this mode. > > This will be used to validate gamma programming using dsb > (d

[Intel-gfx] [PATCH v2] drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä We only consider crtc_state->enable when initially calculating plane visibility. Later on we try to override the plane's state to invisible if the crtc is in DPMS off state (crtc_state->active==false). Unfortunately the code doing that only updates the plane_state.visible flag

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-18 Thread Rodrigo Vivi
On Wed, Mar 18, 2020 at 07:45:15PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We only consider crtc_state->enable when initially calculating plane > visibility. Later on we try to override the plane's state to invisible > if the crtc is in DPMS off state (crtc_state->active==false). >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Reject dumb buffers when driver/device doesn't support modesetting

2020-03-18 Thread Patchwork
== Series Details == Series: drm: Reject dumb buffers when driver/device doesn't support modesetting URL : https://patchwork.freedesktop.org/series/74841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8151 -> Patchwork_17010

[Intel-gfx] [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Ville Syrjala
From: Ville Syrjälä drm_mode_config_init() may not have been called when the driver/device doesn't support modeset. That will cause drm_mode_config_validate() to oops. Skip the validation for !modeset. TODO: We may want to consider calling drm_mode_config_init() unconditionally to avoid similar

Re: [Intel-gfx] [PATCH] drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Chris Wilson
Quoting Ville Syrjala (2020-03-18 18:25:18) > From: Ville Syrjälä > > drm_mode_config_init() may not have been called when the driver/device > doesn't support modeset. That will cause drm_mode_config_validate() > to oops. Skip the validation for !modeset. > > TODO: We may want to consider callin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Port sync for skl+ (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev2) URL : https://patchwork.freedesktop.org/series/74691/ State : warning == Summary == $ dim checkpatch origin/drm-tip d2cdf91643a0 drm/i915/mst: Use .compute_config_late() to compute master transcoder 2c7d28920dca drm/i915: Move T

[Intel-gfx] [PATCH 2/2] drm/i915/gem: Wait until the context is finally retired before releasing engines

2020-03-18 Thread Chris Wilson
If we want to percolate information back from the HW, up through the GEM context, we need to wait until the intel_context is scheduled out for the last time. This is handled by the retirement of the intel_context's barrier, i.e. by listening to the pulse after the notional unpin. To accommodate th

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Force single submission for sentinels

2020-03-18 Thread Chris Wilson
Currently, we only combine a sentinel request with a max-priority barrier such that a sentinel request is always in ELSP[0] with nothing following it. However, we will want to create similar ELSP[] submissions providing a full-barrier in the submission queue, but without forcing maximum priority. A

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Port sync for skl+ (rev2)

2020-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ (rev2) URL : https://patchwork.freedesktop.org/series/74691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8152 -> Patchwork_17011 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v9 01/11] drm/i915: Use 64-bit division macro

2020-03-18 Thread Jani Nikula
On Tue, 17 Mar 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel V

Re: [Intel-gfx] [PATCH 00/10] drm/i915/display: conversion to drm_device based logging macros

2020-03-18 Thread Jani Nikula
On Wed, 11 Mar 2020, Wambui Karuga wrote: > On Wed, 11 Mar 2020, Jani Nikula wrote: > >> On Mon, 09 Mar 2020, Jani Nikula wrote: >>> Please ignore this, I seem to have some smtp trouble which fails some of >>> tha patches. This will be incomplete. >>> >>> Wambui, I'll resend this later. >> >> Oka

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v3)

2020-03-18 Thread Jani Nikula
On Mon, 16 Mar 2020, Mario Kleiner wrote: > This fixes a problem found on the MacBookPro 2017 Retina panel. > > The panel reports 10 bpc color depth in its EDID, and the > firmware chooses link settings at boot which support enough > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), > but t

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Skip drm_mode_config_validate() for !modeset

2020-03-18 Thread Patchwork
== Series Details == Series: drm: Skip drm_mode_config_validate() for !modeset URL : https://patchwork.freedesktop.org/series/74843/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8152 -> Patchwork_17012 Summary --- *

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Adjust PM QoS response frequency based on GPU load.

2020-03-18 Thread Francisco Jerez
Francisco Jerez writes: > Chris Wilson writes: > >> Quoting Francisco Jerez (2020-03-10 21:41:55) >>> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c >>> b/drivers/gpu/drm/i915/gt/intel_lrc.c >>> index b9b3f78f1324..a5d7a80b826d 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c >>> +++ b/dr

  1   2   >