Re: [Intel-gfx] [PATCH 1/7] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Mika Kuoppala
Chris Wilson writes: > Since the fence registers control HW detiling throught the GGTT > aperture, make them a part of the intel_ggtt under gt/ > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/Makefile | 2 +- > drivers/gpu/drm/i915/gt/

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Remove manual save/resume of fence register state

2020-03-16 Thread Mika Kuoppala
Chris Wilson writes: > Since we always reload the fence register state on runtime resume, > having it explicitly in the S0ix resume code is redundant. Indeed, it > is not even being used! > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_drv.h | 1 -

[Intel-gfx] Requesting access to CLOSE the issue

2020-03-16 Thread Karanam, Sri Lakshmi
Hi , When I was going through the gitlab issues,I encountered an issue https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/issues/186 for which the patch is merged in 5.5 kernel and becomes the duplicate of https://gitlab.freedesktop.org/drm/intel/issues/673 and can be CLOSED. I didn't g

Re: [Intel-gfx] [PATCH 4/7] drm/i915/gt: Allocate i915_fence_reg array

2020-03-16 Thread Mika Kuoppala
Chris Wilson writes: > Since the number of fence regs can vary dramactically between platforms, > allocate the array on demand so we don't waste as much space. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 -- > drivers/gpu/drm/i915/gt/intel_ggtt_

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_gttfill: MMAP_OFFSET related refresh

2020-03-16 Thread Janusz Krzysztofik
On Thu, 2020-03-05 at 18:53 +0100, Janusz Krzysztofik wrote: > The test already tried to use a working mapping by first trying legacy > WC, then GTT. Use gem_mmap__device_coherent() helper instead of > approaching its implementation locally. > > Signed-off-by: Janusz Krzysztofik Please ignore t

Re: [Intel-gfx] [RFC][PATCH 1/5] drm: Introduce scaling filter property

2020-03-16 Thread Daniel Vetter
On Tue, Mar 10, 2020 at 06:01:06PM +0200, Ville Syrjälä wrote: > On Tue, Feb 25, 2020 at 12:35:41PM +0530, Pankaj Bharadiya wrote: > > Introduce new scaling filter property to allow userspace to select > > the driver's default scaling filter or Nearest-neighbor(NN) filter > > for upscaling operatio

[Intel-gfx] [RESUBMIT PATCH 2/2] tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent subtests

2020-03-16 Thread Janusz Krzysztofik
Extend initial check for support of MMAP_GTT mapping to userptr with equivalent checks for each MMAP_OFFSET mapping type supported by i915 driver. Based on that, extend coverage of process-exit-gtt* subtests over non-GTT mapping types. In case of dmabuf-* subtests, use first supported mapping typ

Re: [Intel-gfx] [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-16 Thread Daniel Vetter
On Wed, Mar 11, 2020 at 10:07:13AM +0100, Thomas Zimmermann wrote: > Hi Daniel > > Am 02.03.20 um 23:25 schrieb Daniel Vetter: > > We have lots of these. And the cleanup code tends to be of dubious > > quality. The biggest wrong pattern is that developers use devm_, which > > ties the release acti

[Intel-gfx] [RESUBMIT PATCH 0/2] tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent subtests

2020-03-16 Thread Janusz Krzysztofik
Together with recently submitted patches, this series concludes MMAP_OFFSET related changes required for gem_userptr_blits. Thanks, Janusz Janusz Krzysztofik (2): tests/gem_userptr_blits: Refresh readonly-mmap-unsync exercise tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent subte

[Intel-gfx] [RESUBMIT PATCH 1/2] tests/gem_userptr_blits: Refresh readonly-mmap-unsync exercise

2020-03-16 Thread Janusz Krzysztofik
Upgrade the subtest to use MMAP_GTT API v4 (aka MMAP_OFFSET), dynamically examine each mapping type supported by i915 driver. Signed-off-by: Janusz Krzysztofik --- tests/i915/gem_userptr_blits.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tests/i915

Re: [Intel-gfx] [PATCH 03/51] drm: add managed resources tied to drm_device

2020-03-16 Thread Daniel Vetter
On Wed, Mar 11, 2020 at 10:14:03AM +0100, Thomas Zimmermann wrote: > > > Am 02.03.20 um 23:25 schrieb Daniel Vetter: > <...> > > + > > +int __drmm_add_action(struct drm_device *dev, > > + drmres_release_t action, > > + void *data, const char *name) > > +{ > > + s

Re: [Intel-gfx] [PATCH 21/51] drm: Use drmm_ for drm_dev_init cleanup

2020-03-16 Thread Daniel Vetter
On Wed, Mar 11, 2020 at 10:39:13AM +0100, Thomas Zimmermann wrote: > Hi > > Am 02.03.20 um 23:26 schrieb Daniel Vetter: > > Well for the simple stuff at least, vblank, gem and minor cleanup I > > want to further split up as a demonstration. > > > > v2: We need to clear drm_device->dev otherwise t

Re: [Intel-gfx] [PATCH 22/51] drm: manage drm_minor cleanup with drmm_

2020-03-16 Thread Daniel Vetter
On Wed, Mar 11, 2020 at 10:59:10AM +0100, Thomas Zimmermann wrote: > Hi > > Am 02.03.20 um 23:26 schrieb Daniel Vetter: > > The cleanup here is somewhat tricky, since we can't tell apart the > > allocated minor index from 0. So register a cleanup action first, and > > if the index allocation fails

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915/perf: introduce global sseu pinning

2020-03-16 Thread Tvrtko Ursulin
On 14/03/2020 10:33, Lionel Landwerlin wrote: On Gen11 powergating half the execution units is a functional requirement when using the VME samplers. Not fullfilling this requirement can lead to hangs. This unfortunately plays fairly poorly with the NOA requirements. NOA requires a stable power

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/perf: introduce global sseu pinning

2020-03-16 Thread Tvrtko Ursulin
On 13/03/2020 14:34, Lionel Landwerlin wrote: On Gen11 powergating half the execution units is a functional requirement when using the VME samplers. Not fullfilling this requirement can lead to hangs. This unfortunately plays fairly poorly with the NOA requirements. NOA requires a stable power

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/perf: introduce global sseu pinning

2020-03-16 Thread Lionel Landwerlin
On 16/03/2020 11:16, Tvrtko Ursulin wrote: On 13/03/2020 14:34, Lionel Landwerlin wrote: On Gen11 powergating half the execution units is a functional requirement when using the VME samplers. Not fullfilling this requirement can lead to hangs. This unfortunately plays fairly poorly with the NO

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-16 Thread Christian König
Am 16.03.20 um 09:56 schrieb Christoph Hellwig: On Fri, Mar 13, 2020 at 09:17:42AM -0300, Jason Gunthorpe wrote: On Fri, Mar 13, 2020 at 04:21:39AM -0700, Christoph Hellwig wrote: On Thu, Mar 12, 2020 at 11:19:28AM -0300, Jason Gunthorpe wrote: The non-page scatterlist is also a big concern fo

Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming

2020-03-16 Thread Daniel Vetter
On Fri, Mar 06, 2020 at 02:56:06AM -0800, Joe Perches wrote: > On Fri, 2020-03-06 at 11:39 +0100, Daniel Vetter wrote: > > On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote: > > > Am 04.03.20 um 13:07 schrieb Lukas Bulwahn: > > > > Commit 52791eeec1d9 ("dma-buf: rename reservation_obj

Re: [Intel-gfx] [PATCH] MAINTAINERS: adjust to reservation.h renaming

2020-03-16 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 10:50:07AM +0100, Daniel Vetter wrote: > On Fri, Mar 06, 2020 at 02:56:06AM -0800, Joe Perches wrote: > > On Fri, 2020-03-06 at 11:39 +0100, Daniel Vetter wrote: > > > On Wed, Mar 04, 2020 at 01:08:32PM +0100, Christian König wrote: > > > > Am 04.03.20 um 13:07 schrieb Lukas

Re: [Intel-gfx] [PATCH] drm: Mark up racy check of drm_gem_object.handle_count

2020-03-16 Thread Daniel Vetter
On Mon, Mar 09, 2020 at 12:01:51PM +, Chris Wilson wrote: > [ 1715.899800] BUG: KCSAN: data-race in drm_gem_handle_create_tail / > drm_gem_object_handle_put_unlocked > [ 1715.899838] > [ 1715.899861] write to 0x8881830f3604 of 4 bytes by task 7834 on cpu 1: > [ 1715.899896] drm_gem_handle

Re: [Intel-gfx] [PATCH] drm/mm: Allow drm_mm_initialized() to be used outside of the locks

2020-03-16 Thread Daniel Vetter
On Mon, Mar 09, 2020 at 12:15:29PM +, Chris Wilson wrote: > Mark up the potential racy read in drm_mm_initialized(), as we want a > cheap and cheerful check: > > [ 121.098731] BUG: KCSAN: data-race in _i915_gem_object_create_stolen [i915] > / rm_hole > [ 121.098766] > [ 121.098789] write (

Re: [Intel-gfx] [PATCH 4/7] drm/i915/gt: Allocate i915_fence_reg array

2020-03-16 Thread Chris Wilson
Quoting Mika Kuoppala (2020-03-16 07:29:36) > Chris Wilson writes: > > > Since the number of fence regs can vary dramactically between platforms, > > allocate the array on demand so we don't waste as much space. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/gt/intel_ggtt.

[Intel-gfx] [PATCH v5 2/7] drm/dp: get/set phy compliance pattern

2020-03-16 Thread Animesh Manna
During phy compliance auto test mode source need to read requested test pattern from sink through DPCD. After processing the request source need to set the pattern. So set/get method added in drm layer as it is DP protocol. v2: As per review feedback from Manasi on RFC version, - added dp revision

[Intel-gfx] [PATCH v5 1/7] drm/amd/display: Align macro name as per DP spec

2020-03-16 Thread Animesh Manna
[Why]: Aligh with DP spec wanted to follow same naming convention. [How]: Changed the macro name of the dpcd address used for getting requested test-pattern. Cc: Harry Wentland Cc: Alex Deucher Reviewed-by: Harry Wentland Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- drivers/g

[Intel-gfx] [PATCH v5 5/7] drm/i915/dp: Add debugfs entry for DP phy compliance

2020-03-16 Thread Animesh Manna
These debugfs entry will help testapp to understand the test request during dp phy compliance mode. Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/d

[Intel-gfx] [PATCH v5 3/7] drm/i915/dp: Made intel_dp_adjust_train() non-static

2020-03-16 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so have made non-static function. No functional change. v1: initial patch. v2: - used "intel_dp" prefix in function name. (Jani) - used array notation instead pointer for li

[Intel-gfx] [PATCH v5 6/7] drm/i915/dp: Register definition for DP compliance register

2020-03-16 Thread Animesh Manna
DP_COMP_CTL and DP_COMP_PAT register used to program DP compliance pattern. v1: Initial patch. v2: used pipe instead of port in macro definition. [Manasi] Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_reg.h | 20 1 file changed, 20 i

[Intel-gfx] [PATCH v5 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern

2020-03-16 Thread Animesh Manna
This patch process phy compliance request by programming requested vswing, pre-emphasis and test pattern. v1: Initial patch. v2: Fixes added during testing with test-scope. (Khaled/Clint/Manasi) - pipe used as argument during registers programming instead of port. - TRANS_CONF must be disable/enab

[Intel-gfx] [PATCH v5 4/7] drm/i915/dp: Preparation for DP phy compliance auto test

2020-03-16 Thread Animesh Manna
During DP phy compliance auto test mode, sink will request combination of different test pattern with differnt level of vswing, pre-emphasis. Function added to prepare for it. Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 1 + drive

[Intel-gfx] [PATCH v5 0/7] DP Phy compliance auto test

2020-03-16 Thread Animesh Manna
Driver changes mainly to process the request coming from Test equipment as short pulse hpd interrupt to change link-pattern/v-swing/pre-emphasis Complete auto test suite takes much lesser time than manual run. Overall design: -- Automate test request will come to source device as HDP s

[Intel-gfx] [PATCH i-g-t 2/2] i915/sysfs_heartbeat_interval: Check for support prior to 'nopreempt' test

2020-03-16 Thread Chris Wilson
To turn off preemption, we now require per-engine resets. Signed-off-by: Chris Wilson --- tests/i915/sysfs_heartbeat_interval.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/i915/sysfs_heartbeat_interval.c b/tests/i915/sysfs_heartbeat_interval.c index 0ba19b263..ef13

[Intel-gfx] [PATCH i-g-t 1/2] intel-ci: Tweak blacklist for very long running stability tests

2020-03-16 Thread Chris Wilson
To exclude yynamic tests just use their group name? Signed-off-by: Chris Wilson Cc: Petri Latvala --- tests/intel-ci/blacklist.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt index 948b47569..184c23c37 10

Re: [Intel-gfx] [PATCH 4/7] drm/i915/gt: Allocate i915_fence_reg array

2020-03-16 Thread Mika Kuoppala
Chris Wilson writes: > Since the number of fence regs can vary dramactically between platforms, > allocate the array on demand so we don't waste as much space. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 -- > drive

[Intel-gfx] [CI 1/4] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Chris Wilson
Since the fence registers control HW detiling through the GGTT aperture, make them a part of the intel_ggtt under gt/ Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- .../inte

[Intel-gfx] [CI 4/4] drm/i915/gt: Allocate i915_fence_reg array

2020-03-16 Thread Chris Wilson
Since the number of fence regs can vary dramactically between platforms, allocate the array on demand so we don't waste as much space. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 -- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.

[Intel-gfx] [CI 3/4] drm/i915: Remove manual save/resume of fence register state

2020-03-16 Thread Chris Wilson
Since we always reload the fence register state on runtime resume, having it explicitly in the S0ix resume code is redundant. Indeed, it is not even being used! Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [CI 2/4] drm/i915/gt: Pull restoration of GGTT fences underneath the GT

2020-03-16 Thread Chris Wilson
Make the GT responsible for restoring its fence when it wakes up from suspend. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 driver

[Intel-gfx] [PATCH v1 1/3] drm/i915: Decouple cdclk calculation from modeset checks

2020-03-16 Thread Stanislav Lisovskiy
We need to calculate cdclk after watermarks/ddb has been calculated as with recent hw CDCLK needs to be adjusted accordingly to DBuf requirements, which is not possible with current code organization. Setting CDCLK according to DBuf BW requirements and not just rejecting if it doesn't satisfy BW r

[Intel-gfx] [PATCH v1 3/3] drm/i915: Remove unneeded hack now for CDCLK

2020-03-16 Thread Stanislav Lisovskiy
No need to bump up CDCLK now, as it is now correctly calculated, accounting for DBuf BW as BSpec says. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/

[Intel-gfx] [PATCH v1 2/3] drm/i915: Adjust CDCLK accordingly to our DBuf bw needs

2020-03-16 Thread Stanislav Lisovskiy
According to BSpec max BW per slice is calculated using formula Max BW = CDCLK * 64. Currently when calculating min CDCLK we account only per plane requirements, however in order to avoid FIFO underruns we need to estimate accumulated BW consumed by all planes(ddb entries basically) residing on tha

[Intel-gfx] [PATCH v1 0/3] Consider DBuf bandwidth when calculating CDCLK

2020-03-16 Thread Stanislav Lisovskiy
We need to calculate cdclk after watermarks/ddb has been calculated as with recent hw CDCLK needs to be adjusted accordingly to DBuf requirements, which is not possible with current code organization. Setting CDCLK according to DBuf BW requirements and not just rejecting if it doesn't satisfy BW r

[Intel-gfx] [PATCH 15/15] drm/i915/gem: Bind the fence async for execbuf

2020-03-16 Thread Chris Wilson
It is illegal to wait on an another vma while holding the vm->mutex, as that easily leads to ABBA deadlocks (we wait on a second vma that waits on us to release the vm->mutex). So while the vm->mutex exists, move the waiting outside of the lock into the async binding pipeline. Signed-off-by: Chris

[Intel-gfx] [PATCH 10/15] drm/i915/gem: Assign context id for async work

2020-03-16 Thread Chris Wilson
Allocate a few dma fence context id that we can use to associate async work [for the CPU] launched on behalf of this context. For extra fun, we allow a configurable concurrency width. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 4 drivers/gpu/drm/i915

[Intel-gfx] [PATCH 09/15] drm/i915: Immediately execute the fenced work

2020-03-16 Thread Chris Wilson
If the caller allows and we do not have to wait for any signals, immediately execute the work within the caller's process. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence_work.c | 6 +- drivers/gpu/drm/i915/i915_s

[Intel-gfx] [PATCH 05/15] drm/i915/gt: Only wait for GPU activity before unbinding a GGTT fence

2020-03-16 Thread Chris Wilson
Only GPU activity via the GGTT fence is asynchronous, we know that we control the CPU access directly, so we only need to wait for the GPU to stop using the fence before we relinquish it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 12 drivers/gpu/

[Intel-gfx] [PATCH 08/15] drm/i915/gem: Drop cached obj->bind_count

2020-03-16 Thread Chris Wilson
We cached the number of vma bound to the object in order to speed up shrinker decisions. This has been superseded by being more proactive in removing objects we cannot shrink from the shrinker lists, and so we can drop the clumsy attempt at atomically counting the bind count and comparing it to the

[Intel-gfx] [PATCH 06/15] drm/i915/gt: Store the fence details on the fence

2020-03-16 Thread Chris Wilson
Make a copy of the object tiling parameters at the point of grabbing the fence. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 93 +++- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.h | 4 + 2 files changed, 37 insertions(+), 60 deletions(-) diff --

[Intel-gfx] [PATCH 11/15] drm/i915: Export a preallocate variant of i915_active_acquire()

2020-03-16 Thread Chris Wilson
Sometimes we have to be very careful not to allocate underneath a mutex (or spinlock) and yet still want to track activity. Enter i915_active_acquire_for_context(). This raises the activity counter on i915_active prior to use and ensures that the fence-tree contains a slot for the context. Signed-

[Intel-gfx] [PATCH 07/15] drm/i915/gt: Make fence revocation unequivocal

2020-03-16 Thread Chris Wilson
If we must revoke the fence because the VMA is no longer present, or because the fence no longer applies, ensure that we do and convert it into an error if we try but cannot. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 21 +++- drivers/gpu/drm/i

[Intel-gfx] [PATCH 14/15] drm/i915/gem: Asynchronous GTT unbinding

2020-03-16 Thread Chris Wilson
It is reasonably common for userspace (even modern drivers like iris) to reuse an active address for a new buffer. This would cause the application to stall under its mutex (originally struct_mutex) until the old batches were idle and it could synchronously remove the stale PTE. However, we can que

[Intel-gfx] [PATCH 13/15] drm/i915/gem: Separate the ww_mutex walker into its own list

2020-03-16 Thread Chris Wilson
In preparation for making eb_vma bigger and heavy to run inn parallel, we need to stop apply an in-place swap() to reorder around ww_mutex deadlocks. Keep the array intact and reorder the locks using a dedicated list. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c

[Intel-gfx] [PATCH 01/15] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Chris Wilson
Since the fence registers control HW detiling through the GGTT aperture, make them a part of the intel_ggtt under gt/ Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- .../inte

[Intel-gfx] [PATCH 12/15] drm/i915/gem: Split eb_vma into its own allocation

2020-03-16 Thread Chris Wilson
Use a separate array allocation for the execbuf vma, so that we can track their lifetime independently from the copy of the user arguments. With luck, this has a secondary benefit of splitting the malloc size to within reason and avoid vmalloc. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/ge

[Intel-gfx] [PATCH 04/15] drm/i915/gt: Allocate i915_fence_reg array

2020-03-16 Thread Chris Wilson
Since the number of fence regs can vary dramactically between platforms, allocate the array on demand so we don't waste as much space. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 -- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.

[Intel-gfx] [PATCH 03/15] drm/i915: Remove manual save/resume of fence register state

2020-03-16 Thread Chris Wilson
Since we always reload the fence register state on runtime resume, having it explicitly in the S0ix resume code is redundant. Indeed, it is not even being used! Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 1 - 1 file changed, 1 deletion(-) diff

[Intel-gfx] [PATCH 02/15] drm/i915/gt: Pull restoration of GGTT fences underneath the GT

2020-03-16 Thread Chris Wilson
Make the GT responsible for restoring its fence when it wakes up from suspend. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 ++ drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 driver

Re: [Intel-gfx] [PATCH i-g-t 1/2] intel-ci: Tweak blacklist for very long running stability tests

2020-03-16 Thread Petri Latvala
On Mon, Mar 16, 2020 at 10:54:26AM +, Chris Wilson wrote: > To exclude yynamic tests just use their group name? Yes, the igt_subtest_with_dynamic("somename") macro creates a subtest entry point just like igt_subtest, for the purposes of testlists and blacklists. > > Signed-off-by: Chris Wi

Re: [Intel-gfx] Fixes that failed to apply to v5.6-rc3

2020-03-16 Thread Jani Nikula
On Thu, 27 Feb 2020, Jani Nikula wrote: > Hi all - > > The following commits have been marked as Cc: stable or fixing something > in v5.6-rc3 or earlier, but failed to cherry-pick to > drm-intel-fixes. Please see if they are worth backporting, and please do > so if they are. New ones for -rc6: 0

[Intel-gfx] [PATCH v7 1/3] drm/i915: Get active pending request for given context

2020-03-16 Thread Ankit Navik
This patch gives us the active pending request count which is yet to be submitted to the GPU. V2: * Change 64-bit to atomic for request count. (Tvrtko Ursulin) V3: * Remove mutex for request count. * Rebase. * Fixes hitting underflow for predictive request. (Tvrtko Ursulin) V4: * Rebase. V

[Intel-gfx] [PATCH v7 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2020-03-16 Thread Ankit Navik
Load classification is used for predictive governor to control eu/slice/subslice based on workloads. sysfs is provided to enable/disable the feature V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private structure. * Make generic function to set optimum config. (Tvrtko U

[Intel-gfx] [PATCH v7 0/3] drm/i915: Context aware user agnostic EU/Slice/Sub-slice control within kernel

2020-03-16 Thread Ankit Navik
This patch sets improves GPU power consumption on Linux kernel based OS such as Chromium OS, Ubuntu, etc. Following are the power savings. Power savings on GLK-GT1 Bobba platform running on Chrome OS. ---| App /KPI| % Power Benefit (mW) |

[Intel-gfx] [PATCH v7 2/3] drm/i915: set optimum eu/slice/sub-slice configuration based on load type

2020-03-16 Thread Ankit Navik
This patch will select optimum eu/slice/sub-slice configuration based on type of load (low, medium, high) as input. Based on our readings and experiments we have predefined set of optimum configuration for each platform(CHT, KBL). i915_gem_context_set_load_type will select optimum configuration fro

[Intel-gfx] [PATCH v7 1/3] drm/i915: Get active pending request for given context

2020-03-16 Thread Ankit Navik
This patch gives us the active pending request count which is yet to be submitted to the GPU. V2: * Change 64-bit to atomic for request count. (Tvrtko Ursulin) V3: * Remove mutex for request count. * Rebase. * Fixes hitting underflow for predictive request. (Tvrtko Ursulin) V4: * Rebase. V

[Intel-gfx] [PATCH v7 3/3] drm/i915: Predictive governor to control slice/subslice/eu

2020-03-16 Thread Ankit Navik
Load classification is used for predictive governor to control eu/slice/subslice based on workloads. sysfs is provided to enable/disable the feature V2: * Fix code style. * Move predictive_load_timer into a drm_i915_private structure. * Make generic function to set optimum config. (Tvrtko U

[Intel-gfx] [PATCH v7 0/3] Dynamic EU configuration of Slice/Sub-slice/EU

2020-03-16 Thread Ankit Navik
drm/i915: Context aware user agnostic EU/Slice/Sub-slice control within kernel This patch sets improves GPU power consumption on Linux kernel based OS such as Chromium OS, Ubuntu, etc. Following are the power savings. Power savings on GLK-GT1 Bobba platform running on Chrome OS. -

[Intel-gfx] [PATCH v7 2/3] drm/i915: set optimum eu/slice/sub-slice configuration based on load type

2020-03-16 Thread Ankit Navik
This patch will select optimum eu/slice/sub-slice configuration based on type of load (low, medium, high) as input. Based on our readings and experiments we have predefined set of optimum configuration for each platform(CHT, KBL). i915_gem_context_set_load_type will select optimum configuration fro

Re: [Intel-gfx] [PATCH v7 1/3] drm/i915: Get active pending request for given context

2020-03-16 Thread Chris Wilson
Quoting Ankit Navik (2020-03-16 13:29:49) > This patch gives us the active pending request count which is yet > to be submitted to the GPU. > > V2: > * Change 64-bit to atomic for request count. (Tvrtko Ursulin) > > V3: > * Remove mutex for request count. > * Rebase. > * Fixes hitting underfl

Re: [Intel-gfx] [PATCH] drm/i915/dp/mst : Get clock rate from sink's available PBN

2020-03-16 Thread Lee, Shawn C
On Wed, 2020-03-11, Lyude Paul wrote: >On Tue, 2020-01-07 at 01:41 +0800, Lee Shawn C wrote: >> Driver report physcial bandwidth for max dot clock rate. >> It would caused compatibility issue sometimes when physical bandwidth >> exceed MST hub output ability. >> >> For example, here is a MST hu

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-16 Thread Christoph Hellwig
On Fri, Mar 13, 2020 at 09:17:42AM -0300, Jason Gunthorpe wrote: > On Fri, Mar 13, 2020 at 04:21:39AM -0700, Christoph Hellwig wrote: > > On Thu, Mar 12, 2020 at 11:19:28AM -0300, Jason Gunthorpe wrote: > > > The non-page scatterlist is also a big concern for RDMA as we have > > > drivers that want

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-16 Thread Christoph Hellwig
On Mon, Mar 16, 2020 at 10:41:42AM +0100, Christian König wrote: > Well I would prefer if the drivers can somehow express their requirements > and get IOVA structures already in the form they need. > > Converting the IOVA data from one form to another is sometimes quite costly. > Especially when i

Re: [Intel-gfx] [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-16 Thread Christoph Hellwig
On Thu, Mar 12, 2020 at 11:19:28AM -0300, Jason Gunthorpe wrote: > The non-page scatterlist is also a big concern for RDMA as we have > drivers that want the page list, so even if we did as this series > contemplates I'd have still have to split the drivers and create the > notion of a dma-only SGL

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Port sync for skl+

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915: Port sync for skl+ URL : https://patchwork.freedesktop.org/series/74691/ State : failure == Summary == Applying: drm/i915/mst: Use .compute_config_late() to compute master transcoder Applying: drm/i915: Move TRANS_DDI_FUNC_CTL2 programming where it belong

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: DisplayID parser fixes

2020-03-16 Thread Patchwork
== Series Details == Series: drm/edid: DisplayID parser fixes URL : https://patchwork.freedesktop.org/series/74689/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16968 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH] drm/i915/gem: Try allocating va from free space

2020-03-16 Thread Chris Wilson
If the current node/entry location is occupied, and the object is not pinned, try assigning it some free space. We cannot wait here, so if in doubt, we unreserve and try to grab all at once. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 13 +++-- 1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev2)

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev2) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16970 Summary

Re: [Intel-gfx] [RFC][PATCH 1/5] drm: Introduce scaling filter property

2020-03-16 Thread Ville Syrjälä
On Mon, Mar 16, 2020 at 09:31:32AM +0100, Daniel Vetter wrote: > On Tue, Mar 10, 2020 at 06:01:06PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 25, 2020 at 12:35:41PM +0530, Pankaj Bharadiya wrote: > > > Introduce new scaling filter property to allow userspace to select > > > the driver's default s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] drm/i915/perf: remove generated code

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915/perf: remove generated code URL : https://patchwork.freedesktop.org/series/74702/ State : warning == Summary == $ dim checkpatch origin/drm-tip e31b72062fe2 drm/i915/perf: remove generated code -:24: WARNING:UNKNOWN_COMMIT_ID:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/i915/perf: remove generated code

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915/perf: remove generated code URL : https://patchwork.freedesktop.org/series/74702/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16971 Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74703/ State : warning == Summary == $ dim checkpatch origin/drm-tip cfd159dc30dd drm/i915: Move GGTT fence registers under gt/ -:6: WARNING:TYPO

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/7] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74703/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fence_r

[Intel-gfx] [PATCH] drm/i915/gem: Check for a closed context when looking up an engine

2020-03-16 Thread Chris Wilson
Beware that the context may already be closed as we try to lookup an engine. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1389 Fixes: 130a95e9098e ("drm/i915/gem: Consolidate ctx->engines[] release") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala --- drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: convert to struct drm_device based logging macros.

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: convert to struct drm_device based logging macros. URL : https://patchwork.freedesktop.org/series/74707/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6cfa7991dd93 drm/i915/ggtt: convert to drm_device based logging macros. -:84: WARNING

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16972 ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: convert to struct drm_device based logging macros.

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: convert to struct drm_device based logging macros. URL : https://patchwork.freedesktop.org/series/74707/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16973 Summar

Re: [Intel-gfx] [PATCH 2/2] drm/i915: move audio CDCLK constraint setup to bind/unbind

2020-03-16 Thread Kai Vehmanen
Hey Ville and others, On Fri, 13 Mar 2020, Kai Vehmanen wrote: > On Fri, 13 Mar 2020, Ville Syrjälä wrote: > Now thinking of another possibility, is it possible to hook code to > power-up of power domains? E.g. can I hook custom code which is executed [...] > If we could reprogram AUD_FREQ_CNTRL

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev3)

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev3) URL : https://patchwork.freedesktop.org/series/74100/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3d21f79cfaf6 drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v3) -:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev3)

2020-03-16 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev3) URL : https://patchwork.freedesktop.org/series/74100/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16974 Su

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915/perf: remove generated code

2020-03-16 Thread Umesh Nerlige Ramappa
Looks good. Thanks for cleaning this up. With s/mutex_lock/mutex_unlock/ below: Reviewed-by: Umesh Nerlige Ramappa Thanks, Umesh On Sat, Mar 14, 2020 at 12:33:29PM +0200, Lionel Landwerlin wrote: A little bit of history : Back when i915-perf was introduced (4.13), there was no way to dy

[Intel-gfx] ✗ Fi.CI.BUILD: failure for tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent subtests

2020-03-16 Thread Patchwork
== Series Details == Series: tests/gem_userptr_blits: Refresh other now MMAP_GTT dependent subtests URL : https://patchwork.freedesktop.org/series/74730/ State : failure == Summary == Applying: tests/gem_userptr_blits: Refresh readonly-mmap-unsync exercise error: sha1 information is lacking or

Re: [Intel-gfx] [PATCH 1/4] drm/i915/perf: rework aging tail workaround

2020-03-16 Thread Dixit, Ashutosh
On Thu, 12 Mar 2020 16:04:59 -0700, Umesh Nerlige Ramappa wrote: > > From: Lionel Landwerlin > > We're about to introduce an options to open the perf stream, giving > the user ability to configure how often it wants the kernel to poll > the OA registers for available data. > > Right now the workar

[Intel-gfx] ✓ Fi.CI.BAT: success for DP Phy compliance auto test (rev7)

2020-03-16 Thread Patchwork
== Series Details == Series: DP Phy compliance auto test (rev7) URL : https://patchwork.freedesktop.org/series/71121/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16976 Summary --- **SUCCESS** N

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74738/ State : warning == Summary == $ dim checkpatch origin/drm-tip 24d226d21d96 drm/i915: Move GGTT fence registers under gt/ -:47: WARNING

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74738/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/i915_gem_fen

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74738/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16977 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Consider DBuf bandwidth when calculating CDCLK

2020-03-16 Thread Patchwork
== Series Details == Series: Consider DBuf bandwidth when calculating CDCLK URL : https://patchwork.freedesktop.org/series/74739/ State : warning == Summary == $ dim checkpatch origin/drm-tip 70a984e1e806 drm/i915: Decouple cdclk calculation from modeset checks 01a1b24738fd drm/i915: Adjust CD

Re: [Intel-gfx] [PATCH 2/4] drm/i915/perf: move pollin setup to non hw specific code

2020-03-16 Thread Dixit, Ashutosh
On Thu, 12 Mar 2020 16:05:00 -0700, Umesh Nerlige Ramappa wrote: > > From: Lionel Landwerlin > > This isn't really gen specific stuff, so just move it to the common > code. It seems pollin is not the only member which is not gen specific but is initialized in gen specific code. Anyway any other s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Move GGTT fence registers under gt/

2020-03-16 Thread Patchwork
== Series Details == Series: series starting with [01/15] drm/i915: Move GGTT fence registers under gt/ URL : https://patchwork.freedesktop.org/series/74740/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2bf8a0072a07 drm/i915: Move GGTT fence registers under gt/ -:47: WARNING:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Consider DBuf bandwidth when calculating CDCLK

2020-03-16 Thread Patchwork
== Series Details == Series: Consider DBuf bandwidth when calculating CDCLK URL : https://patchwork.freedesktop.org/series/74739/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16978 Summary --- **FA

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Adjust PM QoS response frequency based on GPU load.

2020-03-16 Thread Francisco Jerez
Francisco Jerez writes: > Tvrtko Ursulin writes: >[...] >> Some time ago we entertained the idea of GPU "load average", where that >> was defined as a count of runnable requests (so batch buffers). How >> that, more generic metric, would behave here if used as an input signal >> really intrig

[Intel-gfx] [CI] drm/i915/gt: Restore check for invalid vma for fencing

2020-03-16 Thread Chris Wilson
Apparently we do try and attach a fence to an invalid vma (during execbuf) so we cannot simply assert it never happens and report EINVAL instead. Fixes: dec9cf9ee8cb ("drm/i915/gt: Pull restoration of GGTT fences underneath the GT") Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- dr

  1   2   >