Allows us to drop the drm_driver.release callback.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: This dr
Auto-unwind ftw, now possible with the fixed drm_device related
management.
Aside, clk/regulator seem to be missing devm versions for a bunch of
functions, preventing a pile of these simpler drivers from outright
losing their ->remove hook.
Reviewed-by: Linus Walleij
Signed-off-by: Daniel Vetter
7/7 drivers agree that's the right choice, let's do this.
This avoids duplicating the same old error checking code over all 7
drivers, which is the motivation here.
Acked-by: Sam Ravnborg
Reviewed-by: Noralf Trønnes
Tested-by: Noralf Trønnes
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
== Series Details ==
Series: drm/i915/display: Decrease log level
URL : https://patchwork.freedesktop.org/series/74166/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c
Error: Cannot open file ./drivers/gpu/dr
== Series Details ==
Series: drm/i915/display: Decrease log level
URL : https://patchwork.freedesktop.org/series/74166/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8049 -> Patchwork_16786
Summary
---
**SUCCESS**
== Series Details ==
Series: drm_device managed resources (rev2)
URL : https://patchwork.freedesktop.org/series/73633/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7620b1305ad8 mm/sl[uo]b: export __kmalloc_track(_node)_caller
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-of
== Series Details ==
Series: drm_device managed resources (rev2)
URL : https://patchwork.freedesktop.org/series/73633/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: mm/sl[uo]b: export __kmalloc_track(_node)_caller
Okay!
__
Following the changes in the previous patch
"drm/i915/gen11: Moving WAs to rcs_engine_wa_init()" also moving TGL
Wa_1408615072 to rcs_engine_wa_init() this way after a engine
reset it will be reapplied also restricting it to B0 as it is fixed in
B0 stepping.
BSpec: 52890
Cc: Matt Roper
Signed-off
This are register of render engine, so after a render reset those
would return to the default value and init_clock_gating() is not
called for single engine reset.
So here moving it rcs_engine_wa_init() that will guarantee that this
WAs will not be lost.
Cc: Matt Roper
Signed-off-by: José Roberto
== Series Details ==
Series: drm_device managed resources (rev2)
URL : https://patchwork.freedesktop.org/series/73633/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c
Error: Cannot open file ./drivers/gpu/drm
== Series Details ==
Series: drm_device managed resources (rev2)
URL : https://patchwork.freedesktop.org/series/73633/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8049 -> Patchwork_16787
Summary
---
**SUCCESS**
Adaptive Sync is a VESA feature so add a DRM core helper to parse
the EDID's detailed descritors to obtain the adaptive sync monitor range.
Store this info as part fo drm_display_info so it can be used
across all drivers.
This part of the code is stripped out of amdgpu's function
amdgpu_dm_update_f
== Series Details ==
Series: series starting with [1/2] drm/i915/gen11: Moving WAs to
rcs_engine_wa_init()
URL : https://patchwork.freedesktop.org/series/74174/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.
On 2/29/2020 9:20 AM, Daniele Ceraolo Spurio wrote:
Update to the latest available TGL HuC, which includes changes required
by the media team.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Tony Ye
Cc: Michal Wajdeczko
Cc: Anusha Srivatsa
Reviewed-by: José Roberto de Souza
---
drivers/gpu/drm
== Series Details ==
Series: series starting with [1/2] drm/i915/gen11: Moving WAs to
rcs_engine_wa_init()
URL : https://patchwork.freedesktop.org/series/74174/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8049 -> Patchwork_16788
=
== Series Details ==
Series: drm/dp, i915: eDP DPCD backlight control detection fixes (rev3)
URL : https://patchwork.freedesktop.org/series/72991/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c
Error: Cannot
On 3/2/20 4:25 PM, Ye, Tony wrote:
On 2/29/2020 9:20 AM, Daniele Ceraolo Spurio wrote:
Update to the latest available TGL HuC, which includes changes required
by the media team.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Tony Ye
Cc: Michal Wajdeczko
Cc: Anusha Srivatsa
Reviewed-by: José R
== Series Details ==
Series: drm/dp, i915: eDP DPCD backlight control detection fixes (rev3)
URL : https://patchwork.freedesktop.org/series/72991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8049 -> Patchwork_16789
Summar
== Series Details ==
Series: series starting with [1/6] drm/i915: Nuke pointless div by 64bit
URL : https://patchwork.freedesktop.org/series/74145/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8043_full -> Patchwork_16780_full
=
Hi Daniele,
I'm sorry I missed this patch,
On Thu, Feb 27, 2020 at 06:28:42PM -0800, Daniele Ceraolo Spurio wrote:
> uC is a component of the GT, so it makes sense for the uC debugfs files
> to be in the GT folder. A subfolder has been used to keep the same
> structure we have for the code.
Can
== Series Details ==
Series: drm/dp: Add function to parse EDID descriptors for adaptive sync limits
(rev2)
URL : https://patchwork.freedesktop.org/series/68488/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr
== Series Details ==
Series: drm/i915: Fix doclinks
URL : https://patchwork.freedesktop.org/series/74146/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8043_full -> Patchwork_16781_full
Summary
---
**FAILURE**
Ser
== Series Details ==
Series: drm/dp: Add function to parse EDID descriptors for adaptive sync limits
(rev2)
URL : https://patchwork.freedesktop.org/series/68488/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8050 -> Patchwork_16790
> -Original Message-
> From: Daniel Vetter
> Sent: 03 March 2020 03:15
> To: Emil Velikov
> Cc: Laxminarayan Bharadiya, Pankaj
> ; Jani Nikula
> ; Daniel Vetter ; Intel
> Graphics Development ; ML dri-devel de...@lists.freedesktop.org>
> Subject: Re: [Intel-gfx] [PATCH v2 0/7] drm: drm
> -Original Message-
> From: Emil Velikov
> Sent: 02 March 2020 23:51
> To: Laxminarayan Bharadiya, Pankaj
>
> Cc: Jani Nikula ; Daniel Vetter
> ; Intel Graphics Development g...@lists.freedesktop.org>; ML dri-devel
> Subject: Re: [Intel-gfx] [PATCH v2 0/7] drm: drm_fb_helper cleanup
== Series Details ==
Series: drm: drm_fb_helper cleanup. (rev2)
URL : https://patchwork.freedesktop.org/series/74140/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8045_full -> Patchwork_16782_full
Summary
---
**SUCC
== Series Details ==
Series: drm/i915: fix documentation build after rename
URL : https://patchwork.freedesktop.org/series/74151/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8045_full -> Patchwork_16783_full
Summary
-
DP shim's config_stream_type considered to be succeeded when
return value of intel_dp_hdcp2_write_msg() equals to size of
message to be written, it makes config_stream_type to return
a zero success value in order to succeed the HDCP auth.
v2:
- config_stream_type() returns 0 on success. [Ram]
CC:
On 2020-03-03 at 10:54:07 +0530, Anshuman Gupta wrote:
> DP shim's config_stream_type considered to be succeeded when
> return value of intel_dp_hdcp2_write_msg() equals to size of
> message to be written, it makes config_stream_type to return
> a zero success value in order to succeed the HDCP aut
On 2020-03-03 at 11:13:25 +0530, Ramalingam C wrote:
> On 2020-03-03 at 10:54:07 +0530, Anshuman Gupta wrote:
> > DP shim's config_stream_type considered to be succeeded when
> > return value of intel_dp_hdcp2_write_msg() equals to size of
> > message to be written, it makes config_stream_type to r
== Series Details ==
Series: HDCP 2.2 Comp fixes (rev2)
URL : https://patchwork.freedesktop.org/series/73708/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c
Error: Cannot open file ./drivers/gpu/drm/i915/int
== Series Details ==
Series: HDCP 2.2 Comp fixes (rev2)
URL : https://patchwork.freedesktop.org/series/73708/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8050 -> Patchwork_16791
Summary
---
**SUCCESS**
No regres
On 2020-03-03 at 11:22:03 +0530, Anshuman Gupta wrote:
> On 2020-03-03 at 11:13:25 +0530, Ramalingam C wrote:
> > On 2020-03-03 at 10:54:07 +0530, Anshuman Gupta wrote:
> > > DP shim's config_stream_type considered to be succeeded when
> > > return value of intel_dp_hdcp2_write_msg() equals to size
On Mon, Mar 02, 2020 at 11:25:44PM +0100, Daniel Vetter wrote:
> I also did a full review of all callers, and only the xen driver
> forgot to call drm_dev_put in the failure path. Fix that up too.
>
> v2: I noticed that xen has a drm_driver.release hook, and uses
> drm_dev_alloc(). We need to remo
On Mon, Mar 02, 2020 at 11:25:47PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
Acked-by: Gerd Hoffmann
>
> Signed-off-by: Daniel Vetter
> Cc: Dave Airlie
> Cc: Gerd Hoffmann
> Cc: virtualizat...@lists.linux-foundation.org
> Cc: spice-de...@l
> @@ -575,9 +574,12 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
>
> dev = &cirrus->dev;
> ret = drm_dev_init(dev, &cirrus_driver, &pdev->dev);
> - if (ret)
> - goto err_free_cirrus;
> + if (ret) {
> + kfree(cirrus);
> + goto err_pci
DP shim's config_stream_type considered to be succeeded when
return value of intel_dp_hdcp2_write_msg() equals to size of
message to be written, it makes config_stream_type to return
a zero success value in order to succeed the HDCP auth.
v2:
- config_stream_type() returns 0 on success. [Ram]
CC:
On Mon, Mar 02, 2020 at 11:26:07PM +0100, Daniel Vetter wrote:
> Small mistake that crept into
>
> commit 81da8c3b8d3df6f05b11300b7d17ccd1f3017fab
> Author: Gerd Hoffmann
> Date: Tue Feb 11 14:52:18 2020 +0100
>
> drm/bochs: add drm_driver.release callback
>
> where drm_atomic_helper_shut
On Mon, Mar 02, 2020 at 11:26:08PM +0100, Daniel Vetter wrote:
> Instead rely on the automatic clean, for which we just need to check
> that drm_mode_config_init succeeded. To avoid an inversion in the
> cleanup we also have to move the dev_private allocation over to
> drmm_kzalloc.
>
> This is ma
On Mon, Mar 02, 2020 at 11:26:09PM +0100, Daniel Vetter wrote:
> We can even delete the drm_driver.release hook now!
>
> This is made possible by a preceeding patch which added a drmm_
> cleanup action to drm_mode_config_init(), hence all we need to do to
> ensure that drm_mode_config_cleanup() is
On Mon, Mar 02, 2020 at 11:26:10PM +0100, Daniel Vetter wrote:
> With the drm_device lifetime fun cleaned up there's nothing in the way
> anymore to use devm_ for everything hw releated. Do it, and in the
> process, throw out the entire onion unwinding.
Acked-by: Gerd Hoffmann
__
Hi
Am 02.03.20 um 23:26 schrieb Daniel Vetter:
> There's only two functions called from that:
> drm_kms_helper_poll_fini() and udl_free_urb_list(). Both of these are
> also called from the ubs_driver->disconnect hook, so entirely
> pointless to do the same again in the ->release hook.
>
> Further
201 - 243 of 243 matches
Mail list logo
