These are the leftover drivers that didn't have a ->release hook that
needed to be updated.
Signed-off-by: Daniel Vetter
Cc: "James (Qian) Wang"
Cc: Liviu Dudau
Cc: Mihail Atanassov
Cc: Russell King
Cc: Hans de Goede
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 ++
drivers/gpu/dr
With this we can drop the final kfree from the release function.
Acked-by: Jyri Sarha
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c
We have lots of these. And the cleanup code tends to be of dubious
quality. The biggest wrong pattern is that developers use devm_, which
ties the release action to the underlying struct device, whereas
all the userspace visible stuff attached to a drm_device can long
outlive that one (e.g. after a
With this we can drop the final kfree from the release function.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux-foundation.org
Cc: spice-de...@lists.freedesktop.org
---
drivers/gpu/drm/qxl/qxl_drv.c | 2 --
drivers/gpu/drm/qxl/qxl_kms.c | 2 ++
2
With this we can drop the final kfree from the release function.
v2: We need drm_dev_put to unroll the driver creation (once
drm_dev_init and drmm_add_final_kfree suceeded), otherwise
the drmm_ magic doesn't happen.
v3: Actually squash in the fixup (Laurent).
Signed-off-by: Daniel Vetter
Cc: La
With this we can drop the final kfree from the release function.
v2: After drm_dev_init/drmm_add_final_kfree we need to clean up
everything through a drm_dev_put. Rework the unwind code to match
that.
Signed-off-by: Daniel Vetter
Cc: Daniel Vetter
Cc: Emil Velikov
Cc: Chris Wilson
Cc: Sean Pa
Auto-unwind ftw, now possible with the fixed drm_device related
management.
Aside, clk/regulator seem to be missing devm versions for a bunch of
functions, preventing a pile of these simpler drivers from outright
losing their ->remove hook.
Reviewed-by: Linus Walleij
Signed-off-by: Daniel Vetter
We might want to look into pushing this down into drm_mm_init, but
that would mean rolling out return codes to a pile of functions
unfortunately. So let's leave that for now.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_drv.c | 8 +---
drivers/gpu/drm/drm_gem.c | 21 ++
Small mistake that crept into
commit 81da8c3b8d3df6f05b11300b7d17ccd1f3017fab
Author: Gerd Hoffmann
Date: Tue Feb 11 14:52:18 2020 +0100
drm/bochs: add drm_driver.release callback
where drm_atomic_helper_shutdown was left in both places. The
->release callback really shouldn't touch hardw
Allows us to drop the drm_driver.release callback.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
The cleanup here is somewhat tricky, since we can't tell apart the
allocated minor index from 0. So register a cleanup action first, and
if the index allocation fails, unregister that cleanup action again to
avoid bad mistakes.
The kdev for the minor already handles NULL, so no problem there.
Hen
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: Another
Allows us to drop the drm_driver.release callback.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: Another
It's (almost, there's some iommu stuff without significance) right
above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup
drm_mode_config_cleanup is idempotent, so no harm in calling this
twice. This allows us to gradually switch drivers over by removing
explicit drm_mode_config_cleanup calls.
With this step it's not also possible that (at least for simple
drivers) automatic resource cleanup can be done correctly wit
Instead rely on the automatic clean, for which we just need to check
that drm_mode_config_init succeeded. To avoid an inversion in the
cleanup we also have to move the dev_private allocation over to
drmm_kzalloc.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm
We can even delete the drm_driver.release hook now!
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: This dr
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: Another
Only drops the drm_dev_put, but hey a few lines!
Reviewed-by: Hans de Goede
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/tiny/gm12u320.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/tiny/gm1
With the drm_device lifetime fun cleaned up there's nothing in the way
anymore to use devm_ for everything hw releated. Do it, and in the
process, throw out the entire onion unwinding.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Em
Well for the simple stuff at least, vblank, gem and minor cleanup I
want to further split up as a demonstration.
v2: We need to clear drm_device->dev otherwise the debug drm printing
after our cleanup hook (e.g. in drm_manged_release) will chase
released memory and result in a use-after-free. Not
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: Another
It has become empty. Given the few users I figured not much point
splitting this up.
v2: Rebase over i915 changes.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/cirrus/cirrus.c | 1 -
drivers/gpu/drm/drm_drv.c | 23 +--
drivers/gpu/drm/drm_m
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: Another
Nothing special here, except that this is the first time that we
automatically clean up something that's initialized with an explicit
driver call. But the cleanup was done at the very of the release
sequence for all drivers, and that's still the case. At least without
more uses of drmm_ through exp
The drm_mode_config_cleanup call we can drop, and all the allocations
we can switch over to drmm_kzalloc. Unfortunately the work queue is
still present, so can't get rid of the drm_driver->release function
outright.
Reviewed-by: Hans de Goede
Signed-off-by: Daniel Vetter
Cc: Hans de Goede
Cc: "
7/7 drivers agree that's the right choice, let's do this.
This avoids duplicating the same old error checking code over all 7
drivers, which is the motivation here.
Reviewed-by: Noralf Trønnes
Tested-by: Noralf Trønnes
Signed-off-by: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc:
Instead of having a work item that never stops (which really should be
a kthread), with a dedicated workqueue to not upset anyone else, use a
delayed work. A bunch of changes:
- We can throw out all the custom wakeup and requeue logic and state
tracking. If we schedule the work with a 0 delay it
All collected together to provide a consistent story in one patch,
instead of the somewhat bumpy refactor-evolution leading to this.
Also some thoughts on what the next steps could be:
- Create a macro called devm_drm_dev_alloc() which essentially wraps
the kzalloc(); devm_drm_dev_init(); drmm_
It's right above the drm_dev_put().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Aside: This dr
With this we can drop the final kfree from the release function.
v2: After drm_dev_init/drmm_add_final_kfree we need to clean up
everything through a drm_dev_put. Rework the unwind code to match
that.
Signed-off-by: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Cc: Daniel Vetter
---
Allows us to drop the drm_driver.release callback.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final drm_device
cleanup is check the new error code for _init().
Also there's a race in the disconnect implemenation. First shut
down, then unplug, leaves a window where userspace could sneak
in and restart the entire machinery.
With this we can also delete the very un-atomic global pipe_enabled
tracking.
Reviewed-by: Hans de Goede
Signed-off-by: Daniel Vette
There's only two functions called from that:
drm_kms_helper_poll_fini() and udl_free_urb_list(). Both of these are
also called from the ubs_driver->disconnect hook, so entirely
pointless to do the same again in the ->release hook.
Furthermore by the time we clean up the drm_driver we really should
It's right above the drm_dev_put().
This allows us to delete a bit of onion unwinding in
udl_modeset_init().
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final d
Allows us to drop the drm_driver.release callback from all
drivers, and remove the mipi_dbi_release() function.
This is made possible by a preceeding patch which added a drmm_
cleanup action to drm_mode_config_init(), hence all we need to do to
ensure that drm_mode_config_cleanup() is run on final
== Series Details ==
Series: series starting with [1/3] drm/i915/vgpu: improve vgpu abstractions
URL : https://patchwork.freedesktop.org/series/74024/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8020 -> Patchwork_16735
Su
== Series Details ==
Series: drm/i915/dram: hide the dram structs better
URL : https://patchwork.freedesktop.org/series/74025/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3bee11e22182 drm/i915/dram: hide the dram structs better
-:9: ERROR:GIT_COMMIT_ID: Please use git commit
On Thu, Feb 27, 2020 at 07:57:41PM +0200, Ville Syrjälä wrote:
> On Wed, Feb 26, 2020 at 10:34:53PM +0200, Imre Deak wrote:
> > Split out the PLL parameter->frequency conversion logic for each type of
> > PLL for symmetry with their corresponding inverse conversion functions.
> >
> > Signed-off-by
On Thu, Feb 27, 2020 at 07:14:49PM +0100, Daniel Vetter wrote:
> These are the leftover drivers that didn't have a ->release hook that
> needed to be updated.
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Cc: Russell King
> Cc: Hans de G
hi - I almost certainly know the solution to this, the patches that we got
from amd to do bandwidth checking in the DP MST helpers don't actually work
correctly in a lot of cases and I need to fix them. I've just been busy on PTO
and only just got back today, and have been busy with fixing a lot of
On Thu, 2020-02-27 at 10:04 -0500, Mikita Lipski wrote:
>
> On 2/26/20 6:41 PM, Souza, Jose wrote:
> > Hi Hans
> >
> > Just commenting in the "[3.309061] [drm:intel_dump_pipe_config
> > [i915]] MST master transcoder: " message, it is the expected
> > behaviour for anything older than Tigerlak
Hi,
On 2/27/20 7:41 PM, Lyude Paul wrote:
hi - I almost certainly know the solution to this, the patches that we got
from amd to do bandwidth checking in the DP MST helpers don't actually work
correctly in a lot of cases and I need to fix them. I've just been busy on PTO
and only just got back t
== Series Details ==
Series: drm/i915: Set up PIPE_MISC truncate bit on tgl+
URL : https://patchwork.freedesktop.org/series/73960/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16719_full
Summary
== Series Details ==
Series: drm/i915/dram: hide the dram structs better
URL : https://patchwork.freedesktop.org/series/74025/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8020 -> Patchwork_16736
Summary
---
**SUCCE
On Thu, Feb 27, 2020 at 08:34:53PM +0200, Imre Deak wrote:
> On Thu, Feb 27, 2020 at 07:57:41PM +0200, Ville Syrjälä wrote:
> > On Wed, Feb 26, 2020 at 10:34:53PM +0200, Imre Deak wrote:
> > > Split out the PLL parameter->frequency conversion logic for each type of
> > > PLL for symmetry with their
From: Sean Paul
De-duplicate the HDCP version code and print it for all connectors.
Cc: Juston Li
Signed-off-by: Sean Paul
Changes in v4:
- Added to the set
---
.../drm/i915/display/intel_display_debugfs.c| 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git
Hi,
Thanks for the patch.
I reviewed and tested this patch, and everything looks fine.
Reviewed-by: Rodrigo Siqueira
Tested-by: Rodrigo Siqueira
On 02/27, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> v2: After drm_dev_init/drmm_add_final_kfree w
On Thu, Feb 27, 2020 at 08:13:29PM +0200, Ville Syrjälä wrote:
> On Wed, Feb 26, 2020 at 10:34:55PM +0200, Imre Deak wrote:
> > All platforms using the shared DPLL framework use 3 reference clocks for
> > their DPLLs: SSC, non-SSC and DSI. For a more unified way across
> > platforms store the frequ
Hi,
On 2/27/20 7:15 PM, Daniel Vetter wrote:
Instead of having a work item that never stops (which really should be
a kthread), with a dedicated workqueue to not upset anyone else, use a
delayed work. A bunch of changes:
- We can throw out all the custom wakeup and requeue logic and state
tr
Test-with: 20200127192859.20029-1-bob.j.paa...@intel.com
Stanislav Lisovskiy (1):
drm/i915: Adding YUV444 packed format support for skl+ (V15)
drivers/gpu/drm/i915/display/intel_display.c | 5 +
drivers/gpu/drm/i915/display/intel_sprite.c | 8
drivers/gpu/drm/i915/i915_reg.h
From: Stanislav Lisovskiy
PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification.
v2: Edited commit message, removed redundant whitespaces.
v3: Fixed fallthrough logic for the format switch cases.
v4: Yet again fixed fallthrough logic, to reuse code from other case
== Series Details ==
Series: drm/i915: Use intel_plane_data_rate for min_cdclk calculation (rev6)
URL : https://patchwork.freedesktop.org/series/73718/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8020 -> Patchwork_16737
S
== Series Details ==
Series: drm/i915/crc: move pipe_crc from drm_i915_private to intel_crtc
URL : https://patchwork.freedesktop.org/series/74031/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4a7fff1e2426 drm/i915/crc: move pipe_crc from drm_i915_private to intel_crtc
-:64: CH
From: Ville Syrjälä
gmbus/aux may be clocked by cdclk, thus we should make sure no
transfers are ongoing while the cdclk frequency is being changed.
We do that by simply grabbing all the gmbus/aux mutexes. No one
else should be holding any more than one of those at a time so
the lock ordering her
== Series Details ==
Series: 3 display pipes combination system support (rev5)
URL : https://patchwork.freedesktop.org/series/72468/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16721_full
Summary
--
== Series Details ==
Series: drm/i915/crc: move pipe_crc from drm_i915_private to intel_crtc
URL : https://patchwork.freedesktop.org/series/74031/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8020 -> Patchwork_16738
Summar
== Series Details ==
Series: drm/i915: Proper dbuf global state (rev3)
URL : https://patchwork.freedesktop.org/series/73421/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3643e15727b1 drm/i915: Handle some leftover s/intel_crtc/crtc/
c2f2161d6505 drm/i915: Remove garbage WARNs
== Series Details ==
Series: series starting with [1/3] drm/i915: Fix 400 MHz FSB readout on elk
URL : https://patchwork.freedesktop.org/series/73965/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16722_full
==
== Series Details ==
Series: drm/i915: Proper dbuf global state (rev3)
URL : https://patchwork.freedesktop.org/series/73421/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16739
Summary
---
**SUCCESS
As we drop the engine-pm on retiring, that may happen while there are
still CS events in the buffer. As such we cannot assert the engine is
still active on reset, until we know that the current request is still
in flight.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 7 ++
== Series Details ==
Series: series starting with [1/3] drm/i915: add i915_ioc32.h for compat
URL : https://patchwork.freedesktop.org/series/74033/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
663fbcd4dcd6 drm/i915: add i915_ioc32.h for compat
-:80: WARNING:FILE_PATH_CHANGES:
Hi Daniel.
Nicely written overview.
Acked-by: Sam Ravnborg
snip - detailed changelog + patch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Commit 60c6a14b489b ("drm/i915/display: Force the state compute phase
once to enable PSR") was forcing the state compute too earlier
causing errors because not everything was initialized, so here
moving to the end of i915_driver_modeset_probe() when the display is
all initialized.
Also fixing the
On Thu, Feb 27, 2020 at 07:14:36PM +0100, Daniel Vetter wrote:
> They all share mipi_dbi_release so we need to switch them all
> together. With this we can drop the final kfree from the release
> function.
>
> Aside, I think we could perhaps have a tiny additional helper for
> these mipi_dbi drive
On Thu, Feb 27, 2020 at 07:14:37PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> v2: We need drm_dev_put to unroll the driver creation (once
> drm_dev_init and drmm_add_final_kfree suceeded), otherwise
> the drmm_ magic doesn't happen.
>
> v3:
On Thu, Feb 27, 2020 at 07:14:40PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> I also noticed that cirrus forgot to call drm_dev_fini().
>
> v2: Don't call kfree(cirrus) after we've handed overship of that to
> drm_device and the drmm_ stuff.
On Thu, Feb 27, 2020 at 07:14:44PM +0100, Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> v2: After drm_dev_init/drmm_add_final_kfree we need to clean up
> everything through a drm_dev_put. Rework the unwind code to match
> that.
>
> Signed-off-by: Dani
== Series Details ==
Series: series starting with [1/3] drm/i915: add i915_ioc32.h for compat
URL : https://patchwork.freedesktop.org/series/74033/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16740
Summa
Hi all,
You might have read the short take in the X.org board meeting minutes
already, here's the long version.
The good news: gitlab.fd.o has become very popular with our
communities, and is used extensively. This especially includes all the
CI integration. Modern development process and tooling
== Series Details ==
Series: series starting with [1/3] drm/i915/gem: Consolidate ctx->engines[]
release
URL : https://patchwork.freedesktop.org/series/73966/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16723_full
=
== Series Details ==
Series: drm/i915: Fix kbuild test robot build error (rev2)
URL : https://patchwork.freedesktop.org/series/73990/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8021 -> Patchwork_16741
Summary
---
This will whitelist the HIZ_CHICKEN register so mesa can disable the
optimizations and avoid hang when using D16_UNORM.
v2: moved to the right place and used the right function() (Chris)
Cc: Matt Roper
Cc: Rafael Antognolli
Cc: Chris Wilson
Signed-off-by: José Roberto de Souza
---
drivers/gp
This issue workaround in Wa_1607063988 has the same fix as
Wa_1607138336, so just adding a note in the code.
Reviewed-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drive
Just to make easier to check that the Wa was implemetend when
comparing to the number in BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/dri
From: Anusha Srivatsa
According to BSpec. Wa_1606931601 applies for all TGL steppings.
This patch moves the WA implementation out of A0 only block of
rcs_engine_wa_init().
The WA is has also been referred to by an alternate name
Wa_1607090982.
Bspec: 46045, 52890
Fixes: 3873fd1a43c7 ("drm/i915
It is fixed in B0 stepping.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/intel_pm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 22aa205793e5..a101d8072b5b 100644
--- a/drivers/gp
From: Matt Atwood
Disable Push Constant buffer addition for TGL.
v2: typos, add additional Wa reference
v3: use REG_BIT macro, move to rcs_engine_wa_init, clean up commit
message.
Bspec: 52890
Cc: Rafael Antognolli
Cc: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: Matt Atwood
Signed-off
The Wa number for this fix is Wa_1607087056 the BSpec bug id is
1607087056, just updating to match BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/
Add note about the confliting information in BSpec about this WA.
BSpec: 52890
Acked-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_w
This will fix a memory coherence issue.
v3: using whitespace to make easy to read WA (Chris)
BSpec: 52890
Cc: Chris Wilson
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 8
drivers/gpu/drm/i915/i915_reg.h | 20 +++-
Different issues with the same fix, so justing adding
Wa_1409142259, Wa_1409252684, Wa_1409217633, Wa_1409207793,
Wa_1409178076 and 1408979724 to the comment so other devs can check if
this Was were implemetend with a simple grep.
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/
This workaround the CS not done issue on PIPE_CONTROL.
v2:
- replaced BIT() by REG_BIT() in all GEN7_ROW_CHICKEN2() bits
- shortened the name of the new bit
BSpec: 52890
BSpec: 46218
Cc: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: José Roberto de Souza
---
drivers/gpu/drm/i915/gt/intel_
With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with UACCESS
enabled
This means i915_gem_execbuffer2_ioctl() is calling gen8_canonical_addr()
-- and indirectl
Hi Chris,
On Thu, Feb 27, 2020 at 08:47:27PM +, Chris Wilson wrote:
> As we drop the engine-pm on retiring, that may happen while there are
> still CS events in the buffer. As such we cannot assert the engine is
> still active on reset, until we know that the current request is still
> in flig
Quoting Josh Poimboeuf (2020-02-27 22:08:26)
> With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
>
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with
> UACCESS enabled
>
> This means i915_gem_execbuffer
== Series Details ==
Series: drm/i915/ggtt: do not set bits 1-11 in gen12 ptes
URL : https://patchwork.freedesktop.org/series/73969/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8010_full -> Patchwork_16724_full
Summary
--
On 28/02/2020 00:01, José Roberto de Souza wrote:
Just to make easier to check that the Wa was implemetend when
comparing to the number in BSpec.
BSpec: 52890
Signed-off-by: José Roberto de Souza
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 1 +
1 file
Hi Cris,
> Attaching to the i915_active barrier is a two stage process, and a flush
> is only effective when the barrier is activation. Thus it is possible
> for us to see a barrier, and attempt to flush, only for our flush to
> have no effect. As such, before attempting to activate signaling on t
The following changes since commit efcfa03ae6100dfe523ebf612e03c3a90fc4c794:
linux-firmware: Update firmware file for Intel Bluetooth AX201 (2020-02-24
07:43:42 -0500)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware tgl_huc_7.0.12
for you to fetch cha
Update to the latest available TGL HuC, which includes changes required
by the media team.
Requested-by: Tony Ye
Signed-off-by: Daniele Ceraolo Spurio
Cc: Tony Ye
Cc: Michal Wajdeczko
Cc: Anusha Srivatsa
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 d
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e3a16eee86fc mm/sl[uo]b: export __kmalloc_track(_node)_caller
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: mm/sl[uo]b: export __kmalloc_track(_node)_caller
Okay!
Hi Chris,
On Thu, Feb 27, 2020 at 08:57:11AM +, Chris Wilson wrote:
> Still chasing the mystery of the stray idle flush, let's ensure that the
> heartbeat does not run at the same time as our test and confuse us.
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/541
> Signed-off
On Thu, Feb 27, 2020 at 04:08:26PM -0600, Josh Poimboeuf wrote:
> With CONFIG_CC_OPTIMIZE_FOR_SIZE, objtool reports:
>
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> i915_gem_execbuffer2_ioctl()+0x5b7: call to gen8_canonical_addr() with
> UACCESS enabled
>
> This means
On Tue, Jan 07, 2020 at 06:36:55PM +0200, Ville Syrjälä wrote:
On Mon, Dec 23, 2019 at 12:59:55PM -0800, Lucas De Marchi wrote:
On Fri, Dec 20, 2019 at 10:11:15PM +, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-12-20 22:06:50)
>> According to intel_detect_preproduction_hw(), the SKL st
On Fri, Feb 14, 2020 at 04:27:51AM -0800, Aditya Swarup wrote:
> Add definitions for registers grouped under Transcoder VRR function
> with necessary bitfields.
>
> Bspec: 49268
>
> v2: Use REG_GENMASK, correct tabs/space indentation and move the
> definitions near the transcoder section.(Jani)
>
== Series Details ==
Series: drm managed resources, v3
URL : https://patchwork.freedesktop.org/series/74035/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8022 -> Patchwork_16742
Summary
---
**SUCCESS**
No regress
101 - 200 of 259 matches
Mail list logo
