[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1606054188;tgl

2020-01-20 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add Wa_1606054188;tgl URL : https://patchwork.freedesktop.org/series/72148/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16140_full Summary --- **SUC

[Intel-gfx] [PATCH v3 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

2020-01-20 Thread Thomas Zimmermann
The callback get_vblank_timestamp() is currently located in struct drm_driver, but really belongs into struct drm_crtc_funcs. Add an equivalent there. Driver will be converted in separate patches. The default implementation is drm_calc_vbltimestamp_from_scanoutpos(). The patch adds drm_crtc_vblank

[Intel-gfx] [PATCH v3 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert amdgpu over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12 drivers/gpu/drm/amd/amdgpu/amdgpu_dr

[Intel-gfx] [PATCH v3 07/22] drm/i915: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert i915 over. The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). i915 doesn't use CRTC helpers. Instea

[Intel-gfx] [PATCH v3 01/22] drm: Remove internal setup of struct drm_device.vblank_disable_immediate

2020-01-20 Thread Thomas Zimmermann
VBLANK interrupts can be disabled immediately or with a delay, where the latter is the default. The former option can be selected by setting get_vblank_timestamp and enabling vblank_disable_immediate in struct drm_device. Simplify the code in preparation of the removal of struct drm_device.get_vbla

[Intel-gfx] [PATCH v3 02/22] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

2020-01-20 Thread Thomas Zimmermann
The new callback get_scanout_position() reads the current location of the scanout process. The operation is currently located in struct drm_driver, but really belongs to the CRTC. Drivers will be converted in separate patches. To help with the conversion, the timestamp calculation has been moved f

[Intel-gfx] [PATCH v3 12/22] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert mem over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++ drivers/gpu/drm/msm/disp/mdp5/mdp5_k

[Intel-gfx] [PATCH v3 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 65 ++

[Intel-gfx] [PATCH v3 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert nouveau over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 + driv

[Intel-gfx] [PATCH v3 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert amdgpu over. v2: * don't wrap existing functions; change signature instead Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++---

[Intel-gfx] [PATCH v3 11/22] drm/radeon: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert radeon over. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 12 -- drivers/gpu/drm/radeon/radeon_drv.c | 7

[Intel-gfx] [PATCH v3 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert nouvean over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++ drivers/gpu/drm/nouveau/dispnv50/head.c | 4 drivers/gpu/drm/nouveau

[Intel-gfx] [PATCH v3 00/22] drm: Clean up VBLANK callbacks in struct drm_driver

2020-01-20 Thread Thomas Zimmermann
VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm

[Intel-gfx] [PATCH v3 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert radeon over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 13

[Intel-gfx] [PATCH v3 13/22] drm/msm: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2 ++ dri

[Intel-gfx] [PATCH v3 19/22] drm/vkms: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms/vk

[Intel-gfx] [PATCH v3 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver

2020-01-20 Thread Thomas Zimmermann
All non-legacy users of VBLANK functions in struct drm_driver have been converted to use the respective interfaces in struct drm_crtc_funcs. The remaining users of VBLANK callbacks in struct drm_driver are legacy drivers with userspace modesetting. All users of struct drm_driver.get_scanout_positi

[Intel-gfx] [PATCH v3 18/22] drm/vc4: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff -

[Intel-gfx] [PATCH v3 16/22] drm/sti: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c |

[Intel-gfx] [PATCH v3 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv

[Intel-gfx] [PATCH v3 22/22] drm: Remove legacy version of get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The legacy version of get_scanout_position() was only useful while drivers still used drm_driver.get_scanout_position(). With no such drivers left, the related typedef and code can be removed Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vblank.c| 27 +++ d

[Intel-gfx] [PATCH v3 06/22] drm/gma500: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert gma500 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.c | 4 drivers/gpu/drm/gma500

[Intel-gfx] [PATCH v3 15/22] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Zimmermann
VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[Intel-gfx] [PATCH v3 17/22] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-20 Thread Thomas Zimmermann
The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++- drivers/gpu/drm/vc4/vc4_drv.c | 1 - drivers/gpu/drm/vc4

Re: [Intel-gfx] [PATCH v13 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-20 Thread Lisovskiy, Stanislav
On Fri, 2020-01-17 at 11:06 -0800, Matt Roper wrote: > On Fri, Jan 17, 2020 at 11:50:25AM +0200, Stanislav Lisovskiy wrote: > > Start manipulating DBuf slices as a mask, > > but not as a total number, as current approach > > doesn't give us full control on all combinations > > of slices, which we m

[Intel-gfx] [PATCH 1/1] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DD

[Intel-gfx] [PATCH 0/1] HDCP state updation as per kernel internal state

2020-01-20 Thread Anshuman Gupta
Test-with: <20200120085158.9151-2-anshuman.gu...@intel.com> Anshuman Gupta (1): drm/i915/hdcp: Update CP as per the kernel internal state drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++ drivers/gpu/drm/i915/display/intel_hdcp.c | 13 - 2 files changed, 18 i

[Intel-gfx] ✓ Fi.CI.IGT: success for Security mitigation for Intel Gen7 HWs (rev3)

2020-01-20 Thread Patchwork
== Series Details == Series: Security mitigation for Intel Gen7 HWs (rev3) URL : https://patchwork.freedesktop.org/series/72028/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16141_full Summary --

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Update for preempt-to-busy, heartbeats and timeslicing

2020-01-20 Thread Tvrtko Ursulin
On 17/01/2020 20:58, Ye, Tony wrote: Failed on parsing the trace log: Died at ./trace.pl line 296. Raw data attached. I need to add better error messages - that line is command line argument handling. I have dropped "-s" from this version in favour of always trying to track ELSP port oc

Re: [Intel-gfx] [RFC PATCH v3 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts

2020-01-20 Thread Chris Wilson
Quoting Akeem G Abodunrin (2020-01-16 17:46:55) > +static u32 > +gen7_fill_interface_descriptor(struct batch_chunk *state, > + const struct batch_vals *bv, > + const struct cb_kernel *kernel, > + unsigned int cou

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Jani Nikula
On Mon, 20 Jan 2020, Anshuman Gupta wrote: > Content Protection property should be updated as per the kernel > internal state. Let's say if Content protection is disabled > by userspace, CP property should be set to UNDESIRED so that > reauthentication will not happen until userspace request it ag

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Jani Nikula
On Mon, 20 Jan 2020, Ramalingam C wrote: > On 2020-01-20 at 11:19:54 +0530, Anshuman Gupta wrote: >> Content Protection property should be updated as per the kernel >> internal state. Let's say if Content protection is disabled >> by userspace, CP property should be set to UNDESIRED so that >> rea

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)

2020-01-20 Thread Patchwork
== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev8) URL : https://patchwork.freedesktop.org/series/71873/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9ff81bf712fd drm: Remove internal setup of struct drm_device.vblank_disable_immediate c83

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/mst: Don't do atomic checks over disabled managers

2020-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/mst: Don't do atomic checks over disabled managers URL : https://patchwork.freedesktop.org/series/72152/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16142_full ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)

2020-01-20 Thread Patchwork
== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev8) URL : https://patchwork.freedesktop.org/series/71873/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm: Remove internal setup of struct drm_device.vblank_disable_

[Intel-gfx] [PATCH 4/5] drm/i915/gem: Convert vm idr to xarray

2020-01-20 Thread Chris Wilson
Replace the vm_idr + vm_idr_mutex to an XArray. The XArray data structure is now used to implement IDRs, and provides its won locking. We can simply remove the IDR wrapper and in the process also remove our extra mutex. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH 5/5] drm/i915/display: Squelch kerneldoc complaints

2020-01-20 Thread Chris Wilson
drivers/gpu/drm/i915/display/intel_atomic.c:185: warning: Function parameter or member 'state' not described in 'intel_connector_needs_modeset' drivers/gpu/drm/i915/display/intel_atomic.c:185: warning: Function parameter or member 'connector' not described in 'intel_connector_needs_modeset' driv

[Intel-gfx] [PATCH 3/5] drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list

2020-01-20 Thread Chris Wilson
Currently we create a new mmap_offset for every call to mmap_offset_ioctl. This exposes ourselves to an abusive client that may simply create new mmap_offsets ad infinitum, which will exhaust physical memory and the virtual address space. In addition to the exhaustion, a very long linear list of mm

[Intel-gfx] [PATCH 2/5] drm/i915: Tighten atomicity of i915_active_acquire vs i915_active_release

2020-01-20 Thread Chris Wilson
As we use a mutex to serialise the first acquire (as it may be a lengthy operation), but only an atomic decrement for the release, we have to be careful in case a second thread races and completes both acquire/release as the first finishes its acquire. Fixes: c9ad602feabe ("drm/i915: Split i915_ac

[Intel-gfx] [PATCH 1/5] drm/i915/gt: Acquire ce->active before ce->pin_count/ce->pin_mutex

2020-01-20 Thread Chris Wilson
<0> [198.668822] gem_exec-12460 193899010us : timeline_advance: timeline_advance:387 GEM_BUG_ON(!atomic_read(&tl->pin_count)) <0> [198.668859] - <4> [198.669619] [ cut here ] <2> [198.669621] kernel BUG at drivers/gpu/drm/i915/gt/inte

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Check require bandwidth did not exceed LSPCON limitation

2020-01-20 Thread Patchwork
== Series Details == Series: drm/i915: Check require bandwidth did not exceed LSPCON limitation URL : https://patchwork.freedesktop.org/series/72157/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16143_full ===

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Ramalingam C
On 2020-01-20 at 12:29:36 +0200, Jani Nikula wrote: > On Mon, 20 Jan 2020, Ramalingam C wrote: > > On 2020-01-20 at 11:19:54 +0530, Anshuman Gupta wrote: > >> Content Protection property should be updated as per the kernel > >> internal state. Let's say if Content protection is disabled > >> by us

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_mmap_offset: Exercise many, many mmap_offset

2020-01-20 Thread Abdiel Janulgue
On 17/01/2020 23.11, Chris Wilson wrote: > Just keep on generating a new mmap_offset for the same old buffer, but > for different handles and so exercise the scaling of the obj->mmo lists. > Reviewed-by: Abdiel Janulgue > Signed-off-by: Chris Wilson > Cc: Abdiel Janulgue __

[Intel-gfx] [PATCH v5 0/10] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-01-20 Thread Alexey Budankov
Currently access to perf_events, i915_perf and other performance monitoring and observability subsystems of the kernel is open for a privileged process [1] with CAP_SYS_ADMIN capability enabled in the process effective set [2]. This patch set introduces CAP_PERFMON capability designed to secure

[Intel-gfx] [PATCH v5 01/10] capabilities: introduce CAP_PERFMON to kernel and user space

2020-01-20 Thread Alexey Budankov
Introduce CAP_PERFMON capability designed to secure system performance monitoring and observability operations so that CAP_PERFMON would assist CAP_SYS_ADMIN capability in its governing role for perf_events, i915_perf and other performance monitoring and observability subsystems. CAP_PERFMON int

[Intel-gfx] [PATCH v5 02/10] perf/core: open access to the core for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to monitoring of kernel code, system, tracepoints and namespaces data for a CAP_PERFMON privileged process. For backward compatibility reasons access to perf_events subsystem remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure perf_events monitoring

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Jani Nikula
On Mon, 20 Jan 2020, Ramalingam C wrote: > On 2020-01-20 at 12:29:36 +0200, Jani Nikula wrote: >> On Mon, 20 Jan 2020, Ramalingam C wrote: >> > On 2020-01-20 at 11:19:54 +0530, Anshuman Gupta wrote: >> >> Content Protection property should be updated as per the kernel >> >> internal state. Let's

[Intel-gfx] [PATCH v5 03/10] perf/core: open access to anon probes for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to anon kprobes, uprobes and eBPF tracing for CAP_PERFMON privileged processes. For backward compatibility reasons access remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Providing

[Intel-gfx] [PATCH v5 04/10] perf tool: extend Perf tool with CAP_PERFMON capability support

2020-01-20 Thread Alexey Budankov
Extend error messages to mention CAP_PERFMON capability as an option to substitute CAP_SYS_ADMIN capability for secure system performance monitoring and observability operations. Make perf_event_paranoid_check() and __cmd_ftrace() to be aware of CAP_PERFMON capability. Signed-off-by: Alexey Buda

[Intel-gfx] [PATCH v5 05/10] drm/i915/perf: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to i915_perf monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to i915_perf subsystem remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure i915_perf monitoring is discouraged with respect to CAP_PERFMON capabil

[Intel-gfx] [PATCH v14 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-20 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. v3: Chang

[Intel-gfx] [PATCH v14 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-20 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v14 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-20 Thread Stanislav Lisovskiy
Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather

[Intel-gfx] [PATCH v14 0/5] Enable second DBuf slice for ICL and TGL

2020-01-20 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915: Mo

[Intel-gfx] [PATCH v14 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-20 Thread Stanislav Lisovskiy
Current DBuf slices update wasn't done in proper place, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch) v3: Rename

[Intel-gfx] [PATCH v14 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-20 Thread Stanislav Lisovskiy
Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv v4: Renamed "enabled_s

[Intel-gfx] [PATCH v5 06/10] trace/bpf_trace: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to bpf_trace monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to bpf_trace monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure bpf_trace monitoring is discouraged with respect to CAP_PERFMON capabi

[Intel-gfx] ✓ Fi.CI.IGT: success for Misc GuC CT improvements - part II (rev2)

2020-01-20 Thread Patchwork
== Series Details == Series: Misc GuC CT improvements - part II (rev2) URL : https://patchwork.freedesktop.org/series/72071/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16144_full Summary ---

[Intel-gfx] [PATCH v5 07/10] powerpc/perf: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Providing the access

[Intel-gfx] [PATCH v5 08/10] parisc/perf: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Providing the access

[Intel-gfx] [PATCH v5 09/10] drivers/perf: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Providing the access

[Intel-gfx] [PATCH v5 10/10] drivers/oprofile: open access for CAP_PERFMON privileged process

2020-01-20 Thread Alexey Budankov
Open access to monitoring for CAP_PERFMON privileged processes. For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Providing the access

[Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

2020-01-20 Thread Chris Wilson
Only a couple of tests from gem_ctx_switch are run in BAT, to check we have multiple contexts on RCS. It doesn't actually verify the switch, just that the execbuf API accepts the context argument. This test is redundant as actual context switching (and more) is verified by live_gem_contexts and li

[Intel-gfx] [PATCH i-g-t 2/3] intel-ci: Reduce variety of gem_sync in BAT

2020-01-20 Thread Chris Wilson
Historically, we've had many problems with missed interrupt/seqno syndrome and so have focus on testing with gem_sync. However, these tests rely on the kernel itself reporting the issue which it no longer does. So why the extra variety may impose different timing of execution on the HW (and so diff

[Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Use one ringfull example

2020-01-20 Thread Chris Wilson
The principle under test is that we fill the ring and the kernel waits rather than overrun the ring buffer. We only need one test to exercise that basic behaviour in BAT. Signed-off-by: Chris Wilson --- tests/intel-ci/fast-feedback.testlist | 3 --- 1 file changed, 3 deletions(-) diff --git a/t

[Intel-gfx] [PATCH v14 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-20 Thread Stanislav Lisovskiy
Current DBuf slices update wasn't done in proper place, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch) v3: Rename

[Intel-gfx] [PATCH v14 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-20 Thread Stanislav Lisovskiy
Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv v4: Renamed "enabled_s

[Intel-gfx] [PATCH v14 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-20 Thread Stanislav Lisovskiy
Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather

[Intel-gfx] [PATCH v14 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-20 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. v3: Chang

[Intel-gfx] [PATCH v14 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-20 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v14 0/5] Enable second DBuf slice for ICL and TGL

2020-01-20 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915: Mo

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable second DBuf slice for ICL and TGL (rev17)

2020-01-20 Thread Patchwork
== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev17) URL : https://patchwork.freedesktop.org/series/70059/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16145_full Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Ramalingam C
On 2020-01-20 at 13:24:05 +0200, Jani Nikula wrote: > On Mon, 20 Jan 2020, Ramalingam C wrote: > > On 2020-01-20 at 12:29:36 +0200, Jani Nikula wrote: > >> On Mon, 20 Jan 2020, Ramalingam C wrote: > >> > On 2020-01-20 at 11:19:54 +0530, Anshuman Gupta wrote: > >> >> Content Protection property sh

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix typo in kerneldoc function name

2020-01-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix typo in kerneldoc function name URL : https://patchwork.freedesktop.org/series/72180/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16147_full Summary --

Re: [Intel-gfx] [PATCH v3 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Thomas Hellstrom
On 1/20/20 9:23 AM, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. > > v2: > * remove accidental whitespace fixes > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/vmwg

[Intel-gfx] [PATCH v15 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-20 Thread Stanislav Lisovskiy
Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather

[Intel-gfx] [PATCH v15 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-20 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. v3: Chang

[Intel-gfx] [PATCH v15 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-20 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v15 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-20 Thread Stanislav Lisovskiy
Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv v4: Renamed "enabled_s

[Intel-gfx] [PATCH v15 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-20 Thread Stanislav Lisovskiy
Current DBuf slices update wasn't done in proper place, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch) v3: Rename

[Intel-gfx] [PATCH v15 0/5] Enable second DBuf slice for ICL and TGL

2020-01-20 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915: Mo

Re: [Intel-gfx] [PATCH v3 06/22] drm/gma500: Convert to CRTC VBLANK callbacks

2020-01-20 Thread Patrik Jakobsson
On Mon, Jan 20, 2020 at 9:23 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert gma500 over. > > Signed-off-by: Thomas Zimmermann Looks good. For this patch: Acked-by: Patrik Jakobsson > --- >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)

2020-01-20 Thread Patchwork
== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev8) URL : https://patchwork.freedesktop.org/series/71873/ State : failure == Summary == CI Bug Log - changes from CI_DRM_ -> Patchwork_16170 Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state

2020-01-20 Thread Jani Nikula
On Mon, 20 Jan 2020, Ramalingam C wrote: > hdcp->value is used to track the internal transistions during the link > failure and re-establishing it. When ever kernel want to update the > "content protection" we take the required locks and update the property > state along with uevent. My point is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include the debugfs params header for its own definition

2020-01-20 Thread Patchwork
== Series Details == Series: drm/i915: Include the debugfs params header for its own definition URL : https://patchwork.freedesktop.org/series/72181/ State : success == Summary == CI Bug Log - changes from CI_DRM_7760_full -> Patchwork_16148_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Only retire requests when eviction is allowed to blocked

2020-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Only retire requests when eviction is allowed to blocked URL : https://patchwork.freedesktop.org/series/72184/ State : success == Summary == CI Bug Log - changes from CI_DRM_7761_full -> Patchwork_16151_full ===

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

2020-01-20 Thread Mika Kuoppala
Chris Wilson writes: > Only a couple of tests from gem_ctx_switch are run in BAT, to check we > have multiple contexts on RCS. It doesn't actually verify the switch, > just that the execbuf API accepts the context argument. > > This test is redundant as actual context switching (and more) is veri

Re: [Intel-gfx] [RFC 7/7] drm/i915/dp: Program vswing, pre-emphasis, test-pattern

2020-01-20 Thread Manna, Animesh
On 15-01-2020 03:08, Manasi Navare wrote: On Fri, Dec 13, 2019 at 10:54:20PM +0530, Animesh Manna wrote: Hi Manasi/Jani, Thanks for helping phy compliance design. Added my understanding/doubts below. On 12/12/2019 5:20 AM, Manasi Navare wrote: Hi Animesh/Jani, Is this the right way to forc

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Use one ringfull example

2020-01-20 Thread Mika Kuoppala
Chris Wilson writes: > The principle under test is that we fill the ring and the kernel waits > rather than overrun the ring buffer. We only need one test to exercise > that basic behaviour in BAT. > > Signed-off-by: Chris Wilson Acked-by: Mika Kuoppala > --- > tests/intel-ci/fast-feedback.t

Re: [Intel-gfx] [PATCH i-g-t 2/3] intel-ci: Reduce variety of gem_sync in BAT

2020-01-20 Thread Mika Kuoppala
Chris Wilson writes: > Historically, we've had many problems with missed interrupt/seqno > syndrome and so have focus on testing with gem_sync. However, these > tests rely on the kernel itself reporting the issue which it no longer > does. So why the extra variety may impose different timing of e

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

2020-01-20 Thread Chris Wilson
Quoting Mika Kuoppala (2020-01-20 13:50:46) > Chris Wilson writes: > > > Only a couple of tests from gem_ctx_switch are run in BAT, to check we > > have multiple contexts on RCS. It doesn't actually verify the switch, > > just that the execbuf API accepts the context argument. > > > > This test i

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

2020-01-20 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2020-01-20 13:50:46) >> Chris Wilson writes: >> >> > Only a couple of tests from gem_ctx_switch are run in BAT, to check we >> > have multiple contexts on RCS. It doesn't actually verify the switch, >> > just that the execbuf API accepts the context

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Report the currently active execlists request (rev2)

2020-01-20 Thread Patchwork
== Series Details == Series: drm/i915/gt: Report the currently active execlists request (rev2) URL : https://patchwork.freedesktop.org/series/72179/ State : success == Summary == CI Bug Log - changes from CI_DRM_7762_full -> Patchwork_16152_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/gt: Acquire ce->active before ce->pin_count/ce->pin_mutex

2020-01-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Acquire ce->active before ce->pin_count/ce->pin_mutex URL : https://patchwork.freedesktop.org/series/72269/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6cbb3c0bda69 drm/i915/gt: Acquire ce->active before ce

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/2] drm/i915/userptr: add user_size limit check

2020-01-20 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/userptr: add user_size limit check URL : https://patchwork.freedesktop.org/series/72186/ State : success == Summary == CI Bug Log - changes from CI_DRM_7764_full -> Patchwork_16154_full ===

Re: [Intel-gfx] [PATCH 3/5] drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list

2020-01-20 Thread Abdiel Janulgue
On 20/01/2020 12.49, Chris Wilson wrote: > Currently we create a new mmap_offset for every call to > mmap_offset_ioctl. This exposes ourselves to an abusive client that may > simply create new mmap_offsets ad infinitum, which will exhaust physical > memory and the virtual address space. In additi

Re: [Intel-gfx] [PATCH v3 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

2020-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2020 at 09:22:55AM +0100, Thomas Zimmermann wrote: > The callback get_vblank_timestamp() is currently located in struct > drm_driver, but really belongs into struct drm_crtc_funcs. Add an > equivalent there. Driver will be converted in separate patches. > > The default implementati

Re: [Intel-gfx] [PATCH v3 22/22] drm: Remove legacy version of get_scanout_position()

2020-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2020 at 09:23:14AM +0100, Thomas Zimmermann wrote: > The legacy version of get_scanout_position() was only useful while > drivers still used drm_driver.get_scanout_position(). With no such > drivers left, the related typedef and code can be removed > > Signed-off-by: Thomas Zimmerm

[Intel-gfx] [PATCH libdrm] intel: drm_intel_bo_gem_create_from_* on platforms w/o HW tiling

2020-01-20 Thread Imre Deak
Platforms without a HW detiler doesn't support the get_tiling IOCTL. Fix the drm_intel_bo_gem_create_from_* functions assuming the default no-tiling, no-swizzling setting for the GEM buffer in this case. Signed-off-by: Imre Deak --- intel/intel_bufmgr_gem.c | 42 +

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-01-20 Thread Patchwork
== Series Details == Series: Introduce CAP_PERFMON to secure system performance monitoring and observability URL : https://patchwork.freedesktop.org/series/72273/ State : warning == Summary == $ dim checkpatch origin/drm-tip 08ee25620fef capabilities: introduce CAP_PERFMON to kernel and user

  1   2   >