Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel

On Tue, 14 Jan 2020, Lyude Paul wrote: > fwiw - I got some feedback from one of the vendors that we work with that I > haven't gone through yet, but I'm hoping to figure out whether we want to > trust the vbt/dpcd based off that once I do. Once we've made up the decision > on that (and I send out

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Allow temporary suspension of inflight requests

In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary user-controlled amount of time, we want to let the engine

[Intel-gfx] [PATCH 1/3] drm/i915: Use common priotree lists for virtual engine

Since commit 422d7df4f090 ("drm/i915: Replace engine->timeline with a plain list"), we used the default embedded priotree slot for the virtual engine request queue, which means we can also use the same solitary slot with the scheduler. However, the priolist is expected to be guarded by the engine->

[Intel-gfx] [PATCH 3/3] drm/i915/execlists: Offline error capture

Currently, we skip error capture upon forced preemption. We apply forced preemption when there is a higher priority request that should be running but is being blocked, and we skip inline error capture so that the preemption request is not further delayed by a user controlled capture -- extending t

Re: [Intel-gfx] [PATCH 0/7] Commit early to GuC

Quoting Daniele Ceraolo Spurio (2020-01-15 01:31:36) > We currently wait until we attempt to load the GuC to confirm if we're > in GuC mode or not, at which point a lot of the engine setup has already > happened and needs to be updated for GuC submission. To allow us to get > the setup done directl

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Lookup the i2c bus from ACPI NS only if CONFIG_ACPI=y (v2)

On Tue, 14 Jan 2020, Vivek Kasireddy wrote: > Perform the i2c bus/adapter lookup from ACPI Namespace only if > ACPI is enabled in the kernel config. If ACPI is not enabled or if > the lookup fails, we'll fallback to using the VBT for identiying > the i2c bus. > > This patch > Fixes: 8cbf89db2941 (

[Intel-gfx] [PATCH v2] drm/i915: Keep track of request among the scheduling lists

If we keep track of when the i915_request.sched.link is on the HW runlist, or in the priority queue we can simplify our interactions with the request (such as during rescheduling). This also simplifies the next patch where we introduce a new in-between list, for requests that are ready but neither

Re: [Intel-gfx] [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

On Mon, 06 Jan 2020, "Manna, Animesh" wrote: > Sure Manasi, I will make intel_get_adjust_train() non-static and keep in > intel_dp_link_training.c. > Now as suggested by Jani before > (https://patchwork.freedesktop.org/patch/345823/?series=71121&rev=1#comment_640087) > other non static function

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Add Wa_1409825376 to tgl (rev2)

== Series Details == Series: drm/i915/tgl: Add Wa_1409825376 to tgl (rev2) URL : https://patchwork.freedesktop.org/series/71853/ State : success == Summary == CI Bug Log - changes from CI_DRM_7714_full -> Patchwork_16046_full Summary --

Re: [Intel-gfx] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

Hi Am 13.01.20 um 19:52 schrieb Alex Deucher: > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: >> >> The callback struct drm_driver.get_scanout_position() is deprecated in >> favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert >> amdgpu over. >> > > I would prefer to

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2)

== Series Details == Series: series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2) URL : https://patchwork.freedesktop.org/series/72048/ State : warning == Summary == $ dim checkpatch origin/drm-tip 201e1a96d586 drm/i915: Keep track of request among the s

[Intel-gfx] [PATCH v11 0/5] Enable second DBuf slice for ICL and TGL

Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915: Mo

[Intel-gfx] [PATCH v11 3/5] drm/i915: Manipulate DBuf slices properly

Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v11 1/5] drm/i915: Remove skl_ddl_allocation struct

Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. v3: Chang

[Intel-gfx] [PATCH v11 2/5] drm/i915: Move dbuf slice update to proper place

Current DBuf slices update wasn't done in proper place, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch) v3: Rename

[Intel-gfx] [PATCH v11 5/5] drm/i915: Correctly map DBUF slices to pipes

Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv v4: Renamed "enabled_s

[Intel-gfx] [PATCH v11 4/5] drm/i915: Introduce parameterized DBUF_CTL

Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather

Re: [Intel-gfx] [ [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros

On Wed, 15 Jan 2020, Pankaj Bharadiya wrote: > Add new struct drm_device based WARN* macros. These are modeled after > the core kernel device based WARN* macros. These would be preferred > over the regular WARN* macros, where possible. > > These macros include device information in the backtrace,

Re: [Intel-gfx] [PATCH 2/2] drm/i915/params: support bool values for int and uint params

Quoting Jani Nikula (2019-12-05 15:43:41) > It's not uncommon for us to switch param types between bools and ints, > often having otherwise bool semantics but -1 value for platform > default. Allow bool values (such as YyNn) for ints. > > Signed-off-by: Jani Nikula Reviewed-by: Chris Wilson Bu

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

Quoting Jani Nikula (2019-12-05 15:43:40) > Add a debugfs subdirectory i915_params with all the i915 module > parameters. This is a first step, with lots of boilerplate, and not much > benefit yet. Right, creates a mirror [more or less] of /sys/module/i915/parameters. I probably would have used pa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2)

== Series Details == Series: series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2) URL : https://patchwork.freedesktop.org/series/72048/ State : success == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16106 ===

[Intel-gfx] ✗ Fi.CI.BUILD: warning for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2)

== Series Details == Series: series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev2) URL : https://patchwork.freedesktop.org/series/72048/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK inc

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable second DBuf slice for ICL and TGL (rev13)

== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev13) URL : https://patchwork.freedesktop.org/series/70059/ State : warning == Summary == $ dim checkpatch origin/drm-tip 091637515149 drm/i915: Remove skl_ddl_allocation struct 9c02bbfc80f8 drm/i915: Move dbuf slice updat

[Intel-gfx] ✗ Fi.CI.BUILD: warning for Enable second DBuf slice for ICL and TGL (rev13)

== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev13) URL : https://patchwork.freedesktop.org/series/70059/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/bo

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable second DBuf slice for ICL and TGL (rev13)

== Series Details == Series: Enable second DBuf slice for ICL and TGL (rev13) URL : https://patchwork.freedesktop.org/series/70059/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16107 Summary --- **

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

On Wed, 15 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2019-12-05 15:43:40) >> Add a debugfs subdirectory i915_params with all the i915 module >> parameters. This is a first step, with lots of boilerplate, and not much >> benefit yet. > > Right, creates a mirror [more or less] of /sys/mod

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Allow temporary suspension of inflight requests

On 15/01/2020 08:33, Chris Wilson wrote: In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary user-controll

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Allow temporary suspension of inflight requests

Quoting Tvrtko Ursulin (2020-01-15 10:58:39) > > On 15/01/2020 08:33, Chris Wilson wrote: > > +static bool hold_request(const struct i915_request *rq) > > +{ > > + struct i915_dependency *p; > > + > > + /* > > + * If one of our ancestors is still on hold, we must also still be on > >

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/prime_vgem: Examine blitter access path

Hi Chris, Thanks for your review. On Thursday, January 9, 2020 4:03:30 PM CET Chris Wilson wrote: > Quoting Janusz Krzysztofik (2020-01-09 14:01:25) > > On future hardware with missing GGTT BAR we won't be able to exercise > > dma-buf access via that path. An alternative to basic-gtt subtest for

[Intel-gfx] [PATCH v3] drm/i915/gt: Allow temporary suspension of inflight requests

In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary user-controlled amount of time, we want to let the engine

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/intel_batchbuffer: Add blitter copy using XY_SRC_COPY_BLT

Hi Chris, On Thursday, January 9, 2020 3:43:55 PM CET Chris Wilson wrote: > Quoting Janusz Krzysztofik (2020-01-09 14:01:24) > > From: Vanshidhar Konda > > > > Add a method that uses the XY_SRC_COPY_BLT instruction for copying > > buffers using the blitter engine. > > > > v2: Use uint32_t for p

Re: [Intel-gfx] [PATCH v3] drm/i915/gt: Allow temporary suspension of inflight requests

On 15/01/2020 11:10, Chris Wilson wrote: In order to support out-of-line error capture, we need to remove the active request from HW and put it to one side while a worker compresses and stores all the details associated with that request. (As that compression may take an arbitrary user-controll

Re: [Intel-gfx] [PATCH v3] drm/i915/gt: Allow temporary suspension of inflight requests

Quoting Tvrtko Ursulin (2020-01-15 11:37:23) > > On 15/01/2020 11:10, Chris Wilson wrote: > > In order to support out-of-line error capture, we need to remove the > > active request from HW and put it to one side while a worker compresses > > and stores all the details associated with that request

[Intel-gfx] [PATCH v2 03/21] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

The callback get_vblank_timestamp() is currently located in struct drm_driver, but really belongs into struct drm_crtc_funcs. Add an equivalent there. Driver will be converted in separate patches. The default implementation is drm_calc_vbltimestamp_from_scanoutpos(). The patch adds drm_crtc_vblank

[Intel-gfx] [PATCH v2 05/21] drm/amdgpu: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert amdgpu over. v2: * don't wrap existing functions; change signature instead Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++---

[Intel-gfx] [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert i915 over. The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). i915 doesn't use CRTC helpers. Instea

[Intel-gfx] [PATCH v2 02/21] drm: Evaluate struct drm_device.vblank_disable_immediate on each use

VBLANK interrupts can be disabled immediately or with a delay, where the latter is the default. The former option can be selected by setting get_vblank_timestamp, and enabling vblank_disable_immediate in struct drm_device. The setup is only evaluated once when DRM initializes VBLANKs. Evaluating t

[Intel-gfx] [PATCH v2 08/21] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert nouveau over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1 + driv

[Intel-gfx] [PATCH v2 17/21] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++- drivers/gpu/drm/vc4/vc4_drv.c | 1 - drivers/gpu/drm/vc4

[Intel-gfx] [PATCH v2 01/21] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

The new callback get_scanout_position() reads the current location of the scanout process. The operation is currentyl located in struct drm_driver, but really belongs to the CRTC. Drivers will be converted in separate patches. v2: * fix logical op in drm_calc_vbltimestamp_from_scanoutpos()

[Intel-gfx] [PATCH v2 04/21] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert amdgpu over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12 drivers/gpu/drm/amd/amdgpu/amdgpu_dr

[Intel-gfx] [PATCH v2 00/21] drm: Clean up VBLANK callbacks in struct drm_driver

VBLANK handlers in struct drm_driver are deprecated. Only legacy, non-KMS drivers are supposed to used them. DRM drivers with kernel modesetting are supposed to use VBLANK callbacks of the CRTC infrastructure. This patchset converts all DRM drivers to CRTC VBLANK callbacks and cleans up struct drm

[Intel-gfx] [PATCH v2 14/21] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 65 ++

[Intel-gfx] [PATCH v2 09/21] drm/nouveau: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert nouvean over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++ drivers/gpu/drm/nouveau/dispnv50/head.c | 4 drivers/gpu/drm/nouveau

[Intel-gfx] [PATCH v2 11/21] drm/radeon: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert radeon over. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 12 -- drivers/gpu/drm/radeon/radeon_drv.c | 7

[Intel-gfx] [PATCH v2 06/21] drm/gma500: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert gma500 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.c | 4 drivers/gpu/drm/gma500

[Intel-gfx] [PATCH v2 10/21] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert radeon over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 13

[Intel-gfx] [PATCH v2 12/21] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert mem over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++ drivers/gpu/drm/msm/disp/mdp5/mdp5_k

[Intel-gfx] [PATCH v2 19/21] drm/vkms: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms/vkms_drv.c | 1 - drivers/gpu/drm/vkms/vkms_drv.h | 4

[Intel-gfx] [PATCH v2 21/21] drm: Clean-up VBLANK-related callbacks in struct drm_driver

All non-legacy users of VBLANK functions in struct drm_driver have been converted to use the respective interfaces in struct drm_crtc_funcs. The remaining users of VBLANK callbacks in struct drm_driver are legacy drivers with userspace modesetting. All users of struct drm_driver.get_scanout_positi

[Intel-gfx] [PATCH v2 13/21] drm/msm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2 ++ dri

[Intel-gfx] [PATCH v2 16/21] drm/sti: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c |

[Intel-gfx] [PATCH v2 18/21] drm/vc4: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff -

[Intel-gfx] [PATCH v2 15/21] drm/stm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[Intel-gfx] [PATCH v2 20/21] drm/vmwgfx: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_drv

[Intel-gfx] [PATCH] drm/i915/gt: Use the BIT when checking the flags, not the index

In converting over to using set_bit()/test_bit(), when manually inspecting the rq->flags, we need to use BIT(). Fixes: e1c31fb5dde3 ("drm/i915: Merge i915_request.flags with i915_request.fence.flags") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Matthew Auld --- drivers/gpu/drm/i915/gt/

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the BIT when checking the flags, not the index

On 15/01/2020 12:25, Chris Wilson wrote: In converting over to using set_bit()/test_bit(), when manually inspecting the rq->flags, we need to use BIT(). Fixes: e1c31fb5dde3 ("drm/i915: Merge i915_request.flags with i915_request.fence.flags") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

On Fri, 10 Jan 2020, Ville Syrjälä wrote: > On Thu, Jan 09, 2020 at 04:26:19PM -0500, Harry Wentland wrote: >> >> >> On 2020-01-09 4:04 p.m., Mario Kleiner wrote: >> > On Thu, Jan 9, 2020 at 8:49 PM Alex Deucher > > > wrote: >> > >> > On Thu, Jan 9, 2020 at 11:4

Re: [Intel-gfx] [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

On Wed, 15 Jan 2020, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of their > equivalents in struct drm_crtc_funcs. Convert i915 over. > > The callback struct drm_driver.get_scanout_position() is deprecated > in favor of struct drm_crtc_helper_funcs.get_s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev7)

== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev7) URL : https://patchwork.freedesktop.org/series/71873/ State : warning == Summary == $ dim checkpatch origin/drm-tip b5db489929e6 drm: Add get_scanout_position() to struct drm_crtc_helper_funcs -:65: CHECK:O

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev7)

== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev7) URL : https://patchwork.freedesktop.org/series/71873/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

Re: [Intel-gfx] [PATCH 1/2] drm/i915/params: add i915 parameters to debugfs

On Wed, 15 Jan 2020, Jani Nikula wrote: > On Wed, 15 Jan 2020, Chris Wilson wrote: >> Quoting Jani Nikula (2019-12-05 15:43:40) >>> Add a debugfs subdirectory i915_params with all the i915 module >>> parameters. This is a first step, with lots of boilerplate, and not much >>> benefit yet. >> >> R

[Intel-gfx] [PATCH 2/5] i915/drm/guc: Don't pass CTB while writing

Since we only have one SEND buffer we don't need to explicitly pass it to the write function. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --gi

[Intel-gfx] [PATCH 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB

We should never BUG_ON on any corruption in CTB descriptor as data there can be also modified by the GuC. Instead we can use flag "is_in_error" to indicate that we will not process any further messages over this CTB (until reset). While here move descriptor error reporting to the function that actu

[Intel-gfx] [PATCH 0/5] Misc GuC CT improvements - part II

Michal Wajdeczko (5): drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB i915/drm/guc: Don't pass CTB while writing i915/drm/guc: Don't pass CTB while reading drm/i915/guc: Switch to CT_ERROR in ct_read drm/i915/guc: Introduce CT_DEBUG drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 114 ++

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Introduce CT_DEBUG

As we now have "ct" available almost in all functions we can start using dev variants of logs also for debug. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 41 +++ 1 file changed, 19 insertions(+)

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read

As we now have "ct" available in ct_read function we can switch from generic DRM_ERROR to our custom CT_ERROR. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 18 +- 1 file changed, 9 insertions(+), 9 d

[Intel-gfx] [PATCH 3/5] i915/drm/guc: Don't pass CTB while reading

Since we only have one RECV buffer we don't need to explicitly pass it to the read function. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add current maximum eDP link rate to sink_rate array.

On Wed, Jan 15, 2020 at 02:34:02PM +0200, Jani Nikula wrote: > On Fri, 10 Jan 2020, Ville Syrjälä wrote: > > On Thu, Jan 09, 2020 at 04:26:19PM -0500, Harry Wentland wrote: > >> > >> > >> On 2020-01-09 4:04 p.m., Mario Kleiner wrote: > >> > On Thu, Jan 9, 2020 at 8:49 PM Alex Deucher >> >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II

== Series Details == Series: Misc GuC CT improvements - part II URL : https://patchwork.freedesktop.org/series/72071/ State : warning == Summary == $ dim checkpatch origin/drm-tip b07a956a95fe drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB -:50: CHECK:UNNECESSARY_PARENTHESES: Unnecessary

Re: [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

On Tue, Jan 14, 2020 at 02:45:08PM -0800, Matt Roper wrote: > Since gen12 platform support isn't finalized yet, let's kill off the > legacy color key ioctl for this platform; there's no userspace today > that can run on this platform that utilizes this legacy ioctl, so we can > safely kill it now b

[Intel-gfx] [PATCH v12 3/5] drm/i915: Manipulate DBuf slices properly

Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match

[Intel-gfx] [PATCH v12 4/5] drm/i915: Introduce parameterized DBUF_CTL

Now start using parameterized DBUF_CTL instead of hardcoded, this would allow shorter access functions when reading or storing entire state. Tried to implement it in a MMIO_PIPE manner, however DBUF_CTL1 address is higher than DBUF_CTL2, which implies that we have to now subtract from base rather

[Intel-gfx] [PATCH v12 0/5] Enable second DBuf slice for ICL and TGL

Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915: Mo

[Intel-gfx] [PATCH v12 2/5] drm/i915: Move dbuf slice update to proper place

Current DBuf slices update wasn't done in proper place, especially its "post" part, which should disable those only once vblank had passed and all other changes are committed. v2: Fix to use dev_priv and intel_atomic_state instead of skl_ddb_values (to be nuked in Villes patch) v3: Rename

[Intel-gfx] [PATCH v12 5/5] drm/i915: Correctly map DBUF slices to pipes

Added proper DBuf slice mapping to correspondent pipes, depending on pipe configuration as stated in BSpec. v2: - Remove unneeded braces - Stop using macro for DBuf assignments as it seems to reduce readability. v3: Start using enabled slices mask in dev_priv v4: Renamed "enabled_s

[Intel-gfx] [PATCH v12 1/5] drm/i915: Remove skl_ddl_allocation struct

Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. v3: Chang

[Intel-gfx] ✗ Fi.CI.BUILD: warning for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev3)

== Series Details == Series: series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev3) URL : https://patchwork.freedesktop.org/series/72048/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK inc

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev3)

== Series Details == Series: series starting with [v2] drm/i915: Keep track of request among the scheduling lists (rev3) URL : https://patchwork.freedesktop.org/series/72048/ State : success == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16108 ===

Re: [Intel-gfx] [PATCH v2 02/21] drm: Evaluate struct drm_device.vblank_disable_immediate on each use

On Wed, Jan 15, 2020 at 01:16:33PM +0100, Thomas Zimmermann wrote: > VBLANK interrupts can be disabled immediately or with a delay, where the > latter is the default. The former option can be selected by setting > get_vblank_timestamp, and enabling vblank_disable_immediate in struct > drm_device. >

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev7)

== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev7) URL : https://patchwork.freedesktop.org/series/71873/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Clean up VBLANK callbacks in struct drm_driver (rev7)

== Series Details == Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev7) URL : https://patchwork.freedesktop.org/series/71873/ State : success == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16109 Summary ---

Re: [Intel-gfx] [PATCH v2 03/21] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

On Wed, Jan 15, 2020 at 01:16:34PM +0100, Thomas Zimmermann wrote: > The callback get_vblank_timestamp() is currently located in struct > drm_driver, but really belongs into struct drm_crtc_funcs. Add an > equivalent there. Driver will be converted in separate patches. > > The default implementati

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Sanitize and reset GPU before removing powercontext

== Series Details == Series: series starting with [1/2] drm/i915/gt: Sanitize and reset GPU before removing powercontext URL : https://patchwork.freedesktop.org/series/71953/ State : success == Summary == CI Bug Log - changes from CI_DRM_7733_full -> Patchwork_16070_full =

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/gt: Use the BIT when checking the flags, not the index

== Series Details == Series: drm/i915/gt: Use the BIT when checking the flags, not the index URL : https://patchwork.freedesktop.org/series/72060/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kern

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Use the BIT when checking the flags, not the index

== Series Details == Series: drm/i915/gt: Use the BIT when checking the flags, not the index URL : https://patchwork.freedesktop.org/series/72060/ State : success == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16111 Summar

[Intel-gfx] ✓ Fi.CI.BAT: success for Misc GuC CT improvements - part II

== Series Details == Series: Misc GuC CT improvements - part II URL : https://patchwork.freedesktop.org/series/72071/ State : success == Summary == CI Bug Log - changes from CI_DRM_7748 -> Patchwork_16112 Summary --- **SUCCESS** N

[Intel-gfx] ✗ Fi.CI.BUILD: warning for Misc GuC CT improvements - part II

== Series Details == Series: Misc GuC CT improvements - part II URL : https://patchwork.freedesktop.org/series/72071/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is

Re: [Intel-gfx] [PATCH 3/6] drm/i915/fbc: Move the plane state check into the fbc functions

On Fri, Dec 13, 2019 at 03:34:50PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of dealing with the presence/absence of the primary > plane in the higher level pre/post plane update code let's > move all that into the fbc code itself. Now the higher level > code doesn't have to t

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Preemptive timeline retirement (rev3)

== Series Details == Series: drm/i915: Preemptive timeline retirement (rev3) URL : https://patchwork.freedesktop.org/series/71958/ State : success == Summary == CI Bug Log - changes from CI_DRM_7733_full -> Patchwork_16072_full Summary

Re: [Intel-gfx] [PATCH 5/6] drm/i915/fbc: Add fbc tracepoints

On Fri, Dec 13, 2019 at 03:34:52PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add tracepoints which let us know when fbc activates/deactivates/nukes. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 9 > drivers/gpu/

Re: [Intel-gfx] [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

On Wed, Jan 15, 2020 at 01:16:38PM +0100, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of their > equivalents in struct drm_crtc_funcs. Convert i915 over. > > The callback struct drm_driver.get_scanout_position() is deprecated > in favor of struct drm_cr

[Intel-gfx] [PATCH] drm/i915: Align engine->uabi_class/instance with i915_drm.h

From: Tvrtko Ursulin In our ABI we have defined I915_ENGINE_CLASS_INVALID_NONE and I915_ENGINE_CLASS_INVALID_VIRTUAL as negative values which creates implicit coupling with type widths used in, also ABI, struct i915_engine_class_instance. When for instance we export engine->uabi_class I915_ENGIN

Re: [Intel-gfx] [PATCH] drm/i915: Align engine->uabi_class/instance with i915_drm.h

On 15/01/2020 15:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In our ABI we have defined I915_ENGINE_CLASS_INVALID_NONE and I915_ENGINE_CLASS_INVALID_VIRTUAL as negative values which creates implicit coupling with type widths used in, also ABI, struct i915_engine_class_instance. When for i

Re: [Intel-gfx] [PATCH] drm/i915: Align engine->uabi_class/instance with i915_drm.h

Quoting Tvrtko Ursulin (2020-01-15 15:28:19) > > On 15/01/2020 15:24, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > In our ABI we have defined I915_ENGINE_CLASS_INVALID_NONE and > > I915_ENGINE_CLASS_INVALID_VIRTUAL as negative values which creates > > implicit coupling with type widths

Re: [Intel-gfx] ✗ Fi.CI.BUILD: warning for Enable second DBuf slice for ICL and TGL (rev13)

There is some kind of build failure happening with all recent series: CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3"

Re: [Intel-gfx] [PATCH 0/7] Commit early to GuC

On 1/15/2020 12:40 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2020-01-15 01:31:36) We currently wait until we attempt to load the GuC to confirm if we're in GuC mode or not, at which point a lot of the engine setup has already happened and needs to be updated for GuC submission.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Take local vma references for the parser

== Series Details == Series: drm/i915/gem: Take local vma references for the parser URL : https://patchwork.freedesktop.org/series/71968/ State : success == Summary == CI Bug Log - changes from CI_DRM_7733_full -> Patchwork_16074_full Summa

Re: [Intel-gfx] [PATCH 0/7] Commit early to GuC

Quoting Daniele Ceraolo Spurio (2020-01-15 15:57:27) > > > On 1/15/2020 12:40 AM, Chris Wilson wrote: > > Quoting Daniele Ceraolo Spurio (2020-01-15 01:31:36) > >> We currently wait until we attempt to load the GuC to confirm if we're > >> in GuC mode or not, at which point a lot of the engine se

Re: [Intel-gfx] [PATCH] drm/i915: Align engine->uabi_class/instance with i915_drm.h

On 15/01/2020 15:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2020-01-15 15:28:19) On 15/01/2020 15:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In our ABI we have defined I915_ENGINE_CLASS_INVALID_NONE and I915_ENGINE_CLASS_INVALID_VIRTUAL as negative values which creates implicit co

  1   2   >