[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix vGPU kernel context kmemleak

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix vGPU kernel context kmemleak URL : https://patchwork.freedesktop.org/series/71027/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15807 Summary --- **SUCCES

Re: [Intel-gfx] [CI 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Mon, 16 Dec 2019, Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > > Either the one integrated into the PMIC or the one integrated into the > SoC (the 1st LPSS PWM control

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/dsi: Move Crystal Cove PMIC panel GPIO lookup from mfd to the i915 driver

2019-12-17 Thread Lee Jones
On Mon, 16 Dec 2019, Hans de Goede wrote: > Move the Crystal Cove PMIC panel GPIO lookup-table from > drivers/mfd/intel_soc_pmic_core.c to the i915 driver. > > The moved looked-up table is adding a GPIO lookup to the i915 PCI > device and the GPIO subsys allows only one lookup table per device, >

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Mon, 16 Dec 2019, Hans de Goede wrote: > Hi, > > On 16-12-2019 10:30, Lee Jones wrote: > > [...] > > > > > > > > > > > > > Which use a Crystal Cove PMIC, yet the LCD is connected > > > > > > > > > > > to the SoC/LPSS > > > > > > > > > > > PWM controller (and the VBT correctly indicates this)

Re: [Intel-gfx] [PATCH] drm/i915: Fix vGPU kernel context kmemleak

2019-12-17 Thread Chris Wilson
Quoting Zhenyu Wang (2019-12-17 07:13:54) > Current GVT allocates kernel context as vGPU submission context. > For vGPU destroy, the kernel context needs to be close then released, > otherwise context's vm ppgtt resource would cause memleak issue like > below. This trys to add new helper to destroy

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/dsi: Remove readback of panel orientation on BYT / CHT (rev2)

2019-12-17 Thread Hans de Goede
Hi all, On 16-12-2019 21:55, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/dsi: Remove readback of panel orientation on BYT / CHT (rev2) URL : https://patchwork.freedesktop.org/series/70952/ State : failure == Summary == CI Bug Log - changes from CI_DRM_

[Intel-gfx] [PULL] drm-misc-next

2019-12-17 Thread Maarten Lankhorst
Hey, First pull for v5.6! Enjoy! ~Maarten drm-misc-next-2019-12-16: drm-misc-next for v5.6: UAPI Changes: - Add support for DMA-BUF HEAPS. Cross-subsystem Changes: - mipi dsi definition updates, pulled into drm-intel as well. - Add lockdep annotations for dma_resv vs mmap_sem and fs_reclaim.

[Intel-gfx] [PATCH] drm/i915/gt: Avoid multi-LRI on Sandybridge

2019-12-17 Thread Chris Wilson
Sandybridge is the gen that didn't handle multiple registers in a single LRI packet. Don't forget it! Fixes: 902eb748e5c3 ("drm/i915/gt: Tidy up full-ppgtt on Ivybridge") Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 13 + 1 file

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Avoid multi-LRI on Sandybridge

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid multi-LRI on Sandybridge URL : https://patchwork.freedesktop.org/series/71029/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9825d1f6a29e drm/i915/gt: Avoid multi-LRI on Sandybridge -:47: CHECK:LINE_SPACING: Please don't use multi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT (rev3) URL : https://patchwork.freedesktop.org/series/69686/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15800_full =

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915/perf: open access for CAP_SYS_PERFMON privileged process

2019-12-17 Thread Lionel Landwerlin
On 16/12/2019 22:03, Alexey Budankov wrote: Open access to i915_perf monitoring for CAP_SYS_PERFMON privileged processes. For backward compatibility reasons access to i915_perf subsystem remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure i915_perf monitoring is

[Intel-gfx] [PATCH 5/8] drm/i915/selftests: Disable heartbeats around long queues

2019-12-17 Thread Chris Wilson
For some execlists scheduler tests we assume very precise layout of the inflight queue and become angry if the heartbeat interferes by reprioritising our contexts (because we happen to be using the same engine->kernel_context for our test). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 2/8] drm/i915: Hold reference to intel_frontbuffer as we track activity

2019-12-17 Thread Chris Wilson
Since obj->frontbuffer is no longer protected by the struct_mutex, as we are processing the execbuf, it may be removed. Mark the intel_frontbuffer as rcu protected, and so acquire a reference to the struct as we track activity upon it. Closes: https://gitlab.freedesktop.org/drm/intel/issues/827 Fi

[Intel-gfx] [PATCH 6/8] drm/i915/selftests: Impose a timeout for request submission

2019-12-17 Thread Chris Wilson
Avoid spinning indefinitely waiting for the request to be submitted, and instead apply a timeout. A secondary benefit is that the error message will show which suspect is blocked. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 26 +- 1 file chang

[Intel-gfx] [PATCH 1/8] drm/i915: Unpin vma->obj on early error

2019-12-17 Thread Chris Wilson
If we inherit an error along the fence chain, we skip the main work callback and go straight to the error. In the case of the vma bind worker, we only dropped the pinned pages from the worker. In the process, make sure we call the release earlier rather than wait until the final reference to the f

[Intel-gfx] [PATCH 3/8] drm/i915/display: Silence powerwell debug

2019-12-17 Thread Chris Wilson
As we may try to toggle the powerwell several hundred thousand times a second, emitting several debug messages for each event simply overwhelms the reader, cibuglog and the filesystem! TLDR; logging overload. Signed-off-by: Chris Wilson Cc: Imre Deak Cc: Ville Syrjälä --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/8] drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp

2019-12-17 Thread Chris Wilson
As we stash a pointer to the HWSP cacheline on the request, when reading it we only need confirm that the cacheline is still valid by checking that the request and timeline are still intact. v2: Protect hwsp_cachline with RCU Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 8/8] drm/i915: Tweak scheduler's kick_submission()

2019-12-17 Thread Chris Wilson
Skip useless priority bumping on adding a new dependency, but otherwise prevent tasklet scheduling until we have completed all the potential rescheduling. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_scheduler.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling

2019-12-17 Thread Chris Wilson
Only signal the breadcrumbs from inside the irq_work, simplifying our interface and calling conventions. The micro-optimisation here is that by always using the irq_work interface, we know we are always inside an irq-off critical section for the breadcrumb signaling and can ellide save/restore of t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Avoid multi-LRI on Sandybridge

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid multi-LRI on Sandybridge URL : https://patchwork.freedesktop.org/series/71029/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15808 Summary --- **SUCCE

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: Control panel and backlight enable GPIOs from VBT (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Control panel and backlight enable GPIOs from VBT (rev2) URL : https://patchwork.freedesktop.org/series/70945/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15801_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Unpin vma->obj on early error

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Unpin vma->obj on early error URL : https://patchwork.freedesktop.org/series/71031/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15809 Sum

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-17 Thread Ville Syrjälä
On Mon, Dec 16, 2019 at 02:58:13PM -0800, Manasi Navare wrote: > On Mon, Dec 16, 2019 at 02:33:10PM -0800, Manasi Navare wrote: > > On Mon, Dec 16, 2019 at 11:37:38PM +0200, Ville Syrjälä wrote: > > > On Mon, Dec 16, 2019 at 11:13:09AM -0800, Manasi Navare wrote: > > > > On Mon, Dec 16, 2019 at 04:

Re: [Intel-gfx] [CI 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT

2019-12-17 Thread Jani Nikula
On Mon, 16 Dec 2019, Hans de Goede wrote: > Hi All, > > Somehow the CI system did not pick up this series the first time, there > are no test results recorded for it: > https://patchwork.freedesktop.org/series/69685 > > So this is a resend for CI to do its thing. As soon as CI is happy with > this

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915/perf: open access for CAP_SYS_PERFMON privileged process

2019-12-17 Thread Alexey Budankov
On 17.12.2019 12:45, Lionel Landwerlin wrote: > On 16/12/2019 22:03, Alexey Budankov wrote: >> Open access to i915_perf monitoring for CAP_SYS_PERFMON privileged processes. >> For backward compatibility reasons access to i915_perf subsystem remains open >> for CAP_SYS_ADMIN privileged processes b

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3) URL : https://patchwork.freedesktop.org/series/69129/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15797 ===

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Add selftest for memory region PF handling

2019-12-17 Thread Abdiel Janulgue
Instead of testing individually our new fault handlers, iterate over all memory regions and test all from one interface. Signed-off-by: Abdiel Janulgue Cc: Matthew Auld Cc: Chris Wilson Cc: Joonas Lahtinen --- .../drm/i915/gem/selftests/i915_gem_mman.c| 226 -- 1 file chan

[Intel-gfx] [PATCH 1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Abdiel Janulgue
Fault handler to handle missing pages for lmem objects. v4: Restore non-contigous fault handling in addition to remap_io_mapping Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 13 + drivers/gp

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Steven Price
On 17/12/2019 06:37, Randy Dunlap wrote: > On 12/16/19 9:42 PM, Sam Ravnborg wrote: >> Hi Randy. >> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >>> On 12/15/19 9:22 PM, Stephen Rothwell wrote: Hi all, Changes since 20191213: >>> >>> on x86_64: >>> >>> ld: dr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Chris Wilson
Quoting Abdiel Janulgue (2019-12-17 11:57:49) > Fault handler to handle missing pages for lmem objects. > > v4: Restore non-contigous fault handling in addition to remap_io_mapping > > Signed-off-by: Abdiel Janulgue > Signed-off-by: Matthew Auld > Cc: Chris Wilson > Cc: Joonas Lahtinen > ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Abdiel Janulgue
On 17/12/2019 14.14, Chris Wilson wrote: > Quoting Abdiel Janulgue (2019-12-17 11:57:49) >> Fault handler to handle missing pages for lmem objects. >> >> v4: Restore non-contigous fault handling in addition to remap_io_mapping >> >> Signed-off-by: Abdiel Janulgue >> Signed-off-by: Matthew Auld

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : warning == Summary == $ dim checkpatch origin/drm-tip 21b92ebb9c01 drm/i915: Add lmem fault handler -:116: WARNING:UNNECESSARY_ELSE: else is no

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Add lmem fault handler - +drivers/gpu/drm/i915/gem/i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp (rev3) URL : https://patchwork.freedesktop.org/series/70997/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15804_full ==

Re: [Intel-gfx] [PULL] drm-misc-next

2019-12-17 Thread Daniel Vetter
On Tue, Dec 17, 2019 at 09:48:53AM +0100, Maarten Lankhorst wrote: > Hey, > > First pull for v5.6! > > Enjoy! > > ~Maarten > > drm-misc-next-2019-12-16: > drm-misc-next for v5.6: > > UAPI Changes: > - Add support for DMA-BUF HEAPS. > > Cross-subsystem Changes: > - mipi dsi definition updates,

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add lmem fault handler URL : https://patchwork.freedesktop.org/series/71051/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15810 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Patchwork
== Series Details == Series: linux-next: Tree for Dec 16 (drm_panel & intel_panel) URL : https://patchwork.freedesktop.org/series/71052/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f9c2e2f3e3a linux-next: Tree for Dec 16 (drm_panel & intel_panel) -:22: WARNING:COMMIT_LOG_LON

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-12-17 Thread Daniel Vetter
On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function > 'anx6345_i2c_probe': > drivers/gpu/drm/bridge/

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lee Jones wrote: > On Mon, 16 Dec 2019, Hans de Goede wrote: > >> Hi, >> >> Doing immutable branches assumes that there is a base point, >> e.g. 5.5-rc1 where the immutable branch can then be based on and >> that the branch can then be merged without issues into both subsyste

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/guc: Merge communication_stop and communication_disable URL : https://patchwork.freedesktop.org/series/71020/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15805_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Patchwork
== Series Details == Series: linux-next: Tree for Dec 16 (drm_panel & intel_panel) URL : https://patchwork.freedesktop.org/series/71052/ State : success == Summary == CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15811 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add lmem fault handler

2019-12-17 Thread Abdiel Janulgue
On 17/12/2019 15.00, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Add lmem fault handler > URL : https://patchwork.freedesktop.org/series/71051/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7580 -> Patchwork_15810 > ===

[Intel-gfx] [PATCH] drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Chris Wilson
Since commit e5dadff4b093 ("drm/i915: Protect request retirement with timeline->mutex"), the request retirement can happen outside of the struct_mutex serialised only by the timeline->mutex. We drop the timeline->mutex on submitting the request (i915_request_add) so after that point, it is liable t

Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Tue, 17 Dec 2019, Jani Nikula wrote: > On Tue, 17 Dec 2019, Lee Jones wrote: > > On Mon, 16 Dec 2019, Hans de Goede wrote: > > > >> Hi, > >> > >> Doing immutable branches assumes that there is a base point, > >> e.g. 5.5-rc1 where the immutable branch can then be based on and > >> that the br

[Intel-gfx] [PATCH v2] drm/i915/display: Force the state compute phase once to enable PSR

2019-12-17 Thread José Roberto de Souza
Recent improvements in the state tracking in i915 caused PSR to not be enabled when reusing firmware/BIOS modeset, this is due to all initial commits returning ealier in intel_atomic_check() as needs_modeset() is always false. To fix that here forcing the state compute phase in CRTC that is drivin

Re: [Intel-gfx] [PATCH] drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Matthew Auld
On Tue, 17 Dec 2019 at 13:47, Chris Wilson wrote: > > Since commit e5dadff4b093 ("drm/i915: Protect request retirement with > timeline->mutex"), the request retirement can happen outside of the > struct_mutex serialised only by the timeline->mutex. We drop the > timeline->mutex on submitting the r

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Andy Shevchenko
On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > On 17/12/2019 06:37, Randy Dunlap wrote: > > On 12/16/19 9:42 PM, Sam Ravnborg wrote: > >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: > >>> On 12/15/19 9:22 PM, Stephen Rothwell wrote: > >>> on x86_64: > >>> > >>> ld: driver

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,rebased,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v2,rebased,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2) URL : https://patchwork.freedesktop.org/series/70775/ State : failure == Summary == Applying: drm: Add __drm_atomic_helper_crtc_state_reset() & co. Applying: drm/i

[Intel-gfx] [PATCH v2] drm/i915/pmu: Ensure monotonic rc6

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoid rc6 counter going backward in close to 0% RC6 scenarios like: 15.005477996114,246,613 ns i915/rc6-residency/ 16.005876662667,657 ns i915/rc6-residency/ 17.006131417 7,286 ns i915/rc6-residency/ 18.006615031 18,446,

Re: [Intel-gfx] [PATCH v2] drm/i915/pmu: Ensure monotonic rc6

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 14:20:57) > From: Tvrtko Ursulin > > Avoid rc6 counter going backward in close to 0% RC6 scenarios like: > > 15.005477996114,246,613 ns i915/rc6-residency/ > 16.005876662667,657 ns i915/rc6-residency/ > 17.006131417

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Add getfb2 ioctl (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm: Add getfb2 ioctl (rev2) URL : https://patchwork.freedesktop.org/series/67553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15806_full Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v3,01/11] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2) URL : https://patchwork.freedesktop.org/series/71009/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7581 -> Patchwork_15813 ==

Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Jani Nikula
On Tue, 10 Dec 2019, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. > > We have existing drm specific struct

[Intel-gfx] [PATCH v4 rebased 2/2] drm/i915/display: Fix warning about MST and DDI restrictions

2019-12-17 Thread José Roberto de Souza
Capturing the restrictions of the BSpec pages bellow: SKL and CNL do not support MST in DDI E, DDI E only support 2 lanes and it is mostly used to support a 4 lanes eDP panel together with DDI A. ICL's DDI E support MST just like other ports but DDI A is still eDP and MIPI only. TGL supports MST i

[Intel-gfx] [PATCH v4 rebased 1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-17 Thread José Roberto de Souza
Talked with HW team and this is a left over, driver should not program clockgating, mg or dekel firmware is reponsible for any clockgating programing. Also removing the register and bits definition related to clockgating. v2: Added WARN_ON v3: Only calling icl_phy_set_clock_gating() on intel_ddi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Keep request alive while attaching fences

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gem: Keep request alive while attaching fences URL : https://patchwork.freedesktop.org/series/71053/ State : success == Summary == CI Bug Log - changes from CI_DRM_7581 -> Patchwork_15814 Summary --

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Andy Shevchenko wrote: > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: >> On 17/12/2019 06:37, Randy Dunlap wrote: >> > On 12/16/19 9:42 PM, Sam Ravnborg wrote: >> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >> >>> On 12/15/19 9:22 PM, Stephen Rothw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix vGPU kernel context kmemleak

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix vGPU kernel context kmemleak URL : https://patchwork.freedesktop.org/series/71027/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15807_full Summary ---

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Andy Shevchenko
On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula wrote: > On Tue, 17 Dec 2019, Andy Shevchenko wrote: > > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/. > > It fixes issue for me. > > As discussed off-line, this will allow silent

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Andy Shevchenko wrote: > On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula > wrote: >> On Tue, 17 Dec 2019, Andy Shevchenko wrote: >> > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote: > >> > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/. >> > It fixes issue fo

Re: [Intel-gfx] [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros

2019-12-17 Thread Sam Ravnborg
Hi Jani. Will you type a todo entry as requested by Daniel? > Pushed this one patch, thanks for the reviews and acks. The rest could > still use review. ;) Will take a look again later tonight. I recall from last time I looked they were fine but I just never sent anything to the ML. Sam

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Avoid multi-LRI on Sandybridge

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid multi-LRI on Sandybridge URL : https://patchwork.freedesktop.org/series/71029/ State : success == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15808_full Summary ---

[Intel-gfx] [PATCH] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Get_pid_task() needs to be paired with a put_pid or we leak a pid reference every time a banned client tries to create a context. Signed-off-by: Tvrtko Ursulin Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit") Cc: Chris Wilson Cc: Mika Kuoppala --- d

Re: [Intel-gfx] [PATCH] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 16:18:14) > From: Tvrtko Ursulin > > Get_pid_task() needs to be paired with a put_pid or we leak a pid > reference every time a banned client tries to create a context. > > Signed-off-by: Tvrtko Ursulin > Fixes: b083a0870c79 ("drm/i915: Add per client max cont

Re: [Intel-gfx] [PATCH v3 06/11] drm/i915/display: Share intel_connector_needs_modeset()

2019-12-17 Thread Souza, Jose
On Mon, 2019-12-16 at 15:52 -0800, Lucas De Marchi wrote: > On Mon, Dec 16, 2019 at 02:07:37PM -0800, Jose Souza wrote: > > intel_connector_needs_modeset() will be used outside of > > intel_display.c in a future patch so it would only be necessary to > > remove the state and add the prototype to th

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp

2019-12-17 Thread Tvrtko Ursulin
On 16/12/2019 17:52, Chris Wilson wrote: As we stash a pointer to the HWSP cacheline on the request, when reading it we only need confirm that the cacheline is still valid by checking that the request and timeline are still intact. v2: Protect hwsp_cachline with RCU Signed-off-by: Chris Wilso

Re: [Intel-gfx] [PATCH v12 1/3] drm/i915: Refactor intel_can_enable_sagv

2019-12-17 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 04:12:29PM +0200, Stanislav Lisovskiy wrote: > Currently intel_can_enable_sagv function contains > a mix of workarounds for different platforms > some of them are not valid for gens >= 11 already, > so lets split it into separate functions. > > v2: > - Rework watermark

[Intel-gfx] [PATCH v2] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Get_pid_task() needs to be paired with a put_pid or we leak a pid reference every time a banned client tries to create a context. v2: * task_pid_nr helper exists! (Chris) Signed-off-by: Tvrtko Ursulin Fixes: b083a0870c79 ("drm/i915: Add per client max context ban limit")

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pid leak with banned clients

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 17:09:33) > From: Tvrtko Ursulin > > Get_pid_task() needs to be paired with a put_pid or we leak a pid > reference every time a banned client tries to create a context. > > v2: > * task_pid_nr helper exists! (Chris) > > Signed-off-by: Tvrtko Ursulin > Fixes:

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs

2019-12-17 Thread Tvrtko Ursulin
On 16/12/2019 12:53, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-12-16 12:07:01) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 0781b6326b8c..9fcbcb6d6f76 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -224,6 +22

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Expose list of clients in sysfs

2019-12-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-17 17:21:28) > > On 16/12/2019 12:53, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-12-16 12:07:01) > >> diff --git a/drivers/gpu/drm/i915/i915_drv.h > >> b/drivers/gpu/drm/i915/i915_drv.h > >> index 0781b6326b8c..9fcbcb6d6f76 100644 > >> --- a/drivers/gpu/d

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Move stuff from haswell_crtc_disable() into encoder .post_disable()

2019-12-17 Thread Souza, Jose
On Fri, 2019-12-13 at 21:52 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Move all of haswell_crtc_disable() into the encoder > .post_disable() hooks. Now we're left with just > calling the .disable() and .post_disable() hooks > back to back. > > I chose to move the code into the .post_d

Re: [Intel-gfx] [PATCH v3 06/11] drm/i915/display: Share intel_connector_needs_modeset()

2019-12-17 Thread Lucas De Marchi
On Tue, Dec 17, 2019 at 08:39:15AM -0800, Jose Souza wrote: On Mon, 2019-12-16 at 15:52 -0800, Lucas De Marchi wrote: On Mon, Dec 16, 2019 at 02:07:37PM -0800, Jose Souza wrote: > intel_connector_needs_modeset() will be used outside of > intel_display.c in a future patch so it would only be nece

Re: [Intel-gfx] [PATCH v12 2/3] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-12-17 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 04:12:30PM +0200, Stanislav Lisovskiy wrote: > According to BSpec 53998, we should try to > restrict qgv points, which can't provide > enough bandwidth for desired display configuration. > > Currently we are just comparing against all of > those and take minimum(worst case)

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-17 Thread Jason Ekstrand
On Sun, Dec 15, 2019 at 10:24 PM Niranjan Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > On Sat, Dec 14, 2019 at 10:31:37AM +, Chris Wilson wrote: > >Quoting Jason Ekstrand (2019-12-14 00:36:19) > >> On Fri, Dec 13, 2019 at 5:24 PM Niranjan Vishwanathapura < > >> niranjana.vis

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3) URL : https://patchwork.freedesktop.org/series/69129/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread Souza, Jose
On Tue, 2019-12-17 at 18:10 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/5] drm: Add > __drm_atomic_helper_crtc_state_reset() & co. (rev3) > URL : https://patchwork.freedesktop.org/series/69129/ > State : failure > > == Summary == > > CI Bug Log - changes

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Force the state compute phase once to enable PSR (rev3)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Force the state compute phase once to enable PSR (rev3) URL : https://patchwork.freedesktop.org/series/7/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15815 =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

2019-12-17 Thread James Ausmus
(+Lakshmi) On Tue, Dec 17, 2019 at 06:33:58PM +, Souza, Jose wrote: > On Tue, 2019-12-17 at 18:10 +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/5] drm: Add > > __drm_atomic_helper_crtc_state_reset() & co. (rev3) > > URL : https://patchwork.freedesk

Re: [Intel-gfx] [PATCH 2/8] drm/client: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:44PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and > DRM_DEV_ERROR(). > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_client.c | 10 +- > 1 file changed, 5 inserti

Re: [Intel-gfx] [PATCH 3/8] drm/fb-helper: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:45PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms(), drm_info(), and drm_err() over all other > logging. This is about KMS so switch to the KMS category while at it. > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_f

Re: [Intel-gfx] [PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote: > Prefer drm_dbg_kms() and drm_err() over all other logging. > > Signed-off-by: Jani Nikula Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >

Re: [Intel-gfx] [PATCH 5/8] drm/mipi-dbi: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote: > Prefer drm device based logging where possible. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_mipi_dbi.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-17 Thread Manasi Navare
On Tue, Dec 17, 2019 at 12:50:31PM +0200, Ville Syrjälä wrote: > On Mon, Dec 16, 2019 at 02:58:13PM -0800, Manasi Navare wrote: > > On Mon, Dec 16, 2019 at 02:33:10PM -0800, Manasi Navare wrote: > > > On Mon, Dec 16, 2019 at 11:37:38PM +0200, Ville Syrjälä wrote: > > > > On Mon, Dec 16, 2019 at 11:

Re: [Intel-gfx] [PATCH 6/8] drm/atomic: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
Hi Jani. On Tue, Dec 10, 2019 at 02:30:48PM +0200, Jani Nikula wrote: > Prefer drm_dbg_atomic(). This patch simplify code by introducing a local drm_device varialble which is good. But this is not mentioned in the cahngelog. Anf the patch uses more than just drm_dbg_atomic(), see for example the

Re: [Intel-gfx] [PATCH 5/8] drm/mipi-dbi: convert to drm device based logging

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 17, 2019 at 08:00:11PM +0100, Sam Ravnborg wrote: > On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote: > > Prefer drm device based logging where possible. > > > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/drm_mipi_dbi.c | 15 --- > > 1 file changed,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Ensure monotonic rc6 (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Ensure monotonic rc6 (rev2) URL : https://patchwork.freedesktop.org/series/70998/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15816 Summary --- **SUCCESS

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-17 Thread Patchwork
== Series Details == Series: series starting with [v4,rebased,1/2] drm/i915/display/icl+: Do not program clockgating URL : https://patchwork.freedesktop.org/series/71058/ State : success == Summary == CI Bug Log - changes from CI_DRM_7585 -> Patchwork_15817 ===

Re: [Intel-gfx] [PATCH] drm/i915/display: cleanup intel_bw_state on i915 module removal

2019-12-17 Thread Lucas De Marchi
On Thu, Dec 12, 2019 at 12:34:49PM -0800, Lucas De Marchi wrote: On Thu, Dec 12, 2019 at 09:37:17AM -0800, Matt Roper wrote: On Wed, Dec 11, 2019 at 04:22:50PM -0800, Lucas De Marchi wrote: On Wed, Dec 11, 2019 at 12:10:41PM +0530, Bharadiya,Pankaj wrote: On Tue, Dec 10, 2019 at 09:57:39PM -08

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:04PM -0800, Niranjana Vishwanathapura wrote: > + ctx = i915_gem_context_lookup(file->driver_priv, args->rsvd1); > + if (!ctx || !rcu_access_pointer(ctx->vm)) > + return -ENOENT; > + > + rcu_read_lock(); > + vm = i915_vm_get(ctx->vm); > +

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-12-17 Thread Stephen Rothwell
Hi Daniel, On Tue, 17 Dec 2019 14:19:37 +0100 Daniel Vetter wrote: > > On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote: > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/gpu/drm/bridge/analogix/analogix

Re: [Intel-gfx] [RFC v2 05/12] drm/i915/svm: Page table mirroring support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:07PM -0800, Niranjana Vishwanathapura wrote: > +static struct i915_svm *vm_get_svm(struct i915_address_space *vm) > +{ > + struct i915_svm *svm = vm->svm; > + > + mutex_lock(&vm->svm_mutex); > + if (svm && !kref_get_unless_zero(&svm->ref)) > + s

Re: [Intel-gfx] [RFC v2 06/12] drm/i915/svm: Device memory support

2019-12-17 Thread Jason Gunthorpe
On Fri, Dec 13, 2019 at 01:56:08PM -0800, Niranjana Vishwanathapura wrote: > @@ -169,6 +170,11 @@ static int i915_range_fault(struct svm_notifier *sn, > return ret; > } > > + /* For dgfx, ensure the range is in device local memory only */ > +

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Tue, Dec 17, 2019 at 09:56:54AM +0200, Tomi Sarvela wrote: > On 12/17/19 1:59 AM, Manasi Navare wrote: > >On Fri, Dec 13, 2019 at 10:54:55AM +0200, Tomi Sarvela wrote: > >>On 12/12/19 11:28 PM, Manasi Navare wrote: > >>>The KBL failure does not look related to the changes in this patch series. >

Re: [Intel-gfx] [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes should > be able to be display

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix pid leak with banned clients (rev2)

2019-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix pid leak with banned clients (rev2) URL : https://patchwork.freedesktop.org/series/71062/ State : success == Summary == CI Bug Log - changes from CI_DRM_7587 -> Patchwork_15818 Summary --- *

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915/guc/ct: Drop guards in enable/disable calls

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:11 +0100, Daniele Ceraolo Spurio wrote: We track the status of the GuC much more closely now and we expect the enable/disable functions to be correctly called only once. If this isn't true we do want to flag it as a flow failure (via the BUG_ON in the ctch functions)

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915/guc/ct: Stop expecting multiple CT channels

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:12 +0100, Daniele Ceraolo Spurio wrote: The GuC supports having multiple CT buffer pairs and we designed our implementation with that in mind. However, the different channels are not processed in parallel within the GuC, so there is very little advantage in having mu

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/guc/ct: Group request-related variables in a sub-structure

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:13 +0100, Daniele Ceraolo Spurio wrote: For better isolation of the request tracking from the rest of the CT-related data. v2: split to separate patch, move next_fence to substructure (Michal) Signed-off-by: Daniele Ceraolo Spurio Cc: Michal Wajdeczko Cc: John Ha

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915/guc: Remove function pointers for send/receive calls

2019-12-17 Thread Michal Wajdeczko
On Tue, 17 Dec 2019 02:23:14 +0100, Daniele Ceraolo Spurio wrote: Since we started using CT buffers on all gens, the function pointers can only be set to either the _nop() or the _ct() functions. Since the _nop() case applies to when the CT are disabled, we can just handle that case in the _c

  1   2   >