[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: remove extra debug messages

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/bios: remove extra debug messages URL : https://patchwork.freedesktop.org/series/70572/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7503_full -> Patchwork_15632_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Update uncore access path in flush_ggtt_writes

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update uncore access path in flush_ggtt_writes URL : https://patchwork.freedesktop.org/series/70579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7506_full -> Patchwork_15635_full

Re: [Intel-gfx] [PATCH] drm/i915/guc: Update uncore access path in flush_ggtt_writes

2019-12-07 Thread Chris Wilson
Quoting john.c.harri...@intel.com (2019-12-07 01:00:33) > From: Matthew Brost > > The preferred way to access the uncore is through the GT structure. > Update the GuC function, flush_ggtt_writes, to use this path. > > Signed-off-by: Matthew Brost > Cc: John Harrison John, you should provide a

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915/tgl: Select master transcoder for MST stream

2019-12-07 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/tgl: Select master transcoder for MST stream URL : https://patchwork.freedesktop.org/series/70581/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7506_full -> Patchwork_15636_full

[Intel-gfx] [PATCH 8/8] HAX: Use aliasing-ppgtt for gen7

2019-12-07 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index bba6b50e6beb..da3e9b5752ac 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -436,

[Intel-gfx] [PATCH 3/8] drm/i915: Simplify error escape from cmdparser

2019-12-07 Thread Chris Wilson
We need to flush the destination buffer, even on error, to maintain consistent cache state. Thereby removing the jump on error past the clear, and reducing the loop-escape mechanism to a mere break. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_cmd_parser.c | 12 1 file

[Intel-gfx] [PATCH 2/8] drm/i915: Remove redundant parameters from intel_engine_cmd_parser

2019-12-07 Thread Chris Wilson
Declutter the calling interface by reducing the parameters to the i915_vma and associated offsets. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 33 +- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 21 drivers/gpu/drm/i915/i915_cmd_parser.c|

[Intel-gfx] [PATCH 5/8] drm/i915: Align start for memcpy_from_wc

2019-12-07 Thread Chris Wilson
The movntqda requires 16-byte alignment for the source pointer. Avoid falling back to clflush if the source pointer is misaligned by doing the doing a small uncached memcpy to fixup the alignments. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_cmd_parser.c | 30 +-

[Intel-gfx] [PATCH 6/8] drm/i915: Prepare gen7 cmdparser for async execution

2019-12-07 Thread Chris Wilson
The gen7 cmdparser is primarily a promotion-based system to allow access to additional registers beyond the HW validation, and allows fallback to normal execution of the user batch buffer if valid and requires chaining. In the next patch, we will do the cmdparser validation in the pipeline asynchro

[Intel-gfx] [PATCH 4/8] drm/i915/gem: Tidy up error handling for eb_parse()

2019-12-07 Thread Chris Wilson
As the caller no longer uses the i915_vma result, stop returning it and just return the error code instead. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 37 +-- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 7/8] drm/i915: Asynchronous cmdparser

2019-12-07 Thread Chris Wilson
Execute the cmdparser asynchronously as part of the submission pipeline. Using our dma-fences, we can schedule execution after an asynchronous piece of work, so we move the cmdparser out from under the struct_mutex inside execbuf as run it as part of the submission pipeline. The same security rules

[Intel-gfx] [PATCH 1/8] drm/i915: Fix cmdparser drm.debug

2019-12-07 Thread Chris Wilson
The cmdparser rejection debug is not for driver development, but for the user, for which we use a plain DRM_DEBUG(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_cmd_parser.c | 55 +- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Asynchronous cmdparser

2019-12-07 Thread Chris Wilson
Quoting Chris Wilson (2019-12-07 17:01:09) > Execute the cmdparser asynchronously as part of the submission pipeline. > Using our dma-fences, we can schedule execution after an asynchronous > piece of work, so we move the cmdparser out from under the struct_mutex > inside execbuf as run it as part

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Asynchronous cmdparser

2019-12-07 Thread Chris Wilson
Quoting Chris Wilson (2019-12-07 17:17:31) > Quoting Chris Wilson (2019-12-07 17:01:09) > > Execute the cmdparser asynchronously as part of the submission pipeline. > > Using our dma-fences, we can schedule execution after an asynchronous > > piece of work, so we move the cmdparser out from under t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915: Fix cmdparser drm.debug

2019-12-07 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Fix cmdparser drm.debug URL : https://patchwork.freedesktop.org/series/70586/ State : warning == Summary == $ dim checkpatch origin/drm-tip d02707c0b2f8 drm/i915: Fix cmdparser drm.debug 46e41bd43545 drm/i915: Remove redundant p

Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"

2019-12-07 Thread Chris Wilson
Quoting Andi Shyti (2019-12-07 17:42:39) > Hi Chris, > > On Sat, Dec 07, 2019 at 01:08:35AM +, Chris Wilson wrote: > > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b. > > > > __for_each_physical_engine() reprograms the context, invalidating the > > use of e->flags to select engi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/8] drm/i915: Fix cmdparser drm.debug

2019-12-07 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Fix cmdparser drm.debug URL : https://patchwork.freedesktop.org/series/70586/ State : success == Summary == CI Bug Log - changes from CI_DRM_7507 -> Patchwork_15637 Summary -

Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"

2019-12-07 Thread Andi Shyti
Hi Chris, On Sat, Dec 07, 2019 at 01:08:35AM +, Chris Wilson wrote: > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b. > > __for_each_physical_engine() reprograms the context, invalidating the > use of e->flags to select engines, necessitating e->index instead. > Withot also fixi

[Intel-gfx] [PATCH] drm/i915: Flesh out device_info pretty printer

2019-12-07 Thread Chris Wilson
Include all the number fields for describing the GT, as well as the current boolean flags, primarily for inclusion in error states. Signed-off-by: Chris Wilson Cc: Andi Shyti --- drivers/gpu/drm/i915/i915_debugfs.c | 22 +--- drivers/gpu/drm/i915/i915_drv.c | 4 +-- d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Flesh out device_info pretty printer

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Flesh out device_info pretty printer URL : https://patchwork.freedesktop.org/series/70587/ State : warning == Summary == $ dim checkpatch origin/drm-tip 17389fb3b235 drm/i915: Flesh out device_info pretty printer -:161: CHECK:PARENTHESIS_ALIGNMENT: Alignm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flesh out device_info pretty printer

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Flesh out device_info pretty printer URL : https://patchwork.freedesktop.org/series/70587/ State : success == Summary == CI Bug Log - changes from CI_DRM_7507 -> Patchwork_15638 Summary --- **SU

Re: [Intel-gfx] [PATCH] drm/i915/uc: Extra info notice about FW version mis-match vs overrides

2019-12-07 Thread Michal Wajdeczko
On Fri, 06 Dec 2019 22:21:37 +0100, John Harrison wrote: On 11/21/2019 02:43, Michal Wajdeczko wrote: On Thu, 21 Nov 2019 01:27:23 +0100, wrote: From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning message was still being printed, tho

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/8] drm/i915: Fix cmdparser drm.debug

2019-12-07 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Fix cmdparser drm.debug URL : https://patchwork.freedesktop.org/series/70586/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7507_full -> Patchwork_15637_full

Re: [Intel-gfx] [PATCH] drm/i915/uc: Don't complain about FW versions when overridden

2019-12-07 Thread Michal Wajdeczko
On Sat, 07 Dec 2019 02:01:55 +0100, wrote: From: John Harrison If a FW override is present then a version mis-match is actually ignored. The warning notice was still being printed, though. Which could confuse people by implying that the load had failed when it had actually succeeded. Given th

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Avoid calling i915_gem_object_unbind holding object lock

2019-12-07 Thread Andi Shyti
Hi Chris, > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c > > > b/drivers/gpu/drm/i915/gem/i915_gem_domain.c > > > index 808eb327a29b..53e28e417cc9 100644 > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c > > > @@ -187,21 +

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_freq: Protect against absent sysfs nodes

2019-12-07 Thread Chris Wilson
Not all machines expose the RPS control nodes (e.g. Ironlake and earlier) as they don't support RPS. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_freq.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/

Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/i915: Use engine query interface for gem_ctx_isolation/persistence"

2019-12-07 Thread Andi Shyti
> > This reverts commit 343aae776a58a67fa153825385e6fe90e3185c5b. [...] > > - __for_each_physical_engine(fd, e) { > > + for (const struct intel_execution_engine2 *e = intel_execution_engines2; > > +e->name; e++) { > > __for_each_static_engine() ? oh yes, that's a revert! ignore it.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Flesh out device_info pretty printer

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Flesh out device_info pretty printer URL : https://patchwork.freedesktop.org/series/70587/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7507_full -> Patchwork_15638_full Summary -

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_engines: Use an offset hint to avoid overlap

2019-12-07 Thread Chris Wilson
As Braswell is using aliasing-ppgtt, softpinning is trick as we have to avoid overlapping with HW objects in the GGTT (like context images). Typically allocations are from either end, so if we provide a hint to use the middle, we should be safe from overlap. Signed-off-by: Chris Wilson --- tests

[Intel-gfx] [PATCH] drm/i915/gtt: Account for preallocation in asserts

2019-12-07 Thread Chris Wilson
Our asserts allow for the PDEs to be allocated concurrently, but we did not account for the aliasing-ppgtt to be preallocated on top. Testcase: igt/gem_ppgtt #bsw Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 -- 1 file changed, 4 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

2019-12-07 Thread Chris Wilson
Since we didn't check and insist that args.pad must be zero for MMAP_GTT historically, we cannot insert a check now as old userspace may be feeding in garbage. As such the lack of check is enshrined into the ABI, so add a comment to remind us we cannot add the check later. Signed-off-by: Chris Wil

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Account for preallocation in asserts

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Account for preallocation in asserts URL : https://patchwork.freedesktop.org/series/70591/ State : success == Summary == CI Bug Log - changes from CI_DRM_7508 -> Patchwork_15639 Summary ---

Re: [Intel-gfx] [PATCH v2 11/14] HID: picoLCD: constify fb ops

2019-12-07 Thread Jiri Kosina
On Thu, 5 Dec 2019, Jani Nikula wrote: > >> Now that the fbops member of struct fb_info is const, we can start > >> making the ops const as well. > >> > >> v2: fixtypo (Christophe de Dinechin) > > > > Fine with me. > > I don't think going through drm-misc would trigger any conflict, but > > ad

[Intel-gfx] [PATCH] drm/i915/gem: Avoid rcu_barrier() from shrinker paths

2019-12-07 Thread Chris Wilson
As i915_gem_object_unbind() waits on an rcu_barrier() to flush vm releases (and destruction of their bound vma), we have to be careful not to invoke that barrier from beneath the shrinker: <4> [430.222671] WARNING: possible circular locking dependency detected <4> [430.222673] 5.4.0-rc8-CI-CI_DRM_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET URL : https://patchwork.freedesktop.org/series/70593/ State : success == Summary == CI Bug Log - changes from CI_DRM_7508 -> Patchwork_15640 S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Avoid rcu_barrier() from shrinker paths

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid rcu_barrier() from shrinker paths URL : https://patchwork.freedesktop.org/series/70596/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d43df857939 drm/i915/gem: Avoid rcu_barrier() from shrinker paths -:14: WARNING:COMMIT_LOG_LON

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Avoid rcu_barrier() from shrinker paths

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid rcu_barrier() from shrinker paths URL : https://patchwork.freedesktop.org/series/70596/ State : success == Summary == CI Bug Log - changes from CI_DRM_7509 -> Patchwork_15641 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gtt: Account for preallocation in asserts

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Account for preallocation in asserts URL : https://patchwork.freedesktop.org/series/70591/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7508_full -> Patchwork_15639_full Summary -

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET

2019-12-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Comment on inability to check args.pad for MMAP_OFFSET URL : https://patchwork.freedesktop.org/series/70593/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7508_full -> Patchwork_15640_full =