Re: [Intel-gfx] [PATCH v2] drm/i915/vbt: Handle generic DTD block

2019-10-29 Thread Jani Nikula
On Mon, 28 Oct 2019, Matt Roper wrote: > VBT revision 229 adds a new "Generic DTD" block 58 and deprecates the > old LFP panel mode data in block 42. Let's start parsing this block to > fill in the panel fixed mode on devices with a >=229 VBT. > > v2: > * Update according to the recent updates:

[Intel-gfx] [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.

2019-10-29 Thread Maarten Lankhorst
Use this in all the places where we try to acquire planes after the planes atomic_check(). In case of intel_modeset_all_pipes() this is not yet done after atomic_check, but seems like it will be in the future. To add some paranoia, add all planes rather than active planes, because of bigjoiner and

[Intel-gfx] [CI 02/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-29 Thread Maarten Lankhorst
We are still looking at drm_crtc_state in a few places, convert those to use intel_crtc_state instead. Changes since v1: - Move to before uapi/hw split. - Add hunks for intel_pm.c as well. Changes since v2: - Incorporate Ville's feedback. Signed-off-by: Maarten Lankhorst Reviewed-by: Matt Roper

[Intel-gfx] [CI 03/12] drm/i915: Add aliases for uapi and hw to crtc_state

2019-10-29 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_atomic.c | 8 -- drivers/gpu/dr

[Intel-gfx] [CI 05/12] drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.

2019-10-29 Thread Maarten Lankhorst
Split up crtc_state->base to hw where appropriate. This is done using the following patch: @@ struct intel_crtc_state *T; identifier x =~ "^(active|enable|degamma_lut|gamma_lut|ctm|mode|adjusted_mode)$"; @@ -T->base.x +T->hw.x @@ struct drm_crtc_state *T; identifier x =~ "^(active|enable|degam

[Intel-gfx] [CI 07/12] drm/i915: Complete crtc hw/uapi split, v4.

2019-10-29 Thread Maarten Lankhorst
Now that we separated everything into uapi and hw, it's time to make the split definitive. Remove the union and make a copy of the hw state on modeset and fastset. Color blobs are copied in crtc atomic_check(), right before color management is checked. Changes since v1: - Copy all blobs immediate

[Intel-gfx] [CI 10/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.

2019-10-29 Thread Maarten Lankhorst
Split up plane_state->base to hw. This is done using the following patch: @@ struct intel_plane_state *T; identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; @@ -T->base.x +T->hw.x Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_ato

[Intel-gfx] [CI 11/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.

2019-10-29 Thread Maarten Lankhorst
Split up plane_state->base to uapi. This is done using the following patch, ran after the previous commit that splits out any hw references: @@ struct intel_plane_state *T; identifier x; @@ -T->base.x +T->uapi.x @@ struct intel_plane_state *T; @@ -T->base +T->uapi Signed-off-by: Maarten Lankhors

[Intel-gfx] [CI 08/12] drm/i915: Add aliases for uapi and hw to plane_state

2019-10-29 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- .../gpu/drm/i915/display/intel_atomic_plane.c| 16 .

[Intel-gfx] [CI 04/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-29 Thread Maarten Lankhorst
intel_get_load_detect_pipe() needs to set uapi active, uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), so we can remove it. intel_pipe_config_compare() needs to look at hw state, but I didn't change spatch to look at it. It's easy enough to do manually. intel_atomic_check() defi

[Intel-gfx] [CI 09/12] drm/i915: Perform manual conversions for plane uapi/hw split

2019-10-29 Thread Maarten Lankhorst
get_crtc_from_states() is called before plane_state is copied to uapi, so use the uapi state there. intel_legacy_cursor_update() could probably get away with looking at the hw state, but for clarity look at the uapi state always Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/

[Intel-gfx] [CI 12/12] drm/i915: Complete plane hw and uapi split, v2.

2019-10-29 Thread Maarten Lankhorst
Splitting plane state is easier than splitting crtc_state, before plane check we copy the drm properties to hw so we can do the same in bigjoiner later on. We copy the state after we did all the modeset handling, but fortunately i915 seems to be split correctly and nothing during modeset looks at

Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-29 Thread Zhu Lingshan
On 10/23/2019 9:07 PM, Jason Wang wrote: This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Signed-off-by: Jason Wang --- drivers/vfio/mdev/mdev_core.c| 20 drivers/vfio/mdev/mdev_private.h | 2 + include/linux/mdev.h

Re: [Intel-gfx] [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

2019-10-29 Thread Jonathan Corbet
On Tue, 29 Oct 2019 08:31:22 +0800 Changbin Du wrote: > Here python is different from C. Both empty string and None are False in > python. > Note such condition is common in python. Treating both as a False value is reasonably common. Treating them elsewhere in the same code block as separate

[Intel-gfx] [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID

2019-10-29 Thread Lee Shawn C
commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)' introduced new PCI ID that CML support. But some PCI IDs were removed from CML IDs in BSpec. v2: remove some inaccurate descriptions. v3: fix typo. v4: add missing version number. v5: no update. v6: update patch comment. Cc: Rodrigo Vivi Cc:

[Intel-gfx] [PATCH v6 2/2] drm/i915/cml: Separate U series pci id from origianl list.

2019-10-29 Thread Lee Shawn C
U series device need different DDI buffer setup for eDP and DP. If driver did not recognize ULT id proerply. The setting for H and S series would be used. v2: add missing comma in subplatform_ult_ids[]. v3: no update. v4: no update. v5: no update. v6: no update. Cc: Rodrigo Vivi Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. URL : https://patchwork.freedesktop.org/series/68694/ State : warning == Summary == $ dim checkpatch origin/drm-tip 874fbe7ef3ea drm/i915: Introduce intel_atomic_ge

Re: [Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum

2019-10-29 Thread Joonas Lahtinen
Quoting Jani Nikula (2019-10-28 12:38:20) > Mostly for improved documentation, convert the debug category macros > into an enum. Drop unused DRM_UT_NONE. Document previously undocumented > categories. > > Signed-off-by: Jani Nikula > +enum drm_debug_category { > + /** > +* @DRM_U

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2. URL : https://patchwork.freedesktop.org/series/68694/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7208 -> Patchwork_15042 ===

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB- >BDW sprites > >From: Ville Syrjälä > >SNB-BDW support 10:10:10

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle URL : https://patchwork.freedesktop.org/series/68644/ State : success == Summary == CI Bug Log - changes from CI_DRM_7201_full -> Patchwork_15019_full

[Intel-gfx] [PATCH] drm/i915/gt: Make timeslice duration configurable

2019-10-29 Thread Chris Wilson
Execlists uses a scheduling quantum (a timeslice) to alternate execution between ready-to-run contexts of equal priority. This ensures that all users (though only if they of equal importance) have the opportunity to run and prevents livelocks where contexts may have implicit ordering due to userspa

Re: [Intel-gfx] [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

2019-10-29 Thread Changbin Du
On Mon, Oct 28, 2019 at 11:24:22AM +0200, Jani Nikula wrote: > On Fri, 25 Oct 2019, Changbin Du wrote: > > On Fri, Oct 25, 2019 at 09:57:48AM +0300, Jani Nikula wrote: > >> On Thu, 24 Oct 2019, Jonathan Corbet wrote: > >> > On Sun, 20 Oct 2019 21:17:17 +0800 > >> > Changbin Du wrote: > >> > > >>

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-29 Thread Val Kulkov
On Mon, 28 Oct 2019 at 14:16, Imre Deak wrote: > > For the HPD interrupt functionality the HW depends on power wells in the > display core domain to be on. Accordingly when enabling these power > wells the HPD polling logic will force an HPD detection cycle to account > for hotplug events that may

Re: [Intel-gfx] [RFC 0/3] Display uncore

2019-10-29 Thread Jani Nikula
On Wed, 07 Aug 2019, Daniele Ceraolo Spurio wrote: > I've been trying to identify MMIO ranges to clearly define what belongs > to display_uncore to do a check on access, but there are lots of > exceptions and differences across gens (with a few more coming with TGL), > so I don't think that's a v

Re: [Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum

2019-10-29 Thread Jani Nikula
On Tue, 29 Oct 2019, Joonas Lahtinen wrote: > Quoting Jani Nikula (2019-10-28 12:38:20) >> Mostly for improved documentation, convert the debug category macros >> into an enum. Drop unused DRM_UT_NONE. Document previously undocumented >> categories. >> >> Signed-off-by: Jani Nikula > > > >> +en

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v6,1/2] drm/i915/cml: Remove unsupport PCI ID

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [v6,1/2] drm/i915/cml: Remove unsupport PCI ID URL : https://patchwork.freedesktop.org/series/68698/ State : failure == Summary == Applying: drm/i915/cml: Remove unsupport PCI ID Applying: drm/i915/cml: Separate U series pci id from origianl li

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Make timeslice duration configurable

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/gt: Make timeslice duration configurable URL : https://patchwork.freedesktop.org/series/68701/ State : success == Summary == CI Bug Log - changes from CI_DRM_7208 -> Patchwork_15044 Summary --- *

[Intel-gfx] [PATCH 5/7] drm/i915: Don't try to place HWS in non-existing mappable region

2019-10-29 Thread Matthew Auld
From: Michal Wajdeczko HWS placement restrictions can't just rely on HAS_LLC flag. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Matthew Auld
Since we have no way access it from the CPU. For such cases just fallback to internal objects. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 4/7] drm/i915: error capture with no ggtt slot

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio If the aperture is not available in HW we can't use a ggtt slot and wc copy, so fall back to regular kmap. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 19 dr

[Intel-gfx] [PATCH 2/7] drm/i915: do not map aperture if it is not available.

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio Skip both setup and cleanup of the aperture mapping if the HW doesn't have an aperture bar. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 31 ++--- 1 file changed, 19 insertions(

[Intel-gfx] [PATCH 1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio The following patches in the series will use it to avoid certain operations when the mappable aperture is not available in HW. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.h | 5 + 1 file changed, 5 in

[Intel-gfx] [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio We can't fence anything without aperture. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Stuart Summers Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 7/7] drm/i915/selftests: check for missing aperture

2019-10-29 Thread Matthew Auld
We may be missing support for the mappable aperture on some platforms. Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio --- .../drm/i915/gem/selftests/i915_gem_coherency.c| 5 - drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 6 ++ drivers/gpu/drm/i915/gt/selftest_hangc

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Expose alpha formats on VLV/CHV primary planes

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 2/9] drm/i915: Expose alpha formats on VLV/CHV >primary >planes > >From: Ville Syrjälä > >Currently we expose VLV/

Re: [Intel-gfx] [PATCH 1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:50) > From: Daniele Ceraolo Spurio > > The following patches in the series will use it to avoid certain > operations when the mappable aperture is not available in HW. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matthew Auld Reviewed-by: Ch

Re: [Intel-gfx] [PATCH 2/7] drm/i915: do not map aperture if it is not available.

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:51) > From: Daniele Ceraolo Spurio > > Skip both setup and cleanup of the aperture mapping if the HW doesn't > have an aperture bar. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 31

Re: [Intel-gfx] [PATCH] drm/i915/dp: Do not switch aux to TBT mode for non-TC ports

2019-10-29 Thread Imre Deak
On Mon, Oct 28, 2019 at 06:10:14PM -0700, José Roberto de Souza wrote: > Non-TC ports always have tc_mode == TC_PORT_TBT_ALT so it was > switching aux to TC mode for all combo-phy ports, happily this did > not caused any issue but is better follow BSpec. > Also this is reserved bit before ICL. > >

Re: [Intel-gfx] [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:52) > From: Daniele Ceraolo Spurio > > We can't fence anything without aperture. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Stuart Summers > Signed-off-by: Matthew Auld Neat. Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 4/7] drm/i915: error capture with no ggtt slot

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:53) > From: Daniele Ceraolo Spurio > > If the aperture is not available in HW we can't use a ggtt slot and wc > copy, so fall back to regular kmap. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Abdiel Janulgue > Signed-off-by: Matthew Auld >

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Don't try to place HWS in non-existing mappable region

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:54) > From: Michal Wajdeczko > > HWS placement restrictions can't just rely on HAS_LLC flag. > > Signed-off-by: Michal Wajdeczko > Signed-off-by: Matthew Auld > Cc: Daniele Ceraolo Spurio > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > 1 fil

Re: [Intel-gfx] [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:55) > Since we have no way access it from the CPU. For such cases just > fallback to internal objects. > > Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.fr

Re: [Intel-gfx] [PATCH 7/7] drm/i915/selftests: check for missing aperture

2019-10-29 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 09:58:56) > We may be missing support for the mappable aperture on some platforms. > > Signed-off-by: Matthew Auld > Cc: Daniele Ceraolo Spurio > --- > .../drm/i915/gem/selftests/i915_gem_coherency.c| 5 - > drivers/gpu/drm/i915/gem/selftests/i915_gem_m

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/6] drm/i915: Fix i845/i865 cursor width

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Fix i845/i865 cursor width URL : https://patchwork.freedesktop.org/series/68646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7201_full -> Patchwork_15021_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture URL : https://patchwork.freedesktop.org/series/68705/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6d8f88fa8405 drm/i915: define i915_ggtt_has_aperture d802efde66e4 drm/i915: do not

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Check a few more fixed locations within the context image (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check a few more fixed locations within the context image (rev2) URL : https://patchwork.freedesktop.org/series/68611/ State : success == Summary == CI Bug Log - changes from CI_DRM_7201_full -> Patchwork_15022_full

[Intel-gfx] [RESEND PATCH i-g-t v2 1/1] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Janusz Krzysztofik
Name of the i915 module parameter providing fault injection function is changing for consistency with a new convention of naming i915 driver internal functions called from the driver PCI .probe entry point. Adjust the test to use the new name. Suggested-by: Joonas Lahtinen Signed-off-by: Janusz

[Intel-gfx] [RESEND PATCH i-g-t v2 0/1] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Janusz Krzysztofik
Name of the i915 module parameter providing fault injection function is changing for consistency with a new convention of naming i915 driver internal functions called from the driver PCI .probe entry point. Adjust the test to use the new name. v2: * add R-b (thanks Chris), * add cover letter

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture URL : https://patchwork.freedesktop.org/series/68705/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: define i915_ggtt_has_aperture Okay! Commit:

[Intel-gfx] [RESUBMIT PATCH v2 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-29 Thread Janusz Krzysztofik
Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently") deliberately left the name of the module parameter unchanged as that would require a corresponding change on IGT size. Now as the IGT side change has been submitted, complete the switch to the "probe" nomenclature. Sugges

[Intel-gfx] [RESUBMIT PATCH v2 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-29 Thread Janusz Krzysztofik
Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") introduced new functions unfortunately named incompatibly with rules established by commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently"). Fix it for consistency. Suggested-by: Michał Wajdeczko Signed-

[Intel-gfx] [RESUBMIT PATCH v2 0/2] drm/i915: Conclude load -> probe naming convention switch

2019-10-29 Thread Janusz Krzysztofik
Test-with: <20191029101751.5848-2-janusz.krzyszto...@linux.intel.com> The purpose is: * to fix incompatible names of new functions introduced meanwhile, * to complete postponed rename of module parameter. v2: * drop unnecessary statement about custom user applications from commit message of

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2) URL : https://patchwork.freedesktop.org/series/68644/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7205 -> Patchwork_15031 S

[Intel-gfx] [PATCH v2 7/7] drm/i915/selftests: check for missing aperture

2019-10-29 Thread Matthew Auld
We may be missing support for the mappable aperture on some platforms. Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson --- .../drm/i915/gem/selftests/i915_gem_coherency.c| 7 ++- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 6 ++ drivers/g

[Intel-gfx] [PATCH v2 1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio The following patches in the series will use it to avoid certain operations when the mappable aperture is not available in HW. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.h | 5

[Intel-gfx] [PATCH v2 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

2019-10-29 Thread Matthew Auld
Since we have no way access it from the CPU. For such cases just fallback to internal objects. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring

[Intel-gfx] [PATCH v2 2/7] drm/i915: do not map aperture if it is not available.

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio Skip both setup and cleanup of the aperture mapping if the HW doesn't have an aperture bar. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 31 ++--- 1 f

[Intel-gfx] [PATCH v2 4/7] drm/i915: error capture with no ggtt slot

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio If the aperture is not available in HW we can't use a ggtt slot and wc copy, so fall back to regular kmap. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Abdiel Janulgue Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_ge

[Intel-gfx] [PATCH v2 5/7] drm/i915: Don't try to place HWS in non-existing mappable region

2019-10-29 Thread Matthew Auld
From: Michal Wajdeczko HWS placement restrictions can't just rely on HAS_LLC flag. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Auld Cc: Daniele Ceraolo Spurio Acked-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[Intel-gfx] [PATCH v2 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

2019-10-29 Thread Matthew Auld
From: Daniele Ceraolo Spurio We can't fence anything without aperture. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Stuart Summers Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 -- 1 file changed, 4 insertions(+), 2 delet

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Expose C8 on VLV/CHV sprite planes

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 4/9] drm/i915: Expose C8 on VLV/CHV sprite planes > >From: Ville Syrjälä > >VLV/CHV sprite planes also support the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture URL : https://patchwork.freedesktop.org/series/68705/ State : success == Summary == CI Bug Log - changes from CI_DRM_7208 -> Patchwork_15045 Sum

[Intel-gfx] [PATCH] drm/i915/display: only include intel_dp_link_training.h where needed

2019-10-29 Thread Jani Nikula
The intel_dp_link_training.h include has no need or place in intel_display.h. Include it in intel_display.c instead. Cc: Cc: Manasi Navare Fixes: eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync") Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_di

Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-29 Thread Jason Wang
On 2019/10/29 下午3:42, Zhu Lingshan wrote: >> >> +    void (*set_status)(struct mdev_device *mdev, u8 status); > > Hi Jason > > Is it possible to make set_status() return an u8 or bool, because this > may fail in real hardware. Without a returned code, I am not sure  > whether it is a good idea to

[Intel-gfx] [RFC 2/2] drm/i915/audio: replace I915_*() calls with the new intel_de_*() calls

2019-10-29 Thread Jani Nikula
Not for merging, for demo only. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 113 +++-- 1 file changed, 59 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 85

[Intel-gfx] [RFC 1/2] drm/i915: add display uncore helpers

2019-10-29 Thread Jani Nikula
Add convenience helpers for the most common uncore operations with struct drm_i915_private * as context rather than struct intel_uncore *. The goal is to replace all instances of I915_READ(), I915_POSTING_READ(), and I915_WRITE() in display/ with these, to finally be able to get rid of the implici

Re: [Intel-gfx] [PATCH] drm/i915/display: only include intel_dp_link_training.h where needed

2019-10-29 Thread Jani Nikula
On Tue, 29 Oct 2019, Jani Nikula wrote: > The intel_dp_link_training.h include has no need or place in > intel_display.h. Include it in intel_display.c instead. > > Cc: Whoops, obviously to be removed before merging. BR, Jani. > > Cc: Manasi Navare > Fixes: eadf6f9170d5 ("drm/i915/display/icl:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Conclude load -> probe naming convention switch (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915: Conclude load -> probe naming convention switch (rev2) URL : https://patchwork.freedesktop.org/series/67454/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2fff720f7c40 drm/i915: Fix i915_inject_load_error() name to read *_probe_* -:11: ERR

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Add missing 10bpc formats for pipe B sprites on CHV

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 3/9] drm/i915: Add missing 10bpc formats for pipe B >sprites on CHV > >From: Ville Syrjälä > >CHV pipe B sprites ga

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915: Add 10bpc formats with alpha for icl+

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Wednesday, October 9, 2019 4:14 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH v2 5/9] drm/i915: Add 10bpc formats with alpha for >icl+ > >From: Ville Syrjälä > >ICL+ again supports alpha ble

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Sort format arrays consistently

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 6/9] drm/i915: Sort format arrays consistently > >From: Ville Syrjälä > >Let's try to keep the pixel format arrays

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v2,1/7] drm/i915: define i915_ggtt_has_aperture

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915: define i915_ggtt_has_aperture URL : https://patchwork.freedesktop.org/series/68710/ State : failure == Summary == Applying: drm/i915: define i915_ggtt_has_aperture Using index info to reconstruct a base tree... M driver

Re: [Intel-gfx] [PATCH] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

2019-10-29 Thread Michal Wajdeczko
On Mon, 28 Oct 2019 22:25:27 +0100, wrote: From: Don Hiatt On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. We can remove the Gu

Re: [Intel-gfx] [RESEND PATCH i-g-t v2 1/1] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-29 10:17:51) > Name of the i915 module parameter providing fault injection function is > changing for consistency with a new convention of naming i915 driver > internal functions called from the driver PCI .probe entry point. Adjust > the test to use the new nam

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: only include intel_dp_link_training.h where needed

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/display: only include intel_dp_link_training.h where needed URL : https://patchwork.freedesktop.org/series/68711/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1b222834c572 drm/i915/display: only include intel_dp_link_training.h where need

[Intel-gfx] [PATCH i-g-t] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Chris Wilson
From: Janusz Krzysztofik Name of the i915 module parameter providing fault injection function is changing for consistency with a new convention of naming i915 driver internal functions called from the driver PCI .probe entry point. Adjust the test to use the new name. [ickle: keep the old param

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2) URL : https://patchwork.freedesktop.org/series/68644/ State : success == Summary == CI Bug Log - changes from CI_DRM_7205 -> Patchwork_15031 S

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+ > >From: Ville Syrjälä > >According to the spec color keying is not support

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Simply walk back along request timeline on reset (rev6)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Simply walk back along request timeline on reset (rev6) URL : https://patchwork.freedesktop.org/series/68601/ State : success == Summary == CI Bug Log - changes from CI_DRM_7203_full -> Patchwork_15023_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Initialise ret

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Initialise ret URL : https://patchwork.freedesktop.org/series/68662/ State : success == Summary == CI Bug Log - changes from CI_DRM_7203_full -> Patchwork_15025_full

Re: [Intel-gfx] [PATCH] drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA

2019-10-29 Thread Animesh Manna
On 10/25/2019 8:52 PM, Animesh Manna wrote: On 10/17/2019 9:28 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It sounds like the hardware only needs the DSB object to be in global GTT and not in the mappable region. Currently tested and working without any regression, waiting for confi

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Do not enable HDR mode when color keying is active

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 8/9] drm/i915: Do not enable HDR mode when color >keying is active > >From: Ville Syrjälä > >The spec says that col

[Intel-gfx] [PATCH] drm/i915: Nuke 'mode' argument to intel_get_load_detect_pipe()

2019-10-29 Thread Ville Syrjala
From: Ville Syrjälä We always pass mode==NULL to intel_get_load_detect_pipe(). Remove the pointless function argument. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crt.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 7 ++- drivers/gpu/drm/i915/display/in

Re: [Intel-gfx] [CI 04/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-29 Thread Ville Syrjälä
On Tue, Oct 29, 2019 at 08:22:21AM +0100, Maarten Lankhorst wrote: > intel_get_load_detect_pipe() needs to set uapi active, > uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), > so we can remove it. > > intel_pipe_config_compare() needs to look at hw state, but I didn't > change sp

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Eliminate redundancy in intel_primary_plane_create()

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx On Behalf Of Ville >Syrjala >Sent: Tuesday, October 8, 2019 9:45 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 9/9] drm/i915: Eliminate redundancy in >intel_primary_plane_create() > >From: Ville Syrjälä > >Lots of redundant as

Re: [Intel-gfx] [PATCH] drm/dp: Increase link status size

2019-10-29 Thread Jani Nikula
On Tue, 29 Oct 2019, Thierry Reding wrote: > From: Thierry Reding > > The current link status contains bytes 0x202 through 0x207, but we also > want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) > so that the post-cursor adjustment can be queried during link training. We don

Re: [Intel-gfx] [PATCH i-g-t] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Janusz Krzysztofik
Hi Chris, On Tuesday, October 29, 2019 1:49:26 PM CET Chris Wilson wrote: > From: Janusz Krzysztofik > > Name of the i915 module parameter providing fault injection function is > changing for consistency with a new convention of naming i915 driver > internal functions called from the driver PCI

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+

2019-10-29 Thread Shankar, Uma
>-Original Message- >From: Shankar, Uma >Sent: Tuesday, October 29, 2019 6:38 PM >To: Ville Syrjala ; >intel-gfx@lists.freedesktop.org >Subject: RE: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+ > > > >>-Original Message- >>From: Intel-gfx On Behalf Of >>Ville Syrja

Re: [Intel-gfx] [PATCH i-g-t] tests/i915_module_load: Use new name of fault injection module parameter

2019-10-29 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-29 13:35:48) > > diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c > > index f42083f53..7d9a5cfd2 100644 > > --- a/tests/i915/i915_module_load.c > > +++ b/tests/i915/i915_module_load.c > > @@ -350,11 +350,17 @@ igt_main > > } > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/print: cleanup and new drm_device based logging (rev3)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/print: cleanup and new drm_device based logging (rev3) URL : https://patchwork.freedesktop.org/series/67795/ State : success == Summary == CI Bug Log - changes from CI_DRM_7204_full -> Patchwork_15026_full S

[Intel-gfx] [RESEND PATCH] drm/dp: Increase link status size

2019-10-29 Thread Thierry Reding
From: Thierry Reding The current link status contains bytes 0x202 through 0x207, but we also want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) so that the post-cursor adjustment can be queried during link training. Reported-by: coverity-bot Addresses-Coverity-ID: 1487366 (

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/5] drm/dsi: clean up DSI data type definitions

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/dsi: clean up DSI data type definitions URL : https://patchwork.freedesktop.org/series/68664/ State : success == Summary == CI Bug Log - changes from CI_DRM_7204_full -> Patchwork_15027_full ===

Re: [Intel-gfx] [PATCH] drm/dp: Increase link status size

2019-10-29 Thread Thierry Reding
On Tue, Oct 29, 2019 at 03:32:41PM +0200, Jani Nikula wrote: > On Tue, 29 Oct 2019, Thierry Reding wrote: > > From: Thierry Reding > > > > The current link status contains bytes 0x202 through 0x207, but we also > > want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) > > so tha

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Use vfunc to check engine submission mode (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Use vfunc to check engine submission mode (rev2) URL : https://patchwork.freedesktop.org/series/68654/ State : success == Summary == CI Bug Log - changes from CI_DRM_7204_full -> Patchwork_15029_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: add support to one DP-MST stream

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915/tgl: add support to one DP-MST stream URL : https://patchwork.freedesktop.org/series/68671/ State : success == Summary == CI Bug Log - changes from CI_DRM_7204_full -> Patchwork_15030_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Conclude load -> probe naming convention switch (rev2)

2019-10-29 Thread Patchwork
== Series Details == Series: drm/i915: Conclude load -> probe naming convention switch (rev2) URL : https://patchwork.freedesktop.org/series/67454/ State : success == Summary == CI Bug Log - changes from CI_DRM_7209 -> Patchwork_15046 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/2] drm/i915: add display uncore helpers

2019-10-29 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: add display uncore helpers URL : https://patchwork.freedesktop.org/series/68713/ State : warning == Summary == $ dim checkpatch origin/drm-tip dfb3731d13b1 drm/i915: add display uncore helpers -:28: WARNING:FILE_PATH_CHANGES

[Intel-gfx] [PATCH] drm/i915/perf: ensure selftests select valid format

2019-10-29 Thread Lionel Landwerlin
Gen12 only support a single report format : I915_OA_FORMAT_A32u40_A4u32_B8_C8 Signed-off-by: Lionel Landwerlin Fixes: 00a7f0d7155c ("drm/i915/tgl: Add perf support on TGL") --- drivers/gpu/drm/i915/selftests/i915_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

Re: [Intel-gfx] [CI 07/12] drm/i915: Complete crtc hw/uapi split, v4.

2019-10-29 Thread Ville Syrjälä
On Tue, Oct 29, 2019 at 08:22:24AM +0100, Maarten Lankhorst wrote: > Now that we separated everything into uapi and hw, it's > time to make the split definitive. Remove the union and > make a copy of the hw state on modeset and fastset. > > Color blobs are copied in crtc atomic_check(), right > be

  1   2   3   >