Re: [Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-28 Thread Pekka Paalanen
On Fri, 25 Oct 2019 21:03:12 +0200 Daniel Vetter wrote: > On Fri, Oct 25, 2019 at 1:36 PM Thierry Reding > wrote: > > > > On Thu, Oct 24, 2019 at 01:45:16PM -0700, Rajat Jain wrote: > > > Hi, > > > > > > Thanks for your review and comments. Please see inline below. > > > > > > On Thu, Oct 24,

[Intel-gfx] [PATCH v6 1/2] drm/i915/cml: Remove unsupport PCI ID

2019-10-28 Thread Lee Shawn C
commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)' introduced new PCI ID that CML support. But some PCI IDs were removed from CML IDs in BSpec. v2: remove some inaccurate descriptions. v3: fix typo. v4: add missing version number. v5: no update. v6: update patch comment. Cc: Rodrigo Vivi Cc:

[Intel-gfx] [PATCH v6 2/2] drm/i915/cml: Separate U series pci id from origianl list.

2019-10-28 Thread Lee Shawn C
U series device need different DDI buffer setup for eDP and DP. If driver did not recognize ULT id proerply. The setting for H and S series would be used. v2: add missing comma in subplatform_ult_ids[]. v3: no update. v4: no update. v5: no update. v6: no update. Cc: Rodrigo Vivi Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/execlists: Simply walk back along request timeline on reset (rev3)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Simply walk back along request timeline on reset (rev3) URL : https://patchwork.freedesktop.org/series/68601/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7193_full -> Patchwork_15004_full =

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Complete crtc hw/uapi split, v3.

2019-10-28 Thread Maarten Lankhorst
Op 25-10-2019 om 12:13 schreef Ville Syrjälä: > On Fri, Oct 25, 2019 at 11:00:06AM +0200, Maarten Lankhorst wrote: >> Op 24-10-2019 om 17:21 schreef Ville Syrjälä: >>> On Thu, Oct 24, 2019 at 02:47:59PM +0200, Maarten Lankhorst wrote: Now that we separated everything into uapi and hw, it's >>>

Re: [Intel-gfx] [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

2019-10-28 Thread Jani Nikula
On Fri, 25 Oct 2019, Changbin Du wrote: > On Fri, Oct 25, 2019 at 09:57:48AM +0300, Jani Nikula wrote: >> On Thu, 24 Oct 2019, Jonathan Corbet wrote: >> > On Sun, 20 Oct 2019 21:17:17 +0800 >> > Changbin Du wrote: >> > >> >> The 'functions' directive is not only for functions, but also works for

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v6,2/2] drm/i915/cml: Separate U series pci id from origianl list. (rev7)

2019-10-28 Thread Patchwork
== Series Details == Series: series starting with [v6,2/2] drm/i915/cml: Separate U series pci id from origianl list. (rev7) URL : https://patchwork.freedesktop.org/series/68547/ State : failure == Summary == Applying: drm/i915/cml: Separate U series pci id from origianl list. error: sha1 inf

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps URL : https://patchwork.freedesktop.org/series/68604/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7193_full -> Patchwork_15005_full

[Intel-gfx] [RFC PATCH drm-intel] drm/i915: r8712_construct_txaggr_cmd_desc() can be static

2019-10-28 Thread kbuild test robot
Fixes: d9d54a530a70 ("drm/i915: Put future HW and their uAPIs under STAGING & BROKEN") Signed-off-by: kbuild test robot --- rtl8712_xmit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_x

[Intel-gfx] [PATCH RESEND 0/8] drm/print: cleanup and new drm_device based logging

2019-10-28 Thread Jani Nikula
Resend of [1]; I may have rebased but I'm not sure anymore... For starters some fairly benign cleanup, and a proposal for new struct drm_device based drm logging macros analoguous to core kernel struct device based macros. Please let's at least get the first 7 reviewed/acked/merged, shall we? B

[Intel-gfx] [PATCH RESEND 1/8] drm/i915: use drm_debug_enabled() to check for debug categories

2019-10-28 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Reviewed-by: Eric Engestrom Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH RESEND 2/8] drm/nouveau: use drm_debug_enabled() to check for debug categories

2019-10-28 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. v2: move unlikely() to drm_debug_enabled() Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/n

[Intel-gfx] [PATCH RESEND 5/8] drm/print: underscore prefix functions that should be private to print

2019-10-28 Thread Jani Nikula
We don't want people calling the functions directly. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8 include/drm/drm_print.h | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_prin

[Intel-gfx] [PATCH RESEND 8/8] drm/print: introduce new struct drm_device based logging macros

2019-10-28 Thread Jani Nikula
Add new struct drm_device based logging macros modeled after the core kernel device based logging macros. These would be preferred over the drm printk and struct device based macros in drm code, where possible. We have existing drm specific struct device based logging functions, but they are too v

[Intel-gfx] [PATCH RESEND 7/8] drm/print: group logging functions by prink or device based

2019-10-28 Thread Jani Nikula
In preparation for adding struct drm_device based logging, group the existing functions by prink or struct device based logging. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 135 ++-- 1 file changed, 74 insertions(+), 61 dele

[Intel-gfx] [PATCH RESEND 4/8] drm/print: rename drm_debug to __drm_debug to discourage use

2019-10-28 Thread Jani Nikula
drm_debug_enabled() is the way to check. __drm_debug is now reserved for drm print code only. No functional changes. v2: Rebase on move unlikely() to drm_debug_enabled() Acked-by: Alex Deucher Reviewed-by: Eric Engestrom Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8

[Intel-gfx] [PATCH RESEND 3/8] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-10-28 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-...@lists.freedesktop.org Acked-by: Alex Deucher Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c |

[Intel-gfx] [PATCH RESEND 6/8] drm/print: convert debug category macros into an enum

2019-10-28 Thread Jani Nikula
Mostly for improved documentation, convert the debug category macros into an enum. Drop unused DRM_UT_NONE. Document previously undocumented categories. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 4 +- include/drm/drm_print.h | 101 ++-- 2

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Restore i915.reset before testing it in igt_allow_hang()

2019-10-28 Thread Ville Syrjälä
On Thu, Oct 24, 2019 at 04:34:16PM +0100, Chris Wilson wrote: > igt_allow_hang() checks that the GPU can be reset before allowing the > test to cause a GPU hang (which would need the reset to recover). > However, our checking for allowing a hang depends on i915.reset which we > later restore. Do th

[Intel-gfx] [PATCH] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Imre Deak
For the HPD interrupt functionality the HW depends on power wells in the display core domain to be on. Accordingly when enabling these power wells the HPD polling logic will force an HPD detection cycle to account for hotplug events that may have happened when such a power well was off. Thus a det

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Split memory_region initialisation into its own file (rev2)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915: Split memory_region initialisation into its own file (rev2) URL : https://patchwork.freedesktop.org/series/68200/ State : success == Summary == CI Bug Log - changes from CI_DRM_7193_full -> Patchwork_15006_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Measure basic throughput of blit routines

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 14:36, Chris Wilson wrote: > > We need to verify that our blitter routines perform as expected, so > measure it. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@l

Re: [Intel-gfx] [PATCH 1/5] drm/i915/selftests: Drop global engine lookup for gt selftests

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 22:58, Chris Wilson wrote: > > As we are inside the gt, we have a local gt->engine[] lookup we should > be using in preference over the i915->engine[] copy. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx

Re: [Intel-gfx] [PATCH 3/5] drm/i915/selftests: Check all blitter engines for client blt

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 22:58, Chris Wilson wrote: > > Check all user accessible engines that can blit work with our blitter > client. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org h

[Intel-gfx] [CI] drm/i915/selftests: Measure basic throughput of blit routines

2019-10-28 Thread Chris Wilson
We need to verify that our blitter routines perform as expected, so measure it. Signed-off-by: Chris Wilson Cc: Matthew Auld Reviewed-by: Matthew Auld --- .../i915/gem/selftests/i915_gem_object_blt.c | 172 ++ 1 file changed, 172 insertions(+) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 2/6] drm/i915: Fix max cursor size for i915g/gm

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä Apparently the 128x128 and 256x256 ARGB cursor modes were only added on LPT/CST. While the display section of bspec isn't super clear on the subject, it does highlight these two modes in a different color, has a few changlog entries indicating the 256x256 mode was added for a

[Intel-gfx] [PATCH 6/6] drm/i915: Protect overlay colorkey macro arguments

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä Put the customary () around the macro argument in the overlay colorkey macros. And while at switch to using a consistent case for the hex constants. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_overlay.c | 8 1 file changed, 4 insertions(+),

[Intel-gfx] [PATCH 3/6] drm/i915: Fix overlay colorkey for 30bpp and 8bpp

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä As with the video sprites the colorkey is always specified as 8bpc. For 10bpc primary plane formats we just ignore the two lsbs of each component. For C8 we'll replicate the same key to each chanel, which is what the hardware wants. Signed-off-by: Ville Syrjälä --- drivers/

[Intel-gfx] [PATCH 4/6] drm/i915: Configure overlay cc_out precision based on crtc gamma config

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä Put the overlay color conversion unit into 10bit mode if the pipe isn't using the 8bit legacy gamma. Not 100% sure this is what the intention of the bit was but makes at least some sense to me. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_overlay.c |

[Intel-gfx] [PATCH 5/6] drm/i915: Enable pipe gamma for the overlay

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä We pass the plane data through the pipe gamma for all the other planes. Can't see why we should treat the overlay differently, so let's enable pipe gamma for it as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_overlay.c | 2 ++ 1 file changed, 2

[Intel-gfx] [PATCH 1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä The change from the uapi coordinates to the internal coordinates broke the cursor on i845/i865 due to src and dst getting swapped. Fix it. Cc: Maarten Lankhorst Fixes: 3a612765f423 ("drm/i915: Remove cursor use of properties for coordinates") Signed-off-by: Ville Syrjälä -

Re: [Intel-gfx] [PATCH 4/5] drm/i915/selftests: Use a random engine for GEM coherency tests

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 22:58, Chris Wilson wrote: > > Select a random user accessible engine for checking coherency results. > While we should check all engines, we use a random selection so that > over repeated runs we cover all. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: add compression parameter block definition (rev2)

2019-10-28 Thread Jani Nikula
On Fri, 25 Oct 2019, Patchwork wrote: > == Series Details == > > Series: drm/i915/bios: add compression parameter block definition (rev2) > URL : https://patchwork.freedesktop.org/series/68396/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7169_full -> Patchwork_14961_

Re: [Intel-gfx] [PATCH 5/5] drm/i915/selftests: Select a random engine for testing memory regions

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 22:58, Chris Wilson wrote: > > Use any blitter engine at random for prefilling the memory region. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.

Re: [Intel-gfx] [PATCH] drm/i915/gt: Tidy up rps irq handler to use intel_gt

2019-10-28 Thread Andi Shyti
Hi Chris, On Sun, Oct 27, 2019 at 05:55:05PM +, Chris Wilson wrote: > Since the rps is tied to its intel_gt, use that backpointer to find the > right engine rather than delving into i915. > > Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH 2/5] drm/i915/selftests: Exercise adjusting rpcs over all render-class engines

2019-10-28 Thread Matthew Auld
On Sun, 27 Oct 2019 at 22:58, Chris Wilson wrote: > > Iterate over all user-accessible render engines when checking whether > they can be adjusted for sseu. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Adjust the location of RING_MI_MODE in the context image

2019-10-28 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-10-26 11:22:20) > The location of RING_MI_MODE (used to stop the ring across resets) moved > for Tigerlake. Fixup the new location and include a selftest to verify > the location in the default context image. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Reviewe

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Check a few more fixed locations within the context image

2019-10-28 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-10-27 17:03:13) > As we use hard coded offsets for a few locations within the context > image, include those in the selftests to assert that they are valid. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -3194

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Check a few more fixed locations within the context image

2019-10-28 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-10-28 12:13:05) > Quoting Chris Wilson (2019-10-27 17:03:13) > > As we use hard coded offsets for a few locations within the context > > image, include those in the selftests to assert that they are valid. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala >

[Intel-gfx] [CI] drm/i915/selftests: Check a few more fixed locations within the context image

2019-10-28 Thread Chris Wilson
As we use hard coded offsets for a few locations within the context image, include those in the selftests to assert that they are valid. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 27 +- 1 file

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Simply walk back along request timeline on reset

2019-10-28 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-10-27 13:13:09) > The request's timeline will only contain requests from this context, in > order of execution. Therefore, we can simply look back along this > timeline to find the currently executing request. > > If we do find that the current context has completed its

[Intel-gfx] [CI] drm/i915/execlists: Simply walk back along request timeline on reset

2019-10-28 Thread Chris Wilson
The request's timeline will only contain requests from this context, in order of execution. Therefore, we can simply look back along this timeline to find the currently executing request. If we do find that the current context has completed its last request, that does not imply that all requests a

[Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Michal Wajdeczko
While processing CSB there is no need to look at GuC submission settings, just check if engine is configured for execlists mode. While today GuC submission is disabled it's settings are still based on modparam values that might not correctly reflect actual submission status in case of any fallback

Re: [Intel-gfx] [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace()

2019-10-28 Thread Joonas Lahtinen
Quoting paul...@kernel.org (2019-10-22 22:12:08) > From: "Paul E. McKenney" > > This commit replaces the use of rcu_swap_protected() with the more > intuitively appealing rcu_replace() as a step towards removing > rcu_swap_protected(). > > Link: > https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFE

[Intel-gfx] [PATCH xf86-video-intel] sna/video/overlay: Declare support for depth 8 and 30

2019-10-28 Thread Ville Syrjala
From: Ville Syrjälä Add 8 and 30 to the list of supported screen depths. The colorkey massaging will be handled by the kernel so we don't have to worry about it unlike with the sprite colorkey uapi. Signed-off-by: Ville Syrjälä --- src/sna/sna_video_overlay.c | 2 ++ 1 file changed, 2 insertio

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-10-28 12:57:03) > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h > b/drivers/gpu/drm/i915/gt/intel_lrc.h > index 99dc576a4e25..23dde9083349 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.h > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.h > @@ -145,4 +145,6 @@ struct i

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Janusz Krzysztofik
Hi Michał, On Monday, October 28, 2019 1:57:03 PM CET Michal Wajdeczko wrote: > While processing CSB there is no need to look at GuC submission > settings, just check if engine is configured for execlists mode. > > While today GuC submission is disabled it's settings are still > based on modparam

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Simply walk back along request timeline on reset (rev5)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Simply walk back along request timeline on reset (rev5) URL : https://patchwork.freedesktop.org/series/68601/ State : success == Summary == CI Bug Log - changes from CI_DRM_7194_full -> Patchwork_15008_full =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging (rev2)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/print: cleanup and new drm_device based logging (rev2) URL : https://patchwork.freedesktop.org/series/67795/ State : warning == Summary == $ dim checkpatch origin/drm-tip f2d563f17142 drm/i915: use drm_debug_enabled() to check for debug categories 528222fb93b9

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/print: cleanup and new drm_device based logging (rev2)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/print: cleanup and new drm_device based logging (rev2) URL : https://patchwork.freedesktop.org/series/67795/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7201 -> Patchwork_15018 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle URL : https://patchwork.freedesktop.org/series/68644/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4e80a212b380 drm/i915: Avoid HPD poll detect triggering a new detect cycle -:29: ERROR:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle URL : https://patchwork.freedesktop.org/series/68644/ State : success == Summary == CI Bug Log - changes from CI_DRM_7201 -> Patchwork_15019 Summary

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Maarten Lankhorst
Op 28-10-2019 om 12:30 schreef Ville Syrjala: > From: Ville Syrjälä > > The change from the uapi coordinates to the internal coordinates > broke the cursor on i845/i865 due to src and dst getting swapped. > Fix it. > > Cc: Maarten Lankhorst > Fixes: 3a612765f423 ("drm/i915: Remove cursor use of p

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Michal Wajdeczko
On Mon, 28 Oct 2019 14:09:05 +0100, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-10-28 12:57:03) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h b/drivers/gpu/drm/i915/gt/intel_lrc.h index 99dc576a4e25..23dde9083349 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.h +++ b/drivers/gpu/

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Initialise ret

2019-10-28 Thread Chris Wilson
Keep smatch quiet, drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1268 __igt_ctx_sseu() error: uninitialized symbol 'ret'. drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1280 __igt_ctx_sseu() error: uninitialized symbol 'ret'. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator

2019-10-28 Thread Chris Wilson
smatch complains about drivers/gpu/drm/i915//display/intel_display.c:14403 intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'. because it has no way to determine that the loop must have an entry. Tell the static analysers to ignore the local, it will always be set. Signed-off-by: Chr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Measure basic throughput of blit routines (rev2)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Measure basic throughput of blit routines (rev2) URL : https://patchwork.freedesktop.org/series/68610/ State : failure == Summary == Applying: drm/i915/selftests: Measure basic throughput of blit routines Using index info to reconstruct a base t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Fix i845/i865 cursor width URL : https://patchwork.freedesktop.org/series/68646/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4da018f49855 drm/i915: Fix i845/i865 cursor width 19cde21752fa drm/i915: Fix max curs

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Initialise ret

2019-10-28 Thread Mika Kuoppala
Chris Wilson writes: > Keep smatch quiet, > > drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1268 __igt_ctx_sseu() > error: uninitialized symbol 'ret'. > drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1280 __igt_ctx_sseu() > error: uninitialized symbol 'ret'. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add missing AUX channel H & I support

2019-10-28 Thread Matt Roper
On Fri, Oct 25, 2019 at 04:13:40PM -0700, Lucas De Marchi wrote: > On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote: > > TGL's extra ports also bring extra AUX channels. > > > > Signed-off-by: Matt Roper > > --- > > drivers/gpu/drm/i915/display/intel_bios.c | 6 > > drivers/gpu

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator

2019-10-28 Thread Mika Kuoppala
Chris Wilson writes: > smatch complains about > drivers/gpu/drm/i915//display/intel_display.c:14403 > intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'. > because it has no way to determine that the loop must have an entry. > Tell the static analysers to ignore the local, it will a

[Intel-gfx] [PATCH v2 2/5] drm/dsi: add missing DSI data types

2019-10-28 Thread Jani Nikula
Add execute queue and compressed pixel stream packet data types for completeness. Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_mipi_dsi.c | 2 ++ include/video/mipi_display.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/dri

[Intel-gfx] [PATCH v2 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS

2019-10-28 Thread Jani Nikula
The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since v1.02, for more than a decade. Rename the enumeration to match the spec. v2: add comment about the rename (David Lechner) Cc: David Lechner Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- drivers/gpu/drm/tiny/st7586.c |

[Intel-gfx] [PATCH v2 1/5] drm/dsi: clean up DSI data type definitions

2019-10-28 Thread Jani Nikula
Rename picture parameter set (it's a long packet, not a long write) and compression mode (it's not a DCS command) enumerations according to the DSI specification. Order the types according to the spec. Use tabs instead of spaces for indentation. Use all lower case for hex. Cc: Vandita Kulkarni Re

[Intel-gfx] [PATCH v2 3/5] drm/dsi: add missing DSI DCS commands

2019-10-28 Thread Jani Nikula
Update from the DCS specification. Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- include/video/mipi_display.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h index 6b6390dfa203..928f8c4b6658 100644 --- a/include/v

[Intel-gfx] [PATCH v2 5/5] drm/dsi: add helpers for DSI compression mode and PPS packets

2019-10-28 Thread Jani Nikula
Add helper functions for sending the DSI compression mode and picture parameter set data type packets. For the time being, limit the support to using VESA DSC 1.1 and the default PPS. This may need updating if the need arises for proprietary compression or non-default PPS, however keep it simple fo

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Fix i845/i865 cursor width URL : https://patchwork.freedesktop.org/series/68646/ State : success == Summary == CI Bug Log - changes from CI_DRM_7201 -> Patchwork_15021 Summar

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 03:20:34PM +0100, Maarten Lankhorst wrote: > Op 28-10-2019 om 12:30 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > The change from the uapi coordinates to the internal coordinates > > broke the cursor on i845/i865 due to src and dst getting swapped. > > Fix it. > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Collect user engines at driver_register phase

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915: Collect user engines at driver_register phase URL : https://patchwork.freedesktop.org/series/68609/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7194_full -> Patchwork_15009_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Check a few more fixed locations within the context image (rev2)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check a few more fixed locations within the context image (rev2) URL : https://patchwork.freedesktop.org/series/68611/ State : success == Summary == CI Bug Log - changes from CI_DRM_7201 -> Patchwork_15022 ==

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl: Handle AUX interrupts for TC ports (rev2)

2019-10-28 Thread Matt Roper
On Sat, Oct 26, 2019 at 08:01:35AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/tgl: Handle AUX interrupts for TC ports (rev2) > URL : https://patchwork.freedesktop.org/series/68528/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7176_full -> Pa

Re: [Intel-gfx] [PATCH tip/core/rcu 03/10] drivers/gpu: Replace rcu_swap_protected() with rcu_replace()

2019-10-28 Thread Paul E. McKenney
On Mon, Oct 28, 2019 at 02:57:26PM +0200, Joonas Lahtinen wrote: > Quoting paul...@kernel.org (2019-10-22 22:12:08) > > From: "Paul E. McKenney" > > > > This commit replaces the use of rcu_swap_protected() with the more > > intuitively appealing rcu_replace() as a step towards removing > > rcu_sw

Re: [Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-28 Thread Rajat Jain
On Fri, Oct 25, 2019 at 4:36 AM Thierry Reding wrote: > > On Thu, Oct 24, 2019 at 01:45:16PM -0700, Rajat Jain wrote: > > Hi, > > > > Thanks for your review and comments. Please see inline below. > > > > On Thu, Oct 24, 2019 at 4:20 AM Thierry Reding > > wrote: > > > > > > On Tue, Oct 22, 2019 a

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-10-28 14:22:29) > On Mon, 28 Oct 2019 14:09:05 +0100, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-10-28 12:57:03) > >> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h > >> b/drivers/gpu/drm/i915/gt/intel_lrc.h > >> index 99dc576a4e25..23dde908334

[Intel-gfx] [RFC PATCH i-g-t v3 2/4] lib: Add GEM minimum page size helper

2019-10-28 Thread Janusz Krzysztofik
Some tests assume 4kB page size while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are incorrectly aligned, may silently skip such incorrectly aligned addresses assu

[Intel-gfx] [RFC PATCH i-g-t v3 0/4] Calculate softpin offsets from actual page size

2019-10-28 Thread Janusz Krzysztofik
Some tests assume 4kB page size while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are incorrectly aligned, may silently skip such incorrectly aligned addresses assu

[Intel-gfx] [RFC PATCH i-g-t v3 3/4] tests/gem_exec_reloc: Calculate softpin offsets from actual page size

2019-10-28 Thread Janusz Krzysztofik
From: Janusz Krzysztofik The basic-range subtest assumes 4kB page size while calculating softpin offsets. On future backends with possibly larger minimum page sizes a half of calculated offsets to be tested may be incorrectly detected as occupied by other users and skiped, significantly distorin

[Intel-gfx] [RFC PATCH i-g-t v3 1/4] lib: Move redundant local helpers to lib/

2019-10-28 Thread Janusz Krzysztofik
Two tests - gem_exec_reloc and gem_softpin - define local helpers for calculation of softpin offset canonical addresses. As more users are expected, replace those local instances with a single shared one under lib/. Signed-off-by: Janusz Krzysztofik Cc: Chris Wilson --- lib/igt_x86.c

[Intel-gfx] [RFC PATCH i-g-t v3 4/4] tests/gem_ctx_shared: Calculate object attributs from actual page size

2019-10-28 Thread Janusz Krzysztofik
exec-shared-gtt-* subtests use hardcoded values for object size and softpin offset, based on 4kB page size assumption. That may result in those subtests failing when run on future backing stores with possibly larger minimum page sizes. Replace hardcoded constants with values derived from minimum

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix i845/i865 cursor width

2019-10-28 Thread Maarten Lankhorst
Op 28-10-2019 om 16:05 schreef Ville Syrjälä: > On Mon, Oct 28, 2019 at 03:20:34PM +0100, Maarten Lankhorst wrote: >> Op 28-10-2019 om 12:30 schreef Ville Syrjala: >>> From: Ville Syrjälä >>> >>> The change from the uapi coordinates to the internal coordinates >>> broke the cursor on i845/i865 due

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Check a few more fixed locations within the context image

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check a few more fixed locations within the context image URL : https://patchwork.freedesktop.org/series/68611/ State : success == Summary == CI Bug Log - changes from CI_DRM_7194_full -> Patchwork_15011_full ===

[Intel-gfx] [PATCH] drm/i915/blt: fixup block_size rounding

2019-10-28 Thread Matthew Auld
There is nothing to say that the obj->base.size is actually a multiple of the block_size. Reported-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915/gem: Limit the blitter sizes to ensure low preemption latency

2019-10-28 Thread Matthew Auld
On Fri, 25 Oct 2019 at 22:06, Chris Wilson wrote: > > Currently we insert a arbitration point every 128MiB during a blitter > copy. At 8GiB/s, this is around 30ms. This is a little on the large side > if we need to inject a high priority work, so reduced it down to 8MiB or > roughly 1ms. > > Signe

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures

2019-10-28 Thread Ville Syrjälä
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote: > We're seeing some failures where an aux transaction still shows as > 'busy' well after the timeout limit that the hardware is supposed to > enforce. Improve the error message so that we can see exactly which aux > channel this error hap

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Daniele Ceraolo Spurio
On 10/24/19 9:29 AM, don.hi...@intel.com wrote: From: Don Hiatt Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action. You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do

[Intel-gfx] [PATCH v2] drm/i915/execlists: Use vfunc to check engine submission mode

2019-10-28 Thread Michal Wajdeczko
While processing CSB there is no need to look at GuC submission settings, just check if engine is configured for execlists mode. While today GuC submission is disabled it's settings are still based on modparam values that might not correctly reflect actual submission status in case of any fallback

Re: [Intel-gfx] [PATCH] drm/i915/blt: fixup block_size rounding

2019-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 04:39:50PM +, Matthew Auld wrote: > There is nothing to say that the obj->base.size is actually a multiple > of the block_size. > > Reported-by: Chris Wilson > Signed-off-by: Matthew Auld > Cc: Chris Wilson > --- > drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 4

[Intel-gfx] [PATCH] drm/i915/tgl: add support to one DP-MST stream

2019-10-28 Thread Lucas De Marchi
This is the minimum change to support 1 (and only 1) DP-MST monitor connected on Tiger Lake. This change was isolated from previous patch from José. In order to support more streams we will need to create a master-slave relation on the transcoders and that is currently not working yet. Cc: José Ro

Re: [Intel-gfx] [PATCH RESEND 8/8] drm/print: introduce new struct drm_device based logging macros

2019-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 12:38:22PM +0200, Jani Nikula wrote: > Add new struct drm_device based logging macros modeled after the core > kernel device based logging macros. These would be preferred over the > drm printk and struct device based macros in drm code, where possible. > > We have existing

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Put future HW and their uAPIs under STAGING & BROKEN

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915: Put future HW and their uAPIs under STAGING & BROKEN URL : https://patchwork.freedesktop.org/series/68612/ State : success == Summary == CI Bug Log - changes from CI_DRM_7194_full -> Patchwork_15012_full ===

Re: [Intel-gfx] [PATCH] drm/i915/tgl: add support to one DP-MST stream

2019-10-28 Thread Souza, Jose
On Mon, 2019-10-28 at 10:04 -0700, Lucas De Marchi wrote: > This is the minimum change to support 1 (and only 1) DP-MST monitor > connected on Tiger Lake. This change was isolated from previous patch > from José. In order to support more streams we will need to create a > master-slave relation on t

Re: [Intel-gfx] [PATCH] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Val Kulkov
On Mon, 28 Oct 2019 at 07:02, Imre Deak wrote: > > For the HPD interrupt functionality the HW depends on power wells in the > display core domain to be on. Accordingly when enabling these power > wells the HPD polling logic will force an HPD detection cycle to account > for hotplug events that may

Re: [Intel-gfx] [PATCH] drm/i915/blt: fixup block_size rounding

2019-10-28 Thread Chris Wilson
Quoting Ville Syrjälä (2019-10-28 16:46:46) > On Mon, Oct 28, 2019 at 04:39:50PM +, Matthew Auld wrote: > > There is nothing to say that the obj->base.size is actually a multiple > > of the block_size. > > > > Reported-by: Chris Wilson > > Signed-off-by: Matthew Auld > > Cc: Chris Wilson >

Re: [Intel-gfx] [PATCH] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 01:00:31PM +0200, Imre Deak wrote: > For the HPD interrupt functionality the HW depends on power wells in the > display core domain to be on. Accordingly when enabling these power > wells the HPD polling logic will force an HPD detection cycle to account > for hotplug events

[Intel-gfx] ✗ Fi.CI.BUILD: failure for sna/video/overlay: Declare support for depth 8 and 30

2019-10-28 Thread Patchwork
== Series Details == Series: sna/video/overlay: Declare support for depth 8 and 30 URL : https://patchwork.freedesktop.org/series/68655/ State : failure == Summary == Applying: sna/video/overlay: Declare support for depth 8 and 30 error: sha1 information is lacking or useless (src/sna/sna_vide

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Simply walk back along request timeline on reset (rev6)

2019-10-28 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Simply walk back along request timeline on reset (rev6) URL : https://patchwork.freedesktop.org/series/68601/ State : success == Summary == CI Bug Log - changes from CI_DRM_7203 -> Patchwork_15023 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Initialise ret

2019-10-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Initialise ret URL : https://patchwork.freedesktop.org/series/68662/ State : warning == Summary == $ dim checkpatch origin/drm-tip a204f00d5275 drm/i915/selftests: Initialise ret -:8: WARNING:COMMIT_LOG_LONG_LINE: Poss

Re: [Intel-gfx] [PATCH] drm/i915/tgl: add support to one DP-MST stream

2019-10-28 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 10:04:57AM -0700, Lucas De Marchi wrote: > This is the minimum change to support 1 (and only 1) DP-MST monitor > connected on Tiger Lake. This change was isolated from previous patch > from José. In order to support more streams we will need to create a > master-slave relati

Re: [Intel-gfx] [PATCH] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Imre Deak
On Mon, Oct 28, 2019 at 07:45:09PM +0200, Ville Syrjälä wrote: > On Mon, Oct 28, 2019 at 01:00:31PM +0200, Imre Deak wrote: > > For the HPD interrupt functionality the HW depends on power wells in the > > display core domain to be on. Accordingly when enabling these power > > wells the HPD polling

[Intel-gfx] [PATCH v2] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-28 Thread Imre Deak
For the HPD interrupt functionality the HW depends on power wells in the display core domain to be on. Accordingly when enabling these power wells the HPD polling logic will force an HPD detection cycle to account for hotplug events that may have happened when such a power well was off. Thus a det

  1   2   >