Re: [Intel-gfx] [PATCH] drm/i915/cml: Add second PCH ID for CMP

2019-10-09 Thread Timo Aaltonen
On 17.9.2019 2.32, Matt Roper wrote: > The CMP PCH ID we have in the driver is correct for the CML-U machines we have > in our CI system, but the CML-S and CML-H CI machines appear to use a > different PCH ID, leading our driver to detect no PCH for them. > > Cc: Rodrigo Vivi > Cc: Anusha Srivats

[Intel-gfx] [PATCH 4/4] FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

2019-10-09 Thread Swati Sharma
Only to print hw and sw lut values/channel. Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_color.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index 614e0ad386ca..6dd0bd3aca37 1

[Intel-gfx] [PATCH 0/4] fix broken state checker and enable state checker for icl+

2019-10-09 Thread Swati Sharma
In this patch series, basically added 3 patches 1. Fixing broken state-checker during boot since legacy platforms i.e. platforms for which state checker was already enabled 2. Moving gamma_enable checks in bit_precision func() to platform specific func() 3. Enabling state checker for ICL

[Intel-gfx] [PATCH 2/4] [v2] drm/i915/color: move check of gamma_enable to specific func/platform

2019-10-09 Thread Swati Sharma
Moved common code to check gamma_enable to specific funcs per platform in bit_precision func. icl doesn't support that and chv has separate enable knob for CGM LUT. v2: -Simplified chv_gamma_precision() [Ville] Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_color.c | 12

[Intel-gfx] [PATCH 1/4] [v3] drm/i915/color: fix broken gamma state-checker during boot

2019-10-09 Thread Swati Sharma
Premature gamma lut prepration and loading which was getting reflected in first modeset causing different colors on screen during boot. Issue: In BIOS, gamma is disabled by default. However, legacy read_luts() was setting crtc_state->base.gamma_lut and gamma_lut was programmed with junk values whi

[Intel-gfx] [PATCH 3/4] [v5] drm/i915/color: Extract icl_read_luts()

2019-10-09 Thread Swati Sharma
For icl+, have hw read out to create hw blob of gamma lut values. icl+ platforms supports multi segmented gamma mode by default, add hw lut creation for this mode. This will be used to validate gamma programming using dsb (display state buffer) which is a tgl specific feature. Major change done-r

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/perf: store the associated engine of a stream URL : https://patchwork.freedesktop.org/series/67760/ State : warning == Summary == $ dim checkpatch origin/drm-tip dc7ec59ac5eb drm/i915/perf: store the associated engine of a st

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Hold request reference over waits (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Hold request reference over waits (rev2) URL : https://patchwork.freedesktop.org/series/67757/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14716 Summary -

[Intel-gfx] [PATCH v2] drm/i915: Enable second dbuf slice for ICL

2019-10-09 Thread Stanislav Lisovskiy
Also implemented algorithm for choosing DBuf slice configuration based on active pipes, pipe ratio as stated in BSpec 12716. Now pipe allocation still stays proportional to pipe width as before, however within allowed DBuf slice for this particular configuration. v2: Remove unneeded check from co

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Patchwork
== Series Details == Series: series starting with [v2,1/9] drm/i915/perf: store the associated engine of a stream URL : https://patchwork.freedesktop.org/series/67760/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14717 ==

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 09:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 07:40:54) On 09/10/2019 02:26, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 00:14:41) If we start reusing it for extended parameters, we need to make fences the first extended param. Why? How do we p

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fix broken state checker and enable state checker for icl+ (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: fix broken state checker and enable state checker for icl+ (rev2) URL : https://patchwork.freedesktop.org/series/67586/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7d21a79cea41 drm/i915/color: fix broken gamma state-checker during boot -:18: ERROR

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Hold request reference over waits

2019-10-09 Thread Mika Kuoppala
Chris Wilson writes: > Take a reference on the request before submitting it to the HW and then > waiting on it for selftest_workarounds. Once submitted, the request may > be freed by a background worker, unless we take an extra reference for > ourselves. > > References: https://bugs.freedesktop.o

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: Enable DDI/Port G

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Enable DDI/Port G URL : https://patchwork.freedesktop.org/series/67755/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037_full -> Patchwork_14712_full Summary --- **SUCCESS

[Intel-gfx] ✓ Fi.CI.BAT: success for fix broken state checker and enable state checker for icl+ (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: fix broken state checker and enable state checker for icl+ (rev2) URL : https://patchwork.freedesktop.org/series/67586/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14718 Summ

[Intel-gfx] [PATCH v2] drm/i915: customize DPCD brightness control for specific panel

2019-10-09 Thread Lee Shawn C
This panel (manufacturer is SDC, product ID is 0x4141) used manufacturer defined DPCD register to control brightness that not defined in eDP spec so far. This change follow panel vendor's instruction to support brightness adjustment. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97883 V2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Catch GTT fault errors for gen11+ planes (rev2) URL : https://patchwork.freedesktop.org/series/67752/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037_full -> Patchwork_14713_full Su

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-09 Thread Lee, Shawn C
On Tue, 08 Oct 2019, Jani Nikula wrote: >On Mon, 07 Oct 2019, Adam Jackson wrote: >> On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: >> >>> The problem with the EDID quirks is that exposing the quirks sticks out >>> like a sore thumb. Thus far all of it has been contained in drm_edid.c >>>

[Intel-gfx] [PATCH] drm/i915/execlists: Prevent merging requests with conflicting flags

2019-10-09 Thread Chris Wilson
We set out-of-bound parameters inside the i915_requests.flags field, such as disabling preemption or marking the end-of-context. We should not coalesce consecutive requests if they have differing instructions as we only inspect the last active request in a context. Thus if we allow a later request

[Intel-gfx] [PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Colin King
From: Colin Ian King An earlier commit removed any error assignments to err and we are now left with a zero assignment to err and a check that is always false. Clean this up by removing the redundant variable err and the error check. Addresses-Coverity: ("'Constant' variable guard") Signed-off-b

Re: [Intel-gfx] [PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Chris Wilson
Quoting Colin King (2019-10-09 10:39:35) > From: Colin Ian King > > An earlier commit removed any error assignments to err and we > are now left with a zero assignment to err and a check that is > always false. Clean this up by removing the redundant variable > err and the error check. Oh, we ad

Re: [Intel-gfx] [PATCH][next] drm/i915: remove redundant variable err

2019-10-09 Thread Jani Nikula
On Wed, 09 Oct 2019, Colin King wrote: > From: Colin Ian King > > An earlier commit removed any error assignments to err and we > are now left with a zero assignment to err and a check that is > always false. Clean this up by removing the redundant variable > err and the error check. > > Addresse

[Intel-gfx] [PATCH][next] drm/i915/selftests: fix null pointer dereference on pointer data

2019-10-09 Thread Colin King
From: Colin Ian King In the case where data fails to be allocated the error exit path is via label 'out' where data is dereferenced in a for-loop. Fix this by exiting via the label 'out_file' instead to avoid the null pointer dereference. Addresses-Coverity: ("Dereference after null check") Fix

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable second dbuf slice for ICL

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Enable second dbuf slice for ICL URL : https://patchwork.freedesktop.org/series/67771/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8c8c36e0a241 drm/i915: Enable second dbuf slice for ICL -:52: CHECK:CAMELCASE: Avoid CamelCase: #52: FILE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Enable second dbuf slice for ICL

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Enable second dbuf slice for ICL URL : https://patchwork.freedesktop.org/series/67771/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Enable second dbuf slice for ICL +drivers/gpu/drm/i915/intel_pm.c:435

[Intel-gfx] [PATCH 2/2] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
The active/pending execlists is no longer protected by the engine->active.lock, but is serialised by the tasklet instead. Update the locking around the debug and stats to follow suit. Fixes: df403069029d ("drm/i915/execlists: Lift process_csb() out of the irq-off spinlock") Signed-off-by: Chris W

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Protect peeking at execlists->active

2019-10-09 Thread Chris Wilson
Now that we dropped the engine->active.lock serialisation from around process_csb(), direct submission can run concurrently to the interrupt handler. As such execlists->active may be advanced as we dequeue, dropping the reference to the request. We need to employ our RCU request protection to ensur

Re: [Intel-gfx] [PATCH][next] drm/i915/selftests: fix null pointer dereference on pointer data

2019-10-09 Thread Chris Wilson
Quoting Colin King (2019-10-09 11:00:24) > From: Colin Ian King > > In the case where data fails to be allocated the error exit path is > via label 'out' where data is dereferenced in a for-loop. Fix this > by exiting via the label 'out_file' instead to avoid the null pointer > dereference. > >

[Intel-gfx] [PATCH] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
The active/pending execlists is no longer protected by the engine->active.lock, but is serialised by the tasklet instead. Update the locking around the debug and stats to follow suit. Fixes: df403069029d ("drm/i915/execlists: Lift process_csb() out of the irq-off spinlock") Signed-off-by: Chris W

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable second dbuf slice for ICL

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Enable second dbuf slice for ICL URL : https://patchwork.freedesktop.org/series/67771/ State : success == Summary == CI Bug Log - changes from CI_DRM_7039 -> Patchwork_14719 Summary --- **SUCCES

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Hold request reference over waits (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Hold request reference over waits (rev2) URL : https://patchwork.freedesktop.org/series/67757/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037_full -> Patchwork_14716_full

[Intel-gfx] [PATCH v2 5/9] drm/i915: Add 10bpc formats with alpha for icl+

2019-10-09 Thread Ville Syrjala
From: Ville Syrjälä ICL+ again supports alpha blending with 10bpc pixel formats. Expose them. v2: Add all the stuff I missed earlier! Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 10 +

Re: [Intel-gfx] Reconfigurable OA queries

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 09:40, Lionel Landwerlin wrote: On 09/10/2019 02:26, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 00:14:41) On 09/10/2019 00:40, Chris Wilson wrote: This is Lionel's work to enable OA for Vulkan, greatly bastardised on top of the struct_mutex removal. It claims to be

[Intel-gfx] ✓ Fi.CI.IGT: success for fix broken state checker and enable state checker for icl+ (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: fix broken state checker and enable state checker for icl+ (rev2) URL : https://patchwork.freedesktop.org/series/67586/ State : success == Summary == CI Bug Log - changes from CI_DRM_7037_full -> Patchwork_14718_full

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-09 Thread Maarten Lankhorst
Op 08-10-2019 om 19:42 schreef Ville Syrjälä: > On Fri, Oct 04, 2019 at 01:35:02PM +0200, Maarten Lankhorst wrote: >> Splitting plane state is easier than splitting crtc_state, >> before plane check we copy the drm properties to hw so we can >> do the same in bigjoiner later on. >> >> We copy the s

[Intel-gfx] [PATCH] drm/i915/execlists: Leave tell-tales as to why pending[] is bad

2019-10-09 Thread Chris Wilson
Before we BUG out with bad pending state, leave a telltale as to which test failed. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_lrc.c | 30 - drivers/gpu/drm/i915/i915_gem.h | 7 +++ 2 files changed, 28

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-09 Thread Ville Syrjälä
On Wed, Oct 09, 2019 at 02:13:55PM +0200, Maarten Lankhorst wrote: > Op 08-10-2019 om 19:42 schreef Ville Syrjälä: > > On Fri, Oct 04, 2019 at 01:35:02PM +0200, Maarten Lankhorst wrote: > >> Splitting plane state is easier than splitting crtc_state, > >> before plane check we copy the drm propertie

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: customize DPCD brightness control for specific panel (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: customize DPCD brightness control for specific panel (rev2) URL : https://patchwork.freedesktop.org/series/67595/ State : warning == Summary == $ dim checkpatch origin/drm-tip ebafaef17574 drm/i915: customize DPCD brightness control for specific panel -:3

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-09 Thread Maarten Lankhorst
Op 09-10-2019 om 14:23 schreef Ville Syrjälä: > On Wed, Oct 09, 2019 at 02:13:55PM +0200, Maarten Lankhorst wrote: >> Op 08-10-2019 om 19:42 schreef Ville Syrjälä: >>> On Fri, Oct 04, 2019 at 01:35:02PM +0200, Maarten Lankhorst wrote: Splitting plane state is easier than splitting crtc_state,

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-09 Thread Ville Syrjälä
On Wed, Oct 09, 2019 at 02:31:58PM +0200, Maarten Lankhorst wrote: > Op 09-10-2019 om 14:23 schreef Ville Syrjälä: > > On Wed, Oct 09, 2019 at 02:13:55PM +0200, Maarten Lankhorst wrote: > >> Op 08-10-2019 om 19:42 schreef Ville Syrjälä: > >>> On Fri, Oct 04, 2019 at 01:35:02PM +0200, Maarten Lankho

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Lionel Landwerlin
Do you have branch somewhere with this series? -Lionel On 09/10/2019 09:42, Chris Wilson wrote: From: Lionel Landwerlin ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-09 13:43:32) > Do you have branch somewhere with this series? https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=wip-perf -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: customize DPCD brightness control for specific panel (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: customize DPCD brightness control for specific panel (rev2) URL : https://patchwork.freedesktop.org/series/67595/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7040 -> Patchwork_14720

Re: [Intel-gfx] [PATCH 12/24] drm/i915: Split plane hw and uapi state

2019-10-09 Thread Maarten Lankhorst
Op 09-10-2019 om 14:41 schreef Ville Syrjälä: > On Wed, Oct 09, 2019 at 02:31:58PM +0200, Maarten Lankhorst wrote: >> Op 09-10-2019 om 14:23 schreef Ville Syrjälä: >>> On Wed, Oct 09, 2019 at 02:13:55PM +0200, Maarten Lankhorst wrote: Op 08-10-2019 om 19:42 schreef Ville Syrjälä: > On Fri,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Prevent merging requests with conflicting flags

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Prevent merging requests with conflicting flags URL : https://patchwork.freedesktop.org/series/67776/ State : warning == Summary == $ dim checkpatch origin/drm-tip d86b0f31f5c9 drm/i915/execlists: Prevent merging requests with conflicting flags

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 15:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 13:43:32) Do you have branch somewhere with this series? https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=wip-perf -Chris Cheers, I've modified the top patch to set the nopreempt flag for as long as the cont

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-09 14:34:49) > On 09/10/2019 15:45, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-10-09 13:43:32) > >> Do you have branch somewhere with this series? > > https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=wip-perf > > -Chris > > > Cheers, > > > I've

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 16:40, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 14:34:49) On 09/10/2019 15:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 13:43:32) Do you have branch somewhere with this series? https://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=wip-perf -Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Prevent merging requests with conflicting flags

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Prevent merging requests with conflicting flags URL : https://patchwork.freedesktop.org/series/67776/ State : success == Summary == CI Bug Log - changes from CI_DRM_7041 -> Patchwork_14721 Su

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Prevent merging requests with conflicting flags

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 12:28, Chris Wilson wrote: We set out-of-bound parameters inside the i915_requests.flags field, such as disabling preemption or marking the end-of-context. We should not coalesce consecutive requests if they have differing instructions as we only inspect the last active request in a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable second dbuf slice for ICL

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: Enable second dbuf slice for ICL URL : https://patchwork.freedesktop.org/series/67771/ State : success == Summary == CI Bug Log - changes from CI_DRM_7039_full -> Patchwork_14719_full Summary ---

Re: [Intel-gfx] [PATCH 2/4] drm/ttm: use the parent resv for ghost objects v2

2019-10-09 Thread Daniel Vetter
On Wed, Oct 09, 2019 at 03:10:09PM +0200, Christian König wrote: > Am 08.10.19 um 11:25 schrieb Daniel Vetter: > > On Thu, Aug 29, 2019 at 04:29:15PM +0200, Christian König wrote: > > > This way we can even pipeline imported BO evictions. > > > > > > v2: Limit this to only cases when the parent ob

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-10-09 14:48:42) > On 09/10/2019 16:40, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-10-09 14:34:49) > >> On 09/10/2019 15:45, Chris Wilson wrote: > >>> Quoting Lionel Landwerlin (2019-10-09 13:43:32) > Do you have branch somewhere with this series? >

Re: [Intel-gfx] [PATCH 3/4] [v5] drm/i915/color: Extract icl_read_luts()

2019-10-09 Thread Ville Syrjälä
On Wed, Oct 09, 2019 at 12:25:41PM +0530, Swati Sharma wrote: > For icl+, have hw read out to create hw blob of gamma > lut values. icl+ platforms supports multi segmented gamma > mode by default, add hw lut creation for this mode. > > This will be used to validate gamma programming using dsb > (d

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/perf: store the associated engine of a stream

2019-10-09 Thread Lionel Landwerlin
On 09/10/2019 17:10, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 14:48:42) On 09/10/2019 16:40, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 14:34:49) On 09/10/2019 15:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-10-09 13:43:32) Do you have branch somewh

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove redundant variable err

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915: remove redundant variable err URL : https://patchwork.freedesktop.org/series/6/ State : success == Summary == CI Bug Log - changes from CI_DRM_7041 -> Patchwork_14722 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add microcontrollers documentation section

2019-10-09 Thread Martin Peres
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote: > To better organize the information, add a microcontrollers section and > move/link the GuC, HuC and DMC documentation under it. Also add a small > intro. > > Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Martin Peres > Cc: Michal Wajdec

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: improve documentation

2019-10-09 Thread Martin Peres
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote: > Add a short description of what we expect from GuC and some minor > improvements to existing documentation. Also remove a comment about a > difference between GuC and HuC that is not true anymore. > > Signed-off-by: Daniele Ceraolo Spurio > Cc:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/huc: improve documentation

2019-10-09 Thread Martin Peres
On 28/09/2019 00:42, Daniele Ceraolo Spurio wrote: > Better explain the usage of the microcontroller and what i915 is > responsible of. While at it, fix the documentation for the auth > function, which doesn't do any pinning anymore. > > Signed-off-by: Daniele Ceraolo Spurio > Cc: Michal Wajdeczk

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: fix null pointer dereference on pointer data

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix null pointer dereference on pointer data URL : https://patchwork.freedesktop.org/series/67780/ State : failure == Summary == Applying: drm/i915/selftests: fix null pointer dereference on pointer data Using index info to reconstruct a base tr

Re: [Intel-gfx] [PATCH 2/4] drm/ttm: use the parent resv for ghost objects v2

2019-10-09 Thread Christian König
Am 08.10.19 um 11:25 schrieb Daniel Vetter: On Thu, Aug 29, 2019 at 04:29:15PM +0200, Christian König wrote: This way we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem.

Re: [Intel-gfx] [PATCH -next] treewide: remove unused argument in lock_release()

2019-10-09 Thread Yuyang Du
I didn't have the guts to do this, and I am glad you did it :) Yuyang On Fri, 20 Sep 2019 at 00:10, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > in __lock_release"), @nested is no longer used in lock_release(), so > remove it from all lock_release

[Intel-gfx] [tip: locking/core] locking/lockdep: Remove unused @nested argument from lock_release()

2019-10-09 Thread tip-bot2 for Qian Cai
The following commit has been merged into the locking/core branch of tip: Commit-ID: 5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Gitweb: https://git.kernel.org/tip/5facae4f3549b5cf7c0e10ec312a65ffd43b5726 Author:Qian Cai AuthorDate:Thu, 19 Sep 2019 12:09:40 -04:00 Committer:

[Intel-gfx] [PULL] drm-misc-next

2019-10-09 Thread Sean Paul
Hi Dave and Daniel, Apologies for missing last week, but this was not something I wanted to do from XDC :-) Lots happening in this pull, the highlights are Thomas' work on gem vram objects, Lyude starting to push the big MST series, Gerd's ttm and virtio refactors, and komeda improvements. One n

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Leave tell-tales as to why pending[] is bad

2019-10-09 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc2 next-20191009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

Re: [Intel-gfx] kernel warning related to i915 code

2019-10-09 Thread Daniel Vetter
On Sun, Sep 29, 2019 at 10:09:43PM +0900, Norbert Preining wrote: > Dear all, > > (please Cc) Adding intel-gfx. -Daniel > > linux 5.3.1 > Debian/sid > Lenovo X260 > [2.472152] i915 :00:02.0: vgaarb: deactivate vga console > [2.473035] [drm] Supports vblank timestamp caching Rev 2 (2

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Protect peeking at execlists->active (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Protect peeking at execlists->active (rev2) URL : https://patchwork.freedesktop.org/series/67782/ State : success == Summary == CI Bug Log - changes from CI_DRM_7042 -> Patchwork_14724

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Select DPLL's via mask (rev3)

2019-10-09 Thread Matt Roper
On Wed, Oct 09, 2019 at 04:25:01AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Select DPLL's via mask (rev3) > URL : https://patchwork.freedesktop.org/series/67740/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_7035_full -> Patchwork_14709_fu

[Intel-gfx] [PATCH 7/8] drm/print: group logging functions by prink or device based

2019-10-09 Thread Jani Nikula
In preparation for adding struct drm_device based logging, group the existing functions by prink or struct device based logging. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 135 ++-- 1 file changed, 74 insertions(+), 61 dele

[Intel-gfx] [PATCH 0/8] drm/print: cleanup and new drm_device based logging

2019-10-09 Thread Jani Nikula
For starters some fairly benign cleanup, and a proposal for new struct drm_device based drm logging macros analoguous to core kernel struct device based macros. BR, Jani. Jani Nikula (8): drm/i915: use drm_debug_enabled() to check for debug categories drm/nouveau: use drm_debug_enabled() to

[Intel-gfx] [PATCH 1/8] drm/i915: use drm_debug_enabled() to check for debug categories

2019-10-09 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Reviewed-by: Eric Engestrom Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 8/8] drm/print: introduce new struct drm_device based logging macros

2019-10-09 Thread Jani Nikula
Add new struct drm_device based logging macros modeled after the core kernel device based logging macros. These would be preferred over the drm printk and struct device based macros in drm code, where possible. We have existing drm specific struct device based logging functions, but they are too v

[Intel-gfx] [PATCH 2/8] drm/nouveau: use drm_debug_enabled() to check for debug categories

2019-10-09 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. v2: move unlikely() to drm_debug_enabled() Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.h | 4 ++-- drivers/gpu/drm/nouveau/n

[Intel-gfx] [PATCH 6/8] drm/print: convert debug category macros into an enum

2019-10-09 Thread Jani Nikula
Mostly for improved documentation, convert the debug category macros into an enum. Drop unused DRM_UT_NONE. Document previously undocumented categories. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 4 +- include/drm/drm_print.h | 101 ++-- 2

[Intel-gfx] [PATCH 5/8] drm/print: underscore prefix functions that should be private to print

2019-10-09 Thread Jani Nikula
We don't want people calling the functions directly. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8 include/drm/drm_print.h | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_prin

[Intel-gfx] [PATCH 3/8] drm/amdgpu: use drm_debug_enabled() to check for debug categories

2019-10-09 Thread Jani Nikula
Allow better abstraction of the drm_debug global variable in the future. No functional changes. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-...@lists.freedesktop.org Acked-by: Alex Deucher Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c |

[Intel-gfx] [PATCH 4/8] drm/print: rename drm_debug to __drm_debug to discourage use

2019-10-09 Thread Jani Nikula
drm_debug_enabled() is the way to check. __drm_debug is now reserved for drm print code only. No functional changes. v2: Rebase on move unlikely() to drm_debug_enabled() Acked-by: Alex Deucher Reviewed-by: Eric Engestrom Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_print.c | 8

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Protect peeking at execlists->active

2019-10-09 Thread Tvrtko Ursulin
On 09/10/2019 11:09, Chris Wilson wrote: Now that we dropped the engine->active.lock serialisation from around process_csb(), direct submission can run concurrently to the interrupt handler. As such execlists->active may be advanced as we dequeue, dropping the reference to the request. We need t

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/kms_crtc_background_color: overhaul to match upstream ABI (v5.1)

2019-10-09 Thread Daniel Vetter
On Tue, Oct 01, 2019 at 03:27:41PM +0300, Ville Syrjälä wrote: > On Mon, Sep 30, 2019 at 10:18:17PM -0400, Martin Peres wrote: > > On 30/09/2019 19:13, Matt Roper wrote: > > > CRTC background color kernel patches were written about 2.5 years ago > > > and floated on the upstream mailing list, but s

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915: Expose 10:10:10 XRGB formats on SNB-BDW sprites (rev2) URL : https://patchwork.freedesktop.org/series/67741/ State : success == Summary == CI Bug Log - changes from CI_DRM_7042 -> Patchwork_14725 ===

Re: [Intel-gfx] [PATCH i-g-t v2 2/2] NOMERGE: Import drm.h up to 54ecb8f7028c

2019-10-09 Thread Daniel Vetter
On Thu, Oct 03, 2019 at 11:46:28AM -0700, Juston Li wrote: > Depends on ummerged kernel code for getfb2 > > Rest of drm.h taken from: > commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c > Author: Linus Torvalds > Date: Mon Sep 30 10:35:40 2019 -0700 > > Linux 5.4-rc1 > > Signed-off-by: Just

Re: [Intel-gfx] [RESEND PATCH v2] drm: Add getfb2 ioctl

2019-10-09 Thread Daniel Vetter
On Thu, Oct 03, 2019 at 11:31:25AM -0700, Juston Li wrote: > From: Daniel Stone > > getfb2 allows us to pass multiple planes and modifiers, just like addfb2 > over addfb. > > Changes since v1: > - unused modifiers set to 0 instead of DRM_FORMAT_MOD_INVALID > - update ioctl number > > Signed-o

Re: [Intel-gfx] [PATCH] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Tvrtko Ursulin
On 09/10/2019 11:26, Chris Wilson wrote: The active/pending execlists is no longer protected by the engine->active.lock, but is serialised by the tasklet instead. Update the locking around the debug and stats to follow suit. Fixes: df403069029d ("drm/i915/execlists: Lift process_csb() out of th

Re: [Intel-gfx] [PATCH 5/5] drm/mm: Use clear_bit_unlock() for releasing the drm_mm_node()

2019-10-09 Thread Daniel Vetter
On Fri, Oct 04, 2019 at 01:01:36PM +0100, Tvrtko Ursulin wrote: > > On 04/10/2019 12:17, Chris Wilson wrote: > > Quoting Chris Wilson (2019-10-04 12:07:10) > > > Quoting Tvrtko Ursulin (2019-10-04 10:15:20) > > > > > > > > On 03/10/2019 22:01, Chris Wilson wrote: > > > > > A few callers need to s

Re: [Intel-gfx] [PATCH] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-09 16:53:53) > > On 09/10/2019 11:26, Chris Wilson wrote: > > +static inline void > > +execlists_active_lock(struct intel_engine_execlists *execlists) > > +{ > > + tasklet_lock(&execlists->tasklet); > > +} > > + > > +static inline void > > +execlists_active_unlo

[Intel-gfx] [PATCH v2] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
The active/pending execlists is no longer protected by the engine->active.lock, but is serialised by the tasklet instead. Update the locking around the debug and stats to follow suit. v2: local_bh_disable() to prevent recursing into the tasklet in case we trigger a softirq (Tvrtko) Fixes: df40306

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-10-09 Thread Alex Deucher
Applied. thanks! Alex On Tue, Oct 8, 2019 at 8:36 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_module.c:25: > drivers/gpu/drm/amd/

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
Quoting Chris Wilson (2019-10-09 17:09:06) > The active/pending execlists is no longer protected by the > engine->active.lock, but is serialised by the tasklet instead. Update > the locking around the debug and stats to follow suit. > > v2: local_bh_disable() to prevent recursing into the tasklet

Re: [Intel-gfx] [PATCH] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Tvrtko Ursulin
On 09/10/2019 16:59, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-09 16:53:53) On 09/10/2019 11:26, Chris Wilson wrote: +static inline void +execlists_active_lock(struct intel_engine_execlists *execlists) +{ + tasklet_lock(&execlists->tasklet); +} + +static inline void +execlists_a

[Intel-gfx] ✗ Fi.CI.BUILD: failure for treewide: remove unused argument in lock_release() (rev2)

2019-10-09 Thread Patchwork
== Series Details == Series: treewide: remove unused argument in lock_release() (rev2) URL : https://patchwork.freedesktop.org/series/67007/ State : failure == Summary == Applying: locking/lockdep: Remove unused @nested argument from lock_release() error: sha1 information is lacking or useless

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Leave tell-tales as to why pending[] is bad

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Leave tell-tales as to why pending[] is bad URL : https://patchwork.freedesktop.org/series/67786/ State : success == Summary == CI Bug Log - changes from CI_DRM_7043 -> Patchwork_14726 Summar

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/execlists: Leave tell-tales as to why pending[] is bad

2019-10-09 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Leave tell-tales as to why pending[] is bad URL : https://patchwork.freedesktop.org/series/67786/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h AR

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/print: cleanup and new drm_device based logging

2019-10-09 Thread Patchwork
== Series Details == Series: drm/print: cleanup and new drm_device based logging URL : https://patchwork.freedesktop.org/series/67795/ State : warning == Summary == $ dim checkpatch origin/drm-tip 89aa720fbb9a drm/i915: use drm_debug_enabled() to check for debug categories ad0afd4a8ac2 drm/nou

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Tvrtko Ursulin
On 09/10/2019 17:32, Chris Wilson wrote: Quoting Chris Wilson (2019-10-09 17:09:06) The active/pending execlists is no longer protected by the engine->active.lock, but is serialised by the tasklet instead. Update the locking around the debug and stats to follow suit. v2: local_bh_disable() to

Re: [Intel-gfx] [PATCH] drm/i915/gt: execlists->active is serialised by the tasklet

2019-10-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-09 17:37:42) > > On 09/10/2019 16:59, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-10-09 16:53:53) > >> > >> On 09/10/2019 11:26, Chris Wilson wrote: > >>> +static inline void > >>> +execlists_active_lock(struct intel_engine_execlists *execlists) > >>> +{ >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/print: cleanup and new drm_device based logging

2019-10-09 Thread Patchwork
== Series Details == Series: drm/print: cleanup and new drm_device based logging URL : https://patchwork.freedesktop.org/series/67795/ State : success == Summary == CI Bug Log - changes from CI_DRM_7043 -> Patchwork_14728 Summary ---

[Intel-gfx] [CI 1/2] drm/i915: Move SAGV block time to dev_priv

2019-10-09 Thread Lucas De Marchi
From: James Ausmus In prep for newer platforms having more complicated ways to determine the SAGV block time, move the variable to dev_priv, and extract the setting to an initial setup function. While we're at it, update the if ladder to follow the new gen -> old gen order preference, and warn on

[Intel-gfx] [CI 2/2] drm/i915/tgl: Read SAGV block time from PCODE

2019-10-09 Thread Lucas De Marchi
From: James Ausmus Starting from TGL, we now need to read the SAGV block time via a PCODE mailbox, rather than having a static value. BSpec: 49326 v2: Fix up pcode val data type (Ville), tighten variable scope (Ville) Cc: Ville Syrjälä Cc: Stanislav Lisovskiy Cc: Lucas De Marchi Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Leave tell-tales as to why pending[] is bad

2019-10-09 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc2 next-20191009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

Re: [Intel-gfx] [PATCH] drm/i915/cml: Add second PCH ID for CMP

2019-10-09 Thread Matt Roper
On Wed, Oct 09, 2019 at 10:03:31AM +0300, Timo Aaltonen wrote: > On 17.9.2019 2.32, Matt Roper wrote: > > The CMP PCH ID we have in the driver is correct for the CML-U machines we > > have > > in our CI system, but the CML-S and CML-H CI machines appear to use a > > different PCH ID, leading our d

  1   2   >