[Intel-gfx] ✗ Fi.CI.IGT: failure for CRTC background color (rev8)

2019-10-01 Thread Patchwork
== Series Details == Series: CRTC background color (rev8) URL : https://patchwork.freedesktop.org/series/50834/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6979_full -> Patchwork_14594_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/color: fix broken display in icl+

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/color: fix broken display in icl+ URL : https://patchwork.freedesktop.org/series/67429/ State : success == Summary == CI Bug Log - changes from CI_DRM_6979 -> Patchwork_14597 Summary --- **SUCCES

[Intel-gfx] [PATCH] TGL HAX drm/i915/tgl: Defer direct submission from interrupt context

2019-10-01 Thread Chris Wilson
--- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index ef9eb3330a37..8906d86c76de 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/g

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tc: Implement the TC cold exit sequence (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/tc: Implement the TC cold exit sequence (rev2) URL : https://patchwork.freedesktop.org/series/67426/ State : success == Summary == CI Bug Log - changes from CI_DRM_6979 -> Patchwork_14598 Summary --

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Swati Sharma wrote: > Premature gamma lut prepration and loading which was getting > reflected in first modeset causing different colors on > screen during boot. > > Issue: In BIOS, gamma is disabled by default. However, > legacy_read_luts() was getting called even before the

[Intel-gfx] [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-01 Thread Jani Nikula
The kernel has plenty of ternary operators to choose between constant strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : "s": $ git grep '? "yes" : "no"' | wc -l 258 $ git grep '? "on" : "off"' | wc -l 204 $ git grep '? "enabled" : "disabled"' | wc -l 196 $ git grep '? "" : "s

Re: [Intel-gfx] [PATCH] drm/i915/gt: Only unwedge if we can reset first

2019-10-01 Thread Janusz Krzysztofik
Hi Chris, On Friday, September 27, 2019 6:03:35 PM CEST Chris Wilson wrote: > Unwedging the GPU requires a successful GPU reset before we restore the > default submission, or else we may see residual context switch events > that we were not expecting. > > v2: Pull in the special-case reset_clobbe

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFT drm/i915/tgl: Re-enable rps (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev2) URL : https://patchwork.freedesktop.org/series/67398/ State : warning == Summary == $ dim checkpatch origin/drm-tip c071a17cd8f9 RFT drm/i915/tgl: Re-enable rps -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an

[Intel-gfx] [PATCH] HAX: Force kmemleak off

2019-10-01 Thread Chris Wilson
--- mm/kmemleak.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index f6e602918dac..cf392615ad40 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -2015,6 +2015,9 @@ void __init kmemleak_init(void) } #endif + kmemleak_disable(); + retur

[Intel-gfx] ✓ Fi.CI.BAT: success for RFT drm/i915/tgl: Re-enable rps (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev2) URL : https://patchwork.freedesktop.org/series/67398/ State : success == Summary == CI Bug Log - changes from CI_DRM_6980 -> Patchwork_14599 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for TGL HAX drm/i915/tgl: Defer direct submission from interrupt context

2019-10-01 Thread Patchwork
== Series Details == Series: TGL HAX drm/i915/tgl: Defer direct submission from interrupt context URL : https://patchwork.freedesktop.org/series/67431/ State : warning == Summary == $ dim checkpatch origin/drm-tip c5799b216ffc TGL HAX drm/i915/tgl: Defer direct submission from interrupt conte

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/color: fix broken display in icl+

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/color: fix broken display in icl+ URL : https://patchwork.freedesktop.org/series/67429/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6979_full -> Patchwork_14597_full Summary ---

Re: [Intel-gfx] [PATCH v10 4/6] drm/i915/tgl: Do modeset to enable and configure DC3CO exitline

2019-10-01 Thread Imre Deak
On Mon, Sep 30, 2019 at 11:11:35PM +0530, Anshuman Gupta wrote: > DC3CO enabling B.Specs sequence requires to enable end configure > exit scanlines to TRANS_EXITLINE register, programming this register > has to be part of modeset sequence as this can't be change when > transcoder or port is enabled

Re: [Intel-gfx] [PATCH 1/4] drm/rect: Add drm_rect_translate_to()

2019-10-01 Thread Jani Nikula
On Mon, 30 Sep 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a helper to translate a rectangle to an absolute position. > > Signed-off-by: Ville Syrjälä The series is Reviewed-by: Jani Nikula > --- > include/drm/drm_rect.h | 14 ++ > 1 file changed, 14 insertions(+)

Re: [Intel-gfx] [PATCH v10 5/6] drm/i915/tgl: Switch between dc3co and dc5 based on display idleness

2019-10-01 Thread Imre Deak
On Mon, Sep 30, 2019 at 11:11:36PM +0530, Anshuman Gupta wrote: > DC3CO is useful power state, when DMC detects PSR2 idle frame > while an active video playback, playing 30fps video on 60hz panel > is the classic example of this use case. > > B.Specs:49196 has a restriction to enable DC3CO only fo

[Intel-gfx] ✓ Fi.CI.BAT: success for TGL HAX drm/i915/tgl: Defer direct submission from interrupt context

2019-10-01 Thread Patchwork
== Series Details == Series: TGL HAX drm/i915/tgl: Defer direct submission from interrupt context URL : https://patchwork.freedesktop.org/series/67431/ State : success == Summary == CI Bug Log - changes from CI_DRM_6980 -> Patchwork_14600 S

Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-01 Thread Greg Kroah-Hartman
On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: > The kernel has plenty of ternary operators to choose between constant > strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : > "s": > > $ git grep '? "yes" : "no"' | wc -l > 258 > $ git grep '? "on" : "off"' | wc -l

Re: DDC on Thinkpad x220

2019-10-01 Thread Jani Nikula
On Mon, 30 Sep 2019, Pavel Machek wrote: > Hi! > > Thinkpad X220 should be new enough machine to talk DDC to the > monitors, right? And my monitor has DDC enable/disable in the menu, so > it should support it, too... > > But I don't have /dev/i2c* and did not figure out how to talk to the > monito

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3) URL : https://patchwork.freedesktop.org/series/67349/ State : warning == Summary == $ dim checkpatch origin/drm-tip d0541b40d6ed drm/i915/userptr: Never allow userptr into the mappable GGTT -:25: W

Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Greg Kroah-Hartman wrote: > On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: >> The kernel has plenty of ternary operators to choose between constant >> strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : >> "s": >> >> $ git grep '? "yes" : "no

[Intel-gfx] [PATCH] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

[Intel-gfx] [PATCH] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

Re: [Intel-gfx] [PATCH v10 5/6] drm/i915/tgl: Switch between dc3co and dc5 based on display idleness

2019-10-01 Thread Imre Deak
On Mon, Sep 30, 2019 at 11:11:36PM +0530, Anshuman Gupta wrote: > DC3CO is useful power state, when DMC detects PSR2 idle frame > while an active video playback, playing 30fps video on 60hz panel > is the classic example of this use case. > > B.Specs:49196 has a restriction to enable DC3CO only fo

Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-01 Thread Greg Kroah-Hartman
On Tue, Oct 01, 2019 at 12:42:34PM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Greg Kroah-Hartman wrote: > > On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: > >> The kernel has plenty of ternary operators to choose between constant > >> strings, such as condition ? "yes" : "no",

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tc: Implement the TC cold exit sequence (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/tc: Implement the TC cold exit sequence (rev2) URL : https://patchwork.freedesktop.org/series/67426/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6979_full -> Patchwork_14598_full Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3) URL : https://patchwork.freedesktop.org/series/67349/ State : success == Summary == CI Bug Log - changes from CI_DRM_6980 -> Patchwork_14601 Su

Re: [Intel-gfx] [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Greg Kroah-Hartman wrote: > On Tue, Oct 01, 2019 at 12:42:34PM +0300, Jani Nikula wrote: >> On Tue, 01 Oct 2019, Greg Kroah-Hartman wrote: >> > On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: >> >> The kernel has plenty of ternary operators to choose between cons

[Intel-gfx] [PATCH] drm/i915: Initialise breadcrumb lists on the virtual engine

2019-10-01 Thread Chris Wilson
With deferring the breadcrumb signalling to the virtual engine (thanks preempt-to-busy) we need to make sure the lists and irq-worker are ready to send a signal. [41958.710544] BUG: kernel NULL pointer dereference, address: [41958.710553] #PF: supervisor write access in kernel mod

Re: [Intel-gfx] [PATCH] drm/i915: Initialise breadcrumb lists on the virtual engine

2019-10-01 Thread Tvrtko Ursulin
On 01/10/2019 11:35, Chris Wilson wrote: With deferring the breadcrumb signalling to the virtual engine (thanks preempt-to-busy) we need to make sure the lists and irq-worker are ready to send a signal. [41958.710544] BUG: kernel NULL pointer dereference, address: [41958.710553

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2) URL : https://patchwork.freedesktop.org/series/67405/ State : warning == Summary == $ dim checkpatch origin/drm-tip ff289b0aa561 string-choice: add yesno(), onoff(), enableddisable

5.4-rc1 on Thinkpad x220: graphics regression, it "snows" on digital output

2019-10-01 Thread Pavel Machek
Hi! When 5.4-rc1 is booted on thinkpad X220 I get "snow" and other artefacts on digital output. 00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller (rev 09) It already snows when kernel is booting, snow continues in X. HDMI1 c

Re: 5.4-rc1 on Thinkpad x220: graphics regression, it "snows" on digital output

2019-10-01 Thread Pavel Machek
Hi! > When 5.4-rc1 is booted on thinkpad X220 I get "snow" and other > artefacts on digital output. > > 00:02.0 VGA compatible controller: Intel Corporation 2nd Generation > Core Processor Family Integrated Graphics Controller (rev 09) > > It already snows when kernel is booting, snow continues

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-01 Thread Jani Nikula
On Thu, 26 Sep 2019, Eric Engestrom wrote: > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote: >> Hi all, v2 of [1], a little refactoring around drm_debug access to >> abstract it better. There shouldn't be any functional changes. >> >> I'd appreciate acks for merging the lot via drm-misc

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2) URL : https://patchwork.freedesktop.org/series/67405/ State : success == Summary == CI Bug Log - changes from CI_DRM_6981 -> Patchwork_14602 ===

Re: DDC on Thinkpad x220

2019-10-01 Thread Pavel Machek
On Tue 2019-10-01 12:39:34, Jani Nikula wrote: > On Mon, 30 Sep 2019, Pavel Machek wrote: > > Hi! > > > > Thinkpad X220 should be new enough machine to talk DDC to the > > monitors, right? And my monitor has DDC enable/disable in the menu, so > > it should support it, too... > > > > But I don't ha

[Intel-gfx] ✓ Fi.CI.IGT: success for RFT drm/i915/tgl: Re-enable rps (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev2) URL : https://patchwork.freedesktop.org/series/67398/ State : success == Summary == CI Bug Log - changes from CI_DRM_6980_full -> Patchwork_14599_full Summary --- **

[Intel-gfx] [PATCH 2/2] drm/i915: FB backing gem obj should reside in LMEM

2019-10-01 Thread Ramalingam C
If Local memory is supported by hardware, we want framebuffer backing gem objects from local memory. pin_to_display is failed, if the backing obj is not from LMEM. This is developed on top of LMEM Basics https://patchwork.freedesktop.org/series/67350/ v2: memory regions are correctly assigned

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-10-01 Thread Ville Syrjälä
On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasa...@intel.com wrote: > From: Srinivasan S > > This patch avoids DP MST payload error message in dmesg, as it is trying > to update the payload to the disconnected DP MST device. After DP MST > device is disconnected we should not be updating the

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Tvrtko Ursulin
On 01/10/2019 10:51, Chris Wilson wrote: If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync

2019-10-01 Thread Ville Syrjälä
On Mon, Sep 30, 2019 at 11:37:41AM -0700, Lucas De Marchi wrote: > On Sun, Sep 22, 2019 at 10:08:02AM -0700, Manasi Navare wrote: > >In case of tiled displays when the two tiles are sent across two CRTCs > >over two separate DP SST connectors, we need a mechanism to synchronize > >the two CRTCs and

[Intel-gfx] [PATCH] drm/i915: Describe structure members in documentation

2019-10-01 Thread Anna Karas
Add missing descriptions of i915_perf_stream structure members to documentation. Cc: Umesh Nerlige Ramappa Cc: Lionel Landwerlin Cc: Robert Bragg Signed-off-by: Anna Karas --- drivers/gpu/drm/i915/i915_drv.h | 29 + 1 file changed, 29 insertions(+) diff --git a/dr

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-01 13:16:19) > > On 01/10/2019 10:51, Chris Wilson wrote: > > + > > + /* > > + * Setup the pair of contexts such that if we > > + * lite-restore using the RING_TAIL from ce[1] it > > +

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/kms_crtc_background_color: overhaul to match upstream ABI (v5.1)

2019-10-01 Thread Ville Syrjälä
On Mon, Sep 30, 2019 at 10:18:17PM -0400, Martin Peres wrote: > On 30/09/2019 19:13, Matt Roper wrote: > > CRTC background color kernel patches were written about 2.5 years ago > > and floated on the upstream mailing list, but since no opensource > > userspace materialized, we never actually merged

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Tvrtko Ursulin
On 01/10/2019 13:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-10-01 13:16:19) On 01/10/2019 10:51, Chris Wilson wrote: + + /* + * Setup the pair of contexts such that if we + * lite-restore using the RING_TAIL from ce[1] it

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote: > On Thu, 26 Sep 2019, Eric Engestrom wrote: > > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote: > >> Hi all, v2 of [1], a little refactoring around drm_debug access to > >> abstract it better. There shouldn't be any functional ch

[Intel-gfx] ✓ Fi.CI.IGT: success for TGL HAX drm/i915/tgl: Defer direct submission from interrupt context

2019-10-01 Thread Patchwork
== Series Details == Series: TGL HAX drm/i915/tgl: Defer direct submission from interrupt context URL : https://patchwork.freedesktop.org/series/67431/ State : success == Summary == CI Bug Log - changes from CI_DRM_6980_full -> Patchwork_14600_full =

[Intel-gfx] [PATCH v2] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-10-01 Thread S, Srinivasan
Thanks a lot Manasi, Ville, Mika, Jani, Lakshmi, for all your time in reviewing this patch. Best Regards, > -Original Message- > From: dri-devel On Behalf Of Ville > Syrjälä > Sent: Tuesday, October 1, 2019 5:31 PM > To: S, Srinivasan > Cc: Navare, Manasi D ; intel- > g...@lists.freede

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Tvrtko Ursulin
On 01/10/2019 13:43, Chris Wilson wrote: If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-10-01 13:59:14) > > On 01/10/2019 13:43, Chris Wilson wrote: > > + tasklet_kill(&engine->execlists.tasklet); /* flush submission > > */ > > Is this really needed, why? In a pathological case where we are using the tasklet (e.g. preemption and ksoftirqd a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/userptr: Never allow userptr into the mappable GGTT (rev3) URL : https://patchwork.freedesktop.org/series/67349/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6980_full -> Patchwork_14601_full ==

[Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Jani Nikula
Split out code related to vga client and vga switcheroo register/unregister and state handling from i915_drv.c and intel_display.c. It's a bit difficult to draw the line how much to move to the new file from i915_drv.c, but it seemed to me keeping i915_suspend_switcheroo() and i915_resume_switcher

[Intel-gfx] [PATCH 0/2] Conclude load -> probe naming convention switch

2019-10-01 Thread Janusz Krzysztofik
Test-with: <20191001132728.14602-1-janusz.krzyszto...@linux.intel.com> The purpose is: * to fix incompatible names of new functions introduced meanwhile, * to complete postponed rename of module parameter. Will be tested with just submitted IGT counterpart using a trybot submission because I forg

[Intel-gfx] [PATCH 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Janusz Krzysztofik
Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") introduced new functions unfortunately named incompatibly with rules established by commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently"). Fix it for consistency. Suggested-by: Michał Wajdeczko Signed-

[Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently") deliberately left the name of the module parameter unchanged as that would require a corresponding change on IGT size. Now as the IGT side change has been submitted, complete the switch to the "probe" nomenclature. May af

[Intel-gfx] [PATCH 2/2] drm/i915/tgl: Restrict availables engines to rcs0 by default

2019-10-01 Thread Chris Wilson
CI is still unstable whenever we enable more than one engine, and we have not yet found a better hack than restricting it to using just rcs0. However, to allow testing to continue on the other engines by developers, we allow the available set of engines to be overridden on the command line with ju

[Intel-gfx] [PATCH 1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread Chris Wilson
Allow the user to restrict the available set of engines via a module parameter. Signed-off-by: Chris Wilson Cc: Stuart Summers Cc: Andi Shyti Cc: Mika Kuoppala Cc: Tvrtko Ursulin Cc: Joonas Lahtinen Cc: Martin Peres --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 35 ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > consequently") deliberately left the name of the module parameter > unchanged as that would require a corresponding change on IGT size. > Now as the IGT side change has been submitted,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Hi Chris, On Tuesday, October 1, 2019 3:57:27 PM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > > consequently") deliberately left the name of the module parameter > > unchanged as that would require a

[Intel-gfx] [PATCH v3] drm/print: add drm_debug_enabled()

2019-10-01 Thread Jani Nikula
Add helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes. v2: Move unlikely() to drm_debug_enabled() (Eric) v3: Keep unlikely() when combined with other conditions (Eric) Cc: Eric Engestrom Acked-by: Alex Deucher Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Eric Engestrom wrote: > On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote: >> On Thu, 26 Sep 2019, Eric Engestrom wrote: >> > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote: >> >> Hi all, v2 of [1], a little refactoring around drm_debug access to >> >> abstra

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 04:43:53PM +0300, Jani Nikula wrote: > Split out code related to vga client and vga switcheroo > register/unregister and state handling from i915_drv.c and > intel_display.c. The two things don't really have anything in common except both have "vga" in the name, so not sure

[Intel-gfx] ✗ Fi.CI.BUILD: failure for HAX: Force kmemleak off

2019-10-01 Thread Patchwork
== Series Details == Series: HAX: Force kmemleak off URL : https://patchwork.freedesktop.org/series/67436/ State : failure == Summary == Applying: HAX: Force kmemleak off Using index info to reconstruct a base tree... M mm/kmemleak.c Falling back to patching base and 3-way merge... Auto-

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Chris Wilson
Quoting Jani Nikula (2019-10-01 14:43:53) > Split out code related to vga client and vga switcheroo > register/unregister and state handling from i915_drv.c and > intel_display.c. > > It's a bit difficult to draw the line how much to move to the new file > from i915_drv.c, but it seemed to me keep

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:33) > Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") > introduced new functions unfortunately named incompatibly with rules > established by commit f2db53f14d3d ("drm/i915: Replace "_load" with > "_probe" consequently"). Fix it

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > consequently") deliberately left the name of the module parameter > unchanged as that would require a corresponding change on IGT size. > Now as the IGT side change has been submitted,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFT drm/i915/tgl: Re-enable rps (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev3) URL : https://patchwork.freedesktop.org/series/67398/ State : warning == Summary == $ dim checkpatch origin/drm-tip 63d2c674198c RFT drm/i915/tgl: Re-enable rps -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Swati Sharma wrote: > > Premature gamma lut prepration and loading which was getting > > reflected in first modeset causing different colors on > > screen during boot. > > > > Issue: In BIOS, gamma is disabled by d

[Intel-gfx] [PATCH v10 0/6] DC3CO Support for TGL

2019-10-01 Thread Anshuman Gupta
Resending this version v10 after adding Imre's RB and after fixing few code refactoring related comments provided by Imre. Anshuman Gupta (6): drm/i915/tgl: Add DC3CO required register and bits drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask drm/i915/tgl: Enable DC3CO state

[Intel-gfx] [PATCH v10 2/6] drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask

2019-10-01 Thread Anshuman Gupta
Enable dc3co state in enable_dc module param and add dc3co enable mask to allowed_dc_mask and gen9_dc_mask. v1: Adding enable_dc=3,4 options to enable DC3CO with DC5 and DC6 independently. [Animesh] v2: Using a switch statement for cleaner code. [Animesh] Cc: Jani Nikula Cc: Imre Deak Cc: A

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > Quoting Jani Nikula (2019-10-01 14:43:53) > > Split out code related to vga client and vga switcheroo > > register/unregister and state handling from i915_drv.c and > > intel_display.c. > > > > It's a bit difficult to draw the line ho

[Intel-gfx] [PATCH v10 5/6] drm/i915/tgl: Switch between dc3co and dc5 based on display idleness

2019-10-01 Thread Anshuman Gupta
DC3CO is useful power state, when DMC detects PSR2 idle frame while an active video playback, playing 30fps video on 60hz panel is the classic example of this use case. B.Specs:49196 has a restriction to enable DC3CO only for Video Playback. It will be worthy to enable DC3CO after completion of ea

[Intel-gfx] [PATCH v10 6/6] drm/i915/tgl: Add DC3CO counter in i915_dmc_info

2019-10-01 Thread Anshuman Gupta
Adding DC3CO counter in i915_dmc_info debugfs will be useful for DC3CO validation. DMC firmware uses DMC_DEBUG3 register as DC3CO counter register on TGL, as per B.Specs DMC_DEBUG3 is general purpose register. v1: comment modification for DMC_DBUG3. using GEN >= 12 check instead of IS_TIGERLAK

[Intel-gfx] [PATCH v10 1/6] drm/i915/tgl: Add DC3CO required register and bits

2019-10-01 Thread Anshuman Gupta
Adding following definition to i915_reg.h 1. DC_STATE_EN register DC3CO bit fields and masks. DC3CO enable bit will be used by driver to make DC3CO ready for DMC f/w and status bit will be used as DC3CO entry status. 2. Transcoder EXITLINE register and its bit fields and mask. Transcode

[Intel-gfx] [PATCH v10 4/6] drm/i915/tgl: Do modeset to enable and configure DC3CO exitline

2019-10-01 Thread Anshuman Gupta
DC3CO enabling B.Specs sequence requires to enable end configure exit scanlines to TRANS_EXITLINE register, programming this register has to be part of modeset sequence as this can't be change when transcoder or port is enabled. When system boots with only eDP panel there may not be real modeset as

[Intel-gfx] [PATCH v10 3/6] drm/i915/tgl: Enable DC3CO state in "DC Off" power well

2019-10-01 Thread Anshuman Gupta
Add target_dc_state and used by set_target_dc_state API in order to enable DC3CO state with existing DC states. target_dc_state will enable/disable the desired DC state in DC_STATE_EN reg when "DC Off" power well gets disable/enable. v2: commit log improvement. v3: Used intel_wait_for_register to

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Sharma, Swati2
On 01-Oct-19 7:51 PM, Ville Syrjälä wrote: On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: On Tue, 01 Oct 2019, Swati Sharma wrote: Premature gamma lut prepration and loading which was getting reflected in first modeset causing different colors on screen during boot. Issue: In BI

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Ville Syrjälä wrote: > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: >> Quoting Jani Nikula (2019-10-01 14:43:53) >> > Split out code related to vga client and vga switcheroo >> > register/unregister and state handling from i915_drv.c and >> > intel_display.c.

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Chris Wilson
Quoting Jani Nikula (2019-10-01 15:28:51) > On Tue, 01 Oct 2019, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > >> For the sake of argument, could you float the split in the other > >> direction? > > Please elaborate. Move switcheroo higher in the call ch

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjälä > Sent: tiistai 1. lokakuuta 2019 17.21 > To: Nikula, Jani > Cc: intel-gfx@lists.freedesktop.org; Nautiyal, Ankit K > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+ > > On Tue, Oct

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 07:58:39PM +0530, Sharma, Swati2 wrote: > On 01-Oct-19 7:51 PM, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: > >> On Tue, 01 Oct 2019, Swati Sharma wrote: > >>> Premature gamma lut prepration and loading which was getting > >>> refle

[Intel-gfx] [PATCH v2 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Janusz Krzysztofik
Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") introduced new functions unfortunately named incompatibly with rules established by commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently"). Fix it for consistency. Suggested-by: Michał Wajdeczko Signed-

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 05:28:51PM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > >> Quoting Jani Nikula (2019-10-01 14:43:53) > >> > Split out code related to vga client and vga switcheroo > >> > register/u

[Intel-gfx] [PATCH v2 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently") deliberately left the name of the module parameter unchanged as that would require a corresponding change on IGT size. Now as the IGT side change has been submitted, complete the switch to the "probe" nomenclature. Sugges

[Intel-gfx] [PATCH v2 0/2] drm/i915: Conclude load -> probe naming convention switch

2019-10-01 Thread Janusz Krzysztofik
Test-with: <20191001142724.16472-2-janusz.krzyszto...@linux.intel.com> The purpose is: * to fix incompatible names of new functions introduced meanwhile, * to complete postponed rename of module parameter. v2: * drop unnecessary statement about custom user applications from commit message o

[Intel-gfx] ✓ Fi.CI.BAT: success for RFT drm/i915/tgl: Re-enable rps (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev3) URL : https://patchwork.freedesktop.org/series/67398/ State : success == Summary == CI Bug Log - changes from CI_DRM_6984 -> Patchwork_14604 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/4] drm/rect: Add drm_rect_translate_to()

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 12:26:52PM +0300, Jani Nikula wrote: > On Mon, 30 Sep 2019, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add a helper to translate a rectangle to an absolute position. > > > > Signed-off-by: Ville Syrjälä > > The series is > > Reviewed-by: Jani Nikula > Thanks

Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

2019-10-01 Thread Janusz Krzysztofik
Hi Baolu, On Tuesday, September 3, 2019 9:41:23 AM CEST Janusz Krzysztofik wrote: > Hi Baolu, > > On Tuesday, September 3, 2019 3:29:40 AM CEST Lu Baolu wrote: > > Hi Janusz, > > > > On 9/2/19 4:37 PM, Janusz Krzysztofik wrote: > > >> I am not saying that keeping data is not acceptable. I just w

Re: [Intel-gfx] [PATCH v3] drm/print: add drm_debug_enabled()

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 17:06:14 +0300, Jani Nikula wrote: > Add helper to check if a drm debug category is enabled. Convert drm core > to use it. No functional changes. > > v2: Move unlikely() to drm_debug_enabled() (Eric) > > v3: Keep unlikely() when combined with other conditions (Eric) > > Cc

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2) URL : https://patchwork.freedesktop.org/series/67405/ State : success == Summary == CI Bug Log - changes from CI_DRM_6981_full -> Patchwork_14602_full =

[Intel-gfx] [PATCH] drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Jani Nikula
Split out the code related to vga client and vgaarb all over the place into new intel_vga.[ch]. No functional changes. Cc: Ville Syrjälä Cc: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/display/intel_display.c | 97 +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Initialise breadcrumb lists on the virtual engine (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Initialise breadcrumb lists on the virtual engine (rev2) URL : https://patchwork.freedesktop.org/series/67373/ State : failure == Summary == Applying: drm/i915: Initialise breadcrumb lists on the virtual engine Using index info to reconstruct a base tree.

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Ville Syrjälä wrote: > On Tue, Oct 01, 2019 at 05:28:51PM +0300, Jani Nikula wrote: >> On Tue, 01 Oct 2019, Ville Syrjälä wrote: >> > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: >> >> Quoting Jani Nikula (2019-10-01 14:43:53) >> >> > Split out code related t

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915: Create dumb buffer from LMEM (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Create dumb buffer from LMEM (rev2) URL : https://patchwork.freedesktop.org/series/67428/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK incl

[Intel-gfx] [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread Ville Syrjala
From: Ville Syrjälä When adding the max plane size checks to the .mode_valid() hooks I naturally forgot about MST. Take care of that one as well. Cc: Manasi Navare Cc: Sean Paul Cc: José Roberto de Souza Cc: Maarten Lankhorst Fixes: 2d20411e25a3 ("drm/i915: Don't advertise modes that exceed

[Intel-gfx] [PATCH 2/2] drm/i915: Polish intel_tv_mode_valid()

2019-10-01 Thread Ville Syrjala
From: Ville Syrjälä Drop the tv_mode NULL check since intel_tv_mode_find() never actually returns NULL, and flip the condition around so that the MODE_OK case is at the end, which is customary to all the other .mode_valid() implementations. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Describe structure members in documentation

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Describe structure members in documentation URL : https://patchwork.freedesktop.org/series/67442/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14607 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: split out intel_vga_client.[ch] URL : https://patchwork.freedesktop.org/series/67447/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1b290f96d25 drm/i915/display: split out intel_vga_client.[ch] -:91: WARNING:FILE_PATH_CHANGES: add

[Intel-gfx] ✗ Fi.CI.BAT: failure for Conclude load -> probe naming convention switch

2019-10-01 Thread Patchwork
== Series Details == Series: Conclude load -> probe naming convention switch URL : https://patchwork.freedesktop.org/series/67448/ State : failure == Summary == Series 67448 revision 1 Test-with: <20191001132728.14602-1-janusz.krzyszto...@linux.intel.com> not found __

  1   2   >