[Intel-gfx] [PATCH] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Chris Wilson
Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it using the kernel timeline. This is the same time

[Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Just a heads up that icl is consistently showing <4> [315.478830] snd_hda_intel :00:1f.3: azx_get_response timeout, switching to polling mode: last cmd=0x202f8100 <4> [316.482799] snd_hda_intel :00:1f.3: No response from codec, disabling MSI: last cmd=0x202f8100 <3> [508.412915] snd_hda_

[Intel-gfx] [PATCH] Revert "ALSA: line6: sizeof (byte) is always 1, use that fact."

2019-07-25 Thread Chris Wilson
Just a heads up that icl is consistently showing <4> [315.478830] snd_hda_intel :00:1f.3: azx_get_response timeout, switching to polling mode: last cmd=0x202f8100 <4> [316.482799] snd_hda_intel :00:1f.3: No response from codec, disabling MSI: last cmd=0x202f8100 <3> [508.412915] snd_hda_

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 10:03:00 +0200, Chris Wilson wrote: > > Just a heads up that icl is consistently showing > > <4> [315.478830] snd_hda_intel :00:1f.3: azx_get_response timeout, > switching to polling mode: last cmd=0x202f8100 > <4> [316.482799] snd_hda_intel :00:1f.3: No response from

[Intel-gfx] [PATCH] drm/i915: Use intel_gt directly when closing VMAs

2019-07-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Save one level of derefernce by not going via global i915. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_vma.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Unshare the idle-barrier from other kernel requests (rev3)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev3) URL : https://patchwork.freedesktop.org/series/64171/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4db89a82be2b drm/i915: Unshare the idle-barrier from other kernel requests -:114

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 10:16:07 +0200, Takashi Iwai wrote: > > On Thu, 25 Jul 2019 10:03:00 +0200, > Chris Wilson wrote: > > > > Just a heads up that icl is consistently showing > > > > <4> [315.478830] snd_hda_intel :00:1f.3: azx_get_response timeout, > > switching to polling mode: last cmd=0

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Quoting Takashi Iwai (2019-07-25 09:26:56) > On Thu, 25 Jul 2019 10:16:07 +0200, > Takashi Iwai wrote: > > > > On Thu, 25 Jul 2019 10:03:00 +0200, > > Chris Wilson wrote: > > > > > > Just a heads up that icl is consistently showing > > > > > > <4> [315.478830] snd_hda_intel :00:1f.3: azx_get

Re: [Intel-gfx] [PATCH] drm/i915: Use intel_gt directly when closing VMAs

2019-07-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-25 09:26:00) > From: Tvrtko Ursulin > > Save one level of derefernce by not going via global i915. This shouldn't actually be on intel_gt. It's used as a keepalive mechanism for GEM clients (the display servers that take a dri3 buffer from a client, show it and th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "ALSA: line6: sizeof (byte) is always 1, use that fact."

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: line6: sizeof (byte) is always 1, use that fact." URL : https://patchwork.freedesktop.org/series/64213/ State : warning == Summary == $ dim checkpatch origin/drm-tip 01fd92ee262b Revert "ALSA: line6: sizeof (byte) is always 1, use that fact." -:9: WAR

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unshare the idle-barrier from other kernel requests (rev3)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev3) URL : https://patchwork.freedesktop.org/series/64171/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6547 -> Patchwork_13742 S

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "ALSA: line6: sizeof (byte) is always 1, use that fact."

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: line6: sizeof (byte) is always 1, use that fact." URL : https://patchwork.freedesktop.org/series/64213/ State : success == Summary == CI Bug Log - changes from CI_DRM_6547 -> Patchwork_13743 Summar

[Intel-gfx] [PATCH] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Chris Wilson
Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it using the kernel timeline. This is the same time

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use intel_gt directly when closing VMAs

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Use intel_gt directly when closing VMAs URL : https://patchwork.freedesktop.org/series/64216/ State : success == Summary == CI Bug Log - changes from CI_DRM_6548 -> Patchwork_13744 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev2)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev2) URL : https://patchwork.freedesktop.org/series/64212/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5331d8b5ce96 Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Int

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev2)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev2) URL : https://patchwork.freedesktop.org/series/64212/ State : success == Summary == CI Bug Log - changes from CI_DRM_6548 -> Patchwork_13745 ===

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Quoting Chris Wilson (2019-07-25 09:30:25) > Quoting Takashi Iwai (2019-07-25 09:26:56) > > On Thu, 25 Jul 2019 10:16:07 +0200, > > Takashi Iwai wrote: > > > > > > On Thu, 25 Jul 2019 10:03:00 +0200, > > > Chris Wilson wrote: > > > > > > > > Just a heads up that icl is consistently showing > > >

Re: [Intel-gfx] [PATCH] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Lionel Landwerlin
On 25/07/2019 12:38, Chris Wilson wrote: Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it using

[Intel-gfx] [PATCH v10 2/9] drm/i915/perf: allow for CS OA configs to be created lazily

2019-07-25 Thread Lionel Landwerlin
Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace commands so that a particu

[Intel-gfx] [PATCH v10 1/9] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-07-25 Thread Lionel Landwerlin
Reporting this version will help application figure out what level of the support the running kernel provides. v2: Add i915_perf_ioctl_version() (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 3 +++ drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH v10 5/9] drm/i915: add syncobj timeline support

2019-07-25 Thread Lionel Landwerlin
Introduces a new parameters to execbuf so that we can specify syncobj handles as well as timeline points. v2: Reuse i915_user_extension_fn v3: Check that the chained extension is only present once (Chris) v4: Check that dma_fence_chain_find_seqno returns a non NULL fence (Lionel) v5: Use BIT_UL

[Intel-gfx] [PATCH v10 0/9] drm/i915: Vulkan performance query support

2019-07-25 Thread Lionel Landwerlin
Hi all, Just posted some tests : https://patchwork.freedesktop.org/series/64220/ And shockingly it found a few bugs. This series is also rebased on top of Chris' on the fly OA reconfiguration of contexts. Cheers, Lionel Landwerlin (9): drm/i915/perf: introduce a versioning of the i915-perf ua

[Intel-gfx] [PATCH v10 4/9] drm/i915: introduce a mechanism to extend execbuf2

2019-07-25 Thread Lionel Landwerlin
We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 32 ++- include/uapi/drm/i915_drm.h

[Intel-gfx] [PATCH v10 3/9] drm/i915/perf: implement active wait for noa configurations

2019-07-25 Thread Lionel Landwerlin
NOA configuration take some amount of time to apply. That amount of time depends on the size of the GT. There is no documented time for this. For example, past experimentations with powergating configuration changes seem to indicate a 60~70us delay. We go with 500us as default for now which should

[Intel-gfx] [PATCH v10 6/9] drm/i915: add a new perf configuration execbuf parameter

2019-07-25 Thread Lionel Landwerlin
We want the ability to dispatch a set of command buffer to the hardware, each with a different OA configuration. To achieve this, we reuse a couple of fields from the execbuf2 struct (I CAN HAZ execbuf3?) to notify what OA configuration should be used for a batch buffer. This requires the process m

[Intel-gfx] [PATCH v10 8/9] drm/i915/perf: execute OA configuration from command stream

2019-07-25 Thread Lionel Landwerlin
We haven't run into issues with programming the global OA/NOA registers configuration from CPU so far, but HW engineers actually recommend doing this from the command streamer. On TGL in particular one of the clock domain in which some of that programming goes might not be powered when we poke thin

[Intel-gfx] [PATCH v10 7/9] drm/i915/perf: allow holding preemption on filtered ctx

2019-07-25 Thread Lionel Landwerlin
We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command buffer. In OpenGL, the lack of

[Intel-gfx] [PATCH v10 9/9] drm/i915: add support for perf configuration queries

2019-07-25 Thread Lionel Landwerlin
Listing configurations at the moment is supported only through sysfs. This might cause issues for applications wanting to list configurations from a container where sysfs isn't available. This change adds a way to query the number of configurations and their content through the i915 query uAPI. v

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 12:21:11 +0200, Chris Wilson wrote: > > Quoting Chris Wilson (2019-07-25 09:30:25) > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > On Thu, 25 Jul 2019 10:16:07 +0200, > > > Takashi Iwai wrote: > > > > > > > > On Thu, 25 Jul 2019 10:03:00 +0200, > > > > Chris Wilson wrote:

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Quoting Takashi Iwai (2019-07-25 11:44:08) > On Thu, 25 Jul 2019 12:21:11 +0200, > Chris Wilson wrote: > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > > On Thu, 25 Jul 2019 10:16:07 +0200, > > > > Takashi Iwai wrote: > > > > > > > > > > On

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "ALSA: line6: sizeof (byte) is always 1, use that fact."

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: line6: sizeof (byte) is always 1, use that fact." URL : https://patchwork.freedesktop.org/series/64213/ State : success == Summary == CI Bug Log - changes from CI_DRM_6547_full -> Patchwork_13743_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Unshare the idle-barrier from other kernel requests (rev4)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev4) URL : https://patchwork.freedesktop.org/series/64171/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7e8e9ad5e045 drm/i915: Unshare the idle-barrier from other kernel requests -:115

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unshare the idle-barrier from other kernel requests (rev4)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev4) URL : https://patchwork.freedesktop.org/series/64171/ State : success == Summary == CI Bug Log - changes from CI_DRM_6549 -> Patchwork_13746 S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev10)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev10) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim checkpatch origin/drm-tip 63829d5dfc38 drm/i915/perf: introduce a versioning of the i915-perf uapi 499c943ab2e5 drm/i915/per

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unshare the idle-barrier from other kernel requests (rev4)

2019-07-25 Thread Chris Wilson
Quoting Patchwork (2019-07-25 12:44:16) > == Series Details == > > Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev4) > URL : https://patchwork.freedesktop.org/series/64171/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6549 -> Patchwork_137

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Vulkan performance query support (rev10)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev10) URL : https://patchwork.freedesktop.org/series/60916/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/perf: introduce a versioning of the i915-perf uapi Okay! Comm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3) URL : https://patchwork.freedesktop.org/series/64212/ State : warning == Summary == $ dim checkpatch origin/drm-tip b9d380a28e06 Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Int

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Vulkan performance query support (rev10)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev10) URL : https://patchwork.freedesktop.org/series/60916/ State : success == Summary == CI Bug Log - changes from CI_DRM_6549 -> Patchwork_13747 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3) URL : https://patchwork.freedesktop.org/series/64212/ State : success == Summary == CI Bug Log - changes from CI_DRM_6549 -> Patchwork_13748 ===

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Quoting Takashi Iwai (2019-07-25 11:44:08) > On Thu, 25 Jul 2019 12:21:11 +0200, > Chris Wilson wrote: > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > > On Thu, 25 Jul 2019 10:16:07 +0200, > > > > Takashi Iwai wrote: > > > > > > > > > > On

[Intel-gfx] [PATCH] drm/i915: Do not rely on for loop caching the mask

2019-07-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin for_each_engine_masked caches the engine mask but what does the caller know. Cache it explicitly for clarity and while at it correct the type to match. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 6 +++--- 1 file changed, 3 ins

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 14:50:18 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 11:44:08) > > On Thu, 25 Jul 2019 12:21:11 +0200, > > Chris Wilson wrote: > > > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > > > On Thu, 25 Jul

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Add to timeline requires the timeline mutex

2019-07-25 Thread Chris Wilson
Modifying a remote context requires careful serialisation with requests on that context, and that serialisation requires us to take their timeline->mutex. Make it so. Note that while struct_mutex rules, we can't create more than one request in parallel, but that age is soon coming to an end. v2:

[Intel-gfx] [PATCH 2/2] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Chris Wilson
Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it using the kernel timeline. This is the same time

Re: [Intel-gfx] [PATCH] drm/i915: Do not rely on for loop caching the mask

2019-07-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-25 13:50:56) > From: Tvrtko Ursulin > > for_each_engine_masked caches the engine mask but what does the caller > know. > > Cache it explicitly for clarity and while at it correct the type to match. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson Stealing

[Intel-gfx] [PATCH v3 4/5] drm/i915: utilize subconnector property for DP

2019-07-25 Thread Oleg Vasilev
Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself. Signed-off-by: Oleg Vasilev Cc: intel-gfx@lists.freedesktop.org v2: updates to match previous commit changes Signed-off-by: Oleg Vasilev --- drivers/gpu/drm/i915/dis

Re: [Intel-gfx] [PATCH] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Tvrtko Ursulin
On 25/07/2019 10:38, Chris Wilson wrote: Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it usin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use intel_gt directly when closing VMAs

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Use intel_gt directly when closing VMAs URL : https://patchwork.freedesktop.org/series/64216/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6548_full -> Patchwork_13744_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-25 14:19:22) > > On 25/07/2019 10:38, Chris Wilson wrote: > > @@ -352,22 +384,29 @@ int i915_active_acquire_preallocate_barrier(struct > > i915_active *ref, > > > > GEM_BUG_ON(!engine->mask); > > for_each_engine_masked(engine, i915, engine->mask, tmp

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 12:49:12 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 11:44:08) > > On Thu, 25 Jul 2019 12:21:11 +0200, > > Chris Wilson wrote: > > > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > > > On Thu, 25 Jul

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Chris Wilson
Quoting Takashi Iwai (2019-07-25 14:45:10) > On Thu, 25 Jul 2019 12:49:12 +0200, > Chris Wilson wrote: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13745/fi-icl-u2/igt@i915_module_l...@reload.html > > <4> [383.858354] snd_hda_intel :00:1f.3: azx_get_response timeout, > > switching to

[Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Update drawing for firmware layout

2019-07-25 Thread Michal Wajdeczko
Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics. v2: also update text and do it before move (Daniele) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- Documentation/gpu/i915.rst | 12 -

[Intel-gfx] [PATCH v2 1/3] drm/i915: Fix GuC documentation links

2019-07-25 Thread Michal Wajdeczko
We moved GuC related files to new location but we missed to update .rst file with links. References: commit 0f261b241d9c ("drm/i915/uc: move GuC and HuC files under gt/uc/") Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson Reviewed-by: Daniele Ceraolo Spurio --- Do

[Intel-gfx] [PATCH v2 3/3] drm/i915/uc: Move uc firmware layout definitions to dedicated file

2019-07-25 Thread Michal Wajdeczko
Generic uc firmware layout definitions are unlikely to change and are separate to other GuC specific definitions. v2: reordered Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio --- Documentation/gpu/i915.rst | 2 +- drivers/gpu/

[Intel-gfx] [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake

2019-07-25 Thread Michal Wajdeczko
From GT perspective, Comet Lake is just Coffe Lake rev 5, but there is dedicated GuC firmware for it. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] i915/gem_ctx_shared: Avoid clflush by using WC for readback

2019-07-25 Thread Matthew Auld
On Tue, 23 Jul 2019 at 17:17, Chris Wilson wrote: > > As we never officially write to the scratch buffer, the kernel will > leave it in the CPU read domain upon execution. Our attempt to > invalidate the CPU cache on !llc is therefore skipped as the kernel > doesn't believe the backing store has b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex

2019-07-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex URL : https://patchwork.freedesktop.org/series/64227/ State : warning == Summary == $ dim checkpatch origin/drm-tip 400f113b3b2b drm/i915/gt: Add to timeline requires the timeline

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 15:57:10 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 14:45:10) > > On Thu, 25 Jul 2019 12:49:12 +0200, > > Chris Wilson wrote: > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13745/fi-icl-u2/igt@i915_module_l...@reload.html > > > <4> [383.858354] sn

Re: [Intel-gfx] [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake

2019-07-25 Thread Daniele Ceraolo Spurio
On 7/25/19 7:27 AM, Michal Wajdeczko wrote: From GT perspective, Comet Lake is just Coffe Lake rev 5, but there is dedicated GuC firmware for it. According to Anusha there is also a dedicated HuC FW for it, which should be coming out soon, so we should probably wait and add them both at th

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not rely on for loop caching the mask

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Do not rely on for loop caching the mask URL : https://patchwork.freedesktop.org/series/64225/ State : success == Summary == CI Bug Log - changes from CI_DRM_6551 -> Patchwork_13749 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex

2019-07-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex URL : https://patchwork.freedesktop.org/series/64227/ State : success == Summary == CI Bug Log - changes from CI_DRM_6551 -> Patchwork_13750 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Fix GuC documentation links

2019-07-25 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Fix GuC documentation links URL : https://patchwork.freedesktop.org/series/64237/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ed7463b65ac drm/i915: Fix GuC documentation links -:9: WARNING:COMMIT_LOG_LONG_L

[Intel-gfx] [PULL] drm-misc-fixes

2019-07-25 Thread Sean Paul
Hi all, Substitute-Maarten here for another pull request. This week is pretty light, as you would expect. I merged a leftover nugget from drm-misc-next that didn't make -rc1 and am abusing covering for Maarten by sneaking in a handful of msm changes to avoid having to send 2 pulls. drm-misc-fixe

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Fix GuC documentation links

2019-07-25 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Fix GuC documentation links URL : https://patchwork.freedesktop.org/series/64237/ State : success == Summary == CI Bug Log - changes from CI_DRM_6551 -> Patchwork_13751 Su

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Define GuC firmware version for Comet Lake (rev5)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915/guc: Define GuC firmware version for Comet Lake (rev5) URL : https://patchwork.freedesktop.org/series/62969/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6552 -> Patchwork_13752 Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev4)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev4) URL : https://patchwork.freedesktop.org/series/64212/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4c375059e361 Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Int

[Intel-gfx] [PATCH] drm/i915/guc: init submission structures as part of guc_init

2019-07-25 Thread Daniele Ceraolo Spurio
guc->stage_desc_pool is required as part of the init parameters and there is no reason we have to init them after HuC. This fixes a NULL ptr dereference due to guc->stage_desc_pool not being set (no fixes tag since GuC submission can't be enabled yet). Signed-off-by: Daniele Ceraolo Spurio Cc: Mi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Unshare the idle-barrier from other kernel requests (rev4)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Unshare the idle-barrier from other kernel requests (rev4) URL : https://patchwork.freedesktop.org/series/64171/ State : success == Summary == CI Bug Log - changes from CI_DRM_6549_full -> Patchwork_13746_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev4)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev4) URL : https://patchwork.freedesktop.org/series/64212/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6552 -> Patchwork_13753 ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: init submission structures as part of guc_init

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915/guc: init submission structures as part of guc_init URL : https://patchwork.freedesktop.org/series/64254/ State : success == Summary == CI Bug Log - changes from CI_DRM_6552 -> Patchwork_13754 Summary -

[Intel-gfx] [PATCH] drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Chris Wilson
Currently we use the engine->active.lock to ensure that the request is not retired as we capture the data. However, we only need to ensure that the vma are not removed prior to use acquiring their contents, and since we have already relinquished our stop-machine protection, we assume that the user

Re: [Intel-gfx] [PATCH 18/22] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-25 Thread Lis, Tomasz
On 2019-07-25 00:32, Lucas De Marchi wrote: On Thu, Jul 18, 2019 at 10:09:27AM -0700, Daniele Ceraolo Spurio wrote: On 7/18/19 6:08 AM, Ville Syrjälä wrote: On Fri, Jul 12, 2019 at 06:09:36PM -0700, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Capture vma contents outside of spinlock URL : https://patchwork.freedesktop.org/series/64256/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Capture vma contents outside of spinlock -O:drivers/gpu/drm/i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Capture vma contents outside of spinlock URL : https://patchwork.freedesktop.org/series/64256/ State : success == Summary == CI Bug Log - changes from CI_DRM_6552 -> Patchwork_13755 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Vulkan performance query support (rev10)

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev10) URL : https://patchwork.freedesktop.org/series/60916/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6549_full -> Patchwork_13747_full Summary -

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Update drawing for firmware layout

2019-07-25 Thread Daniele Ceraolo Spurio
On 7/25/19 7:13 AM, Michal Wajdeczko wrote: Sphinx was rendering firmware layout as html table, but since we want to add sizes relations switch to plain text graphics. v2: also update text and do it before move (Daniele) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Reviewed-

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Update drawing for firmware layout

2019-07-25 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-07-25 21:16:23) > > > On 7/25/19 7:13 AM, Michal Wajdeczko wrote: > > Sphinx was rendering firmware layout as html table, but since > > we want to add sizes relations switch to plain text graphics. > > > > v2: also update text and do it before move (Daniele)

[Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Josh Poimboeuf
Objtool reports: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: .altinstr_replacement+0x36: redundant UACCESS disable __copy_from_user() already does both STAC and CLAC, so the user_access_end() in its error path adds an extra unnecessary CLAC. Fixes: 0b2c8f8b6b0c ("i915: f

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3)

2019-07-25 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" (rev3) URL : https://patchwork.freedesktop.org/series/64212/ State : success == Summary == CI Bug Log - changes from CI_DRM_6549_full -> Patchwork_13748_full =

[Intel-gfx] [PATCH] drm/i915/uc: Don't sanitize guc_log_level modparam

2019-07-25 Thread Michal Wajdeczko
We are already storing runtime value of log level in private field, so there is no need to modify modparam. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 29 - drivers/gpu/drm/i915/gt/uc/intel_uc.c | 50 -

[Intel-gfx] [PATCH] drm/i915/uc: Reorder params in intel_uc_fw_fetch

2019-07-25 Thread Michal Wajdeczko
All intel_uc_fw_* functions are taking uc_fw as first param except intel_uc_fw_fetch() which is taking i915. Fix that. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc.c| 4 ++-- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 8 +++- drivers

Re: [Intel-gfx] [PATCH] drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Matthew Auld
On Thu, 25 Jul 2019 at 19:24, Chris Wilson wrote: > > Currently we use the engine->active.lock to ensure that the request is > not retired as we capture the data. However, we only need to ensure that > the vma are not removed prior to use acquiring their contents, and > since we have already relin

Re: [Intel-gfx] [PATCH] drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Chris Wilson
Quoting Matthew Auld (2019-07-25 22:04:33) > On Thu, 25 Jul 2019 at 19:24, Chris Wilson wrote: > > > > Currently we use the engine->active.lock to ensure that the request is > > not retired as we capture the data. However, we only need to ensure that > > the vma are not removed prior to use acquir

Re: [Intel-gfx] [PATCH 07/23] drm/i915/gt: Move the [class][inst] lookup for engines onto the GT

2019-07-25 Thread Daniele Ceraolo Spurio
On 7/23/19 11:38 AM, Chris Wilson wrote: To maintain a fast lookup from a GT centric irq handler, we want the engine lookup tables on the intel_gt. To avoid having multiple copies of the same multi-dimension lookup table, move the generic user engine lookup into an rbtree (for fast and flexible

Re: [Intel-gfx] [PATCH] drm/i915/uc: Reorder params in intel_uc_fw_fetch

2019-07-25 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-25 22:03:14) > All intel_uc_fw_* functions are taking uc_fw as first param > except intel_uc_fw_fetch() which is taking i915. Fix that. > > Signed-off-by: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio Has a certain logic to it, Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH] drm/i915/uc: Don't sanitize guc_log_level modparam

2019-07-25 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-25 21:51:06) > We are already storing runtime value of log level in private > field, so there is no need to modify modparam. There is an aspect of communicating the clamped value back to the user. Does that have any value or alternative? -Chris ___

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Thomas Gleixner
On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > Objtool reports: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x36: redundant UACCESS disable > > __copy_from_user() already does both STAC and CLAC, so the > user_access_end() in its error path adds

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant user_access_end() from __copy_from_user() error path URL : https://patchwork.freedesktop.org/series/64262/ State : success == Summary == CI Bug Log - changes from CI_DRM_6553 -> Patchwork_13756 ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Don't sanitize guc_log_level modparam

2019-07-25 Thread Patchwork
== Series Details == Series: drm/i915/uc: Don't sanitize guc_log_level modparam URL : https://patchwork.freedesktop.org/series/64264/ State : success == Summary == CI Bug Log - changes from CI_DRM_6553 -> Patchwork_13757 Summary ---

[Intel-gfx] [CI] drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Chris Wilson
Currently we use the engine->active.lock to ensure that the request is not retired as we capture the data. However, we only need to ensure that the vma are not removed prior to use acquiring their contents, and since we have already relinquished our stop-machine protection, we assume that the user

[Intel-gfx] [PATCH 2/5] drm/i915/gt: Add to timeline requires the timeline mutex

2019-07-25 Thread Chris Wilson
Modifying a remote context requires careful serialisation with requests on that context, and that serialisation requires us to take their timeline->mutex. Make it so. Note that while struct_mutex rules, we can't create more than one request in parallel, but that age is soon coming to an end. v2:

[Intel-gfx] [PATCH 5/5] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH 1/5] drm/i915: Capture vma contents outside of spinlock

2019-07-25 Thread Chris Wilson
Currently we use the engine->active.lock to ensure that the request is not retired as we capture the data. However, we only need to ensure that the vma are not removed prior to use acquiring their contents, and since we have already relinquished our stop-machine protection, we assume that the user

[Intel-gfx] [PATCH 3/5] drm/i915: Unshare the idle-barrier from other kernel requests

2019-07-25 Thread Chris Wilson
Under some circumstances (see intel_context_prepare_remote_request), we may use a request along a kernel context to modify the logical state of another. To keep the target context in place while the request executes, we take an active reference on it using the kernel timeline. This is the same time

[Intel-gfx] [PATCH 4/5] drm/i915/execlists: Force preemption

2019-07-25 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of flagging

[Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Replace sampling the engine state every so often with a periodic heartbeat request to measure the health of an engine. This is coupled with the forced-preemption to allow long running requests to survive so long as they do not block other users. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 25, 2019 4:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Joonas Lahtinen > ; Ursulin, Tvrtko ; > Bloomfield, Jon > Subject: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Replace sampling the engin

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-25 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 00:21:47) > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 25, 2019 4:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Chris Wilson ; Joonas Lahtinen > > ; Ursulin, Tvrtko > > ; > > Bloomfield, Jon > > Subject: [PATCH] drm/i9

[Intel-gfx] [CI 2/3] drm/i915/tgl: select correct bit for port select

2019-07-25 Thread Lucas De Marchi
From: Mahesh Kumar Bit definitions for port-select got changed for TRANS_CLK_SEL & TRANS_DDI_FUNC_CTL registers in TGL. v2 (Lucas): - Nuke TRANS_DDI_PORT_NONE since it's 0: we are already clearing {TGL_,}TRANS_DDI_PORT_MASK (suggested by Ville) - Also cover haswell_get_ddi_port_state() i

[Intel-gfx] [CI 3/3] drm/i915/tgl: update ddi/tc clock_off bits

2019-07-25 Thread Lucas De Marchi
From: Mahesh Kumar In GEN 12 PORT_C DDI clk_off bit is not equally distanced to A/B, it's at offset 24. Similarly TC port (5/6) clk off bits are at offset 22/23. Extend the macros to cover the additional ports. Cc: Matt Roper Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed

  1   2   >