[Intel-gfx] [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

2019-07-12 Thread John . C . Harrison
From: John Harrison Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only. v2: Removed all use of 'rsvd' for read-only registers to avoid ambiguous code or error messages. Signed-off-by:

[Intel-gfx] [PATCH v2 0/3] Improve whitelist selftest for read-only registers

2019-07-12 Thread John . C . Harrison
From: John Harrison Follow up patch to earlier whitelist updates. This series adds some extra sanity checking to the driver and improves the self-test. v2: Resolved abiguity over meaning of 'rsvd' in read-only mode by removing it. Rebased to newer tree. John Harrison (3): drm/i915: Add test f

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add engine name to workaround debug print

2019-07-12 Thread John . C . Harrison
From: John Harrison There is a debug message in the workaround initialisation path that reports how many entries were added of each type. However, whitelist workarounds exist for multiple engines but the type name is just 'whitelist'. Tvrtko suggested adding the engine name to make the message mo

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add test for invalid flag bits in whitelist entries

2019-07-12 Thread John . C . Harrison
From: John Harrison As per review feedback by Tvrtko, added a check that no invalid bits are being set in the whitelist flags fields. Also updated the read/write access definitions to make it clearer that they are an enum field not a set of single bit flags. Signed-off-by: John Harrison CC: Tv

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915: Rename "_load"/"_unload" to match PCI entry points

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:53) > Current names of i915_driver_load/unload() functions originate in > legacy DRM stubs. Reduce nomenclature ambiguity by renaming them to > match their current use as helpers called from PCI entry points. > > Suggested by: Chris Wilson > Signed-of

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Replace "_load" with "_probe" consequently

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:54) > Use the "_probe" nomenclature not only in i915_driver_probe() helper > name but also in other related function / variable names for > consistency. > Only the userspace exposed name of a related module > parameter is left untouched. Syncing with

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:55) > Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names > of fucntions called from i915_driver_release() with "_release" suffix > consistently. This provides better code readability, especially > helpful when trying to work out whic

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:55) > Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names > of fucntions called from i915_driver_release() with "_release" suffix ^- typo Regards, Joonas ___ Intel-gfx mailing list Int

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Propagate "_remove" function name suffix down

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:56) > Similar to the "_release" case, consistently replace mixed > "_cleanup"/"_fini"/"_fini_hw" components found in names of functions > called from i915_driver_remove() with "_remove" or "_driver_remove" > suffixes for better code readability. > > Sig

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Propagate "_probe" function name suffix down

2019-07-12 Thread Joonas Lahtinen
Quoting Janusz Krzysztofik (2019-07-11 10:31:57) > Similar to the "_release" and "_remove" cases, consequently replace > "_init" components of names of functions called from > i915_driver_probe() with "_probe" suffixes for better code readability. > > Signed-off-by: Janusz Krzysztofik Reviewed-b

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Rename functions to match their entry points

2019-07-12 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-07-11 10:40:02) > Quoting Janusz Krzysztofik (2019-07-11 08:31:52) > > Need for this was identified while working on split of driver unbind > > path into _remove() and _release() parts. Consistency in function > > naming has been recognized as helpful when trying to work

Re: [Intel-gfx] [PATCH v4 15/23] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-12 Thread Benjamin Gaignard
Le jeu. 11 juil. 2019 à 13:30, Andrzej Pietrasiewicz a écrit : > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dri

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve whitelist selftest for read-only registers (rev2)

2019-07-12 Thread Patchwork
== Series Details == Series: Improve whitelist selftest for read-only registers (rev2) URL : https://patchwork.freedesktop.org/series/63102/ State : success == Summary == CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13634 Summary

[Intel-gfx] [CI] drm/i915/gtt: Use shallow dma pages for scratch

2019-07-12 Thread Chris Wilson
We only use the dma pages for scratch, and so do not need to allocate the extra storage for the shadow page directory. v2: Refrain from reintroducing I915_PDES Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 196 --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Use shallow dma pages for scratch (rev2)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Use shallow dma pages for scratch (rev2) URL : https://patchwork.freedesktop.org/series/63595/ State : warning == Summary == $ dim checkpatch origin/drm-tip 820b8449637c drm/i915/gtt: Use shallow dma pages for scratch -:540: CHECK:MACRO_ARG_REUSE: Mac

[Intel-gfx] [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-12 Thread Chris Wilson
Since kmalloc() will round up the allocation to the next slab size or page, it will normally return a pointer to a memory block bigger than we asked for. We can query for the actual size of the allocated block using ksize() and expand our variable size reservation_list to take advantage of that ext

[Intel-gfx] [PATCH 2/2] dma-buf: Relax the write-seqlock for reallocating the shared fence list

2019-07-12 Thread Chris Wilson
As the set of shared fences is not being changed during reallocation of the reservation list, we can skip updating the write_seqlock. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Christian König --- drivers/dma-buf/reservation.c | 14 +++--- 1 file changed, 7 insertions(+), 7 dele

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gtt: Use shallow dma pages for scratch (rev2)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Use shallow dma pages for scratch (rev2) URL : https://patchwork.freedesktop.org/series/63595/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Use shallow dma pages for scratch -O:drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-12 Thread Joonas Lahtinen
+ Zhenyu as FYI Quoting Chris Wilson (2019-07-02 14:56:04) > Quoting Michał Winiarski (2019-07-02 12:31:48) > > This reverts commit 4395890a48551982549d222d1923e2833dac47cf. > > > > It's been over a year since this was merged, and the actual users of > > intel_ppat_get / intel_ppat_put never mate

[Intel-gfx] [PATCH v3] drm/i915: Fix wrong escape clock divisor init for GLK

2019-07-12 Thread Stanislav Lisovskiy
According to Bspec clock divisor registers in GeminiLake should be initialized by shifting 1(<<) to amount of correspondent divisor. While i915 was writing all this time that value as is. Surprisingly that it by accident worked, until we met some issues with Microtech Etab. v2: Added Fixes tag an

[Intel-gfx] [PATCH] drm/i915/selftests: Ignore self-preemption suppression under gvt

2019-07-12 Thread Chris Wilson
GVT forces single port submission of individual requests. We do not enjoy the context amalgamation that the test depends upon for setting up the test (where port 0 has a large number of requests with a priority change somewhere in the middle). Under single request submission of gvt it is quite able

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-12 Thread Zhenyu Wang
On 2019.07.12 11:06:01 +0300, Joonas Lahtinen wrote: > + Zhenyu as FYI > > Quoting Chris Wilson (2019-07-02 14:56:04) > > Quoting Michał Winiarski (2019-07-02 12:31:48) > > > This reverts commit 4395890a48551982549d222d1923e2833dac47cf. > > > > > > It's been over a year since this was merged, and

[Intel-gfx] [PULL] drm-misc-next-fixes

2019-07-12 Thread Maarten Lankhorst
drm-misc-next-fixes-2019-07-11: Pull request for drm-misc-fixes-next for v5.3: - Revert properties exposed in komeda that need improvement before they become ABI. - Only add modes from the cmdline if they are valid. - Add orientation quirk for GPD MicroPC. - Reduce stack usage in drm selftests. -

Re: [Intel-gfx] [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-12 Thread Michel Dänzer
On 2019-07-12 10:03 a.m., Chris Wilson wrote: > Since kmalloc() will round up the allocation to the next slab size or > page, it will normally return a pointer to a memory block bigger than we > asked for. We can query for the actual size of the allocated block using > ksize() and expand our variab

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Use shallow dma pages for scratch (rev2)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Use shallow dma pages for scratch (rev2) URL : https://patchwork.freedesktop.org/series/63595/ State : success == Summary == CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13635 Summary ---

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-12 Thread Wang, Zhi A
It's quite a long time ago. I cannot fully remember the whole picture now. I remembered the last status was to push some unit tests and with the last part of patch. Currently I think you can revert this if it causes troubles, we can purpose this again if we need this in future. Thanks, Zhi. --

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Add test for invalid flag bits in whitelist entries

2019-07-12 Thread Tvrtko Ursulin
On 12/07/2019 08:07, john.c.harri...@intel.com wrote: From: John Harrison As per review feedback by Tvrtko, added a check that no invalid bits are being set in the whitelist flags fields. Also updated the read/write access definitions to make it clearer that they are an enum field not a set o

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add engine name to workaround debug print

2019-07-12 Thread Tvrtko Ursulin
On 12/07/2019 08:07, john.c.harri...@intel.com wrote: From: John Harrison There is a debug message in the workaround initialisation path that reports how many entries were added of each type. However, whitelist workarounds exist for multiple engines but the type name is just 'whitelist'. Tvrt

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

2019-07-12 Thread Tvrtko Ursulin
On 12/07/2019 08:07, john.c.harri...@intel.com wrote: From: John Harrison Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only. v2: Removed all use of 'rsvd' for read-only registers to

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Implement read-only support in whitelist selftest

2019-07-12 Thread Tvrtko Ursulin
On 12/07/2019 08:07, john.c.harri...@intel.com wrote: > From: John Harrison > > Newer hardware supports extra feature in the whitelist registers. This > patch updates the selftest to test that entries marked as read only > are actually read only. > > v2: Removed all use of 'rsvd' for read-only

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] dma-buf: Expand reservation_list to fill allocation

2019-07-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] dma-buf: Expand reservation_list to fill allocation URL : https://patchwork.freedesktop.org/series/63615/ State : success == Summary == CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13636

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix wrong escape clock divisor init for GLK (rev3)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix wrong escape clock divisor init for GLK (rev3) URL : https://patchwork.freedesktop.org/series/63505/ State : warning == Summary == $ dim checkpatch origin/drm-tip bcd7871af13d drm/i915: Fix wrong escape clock divisor init for GLK -:43: WARNING:NO_AUTH

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Improve whitelist selftest for read-only registers (rev2)

2019-07-12 Thread Tvrtko Ursulin
On 12/07/2019 08:55, Patchwork wrote: == Series Details == Series: Improve whitelist selftest for read-only registers (rev2) URL : https://patchwork.freedesktop.org/series/63102/ State : success == Summary == CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13634 =

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Replace "_load" with "_probe" consequently

2019-07-12 Thread Janusz Krzysztofik
On Friday, July 12, 2019 9:36:31 AM CEST Joonas Lahtinen wrote: > Quoting Janusz Krzysztofik (2019-07-11 10:31:54) > > Use the "_probe" nomenclature not only in i915_driver_probe() helper > > name but also in other related function / variable names for > > consistency. > > > Only the userspace ex

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix wrong escape clock divisor init for GLK (rev3)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix wrong escape clock divisor init for GLK (rev3) URL : https://patchwork.freedesktop.org/series/63505/ State : success == Summary == CI Bug Log - changes from CI_DRM_6469 -> Patchwork_13637 Summary -

[Intel-gfx] [CI 6/6] drm/i915/gtt: Use NULL to encode scratch shadow entries

2019-07-12 Thread Chris Wilson
We can simplify our gtt walking code by comparing against NULL for scratch entries as opposed to looking up the distinct per-level scratch pointer. The only caveat is to remember to protect external parties and map the NULL to the scratch top pd. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuo

[Intel-gfx] [CI 2/6] drm/i915/gtt: Reorder gen8 ppgtt free/clear/alloc

2019-07-12 Thread Chris Wilson
In preparation for refactoring the free/clear/alloc, first move the code around so that we can avoid forward declarations in the next set of patches. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 673 ++-- 1 file changed

[Intel-gfx] [CI 1/6] drm/i915/gtt: Wrap page_table with page_directory

2019-07-12 Thread Chris Wilson
The page directory extends the page table with the shadow entries. Make the page directory struct embed the page table for easier code reuse. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [CI 3/6] drm/i915/gtt: Markup i915_ppgtt height

2019-07-12 Thread Chris Wilson
This will be useful to consolidate recursive code. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 ++ drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/

[Intel-gfx] [CI 5/6] drm/i915/gtt: Convert vm->scratch into an array

2019-07-12 Thread Chris Wilson
Each level has its own scratch. Make the levels more obvious by forgoing the fancy similarly names and replace them with a number. 0 is the bottom most level, the physical page used for actual data; 1+ are the page directories. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/

[Intel-gfx] [CI 4/6] drm/i915/gtt: Compute the radix for gen8 page table levels

2019-07-12 Thread Chris Wilson
The radix levels of each page directory are easily determined so replace the numerous hardcoded constants with precomputed derived constants. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 42 + drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH 14/14] drm/i915/gt: Use intel_gt as the primary object for handling resets

2019-07-12 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-07-11 21:45:36) > > > > --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c > > +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c > > @@ -256,7 +256,7 @@ int __i915_live_setup(void *data) > > { > > struct drm_i915_private *i915 = data; > > > > -

[Intel-gfx] [PATCH i-g-t] [RFT] What's up with Broadwater?

2019-07-12 Thread Chris Wilson
Just a poke to see if we still get mystery failures with MI_STORE_DWORD_IMM or maybe we've cracked the flushing! --- lib/igt_gt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/igt_gt.c b/lib/igt_gt.c index 78e3cd089..2d0a34b22 100644 --- a/lib/igt_gt.c +++ b/lib/igt_gt.c @@ -572,9 +572

Re: screen freeze with 5.2-rc6 Dell XPS-13 skylake i915

2019-07-12 Thread Paul Bolle
Paul Bolle schreef op do 11-07-2019 om 13:20 [+0200]: > Chris Wilson schreef op do 11-07-2019 om 10:29 [+0100]: > > Temporary workaround would be to set i915.enable_psr=0 > > That workaround seems to work for me. Over an hour of uptime without any > screen freezes. May or may not be related: 24 h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Ignore self-preemption suppression under gvt

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Ignore self-preemption suppression under gvt URL : https://patchwork.freedesktop.org/series/63619/ State : success == Summary == CI Bug Log - changes from CI_DRM_6471 -> Patchwork_13638 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Revert "drm/i915: Enable PSR2 by default"

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Revert "drm/i915: Enable PSR2 by default" URL : https://patchwork.freedesktop.org/series/63548/ State : success == Summary == CI Bug Log - changes from CI_DRM_6458_full -> Patchwork_13620_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory

2019-07-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory URL : https://patchwork.freedesktop.org/series/63629/ State : warning == Summary == $ dim checkpatch origin/drm-tip 203c4b085992 drm/i915/gtt: Wrap page_table with page_directory -:385

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory

2019-07-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory URL : https://patchwork.freedesktop.org/series/63629/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Wrap page_table with page_d

Re: [Intel-gfx] [PATCH v4 23/23] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-12 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 01:26:50PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. We already have a symlink via intel_hdmi_create_i2c_symlink(). I guess we should remove that in favor of the generic one. Oleg? > > Signed-off-by: Andrzej Pietrasiewicz

Re: [Intel-gfx] [PATCH v4 01/23] drm: Include ddc adapter pointer in struct drm_connector

2019-07-12 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 01:26:28PM +0200, Andrzej Pietrasiewicz wrote: > Add generic code which creates symbolic links in sysfs, pointing to ddc > interface used by a particular video output. For example: > > ls -l /sys/class/drm/card0-HDMI-A-1/ddc > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/clas

Re: [Intel-gfx] [PATCH v9 1/6] drm: Add Content protection type property

2019-07-12 Thread Pekka Paalanen
On Thu, 11 Jul 2019 11:20:49 +0530 Ramalingam C wrote: > On 2019-07-10 at 11:16:24 +0300, Pekka Paalanen wrote: > > On Tue, 9 Jul 2019 18:17:59 +0530 > > Ramalingam C wrote: > > > > > On 2019-07-09 at 17:31:10 +0300, Pekka Paalanen wrote: > > > > On Mon, 8 Jul 2019 16:51:11 +0530 > > > > R

[Intel-gfx] [PATCH v3 2/6] drm/i915: Rename "_load"/"_unload" to match PCI entry points

2019-07-12 Thread Janusz Krzysztofik
Current names of i915_driver_load/unload() functions originate in legacy DRM stubs. Reduce nomenclature ambiguity by renaming them to match their current use as helpers called from PCI entry points. Suggested by: Chris Wilson Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH v3 6/6] drm/i915: Propagate "_probe" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Similar to the "_release" and "_remove" cases, consequently replace "_init" components of names of functions called from i915_driver_probe() with "_probe" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_drv.c | 26 +-

[Intel-gfx] [PATCH v3 0/6] drm/i915: Rename functions to match their entry points

2019-07-12 Thread Janusz Krzysztofik
Need for this was identified while working on split of driver unbind path into _remove() and _release() parts. Consistency in function naming has been recognized as helpful when trying to work out which phase the code is in. v2: * early_probe pairs better with late_release (Chris), * exclude

[Intel-gfx] [PATCH v3 4/6] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names of functions called from i915_driver_release() with "_release" suffix consistently. This provides better code readability, especially helpful when trying to work out which phase the code is in. Functions names starting with "i

[Intel-gfx] [PATCH v3 5/6] drm/i915: Propagate "_remove" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Similar to the "_release" case, consistently replace mixed "_cleanup"/"_fini"/"_fini_hw" components found in names of functions called from i915_driver_remove() with "_remove" or "_driver_remove" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH v3 3/6] drm/i915: Replace "_load" with "_probe" consequently

2019-07-12 Thread Janusz Krzysztofik
Use the "_probe" nomenclature not only in i915_driver_probe() helper name but also in other related function / variable names for consistency. Only the userspace exposed name of a related module parameter is left untouched. Signed-off-by: Janusz Krzysztofik --- .../gpu/drm/i915/display/intel_co

[Intel-gfx] [PATCH v3 1/6] drm/i915: Drop extern qualifiers from header function prototypes

2019-07-12 Thread Janusz Krzysztofik
Follow dim checkpatch recommendation so it doesn't complain on that now and again on header file modifications. v2: drop testing leftover (Chris) Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +- drivers/gpu/drm/i915/gvt/gtt.h | 13 +++--- dri

[Intel-gfx] [PATCH 0/2] Enable HuC by default for Gen11+

2019-07-12 Thread Michal Wajdeczko
HuC firmware is required to unlock advanced video codecs in media driver. Let's enable it by default for Gen11+ platforms, where we know it works. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Michal Wajdeczko (2): drm/i915/guc: Don't enab

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory

2019-07-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/gtt: Wrap page_table with page_directory URL : https://patchwork.freedesktop.org/series/63629/ State : success == Summary == CI Bug Log - changes from CI_DRM_6471 -> Patchwork_13639 ===

Re: [Intel-gfx] [PATCH v3 0/6] drm/i915: Rename functions to match their entry points

2019-07-12 Thread Janusz Krzysztofik
On Friday, July 12, 2019 1:12:52 PM CEST Janusz Krzysztofik wrote: > Need for this was identified while working on split of driver unbind > path into _remove() and _release() parts. Consistency in function > naming has been recognized as helpful when trying to work out which > phase the code is in

[Intel-gfx] ✗ Fi.CI.BAT: failure for Docs: move more driver, device related docs into drivers dir follows kernel source

2019-07-12 Thread Patchwork
== Series Details == Series: Docs: move more driver, device related docs into drivers dir follows kernel source URL : https://patchwork.freedesktop.org/series/63633/ State : failure == Summary == Applying: Docs: move more driver, device related docs into drivers dir follows kernel source err

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-12 Thread Michal Wajdeczko
Using "enable_guc" modparam auto mode (-1) will let driver decide on which platforms and in which configuration we want to use GuC/HuC firmwares. Today driver will enable HuC firmware authentication by GuC only on Gen11+ platforms as HuC firmware is required to unlock advanced video codecs in medi

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

2019-07-12 Thread Michal Wajdeczko
We are about to change default setting of "enable_guc" modparam from 0(disabled) to -1(auto). As we only want to turn on GuC/HuC on Gen11+, keep it off for older gens. Note that it would be still possible to enable GuC/HuC on these old platforms using explicit "enable_guc=2" modparam. Signed-off-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

2019-07-12 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2019-07-12 14:14:44) > We are about to change default setting of "enable_guc" modparam > from 0(disabled) to -1(auto). As we only want to turn on > GuC/HuC on Gen11+, keep it off for older gens. > > Note that it would be still possible to enable GuC/HuC on these > old pla

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-12 Thread Joonas Lahtinen
Quoting Michal Wajdeczko (2019-07-12 14:14:45) > Using "enable_guc" modparam auto mode (-1) will let driver > decide on which platforms and in which configuration we want > to use GuC/HuC firmwares. > > Today driver will enable HuC firmware authentication by GuC > only on Gen11+ platforms as HuC f

[Intel-gfx] [RESUBMIT PATCH v3 1/6] drm/i915: Drop extern qualifiers from header function prototypes

2019-07-12 Thread Janusz Krzysztofik
Follow dim checkpatch recommendation so it doesn't complain on that now and again on header file modifications. v2: drop testing leftover (Chris) Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +- drivers/gpu/drm/i915/gvt/gtt.h

[Intel-gfx] [RESUBMIT PATCH v3 2/6] drm/i915: Rename "_load"/"_unload" to match PCI entry points

2019-07-12 Thread Janusz Krzysztofik
Current names of i915_driver_load/unload() functions originate in legacy DRM stubs. Reduce nomenclature ambiguity by renaming them to match their current use as helpers called from PCI entry points. Suggested by: Chris Wilson Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson Reviewed

[Intel-gfx] [RESUBMIT PATCH v3 4/6] drm/i915: Propagate "_release" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Replace mixed "_fini"/"_cleanup"/"_cleanup_hw" suffixes found in names of functions called from i915_driver_release() with "_release" suffix consistently. This provides better code readability, especially helpful when trying to work out which phase the code is in. Functions names starting with "i

[Intel-gfx] [RESUBMIT PATCH v3 5/6] drm/i915: Propagate "_remove" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Similar to the "_release" case, consistently replace mixed "_cleanup"/"_fini"/"_fini_hw" components found in names of functions called from i915_driver_remove() with "_remove" or "_driver_remove" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson Re

[Intel-gfx] [RESUBMIT PATCH v3 3/6] drm/i915: Replace "_load" with "_probe" consequently

2019-07-12 Thread Janusz Krzysztofik
Use the "_probe" nomenclature not only in i915_driver_probe() helper name but also in other related function / variable names for consistency. Only the userspace exposed name of a related module parameter is left untouched. Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson Reviewed-by

[Intel-gfx] [RESUBMIT PATCH v3 0/6] drm/i915: Rename functions to match their entry points

2019-07-12 Thread Janusz Krzysztofik
Need for this was identified while working on split of driver unbind path into _remove() and _release() parts. Consistency in function naming has been recognized as helpful when trying to work out which phase the code is in. v2: * early_probe pairs better with late_release (Chris), * exclude

[Intel-gfx] [RESUBMIT PATCH v3 6/6] drm/i915: Propagate "_probe" function name suffix down

2019-07-12 Thread Janusz Krzysztofik
Similar to the "_release" and "_remove" cases, consequently replace "_init" components of names of functions called from i915_driver_probe() with "_probe" suffixes for better code readability. Signed-off-by: Janusz Krzysztofik Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/

[Intel-gfx] [PATCH 1/4] drm/i915/gtt: Recursive cleanup for gen8

2019-07-12 Thread Chris Wilson
With an explicit level, we can refactor the separate cleanup functions as a simple recursive function. We take the opportunity to pass down the size of each level so that we can deal with the different sizes of top-level and avoid over allocating for 32/36-bit vm. Signed-off-by: Chris Wilson ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Don't enable GuC/HuC in auto mode on pre-Gen11

2019-07-12 Thread Rodrigo Vivi
On Fri, Jul 12, 2019 at 11:14:44AM +, Michal Wajdeczko wrote: > We are about to change default setting of "enable_guc" modparam > from 0(disabled) to -1(auto). As we only want to turn on > GuC/HuC on Gen11+, keep it off for older gens. > > Note that it would be still possible to enable GuC/HuC

[Intel-gfx] [PATCH 2/4] drm/i915/gtt: Recursive ppgtt clear for gen8

2019-07-12 Thread Chris Wilson
With an explicit level, we can refactor the separate clear functions as a simple recursive function. The additional knowledge of the level allows us to spot when we can free an entire subtree at once. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug | 15 +++ drivers/gpu/drm/

[Intel-gfx] ppGTT the recursive wars

2019-07-12 Thread Chris Wilson
Doing more with less! We restore and succesfully generalise a recently lost optimisation to avoid updating page directories to be removed, all while using less i$ and hopefully more predictable branches. Mircoptimisations, but less code for the win. We even add some debug traces for the next poor

[Intel-gfx] [PATCH 4/4] drm/i915/gtt: Tidy up ppgtt insertion for gen8

2019-07-12 Thread Chris Wilson
Apply the new radix shift helpers to extract the multi-level indices cleanly when inserting pte into the gtt tree. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 115 +++- drivers/gpu/drm/i915/i915_gem_gtt.h | 90 ++ 2 files cha

[Intel-gfx] [PATCH 3/4] drm/i915/gtt: Recursive ppgtt alloc for gen8

2019-07-12 Thread Chris Wilson
Refactor the separate allocation routines into a single recursive function. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 272 ++-- 1 file changed, 97 insertions(+), 175 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-12 Thread Rodrigo Vivi
On Fri, Jul 12, 2019 at 11:14:45AM +, Michal Wajdeczko wrote: > Using "enable_guc" modparam auto mode (-1) will let driver > decide on which platforms and in which configuration we want > to use GuC/HuC firmwares. > > Today driver will enable HuC firmware authentication by GuC > only on Gen11+

Re: [Intel-gfx] [PATCH v2] drm/i915: Drop extern qualifiers from header function prototypes

2019-07-12 Thread Janusz Krzysztofik
On Thursday, July 11, 2019 8:55:05 AM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-07-11 07:50:01) > > Follow dim checkpatch recommendation so it doesn't complain on that now > > and again on header file modifications. > > > > v2: Drop testing leftover > > > > Signed-off-by: Janusz

Re: [Intel-gfx] [PATCH v9 1/6] drm: Add Content protection type property

2019-07-12 Thread Pekka Paalanen
On Thu, 11 Jul 2019 10:18:22 -0400 Sean Paul wrote: > On Mon, Jul 08, 2019 at 04:51:11PM +0530, Ramalingam C wrote: > > This patch adds a DRM ENUM property to the selected connectors. > > This property is used for mentioning the protected content's type > > from userspace to kernel HDCP authentic

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

2019-07-12 Thread Ser, Simon
On Thu, 2019-07-11 at 23:44 -0300, Rodrigo Siqueira wrote: > On 07/10, Ser, Simon wrote: > > Hi, > > > > Thanks for the patch! Here are a few comments. > > > > For bonus points, it would be nice to add igt_describe descriptions of > > each sub-test. > > Hi Simon, > > First of all, thanks for yo

Re: [Intel-gfx] [PATCH v9 1/6] drm: Add Content protection type property

2019-07-12 Thread Ramalingam C
On 2019-07-12 at 14:11:05 +0300, Pekka Paalanen wrote: > On Thu, 11 Jul 2019 11:20:49 +0530 > Ramalingam C wrote: > > > On 2019-07-10 at 11:16:24 +0300, Pekka Paalanen wrote: > > > On Tue, 9 Jul 2019 18:17:59 +0530 > > > Ramalingam C wrote: > > > > > > > On 2019-07-09 at 17:31:10 +0300, Pekka

[Intel-gfx] [PATCH] drm/vgem: Reclassify buffer creation debug message

2019-07-12 Thread Chris Wilson
A buffer is created in response to the user ioctl, it should therefore be a plain DRM_DEBUG() message to reflect it being a user invoked response and not a driver construct. This is just to make the commonplace drm.debug=[26e] quieter when running with vgem. Signed-off-by: Chris Wilson Cc: Danie

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename functions to match their entry points (rev2)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Rename functions to match their entry points (rev2) URL : https://patchwork.freedesktop.org/series/63541/ State : success == Summary == CI Bug Log - changes from CI_DRM_6471 -> Patchwork_13641 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default"

2019-07-12 Thread Rodrigo Vivi
On Thu, Jul 11, 2019 at 12:08:12PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2019-07-11 12:02:01) > > On Thu, Jul 11, 2019 at 10:22:54AM +0100, Chris Wilson wrote: > > > Multiple users are reporting black screens upon boot, after resume, or > > > frozen after a short period of idleness. A

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

2019-07-12 Thread Ser, Simon
On Thu, 2019-07-11 at 23:49 -0300, Rodrigo Siqueira wrote: > On 07/10, Ser, Simon wrote: > > On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > > > Mostly LGTM, here are a few nits. > > > > > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > > > > To use writeback buffers as a CRC so

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 4/6] kms_writeback: Add writeback-check-output

2019-07-12 Thread Ser, Simon
Mostly looks good, here are a few comments. On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > Add a test which makes commits using the writeback connector, and > checks the output buffer hash to make sure it is/isn't written as > appropriate. > > Signed-off-by: Brian Starkey > --- > tes

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HuC by default for Gen11+

2019-07-12 Thread Patchwork
== Series Details == Series: Enable HuC by default for Gen11+ URL : https://patchwork.freedesktop.org/series/63635/ State : success == Summary == CI Bug Log - changes from CI_DRM_6472 -> Patchwork_13642 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/display/icl: Bump up the vdisplay to reflect higher transcoder vertical limits

2019-07-12 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 04:15:41PM -0700, Manasi Navare wrote: > On Thu, Jul 11, 2019 at 01:38:41PM +0300, Ville Syrjälä wrote: > > On Wed, Jul 10, 2019 at 02:39:50PM -0700, Manasi Navare wrote: > > > On ICL+, the vertical limits for the transcoders are increased to 8192 so > > > bump up > > > lim

Re: [Intel-gfx] [PATCH] drm/vgem: Reclassify buffer creation debug message

2019-07-12 Thread Daniel Vetter
On Fri, Jul 12, 2019 at 2:01 PM Chris Wilson wrote: > > A buffer is created in response to the user ioctl, it should therefore > be a plain DRM_DEBUG() message to reflect it being a user invoked > response and not a driver construct. > > This is just to make the commonplace drm.debug=[26e] quieter

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

2019-07-12 Thread Ser, Simon
So, to test these last two patches we'd need specific hardware right? Because VKMS doesn't support cloning yet (does it?). What kind of hardware supports cloned writeback outputs? I have a Raspberry Pi which supports writeback via VC4, but I don't think it has writeback cloning. I'm also not willi

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Add modular FIA

2019-07-12 Thread Ville Syrjälä
On Thu, Jul 11, 2019 at 04:49:07PM -0700, Lucas De Marchi wrote: > On Thu, Jul 11, 2019 at 04:15:42PM -0700, Summers, Stuart wrote: > >On Thu, 2019-07-11 at 13:58 -0700, Lucas De Marchi wrote: > >> From: Anusha Srivatsa > >> > >> Some platforms may have Modular FIA. If Modular FIA is used in the >

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gtt: Recursive cleanup for gen8

2019-07-12 Thread Abdiel Janulgue
On 12/07/2019 14.27, Chris Wilson wrote: > With an explicit level, we can refactor the separate cleanup functions > as a simple recursive function. We take the opportunity to pass down the > size of each level so that we can deal with the different sizes of > top-level and avoid over allocating f

[Intel-gfx] [PATCH i-g-t v2] i915/gem_ctx_engine: Drip feed requests into 'independent'

2019-07-12 Thread Chris Wilson
The intent of the test is to exercise that each channel in the engine[] is an independent context/ring/timeline. It setups 64 channels pointing to rcs0 and then submits one request to each in turn waiting on a timeline that will force them to run out of submission order. They can only run in fence

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename functions to match their entry points (rev3)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Rename functions to match their entry points (rev3) URL : https://patchwork.freedesktop.org/series/63541/ State : success == Summary == CI Bug Log - changes from CI_DRM_6472 -> Patchwork_13643 Summary

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename functions to match their entry points (rev3)

2019-07-12 Thread Chris Wilson
Quoting Patchwork (2019-07-12 14:14:34) > == Series Details == > > Series: drm/i915: Rename functions to match their entry points (rev3) > URL : https://patchwork.freedesktop.org/series/63541/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6472 -> Patchwork_13643 > ==

[Intel-gfx] [PATCH] drm/i915/display: Drop kerneldoc for 'intel_atomic_commit'

2019-07-12 Thread Chris Wilson
intel_atomic_commit() is not for use internally, but only as an entry point from the core drm atomic helper (drm_atomic_commit). Squelches the warning for: drivers/gpu/drm/i915/display/intel_display.c:14148: warning: Function parameter or member '_state' not described in 'intel_atomic_commit' dri

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Vulkan performance query support (rev9)

2019-07-12 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev9) URL : https://patchwork.freedesktop.org/series/60916/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6458_full -> Patchwork_13621_full Summary --

  1   2   >