Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Christian König
Am 25.06.19 um 18:05 schrieb Daniel Vetter: On Tue, Jun 25, 2019 at 02:46:49PM +0200, Christian König wrote: On the exporter side we add optional explicit pinning callbacks. If those callbacks are implemented the framework no longer caches sg tables and the map/unmap callbacks are always called

Re: [Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 4:00 AM Rodrigo Siqueira wrote: > > On 06/19, Daniel Vetter wrote: > > On Wed, Jun 19, 2019 at 09:48:56AM +0200, Daniel Vetter wrote: > > > On Tue, Jun 18, 2019 at 11:07:50PM -0300, Rodrigo Siqueira wrote: > > > > For historical reason, the function drm_wait_vblank_ioctl al

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 09:49:03AM +0200, Christian König wrote: > Am 25.06.19 um 18:05 schrieb Daniel Vetter: > > On Tue, Jun 25, 2019 at 02:46:49PM +0200, Christian König wrote: > > > On the exporter side we add optional explicit pinning callbacks. If those > > > callbacks are implemented the fra

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62756/ State : warning == Summary == $ dim checkpatch origin/drm-tip 679239f7e788 drm/i915/selftests: Serialise nop reset with retirem

[Intel-gfx] [PULL] topic/remove-fbcon-notifiers for v5.3, fixes

2019-06-26 Thread Maarten Lankhorst
Hi all, This is the followup pull request for the remove-fbcon-notifiers topic branch. No major changes, just a few compile fixes. This will be pulled into drm-misc-next, but it might be useful for the fbdev and backlight trees too. Cheers, Maarten topic/remove-fbcon-notifiers-2019-06-26: - Ex

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fail harder if GPU reset fails outright

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fail harder if GPU reset fails outright URL : https://patchwork.freedesktop.org/series/62740/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13428_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915: Fail harder if GPU reset fails outright

2019-06-26 Thread Chris Wilson
Quoting Chris Wilson (2019-06-26 00:08:15) > If we request a reset and the GPU fails to respond, abandon all hope. If > the request is still stuck when we attempt to do another, fail early and > avoid requesting multiple possibly conflicting domains be reset > simultaneously. > > We should never s

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Koenig, Christian
Am 26.06.19 um 10:17 schrieb Daniel Vetter: > On Wed, Jun 26, 2019 at 09:49:03AM +0200, Christian König wrote: >> Am 25.06.19 um 18:05 schrieb Daniel Vetter: >>> On Tue, Jun 25, 2019 at 02:46:49PM +0200, Christian König wrote: On the exporter side we add optional explicit pinning callbacks. If

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Always call kref_init for the timeline

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always call kref_init for the timeline URL : https://patchwork.freedesktop.org/series/62741/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13429_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62756/ State : success == Summary == CI Bug Log - changes from CI_DRM_6354 -> Patchwork_13434

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gt: Drop stale commentary for timeline density

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Drop stale commentary for timeline density URL : https://patchwork.freedesktop.org/series/62742/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13430_full ===

[Intel-gfx] [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Chris Wilson
We gracefully handle the caller specifying a zero range, so don't force them to special case that condition if it naturally falls out of their setup. What we don't check is if the end < start, so keep that as an assert for an illegal call. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Dani

[Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Vandita Kulkarni
Add scaling and panel orientation properties for icl mipi dsi. v2: Add platform specific function (Ville) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 30 ++ drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++-- 2 files changed, 32 insertions(

Re: [Intel-gfx] [RFC 1/4] drm/i915: split out uncore_mmio_debug

2019-06-26 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-24 21:31:49) > @@ -605,18 +614,20 @@ void intel_uncore_forcewake_get(struct intel_uncore > *uncore, > void intel_uncore_forcewake_user_get(struct intel_uncore *uncore) > { > spin_lock_irq(&uncore->lock); > + spin_lock(&uncore->debug->lock); >

Re: [Intel-gfx] [PULL] topic/remove-fbcon-notifiers for v5.3, fixes

2019-06-26 Thread Bartlomiej Zolnierkiewicz
Hi, On 6/26/19 10:48 AM, Maarten Lankhorst wrote: > Hi all, > > This is the followup pull request for the remove-fbcon-notifiers topic branch. > No major changes, just a few compile fixes. > > This will be pulled into drm-misc-next, but it might be useful for the fbdev > and backlight trees to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/connector: Allow max possible encoders to attach to a connector

2019-06-26 Thread Patchwork
== Series Details == Series: drm/connector: Allow max possible encoders to attach to a connector URL : https://patchwork.freedesktop.org/series/62743/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13431_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Patchwork
== Series Details == Series: drm: Allow range of 0 for drm_mm_insert_node_in_range() URL : https://patchwork.freedesktop.org/series/62768/ State : success == Summary == CI Bug Log - changes from CI_DRM_6356 -> Patchwork_13435 Summary --

Re: [Intel-gfx] [PULL] topic/remove-fbcon-notifiers for v5.3, fixes

2019-06-26 Thread Maarten Lankhorst
Op 26-06-2019 om 12:03 schreef Bartlomiej Zolnierkiewicz: > Hi, > > On 6/26/19 10:48 AM, Maarten Lankhorst wrote: >> Hi all, >> >> This is the followup pull request for the remove-fbcon-notifiers topic >> branch. >> No major changes, just a few compile fixes. >> >> This will be pulled into drm-mis

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_engine: Drip feed requests into 'independent'

2019-06-26 Thread Chris Wilson
The intent of the test is to exercise that each channel in the engine[] is an independent context/ring/timeline. It setups 64 channels pointing to rcs0 and then submits one request to each in turn waiting on a timeline that will force them to run out of submission order. They can only run in fence

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:28 AM Koenig, Christian wrote: > > Am 26.06.19 um 10:17 schrieb Daniel Vetter: > > On Wed, Jun 26, 2019 at 09:49:03AM +0200, Christian König wrote: > >> Am 25.06.19 um 18:05 schrieb Daniel Vetter: > >>> On Tue, Jun 25, 2019 at 02:46:49PM +0200, Christian König wrote: > >

[Intel-gfx] ✓ Fi.CI.IGT: success for EHL port programming (rev3)

2019-06-26 Thread Patchwork
== Series Details == Series: EHL port programming (rev3) URL : https://patchwork.freedesktop.org/series/62492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13432_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Add icl mipi dsi properties URL : https://patchwork.freedesktop.org/series/62770/ State : warning == Summary == $ dim checkpatch origin/drm-tip c3eee71d5187 drm/i915: Add icl mipi dsi properties -:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match op

Re: [Intel-gfx] [PATCH v2 12/23] drm/i915: Sanitize the TypeC connect/detect sequences

2019-06-26 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 09:30:43PM +0300, Imre Deak wrote: > On Tue, Jun 25, 2019 at 04:42:01PM +0300, Ville Syrjälä wrote: > > On Thu, Jun 20, 2019 at 05:05:49PM +0300, Imre Deak wrote: > > > Make the order during detection more consistent: first reset the TypeC > > > port mode if needed (adding n

Re: [Intel-gfx] [PATCH v2 21/23] drm/i915: Add state verification for the TypeC port mode

2019-06-26 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 10:23:51PM +0300, Imre Deak wrote: > On Tue, Jun 25, 2019 at 05:12:52PM +0300, Ville Syrjälä wrote: > > On Thu, Jun 20, 2019 at 05:05:58PM +0300, Imre Deak wrote: > > > Add state verification for the TypeC port mode wrt. the port's AUX power > > > well enabling/disabling. Al

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Christian König
[SNIP] I'm confused here: Atm ->moving isn't in resv_obj, there's only one exclusive fence. And yes you need to set that every time you do a move (because a move needs to be pretty exclusive access). But I'm not seeing a separate not_quite_exclusive fence slot for moves. Yeah, but shouldn't tha

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915/icl: Add new supported CD clocks

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [v3,1/3] drm/i915/icl: Add new supported CD clocks URL : https://patchwork.freedesktop.org/series/62748/ State : success == Summary == CI Bug Log - changes from CI_DRM_6351_full -> Patchwork_13433_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Add icl mipi dsi properties URL : https://patchwork.freedesktop.org/series/62770/ State : success == Summary == CI Bug Log - changes from CI_DRM_6357 -> Patchwork_13436 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v12

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 1:53 PM Christian König wrote: > > [SNIP] > > I'm confused here: Atm ->moving isn't in resv_obj, there's only one > >>> exclusive fence. And yes you need to set that every time you do a move > >>> (because a move needs to be pretty exclusive access). But I'm not seeing

[Intel-gfx] [PATCH 4/6] drm/amdgpu: use allowed_domains for exported DMA-bufs

2019-06-26 Thread Christian König
Avoid that we ping/pong the buffers when we stop to pin DMA-buf exports by using the allowed domains for exported buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[Intel-gfx] [PATCH 3/6] drm/ttm: use the parent resv for ghost objects v2

2019-06-26 Thread Christian König
This way we can even pipeline imported BO evictions. v2: Limit this to only cases when the parent object uses a separate reservation object as well. This fixes another OOM problem. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 20 +++- 1 file changed

[Intel-gfx] [PATCH 5/6] drm/amdgpu: add independent DMA-buf export v6

2019-06-26 Thread Christian König
The caching of SGT's is actually quite harmful and should probably removed altogether when all drivers are audited. Start by providing a separate DMA-buf export implementation in amdgpu. This is also a prerequisite of unpinned DMA-buf handling. v2: fix unintended recursion, remove debugging lefto

[Intel-gfx] [PATCH 6/6] drm/amdgpu: add independent DMA-buf import v7

2019-06-26 Thread Christian König
Instead of relying on the DRM functions just implement our own import functions. This prepares support for taking care of unpinned DMA-buf. v2: enable for all exporters, not just amdgpu, fix invalidation handling, lock reservation object while setting callback v3: change to new dma_buf attach

[Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-06-26 Thread Christian König
On the exporter side we add optional explicit pinning callbacks. If those callbacks are implemented the framework no longer caches sg tables and the map/unmap callbacks are always called with the lock of the reservation object held. On the importer side we add an optional invalidate callback. This

[Intel-gfx] [PATCH 2/6] drm/ttm: remove the backing store if no placement is given

2019-06-26 Thread Christian König
Pipeline removal of the BOs backing store when no placement is given during validation. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c7de667d482a

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v13

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 02:23:05PM +0200, Christian König wrote: > On the exporter side we add optional explicit pinning callbacks. If those > callbacks are implemented the framework no longer caches sg tables and the > map/unmap callbacks are always called with the lock of the reservation object >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] dma-buf: add dynamic DMA-buf handling v12 (rev2)

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v12 (rev2) URL : https://patchwork.freedesktop.org/series/62703/ State : failure == Summary == Applying: dma-buf: add dynamic DMA-buf handling v12 error: patch failed: include/drm/ttm/ttm_bo_api.h:21

[Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Michal Wajdeczko
OA files look to be auto-generated so we can keep them all in dedicated subdirectory. Signed-off-by: Michal Wajdeczko Cc: Lionel Landwerlin Cc: Chris Wilson Cc: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 36 ++- drivers/gpu/drm/i915/i915_perf.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13 URL : https://patchwork.freedesktop.org/series/62777/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6d09a7de3969 dma-buf: add dynamic DMA-buf handling v13 -:11: WARNING:COMMIT_LOG_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13 URL : https://patchwork.freedesktop.org/series/62777/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: dma-buf: add dynamic DMA-buf handling v13 Okay! Comm

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Michal Wajdeczko wrote: > OA files look to be auto-generated so we can keep them all in > dedicated subdirectory. > > Signed-off-by: Michal Wajdeczko > Cc: Lionel Landwerlin > Cc: Chris Wilson > Cc: Jani Nikula I'll let others judge whether "oa" as the subdir name is the

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Lionel Landwerlin
Sure, Acked-by: Lionel Landwerlin -Lionel On 26/06/2019 15:38, Michal Wajdeczko wrote: OA files look to be auto-generated so we can keep them all in dedicated subdirectory. Signed-off-by: Michal Wajdeczko Cc: Lionel Landwerlin Cc: Chris Wilson Cc: Jani Nikula --- drivers/gpu/drm/i915/M

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-06-26 13:38:26) > OA files look to be auto-generated so we can keep them all in > dedicated subdirectory. The question I couldn't answer was how coupled into the GEM api is the i915_perf ioctl. Is the GEM context filtering an adjunct or core? The move makes sense, bu

Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Vandita Kulkarni wrote: > Add scaling and panel orientation properties for > icl mipi dsi. > > v2: Add platform specific function (Ville) > > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 30 ++ > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Chris Wilson wrote: > Quoting Michal Wajdeczko (2019-06-26 13:38:26) >> OA files look to be auto-generated so we can keep them all in >> dedicated subdirectory. > > The question I couldn't answer was how coupled into the GEM api is the > i915_perf ioctl. Is the GEM context fil

Re: [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > In order for the reset count to be accurate across our selftest, we need > to prevent the background retire worker from modifying our expected > state. > Ok, to summarize the irc discussion we had: The above holds true for igt_reset_engine_nop only. As there is no race in

Re: [Intel-gfx] [PATCH 2/6] drm/i915/selftests: Drop manual request wakerefs around hangcheck

2019-06-26 Thread Chris Wilson
Quoting Chris Wilson (2019-06-26 07:52:59) > We no longer need to manually acquire a wakeref for request emission, so > drop the redundant wakerefs, letting us test our wakeref handling more > precisely. References: 79ffac8599c4 ("drm/i915: Invert the GEM wakeref hierarchy") > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-26 14:11:49) > Chris Wilson writes: > > > In order for the reset count to be accurate across our selftest, we need > > to prevent the background retire worker from modifying our expected > > state. > > > > Ok, to summarize the irc discussion we had: The above holds

Re: [Intel-gfx] [PATCH 2/6] drm/i915/selftests: Drop manual request wakerefs around hangcheck

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > We no longer need to manually acquire a wakeref for request emission, so > drop the redundant wakerefs, letting us test our wakeref handling more > precisely. > > Signed-off-by: Chris Wilson Riding on the request's ref and getting more fine grained sounds good. Reviewed-

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] dma-buf: add dynamic DMA-buf handling v13 URL : https://patchwork.freedesktop.org/series/62777/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6358 -> Patchwork_13438 S

Re: [Intel-gfx] [PATCH 3/6] drm/i915/selftests: Fixup atomic reset checking

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > We require that the intel_gpu_reset() was atomic, not the whole of > i915_reset() which is guarded by a mutex. However, we do require that > i915_reset_engine() is atomic for use from within the submission tasklet. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-26 Thread Rodrigo Siqueira
On Wed, Jun 26, 2019 at 4:53 AM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 4:00 AM Rodrigo Siqueira > wrote: > > > > On 06/19, Daniel Vetter wrote: > > > On Wed, Jun 19, 2019 at 09:48:56AM +0200, Daniel Vetter wrote: > > > > On Tue, Jun 18, 2019 at 11:07:50PM -0300, Rodrigo Siqueira wrote:

Re: [Intel-gfx] [PATCH 3/6] drm/i915/selftests: Fixup atomic reset checking

2019-06-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-26 14:35:01) > Chris Wilson writes: > > > We require that the intel_gpu_reset() was atomic, not the whole of > > i915_reset() which is guarded by a mutex. However, we do require that > > i915_reset_engine() is atomic for use from within the submission tasklet. > > >

Re: [Intel-gfx] [PATCH 3/6] drm/i915/selftests: Fixup atomic reset checking

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-06-26 14:35:01) >> Chris Wilson writes: >> >> > We require that the intel_gpu_reset() was atomic, not the whole of >> > i915_reset() which is guarded by a mutex. However, we do require that >> > i915_reset_engine() is atomic for use from within

Re: [Intel-gfx] [PATCH] drm/connector: Allow max possible encoders to attach to a connector

2019-06-26 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote: > Currently we restrict the number of encoders that can be linked to > a connector to 3, increase it to match the maximum number of encoders > that can be initialized - 32. The current limitation looks artificial. > Increasing the

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > For use in the next patch, we want to acquire a wakeref without having > to wake the device up -- i.e. only acquire the engine wakeref if the > engine is already active. > s/iff/if on the subject. Reviewed-by: Mika Kuoppala > Signed-off-by: Chris Wilson > --- > driver

[Intel-gfx] [CI 1/3] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Chris Wilson
In order for the reset count to be accurate across our selftest, we need to prevent the background retire worker from modifying our expected state. To preserve the intent of symmetry, we apply this to both i915_reset and i915_reset_engine, even though it strictly only affects i915_reset_engine curr

[Intel-gfx] [CI 3/3] drm/i915/selftests: Fixup atomic reset checking

2019-06-26 Thread Chris Wilson
We require that the intel_gpu_reset() was atomic, not the whole of i915_reset() which is guarded by a mutex. However, we do require that i915_reset_engine() is atomic for use from within the submission tasklet. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/s

[Intel-gfx] [CI 2/3] drm/i915/selftests: Drop manual request wakerefs around hangcheck

2019-06-26 Thread Chris Wilson
We no longer need to manually acquire a wakeref for request emission, so drop the redundant wakerefs, letting us test our wakeref handling more precisely. References: 79ffac8599c4 ("drm/i915: Invert the GEM wakeref hierarchy") Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/g

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Move OA files to separate folder

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Move OA files to separate folder URL : https://patchwork.freedesktop.org/series/62779/ State : warning == Summary == $ dim checkpatch origin/drm-tip 61d6088532ee drm/i915: Move OA files to separate folder -:111: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move OA files to separate folder

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Move OA files to separate folder URL : https://patchwork.freedesktop.org/series/62779/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Move OA files to separate folder +./include/uapi/linux/perf_event.h:1

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-26 14:43:54) > Chris Wilson writes: > > > For use in the next patch, we want to acquire a wakeref without having > > to wake the device up -- i.e. only acquire the engine wakeref if the > > engine is already active. > > > > s/iff/if on the subject. iff === if, and

Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Ville Syrjälä
On Wed, Jun 26, 2019 at 03:53:19PM +0300, Jani Nikula wrote: > On Wed, 26 Jun 2019, Vandita Kulkarni wrote: > > Add scaling and panel orientation properties for > > icl mipi dsi. > > > > v2: Add platform specific function (Ville) > > > > Signed-off-by: Vandita Kulkarni > > --- > > drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62784/ State : warning == Summary == $ dim checkpatch origin/drm-tip a38bf677c3fc drm/i915/selftests: Serialise nop reset with reti

Re: [Intel-gfx] [PATCH V4] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 10:37:11AM -0300, Rodrigo Siqueira wrote: > On Wed, Jun 26, 2019 at 4:53 AM Daniel Vetter wrote: > > > > On Wed, Jun 26, 2019 at 4:00 AM Rodrigo Siqueira > > wrote: > > > > > > On 06/19, Daniel Vetter wrote: > > > > On Wed, Jun 19, 2019 at 09:48:56AM +0200, Daniel Vetter w

Re: [Intel-gfx] [PATCH] drm/connector: Allow max possible encoders to attach to a connector

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 04:43:28PM +0300, Ville Syrjälä wrote: > On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote: > > Currently we restrict the number of encoders that can be linked to > > a connector to 3, increase it to match the maximum number of encoders > > that can be init

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move OA files to separate folder

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Move OA files to separate folder URL : https://patchwork.freedesktop.org/series/62779/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13439 Summary --- **SUCCES

[Intel-gfx] [PATCH 2/2] drm/i915: add header search path to subdir Makefiles

2019-06-26 Thread Jani Nikula
With the subdirectories we lost the ability to build individual files on the command line, for example: $ make drivers/gpu/drm/i915/display/intel_display.o This was due to the top level directory missing from header search path. Add the header search paths to subdir Makefiles. Note that none of

[Intel-gfx] [PATCH 1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Jani Nikula
Per commit 43068cb7ba1f ("drm: prefix header search paths with $(srctree)/") this is what we should be doing. Follow suit. Cc: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Makef

[Intel-gfx] drm/i915: last bits to make headers self-contained

2019-06-26 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/62192/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 05/13] drm/i915: make i915_globals.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_globals.h | 2 ++ 2 files changed, 3 insertions(+) di

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-06-26 14:43:54) >> Chris Wilson writes: >> >> > For use in the next patch, we want to acquire a wakeref without having >> > to wake the device up -- i.e. only acquire the engine wakeref if the >> > engine is already active. >> > >> >> s/iff/if

[Intel-gfx] [PATCH v2 02/13] drm/i915: add include path to subdir Makefiles

2019-06-26 Thread Jani Nikula
With the subdirectories we lost the ability to build individual files on the command line, for example: $ make drivers/gpu/drm/i915/display/intel_display.o This was due to missing include paths. Add the include paths to subdir Makefiles. Note that none of the other options in the top level i915

[Intel-gfx] [PATCH v2 11/13] drm/i915: make intel_gvt.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_gvt.h | 2 +- 2 files changed, 2 insertions(+), 1

[Intel-gfx] [PATCH v2 12/13] drm/i915: make intel_uc_fw.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_uc_fw.h| 2 ++ 2 files changed, 3 insertions(+) di

[Intel-gfx] [PATCH v2 13/13] drm/i915: use wildcard to ensure all headers stay self-contained

2019-06-26 Thread Jani Nikula
Skip the generated i915_oa_*.h files. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 28 +-- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v2 09/13] drm/i915: make intel_guc_fwif.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_fwif.h | 4 2 files changed, 5 insertions(+)

[Intel-gfx] [PATCH v2 03/13] drm/i915: make i915_fixed.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_fixed.h | 5 + 2 files changed, 6 insertions(+)

[Intel-gfx] [PATCH v2 08/13] drm/i915: make intel_guc_ct.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_ct.h | 7 +-- 2 files changed, 6 insertions(+

[Intel-gfx] [PATCH v2 07/13] drm/i915: make i915_vgpu.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_vgpu.h | 1 + 2 files changed, 2 insertions(+) dif

[Intel-gfx] [PATCH v2 01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Jani Nikula
Per commit 43068cb7ba1f ("drm: prefix header search paths with $(srctree)/") this is what we should be doing. Follow suit. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/

[Intel-gfx] [PATCH v2 10/13] drm/i915: make intel_guc_reg.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. v2: also include i915_reg.h (Michal) Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_reg.h | 5 ++

[Intel-gfx] [PATCH v2 06/13] drm/i915: make i915_pvinfo.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_pvinfo.h| 2 ++ 2 files changed, 3 insertions(+) di

Re: [Intel-gfx] [PATCH v4 0/7] Hexdump Enhancements

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Apologies for the large CC list, it's a heads up for those > > responsible > > for subsystems where a prototype change in generic code causes a > >

Re: [Intel-gfx] [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > In order to support additional features, rename hex_dump_to_buffer > > to > > hex_dump_to_buffer_ext, and replace the ascii bool parameter with > >

Re: [Intel-gfx] [PATCH v4 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:37 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > With the wider display format, it can become hard to identify how > > many > > bytes into the line you are looking at. > > > > The patch adds new

Re: [Intel-gfx] [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:19 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > > The change actions Jani's suggestion: > > https://lkml.org/lkml/2019/6/20/343 > > I suggest not changing any of the existing uses of > hex_dump_to_buffer and only use hex_dump_to_

Re: [Intel-gfx] [PATCH 1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Chris Wilson
Quoting Jani Nikula (2019-06-26 15:36:17) > Per commit 43068cb7ba1f ("drm: prefix header search paths with > $(srctree)/") this is what we should be doing. Follow suit. Bleugh, it's not mentioned in Documention/kbuild but it is used in one of their examples. > Cc: Chris Wilson > Signed-off-by:

[Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/driver

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add header search path to subdir Makefiles

2019-06-26 Thread Chris Wilson
Quoting Jani Nikula (2019-06-26 15:36:18) > With the subdirectories we lost the ability to build individual files on > the command line, for example: > > $ make drivers/gpu/drm/i915/display/intel_display.o > > This was due to the top level directory missing from header search > path. Add the head

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Only recover active engines

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > If we issue a reset to a currently idle engine, leave it idle > afterwards. This is useful to excise a linkage between reset and the > shrinker. When waking the engine, we need to pin the default context default context, kernel context, golden context... if we ever revisit

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Only recover active engines

2019-06-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-26 15:44:56) > Chris Wilson writes: > > > If we issue a reset to a currently idle engine, leave it idle > > afterwards. This is useful to excise a linkage between reset and the > > shrinker. When waking the engine, we need to pin the default context > > default con

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62790/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: prefix header search path with

Re: [Intel-gfx] [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton

2019-06-26 Thread Jani Nikula
On Tue, 25 Jun 2019, "Lee, Shawn C" wrote: > On Tue, 25 Jun 2019, Jani Nikula wrote: >>On Thu, 20 Jun 2019, Lee Shawn C wrote: >>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface". >>> Driver should check panel capability and try to initialize aux backlight. >>> No matter i915

Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Kulkarni, Vandita
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, June 26, 2019 7:29 PM > To: Nikula, Jani > Cc: Kulkarni, Vandita ; intel- > g...@lists.freedesktop.org; Syrjala, Ville > Subject: Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties > > On Wed, Jun 26, 2019 at 03:53:19

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62784/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13440 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62791/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: prefix header search path

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62756/ State : success == Summary == CI Bug Log - changes from CI_DRM_6354_full -> Patchwork_13434_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62790/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13441 ===

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Michal Wajdeczko
On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula wrote: Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 1 file changed, 2 insertions(+

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Michal Wajdeczko wrote: > On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula > wrote: > >> Add the minimal includes/declarations to make the header self-contained, >> and ensure it stays that way. >> >> Reviewed-by: Chris Wilson >> Signed-off-by: Jani Nikula >> --- >> drive

  1   2   >