[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 vgpu PV to improve vgpu performance

2019-06-03 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/61493/ State : warning == Summary == $ dim checkpatch origin/drm-tip b84d8b472a53 drm/i915: introduced vgpu pv capability -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should mat

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915 vgpu PV to improve vgpu performance

2019-06-03 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/61493/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: introduced vgpu pv capability Okay! Commit: drm/i915: vgpu shared memo

Re: [Intel-gfx] [RFC PATCH 1/1] drm/i915: Split off pci_driver.remove() tail to drm_driver.release()

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 10:40:09AM +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-05-30 10:24:26) > > In order to support driver hot unbind, some cleanup operations, now > > performed on PCI driver remove, must be called later, after all device > > file descriptors are closed. > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Split off pci_driver.remove() tail to drm_driver.release()

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 03:31:05PM +0200, Janusz Krzysztofik wrote: > In order to support driver hot unbind, some cleanup operations, now > performed on PCI driver remove, must be called later, after all device > file descriptors are closed. > > Split out those operations from the tail of pci_driv

Re: [Intel-gfx] linux-next: unable to fetch the drm-intel-fixes tree

2019-06-03 Thread Daniel Vetter
On Mon, Jun 03, 2019 at 11:04:03AM +1000, Stephen Rothwell wrote: > Hi Stephen, > > On Mon, 3 Jun 2019 08:20:51 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > Trying to fetch the drm-intel-fixes tree today gives me this error: > > > > --

5.2: display corruption on X60, X220

2019-06-03 Thread Pavel Machek
Hi! In recent kernels (5.2.0-rc1-next-20190522, 5.2-rc2) I'm getting display corruption in X. Usually in terminals, but also in title bars etc. Black areas with white lines in them, usually... Same configuration worked properly in ... probably 4.19? Then I got some graphics-crashes on X220 that p

Re: [Intel-gfx] [PATCH 1/4] drm: Drop a redundant unused variable

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 01:29:01AM +0530, Uma Shankar wrote: > Drop a redundant and unused variable "hdr_output_metadata" from > drm_connector. > > Suggested-by: Daniel Vetter > Signed-off-by: Uma Shankar For next time around: Please add Fixes: lines to indicate which already merged commit you'

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 vgpu PV to improve vgpu performance

2019-06-03 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/61493/ State : success == Summary == CI Bug Log - changes from CI_DRM_6179 -> Patchwork_13156 Summary --- **SUCCESS*

Re: [Intel-gfx] [PATCH 2/4] drm: Fix docbook warnings in hdr metadata helper structures

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 01:29:02AM +0530, Uma Shankar wrote: > Fixes the following warnings: > ./include/drm/drm_mode_config.h:841: warning: Incorrect use of > kernel-doc format: * hdr_output_metadata_property: Connector > property containing hdr > ./include/drm/drm_mode_config.h:918: warn

Re: [Intel-gfx] [PATCH 4/4] video/hdmi: Dropped static functions from kernel doc

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 01:29:04AM +0530, Uma Shankar wrote: > Dropped static functions from kernel documentation. > > Suggested-by: Daniel Vetter > Signed-off-by: Uma Shankar > --- > drivers/video/hdmi.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-)

Re: [Intel-gfx] [PATCH 3/4] drm: Fixed doc warnings in drm uapi header

2019-06-03 Thread Daniel Vetter
On Thu, May 30, 2019 at 01:29:03AM +0530, Uma Shankar wrote: > Fixed doc warnings in drm uapi header. All the UAPI > structures are now documented in kernel doc. > > Signed-off-by: Uma Shankar Applied, thanks for the patch. Long-term there's obviously a lot more to do here, but this at least ge

Re: [Intel-gfx] linux-next: unable to fetch the drm-intel-fixes tree

2019-06-03 Thread Stephen Rothwell
Hi Daniel, On Mon, 3 Jun 2019 09:31:03 +0200 Daniel Vetter wrote: > > drm.git too I guess? No, I fetch that from git://git.freedesktop.org/ which seems to answer. > But yeah fd.o anongit keeled over over the w/e :-( Admins not yet awake, > so can't tell you what's up. No worries, I will just k

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-06-03 Thread Michel Dänzer
On 2019-05-21 9:52 a.m., Daniel Vetter wrote: > On Tue, May 21, 2019 at 8:55 AM Pekka Paalanen wrote: >> On Mon, 20 May 2019 18:11:07 +0200 >> Daniel Vetter wrote: >> >>> There's also a fairly easy fix for that -modesetting issue: We don't >>> expose atomic if the compositor has a process name of

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 vgpu PV to improve vgpu performance

2019-06-03 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/61493/ State : success == Summary == CI Bug Log - changes from CI_DRM_6179_full -> Patchwork_13156_full Summary ---

Re: [Intel-gfx] [RFC PATCH 1/1] drm/i915: Split off pci_driver.remove() tail to drm_driver.release()

2019-06-03 Thread Janusz Krzysztofik
On Monday, June 3, 2019 9:28:18 AM CEST Daniel Vetter wrote: > On Thu, May 30, 2019 at 10:40:09AM +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-05-30 10:24:26) > > > In order to support driver hot unbind, some cleanup operations, now > > > performed on PCI driver remove, must be c

Re: [Intel-gfx] [PATCH v3] drm/i915: add i2c symlink under hdmi connector

2019-06-03 Thread Vasilev, Oleg
Hi, Can this be reviewed, please? On Mon, 2019-05-20 at 18:06 +0300, Oleg Vasilev wrote: > Currently, the i2c adapter is available only under DP connectors. > > Add i2c symlink under hdmi connector pointing to i2c adapter in order > to > make this behaviour consistent. > > The initial motivatio

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-06-03 Thread Tvrtko Ursulin
On 29/05/2019 14:24, Chris Wilson wrote: If we run out of engines, intel_get_current_physical_engine() degrades into an infinite loop as although it advanced the iterator, it did not update its local engine pointer. We had one infinite loop in there already.. AFAIR it was on one engine platfo

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-06-03 Thread Tvrtko Ursulin
On 03/06/2019 11:32, Petri Latvala wrote: On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote: On 29/05/2019 14:24, Chris Wilson wrote: If we run out of engines, intel_get_current_physical_engine() degrades into an infinite loop as although it advanced the iterator, it did not upda

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-06-03 Thread Petri Latvala
On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote: > > On 29/05/2019 14:24, Chris Wilson wrote: > > If we run out of engines, intel_get_current_physical_engine() degrades > > into an infinite loop as although it advanced the iterator, it did not > > update its local engine pointer. >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-06-03 Thread Petri Latvala
On Mon, Jun 03, 2019 at 11:39:25AM +0100, Tvrtko Ursulin wrote: > > On 03/06/2019 11:32, Petri Latvala wrote: > > On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote: > > > > > > On 29/05/2019 14:24, Chris Wilson wrote: > > > > If we run out of engines, intel_get_current_physical_engin

Re: [Intel-gfx] [PATCH 1/4] drm: Drop a redundant unused variable

2019-06-03 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Monday, June 3, 2019 1:42 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; ville.syrj...@linux.intel.c

Re: [Intel-gfx] [PATCH 3/4] drm: Fixed doc warnings in drm uapi header

2019-06-03 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Monday, June 3, 2019 1:56 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; ville.syrj...@linux.intel.c

Re: [Intel-gfx] [PATCH 4/4] video/hdmi: Dropped static functions from kernel doc

2019-06-03 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Monday, June 3, 2019 1:55 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; ville.syrj...@linux.intel.c

[Intel-gfx] [PATCH i-g-t 1/4] tests: add libatomic dependency

2019-06-03 Thread Guillaume Tucker
Add dependency to libatomic in order to be able to use the __atomic_* functions instead of the older __sync_* ones. This is to enable atomic operations on a wider number of architectures including MIPS. Signed-off-by: Guillaume Tucker --- meson.build | 1 + tests/meson.build | 2 +- 2 fil

[Intel-gfx] [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image

2019-06-03 Thread Guillaume Tucker
Add libatomic to the Fedora docker image so it can link binaries that use __atomic_* functions. Signed-off-by: Guillaume Tucker --- Dockerfile.fedora | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile.fedora b/Dockerfile.fedora index 6686e587613d..c84b412b0723 100644

[Intel-gfx] [PATCH i-g-t 3/4] i915/gem_create: use __atomic_* instead of __sync_*

2019-06-03 Thread Guillaume Tucker
Replace calls to the older __sync_* functions with the new __atomic_* standard ones. This fixes builds on some architectures, in particular MIPS which doesn't have __sync_add_and_fetch_8 and __sync_val_compare_and_swap_8 for 64-bit variable handling. Signed-off-by: Guillaume Tucker --- tests/Ma

[Intel-gfx] [PATCH i-g-t 4/4] tests/sw_sync: use __atomic_* instead of __sync_*

2019-06-03 Thread Guillaume Tucker
Replace calls to the older __sync_* functions with the new __atomic_* standard ones to be consistent with other tests and improve portability across CPU architectures. Signed-off-by: Guillaume Tucker --- tests/Makefile.am | 1 + tests/sw_sync.c | 6 +++--- 2 files changed, 4 insertions(+), 3 d

Re: [Intel-gfx] [PATCH 2/4] drm: Fix docbook warnings in hdr metadata helper structures

2019-06-03 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Daniel >Vetter >Sent: Monday, June 3, 2019 1:53 PM >To: Shankar, Uma >Cc: Sean Paul ; linux-fb...@vger.kernel.org; >dcasta...@chromium.org; jo...@kwiboo.se; Maxime Ripard >; intel-gfx@lis

[Intel-gfx] [v2 1/3] drm: ADD UAPI structure definition section in kernel doc

2019-06-03 Thread Uma Shankar
Add a new section for UAPI structure and helper definitions in kernel docbook. Suggested-by: Daniel Vetter Signed-off-by: Uma Shankar --- Documentation/gpu/drm-uapi.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst i

[Intel-gfx] [v2 0/3] Document fixes for DRM UAPI and HDR

2019-06-03 Thread Uma Shankar
This series adds DRM UAPI header structure documentation to kernel docs. Fixes issues with existing structure documentation in drm uapi header. This also fixes warnings in HDR doc and addresses suggestions from Daniel Vetter. v2: 2 patches from v1 are merged. This series version adds remaining on

[Intel-gfx] [v2 3/3] video/hdmi: Dropped static functions from kernel doc

2019-06-03 Thread Uma Shankar
Dropped static functions from kernel documentation. v2: Dropped the comments altogether for static functions, as the definitions seems self explanatory. Suggested-by: Daniel Vetter Signed-off-by: Uma Shankar --- drivers/video/hdmi.c | 30 -- 1 file changed, 30 delet

[Intel-gfx] [v2 2/3] drm: Fix docbook warnings in hdr metadata helper structures

2019-06-03 Thread Uma Shankar
Fixes the following warnings: ./include/drm/drm_mode_config.h:841: warning: Incorrect use of kernel-doc format: * hdr_output_metadata_property: Connector property containing hdr ./include/drm/drm_mode_config.h:918: warning: Function parameter or member 'hdr_output_metadata_property' not d

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-06-03 Thread Tvrtko Ursulin
On 03/06/2019 12:19, Petri Latvala wrote: On Mon, Jun 03, 2019 at 11:39:25AM +0100, Tvrtko Ursulin wrote: On 03/06/2019 11:32, Petri Latvala wrote: On Mon, Jun 03, 2019 at 11:19:48AM +0100, Tvrtko Ursulin wrote: On 29/05/2019 14:24, Chris Wilson wrote: If we run out of engines, intel_get_c

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_ppgtt: Remove defunct test

2019-06-03 Thread Tvrtko Ursulin
On 02/06/2019 09:53, Chris Wilson wrote: i915_gem_gtt_info has been removed and so flink-and-exit-vma-leak is defunct. Signed-off-by: Chris Wilson Cc: Matt since he would know he reviewed the corresponding i915 patch. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko --- tests/i915/gem_ppg

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations

2019-06-03 Thread Tvrtko Ursulin
On 27/05/2019 10:46, Chris Wilson wrote: We can use offsetof for the same effect, much tidier with no dummy locals. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/benchmarks/gem_ws

[Intel-gfx] [PATCH] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Chris Wilson
The idea behind keeping the saturation mask local to a context backfired spectaculary. The premise with the local mask was that we would be more proactive in attempting to use semaphores everytime after each time th context idled, and that all new contexts would attempt to use semaphores ignoring t

[Intel-gfx] [PATCH] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Chris Wilson
The idea behind keeping the saturation mask local to a context backfired spectacularly. The premise with the local mask was that we would be more proactive in attempting to use semaphores after each time the context idled, and that all new contexts would attempt to use semaphores ignoring the curre

[Intel-gfx] [PULL] drm-intel-fixes

2019-06-03 Thread Joonas Lahtinen
Hi Dave & Daniel, Missed last week's window of opportunity due to trouble getting CI results for Icelake. So this is against -rc2 still to avoid re-doing the GVT pull third time. Just a single Icelake W/A for i915. For GVT a fix for recently seen arbitrary DMA map fault and more enforcement fixes

Re: [Intel-gfx] [PATCH v3] drm/i915: add i2c symlink under hdmi connector

2019-06-03 Thread Ville Syrjälä
On Mon, Jun 03, 2019 at 10:09:30AM +, Vasilev, Oleg wrote: > Hi, > > Can this be reviewed, please? It looks good to me. But the test results are horrible, due to the ext4 fail I think. I've hit retest to get new results. > > On Mon, 2019-05-20 at 18:06 +0300, Oleg Vasilev wrote: > > Current

[Intel-gfx] ✗ Fi.CI.BAT: failure for Document fixes for DRM UAPI and HDR (rev2)

2019-06-03 Thread Patchwork
== Series Details == Series: Document fixes for DRM UAPI and HDR (rev2) URL : https://patchwork.freedesktop.org/series/61349/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6180 -> Patchwork_13157 Summary --- **FAILUR

[Intel-gfx] [PATCH 07/15] drm/i915: Move object close under its own lock

2019-06-03 Thread Chris Wilson
Use i915_gem_object_lock() to guard the LUT and active reference to allow us to break free of struct_mutex for handling GEM_CLOSE. Testcase: igt/gem_close_race Testcase: igt/gem_exec_parallel Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 75 ++-

[Intel-gfx] [PATCH 06/15] drm/i915: Report an earlier wedged event when suspending the engines

2019-06-03 Thread Chris Wilson
On i915_gem_load_power_context() we do care whether or not we succeed in completing the switch back to the kernel context (via idling the engines). Currently, we detect if an error occurs while we wait, but we do not report one if it occurred beforehand (and the status of the switch is undefined).

[Intel-gfx] [PATCH 14/15] drm/i915/execlists: Force preemption

2019-06-03 Thread Chris Wilson
If the preempted context takes too long to relinquish control, e.g. it is stuck inside a shader with arbitration disabled, evict that context with an engine reset. This ensures that preemptions are reasonably responsive, providing a tighter QoS for the more important context at the cost of flagging

[Intel-gfx] [PATCH 11/15] drm/i915: Flush the execution-callbacks on retiring

2019-06-03 Thread Chris Wilson
In the unlikely case the request completes while we regard it as not even executing on the GPU (see the next patch!), we have to flush any pending execution callbacks at retirement and ensure that we do not add any more. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 93 ++

[Intel-gfx] [PATCH 10/15] drm/i915: Replace engine->timeline with a plain list

2019-06-03 Thread Chris Wilson
To continue the onslaught of removing the assumption of a global execution ordering, another casualty is the engine->timeline. Without an actual timeline to track, it is overkill and we can replace it with a much less grand plain list. We still need a list of requests inflight, for the simple purpo

[Intel-gfx] [PATCH 02/15] drm: Flush output polling on shutdown

2019-06-03 Thread Chris Wilson
We need to mark the output polling as disabled to prevent concurrent irqs from queuing new work as shutdown the probe -- causing that work to execute after we have freed the structs: <4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock)) <4> [341.846497] WARNING: CPU: 3 PID: 3300 at kernel/lo

[Intel-gfx] [PATCH 05/15] drm/i915: Use unchecked unccore writes to flush the GTT

2019-06-03 Thread Chris Wilson
As the GTT is outside of the powerwell, we can simplify flushing the GGTT writes by using an unchecked mmio write and post. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 08/15] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-03 Thread Chris Wilson
We need to keep the context image pinned in memory until after the GPU has finished writing into it. Since it continues to write as we signal the final breadcrumb, we need to keep it pinned until the request after it is complete. Currently we know the order in which requests execute on each engine,

[Intel-gfx] [PATCH 03/15] drm/i915/selftests: Flush partial-tiling object once

2019-06-03 Thread Chris Wilson
We only need to flush the object once prior to starting the partial tiling test as inside the test we explicitly maintain coherency. Signed-off-by: Chris Wilson --- .../drm/i915/gem/selftests/i915_gem_mman.c| 21 --- 1 file changed, 9 insertions(+), 12 deletions(-) diff --gi

[Intel-gfx] [PATCH 09/15] drm/i915: Stop retiring along engine

2019-06-03 Thread Chris Wilson
We no longer track the execution order along the engine and so no longer need to enforce ordering of retire along the engine. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 128 +++- 1 file changed, 52 insertions(+), 76 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 04/15] drm/i915: Use unchecked writes for setting up the fences

2019-06-03 Thread Chris Wilson
As the fence registers are not part of the engine powerwells, we do not need to fiddle with forcewake in order to update a fence. Avoid using the heavyweight debug checking normal mmio writes as the checking dominates the selftest runtime and is superfluous! In the process, retire the I915_WRITE()

[Intel-gfx] [PATCH 01/15] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Chris Wilson
The idea behind keeping the saturation mask local to a context backfired spectacularly. The premise with the local mask was that we would be more proactive in attempting to use semaphores after each time the context idled, and that all new contexts would attempt to use semaphores ignoring the curre

[Intel-gfx] [PATCH 15/15] drm/i915: Add a label for config DRM_I915_SPIN_REQUEST

2019-06-03 Thread Chris Wilson
If we don't give it a label, it does not appear as a configuration option. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/Kconfig.profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.profile b/drivers/gpu/drm/i915/Kcon

[Intel-gfx] [PATCH 13/15] drm/i915/execlists: Minimalistic timeslicing

2019-06-03 Thread Chris Wilson
If we have multiple contexts of equal priority pending execution, activate a timer to demote the currently executing context in favour of the next in the queue when that timeslice expires. This enforces fairness between contexts (so long as they allow preemption -- forced preemption, in the future,

[Intel-gfx] [PATCH] drm/i915: Fix per-pixel alpha with CCS

2019-06-03 Thread Ville Syrjala
From: Ville Syrjälä We forgot to set .has_alpha=true for the A+CCS formats when the code started to consult .has_alpha. This manifests as A+CCS being treated as X+CCS which means no per-pixel alpha blending. Fix the format list appropriately. Cc: sta...@vger.kernel.org Cc: Maarten Lankhorst Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make the semaphore saturation mask global (rev2)

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: Make the semaphore saturation mask global (rev2) URL : https://patchwork.freedesktop.org/series/61522/ State : success == Summary == CI Bug Log - changes from CI_DRM_6180 -> Patchwork_13158 Summary ---

Re: [Intel-gfx] linux-next: unable to fetch the drm-intel-fixes tree

2019-06-03 Thread Stephen Rothwell
Hi Daniel, On Mon, 3 Jun 2019 19:50:18 +1000 Stephen Rothwell wrote: > > On Mon, 3 Jun 2019 09:31:03 +0200 Daniel Vetter wrote: > > > > drm.git too I guess? > > No, I fetch that from git://git.freedesktop.org/ which seems to answer. > > > But yeah fd.o anongit keeled over over the w/e :-( A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add i2c symlink under hdmi connector (rev3)

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: add i2c symlink under hdmi connector (rev3) URL : https://patchwork.freedesktop.org/series/60866/ State : success == Summary == CI Bug Log - changes from CI_DRM_6180 -> Patchwork_13159 Summary ---

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-06-03 Thread Daniel Vetter
On Mon, Jun 03, 2019 at 11:50:53AM +0200, Michel Dänzer wrote: > On 2019-05-21 9:52 a.m., Daniel Vetter wrote: > > On Tue, May 21, 2019 at 8:55 AM Pekka Paalanen wrote: > >> On Mon, 20 May 2019 18:11:07 +0200 > >> Daniel Vetter wrote: > >> > >>> There's also a fairly easy fix for that -modesettin

Re: [Intel-gfx] [PATCH] drm/i915: Fix per-pixel alpha with CCS

2019-06-03 Thread Maarten Lankhorst
Op 03-06-2019 om 16:25 schreef Ville Syrjala: > From: Ville Syrjälä > > We forgot to set .has_alpha=true for the A+CCS formats when the code > started to consult .has_alpha. This manifests as A+CCS being treated > as X+CCS which means no per-pixel alpha blending. Fix the format > list appropriatel

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-06-03 Thread Ser, Simon
On Mon, 2019-06-03 at 17:08 +0200, Daniel Vetter wrote: > On Mon, Jun 03, 2019 at 11:50:53AM +0200, Michel Dänzer wrote: > > On 2019-05-21 9:52 a.m., Daniel Vetter wrote: > > > On Tue, May 21, 2019 at 8:55 AM Pekka Paalanen > > > wrote: > > > > On Mon, 20 May 2019 18:11:07 +0200 > > > > Daniel Ve

[Intel-gfx] [PATCH 12/15] drm/i915/execlists: Preempt-to-busy

2019-06-03 Thread Chris Wilson
When using a global seqno, we required a precise stop-the-workd event to handle preemption and unwind the global seqno counter. To accomplish this, we would preempt to a special out-of-band context and wait for the machine to report that it was idle. Given an idle machine, we could very precisely s

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix per-pixel alpha with CCS

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix per-pixel alpha with CCS URL : https://patchwork.freedesktop.org/series/61526/ State : success == Summary == CI Bug Log - changes from CI_DRM_6182 -> Patchwork_13160 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-06-03 Thread Lionel Landwerlin
On 23/05/2019 16:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 14:46:42) On 23/05/2019 12:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 12:46:20) - syncobj = drm_syncobj_find(file, fence.handle); - if (!syncobj) { -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [01/15] drm/i915: Make the semaphore saturation mask global URL : https://patchwork.freedesktop.org/series/61524/ State : warning == Summary == $ dim checkpatch origin/drm-tip 73098627036b drm/i915: Make the semaphore saturation mask global 03

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/15] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [01/15] drm/i915: Make the semaphore saturation mask global URL : https://patchwork.freedesktop.org/series/61524/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make the semaphore saturation

Re: [Intel-gfx] [RFC 1/3] kbuild: add support for ensuring headers are self-contained

2019-06-03 Thread Masahiro Yamada
Hi Sam, On Sat, May 25, 2019 at 2:40 AM Sam Ravnborg wrote: > > Hi Jani > > > Sometimes it's useful to be able to explicitly ensure certain headers > > remain self-contained, i.e. that they are compilable as standalone > > units, by including and/or forward declaring everything they depend on. >

[Intel-gfx] [PATCH] drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-03 Thread Chris Wilson
Instead of relying on the caller holding struct_mutex across the allocation, push the allocation under a tree of spinlocks stored inside the page tables. Not only should this allow us to avoid struct_mutex here, but it will allow multiple users to lock independent ranges for concurrent allocations,

Re: [Intel-gfx] [RFC 1/3] kbuild: add support for ensuring headers are self-contained

2019-06-03 Thread Masahiro Yamada
Hi Jani, On Mon, May 20, 2019 at 6:16 PM Jani Nikula wrote: > > > > > I will take a little time to considier > > how far we can extend the idea about > > "headers should be self-contained". > > Thanks! Please let me know if/when you need further action from me, I > won't post new versions until t

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/15] drm/i915: Make the semaphore saturation mask global

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [01/15] drm/i915: Make the semaphore saturation mask global URL : https://patchwork.freedesktop.org/series/61524/ State : success == Summary == CI Bug Log - changes from CI_DRM_6182 -> Patchwork_13161 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Replace struct_mutex serialisation for allocation URL : https://patchwork.freedesktop.org/series/61533/ State : warning == Summary == $ dim checkpatch origin/drm-tip d6226b7f1918 drm/i915/gtt: Replace struct_mutex serialisation for allocation -:495: C

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Replace struct_mutex serialisation for allocation URL : https://patchwork.freedesktop.org/series/61533/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Replace struct_mutex serialisation for alloc

Re: [RFC 1/3] kbuild: add support for ensuring headers are self-contained

2019-06-03 Thread Sam Ravnborg
Hi Masahiro/Jani. > > Following the obj-y pattern, > I want to make header-test-y relative to $(obj). I also considered this and agree this is better. Otherwise we end up with a spaghetti of dependencies across the tree. What I made just fit the purpose I had that day, which is no excuse for b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Replace struct_mutex serialisation for allocation URL : https://patchwork.freedesktop.org/series/61533/ State : success == Summary == CI Bug Log - changes from CI_DRM_6182 -> Patchwork_13162 Summar

[Intel-gfx] [PATCH 1/7] drm/i915: Combine unbound/bound list tracking for objects

2019-06-03 Thread Chris Wilson
With async binding, we don't want to manage a bound/unbound list as we may end up running before we even acquire the pages. All that is required is keeping track of shrinkable objects, so reduce it to the minimum list. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_domain.c

[Intel-gfx] [PATCH 2/7] drm/i915: Propagate fence errors

2019-06-03 Thread Chris Wilson
Errors spread like wildfire, and must eventually be returned to the user. They need to be captured and passed along the flow of fences, infecting each in turn with the existing error, until finally they fall out of a user visible result. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 4/7] drm/i915/gtt: Replace struct_mutex serialisation for allocation

2019-06-03 Thread Chris Wilson
Instead of relying on the caller holding struct_mutex across the allocation, push the allocation under a tree of spinlocks stored inside the page tables. Not only should this allow us to avoid struct_mutex here, but it will allow multiple users to lock independent ranges for concurrent allocations,

[Intel-gfx] [PATCH 5/7] drm/i915: Pull kref into i915_address_space

2019-06-03 Thread Chris Wilson
Make the kref common to both derived structs (i915_ggtt and i915_ppgtt) so that we can safely reference count an abstract ctx->vm address space. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_client_blt.c| 4 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 132 +--

[Intel-gfx] [PATCH 3/7] drm/i915: Allow page pinning to be in the background

2019-06-03 Thread Chris Wilson
Assume that pages may be pinned in a background task and use a completion event to synchronise with callers that must access the pages immediately. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 1 + drivers/gpu/drm/i915/gem/i915_gem_object.h| 7 +-- .../gp

[Intel-gfx] [PATCH 6/7] drm/i915: Rename i915_hw_ppgtt to i915_ppgtt

2019-06-03 Thread Chris Wilson
Keeping the _hw_ in there does not help to distinguish it from its brethren i915_ggtt, so drop it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 8 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 12 +-- .../gpu/drm/i915/gem/selftests/mock_context.c | 2 +-

[Intel-gfx] [PATCH 7/7] drm/i915: Allow vma binding to occur asynchronously

2019-06-03 Thread Chris Wilson
If we let pages be allocated asynchronously, we also then want to push the binding process into an asynchronous task. Make it so, utilising the recent improvements to fence error tracking and struct_mutex reduction. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c|

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects URL : https://patchwork.freedesktop.org/series/61537/ State : warning == Summary == $ dim checkpatch origin/drm-tip df5d9cb2c640 drm/i915: Combine unbound/bound list tracking for

[Intel-gfx] [PATCH 12/22] gpu: i915.rst: Fix references to renamed files

2019-06-03 Thread Mauro Carvalho Chehab
WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function Hardware workarounds ./drivers/gpu/drm/i915/intel_workarounds.c' failed with return code 1 WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function Logical Rings, Logical Ring Contexts and Execlists ./drivers/

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow vma binding to occur asynchronously

2019-06-03 Thread Chris Wilson
Quoting Chris Wilson (2019-06-03 18:49:35) > If we let pages be allocated asynchronously, we also then want to push > the binding process into an asynchronous task. Make it so, utilising the > recent improvements to fence error tracking and struct_mutex reduction. Caveat emptor. Definitely missing

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects URL : https://patchwork.freedesktop.org/series/61537/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Combine unbound/bound list

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects

2019-06-03 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Combine unbound/bound list tracking for objects URL : https://patchwork.freedesktop.org/series/61537/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6182 -> Patchwork_13163 ==

Re: [Intel-gfx] [PATCH 0/2] split out intel_display_power

2019-06-03 Thread Jani Nikula
On Sat, 01 Jun 2019, Chris Wilson wrote: > Quoting Daniele Ceraolo Spurio (2019-05-31 23:24:07) >> Separate the display PM from the PCI-level runtime PM. >> I'll follow this up with v2 of the rpm encapsulation series [1], but >> I'd like to get this in before that to avoid having to carry this >>

Re: [Intel-gfx] [RFC 1/7] drm/i915: prefer i915_runtime_pm in intel_runtime function

2019-06-03 Thread Jani Nikula
On Fri, 31 May 2019, Daniele Ceraolo Spurio wrote: > On 5/21/19 1:45 AM, Jani Nikula wrote: >> On Thu, 16 May 2019, Daniele Ceraolo Spurio >> wrote: >>> As a first step towards updating the code to work on the runtime_pm >>> structure instead of i915, rework all the internals to use and pass >>

Re: [Intel-gfx] [PATCH] drm/i915/perf: fix whitelist on Gen10+

2019-06-03 Thread Kenneth Graunke
On Saturday, June 1, 2019 3:58:45 PM PDT Lionel Landwerlin wrote: > Gen10 added an additional NOA_WRITE register (high bits) and we forgot > to whitelist it for userspace. > > Fixes: 95690a02fb5d96 ("drm/i915/perf: enable perf support on CNL") > Signed-off-by: Lionel Landwerlin > --- > drivers/g

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: Update MOCS table for EHL

2019-06-03 Thread Matt Roper
On Sat, Jun 01, 2019 at 06:22:53AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ehl: Update MOCS table for EHL > URL : https://patchwork.freedesktop.org/series/61409/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6171_full -> Patchwork_13142_fu

[Intel-gfx] [PATCH] drm/i915/dp: Correctly advertise HBR3 for GEN11+

2019-06-03 Thread matthew . s . atwood
From: Matt Atwood intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to use before encoder_type is set. This caused GEN11+ to incorrectly strip HBR3 from source rates. Move intel_dp_set_source_rates() to after encoder_type is set. Add comment to intel_dp_is_edp() describing unsa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make the semaphore saturation mask global (rev2)

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: Make the semaphore saturation mask global (rev2) URL : https://patchwork.freedesktop.org/series/61522/ State : success == Summary == CI Bug Log - changes from CI_DRM_6180_full -> Patchwork_13158_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Correctly advertise HBR3 for GEN11+

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915/dp: Correctly advertise HBR3 for GEN11+ URL : https://patchwork.freedesktop.org/series/61546/ State : success == Summary == CI Bug Log - changes from CI_DRM_6182 -> Patchwork_13164 Summary --- **

Re: [Intel-gfx] question about i915 GPU driver in VM

2019-06-03 Thread Micah Morton
On Sun, Jun 2, 2019 at 6:52 PM Zhang, Xiong Y wrote: > > > Hi, > > > > I'm trying to get iGPU passthrough working in a VM running on a Chrome OS > > "7th Generation (Kaby Lake) Intel Core i5-7Y57 with HD Graphics 615" device. > > I'm able to pass the iGPU through to the VM and execute the i915 dri

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add i2c symlink under hdmi connector (rev3)

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: add i2c symlink under hdmi connector (rev3) URL : https://patchwork.freedesktop.org/series/60866/ State : success == Summary == CI Bug Log - changes from CI_DRM_6180_full -> Patchwork_13159_full Summar

Re: [Intel-gfx] [PATCH] drm/i915/dp: Correctly advertise HBR3 for GEN11+

2019-06-03 Thread Manasi Navare
On Mon, Jun 03, 2019 at 02:49:40PM -0700, matthew.s.atw...@intel.com wrote: > From: Matt Atwood > > intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to > use before encoder_type is set. This caused GEN11+ to incorrectly strip > HBR3 from source rates. Move intel_dp_set_source_

Re: [Intel-gfx] [RFC 1/3] kbuild: add support for ensuring headers are self-contained

2019-06-03 Thread Masahiro Yamada
Hi Sam, Jani, On Tue, Jun 4, 2019 at 2:33 AM Sam Ravnborg wrote: > > Hi Masahiro/Jani. > > > > > Following the obj-y pattern, > > I want to make header-test-y relative to $(obj). > > I also considered this and agree this is better. > > Otherwise we end up with a spaghetti of dependencies across t

Re: [Intel-gfx] [PATCH] drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15

2019-06-03 Thread Khaled Almahallawy
On 5/30/19 2:20 PM, Manasi Navare wrote: On Thu, May 30, 2019 at 12:33:40PM -0700, Almahallawy, Khaled wrote: On Wed, 2019-05-22 at 12:25 -0700, Manasi Navare wrote: On Tue, May 21, 2019 at 04:24:58PM +0300, Ville Syrjälä wrote: On Mon, May 20, 2019 at 04:25:41PM -0700, Khaled Almahallawy wro

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix per-pixel alpha with CCS

2019-06-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix per-pixel alpha with CCS URL : https://patchwork.freedesktop.org/series/61526/ State : success == Summary == CI Bug Log - changes from CI_DRM_6182_full -> Patchwork_13160_full Summary --- **