Hello Chris Wilson,
The patch cc731f5a3b1f: "drm/i915: Trim struct_mutex hold duration
for i915_gem_free_objects" from Oct 13, 2017, leads to the following
static checker warning:
drivers/gpu/drm/i915/gem/i915_gem_object.c:195 __i915_gem_free_objects()
error: we previously assumed
Quoting Dan Carpenter (2019-05-30 09:13:01)
> Hello Chris Wilson,
>
> The patch cc731f5a3b1f: "drm/i915: Trim struct_mutex hold duration
> for i915_gem_free_objects" from Oct 13, 2017, leads to the following
> static checker warning:
>
> drivers/gpu/drm/i915/gem/i915_gem_object.c:195
> _
Since the next entry is an offset from a pointer, it can not be NULL.
For simplicity, drop the extra conditional before calling cond_resched()
Reported-by: Dan Carpenter
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 3 +--
1 file changed, 1 insertion(+), 2 deletio
Hi,
> -Original Message-
> From: Summers, Stuart
> Sent: keskiviikko 29. toukokuuta 2019 19.02
> To: Saarinen, Jani ; Ceraolo Spurio, Daniele
> ; Navare, Manasi D
>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask
>
> On Wed, 20
In order to support driver hot unbind, some cleanup operations, now
performed on PCI driver remove, must be called later, after all device
file descriptors are closed.
Split out those operations from the tail of pci_driver.remove()
callback and put them into drm_driver.release() which is called as
Hi,
I do realize more work needs to be done to get a clean hotunplug
solution, however I need your comments to make sure that I'm going in
the right direction.
So far I have no good idea how to resolve pm_runtime_get_sync()
failures on outstanding device file close after successfull driver
unbind
== Series Details ==
Series: drm/i915: Drop non-NULL llist_for_each_entry_safe check for
URL : https://patchwork.freedesktop.org/series/61374/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6167 -> Patchwork_13136
Summary
--
Quoting Janusz Krzysztofik (2019-05-30 10:24:26)
> In order to support driver hot unbind, some cleanup operations, now
> performed on PCI driver remove, must be called later, after all device
> file descriptors are closed.
>
> Split out those operations from the tail of pci_driver.remove()
> callb
== Series Details ==
Series: drm/i915: Split off pci_driver.remove() tail to drm_driver.release()
URL : https://patchwork.freedesktop.org/series/61376/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6168 -> Patchwork_13137
S
On Wed, 29 May 2019 at 22:14, Chris Wilson wrote:
>
> On apl, mmio reads fail, reading 0.
> On cml, SRM reads fail, reading 0.
>
> Combine both approaches, starting with SRM and fixing in the blanks with
> mmio reads.
>
> Signed-off-by: Chris Wilson
> Cc: Matthew Auld
> Cc: Mika Kuoppala
Review
The default behaviour is to periodically check for a mmio access error,
and once detected enable mmio access checking. However this is useless
if the error only occurs once.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/Kconfig.debug | 12
drivers/gpu/drm/i
In order to support driver hot unbind, some cleanup operations, now
performed on PCI driver remove, must be called later, after all device
file descriptors are closed.
Split out those operations from the tail of pci_driver.remove()
callback and put them into drm_driver.release() which is called as
On Thu, 2019-05-30 at 09:29 +0100, Saarinen, Jani wrote:
> Hi,
>
>
> > -Original Message-
> > From: Summers, Stuart
> > Sent: keskiviikko 29. toukokuuta 2019 19.02
> > To: Saarinen, Jani ; Ceraolo Spurio,
> > Daniele
> > ; Navare, Manasi D
> >
> > Cc: intel-gfx@lists.freedesktop.org
> >
On 5/30/19 1:29 AM, Saarinen, Jani wrote:
Hi,
-Original Message-
From: Summers, Stuart
Sent: keskiviikko 29. toukokuuta 2019 19.02
To: Saarinen, Jani ; Ceraolo Spurio, Daniele
; Navare, Manasi D
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [CI 0/5] Refactor to expand
Accidentally added during the merge of drm-next.
Fixes: 7126b65091c4 ("Merge remote-tracking branch 'drm/drm-next' into drm-tip")
Reported-by: Jani Saarinen
Signed-off-by: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 --
1 file changed, 6 dele
Quoting Daniele Ceraolo Spurio (2019-05-30 16:16:21)
> Accidentally added during the merge of drm-next.
It's a dim issue. A dinq patch cherry-picked into dif that git isn't
eliminating the duplication when dim build tips.
https://drm.pages.freedesktop.org/maintainer-tools/drm-tip.html#resolving-co
On Tue, 28 May 2019 at 20:50, Chris Wilson wrote:
>
> Currently the purgeable objects, I915_MADV_DONTNEED, as mixed in the
> normal bound/unbound lists. Every shrinker pass starts with an attempt
> to purge from this set of unneeded objects, which entails us doing a
> walk over both lists looking
== Series Details ==
Series: drm/i915: remove duplicated WaDisableBankHangMode:icl
URL : https://patchwork.freedesktop.org/series/61396/
State : failure
== Summary ==
Applying: drm/i915: remove duplicated WaDisableBankHangMode:icl
Using index info to reconstruct a base tree...
M drivers/
On Tue, 28 May 2019 at 20:50, Chris Wilson wrote:
>
> Currently, we try to report to the shrinker the precise number of
> objects (pages) that are available to be reaped at this moment. This
> requires searching all objects with allocated pages to see if they
> fulfill the search criteria, and thi
On 28/05/2019 11:52, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-05-21 15:08:54)
@@ -2048,6 +2081,42 @@ static int eb_submit(struct i915_execbuffer *eb)
return err;
}
if (eb->oa_config) {
err = i915_active_request_set(&eb->i915->perf.oa.oa_confi
Quoting Matthew Auld (2019-05-30 17:10:16)
> On Tue, 28 May 2019 at 20:50, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index fb2e89133e78..770c54b87de6 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i91
On Wed, 2019-05-22 at 12:25 -0700, Manasi Navare wrote:
> On Tue, May 21, 2019 at 04:24:58PM +0300, Ville Syrjälä wrote:
> > On Mon, May 20, 2019 at 04:25:41PM -0700, Khaled Almahallawy wrote:
> > > According to DP 1.4 standard, if the source supports four pre-
> > > emphasis levels, then the sourc
Currently, we try to report to the shrinker the precise number of
objects (pages) that are available to be reaped at this moment. This
requires searching all objects with allocated pages to see if they
fulfill the search criteria, and this count is performed quite
frequently. (The shrinker tries to
Currently the purgeable objects, I915_MADV_DONTNEED, are mixed in the
normal bound/unbound lists. Every shrinker pass starts with an attempt
to purge from this set of unneeded objects, which entails us doing a
walk over both lists looking for any candidates. If there are none, and
since we are shri
== Series Details ==
Series: series starting with [1/2] drm/i915: Track the purgeable objects on a
separate eviction list
URL : https://patchwork.freedesktop.org/series/61405/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Track the purgeabl
On Thu, May 30, 2019 at 12:33:40PM -0700, Almahallawy, Khaled wrote:
> On Wed, 2019-05-22 at 12:25 -0700, Manasi Navare wrote:
> > On Tue, May 21, 2019 at 04:24:58PM +0300, Ville Syrjälä wrote:
> > > On Mon, May 20, 2019 at 04:25:41PM -0700, Khaled Almahallawy wrote:
> > > > According to DP 1.4 sta
EHL defines two new MOCS table entries but is otherwise compatible with
the ICL MOCS table.
These table entries (16 and 17) should still be considered unused for
ICL and as such their behavior remains undefined for that platform.
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_mocs.
Hi,
> -Original Message-
> From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> Sent: torstai 30. toukokuuta 2019 18.23
> To: Ceraolo Spurio, Daniele ; intel-
> g...@lists.freedesktop.org
> Cc: Ceraolo Spurio, Daniele ; Saarinen, Jani
>
> Subject: Re: [PATCH] drm/i915: remove duplicate
Quoting Saarinen, Jani (2019-05-31 07:20:10)
> Hi,
>
> > -Original Message-
> > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
> > Sent: torstai 30. toukokuuta 2019 18.23
> > To: Ceraolo Spurio, Daniele ; intel-
> > g...@lists.freedesktop.org
> > Cc: Ceraolo Spurio, Daniele ; Saarin
29 matches
Mail list logo
