Re: [Intel-gfx] [PATCH] kernel.h: Add non_block_start/end()

2019-05-22 Thread Daniel Vetter
On Tue, May 21, 2019 at 11:06 PM Tetsuo Handa wrote: > > On 2019/05/21 23:44, Daniel Vetter wrote: > OOM notifiers should not depend on any locks or sleepable conditionals. > If some lock directly or indirectly depended on __GFP_DIRECT_RECLAIM, > it will deadlock. Thus, despite bloc

Re: [Intel-gfx] [PATCH] kernel.h: Add non_block_start/end()

2019-05-22 Thread Chris Wilson
Quoting Michal Hocko (2019-05-22 07:34:42) > On Wed 22-05-19 06:06:31, Tetsuo Handa wrote: > [...] > > Since OOM notifier will be called after shrinkers are attempted, > > can i915 move from OOM notifier to shrinker? > > That would be indeed preferable. OOM notifier is an API from hell. We were^W

[Intel-gfx] Getting "rcs0: reset request timeout" on 4.19.16

2019-05-22 Thread Marcin Owsiany
Hello, Every couple of weeks or so my laptop experiences some graphics-related crash. Sometimes it's more frequent - happened twice yesterday. I'm wondering whether this could be a sign of a hardware failure? Or is this some software lock-up? Please do let me know whether I can do anything to he

Re: [Intel-gfx] Getting "rcs0: reset request timeout" on 4.19.16

2019-05-22 Thread Chris Wilson
Quoting Marcin Owsiany (2019-05-22 08:54:50) > Hello, > > Every couple of weeks or so my laptop experiences some graphics-related > crash. Sometimes it's more frequent - happened twice yesterday. > > I'm wondering whether this could be a sign of a hardware failure? Or is this > some software lock

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon notifier begone! (rev2)

2019-05-22 Thread Patchwork
== Series Details == Series: fbcon notifier begone! (rev2) URL : https://patchwork.freedesktop.org/series/60843/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114 -> Patchwork_13061 Summary --- **SUCCESS** No reg

[Intel-gfx] [CI 01/13] drm/i915: Split GEM object type definition to its own header

2019-05-22 Thread Chris Wilson
For convenience in avoiding inline spaghetti, keep the type definition as a separate header. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Acked-by: Rodrigo Vivi Acked-by: Jani Nikula Acked-by: Joonas Lahtinen --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm

[Intel-gfx] [CI 03/13] drm/i915: Move object->pages API to i915_gem_object.[ch]

2019-05-22 Thread Chris Wilson
Currently the code for manipulating the pages on an object is still residing in i915_gem.c, move it to i915_gem_object.c Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 4 +- .../gpu/drm/i915/{ => gem}/i915_gem_obj

[Intel-gfx] [CI 08/13] drm/i915: Move more GEM objects under gem/

2019-05-22 Thread Chris Wilson
Continuing the theme of separating out the GEM clutter. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 26 +-- drivers/gpu/drm/i915/Makefile.header-test | 2 - .../gpu/drm/i915/{ => gem}/i915_gem_clflush.c | 24 ++

[Intel-gfx] [CI 13/13] drm/i915: Move GEM client throttling to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the client self throttling into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_throttle.c | 73 drivers/gpu/d

[Intel-gfx] [CI 05/13] drm/i915: Move phys objects to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, this time the legacy physical object. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/gem/i915_gem_object.h| 11 +- .../gpu/drm/i915/gem/i915_gem_object_types.h

[Intel-gfx] [CI 04/13] drm/i915: Move shmem object setup to its own file

2019-05-22 Thread Chris Wilson
Split the plain old shmem object into its own file to start decluttering i915_gem.c v2: Lose the confusing, hysterical raisins, suffix of _gtt. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/gem/i915_gem_ob

[Intel-gfx] [CI 06/13] drm/i915: Move mmap and friends to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, now the turn of do_mmap and the faulthandlers Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_mman.c | 504 drivers/gpu/drm/i915/ge

[Intel-gfx] [CI 07/13] drm/i915: Move GEM domain management to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c, that of the read/write domains, perhaps the biggest of GEM's follies? Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_domain.c| 782 +

[Intel-gfx] [CI 11/13] drm/i915: Move GEM object waiting to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the object wait decomposition into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gem/i915_gem_object.h | 8 + drivers/gpu/drm/i915/gem/i915_g

[Intel-gfx] [CI 10/13] drm/i915: Move GEM object domain management from struct_mutex to local

2019-05-22 Thread Chris Wilson
Use the per-object local lock to control the cache domain of the individual GEM objects, not struct_mutex. This is a huge leap forward for us in terms of object-level synchronisation; execbuffers are coordinated using the ww_mutex and pread/pwrite is finally fully serialised again. Signed-off-by:

[Intel-gfx] [CI 12/13] drm/i915: Move GEM object busy checking to its own file

2019-05-22 Thread Chris Wilson
Continuing the decluttering of i915_gem.c by moving the object busy checking into its own file. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_busy.c | 138 +++ drivers/gpu/drm/i9

[Intel-gfx] [CI 02/13] drm/i915: Pull GEM ioctls interface to its own file

2019-05-22 Thread Chris Wilson
Declutter i915_drv/gem.h by moving the ioctl API into its own header. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 52 ++ drivers/gpu/drm/i915/i915_drv.c| 1 + drivers/gpu/drm/i915/i915_drv.h|

[Intel-gfx] [CI 09/13] drm/i915: Pull scatterlist utils out of i915_gem.h

2019-05-22 Thread Chris Wilson
Out scatterlist utility routines can be pulled out of i915_gem.h for a bit more decluttering. v2: Push I915_GTT_PAGE_SIZE out of i915_scatterlist itself and into the caller. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 1 + drivers

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 22/27] tests/i915_query: Engine discovery tests

2019-05-22 Thread Andi Shyti
Hi Tvrtko, On Mon, May 20, 2019 at 03:47:34PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Test the new engine discovery query. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Andi Shyti Thanks, Andi ___ Intel-gfx mailing list Intel-gfx@

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/60940/ State : warning == Summary == $ dim checkpatch origin/drm-tip 21a4f2a14a6c drm/i915: Split GEM object type definition

[Intel-gfx] [PATCH i-g-t] drm-uapi: Import i915_drm.h upto a88b6e4cbafd

2019-05-22 Thread Chris Wilson
commit a88b6e4cbafd6f23b3450c087acdbe23d90e7606 Author: Chris Wilson Date: Tue May 21 22:11:34 2019 +0100 drm/i915: Allow specification of parallel execbuf Signed-off-by: Chris Wilson --- include/drm-uapi/i915_drm.h | 164 +++- 1 file changed, 162 insertio

[Intel-gfx] [PATCH i-g-t] drm-uapi: Import i915_drm.h upto a88b6e4cbafd

2019-05-22 Thread Chris Wilson
commit a88b6e4cbafd6f23b3450c087acdbe23d90e7606 Author: Chris Wilson Date: Tue May 21 22:11:34 2019 +0100 drm/i915: Allow specification of parallel execbuf Signed-off-by: Chris Wilson --- include/drm-uapi/i915_drm.h | 167 +++- 1 file changed, 164 insertio

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/60940/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Split GEM object t

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] drm-uapi: Import i915_drm.h upto a88b6e4cbafd

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 09:30, Chris Wilson wrote: commit a88b6e4cbafd6f23b3450c087acdbe23d90e7606 Author: Chris Wilson Date: Tue May 21 22:11:34 2019 +0100 drm/i915: Allow specification of parallel execbuf Signed-off-by: Chris Wilson Acked-by: Tvrtko Ursulin Regards, Tvrtko --- includ

[Intel-gfx] ✗ Fi.CI.IGT: failure for linux-next: manual merge of the drm-misc tree with Linus' tree (rev2)

2019-05-22 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-misc tree with Linus' tree (rev2) URL : https://patchwork.freedesktop.org/series/60886/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13056_full

[Intel-gfx] ✓ Fi.CI.IGT: success for kernel.h: Add non_block_start/end()

2019-05-22 Thread Patchwork
== Series Details == Series: kernel.h: Add non_block_start/end() URL : https://patchwork.freedesktop.org/series/60896/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13057_full Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/60940/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6117 -> Patchwork_13067 ==

[Intel-gfx] [CI] drm/i915: Engine discovery query

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_I915_QUERY_ENGINE_INFO, together with accompa

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/13] drm/i915: Split GEM object type definition to its own header

2019-05-22 Thread Chris Wilson
Quoting Patchwork (2019-05-22 09:56:06) > Possible regressions > > * igt@runner@aborted: > - fi-ilk-650: NOTRUN -> [FAIL][1] >[1]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13067/fi-ilk-650/igt@run...@aborted.html Oh, a new test arrived that needs convertin

[Intel-gfx] [CI] i915: Add gem_vm_create

2019-05-22 Thread Chris Wilson
Exercise basic creation and swapping between new address spaces. v2: Check isolation that the same vm_id on different fd are indeed different VM. v3: Cross-over check with CREATE_EXT_SETPARAM Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- lib/Makefile.sources

Re: [Intel-gfx] [PATCH] kernel.h: Add non_block_start/end()

2019-05-22 Thread Michal Hocko
On Wed 22-05-19 08:13:57, Chris Wilson wrote: > Quoting Michal Hocko (2019-05-22 07:34:42) > > On Wed 22-05-19 06:06:31, Tetsuo Handa wrote: > > [...] > > > Since OOM notifier will be called after shrinkers are attempted, > > > can i915 move from OOM notifier to shrinker? > > > > That would be ind

[Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-22 Thread Mika Kuoppala
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing. Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- lib/igt_dummyload.c| 32 +++- lib/igt_dummyload.h| 1 + tests/i915/gem_exec_schedule.c | 25 +++

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev3)

2019-05-22 Thread Tvrtko Ursulin
On 21/05/2019 18:51, Patchwork wrote: == Series Details == Series: series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev3) URL : https://patchwork.freedesktop.org/series/60857/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114 -> Patchwork_1306

Re: [Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-22 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-22 10:13:46) > Instead of relying a static obj array inside igt_spin_t, > access it with proper indexing. > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala > --- > lib/igt_dummyload.c| 32 +++- > lib/igt_dummyload.h

Re: [Intel-gfx] [PATCH 4/5] drm/i915: add a new perf configuration execbuf parameter

2019-05-22 Thread Lionel Landwerlin
On 21/05/2019 18:48, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-21 18:19:50) On 21/05/2019 18:07, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-21 15:08:54) + if (eb->oa_config && + eb->oa_config != eb->i915->perf.oa.exclusive_stream->oa_config) { But the

Re: [Intel-gfx] [PATCH 4/5] drm/i915: add a new perf configuration execbuf parameter

2019-05-22 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-05-22 10:19:46) > On 21/05/2019 18:48, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-05-21 18:19:50) > >> On 21/05/2019 18:07, Chris Wilson wrote: > >>> Quoting Lionel Landwerlin (2019-05-21 15:08:54) > + if (eb->oa_config && > + e

Re: [Intel-gfx] [PATCH 4/5] drm/i915: add a new perf configuration execbuf parameter

2019-05-22 Thread Lionel Landwerlin
On 22/05/2019 10:25, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-22 10:19:46) On 21/05/2019 18:48, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-21 18:19:50) On 21/05/2019 18:07, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-21 15:08:54) + if (eb->oa_config

[Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-22 Thread Mika Kuoppala
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing. v2: IGT_SPIN_BATCH Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- lib/igt_dummyload.c| 13 ++--- lib/igt_dummyload.h| 1 + tests/i915/gem_exec_schedule.c | 25 ++

Re: [Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-22 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-22 10:34:02) > Instead of relying a static obj array inside igt_spin_t, > access it with proper indexing. > > v2: IGT_SPIN_BATCH > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala > --- > lib/igt_dummyload.c| 13 ++--- > lib/igt_dummyload.h

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Support for DP YCbCr4:2:0 outputs (rev4)

2019-05-22 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP YCbCr4:2:0 outputs (rev4) URL : https://patchwork.freedesktop.org/series/60404/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13058_full Summar

[Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-22 Thread Mika Kuoppala
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing. v2: IGT_SPIN_BATCH v3: indent Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- lib/igt_dummyload.c| 13 ++--- lib/igt_dummyload.h| 1 + tests/i9

Re: [Intel-gfx] [PATCH] fbcon: Remove fbcon_has_exited

2019-05-22 Thread Bartlomiej Zolnierkiewicz
Hi Daniel, On 5/21/19 4:23 PM, Daniel Vetter wrote: > This is unused code since > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > Author: Daniel Vetter > Date: Tue Aug 1 17:32:07 2017 +0200 > > fbcon: Make fbcon a built-time depency for fbdev > > when fbcon was made a compile-time s

Re: [Intel-gfx] [PATCH i-g-t 05/16] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-16 09:38:15) > > On 15/05/2019 20:05, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-05-14 11:15:12) > >> > >> On 08/05/2019 11:09, Chris Wilson wrote: > >>> Check that the extended create interface accepts setparam. > >>> > >>> Signed-off-by: Chris Wilson >

[Intel-gfx] [PATCH] drm/i915: remove duplicate typedef for intel_wakeref_t

2019-05-22 Thread Jani Nikula
Fix the duplicate typedef for intel_wakeref_t leading to Clang build issues. While at it, actually make the intel_runtime_pm.h header self-contained, which was claimed in the commit being fixed. Reported-by: Nathan Chancellor Cc: Nathan Chancellor Cc: Chris Wilson References: http://mid.mail-ar

Re: [Intel-gfx] [PATCH i-g-t 05/16] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 11:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-16 09:38:15) On 15/05/2019 20:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-14 11:15:12) On 08/05/2019 11:09, Chris Wilson wrote: Check that the extended create interface accepts setparam. Signed-off-by: Ch

Re: [Intel-gfx] [18/21] drm/i915: extract intel_runtime_pm.h from intel_drv.h

2019-05-22 Thread Jani Nikula
On Tue, 21 May 2019, Nathan Chancellor wrote: > Hi Jani, > > On Mon, Apr 29, 2019 at 03:29:36PM +0300, Jani Nikula wrote: >> It used to be handy that we only had a couple of headers, but over time >> intel_drv.h has become unwieldy. Extract declarations to a separate >> header file corresponding t

Re: [Intel-gfx] [PATCH] fbcon: Remove fbcon_has_exited

2019-05-22 Thread Daniel Vetter
On Wed, May 22, 2019 at 12:04 PM Bartlomiej Zolnierkiewicz wrote: > > > Hi Daniel, > > On 5/21/19 4:23 PM, Daniel Vetter wrote: > > This is unused code since > > > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > > Author: Daniel Vetter > > Date: Tue Aug 1 17:32:07 2017 +0200 > > > > fbc

Re: [Intel-gfx] [PATCH] drm/i915: remove duplicate typedef for intel_wakeref_t

2019-05-22 Thread Chris Wilson
Quoting Jani Nikula (2019-05-22 11:35:05) > Fix the duplicate typedef for intel_wakeref_t leading to Clang build > issues. While at it, actually make the intel_runtime_pm.h header > self-contained, which was claimed in the commit being fixed. > > Reported-by: Nathan Chancellor > Cc: Nathan Chance

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/10] drm/i915: Restore control over ppgtt for context creation ABI

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [CI,01/10] drm/i915: Restore control over ppgtt for context creation ABI URL : https://patchwork.freedesktop.org/series/60909/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13059_full ===

Re: [Intel-gfx] [PATCH i-g-t 10/16] i915/gem_exec_whisper: Fork all-engine tests one-per-engine

2019-05-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-16 09:57:08) > > On 15/05/2019 20:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-05-14 13:57:26) > >> > >> On 08/05/2019 11:09, Chris Wilson wrote: > >>> Add a new mode for some more stress, submit the all-engines tests > >>> simultaneously, a stream per e

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Don't try to check HuC status if it's not loaded

2019-05-22 Thread Ye, Tony
On 5/21/2019 7:08 PM, Michal Wajdeczko wrote: On Tue, 21 May 2019 13:04:12 +0200, Ye, Tony wrote: There are two users of I915_PARAM_HUC_STATUS, the intel-media driver and the legacy intel-vaapi-driver. Both drivers check the return value like this: has_huc = !! ret_value; So the ABI

[Intel-gfx] [PATCH i-g-t 03/12] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-22 Thread Chris Wilson
Check that the extended create interface accepts setparam. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_create.c | 225 ++-- 1 file changed, 213 insertions(+), 12 deletions(-) diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c index a664

[Intel-gfx] [PATCH i-g-t 11/12] i915/gem_exec_latency: Measure the latency of context switching

2019-05-22 Thread Chris Wilson
Measure the baseline latency between contexts in order to directly compare that with the additional cost of preemption. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_latency.c | 230 ++ 1 file changed, 230 insertions(+) diff --git a/tests/i915/gem_exec_late

[Intel-gfx] [PATCH i-g-t 12/12] i915/gem_exec_latency: Add another variant of waiter latency

2019-05-22 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/i915/gem_exec_latency.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/tests/i915/gem_exec_latency.c b/tests/i915/gem_exec_latency.c index e88fbbc6a..fd4ceb4d6 100644 --- a/tests/i915/gem_exec_latency.c +++ b/tests/i9

[Intel-gfx] [PATCH i-g-t 07/12] i915/gem_exec_whisper: Fork all-engine tests one-per-engine

2019-05-22 Thread Chris Wilson
Add a new mode for some more stress, submit the all-engines tests simultaneously, a stream per engine. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_whisper.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/tests/i915/gem_exec_whisper.c b/test

[Intel-gfx] [PATCH i-g-t 10/12] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-22 Thread Chris Wilson
The submit-fence + load_balancing apis allow for us to execute a named pair of engines in parallel; that this by submitting a request to one engine, we can then use the generated submit-fence to submit a second request to another engine and have it execute at the same time. Furthermore, by specifyi

[Intel-gfx] [PATCH i-g-t 08/12] i915: Add gem_ctx_engines

2019-05-22 Thread Chris Wilson
To exercise the new I915_CONTEXT_PARAM_ENGINES and interactions with gem_execbuf(). Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Andi Shyti Reviewed-by: Andi Shyti --- tests/Makefile.sources | 1 + tests/i915/gem_ctx_engines.c | 517 +++ tests/mes

[Intel-gfx] [PATCH i-g-t 05/12] i915: Exercise creating context with shared GTT

2019-05-22 Thread Chris Wilson
v2: Test each shared context is its own timeline and allows request reordering between shared contexts. v3: Use the modern interface to use physical engines for testing single-timeline along each real engine. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Mika Kuoppala

[Intel-gfx] [PATCH i-g-t 04/12] i915: Add gem_ctx_clone

2019-05-22 Thread Chris Wilson
Exercise cloning contexts, an extension of merely creating one. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/Makefile.sources | 1 + tests/i915/gem_ctx_clone.c | 462 + tests/meson.build | 1 + 3 files changed, 464 insert

[Intel-gfx] [PATCH i-g-t 06/12] i915/gem_ctx_switch: Exercise queues

2019-05-22 Thread Chris Wilson
Queues are a form of contexts that share vm and enfore a single timeline across all engines. Test switching between them, just like ordinary contexts. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_ctx_switch.c | 75 +++-- 1 file chang

[Intel-gfx] [PATCH i-g-t 02/12] i915/gem_ctx_param: Test set/get (copy) VM

2019-05-22 Thread Chris Wilson
Exercise reusing the GTT of one ctx in another. v2: Test setting back to the same VM v3: Check the VM still exists after the parent ctx are dead. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_ctx_param.c | 116 +--

Re: [Intel-gfx] [PATCH i-g-t 10/16] i915/gem_exec_whisper: Fork all-engine tests one-per-engine

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 11:59, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-16 09:57:08) On 15/05/2019 20:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-14 13:57:26) On 08/05/2019 11:09, Chris Wilson wrote: Add a new mode for some more stress, submit the all-engines tests simultaneou

[Intel-gfx] [PATCH i-g-t 09/12] i915: Add gem_exec_balancer

2019-05-22 Thread Chris Wilson
Exercise the in-kernel load balancer checking that we can distribute batches across the set of ctx->engines to avoid load. v2: Many assorted improvements from Tvrtko. Signed-off-by: Chris Wilson --- tests/Makefile.am |1 + tests/Makefile.sources |1 + tests/i915/gem

[Intel-gfx] [PATCH i-g-t 01/12] i915: Add gem_vm_create

2019-05-22 Thread Chris Wilson
Exercise basic creation and swapping between new address spaces. v2: Check isolation that the same vm_id on different fd are indeed different VM. v3: Cross-over check with CREATE_EXT_SETPARAM Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- lib/Makefile.sources

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev3)

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev3) URL : https://patchwork.freedesktop.org/series/60857/ State : success == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13062_full =

Re: [Intel-gfx] [PATCH i-g-t 09/12] i915: Add gem_exec_balancer

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 12:37, Chris Wilson wrote: Exercise the in-kernel load balancer checking that we can distribute batches across the set of ctx->engines to avoid load. v2: Many assorted improvements from Tvrtko. Signed-off-by: Chris Wilson --- tests/Makefile.am |1 + tests/Mak

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] mm: Check if mmu notifier callbacks are allowed to fail (rev2)

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] mm: Check if mmu notifier callbacks are allowed to fail (rev2) URL : https://patchwork.freedesktop.org/series/60874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13063_full ===

Re: [Intel-gfx] [PATCH i-g-t 10/12] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 12:37, Chris Wilson wrote: The submit-fence + load_balancing apis allow for us to execute a named pair of engines in parallel; that this by submitting a request to one engine, we can then use the generated submit-fence to submit a second request to another engine and have it execut

Re: [Intel-gfx] [PATCH i-g-t 10/12] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 13:26:43) > > On 22/05/2019 12:37, Chris Wilson wrote: > > The submit-fence + load_balancing apis allow for us to execute a named > > pair of engines in parallel; that this by submitting a request to one > > engine, we can then use the generated submit-fence to s

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-22 Thread Chris Wilson
The submit-fence + load_balancing apis allow for us to execute a named pair of engines in parallel; that this by submitting a request to one engine, we can then use the generated submit-fence to submit a second request to another engine and have it execute at the same time. Furthermore, by specifyi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine discovery query (rev11)

2019-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev11) URL : https://patchwork.freedesktop.org/series/39958/ State : warning == Summary == $ dim checkpatch origin/drm-tip f26f9f629288 drm/i915: Engine discovery query -:63: WARNING:TYPO_SPELLING: 'assigment' may be misspelled - p

[Intel-gfx] [PATCH v2 1/5] drm/i915/perf: introduce a versioning of the i915-perf uapi

2019-05-22 Thread Lionel Landwerlin
Reporting this version will help application figure out what level of the support the running kernel provides. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_drv.c | 3 +++ include/uapi/drm/i915_drm.h | 21 + 2 files changed, 24 insertions(+) diff --git

[Intel-gfx] [PATCH v2 2/5] drm/i915/perf: allow holding preemption on filtered ctx

2019-05-22 Thread Lionel Landwerlin
We would like to make use of perf in Vulkan. The Vulkan API is much lower level than OpenGL, with applications directly exposed to the concept of command buffers (pretty much equivalent to our batch buffers). In Vulkan, queries are always limited in scope to a command buffer. In OpenGL, the lack of

[Intel-gfx] [PATCH v2 5/5] drm/i915: add support for perf configuration queries

2019-05-22 Thread Lionel Landwerlin
Listing configurations at the moment is supported only through sysfs. This might cause issues for applications wanting to list configurations from a container where sysfs isn't available. This change adds a way to query the number of configurations and their content through the i915 query uAPI. v

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 13:52, Chris Wilson wrote: The submit-fence + load_balancing apis allow for us to execute a named pair of engines in parallel; that this by submitting a request to one engine, we can then use the generated submit-fence to submit a second request to another engine and have it execut

[Intel-gfx] [PATCH v2 0/5] drm/i915: Vulkan performance query support

2019-05-22 Thread Lionel Landwerlin
Hi all, This small (but maybe not to everybody's taste) series enables us to support performance queries on Vulkan. We've gone through the process to define this as a Vulkan INTEL extension (it should appear on [1] soonish). This v2 includes fixes after Chris' first round of review. Cheers, [1

[Intel-gfx] [PATCH v2 3/5] drm/i915/perf: allow for CS OA configs to be created lazily

2019-05-22 Thread Lionel Landwerlin
Here we introduce a mechanism by which the execbuf part of the i915 driver will be able to request that a batch buffer containing the programming for a particular OA config be created. We'll execute these OA configuration buffers right before executing a set of userspace commands so that a particu

[Intel-gfx] [PATCH v2 4/5] drm/i915: add a new perf configuration execbuf parameter

2019-05-22 Thread Lionel Landwerlin
We want the ability to dispatch a set of command buffer to the hardware, each with a different OA configuration. To achieve this, we reuse a couple of fields from the execbuf2 struct (I CAN HAZ execbuf3?) to notify what OA configuration should be used for a batch buffer. This requires the process m

[Intel-gfx] [PATCH i-g-t] lib/i915: Add Icelake vcs2 engine to the static list

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This enables static test enumeration to see the engine. Signed-off-by: Tvrtko Ursulin --- lib/igt_gt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/igt_gt.c b/lib/igt_gt.c index 5e5b9bef03dc..6b7c037e6d10 100644 --- a/lib/igt_gt.c +++ b/lib/igt_gt.c @@ -589,6 +5

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v5,1/2] drm/i915: Make sandybridge_pcode_read() deal with the second data register

2019-05-22 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Make sandybridge_pcode_read() deal with the second data register URL : https://patchwork.freedesktop.org/series/60921/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6114_full -> Patchwork_13064_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Engine discovery query (rev11)

2019-05-22 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev11) URL : https://patchwork.freedesktop.org/series/39958/ State : success == Summary == CI Bug Log - changes from CI_DRM_6120 -> Patchwork_13068 Summary --- **SUCCESS*

[Intel-gfx] [PATCH i-g-t 1/2] drm-uapi: Import i915_drm.h upto c5d3e39caa456b1e061644b739131f2b54c84c08

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin commit c5d3e39caa456b1e061644b739131f2b54c84c08 Author: Tvrtko Ursulin Date: Wed May 22 10:00:54 2019 +0100 drm/i915: Engine discovery query Signed-off-by: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 42 + 1 file cha

[Intel-gfx] [PATCH i-g-t 2/2] tests/i915_query: Engine discovery tests

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Test the new engine discovery query. Signed-off-by: Tvrtko Ursulin Reviewed-by: Andi Shyti --- tests/i915/i915_query.c | 247 1 file changed, 247 insertions(+) diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c index 7

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Engine discovery query (rev11)

2019-05-22 Thread Tvrtko Ursulin
On 22/05/2019 14:27, Patchwork wrote: == Series Details == Series: drm/i915: Engine discovery query (rev11) URL : https://patchwork.freedesktop.org/series/39958/ State : success == Summary == CI Bug Log - changes from CI_DRM_6120 -> Patchwork_13068 ==

[Intel-gfx] [CI i-g-t 02/14] lib/i915: add gem_engine_topology library and for_each loop definition

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti The gem_engine_topology library is a set of functions that interface with the query and getparam/setparam ioctls. The library's access point is the 'intel_init_engine_list()' function that, everytime is called, generates the list of active engines and returns them in a 'struct i

[Intel-gfx] [CI i-g-t 06/14] test: perf_pmu: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Use whenever possible gem_engine_can_store_dword() that checks class instead of flags. Now the __for_each_engine_class_instance and for_each_engine_class_instance are unuse

[Intel-gfx] [CI i-g-t 00/14] Andi's engine discovery for CI

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just for CI since the first patch from the original series won't apply any more. Andi Shyti (13): lib/i915: add gem_engine_topology library and for_each loop definition lib: igt_gt: add execution buffer flags to class helper lib: igt_gt: make gem_engine_can_store_dword

[Intel-gfx] [CI i-g-t 08/14] test/i915: gem_cs_tlb: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Daniel Vetter Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_cs_tlb.c | 8 1 file changed, 4 insertions(+), 4 de

[Intel-gfx] [CI i-g-t 04/14] lib: igt_gt: make gem_engine_can_store_dword() check engine class

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Engines referred by class and instance are getting more popular, gem_engine_can_store_dword() should handle the situation. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti Reviewed-by: Tvrtko Ursulin --- lib/igt_gt.c | 12 +--- lib/igt_gt.h | 1 + 2 files chan

[Intel-gfx] [CI i-g-t 05/14] lib: igt_dummyload: use for_each_context_engine()

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti With the new getparam/setparam api, engines are mapped to context. Use for_each_context_engine() to loop through existing engines. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti Reviewed-by: Tvrtko Ursulin --- lib/igt_dummyload.c | 29 - 1

[Intel-gfx] [CI i-g-t 09/14] test/i915: gem_ctx_exec: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel Vetter Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_ctx_exec.c | 16 +++- 1 file

[Intel-gfx] [CI i-g-t 10/14] test/i915: gem_exec_basic: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_exec_basic.c | 28 ++-- 1 file changed, 14 insertions(+

[Intel-gfx] [CI i-g-t 12/14] test/i915: gem_exec_store: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_exec_store.c | 36 ++-- 1 file changed, 18 inse

[Intel-gfx] [CI i-g-t 14/14] test/i915: i915_hangman: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Mika Kuoppala Cc: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/i915_hangman.c | 15 --- 1 file changed, 4 insertion

[Intel-gfx] [CI i-g-t 03/14] lib: igt_gt: add execution buffer flags to class helper

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti we have a "class/instance to eb flags" helper but not the opposite, add it. Suggested-by: Tvrtko Ursulin Signed-off-by: Andi Shyti Reviewed-by: Tvrtko Ursulin --- lib/igt_gt.c | 18 ++ lib/igt_gt.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/lib/

[Intel-gfx] [CI i-g-t 13/14] test/i915: gem_wait: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_wait.c | 24 1 file changed, 12 insertions(+), 12 dele

[Intel-gfx] [CI i-g-t 01/14] drm-uapi: Import i915_drm.h upto c5d3e39caa456b1e061644b739131f2b54c84c08

2019-05-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin commit c5d3e39caa456b1e061644b739131f2b54c84c08 Author: Tvrtko Ursulin Date: Wed May 22 10:00:54 2019 +0100 drm/i915: Engine discovery query Signed-off-by: Tvrtko Ursulin --- include/drm-uapi/i915_drm.h | 42 + 1 file cha

[Intel-gfx] [CI i-g-t 07/14] test/i915: gem_busy: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Reviewed-by: Tvrtko Ursulin --- tests/i915/gem_busy.c | 128 -- 1 file changed, 48 ins

[Intel-gfx] [CI i-g-t 11/14] test/i915: gem_exec_parallel: use the gem_engine_topology library

2019-05-22 Thread Tvrtko Ursulin
From: Andi Shyti Replace the legacy for_each_engine* defines with the ones implemented in the gem_engine_topology library. Signed-off-by: Andi Shyti Cc: Chris Wilson Reviewed-by: Chris Wilson --- tests/i915/gem_exec_parallel.c | 26 ++ 1 file changed, 14 insertions(+)

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] drm-uapi: Import i915_drm.h upto c5d3e39caa456b1e061644b739131f2b54c84c08

2019-05-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 14:32:39) > From: Tvrtko Ursulin > > commit c5d3e39caa456b1e061644b739131f2b54c84c08 > Author: Tvrtko Ursulin > Date: Wed May 22 10:00:54 2019 +0100 > > drm/i915: Engine discovery query > > Signed-off-by: Tvrtko Ursulin Acked-by: Chris Wilson

  1   2   3   >