[Intel-gfx] ✓ Fi.CI.BAT: success for CI: Revert "net/sch_generic: Shut up noise"

2019-05-16 Thread Patchwork
== Series Details == Series: CI: Revert "net/sch_generic: Shut up noise" URL : https://patchwork.freedesktop.org/series/60699/ State : success == Summary == CI Bug Log - changes from CI_DRM_6089 -> Patchwork_13024 Summary --- **SUCCE

Re: [Intel-gfx] [v10 01/12] drm: Add HDR source metadata property

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, May 16, 2019 12:40 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; Sharma, Shashank >; emil.l.veli...@gmail.com

Re: [Intel-gfx] [v10 04/12] drm: Enable HDR infoframe support

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, May 16, 2019 12:45 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; Sharma, Shashank >; emil.l.veli...@gmail.com

Re: [Intel-gfx] [v10 12/12] drm/i915: Add state readout for DRM infoframe

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, May 16, 2019 1:00 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; Sharma, Shashank >; emil.l.veli...@gmail.com;

Re: [Intel-gfx] [v10 03/12] drm: Parse HDR metadata info from EDID

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, May 16, 2019 1:06 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >maarten.lankho...@linux.intel.com; Sharma, Shashank >; emil.l.veli...@gmail.com;

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Thursday, May 16, 2019 1:02 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and >handling >in DRM layer (rev10) >

[Intel-gfx] ✓ Fi.CI.IGT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures

2019-05-16 Thread Patchwork
== Series Details == Series: Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures URL : https://patchwork.freedesktop.org/series/60697/ State : success == Summary == CI Bug Log - changes from CI_DRM_6089_full -> Patchwork_13023_full Sum

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-16 Thread Pekka Paalanen
On Wed, 15 May 2019 10:24:49 +0200 Daniel Vetter wrote: > On Wed, May 15, 2019 at 10:37:31AM +0300, Pekka Paalanen wrote: > > On Tue, 14 May 2019 16:34:01 +0200 > > Daniel Vetter wrote: > > > > > On Tue, May 14, 2019 at 3:36 PM Pekka Paalanen > > > wrote: > > > > > > > > On Tue, 14 May 20

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Jani Nikula
On Wed, 15 May 2019, Harish Chegondi wrote: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > Cc: Jani Nikula > Cc: Tomi Sarvela > Cc

Re: [Intel-gfx] [PATCH i-g-t 05/16] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-16 Thread Tvrtko Ursulin
On 15/05/2019 20:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-14 11:15:12) On 08/05/2019 11:09, Chris Wilson wrote: Check that the extended create interface accepts setparam. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_create.c | 225 ++--

[Intel-gfx] ✓ Fi.CI.IGT: success for CI: Revert "net/sch_generic: Shut up noise"

2019-05-16 Thread Patchwork
== Series Details == Series: CI: Revert "net/sch_generic: Shut up noise" URL : https://patchwork.freedesktop.org/series/60699/ State : success == Summary == CI Bug Log - changes from CI_DRM_6089_full -> Patchwork_13024_full Summary ---

Re: [Intel-gfx] [PATCH i-g-t 08/16] i915: Exercise creating context with shared GTT

2019-05-16 Thread Tvrtko Ursulin
On 15/05/2019 20:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-15 07:37:18) On 08/05/2019 11:09, Chris Wilson wrote: v2: Test each shared context is its own timeline and allows request reordering between shared contexts. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko

Re: [Intel-gfx] [PATCH i-g-t 10/16] i915/gem_exec_whisper: Fork all-engine tests one-per-engine

2019-05-16 Thread Tvrtko Ursulin
On 15/05/2019 20:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-14 13:57:26) On 08/05/2019 11:09, Chris Wilson wrote: Add a new mode for some more stress, submit the all-engines tests simultaneously, a stream per engine. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_whispe

Re: [Intel-gfx] [PATCH i-g-t 13/16] i915: Add gem_exec_balancer

2019-05-16 Thread Tvrtko Ursulin
On 15/05/2019 20:50, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-15 11:49:45) On 08/05/2019 11:09, Chris Wilson wrote: Exercise the in-kernel load balancer checking that we can distribute batches across the set of ctx->engines to avoid load. Signed-off-by: Chris Wilson --- tests/

Re: [Intel-gfx] [PATCH i-g-t 14/16] i915/gem_exec_balancer: Exercise bonded pairs

2019-05-16 Thread Tvrtko Ursulin
On 15/05/2019 21:32, Chris Wilson wrote: Quoting Chris Wilson (2019-05-15 20:57:18) Quoting Tvrtko Ursulin (2019-05-15 11:58:20) On 08/05/2019 11:09, Chris Wilson wrote: + igt_assert_f(load > 0.90, + "engine %d (class:instance %d:%d) was f

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-16 Thread Lionel Landwerlin
Hi Umesh, This v3 looks good to me. I've left some nits below, but with or with them applied this is : Reviewed-by: Lionel Landwerlin On 15/05/2019 19:07, Umesh Nerlige Ramappa wrote: The oa object manages the oa buffer and must be allocated when the user intends to read performance counter

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-16 Thread Jani Nikula
On Tue, 14 May 2019, Rodrigo Vivi wrote: > One possibility that just came to my mind now is, what if we make > this only for platforms that are still protected by is_alpha_support=1 > (soon becoming require_force_probe=1) Please don't conflate alpha_support or force_probe with *anything* else. >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Disable active links before rebooting

2019-05-16 Thread Jani Nikula
On Wed, 15 May 2019, Chris Wilson wrote: > Certain monitors, e.g. Dell, do not like it when we reboot with an > active link, leaving them in a confused state where they refuse to > renegotiate the link after the reboot. If we hook into the reboot > notifier, we can switch off any active link befor

Re: [Intel-gfx] [v10 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-05-16 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville >Syrjälä >Sent: Thursday, May 16, 2019 12:57 AM >To: Shankar, Uma >Cc: dcasta...@chromium.org; jo...@kwiboo.se; intel-gfx@lists.freedesktop.org; >emil.l.veli...@gmail.com; dri-de...

Re: [Intel-gfx] [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-16 Thread Laurent Pinchart
Hi Sean, On Mon, May 13, 2019 at 10:38:58AM -0400, Sean Paul wrote: > On Sat, May 11, 2019 at 3:12 PM Laurent Pinchart wrote: > > On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote: > >> From: Sean Paul > >> > >> Everyone who implements connector_helper_funcs->atomic_check reaches > >> int

Re: [Intel-gfx] [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-16 Thread Laurent Pinchart
Hi Daniel, On Mon, May 13, 2019 at 04:47:47PM +0200, Daniel Vetter wrote: > On Sat, May 11, 2019 at 10:12:02PM +0300, Laurent Pinchart wrote: > > On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote: > >> From: Sean Paul > >> > >> Everyone who implements connector_helper_funcs->atomic_check

Re: [Intel-gfx] [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-16 Thread Daniel Vetter
On Thu, May 16, 2019 at 2:02 PM Laurent Pinchart wrote: > > Hi Daniel, > > On Mon, May 13, 2019 at 04:47:47PM +0200, Daniel Vetter wrote: > > On Sat, May 11, 2019 at 10:12:02PM +0300, Laurent Pinchart wrote: > > > On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote: > > >> From: Sean Paul >

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-16 Thread Daniel Vetter
On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote: > On Wed, 15 May 2019 10:24:49 +0200 > Daniel Vetter wrote: > > > On Wed, May 15, 2019 at 10:37:31AM +0300, Pekka Paalanen wrote: > > > On Tue, 14 May 2019 16:34:01 +0200 > > > Daniel Vetter wrote: > > > > > > > On Tue, May 14, 2

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Maarten Lankhorst
Op 16-05-2019 om 07:58 schreef Harish Chegondi: > display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which > is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs. > > Cc: Jani Nikula > Cc: Tomi Sarvela >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Jani Nikula
On Thu, 16 May 2019, Maarten Lankhorst wrote: > Op 16-05-2019 om 07:58 schreef Harish Chegondi: >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the >> second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which >> is a GEN7 GPU. So, skip the second CRC even for

Re: [Intel-gfx] [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-16 Thread Sam Ravnborg
Hi Noralf. See few comments in the following. Sam On Mon, May 06, 2019 at 08:01:36PM +0200, Noralf Trønnes wrote: > All drivers add all their connectors so there's no need to keep around an > array of available connectors. > > Rename functions which signature is changed since they will

Re: [Intel-gfx] [v10 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-05-16 Thread Ville Syrjälä
On Thu, May 16, 2019 at 10:54:14AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > >Of Ville > >Syrjälä > >Sent: Thursday, May 16, 2019 12:57 AM > >To: Shankar, Uma > >Cc: dcasta...@chromium.org; jo...@

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-16 Thread Ville Syrjälä
On Thu, May 16, 2019 at 07:28:43AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Thursday, May 16, 2019 1:02 AM > >To: Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org > >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-16 Thread Shankar, Uma
>> >> >-Original Message- >> >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >> >Sent: Thursday, May 16, 2019 1:02 AM >> >To: Shankar, Uma >> >Cc: intel-gfx@lists.freedesktop.org >> >Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata >> >Parsing and handling i

Re: [Intel-gfx] [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-16 Thread Ville Syrjälä
On Thu, May 16, 2019 at 02:07:34PM +0200, Daniel Vetter wrote: > On Thu, May 16, 2019 at 2:02 PM Laurent Pinchart > wrote: > > > > Hi Daniel, > > > > On Mon, May 13, 2019 at 04:47:47PM +0200, Daniel Vetter wrote: > > > On Sat, May 11, 2019 at 10:12:02PM +0300, Laurent Pinchart wrote: > > > > On Th

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Ville Syrjälä
On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: > On Thu, 16 May 2019, Maarten Lankhorst > wrote: > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the > >> second CRC for GEN8+ GPUs. The second CRC is invalid

[Intel-gfx] [v11 06/12] drm/i915: Write HDR infoframe and send to panel

2019-05-16 Thread Uma Shankar
Enable writing of HDR metadata infoframe to panel. The data will be provid by usersapace compositors, based on blending policies and passsed to driver through a blob property. v2: Rebase v3: Fixed a warning message v4: Addressed Shashank's review comments v5: Rebase. Added infoframe calculation

[Intel-gfx] [v11 01/12] drm: Add HDR source metadata property

2019-05-16 Thread Uma Shankar
This patch adds a blob property to get HDR metadata information from userspace. This will be send as part of AVI Infoframe to panel. It also implements get() and set() functions for HDR output metadata property.The blob data is received from userspace and saved in connector state, the same is retu

[Intel-gfx] [v11 04/12] drm: Enable HDR infoframe support

2019-05-16 Thread Uma Shankar
Enable Dynamic Range and Mastering Infoframe for HDR content, which is defined in CEA 861.3 spec. The metadata will be computed based on blending policy in userspace compositors and passed as a connector property blob to driver. The same will be sent as infoframe to panel which support HDR. Added

[Intel-gfx] [v11 11/12] video/hdmi: Add Unpack function for DRM infoframe

2019-05-16 Thread Uma Shankar
Added unpack function for DRM infoframe for dynamic range and mastering infoframe readout. v2: Addressed Ville's review comments. Suggested-by: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/video/hdmi.c | 67 1 file changed, 67 insert

[Intel-gfx] [v11 02/12] drm: Add reference counting on HDR metadata blob

2019-05-16 Thread Uma Shankar
From: Jonas Karlman This adds reference count for HDR metadata blob, handled as part of duplicate and destroy connector state functions. v2: Removed the hdr_metadata_changed initialization as the variable is dropped and not required. Signed-off-by: Jonas Karlman Signed-off-by: Uma Shankar ---

[Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-16 Thread Uma Shankar
This patch series enables HDR support in drm. It basically defines HDR metadata structures, property to pass content (after blending) metadata from user space compositors to driver. Dynamic Range and Mastering infoframe creation and sending. ToDo: 1. We need to get the color framework in place fo

[Intel-gfx] [v11 03/12] drm: Parse HDR metadata info from EDID

2019-05-16 Thread Uma Shankar
HDR metadata block is introduced in CEA-861.3 spec. Parsing the same to get the panel's HDR metadata. v2: Rebase and added Ville's POC changes to the patch. v3: No Change v4: Addressed Shashank's review comments v5: Addressed Shashank's comment and added his RB. v6: Addressed Jonas Karlman rev

[Intel-gfx] [v11 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT

2019-05-16 Thread Uma Shankar
BYT/CHT doesn't support DRM Infoframe. This caused a WARN_ON due to a missing CASE while executing intel_hdmi_infoframes_enabled function. This patch fixes the same. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [v11 08/12] drm/i915: Enable infoframes on GLK+ for HDR

2019-05-16 Thread Uma Shankar
From: Ville Syrjälä This patch enables infoframes on GLK+ to be used to send HDR metadata to HDMI sink. v2: Addressed Shashank's review comment. v3: Addressed Shashank's review comment. v4: Added Shashank's RB. v5: Dropped hdr_metadata_change check while modeset, as per Ville's suggestion. S

[Intel-gfx] [v11 12/12] drm/i915: Add state readout for DRM infoframe

2019-05-16 Thread Uma Shankar
Added state readout for DRM infoframe and enabled state validation for DRM infoframe. v2: Addressed Ville's review comments and dropped the unused drm infoframe read at intel_hdmi_init. v3: Removed a redundant platform check as per Ville's comment. Signed-off-by: Uma Shankar --- drivers/gpu/dr

[Intel-gfx] [v11 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-05-16 Thread Uma Shankar
This patch enables modeset whenever HDR metadata needs to be updated to sink. v2: Addressed Shashank's review comments. v3: Added Shashank's RB. v4: Addressed Ville's review comments. v5: Addressed Ville's review comments. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by:

[Intel-gfx] [v11 05/12] drm/i915: Attach HDR metadata property to connector

2019-05-16 Thread Uma Shankar
Attach HDR metadata property to connector object. v2: Rebase v3: Updated the property name as per updated name while creating hdr metadata property Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [v11 07/12] drm: Add HLG EOTF

2019-05-16 Thread Uma Shankar
From: Ville Syrjälä ADD HLG EOTF to the list of EOTF transfer functions supported. Hybrid Log-Gamma (HLG) is a high dynamic range (HDR) standard. HLG defines a nonlinear transfer function in which the lower half of the signal values use a gamma curve and the upper half of the signal values use a

Re: [Intel-gfx] [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-16 Thread Noralf Trønnes
Den 16.05.2019 15.07, skrev Sam Ravnborg: > Hi Noralf. > > See few comments in the following. > > Sam > > On Mon, May 06, 2019 at 08:01:36PM +0200, Noralf Trønnes wrote: >> All drivers add all their connectors so there's no need to keep around an >> array of available connectors. I coul

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-16 Thread Martin Peres
On 16/05/2019 16:18, Shankar, Uma wrote: > > >>> -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Thursday, May 16, 2019 1:02 AM To: Shankar, Uma Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: fai

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-16 Thread Summers, Stuart
On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote: > On Tue, 14 May 2019, Rodrigo Vivi wrote: > > One possibility that just came to my mind now is, what if we make > > this only for platforms that are still protected by > > is_alpha_support=1 > > (soon becoming require_force_probe=1) > > Pleas

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev11)

2019-05-16 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev11) URL : https://patchwork.freedesktop.org/series/25091/ State : warning == Summary == $ dim checkpatch origin/drm-tip c372f3162e09 drm: Add HDR source metadata property -:62: CHECK:PARENTHESIS_ALIGNMENT: Alig

Re: [Intel-gfx] [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-16 Thread Sean Paul
On Thu, May 16, 2019 at 03:00:01PM +0300, Laurent Pinchart wrote: > Hi Sean, > > On Mon, May 13, 2019 at 10:38:58AM -0400, Sean Paul wrote: > > On Sat, May 11, 2019 at 3:12 PM Laurent Pinchart wrote: > > > On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote: > > >> From: Sean Paul > > >> >

[Intel-gfx] ✓ Fi.CI.BAT: success for Add HDR Metadata Parsing and handling in DRM layer (rev11)

2019-05-16 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev11) URL : https://patchwork.freedesktop.org/series/25091/ State : success == Summary == CI Bug Log - changes from CI_DRM_6090 -> Patchwork_13025 Summary ---

Re: [Intel-gfx] [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-16 Thread Sam Ravnborg
Hi Noralf. On Thu, May 16, 2019 at 03:53:07PM +0200, Noralf Trønnes wrote: > > > Den 16.05.2019 15.07, skrev Sam Ravnborg: > > Hi Noralf. > > > > See few comments in the following. > > > > Sam > > > > On Mon, May 06, 2019 at 08:01:36PM +0200, Noralf Trønnes wrote: > >> All drivers add all

Re: [Intel-gfx] [PATCH v5 10/11] drm/fb-helper: Move out modeset config code

2019-05-16 Thread Sam Ravnborg
Hi Noralf. After clarifying patch 8 this looks good (moved code touched n patch 8). So I consider this: Reviewed-by: Sam Ravnborg ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-16 Thread Jani Nikula
On Thu, 16 May 2019, "Summers, Stuart" wrote: > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote: >> On Tue, 14 May 2019, Rodrigo Vivi wrote: >> > One possibility that just came to my mind now is, what if we make >> > this only for platforms that are still protected by >> > is_alpha_support=1

Re: [Intel-gfx] [PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-05-16 Thread Sam Ravnborg
Hi Noralf. > > drm/fb-helper: Remove drm_fb_helper_crtc > > drm/fb-helper: Prepare to move out commit code > > drm/fb-helper: Move out commit code > > drm/fb-helper: Remove drm_fb_helper_connector > > Patches 5-8 are still in need of review... With the improved changelogs the remaining pa

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Jani Nikula
On Thu, 16 May 2019, Ville Syrjälä wrote: > On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: >> On Thu, 16 May 2019, Maarten Lankhorst >> wrote: >> > Op 16-05-2019 om 07:58 schreef Harish Chegondi: >> >> display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the >> >> se

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-16 Thread Summers, Stuart
On Thu, 2019-05-16 at 18:42 +0300, Jani Nikula wrote: > On Thu, 16 May 2019, "Summers, Stuart" > wrote: > > On Thu, 2019-05-16 at 12:59 +0300, Jani Nikula wrote: > > > On Tue, 14 May 2019, Rodrigo Vivi wrote: > > > > One possibility that just came to my mind now is, what if we > > > > make > > >

Re: [Intel-gfx] [PATCH v4 8/8] drm/i915: Bump gen7+ fb size limits to 16kx16k

2019-05-16 Thread Maarten Lankhorst
Op 09-05-2019 om 14:21 schreef Ville Syrjala: > From: Ville Syrjälä > > With gtt remapping in place we can use arbitrarily large > framebuffers. Let's bump the limits to 16kx16k on gen7+. > The limit was chosen to match the maximum 2D surface size > of the 3D engine. > > With the remapping we coul

[Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

2019-05-16 Thread Anshuman Gupta
This reverts commit 99b69db57544ec7ed427607f1a2a1858a7d43b61 Core-for-CI:ICL_only Disable ACPI idle driver. This hack has been provided considering the Bug assessment that ACPI idle driver page fault causes below bug. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840 But this bug is still r

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "ICL HACK: Disable ACPI idle driver"

2019-05-16 Thread Patchwork
== Series Details == Series: Revert "ICL HACK: Disable ACPI idle driver" URL : https://patchwork.freedesktop.org/series/60731/ State : success == Summary == CI Bug Log - changes from CI_DRM_6091 -> Patchwork_13026 Summary --- **SUCCE

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Randomise random seed

2019-05-16 Thread Chris Wilson
To avoid hitting the same rut on each benchmark run, start with a new random seed. To allow hitting the same rut again, let it be specified by the user. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --gi

[Intel-gfx] ✓ Fi.CI.IGT: success for Add HDR Metadata Parsing and handling in DRM layer (rev11)

2019-05-16 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev11) URL : https://patchwork.freedesktop.org/series/25091/ State : success == Summary == CI Bug Log - changes from CI_DRM_6090_full -> Patchwork_13025_full S

Re: [Intel-gfx] [PATCH xf86-video-intel v2 1/2] sna: Refactor property parsing

2019-05-16 Thread Mario Kleiner
On Fri, Apr 26, 2019 at 6:32 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Generalize the code that parses the plane properties to be useable > for crtc (or any kms object) properties as well. > > v2: plane 'type' prop is enum not range! > > Cc: Mario Kleiner > Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Measure nop latency on all engines

2019-05-16 Thread Chris Wilson
Different engines take different number of cycles for MI_NOOP. As we specify workloads in us, we need to take into account the different calibration values so that the workloads behave as expected. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 72 +++

[Intel-gfx] [RFC 1/3] kbuild: add support for ensuring headers are self-contained

2019-05-16 Thread Jani Nikula
Sometimes it's useful to be able to explicitly ensure certain headers remain self-contained, i.e. that they are compilable as standalone units, by including and/or forward declaring everything they depend on. Add special target header-test-y where individual Makefiles can add headers to be tested

Re: [Intel-gfx] [PATCH xf86-video-intel v2 2/2] sna: Support 10bpc gamma via the GAMMA_LUT crtc property

2019-05-16 Thread Mario Kleiner
On Fri, Apr 26, 2019 at 6:32 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Probe the GAMMA_LUT/GAMMA_LUT_SIZE props and utilize them when > the running with > 8bpc. > > v2: s/sna_crtc_id/__sna_crtc_id/ in DBG since we have a sna_crtc > > Cc: Mario Kleiner > Signed-off-by: Ville Syrjälä >

[Intel-gfx] [RFC 3/3] DO NOT MERGE: drm/i915: add failing header to header-test-y

2019-05-16 Thread Jani Nikula
Demonstrate build failure on a header that is not self-contained. Cc: Chris Wilson Cc: Masahiro Yamada Cc: Michal Marek Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefil

[Intel-gfx] ✗ Fi.CI.BAT: failure for benchmarks/gem_wsim: Measure nop latency on all engines

2019-05-16 Thread Patchwork
== Series Details == Series: benchmarks/gem_wsim: Measure nop latency on all engines URL : https://patchwork.freedesktop.org/series/60737/ State : failure == Summary == Applying: benchmarks/gem_wsim: Measure nop latency on all engines Patch failed at 0001 benchmarks/gem_wsim: Measure nop laten

[Intel-gfx] [RFC 2/3] drm/i915: ensure headers remain self-contained

2019-05-16 Thread Jani Nikula
Use the new header test facility. Cc: Chris Wilson Cc: Masahiro Yamada Cc: Michal Marek Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 1787e1299b1b..05d01a3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained

2019-05-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained URL : https://patchwork.freedesktop.org/series/60738/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: kbuild: add support for ensuri

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained

2019-05-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained URL : https://patchwork.freedesktop.org/series/60738/ State : success == Summary == CI Bug Log - changes from CI_DRM_6091 -> Patchwork_13027

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Chegondi, Harish
On Thu, 2019-05-16 at 15:55 +0300, Jani Nikula wrote: > On Thu, 16 May 2019, Maarten Lankhorst < > maarten.lankho...@linux.intel.com> wrote: > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > > > display_pipe_crc_irq_handler() skips the first CRC for all GPUs > > > and the > > > second CRC for G

Re: [Intel-gfx] [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs

2019-05-16 Thread Chegondi, Harish
On Thu, 2019-05-16 at 16:30 +0300, Ville Syrjälä wrote: > On Thu, May 16, 2019 at 03:55:25PM +0300, Jani Nikula wrote: > > On Thu, 16 May 2019, Maarten Lankhorst < > > maarten.lankho...@linux.intel.com> wrote: > > > Op 16-05-2019 om 07:58 schreef Harish Chegondi: > > > > display_pipe_crc_irq_handle

[Intel-gfx] [RFC 2/7] drm/i915: Remove rpm asserts that use i915

2019-05-16 Thread Daniele Ceraolo Spurio
Quite a few of the call points have already switched to the version working directly on the runtime_pm structure, so let's switch over the rest and kill the i915-based asserts. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gvt/aperture_gm.c| 2 +- drivers/gpu/drm/i915/i915_

[Intel-gfx] [RFC 1/7] drm/i915: prefer i915_runtime_pm in intel_runtime function

2019-05-16 Thread Daniele Ceraolo Spurio
As a first step towards updating the code to work on the runtime_pm structure instead of i915, rework all the internals to use and pass around that. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/intel_drv.h| 10 +- driver

[Intel-gfx] [RFC 3/7] drm/i915: make enable/disable rpm assert function use the rpm structure

2019-05-16 Thread Daniele Ceraolo Spurio
With this all the rpm assert-related functions consistently work on the i915_runtime_pm structure Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_drv.c | 44 +++-- drivers/gpu/drm/i915/i915_irq.c | 32 ++--- drivers/gpu/drm/i915

[Intel-gfx] [RFC 0/7] Runtime PM encapsulation

2019-05-16 Thread Daniele Ceraolo Spurio
While reworking other parts of the code to rely less on i915 and use the new uncore logic for register access, I've noticed that, after the conversion, in a few places the i915 structure is required only for the rpm_get/put calls. We do have a reference to the rpm structure in the uncore one, so, s

[Intel-gfx] [RFC 4/7] drm/i915: move and rename i915_runtime_pm

2019-05-16 Thread Daniele Ceraolo Spurio
Asserts aside, all the code working on this structure is in intel_runtime_pm.c and uses the intel_ prefix, so move the structure to intel_runtime_pm.h and adopt the same prefix. Since all the asserts are now working on the runtime_pm structure, bring them across as well. Signed-off-by: Daniele Ce

[Intel-gfx] [RFC 7/7] drm/i915: update with_intel_runtime_pm to use the rpm structure

2019-05-16 Thread Daniele Ceraolo Spurio
Matching the underlying get/put functions. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_context.c | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- .../gpu/drm/i915/gt/selftest_workarounds.c| 4 ++-- drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [RFC 5/7] drm/i915: move a few more functions to accept the rpm structure

2019-05-16 Thread Daniele Ceraolo Spurio
Focusing on the functions called in few places. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 17 + drivers/gpu/drm/i915/intel_runtime_pm.c | 19 --- drivers/g

[Intel-gfx] [RFC 6/7] drm/i915: update rpm_get/put to use the rpm structure

2019-05-16 Thread Daniele Ceraolo Spurio
The functions are internally already only using the structure, so we need to just flip the interface. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 +-- drivers/gpu/drm/i915/gt/intel_hangcheck.c | 4 +- drivers/gpu/drm/i915/gt/intel_reset.c

Re: [Intel-gfx] [RFC 4/7] drm/i915: move and rename i915_runtime_pm

2019-05-16 Thread Chris Wilson
Quoting Chris Wilson (2019-05-16 23:07:43) > Quoting Daniele Ceraolo Spurio (2019-05-16 22:56:31) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h > > b/drivers/gpu/drm/i915/intel_runtime_pm.h > > index b964ca7af9c8..0e3817f9785e 100644 > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.h > >

Re: [Intel-gfx] [RFC 4/7] drm/i915: move and rename i915_runtime_pm

2019-05-16 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-05-16 22:56:31) > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h > b/drivers/gpu/drm/i915/intel_runtime_pm.h > index b964ca7af9c8..0e3817f9785e 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.h > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h > @@ -6,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Runtime PM encapsulation

2019-05-16 Thread Patchwork
== Series Details == Series: Runtime PM encapsulation URL : https://patchwork.freedesktop.org/series/60751/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6abe6de9d69c drm/i915: prefer i915_runtime_pm in intel_runtime function 459ce16ea796 drm/i915: Remove rpm asserts that use i

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Runtime PM encapsulation

2019-05-16 Thread Patchwork
== Series Details == Series: Runtime PM encapsulation URL : https://patchwork.freedesktop.org/series/60751/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: prefer i915_runtime_pm in intel_runtime function Okay! Commit: drm/i915: Remove rpm as

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-16 Thread Daniele Ceraolo Spurio
--- a/drivers/gpu/drm/i915/gt/intel_sseu.h +++ b/drivers/gpu/drm/i915/gt/intel_sseu.h @@ -9,16 +9,18 @@ #include #include +#include AFAICS this header is not needed anymore. With it removed: Reviewed-by: Daniele Ceraolo Spurio Daniele struct drm_i915_private; #define

Re: [Intel-gfx] [RFC 4/7] drm/i915: move and rename i915_runtime_pm

2019-05-16 Thread Chris Wilson
Quoting Chris Wilson (2019-05-16 23:10:10) > Quoting Chris Wilson (2019-05-16 23:07:43) > > Quoting Daniele Ceraolo Spurio (2019-05-16 22:56:31) > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h > > > b/drivers/gpu/drm/i915/intel_runtime_pm.h > > > index b964ca7af9c8..0e3817f9785e 100644

[Intel-gfx] ✗ Fi.CI.BAT: failure for Runtime PM encapsulation

2019-05-16 Thread Patchwork
== Series Details == Series: Runtime PM encapsulation URL : https://patchwork.freedesktop.org/series/60751/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6091 -> Patchwork_13028 Summary --- **FAILURE** Serious unk

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "ICL HACK: Disable ACPI idle driver"

2019-05-16 Thread Patchwork
== Series Details == Series: Revert "ICL HACK: Disable ACPI idle driver" URL : https://patchwork.freedesktop.org/series/60731/ State : success == Summary == CI Bug Log - changes from CI_DRM_6091_full -> Patchwork_13026_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-05-16 Thread John Harrison
On 5/15/2019 01:52, Tvrtko Ursulin wrote: On 13/05/2019 20:45, john.c.harri...@intel.com wrote: From: John Harrison With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained

2019-05-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/3] kbuild: add support for ensuring headers are self-contained URL : https://patchwork.freedesktop.org/series/60738/ State : success == Summary == CI Bug Log - changes from CI_DRM_6091_full -> Patchwork_13027_full ==

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for CI: Revert "net/sch_generic: Shut up noise"

2019-05-16 Thread Daniel Vetter
On Thu, May 16, 2019 at 08:48:53AM -, Patchwork wrote: > == Series Details == > > Series: CI: Revert "net/sch_generic: Shut up noise" > URL : https://patchwork.freedesktop.org/series/60699/ > State : success Hm no boom at all, I'll try the full revert and see what happens. Maybe we hit a fe

[Intel-gfx] [PATCH] C: Revert "net/sch_generic: Shut up noise"

2019-05-16 Thread Daniel Vetter
This reverts commit a9f840bdd2fd4cb07a669f1c3112b804218b4aba. A quick test patch didn't seem to have hit this, so let's try what happens when we reinstate the full WARNING again. Cc: Martin Peres --- net/sched/sch_generic.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git