Re: [Intel-gfx] [PATCH v5 05/12] drm: revocation check at drm subsystem

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:27:58PM +0530, Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > > SRM table is parsed and stored at drm_hdcp.c, with functions exported > for the services for revocation check from drivers (which

Re: [Intel-gfx] [PATCH v5 06/12] drm/i915: SRM revocation check for HDCP1.4 and 2.2

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:27:59PM +0530, Ramalingam C wrote: > DRM HDCP SRM revocation check services are used from I915 for HDCP1.4 > and 2.2 revocation check during the respective authentication flow. > > v2: > Rebased. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/intel_hdc

Re: [Intel-gfx] [PATCH v5 09/12] drm/hdcp: update content protection property with uevent

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:28:02PM +0530, Ramalingam C wrote: > drm function is defined and exported to update a connector's > content protection property state and to generate a uevent along > with it. > > v2: > Update only when state is different from old one. > > Signed-off-by: Ramalingam C

Re: [Intel-gfx] [PATCH v5 10/12] drm/i915: update the hdcp state with uevent

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:28:03PM +0530, Ramalingam C wrote: > drm function to update the content protection property state and to > generate a uevent is invoked from the intel hdcp property work. > > Hence whenever kernel changes the property state, userspace will be > updated with a uevent. >

Re: [Intel-gfx] [PATCH v5 05/12] drm: revocation check at drm subsystem

2019-04-29 Thread Daniel Vetter
On Mon, Apr 29, 2019 at 09:26:07AM +0200, Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 02:27:58PM +0530, Ramalingam C wrote: > > On every hdcp revocation check request SRM is read from fw file > > /lib/firmware/display_hdcp_srm.bin > > > > SRM table is parsed and stored at drm_hdcp.c, with funct

Re: [Intel-gfx] [PATCH v5 07/12] drm/hdcp: gathering hdcp related code into drm_hdcp.c

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:28:00PM +0530, Ramalingam C wrote: > Considering the significant size of hdcp related code in drm, all > hdcp related codes are moved into separate file called drm_hdcp.c. > > v2: > Rebased. > > Signed-off-by: Ramalingam C > Suggested-by: Daniel Vetter > --- > driv

Re: [Intel-gfx] [PATCH v5 08/12] drm: uevent for connector status change

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:28:01PM +0530, Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > This uevent will have following details related to the status change: > > HOTPLUG=1, CONNECTOR= and PROPERTY= > v2: > Minor fixes at KDoc comments

Re: [Intel-gfx] [PATCH v5 11/12] drm: Add CP downstream_info property

2019-04-29 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:28:04PM +0530, Ramalingam C wrote: > This patch adds a optional CP downstream info blob property to the > connectors. This enables the Userspace to read the information of HDCP > authenticated downstream topology. > > Driver will update this blob with all downstream info

[Intel-gfx] [PATCH 4/4] drm/i915/execlists: Don't apply priority boost for resets

2019-04-29 Thread Chris Wilson
Do not treat reset as a normal preemption event and avoid giving the guilty request a priority boost for simply being active at the time of reset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --gi

[Intel-gfx] [PATCH 3/4] drm/i915: Delay semaphore submission until the start of the signaler

2019-04-29 Thread Chris Wilson
Currently we submit the semaphore busywait as soon as the signaler is submitted to HW. However, we may submit the signaler as the tail of a batch of requests, and even not as the first context in the HW list, i.e. the busywait may start spinning far in advance of the signaler even starting. If we

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for the struct_mutex on idling

2019-04-29 Thread Chris Wilson
When the system is idling, contention for struct_mutex should be low and so we will be more efficient to wait for a contended mutex than reschedule. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_pm.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 2/4] drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-04-29 Thread Chris Wilson
If we couple the scheduler more tightly with the execlists policy, we can apply the preemption policy to the question of whether we need to kick the tasklet at all for this priority bump. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 2 -- drivers/g

Re: [Intel-gfx] [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-29 Thread Jani Nikula
On Thu, 25 Apr 2019, Aditya Swarup wrote: > From: Clinton Taylor > > v2: Fix commit msg to reflect why issue occurs(Jani) > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color. > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa) > doesn't work correctly using xrandr

[Intel-gfx] [PATCH] drm/i915: Skip unused contexts for context_barrier_task()

2019-04-29 Thread Chris Wilson
If the context has not been used yet, it needs no barrier, and in the process fix up the selftest in mock_contexts. Testcase: igt/gem_ctx_clone/vm Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_context.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915

Re: [Intel-gfx] [PATCH 2/3] drm/i915/icl: Add register definitions for Multi Segmented gamma

2019-04-29 Thread Sharma, Shashank
On 4/26/2019 11:46 PM, Ville Syrjälä wrote: On Fri, Apr 26, 2019 at 11:31:50PM +0530, Shashank Sharma wrote: From: Uma Shankar Add macros to define multi segmented gamma registers Cc: Ville Syrjälä Cc: Maarten Lankhorst Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h | 17

Re: [Intel-gfx] [PATCH 24/45] drm/i915: Split GEM object type definition to its own header

2019-04-29 Thread Joonas Lahtinen
Quoting Jani Nikula (2019-04-26 15:12:49) > On Thu, 25 Apr 2019, Chris Wilson wrote: > > For convenience in avoiding inline spaghetti, keep the type definition > > as a separate header. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Matthew Auld > > --- > > drivers/gpu/drm/i915/Makefile

Re: [Intel-gfx] [PATCH] drm/i915: Skip unused contexts for context_barrier_task()

2019-04-29 Thread Tvrtko Ursulin
On 29/04/2019 10:07, Chris Wilson wrote: If the context has not been used yet, it needs no barrier, and in the process fix up the selftest in mock_contexts. Testcase: igt/gem_ctx_clone/vm Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_context.c |

Re: [Intel-gfx] [PATCH v5 4/8] drm/i915: vgpu context submission pv optimization

2019-04-29 Thread Chris Wilson
Quoting Xiaolin Zhang (2019-04-29 04:10:54) > +static void pv_submit(struct intel_engine_cs *engine) > +{ > + struct intel_engine_execlists * const execlists = &engine->execlists; > + struct execlist_port *port = execlists->port; > + unsigned int n; > + struct gvt_shared_pag

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip unused contexts for context_barrier_task()

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Skip unused contexts for context_barrier_task() URL : https://patchwork.freedesktop.org/series/60037/ State : success == Summary == CI Bug Log - changes from CI_DRM_6011 -> Patchwork_12890 Summary

Re: [Intel-gfx] [PATCH 3/3] drm/i915/icl: Add Multi-segmented gamma support

2019-04-29 Thread Sharma, Shashank
On 4/26/2019 11:59 PM, Ville Syrjälä wrote: On Fri, Apr 26, 2019 at 11:31:51PM +0530, Shashank Sharma wrote: ICL introduces a new gamma correction mode in display engine, called multi-segmented-gamma mode. This mode allows users to program the darker region of the gamma curve with sueprfine pre

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Wait for the struct_mutex on idling

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Wait for the struct_mutex on idling URL : https://patchwork.freedesktop.org/series/60048/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Wait for the struct_mutex on idling Oka

Re: [Intel-gfx] [PATCH 3/3] drm/i915/icl: Add Multi-segmented gamma support

2019-04-29 Thread Ville Syrjälä
On Mon, Apr 29, 2019 at 05:00:21PM +0530, Sharma, Shashank wrote: > > On 4/26/2019 11:59 PM, Ville Syrjälä wrote: > > On Fri, Apr 26, 2019 at 11:31:51PM +0530, Shashank Sharma wrote: > >> ICL introduces a new gamma correction mode in display engine, called > >> multi-segmented-gamma mode. This mod

Re: [Intel-gfx] [PATCH] drm/i915: Fix ICL output CSC programming

2019-04-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjala [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, April 26, 2019 12:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: Shankar, Uma >Subject: [PATCH] drm/i915: Fix ICL output CSC programming > >From: Ville Syrjälä > >When I refactored the code i

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Wait for the struct_mutex on idling

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Wait for the struct_mutex on idling URL : https://patchwork.freedesktop.org/series/60048/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12891 ===

[Intel-gfx] [PATCH 01/21] drm/i915: ensure more headers remain self-contained

2019-04-29 Thread Jani Nikula
Add more headers to the header test list: * i915_drv.h * i915_params.h * i915_reg.h * intel_drv.h * intel_uncore.h Happily they already are self-contained, but keep them that way. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 5 + 1 file changed, 5 insertions(+

[Intel-gfx] [PATCH 05/21] drm/i915: move dsi init functions to intel_dsi.h

2019-04-29 Thread Jani Nikula
Keep the header self-contained. It'll need rework of its own in the future, but gotta start somewhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_drv.h | 5 - drivers/gpu/drm/i915/intel_dsi.h | 4 3 files

[Intel-gfx] [PATCH 03/21] drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make self-contained

2019-04-29 Thread Jani Nikula
Put the header more in line with the rest. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/dvo_ch7017.c | 3 ++- drivers/gpu/drm/i915/dvo_ch7xxx.c | 3 ++- drivers/gpu/drm/i915/dvo_iv

[Intel-gfx] [PATCH 04/21] drm/i915: make intel_dpll_mgr.h self-contained

2019-04-29 Thread Jani Nikula
And ensure it stays that way. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/intel_dpll_mgr.h | 8 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 07/21] drm/i915: extract intel_dp_link_training.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 06/21] drm/i915: extract intel_fifo_underrun.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 14/21] drm/i915: extract intel_vdsc.h from intel_drv.h and i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 11/21] drm/i915: extract intel_bios.h functions from i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the header remains self-contained, and do so with minim

[Intel-gfx] [PATCH 09/21] drm/i915: extract i915_irq.h from intel_drv.h and i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 15/21] drm/i915: extract intel_dp_mst.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 16/21] drm/i915: extract intel_dsi_dcs_backlight.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 17/21] drm/i915: extract intel_atomic.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 18/21] drm/i915: extract intel_runtime_pm.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 21/21] drm/i915: add single combo phy init/unit functions

2019-04-29 Thread Jani Nikula
Work on the principle that files should prefer not to expose platform specific functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_combo_phy.c | 24 drivers/gpu/drm/i915/intel_combo_phy.h | 6 ++ drivers/gpu/drm/i915/intel_runtime_pm.c | 10 +-

[Intel-gfx] [PATCH 20/21] drm/i915: extract intel_combo_phy.h from i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time i915_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minima

[Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

2019-04-29 Thread Jani Nikula
Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") missed the declarations in i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 13 - drivers/gpu/drm/i915/i915_pmu.c | 3 ++- drivers/gpu/drm/i915/i915_sysfs.c | 3 ++- drivers/gpu/dr

[Intel-gfx] [PATCH 02/21] drm/i915: make intel_bios.h self-contained

2019-04-29 Thread Jani Nikula
Just a types include required. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_bios.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test i

[Intel-gfx] [PATCH 10/21] drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 12/21] drm/i915: extract intel_quirks.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 08/21] drm/i915: extract intel_dp_aux_backlight.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] [PATCH 00/21] drm/i915: the great header refactoring, part two

2019-04-29 Thread Jani Nikula
Continue the header refactoring started in part one [1]. BR, Jani. [1] https://patchwork.freedesktop.org/series/59022/ Jani Nikula (21): drm/i915: ensure more headers remain self-contained drm/i915: make intel_bios.h self-contained drm/i915/dvo: rename dvo.h to intel_dvo_dev.h and make se

[Intel-gfx] [PATCH 13/21] drm/i915: extract intel_overlay.h from intel_drv.h and i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 vgpu PV to improve vgpu performance

2019-04-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/60055/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9d42b5a1769 drm/i915: introduced vgpu pv capability -:89: CHECK:PARENTHESIS_ALIGNMENT: Alignment should mat

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915 vgpu PV to improve vgpu performance

2019-04-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/60055/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: introduced vgpu pv capability -drivers/gpu/drm/i915/selftests/../i915_d

[Intel-gfx] [PATCH v2] drm/i915: extract intel_atomic.h from intel_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

Re: [Intel-gfx] [PATCH 3/3] drm/i915/icl: Add Multi-segmented gamma support

2019-04-29 Thread Sharma, Shashank
On 4/29/2019 5:19 PM, Ville Syrjälä wrote: On Mon, Apr 29, 2019 at 05:00:21PM +0530, Sharma, Shashank wrote: On 4/26/2019 11:59 PM, Ville Syrjälä wrote: On Fri, Apr 26, 2019 at 11:31:51PM +0530, Shashank Sharma wrote: ICL introduces a new gamma correction mode in display engine, called multi-

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev2) URL : https://patchwork.freedesktop.org/series/60060/ State : warning == Summary == $ dim checkpatch origin/drm-tip 486873c042de drm/i915: ensure more headers remain self-contained 9067550af88f drm/i915: make

Re: [Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

2019-04-29 Thread Chris Wilson
Quoting Jani Nikula (2019-04-29 13:29:37) > Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") > missed the declarations in i915_drv.h. Fwiw, I want to pull these along with gt powermanagement and rps into gt/intel_gt_pm.c and a few friends. Doesn't make much difference for thi

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 vgpu PV to improve vgpu performance

2019-04-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/60055/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12892 Summary --- **SUCCESS*

[Intel-gfx] [PATCH v2] drm/i915: extract intel_hotplug.h from intel_drv.h and i915_drv.h

2019-04-29 Thread Jani Nikula
It used to be handy that we only had a couple of headers, but over time intel_drv.h has become unwieldy. Extract declarations to a separate header file corresponding to the implementation module, clarifying the modularity of the driver. Ensure the new header is self-contained, and do so with minim

Re: [Intel-gfx] [PATCH 19/21] drm/i915: move some leftovers to intel_pm.h from i915_drv.h

2019-04-29 Thread Jani Nikula
On Mon, 29 Apr 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-04-29 13:29:37) >> Commit 696173b064c6 ("drm/i915: extract intel_pm.h from intel_drv.h") >> missed the declarations in i915_drv.h. > > Fwiw, I want to pull these along with gt powermanagement and rps into > gt/intel_gt_pm.c and a

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: the great header refactoring, part two (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev2) URL : https://patchwork.freedesktop.org/series/60060/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: ensure more headers remain self-contained - +./include/u

[Intel-gfx] [PATCH] drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-04-29 Thread Chris Wilson
If we couple the scheduler more tightly with the execlists policy, we can apply the preemption policy to the question of whether we need to kick the tasklet at all for this priority bump. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + drive

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Skip unused contexts for context_barrier_task()

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Skip unused contexts for context_barrier_task() URL : https://patchwork.freedesktop.org/series/60037/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6011_full -> Patchwork_12890_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: the great header refactoring, part two (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev2) URL : https://patchwork.freedesktop.org/series/60060/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12893 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: the great header refactoring, part two (rev3)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev3) URL : https://patchwork.freedesktop.org/series/60060/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2505cc046d89 drm/i915: ensure more headers remain self-contained 2519e59bfa55 drm/i915: make

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: the great header refactoring, part two (rev3)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev3) URL : https://patchwork.freedesktop.org/series/60060/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: ensure more headers remain self-contained - +./include/u

Re: [Intel-gfx] [PATCH 19/45] drm/i915: Load balancing across a virtual engine

2019-04-29 Thread Tvrtko Ursulin
On 25/04/2019 10:19, Chris Wilson wrote: Having allowed the user to define a set of engines that they will want to only use, we go one step further and allow them to bind those engines into a single virtual instance. Submitting a batch to the virtual engine will then forward it to any one of the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: the great header refactoring, part two (rev3)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev3) URL : https://patchwork.freedesktop.org/series/60060/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12894 Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2) URL : https://patchwork.freedesktop.org/series/60048/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Wait for the struct_mutex on id

Re: [Intel-gfx] [PATCH 2/3] drm/i915/icl: Add register definitions for Multi Segmented gamma

2019-04-29 Thread Jani Nikula
On Fri, 26 Apr 2019, Shashank Sharma wrote: > From: Uma Shankar > > Add macros to define multi segmented gamma registers > > Cc: Ville Syrjälä > Cc: Maarten Lankhorst > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/i915_reg.h | 17 + > 1 file changed, 17 insertions(+

Re: [Intel-gfx] [PATCH 20/45] drm/i915: Apply an execution_mask to the virtual_engine

2019-04-29 Thread Tvrtko Ursulin
On 25/04/2019 10:19, Chris Wilson wrote: Allow the user to direct which physical engines of the virtual engine they wish to execute one, as sometimes it is necessary to override the load balancing algorithm. v2: Only kick the virtual engines on context-out if required Signed-off-by: Chris Wils

[Intel-gfx] [PATCH] drm/i915/csr: alpha_support doesn't depend on csr or vice versa

2019-04-29 Thread Jani Nikula
Debug logging should not be dependent on alpha support flag. Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_csr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index f43c2a2563a5..4527b9662330

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2) URL : https://patchwork.freedesktop.org/series/60048/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12895 ===

Re: [Intel-gfx] [PATCH v5 11/12] drm: Add CP downstream_info property

2019-04-29 Thread Ramalingam C
On 2019-04-29 at 09:38:32 +0200, Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 02:28:04PM +0530, Ramalingam C wrote: > > This patch adds a optional CP downstream info blob property to the > > connectors. This enables the Userspace to read the information of HDCP > > authenticated downstream topolo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/csr: alpha_support doesn't depend on csr or vice versa

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915/csr: alpha_support doesn't depend on csr or vice versa URL : https://patchwork.freedesktop.org/series/60062/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12896 Summar

[Intel-gfx] [PATCH] drm/i915: Fix bug for GeminiLake

2019-04-29 Thread Stanislav Lisovskiy
When CDCLK is as low as 79200, picture gets unstable, while DSI and DE pll values were confirmed to be correct. Limiting to 158400 as agreed with Ville. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_cdclk.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix bug for GeminiLake

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Fix bug for GeminiLake -O:drivers/gpu/drm/i915/intel_cdclk.c:2266:29: warning:

[Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-04-29 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice i

[Intel-gfx] [PATCH 2/5] drm/i915: Add macro for SSEU stride calculation

2019-04-29 Thread Stuart Summers
Subslice stride and EU stride are calculated multiple times in i915_query. Move this calculation to a macro to reduce code duplication. v2: update headers in intel_sseu.h Cc: Daniele Ceraolo Spurio Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.h | 2 ++ drivers/gpu/drm/

[Intel-gfx] [PATCH 3/5] drm/i915: Move calculation of subslices per slice to new function

2019-04-29 Thread Stuart Summers
Add a new function to return the number of subslices per slice to consolidate code usage. v2: rebase on changes to move sseu struct to intel_sseu.h Cc: Daniele Ceraolo Spurio Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.h | 6 ++ drivers/gpu/drm/i915/i915_debugf

[Intel-gfx] [PATCH 0/5] Refactor to expand subslice mask

2019-04-29 Thread Stuart Summers
This patch series contains a few code clean-up patches, followed by a patch which changes the storage of the subslice mask to better match the userspace access through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into the subslice_mask array is then calculated: slice * subslice stride + subslice

[Intel-gfx] [PATCH 1/5] drm/i915: Use local variable for SSEU info in GETPARAM ioctl

2019-04-29 Thread Stuart Summers
In the GETPARAM ioctl handler, use a local variable to consolidate usage of SSEU runtime info. Cc: Daniele Ceraolo Spurio Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/i915_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 4/5] drm/i915: Move sseu helper functions to intel_sseu.h

2019-04-29 Thread Stuart Summers
Signed-off-by: Stuart Summers --- drivers/gpu/drm/i915/gt/intel_sseu.h | 47 drivers/gpu/drm/i915/intel_device_info.h | 47 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.h b/drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915: Fix bug for GeminiLake

2019-04-29 Thread Ville Syrjälä
On Mon, Apr 29, 2019 at 06:10:23PM +0300, Stanislav Lisovskiy wrote: > "drm/i915: Fix bug for GeminiLake" The patch subject is rather generic. With that improved Acked-by: Ville Syrjälä since we didn't managed to come up with a good explanation for the failure. PS. you cc:ed me on the wrong ad

Re: [Intel-gfx] [PATCH 22/45] drm/i915/execlists: Virtual engine bonding

2019-04-29 Thread Tvrtko Ursulin
On 25/04/2019 10:19, Chris Wilson wrote: Some users require that when a master batch is executed on one particular engine, a companion batch is run simultaneously on a specific slave engine. For this purpose, we introduce virtual engine bonding, allowing maps of master:slaves to be constructed t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev4)

2019-04-29 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev4) URL : https://patchwork.freedesktop.org/series/59742/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0cad53dc6dba drm/i915: Use local variable for SSEU info in GETPARAM ioctl da46929baac9 drm/i915: Add macro fo

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Refactor to expand subslice mask (rev4)

2019-04-29 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev4) URL : https://patchwork.freedesktop.org/series/59742/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Use local variable for SSEU info in GETPARAM ioctl Okay! Commit: drm/i9

Re: [Intel-gfx] [PATCH] drm/i915/csr: alpha_support doesn't depend on csr or vice versa

2019-04-29 Thread Rodrigo Vivi
On Mon, Apr 29, 2019 at 05:22:53PM +0300, Jani Nikula wrote: > Debug logging should not be dependent on alpha support flag. > > Cc: Rodrigo Vivi > Signed-off-by: Jani Nikula I agree... this is not the right way to track dependencies. Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix bug for GeminiLake

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12897 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor to expand subslice mask (rev4)

2019-04-29 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev4) URL : https://patchwork.freedesktop.org/series/59742/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012 -> Patchwork_12898 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 vgpu PV to improve vgpu performance

2019-04-29 Thread Patchwork
== Series Details == Series: i915 vgpu PV to improve vgpu performance URL : https://patchwork.freedesktop.org/series/60055/ State : success == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12892_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Introduce struct class_instance for engines across the uAPI

2019-04-29 Thread Rodrigo Vivi
On Fri, Apr 12, 2019 at 07:51:47AM +0100, Chris Wilson wrote: > SSEU reprogramming of the context introduced the notion of engine class > and instance for a forwards compatible method of describing any engine > beyond the old execbuf interface. We wish to adopt this class:instance > description for

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1

2019-04-29 Thread Anuj Phogat
On Sun, Apr 28, 2019 at 10:57 PM Tvrtko Ursulin wrote: > > > On 26/04/2019 17:58, Anuj Phogat wrote: > > > > Joonas, > > > > Mesa now applies this WA on ICL and we're not seeing any regressions in CI. > > I tested Mesa with and without this patch applied to kernel. I don't see > > any > > performa

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: the great header refactoring, part two (rev3)

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: the great header refactoring, part two (rev3) URL : https://patchwork.freedesktop.org/series/60060/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12894_full Summ

Re: [Intel-gfx] [PATCH 24/45] drm/i915: Split GEM object type definition to its own header

2019-04-29 Thread Rodrigo Vivi
On Mon, Apr 29, 2019 at 12:36:30PM +0300, Joonas Lahtinen wrote: > Quoting Jani Nikula (2019-04-26 15:12:49) > > On Thu, 25 Apr 2019, Chris Wilson wrote: > > > For convenience in avoiding inline spaghetti, keep the type definition > > > as a separate header. > > > > > > Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 5/5] drm/i915/execlists: Don't apply priority boost for resets

2019-04-29 Thread Chris Wilson
Do not treat reset as a normal preemption event and avoid giving the guilty request a priority boost for simply being active at the time of reset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --gi

[Intel-gfx] [PATCH 1/5] drm/i915: Wait for the struct_mutex on idling

2019-04-29 Thread Chris Wilson
When the system is idling, contention for struct_mutex should be low and so we will be more efficient to wait for a contended mutex than reschedule. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_pm.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 2/5] drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-04-29 Thread Chris Wilson
If we couple the scheduler more tightly with the execlists policy, we can apply the preemption policy to the question of whether we need to kick the tasklet at all for this priority bump. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 7 ++- dri

[Intel-gfx] [PATCH 3/5] drm/i915: Delay semaphore submission until the start of the signaler

2019-04-29 Thread Chris Wilson
Currently we submit the semaphore busywait as soon as the signaler is submitted to HW. However, we may submit the signaler as the tail of a batch of requests, and even not as the first context in the HW list, i.e. the busywait may start spinning far in advance of the signaler even starting. If we

[Intel-gfx] [PATCH 4/5] drm/i915: Disable semaphore busywaits on saturated systems

2019-04-29 Thread Chris Wilson
Asking the GPU to busywait on a memory address, perhaps not unexpectedly in hindsight for a shared system, leads to bus contention that affects CPU programs trying to concurrently access memory. This can manifest as a drop in transcode throughput on highly over-saturated workloads. The only clue o

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Wait for the struct_mutex on idling

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Wait for the struct_mutex on idling URL : https://patchwork.freedesktop.org/series/60072/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Wait for the struct_mutex on idling Oka

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2)

2019-04-29 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Wait for the struct_mutex on idling (rev2) URL : https://patchwork.freedesktop.org/series/60048/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12895_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/csr: alpha_support doesn't depend on csr or vice versa

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915/csr: alpha_support doesn't depend on csr or vice versa URL : https://patchwork.freedesktop.org/series/60062/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12896_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix bug for GeminiLake

2019-04-29 Thread Patchwork
== Series Details == Series: drm/i915: Fix bug for GeminiLake URL : https://patchwork.freedesktop.org/series/60065/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12897_full Summary --- **FAILUR

[Intel-gfx] ✗ Fi.CI.IGT: failure for Refactor to expand subslice mask (rev4)

2019-04-29 Thread Patchwork
== Series Details == Series: Refactor to expand subslice mask (rev4) URL : https://patchwork.freedesktop.org/series/59742/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6012_full -> Patchwork_12898_full Summary --- *

  1   2   >