Re: [Intel-gfx] [PATCH 2/4] drm/i915/uc: Reserve upper range of GGTT

2019-04-16 Thread Chris Wilson
Quoting Fernando Pacheco (2019-04-15 23:32:32) > > On 4/9/19 2:41 PM, Chris Wilson wrote: > > Quoting Fernando Pacheco (2019-04-09 22:31:00) > >> GuC and HuC depend on struct_mutex for device > >> reinitialization. Moving away from this dependency > >> requires perma-pinning the firmware images in

Re: [Intel-gfx] [v3 1/7] drm: Add gamma mode property

2019-04-16 Thread Daniel Vetter
On Fri, Apr 12, 2019 at 03:50:57PM +0530, Uma Shankar wrote: > From: Ville Syrjälä > > Add a gamma mode property to enable various kind of > gamma modes supported by platforms like: Interpolated, Split, > Multi Segmented etc. Userspace can get this property and > should be able to get the platfor

Re: [Intel-gfx] [PULL] gvt-next

2019-04-16 Thread Joonas Lahtinen
I'm getting an error while pulling this, could you check it: From https://github.com/intel/gvt-linux * tag gvt-next-2019-04-09 -> FETCH_HEAD dim: 66bd9f69d615 ("drm/i915/gvt: addressed guest GPU hang with HWS index mode"): Fixes: SHA1 in not pointing at an ancestor:

Re: [Intel-gfx] [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:33PM +0200, Noralf Trønnes wrote: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > >

[Intel-gfx] [PATCH v2 4/4] drm/i915/selftests: Verify whitelist of context registers

2019-04-16 Thread Chris Wilson
The RING_NONPRIV allows us to add registers to a whitelist that allows userspace to modify them. Ideally such registers should be safe and saved within the context such that they do not impact system behaviour for other users. This selftest verifies that those registers we do add are (a) then writa

[Intel-gfx] [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 6 + drivers/gpu/drm/i915/intel_workaro

[Intel-gfx] [PATCH v2 1/4] drm/i915: Verify workarounds immediately after application

2019-04-16 Thread Chris Wilson
Immediately after writing the workaround, verify that it stuck in the register. References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_workarounds.c | 32 +--- 1 file changed, 18 insertion

[Intel-gfx] [PATCH v2 3/4] drm/i915: Make workaround verification *optional*

2019-04-16 Thread Chris Wilson
Sometimes the HW doesn't even play fair, and completely forgets about register writes. Skip verifying known troublemakers. References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_workarounds.c | 40 ++

Re: [Intel-gfx] [PATCH] drm/i915: Enable workaround for pixel shader dispatch hang

2019-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-15 15:45:29) > Set chicken bits to workaround a possible pixel shader > dispatch hang. > > v2: no need to filter out preprod skl (Ville, Chris) > v3: formatting > > Bspec: 14091, ID#0651 > Cc: Chris Wilson > Cc: Ville Syrjälä > Signed-off-by: Mika Kuoppala > ---

[Intel-gfx] [PATCH] drm/i915/ehl: inherit icl cdclk init/uninit

2019-04-16 Thread Jani Nikula
The cdclk init/uninit code was changed by commit 93a643f29bcb ("drm/i915/cdclk: have only one init/uninit function") between the versions of commit 39564ae86d51 ("drm/i915/ehl: Inherit Ice Lake conditional code"). What got merged fails to do cdclk init/uninit on ehl. Fixes: 39564ae86d51 ("drm/i915

Re: [Intel-gfx] [PATCH v2 06/12] drm/fb-helper: Remove drm_fb_helper_crtc

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:37PM +0200, Noralf Trønnes wrote: > It now only contains the modeset so use that directly instead and attach > a modeset array to drm_client_dev. drm_fb_helper will use this array. > Code will later be moved to drm_client, so add code there in a new file > drm_client_m

Re: [Intel-gfx] [PATCH v2 08/12] drm/fb-helper: Move out commit code

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:39PM +0200, Noralf Trønnes wrote: > Move the modeset commit code to drm_client_modeset. > No changes except exporting API. > > v2: Move to drm_client_modeset.c instead of drm_client.c > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_client_modeset.c |

Re: [Intel-gfx] [PATCH v2 00/12] drm/fb-helper: Move modesetting code to drm_client

2019-04-16 Thread Daniel Vetter
On Sun, Apr 07, 2019 at 06:52:31PM +0200, Noralf Trønnes wrote: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > The main change this time is to attach the modeset array to > drm_client_dev and honour the drm_fb_helper MIT licens

Re: [Intel-gfx] [PATCH v2 00/12] drm/fb-helper: Move modesetting code to drm_client

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 10:41:06AM +0200, Daniel Vetter wrote: > On Sun, Apr 07, 2019 at 06:52:31PM +0200, Noralf Trønnes wrote: > > This moves the modesetting code from drm_fb_helper to drm_client so it > > can be shared by all internal clients. > > > > The main change this time is to attach the

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission

2019-04-16 Thread Chris Wilson
When resubmitting the spinner, fill in the expected offset so that we are not tempted to relocate it across contexts (as the spinner must point back to itself for the MI_BB_START to work). In this case, these should work correctly as they are reusing the same active vma, but for pedagogy we should

[Intel-gfx] [PATCH] drm/i915: Drop bool return from breadcrumbs signaler

2019-04-16 Thread Chris Wilson
Since removal of the "missed interrupt detection" bobody used the result of whether or not we signaled anybody during that invocation, so now remove the return value. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 14 +++--- drivers/gpu/drm

Re: [Intel-gfx] [v3 6/7] drm: Add Client Cap for advance gamma mode

2019-04-16 Thread Lankhorst, Maarten
mån 2019-04-15 klockan 15:43 +0300 skrev Ville Syrjälä: > On Mon, Apr 15, 2019 at 10:57:52AM +, Lankhorst, Maarten wrote: > > fre 2019-04-12 klockan 15:51 +0530 skrev Uma Shankar: > > > Introduced a client cap for advance cap mode > > > capability. Userspace should set this to get > > > to be a

Re: [Intel-gfx] [PULL] gvt-next

2019-04-16 Thread Zhenyu Wang
On 2019.04.16 10:29:03 +0300, Joonas Lahtinen wrote: > I'm getting an error while pulling this, could you check it: > > From https://github.com/intel/gvt-linux >* tag gvt-next-2019-04-09 -> FETCH_HEAD > dim: 66bd9f69d615 ("drm/i915/gvt: addressed guest GPU hang with

Re: [Intel-gfx] [PATCH v4 05/13] drivers: create binary sysfs for class

2019-04-16 Thread Greg Kroah-Hartman
On Mon, Apr 15, 2019 at 09:14:12PM +0200, Daniel Vetter wrote: > On Mon, Apr 15, 2019 at 8:01 PM Greg Kroah-Hartman > wrote: > > On Mon, Apr 15, 2019 at 10:44:12PM +0530, Ramalingam C wrote: > > > On 2019-04-15 at 16:47:16 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Apr 15, 2019 at 06:11:13PM

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915: Make PSR registers relative to transcoders

2019-04-16 Thread Jani Nikula
On Mon, 15 Apr 2019, José Roberto de Souza wrote: > PSR registers are a mess, some have the full address while others just > have the additional offset from psr_mmio_base. > > psr_mmio_base is nothing more than TRANSCODER_EDP_OFFSET + 0x800 and > using it makes more difficult for people with an PS

Re: [Intel-gfx] [PATCH] drm/i915: Drop bool return from breadcrumbs signaler

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 09:52, Chris Wilson wrote: Since removal of the "missed interrupt detection" bobody used the result of whether or not we signaled anybody during that invocation, so now remove the return value. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_bread

Re: [Intel-gfx] [PATCH 01/11] [v3] drm/i915: Introduce vfunc intel_get_color_config to create hw lut

2019-04-16 Thread Jani Nikula
On Mon, 15 Apr 2019, Swati Sharma wrote: > v3: Rebase > > Signed-off-by: Swati Sharma > --- > drivers/gpu/drm/i915/i915_drv.h| 1 + > drivers/gpu/drm/i915/intel_color.c | 7 +++ > drivers/gpu/drm/i915/intel_color.h | 1 + > 3 files changed, 9 insertions(+) > > diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH] drm/i915/selftests: Verify whitelist of context registers

2019-04-16 Thread Chris Wilson
The RING_NONPRIV allows us to add registers to a whitelist that allows userspace to modify them. Ideally such registers should be safe and saved within the context such that they do not impact system behaviour for other users. This selftest verifies that those registers we do add are (a) then writa

Re: [Intel-gfx] [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config()

2019-04-16 Thread Jani Nikula
On Mon, 15 Apr 2019, Swati Sharma wrote: > Signed-off-by: Swati Sharma Please add a commit message, and make this patch #2 in the series after the changes I suggested in patch #1. BR, Jani. > --- > drivers/gpu/drm/i915/intel_display.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Verify workarounds immediately after application

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 09:10, Chris Wilson wrote: Immediately after writing the workaround, verify that it stuck in the register. References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_workarounds.c | 32 +

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission

2019-04-16 Thread Patchwork
== Series Details == Series: i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission URL : https://patchwork.freedesktop.org/series/59564/ State : success == Summary == CI Bug Log - changes from IGT_4949 -> IGTPW_2862 Summary --

Re: [Intel-gfx] [PATCH v4 05/13] drivers: create binary sysfs for class

2019-04-16 Thread Daniel Vetter
On Tue, Apr 16, 2019 at 11:04 AM Greg Kroah-Hartman wrote: > On Mon, Apr 15, 2019 at 09:14:12PM +0200, Daniel Vetter wrote: > > On Mon, Apr 15, 2019 at 8:01 PM Greg Kroah-Hartman > > wrote: > > > On Mon, Apr 15, 2019 at 10:44:12PM +0530, Ramalingam C wrote: > > > > On 2019-04-15 at 16:47:16 +0200

Re: [Intel-gfx] [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:33PM +0200, Noralf Trønnes wrote: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > > A

Re: [Intel-gfx] [PATCH 11/11] [v3] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

2019-04-16 Thread Jani Nikula
On Mon, 15 Apr 2019, Swati Sharma wrote: > v3: Rebase > > Signed-off-by: Swati Sharma > --- > drivers/gpu/drm/i915/intel_color.c | 49 > > drivers/gpu/drm/i915/intel_color.h | 6 + > drivers/gpu/drm/i915/intel_display.c | 10 > 3 files chan

Re: [Intel-gfx] [PATCH v2 04/12] drm/fb-helper: No need to cache rotation and sw_rotations

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:35PM +0200, Noralf Trønnes wrote: > Getting rotation info is cheap so we can do it on demand. > > This is done in preparation for the removal of struct drm_fb_helper_crtc. > > Cc: Hans de Goede > Signed-off-by: Noralf Trønnes > Acked-by: Daniel Vetter Reviewed-by:

Re: [Intel-gfx] [PATCH v2 05/12] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:36PM +0200, Noralf Trønnes wrote: > The values are already present in the modeset. > > This is done in preparation for the removal of struct drm_fb_helper_crtc. > > Signed-off-by: Noralf Trønnes > Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard Maxime -- Ma

Re: [Intel-gfx] [PATCH v2 11/12] drm/fb-helper: Move out modeset config code

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:42PM +0200, Noralf Trønnes wrote: > No functional changes, just moving code as-is and fixing includes. > > Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signatu

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 09:10, Chris Wilson wrote: Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH v2 10/12] drm/fb-helper: Prepare to move out modeset config code

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:41PM +0200, Noralf Trønnes wrote: > This prepares the modeset code so it can be moved out as-is in the next > patch. > > Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Make workaround verification *optional*

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 09:10, Chris Wilson wrote: Sometimes the HW doesn't even play fair, and completely forgets about register writes. Skip verifying known troublemakers. References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-16 10:43:43) > > On 16/04/2019 09:10, Chris Wilson wrote: > > Read the engine workarounds back using the GPU after loading the initial > > context state to verify that we are setting them correctly, and bail if > > it fails. > > > > Signed-off-by: Chris Wilson > >

Re: [Intel-gfx] [PATCH v2 01/12] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-04-16 Thread Maxime Ripard
On Sun, Apr 07, 2019 at 06:52:32PM +0200, Noralf Trønnes wrote: > Prepare for moving drm_fb_helper modesetting code to drm_client. > drm_client will be linked to drm.ko, so move > __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() > out of drm_kms_helper.ko. > > While at it, f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: inherit icl cdclk init/uninit

2019-04-16 Thread Patchwork
== Series Details == Series: drm/i915/ehl: inherit icl cdclk init/uninit URL : https://patchwork.freedesktop.org/series/59562/ State : success == Summary == CI Bug Log - changes from CI_DRM_5936 -> Patchwork_12812 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH v2 09/12] drm/fb-helper: Remove drm_fb_helper_connector

2019-04-16 Thread Maxime Ripard
Hi, On Sun, Apr 07, 2019 at 06:52:40PM +0200, Noralf Trønnes wrote: > All drivers add all their connectors so there's no need to keep around an > array of available connectors. > > Rename functions which signature is changed since they will be moved to > drm_client in a later patch. > > Signed-off

[Intel-gfx] [RFC 1/2] drm/i915: start moving state checker to intel_verify.c

2019-04-16 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/intel_display.c | 474 +-- drivers/gpu/drm/i915/intel_drv.h | 12 + drivers/gpu/drm/i915/intel_verify.c | 464 ++ drivers/gpu/drm/i915/intel_veri

[Intel-gfx] [RFC 2/2] drm/i915: move pipe config compare to intel_verify.c

2019-04-16 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 471 +-- drivers/gpu/drm/i915/intel_drv.h | 9 +- drivers/gpu/drm/i915/intel_verify.c | 465 ++ drivers/gpu/drm/i915/intel_verify.h | 8 + 4 files changed, 478 insertion

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 10:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-04-16 10:43:43) On 16/04/2019 09:10, Chris Wilson wrote: Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. Signed-off

Re: [Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

2019-04-16 Thread Jani Nikula
On Mon, 15 Apr 2019, Swati Sharma wrote: > Signed-off-by: Swati Sharma > --- > drivers/gpu/drm/i915/i915_reg.h| 3 +++ > drivers/gpu/drm/i915/intel_color.c | 51 > ++ > 2 files changed, 54 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/

Re: [Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

2019-04-16 Thread Jani Nikula
On Tue, 16 Apr 2019, Jani Nikula wrote: > On Mon, 15 Apr 2019, Swati Sharma wrote: >> Signed-off-by: Swati Sharma >> --- >> drivers/gpu/drm/i915/i915_reg.h| 3 +++ >> drivers/gpu/drm/i915/intel_color.c | 51 >> ++ >> 2 files changed, 54 insertions(+) >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop bool return from breadcrumbs signaler

2019-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Drop bool return from breadcrumbs signaler URL : https://patchwork.freedesktop.org/series/59565/ State : success == Summary == CI Bug Log - changes from CI_DRM_5936 -> Patchwork_12813 Summary ---

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-16 11:36:12) > > On 16/04/2019 10:57, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-04-16 10:43:43) > >> > >> On 16/04/2019 09:10, Chris Wilson wrote: > >>> Read the engine workarounds back using the GPU after loading the initial > >>> context state to verify

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915: Verify workarounds immediately after application (rev2)

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Verify workarounds immediately after application (rev2) URL : https://patchwork.freedesktop.org/series/59560/ State : success == Summary == CI Bug Log - changes from CI_DRM_5936 -> Patchwork_12814 ===

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Make workaround verification *optional*

2019-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-16 10:48:05) > > On 16/04/2019 09:10, Chris Wilson wrote: > > Sometimes the HW doesn't even play fair, and completely forgets about > > register writes. Skip verifying known troublemakers. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 > >

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission

2019-04-16 Thread Patchwork
== Series Details == Series: i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission URL : https://patchwork.freedesktop.org/series/59564/ State : success == Summary == CI Bug Log - changes from IGT_4949_full -> IGTPW_2862_full

Re: [Intel-gfx] [PATCH 11/11] [v3] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

2019-04-16 Thread Dan Carpenter
Hi Swati, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-adding-state-checker-for-gamma-lut-values/20190416-021708 base: git://anongit.freedesktop.org/drm-intel for-linux-next New smatch warnings: drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2 11/22] drm/i915/guc: Reset GuC ADS during sanitize

2019-04-16 Thread Lis, Tomasz
Only comment issues. Besides these: Reviewed-by: Tomasz Lis On 2019-04-11 10:44, Michal Wajdeczko wrote: GuC stores some data in there, which might be stale after a reset. Reinitialize whole ADS in case any part of it was corrupted during previous GuC run. Signed-off-by: Michal Wajdeczko Cc

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c URL : https://patchwork.freedesktop.org/series/59569/ State : warning == Summary == $ dim checkpatch origin/drm-tip a4e2e34c9de6 drm/i915: start moving state checker to intel_ver

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c URL : https://patchwork.freedesktop.org/series/59569/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: start moving state checke

Re: [Intel-gfx] [PATCH 02/50] drm/i915: Mark up ips for RCU protection

2019-04-16 Thread Mika Kuoppala
Chris Wilson writes: > drivers/gpu/drm/i915/intel_pm.c:8352:9: error: incompatible types in > comparison expression (different address spaces) > drivers/gpu/drm/i915/intel_pm.c:8359:9: error: incompatible types in > comparison expression (different address spaces) > Yes, they are gone, Review

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: inherit icl cdclk init/uninit

2019-04-16 Thread Patchwork
== Series Details == Series: drm/i915/ehl: inherit icl cdclk init/uninit URL : https://patchwork.freedesktop.org/series/59562/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5936_full -> Patchwork_12812_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c URL : https://patchwork.freedesktop.org/series/59569/ State : success == Summary == CI Bug Log - changes from CI_DRM_5937 -> Patchwork_12815 =

[Intel-gfx] [PATCH 1/2] drm/i915: Verify workarounds immediately after application

2019-04-16 Thread Chris Wilson
Immediately after writing the workaround, verify that it stuck in the register. References: https://bugs.freedesktop.org/show_bug.cgi?id=108954 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_workarounds.c | 32 +---

[Intel-gfx] [PATCH 2/2] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. v2: Break out the verification into its own loop Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-16 Thread Ville Syrjälä
On Sat, Apr 13, 2019 at 11:13:27AM +, Simon Ser wrote: > From: Ville Syrjälä > > This adds basic immutable support for the zpos property. The zpos increases > from bottom to top: primary, sprites, cursor. I was thinking a bit about how we might go about testing this. We probably want a basi

Re: [Intel-gfx] [PATCH] drm/i915: Enable workaround for pixel shader dispatch hang

2019-04-16 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-04-15 15:45:29) >> Set chicken bits to workaround a possible pixel shader >> dispatch hang. >> >> v2: no need to filter out preprod skl (Ville, Chris) >> v3: formatting >> >> Bspec: 14091, ID#0651 >> Cc: Chris Wilson >> Cc: Ville Syrjälä >> S

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission

2019-04-16 Thread Mika Kuoppala
Chris Wilson writes: > When resubmitting the spinner, fill in the expected offset so that we > are not tempted to relocate it across contexts (as the spinner must > point back to itself for the MI_BB_START to work). In this case, these > should work correctly as they are reusing the same active v

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-16 Thread Maarten Lankhorst
Op 16-04-2019 om 15:20 schreef Ville Syrjälä: > On Sat, Apr 13, 2019 at 11:13:27AM +, Simon Ser wrote: >> From: Ville Syrjälä >> >> This adds basic immutable support for the zpos property. The zpos increases >> from bottom to top: primary, sprites, cursor. > I was thinking a bit about how we m

Re: [Intel-gfx] [PATCH] drm/i915: Enable workaround for pixel shader dispatch hang

2019-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-16 14:26:19) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2019-04-15 15:45:29) > >> Set chicken bits to workaround a possible pixel shader > >> dispatch hang. > >> > >> v2: no need to filter out preprod skl (Ville, Chris) > >> v3: formatting > >> > >> Bspec

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-16 Thread Ville Syrjälä
On Tue, Apr 16, 2019 at 03:28:15PM +0200, Maarten Lankhorst wrote: > Op 16-04-2019 om 15:20 schreef Ville Syrjälä: > > On Sat, Apr 13, 2019 at 11:13:27AM +, Simon Ser wrote: > >> From: Ville Syrjälä > >> > >> This adds basic immutable support for the zpos property. The zpos increases > >> from

Re: [Intel-gfx] [PATCH v5 1/2] drm: Add detection of changing of edid on between suspend and resume

2019-04-16 Thread Mun, Gwan-gyeong
On Thu, 2019-04-11 at 17:00 +0100, Lisovskiy, Stanislav wrote: > On Thu, 2019-04-11 at 17:36 +0300, Gwan-gyeong Mun wrote: > > The hotplug detection routine of drm_helper_hpd_irq_event() can > > detect > > changing of status of connector, but it can not detect changing of > > edid. > > > > Followi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Verify workarounds immediately after application

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Verify workarounds immediately after application URL : https://patchwork.freedesktop.org/series/59579/ State : success == Summary == CI Bug Log - changes from CI_DRM_5938 -> Patchwork_12816 =

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 14:14, Chris Wilson wrote: Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. v2: Break out the verification into its own loop Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v7] drm/i915/icl: Fix clockgating issue when using scalers

2019-04-16 Thread Ville Syrjälä
On Mon, Apr 15, 2019 at 03:55:19PM -0700, Radhakrishna Sripada wrote: > Fixes the clock-gating issue when pipe scaling is enabled. > (Lineage #2006604312) > > V2: Fix typo in headline(Chris) > Handle the non double buffered nature of the register(Ville) > V3: Fix checkpatch warning. BAT failur

Re: [Intel-gfx] [PATCH] drm/i915: Enable eLLC caching of display buffers for SKL+

2019-04-16 Thread Eero Tamminen
Hi, Based on quick tests with the patch: * Results in GfxBench and Unigine (Valley/Heaven) tests were within daily variation on the tested SKL machines * SKL GT4e (128MB eLLC) / Wayland / Weston: +15-20% SynMark TexMem512 (512MB of textures) +4-6% SynMark TerrainFly*, CSCloth, ShMapVsm

[Intel-gfx] [PATCH] drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-04-16 Thread Chris Wilson
Currently there is an underlying assumption that i915_request_unsubmit() is synchronous wrt the GPU -- that is the request is no longer in flight as we remove it. In the near future that may change, and this may upset our signaling as we can process an interrupt for that request while it is no long

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Drop bool return from breadcrumbs signaler

2019-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Drop bool return from breadcrumbs signaler URL : https://patchwork.freedesktop.org/series/59565/ State : success == Summary == CI Bug Log - changes from CI_DRM_5936_full -> Patchwork_12813_full Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-16 15:10:25) > > On 16/04/2019 14:14, Chris Wilson wrote: > > Read the engine workarounds back using the GPU after loading the initial > > context state to verify that we are setting them correctly, and bail if > > it fails. > > > > v2: Break out the verification i

[Intel-gfx] [PATCH i-g-t] i915/gem_spin_batch: Add test to resend spinner

2019-04-16 Thread Mika Kuoppala
Add subtests to resend the same spinner to same context and to other context. Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- tests/i915/gem_spin_batch.c | 47 ++--- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/tests/i915/gem_spin_batch.c b/te

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_spin_batch: Add test to resend spinner

2019-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-16 15:23:15) > Add subtests to resend the same spinner to same context > and to other context. > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson For completeness in creating concise examples of use elsewhere, feed the gem_execbuf to th

Re: [Intel-gfx] [PATCH] drm/i915: Enable eLLC caching of display buffers for SKL+

2019-04-16 Thread Ville Syrjälä
On Tue, Apr 16, 2019 at 05:28:57PM +0300, Eero Tamminen wrote: > Hi, > > Based on quick tests with the patch: > > * Results in GfxBench and Unigine (Valley/Heaven) tests were within > daily variation on the tested SKL machines > > * SKL GT4e (128MB eLLC) / Wayland / Weston: >+15-20% SynMark

Re: [Intel-gfx] [PATCH 4/4] Revert "drm/i915/guc: Disable global reset"

2019-04-16 Thread Fernando Pacheco
On 4/9/19 2:54 PM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-09 22:31:02) >> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. > And don't forget the test code that skips guc. > -Chris Selftests? I couldn't find anything that skips guc. I found some skips for guc submis

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Verify whitelist of context registers

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 10:12, Chris Wilson wrote: The RING_NONPRIV allows us to add registers to a whitelist that allows userspace to modify them. Ideally such registers should be safe and saved within the context such that they do not impact system behaviour for other users. This selftest verifies that

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Verify whitelist of context registers

2019-04-16 Thread Dan Carpenter
Hi Chris, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests-Verify-whitelist-of-context-registers/20190416-105231 base: git://anongit.freedesktop.org/drm-intel for-linux-next New smatch warnings: drivers

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Tvrtko Ursulin
On 16/04/2019 15:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-04-16 15:10:25) On 16/04/2019 14:14, Chris Wilson wrote: Read the engine workarounds back using the GPU after loading the initial context state to verify that we are setting them correctly, and bail if it fails. v2: Break

Re: [Intel-gfx] [PATCH 3/4] drm/i915/uc: Place uC firmware in upper range of GGTT

2019-04-16 Thread Fernando Pacheco
On 4/9/19 3:22 PM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-09 22:31:01) >> diff --git a/drivers/gpu/drm/i915/intel_huc.c >> b/drivers/gpu/drm/i915/intel_huc.c >> index 94c04f16a2ad..89e0b942ae86 100644 >> --- a/drivers/gpu/drm/i915/intel_huc.c >> +++ b/drivers/gpu/drm/i915/intel_h

Re: [Intel-gfx] [PATCH v2 09/12] drm/fb-helper: Remove drm_fb_helper_connector

2019-04-16 Thread Noralf Trønnes
Den 16.04.2019 11.42, skrev Maxime Ripard: > Hi, > > On Sun, Apr 07, 2019 at 06:52:40PM +0200, Noralf Trønnes wrote: >> All drivers add all their connectors so there's no need to keep around an >> array of available connectors. >> >> Rename functions which signature is changed since they will be

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Verify the engine workarounds stick on application

2019-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-16 15:53:40) > > On 16/04/2019 15:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-04-16 15:10:25) > >> > >> On 16/04/2019 14:14, Chris Wilson wrote: > >>> Read the engine workarounds back using the GPU after loading the initial > >>> context state to verify

[Intel-gfx] [PATCH i-g-t] i915/gem_spin_batch: Add test to resend spinner

2019-04-16 Thread Mika Kuoppala
Add subtests to resend the same spinner to same context and to other context. v2: other engines (Chris) Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- tests/i915/gem_spin_batch.c | 67 - 1 file changed, 58 insertions(+), 9 deletions(-) diff --git a/tests

Re: [Intel-gfx] [PATCH 3/4] drm/i915/uc: Place uC firmware in upper range of GGTT

2019-04-16 Thread Chris Wilson
Quoting Fernando Pacheco (2019-04-16 15:51:15) > > On 4/9/19 3:22 PM, Chris Wilson wrote: > > Quoting Fernando Pacheco (2019-04-09 22:31:01) > >> diff --git a/drivers/gpu/drm/i915/intel_huc.c > >> b/drivers/gpu/drm/i915/intel_huc.c > >> index 94c04f16a2ad..89e0b942ae86 100644 > >> --- a/drivers/g

Re: [Intel-gfx] [PATCH 4/4] Revert "drm/i915/guc: Disable global reset"

2019-04-16 Thread Chris Wilson
Quoting Fernando Pacheco (2019-04-16 15:45:03) > > > On 4/9/19 2:54 PM, Chris Wilson wrote: > > Quoting Fernando Pacheco (2019-04-09 22:31:02) > >> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. > > And don't forget the test code that skips guc. > > -Chris > > Selftests? I couldn'

Re: [Intel-gfx] [v3 6/7] drm: Add Client Cap for advance gamma mode

2019-04-16 Thread Ville Syrjälä
On Mon, Apr 15, 2019 at 09:20:55PM +0200, Daniel Vetter wrote: > On Mon, Apr 15, 2019 at 4:14 PM Lankhorst, Maarten > wrote: > > > > mån 2019-04-15 klockan 19:26 +0530 skrev Sharma, Shashank: > > > > -Original Message- > > > > From: Lankhorst, Maarten > > > > Sent: Monday, April 15, 2019 4

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/4] drm/i915: Verify workarounds immediately after application (rev2)

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Verify workarounds immediately after application (rev2) URL : https://patchwork.freedesktop.org/series/59560/ State : success == Summary == CI Bug Log - changes from CI_DRM_5936_full -> Patchwork_12814_full =

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_spin_batch: Add test to resend spinner

2019-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-16 16:01:58) > Add subtests to resend the same spinner to same context > and to other context. > > v2: other engines (Chris) > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson > + igt_subtest_f("resubmit-%s", e->name) > +

Re: [Intel-gfx] [PATCH 4/4] Revert "drm/i915/guc: Disable global reset"

2019-04-16 Thread Fernando Pacheco
On 4/16/19 8:05 AM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-16 15:45:03) >> >> On 4/9/19 2:54 PM, Chris Wilson wrote: >>> Quoting Fernando Pacheco (2019-04-09 22:31:02) This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. >>> And don't forget the test code that skips g

Re: [Intel-gfx] [PATCH] drm/i915/ehl: inherit icl cdclk init/uninit

2019-04-16 Thread Bob Paauwe
On Tue, 16 Apr 2019 11:28:52 +0300 Jani Nikula wrote: > The cdclk init/uninit code was changed by commit 93a643f29bcb > ("drm/i915/cdclk: have only one init/uninit function") between the > versions of commit 39564ae86d51 ("drm/i915/ehl: Inherit Ice Lake > conditional code"). What got merged fails

Re: [Intel-gfx] [PATCH 3/4] drm/i915/uc: Place uC firmware in upper range of GGTT

2019-04-16 Thread Fernando Pacheco
On 4/16/19 8:04 AM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-16 15:51:15) >> On 4/9/19 3:22 PM, Chris Wilson wrote: >>> Quoting Fernando Pacheco (2019-04-09 22:31:01) diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c index 94c04f16a2ad.

Re: [Intel-gfx] [PATCH] drm/i915: Configurable GT idle frequency

2019-04-16 Thread Bob Paauwe
On Mon, 15 Apr 2019 17:33:30 -0700 Vanshidhar Konda wrote: > On Mon, Apr 15, 2019 at 04:05:26PM -0700, Bob Paauwe wrote: > >There are real-time use cases where having deterministic CPU processes > >can be more important than GPU power/performance. Parking the GPU at a > >specific freqency by sett

Re: [Intel-gfx] [PATCH] drm/i915: Configurable GT idle frequency

2019-04-16 Thread Vanshidhar Konda
On Tue, Apr 16, 2019 at 08:30:22AM -0700, Bob Paauwe wrote: On Mon, 15 Apr 2019 17:33:30 -0700 Vanshidhar Konda wrote: On Mon, Apr 15, 2019 at 04:05:26PM -0700, Bob Paauwe wrote: >There are real-time use cases where having deterministic CPU processes >can be more important than GPU power/perfo

Re: [Intel-gfx] [PATCH v7] drm/i915/icl: Fix clockgating issue when using scalers

2019-04-16 Thread Sripada, Radhakrishna
On Tue, 2019-04-16 at 17:14 +0300, Ville Syrjälä wrote: > On Mon, Apr 15, 2019 at 03:55:19PM -0700, Radhakrishna Sripada wrote: > > Fixes the clock-gating issue when pipe scaling is enabled. > > (Lineage #2006604312) > > > > V2: Fix typo in headline(Chris) > > Handle the non double buffered na

Re: [Intel-gfx] [PATCH] drm/i915: Configurable GT idle frequency

2019-04-16 Thread Chris Wilson
Quoting Bob Paauwe (2019-04-16 00:05:26) > There are real-time use cases where having deterministic CPU processes > can be more important than GPU power/performance. Parking the GPU at a > specific freqency by setting idle, min and max prohibits the normal > dynamic GPU frequency switching which ca

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gem_spin_batch: Add test to resend spinner (rev2)

2019-04-16 Thread Patchwork
== Series Details == Series: i915/gem_spin_batch: Add test to resend spinner (rev2) URL : https://patchwork.freedesktop.org/series/59586/ State : success == Summary == CI Bug Log - changes from IGT_4952 -> IGTPW_2870 Summary --- **SU

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c

2019-04-16 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: start moving state checker to intel_verify.c URL : https://patchwork.freedesktop.org/series/59569/ State : success == Summary == CI Bug Log - changes from CI_DRM_5937_full -> Patchwork_12815_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Seal races between async GPU cancellation, retirement and signaling

2019-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Seal races between async GPU cancellation, retirement and signaling URL : https://patchwork.freedesktop.org/series/59584/ State : success == Summary == CI Bug Log - changes from CI_DRM_5939 -> Patchwork_12817 =

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-16 Thread Maarten Lankhorst
Op 16-04-2019 om 15:42 schreef Ville Syrjälä: > On Tue, Apr 16, 2019 at 03:28:15PM +0200, Maarten Lankhorst wrote: >> Op 16-04-2019 om 15:20 schreef Ville Syrjälä: >>> On Sat, Apr 13, 2019 at 11:13:27AM +, Simon Ser wrote: From: Ville Syrjälä This adds basic immutable support fo

Re: [Intel-gfx] [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

2019-04-16 Thread Noralf Trønnes
Den 16.04.2019 09.59, skrev Daniel Vetter: > On Sun, Apr 07, 2019 at 06:52:33PM +0200, Noralf Trønnes wrote: >> drm_fb_helper_is_bound() is used to check if DRM userspace is in control. >> This is done by looking at the fb on the primary plane. By the time >> fb-helper gets around to committing,

  1   2   >