Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2019 at 04:08:49PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/cirrus/cirrus.c: In function 'cirrus_fb_blit_rect': > drivers/gpu/drm/cirrus/cirrus.c:310:25: er

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2019 at 11:34:10AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got conflicts in: > > drivers/gpu/drm/cirrus/cirrus_drv.h > drivers/gpu/drm/cirrus/cirrus_ttm.c > > between commits: > > aa8e2435b3d4 ("drm/ttm: Define a single DR

[Intel-gfx] ✓ Fi.CI.IGT: success for IRQ initialization debloat and conversion to uncore

2019-04-09 Thread Patchwork
== Series Details == Series: IRQ initialization debloat and conversion to uncore URL : https://patchwork.freedesktop.org/series/59202/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891_full -> Patchwork_12734_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for Core-for-CI:ICL_only Disable ACPI idle driver (rev2)

2019-04-09 Thread Patchwork
== Series Details == Series: Core-for-CI:ICL_only Disable ACPI idle driver (rev2) URL : https://patchwork.freedesktop.org/series/59170/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5892 -> Patchwork_12735 Summary ---

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-09 Thread Stephen Rothwell
Hi Gerd, On Tue, 9 Apr 2019 09:22:18 +0200 Gerd Hoffmann wrote: > > On Tue, Apr 09, 2019 at 04:08:49PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the drm-misc tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpu/drm/cirrus/cirrus.

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2019 at 06:08:55PM +1000, Stephen Rothwell wrote: > Hi Gerd, > > > >drm_fb_memcpy_dstclip(__io_virt(cirrus->vram), > > > ^ > > > __do_irq > > > > Probably just a missing arm/io.h include. > > I assume you meant asm/i

[Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps, so HDMI_MAX_DA

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Update HDMI max TMDS data rate definition for VBT URL : https://patchwork.freedesktop.org/series/59220/ State : success == Summary == CI Bug Log - changes from CI_DRM_5895 -> Patchwork_12736 Summary --

[Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

2019-04-09 Thread Ayan Halder
Generated using make headers_install from the drm-next tree - git://anongit.freedesktop.org/drm/drm branch - drm-next commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f The changes were as follows :- core: (drm.h, drm_fourcc.h, drm_mode.h) - Added 'struct drm_syncobj_transfer', 'struct drm_syncobj

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

2019-04-09 Thread Eric Engestrom
On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > Generated using make headers_install from the drm-next > tree - git://anongit.freedesktop.org/drm/drm > branch - drm-next > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f > > The changes were as follows :- > > core: (drm.h, drm_fourcc

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

2019-04-09 Thread Eric Engestrom
On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > Generated using make headers_install from the drm-next > > tree - git://anongit.freedesktop.org/drm/drm > > branch - drm-next > > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote: > VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps > is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map > correct values Eh what? Did someone just change the interpretation of these bits?

[Intel-gfx] [PATCH 01/11] [v2] drm/i915: Introduce vfunc intel_get_color_config to create hw lut

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/intel_color.c | 7 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4af815c..861db

[Intel-gfx] [PATCH 00/11] adding state checker for gamma lut values

2019-04-09 Thread Swati Sharma
Thanks to Jani N, Matt and Ville for the review comments. Hopefully I have addressed all the current review comments and ready to receive more :) In this patch series, added state checker to validate gamma_lut values. This reads hardware state, and compares the originally requested state to the st

[Intel-gfx] [PATCH 04/11] [v2] drm/i915: Extract i965_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6e1fe5e..415b90d 100

[Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 51 ++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 00e0356..c86cbc1 100

[Intel-gfx] [PATCH 05/11] [v2] drm/i915: Extract icl_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 49 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 415b9

[Intel-gfx] [PATCH 03/11] [v2] drm/i915: Extract cherryview_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c86cbc1..6e1fe5e 100

[Intel-gfx] [PATCH 07/11] [v2] drm/i915: Extract bdw_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e398a60..e18388e 100644 --- a/drivers/gpu/drm/i915/intel_color.c

[Intel-gfx] [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7ecfb7d..3282bc7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 06/11] [v2] drm/i915: Extract glk_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 0fdbae3..e398a60 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++

[Intel-gfx] [PATCH 09/11] [v2] drm/i915: Extract ilk_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 42 -- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c424

[Intel-gfx] [PATCH 08/11] [v2] drm/i915: Extract ivb_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e18388e..0352ca5 100644 --- a/drivers/gpu/d

[Intel-gfx] [PATCH 11/11] [v2] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 49 drivers/gpu/drm/i915/intel_display.c | 10 drivers/gpu/drm/i915/intel_drv.h | 3 +++ 3 files changed, 62 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/

[Intel-gfx] [PATCH 00/11] drm/i915: adding state checker for gamma lut values

2019-04-09 Thread Swati Sharma
Thanks to Jani N, Matt and Ville for the review comments. Hopefully I have addressed all the current review comments and ready to receive more :) In this patch series, added state checker to validate gamma_lut values. This reads hardware state, and compares the originally requested state to the st

[Intel-gfx] [PATCH 05/11] [v2] drm/i915: Extract icl_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 49 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 415b9

[Intel-gfx] [PATCH 06/11] [v2] drm/i915: Extract glk_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 0fdbae3..e398a60 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++

[Intel-gfx] [PATCH 07/11] [v2] drm/i915: Extract bdw_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e398a60..e18388e 100644 --- a/drivers/gpu/drm/i915/intel_color.c

[Intel-gfx] [PATCH 09/11] [v2] drm/i915: Extract ilk_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 42 -- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c424

[Intel-gfx] [PATCH 02/11] [v2] drm/i915: Extract i9xx_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 51 ++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 00e0356..c86cbc1 100

[Intel-gfx] [PATCH 01/11] [v2] drm/i915: Introduce vfunc intel_get_color_config to create hw lut

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/intel_color.c | 7 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4af815c..861db

[Intel-gfx] [PATCH 03/11] [v2] drm/i915: Extract cherryview_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index c86cbc1..6e1fe5e 100

[Intel-gfx] [PATCH 11/11] [v2] drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 49 drivers/gpu/drm/i915/intel_display.c | 10 drivers/gpu/drm/i915/intel_drv.h | 3 +++ 3 files changed, 62 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/

[Intel-gfx] [PATCH 04/11] [v2] drm/i915: Extract i965_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/i915_reg.h| 3 +++ drivers/gpu/drm/i915/intel_color.c | 39 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6e1fe5e..415b90d 100

[Intel-gfx] [PATCH 08/11] [v2] drm/i915: Extract ivb_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index e18388e..0352ca5 100644 --- a/drivers/gpu/d

[Intel-gfx] [PATCH 10/11] [v2] drm/i915: Enable intel_get_color_config()

2019-04-09 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7ecfb7d..3282bc7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 01:29:41PM +, Jim Zhang wrote: > Villie: > > What is Intel's plan for the colorkey patch? Does Intel have any plan to > review and release? There is no real plan at this time. But if you have a use case for it I can try to harass people until someone reviews it :)

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Trick semaphores into a GPU hang

2019-04-09 Thread Chris Wilson
If we have two tasks running on xcs0 and xcs1 independently, but who queue subsequent work onto rcs, we may insert semaphores before the rcs work and pick unwisely which task to run first. To maximise throughput, we want to run on rcs whichever task is ready first. Conversely, if we pick wrongly th

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 04:46:24PM +0300, Ville Syrjälä wrote: > On Tue, Apr 09, 2019 at 01:29:41PM +, Jim Zhang wrote: > > Villie: > > > > What is Intel's plan for the colorkey patch? Does Intel have any plan to > > review and release? > > There is no real plan at this time. But if you ha

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 01:59:21PM +, Jim Zhang wrote: > Nice, do you have any sample code for it? https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/sna/sna_video_sprite.c is the only userspace code we have that uses the colorkey. > > Thanks, > > Jim > > > Caterpillar: Co

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 02:14:49PM +, Jim Zhang wrote: > Once I pre-configure the colorkey, am I able to enable and disable it? If > colorkey can be enabled/disabled after that might meet my requirement Not atomically with other updates. > > Thanks, > > Jim > > > Caterpillar: Confidentia

[Intel-gfx] [PATCH] drm/i915: Bump ready tasks ahead of busywaits

2019-04-09 Thread Chris Wilson
Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0 or vcs1). When using semaphores, however, we

[Intel-gfx] [PATCH 2/7] drm/i915/sdvo: Implement proper HDMI audio support for SDVO

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä Our SDVO audio support is pretty bogus. We can't push audio over the SDVO bus, so trying to enable audio in the SDVO control register doesn't do anything. In fact it looks like the SDVO encoder will always mix in the audio coming over HDA, and there's no (at least documented)

[Intel-gfx] [PATCH 7/7] drm/i915/sdvo: Actually print the reason why the SDVO command failed

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä It's much easier to figure out why the SDVO encoder refuses to cooperate if we can see what status we got back. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 5/7] drm/i915/sdvo: Don't unpack stack garbage

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä Pass the length returned by intel_sdvo_read_infoframe() to hdmi_infoframe_unpack() so that we don't try to unpack any leftover stack garbage. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 4/7] drm/i915/sdvo: Check that we have space for the infoframe

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä Before we go writing the infoframe let's make sure we have the space for it. Not that it really matters since the write loop would just terminate early in that case. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+)

[Intel-gfx] [PATCH 0/7] drm/i915: Fix SDVO HDMI audio

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä Here's a series to fix SDVO HDMI audio handling which got broken quite a while ago. I also tossed in a few extra cleanups. Ville Syrjälä (7): drm/i915/sdvo: Fix AVI infoframe TX rate readout drm/i915/sdvo: Implement proper HDMI audio support for SDVO drm/i915: Rename SD

[Intel-gfx] [PATCH 1/7] drm/i915/sdvo: Fix AVI infoframe TX rate readout

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä The AVI infoframe readout code currently issues a SDVO_CMD_GET_HBUF_TXRATE before SDVO_CMD_SET_HBUF_INDEX, which is not the correct order for these two operations. So far this wasn't a problem since we left the index pointing at the AVI infoframe buffer at the end of the modes

[Intel-gfx] [PATCH 6/7] drm/i915/sdvo: Don't write stack garbage into the hbuf

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä Pass the length returned by hdmi_infoframe_pack_only() to intel_sdvo_write_infoframe() so that we don't end up writing stack garbage into the hbuf. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 3/7] drm/i915: Rename SDVO_AUDIO_ENABLE to HDMI_AUDIO_ENABLE

2019-04-09 Thread Ville Syrjala
From: Ville Syrjälä The "audio enable" bit on the SDVO/HDMI control register is only meant for HDMI. Audio is never delivered over the SDVO bus. Rename the define to reflect this fact. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_hdmi.c

Re: [Intel-gfx] colorkey support for intel i915 gpu driver

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 02:24:03PM +, Jim Zhang wrote: > What about if I disable interrupt when changing the colorkey? This will > solve the atomic issue. I think we only change colorkey or enable/disable > colorkey once a while. If disabling interrupt work, I will disable interrupt > and

[Intel-gfx] [PATCH v2] drm/i915: Bump ready tasks ahead of busywaits

2019-04-09 Thread Chris Wilson
Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0 or vcs1). When using semaphores, however, we

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Update HDMI max TMDS data rate definition for VBT URL : https://patchwork.freedesktop.org/series/59220/ State : success == Summary == CI Bug Log - changes from CI_DRM_5895_full -> Patchwork_12736_full

Re: [Intel-gfx] [PATCH v2] drm/i915: Bump ready tasks ahead of busywaits

2019-04-09 Thread Tvrtko Ursulin
On 09/04/2019 16:29, Chris Wilson wrote: Consider two tasks that are running in parallel on a pair of engines (vcs0, vcs1), but then must complete on a shared engine (rcs0). To maximise throughput, we want to run the first ready task on rcs0 (i.e. the first task that completes on either of vcs0

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Trick semaphores into a GPU hang

2019-04-09 Thread Tvrtko Ursulin
On 09/04/2019 14:56, Chris Wilson wrote: If we have two tasks running on xcs0 and xcs1 independently, but who queue subsequent work onto rcs, we may insert semaphores before the rcs work and pick unwisely which task to run first. To maximise throughput, we want to run on rcs whichever task is re

Re: [Intel-gfx] [PATCH v2] drm/i915: Bump ready tasks ahead of busywaits

2019-04-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-09 16:38:37) > > On 09/04/2019 16:29, Chris Wilson wrote: > > Consider two tasks that are running in parallel on a pair of engines > > (vcs0, vcs1), but then must complete on a shared engine (rcs0). To > > maximise throughput, we want to run the first ready task on

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
Hi Ville, The bits is 5-7 means it’s 001x for 2.97Gbps, and 010x for 1.65Gbps. So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297. And HDMI_MAX_DATA_RATE_165 is 4 not 2. I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI 2.0 then found this error. And I r

Re: [Intel-gfx] [PATCH v2] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-09 Thread Rafael J. Wysocki
On 4/9/2019 8:29 AM, Anshuman Gupta wrote: There were few system hung observed while running i915_pm_rpm igt test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840 Root cause is believed to due to page fault in ACPI idle driver. (FDO comment 18). It has been suggested by Daniel Vetter to d

[Intel-gfx] ✗ Fi.CI.BAT: failure for adding state checker for gamma lut values

2019-04-09 Thread Patchwork
== Series Details == Series: adding state checker for gamma lut values URL : https://patchwork.freedesktop.org/series/59226/ State : failure == Summary == Applying: drm/i915: Introduce vfunc intel_get_color_config to create hw lut Using index info to reconstruct a base tree... M drivers/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: adding state checker for gamma lut values (rev3)

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev3) URL : https://patchwork.freedesktop.org/series/58039/ State : failure == Summary == Applying: drm/i915: Introduce vfunc intel_get_color_config to create hw lut Using index info to reconstruct a base tree...

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 03:46:20PM +, Chiou, Cooper wrote: > Hi Ville, > > The bits is 5-7 means it’s 001x for 2.97Gbps, and 010x for 1.65Gbps. > So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297. No. The bitfield is defined as something:3. > And HDMI_MAX_DATA_RATE_165

[Intel-gfx] [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold

2019-04-09 Thread Mika Kuoppala
On gen11 the recommended rc6 threshold differs from previous gens, apply it. References: bspec#52070 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_p

[Intel-gfx] [PATCH 4/7] drm/i915/icl: Enable media sampler powergate

2019-04-09 Thread Mika Kuoppala
Enable media sampler powergate as recommended. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_reg.h | 5 +++-- drivers/gpu/drm/i915/intel_pm.c | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h in

[Intel-gfx] [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Mika Kuoppala
In order not to inflate gen9 rc6 enabling sequence with gen11 specifics, use a separate function for it. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c | 72 + 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drive

[Intel-gfx] [PATCH 5/7] drm/i915/icl: Disable video turbo mode for rp control

2019-04-09 Thread Mika Kuoppala
There is no video turbo mode for gen11, so don't set it. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 47f98e064de5..d6abba5c0b32 100

[Intel-gfx] [PATCH 3/7] drm/i915/icl: Apply recommended rc6 idle hysteresis

2019-04-09 Thread Mika Kuoppala
Use a recommended idle hysteresis for media and render powergates. References: bspec#52070 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c in

[Intel-gfx] [PATCH 6/7] drm/i915/icl: Handle rps interrupts without irq lock

2019-04-09 Thread Mika Kuoppala
Unlike previous gens, we already hold the irq_lock on entering the rps handler so we can't use it as it is. Make a gen11 specific rps interrupt handler without locking. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_irq.c | 18 +- 1 file changed, 17 insertions(+), 1

[Intel-gfx] [PATCH 7/7] drm/i915: Use Engine1 instance for gen11 pm interrupts

2019-04-09 Thread Mika Kuoppala
With gen11 the interrupt registers are shared between 2 engines, with Engine1 instance being upper word and Engine0 instance being lower. Annoyingly gen11 selected the pm interrupts to be in the Engine1 instance. Rectify the situation by shifting the access accordingly, based on gen. Bugzilla: ht

Re: [Intel-gfx] [PATCH 3/7] drm/i915/icl: Apply recommended rc6 idle hysteresis

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:06) > Use a recommended idle hysteresis for media and render powergates. > > References: bspec#52070 > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/driver

Re: [Intel-gfx] [v7 1/9] drm: Add HDR source metadata property

2019-04-09 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Jonas >Karlman >Sent: Monday, April 8, 2019 3:51 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org >Cc: seanp...@chromium.org; emil.l.veli...@gmail.

[Intel-gfx] [v8 05/10] drm/i915: Write HDR infoframe and send to panel

2019-04-09 Thread Uma Shankar
Enable writing of HDR metadata infoframe to panel. The data will be provid by usersapace compositors, based on blending policies and passsed to driver through a blob property. v2: Rebase v3: Fixed a warning message v4: Addressed Shashank's review comments v5: Rebase. Added infoframe calculation

[Intel-gfx] [v8 01/10] drm: Add HDR source metadata property

2019-04-09 Thread Uma Shankar
This patch adds a blob property to get HDR metadata information from userspace. This will be send as part of AVI Infoframe to panel. It also implements get() and set() functions for HDR output metadata property.The blob data is received from userspace and saved in connector state, the same is retu

[Intel-gfx] [v8 06/10] drm/i915: Add HLG EOTF

2019-04-09 Thread Uma Shankar
From: Ville Syrjälä ADD HLG EOTF to the list of EOTF transfer functions supported. Hybrid Log-Gamma (HLG) is a high dynamic range (HDR) standard. HLG defines a nonlinear transfer function in which the lower half of the signal values use a gamma curve and the upper half of the signal values use a

[Intel-gfx] [v8 00/10] Add HDR Metadata Parsing and handling in DRM layer

2019-04-09 Thread Uma Shankar
This patch series enables HDR support in drm. It basically defines HDR metadata structures, property to pass content (after blending) metadata from user space compositors to driver. Dynamic Range and Mastering infoframe creation and sending. ToDo: 1. We need to get the color framework in place fo

[Intel-gfx] [v8 08/10] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-04-09 Thread Uma Shankar
This patch enables modeset whenever HDR metadata needs to be updated to sink. v2: Addressed Shashank's review comments. v3: Added Shashank's RB. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_atomic.c | 14 +- d

[Intel-gfx] [v8 07/10] drm/i915: Enable infoframes on GLK+ for HDR

2019-04-09 Thread Uma Shankar
From: Ville Syrjälä This patch enables infoframes on GLK+ to be used to send HDR metadata to HDMI sink. v2: Addressed Shashank's review comment. v3: Addressed Shashank's review comment. v4: Added Shashank's RB. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by: Shashank Sh

[Intel-gfx] [v8 04/10] drm/i915: Attach HDR metadata property to connector

2019-04-09 Thread Uma Shankar
Attach HDR metadata property to connector object. v2: Rebase v3: Updated the property name as per updated name while creating hdr metadata property Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [v8 03/10] drm: Enable HDR infoframe support

2019-04-09 Thread Uma Shankar
Enable Dynamic Range and Mastering Infoframe for HDR content, which is defined in CEA 861.3 spec. The metadata will be computed based on blending policy in userspace compositors and passed as a connector property blob to driver. The same will be sent as infoframe to panel which support HDR. Added

[Intel-gfx] [v8 02/10] drm: Parse HDR metadata info from EDID

2019-04-09 Thread Uma Shankar
HDR metadata block is introduced in CEA-861.3 spec. Parsing the same to get the panel's HDR metadata. v2: Rebase and added Ville's POC changes to the patch. v3: No Change v4: Addressed Shashank's review comments v5: Addressed Shashank's comment and added his RB. v6: Addressed Jonas Karlman rev

[Intel-gfx] [v8 09/10] drm/i915: Set Infoframe for non modeset case for HDR

2019-04-09 Thread Uma Shankar
HDR metadata requires a infoframe to be set. Due to fastset, full modeset is not performed hence adding it to update_pipe to handle that. Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_ddi.c | 13 + drivers/gpu/drm/i915/intel_hdmi.c | 7

[Intel-gfx] [v8 10/10] drm/i915: Added DRM Infoframe handling for BYT/CHT

2019-04-09 Thread Uma Shankar
BYT/CHT doesn't support DRM Infoframe. This caused a WARN_ON due to a missing CASE while executing intel_hdmi_infoframes_enabled function. This patch fixes the same. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 6/7] drm/i915/icl: Handle rps interrupts without irq lock

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:09) > Unlike previous gens, we already hold the irq_lock on > entering the rps handler so we can't use it as it is. > > Make a gen11 specific rps interrupt handler without > locking. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix SDVO HDMI audio

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Fix SDVO HDMI audio URL : https://patchwork.freedesktop.org/series/59233/ State : success == Summary == CI Bug Log - changes from CI_DRM_5897 -> Patchwork_12739 Summary --- **SUCCESS** No reg

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Use Engine1 instance for gen11 pm interrupts

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:10) > With gen11 the interrupt registers are shared between 2 engines, > with Engine1 instance being upper word and Engine0 instance being > lower. Annoyingly gen11 selected the pm interrupts to be in the > Engine1 instance. Sounds weird, but I can't fault t

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:04) > In order not to inflate gen9 rc6 enabling sequence with > gen11 specifics, use a separate function for it. And disable_rc6 remains as simple as before. > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 5/7] drm/i915/icl: Disable video turbo mode for rp control

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:08) > There is no video turbo mode for gen11, so don't set it. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_pm.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Enable media sampler powergate

2019-04-09 Thread Chris Wilson
Quoting Mika Kuoppala (2019-04-09 17:13:07) > Enable media sampler powergate as recommended. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_reg.h | 5 +++-- > drivers/gpu/drm/i915/intel_pm.c | 4 +++- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/driver

Re: [Intel-gfx] [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold

2019-04-09 Thread Michal Wajdeczko
On Tue, 09 Apr 2019 18:13:05 +0200, Mika Kuoppala wrote: On gen11 the recommended rc6 threshold differs from previous gens, apply it. References: bspec#52070 Is this correct number? I found it at 33149 And note that we are using different tag: Bspec: 33149 Signed-off-by: Mika Kuoppala

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Michal Wajdeczko
On Tue, 09 Apr 2019 18:13:04 +0200, Mika Kuoppala wrote: [snip] + + /* +* 2c: Program Coarse Power Gating Policies. +* +* Bspec's guidance is to use 25us (really 25 * 1280ns) here. What we +* use instead is a more conservative estimate for the maximum ti

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-04-09 17:57:58) > On Tue, 09 Apr 2019 18:13:04 +0200, Mika Kuoppala > wrote: > > [snip] > > > + > > + /* > > + * 2c: Program Coarse Power Gating Policies. > > + * > > + * Bspec's guidance is to use 25us (really 25 * 1280ns) here. What we > > +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Bump ready tasks ahead of busywaits (rev2)

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Bump ready tasks ahead of busywaits (rev2) URL : https://patchwork.freedesktop.org/series/59232/ State : success == Summary == CI Bug Log - changes from CI_DRM_5897 -> Patchwork_12740 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2)

2019-04-09 Thread Patchwork
== Series Details == Series: drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2) URL : https://patchwork.freedesktop.org/series/59220/ State : failure == Summary == Applying: drm/i915: Update HDMI max TMDS data rate definition for VBT error: corrupt patch at line 13 error: could

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 URL : https://patchwork.freedesktop.org/series/59237/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18e95bd1432c drm/i915: Use dedicated rc6 enabling sequence for ge

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for IRQ initialization debloat and conversion to uncore

2019-04-09 Thread Paulo Zanoni
Em ter, 2019-04-09 às 00:44 +, Patchwork escreveu: > == Series Details == > > Series: IRQ initialization debloat and conversion to uncore > URL : https://patchwork.freedesktop.org/series/59202/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 7f73d1fe31bb drm/i915:

[Intel-gfx] [PATCH] drm/i915: Avoiding reclaim tainting from runtime-pm debug

2019-04-09 Thread Chris Wilson
As intel_runtime_pm_get/_put may be called from any blockable context, we need to avoid allowing reclaim from our mallocs, as we need to avoid tainting any mutexes held by the callers (as they may themselves not allow for allocations as they are taken in the shrinker). <4> [435.339331] WARNING: po

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11

2019-04-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 URL : https://patchwork.freedesktop.org/series/59237/ State : success == Summary == CI Bug Log - changes from CI_DRM_5897 -> Patchwork_12742

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev8)

2019-04-09 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev8) URL : https://patchwork.freedesktop.org/series/25091/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6f71d6db5493 drm: Add HDR source metadata property -:67: CHECK:PARENTHESIS_ALIGNMENT: Align

Re: [Intel-gfx] [PATCH 1/3] drm/i915: refactor the IRQ init/reset macros

2019-04-09 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 05:37:27PM -0700, Paulo Zanoni wrote: > The whole point of having macros here is for the token pasting > necessary to automatically have IMR, IIR and IER selected. We don't > really need or want all the inlining that happens as a consequence. > The good thing about the curre

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for IRQ initialization debloat and conversion to uncore

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 10:34:22AM -0700, Paulo Zanoni wrote: > Em ter, 2019-04-09 às 00:44 +, Patchwork escreveu: > > == Series Details == > > > > Series: IRQ initialization debloat and conversion to uncore > > URL : https://patchwork.freedesktop.org/series/59202/ > > State : warning > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Add HDR Metadata Parsing and handling in DRM layer (rev8)

2019-04-09 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev8) URL : https://patchwork.freedesktop.org/series/25091/ State : success == Summary == CI Bug Log - changes from CI_DRM_5897 -> Patchwork_12743 Summary

  1   2   >