Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Dhinakaran Pandiyan
On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > Even when driver is reloaded and hits this scenario the PSR mutex > should be initialized, otherwise reading PSR debugfs status will > execute mutex_lock() over a mutex that was not initialized. > > Cc: Dhinakaran Pandiyan > Cc: Ro

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Souza, Jose
On Thu, 2019-04-04 at 17:22 -0700, Dhinakaran Pandiyan wrote: > On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > > Even when driver is reloaded and hits this scenario the PSR mutex > > should be initialized, otherwise reading PSR debugfs status will > > execute mutex_lock() over a

Re: [Intel-gfx] [PATCH 5/7] drm/i915/bdw+: Move misc display IRQ handling to it own function

2019-04-04 Thread Dhinakaran Pandiyan
On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > Just moving it to reduce the tabs and avoid break code lines. > No behavior changes intended here. > > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/i915_irq.c | 63 +++-- > 1 file c

Re: [Intel-gfx] [PATCH 3/9] drm/i915/ehl: ehl and icl are both gen11

2019-04-04 Thread Lucas De Marchi
On Thu, Mar 14, 2019 at 2:11 PM Souza, Jose wrote: > > Maybe rename the commit message to "drm/i915/ehl: Inherit ICELAKE > conditional code"? > > Also there a few important places that this patch and this series is > missing: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > b/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-04-04 Thread Dhinakaran Pandiyan
On Thu, 2019-04-04 at 17:32 -0700, Souza, Jose wrote: > On Thu, 2019-04-04 at 17:22 -0700, Dhinakaran Pandiyan wrote: > > On Wed, 2019-04-03 at 16:35 -0700, José Roberto de Souza wrote: > > > Even when driver is reloaded and hits this scenario the PSR mutex > > > should be initialized, otherwise re

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add support for DPLL4 (v2)

2019-04-04 Thread kbuild test robot
Hi Vivek, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190404] [cannot apply to v5.1-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-04 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (powerpc allyesconfig) failed like this: kernel/dma/contiguous.c:19:10: fatal error: asm/dma-contiguous.h: No such file or directory #include ^~ Caused by commit 4f2a8f5898ec ("drm: Add ASPEED G

[Intel-gfx] [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-04 Thread Aditya Swarup
From: Clinton Taylor v2: Fix commit msg to reflect why issue occurs(Jani) Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color. Changing settings from 10/12 bit deep color to 8 bit(& vice versa) doesn't work correctly using xrandr max bpc property. When we connect a monitor which suppo

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-04 Thread Stephen Rothwell
Hi Dave, On Fri, 5 Apr 2019 15:55:50 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > kernel/dma/contiguous.c:19:10: fatal error: asm/dma-contiguous.h: No such > file or directory > #include >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Add N & CTS values for 10/12 bit deep color

2019-04-04 Thread Aditya Swarup
On Tue, Apr 02, 2019 at 05:14:40AM -0700, Aditya Swarup wrote: > Adding N & CTS values for 10/12 bit deep color from Appendix C > table in HDMI 2.0 spec. The correct values for N is not chosen > automatically by hardware for deep color modes. > > v2: Remove redundant code and make it generic.(Jani

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-04 Thread Jani Nikula
On Sat, 01 Dec 2018, Hans de Goede wrote: > There are 3 problems with the dsi code's pipe_bpp handling for 6 bpc > pixel-formats which this commit addresses: > > 1) It assumes that the pipe_bpp is the same as the bpp going over the dsi > lanes. This assumption is not valid for MIPI_DSI_FMT_RGB666,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4)

2019-04-04 Thread Patchwork
== Series Details == Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4) URL : https://patchwork.freedesktop.org/series/58912/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5877 -> Patchwork_12690 ===

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-04 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Jani > Nikula > Sent: perjantai 5. huhtikuuta 2019 9.35 > To: Hans de Goede ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Ville > Syrjälä > Cc: intel-gfx ; > dri-de...@lists.freedeskto

<    1   2