[Intel-gfx] [PATCH 16/30] drm/i915/guc: Define GuC firmware version for Icelake

2019-03-29 Thread Michal Wajdeczko
Define GuC firmware version for Icelake. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_guc_fw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_guc

[Intel-gfx] [PATCH 03/30] drm/i915/guc: Update GuC firmware versions and names

2019-03-29 Thread Michal Wajdeczko
GuC firmware changed its release version numbering schema and now it also includes patch version. Update our GuC firmware path definitions to match new pattern: _guc_...bin While here, reorder platform checks and start from the latest. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc

[Intel-gfx] [PATCH 17/30] drm/i915/huc: Define HuC firmware version for Icelake

2019-03-29 Thread Michal Wajdeczko
This patch adds the support to load HuC on ICL. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Anusha Srivatsa Cc: Tony Ye --- drivers/gpu/drm/i915/intel_huc_fw.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 11/30] drm/i915/guc: New GuC interrupt register for Gen11

2019-03-29 Thread Michal Wajdeczko
Gen11 defines new more flexible Host-to-GuC interrupt register. Now the host can write any 32-bit payload to trigger an interrupt and GuC can additionally read this payload from the register. Current GuC firmware ignores the payload so we just write 0. Bspec: 21043 Signed-off-by: Michal Wajdeczko

[Intel-gfx] [PATCH 13/30] drm/i915/guc: Update GuC CTB response definition

2019-03-29 Thread Michal Wajdeczko
From: Oscar Mateo Current GuC firmwares identify response message in a different way. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Kelvin Gardiner Cc: John Spotswood --- drivers/gpu/drm/i915/intel_guc_ct.c | 2 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 2 ++ 2 files cha

[Intel-gfx] [PATCH 14/30] drm/i915/guc: Enable GuC CTB communication on Gen11

2019-03-29 Thread Michal Wajdeczko
Gen11 GuC firmware expects H2G command messages to be sent over CTB (command transport buffers). Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: John Spotswood --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gp

[Intel-gfx] [PATCH 12/30] drm/i915/guc: New GuC scratch registers for Gen11

2019-03-29 Thread Michal Wajdeczko
Gen11 adds new set of scratch registers that can be used for MMIO based Host-to-Guc communication. Due to limited number of these registers it is expected that host will use them only for command transport buffers (CTB) communication setup if one is available. Bspec: 21044 Signed-off-by: Michal W

[Intel-gfx] [PATCH 25/30] drm/i915/guc: New engine-reset-complete message

2019-03-29 Thread Michal Wajdeczko
GuC sends ENGINE_RESET_COMPLETE message as an follow-up answer to earlier ENGINE_RESET request from the host. Once this message is received, clear engine reset flag to unblock our reset process. Credits-to: Michel Thierry Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Vinay Belg

[Intel-gfx] [PATCH 20/30] drm/i915/guc: Make use of the SW counter field in the context descriptor

2019-03-29 Thread Michal Wajdeczko
From: Oscar Mateo The new context descriptor format contains two assignable fields: the SW Context ID (technically 11 bits, but practically limited to 2032 entries due to some being reserved for future use by the GuC) and the SW Counter (6 bits). We don't want to limit ourselves too much in the

[Intel-gfx] [PATCH 19/30] drm/i915/guc: New GuC IDs based on engine class and instance

2019-03-29 Thread Michal Wajdeczko
From: Daniele Ceraolo Spurio Starting from Gen11, the ID to be provided to GuC needs to contain the engine class in bits [0..2] and the instance in bits [3..6]. NOTE: this patch breaks pointer dereferences in some existing GuC functions that use the guc_id to dereference arrays but these functio

[Intel-gfx] [PATCH 28/30] drm/i915/guc: Correctly handle GuC interrupts on Gen11

2019-03-29 Thread Michal Wajdeczko
From: Oscar Mateo The GuC interrupts now get their own interrupt vector (instead of sharing a register with the PM interrupts) so handle appropriately. Signed-off-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Cc: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen --- drivers/g

[Intel-gfx] [PATCH 23/30] drm/i915/guc: Add support for resume-parsing wq item

2019-03-29 Thread Michal Wajdeczko
Since fw version 25.161, GuC lets us know when an engine had to be reset due to a hang in another dependent engine, by setting BIT(engine_class) in the queue_engine_error field. GuC will ignore any other wq item until this flag is cleared. To restart the workqueue processing for that engine, we mu

[Intel-gfx] [PATCH 26/30] drm/i915/guc: Properly capture & release GuC interrupts on Gen11

2019-03-29 Thread Michal Wajdeczko
From: Oscar Mateo With the new interrupt re-partitioning in Gen11, GuC controls by itself the interrupts it receives, so steering bits and registers have been defeatured. Being this the case, when the GuC is in control of submissions we won't know what to do with the ctx switch interrupt in the d

[Intel-gfx] [PATCH 27/30] drm/i915/guc: Create vfuncs for the GuC interrupts control functions

2019-03-29 Thread Michal Wajdeczko
From: Oscar Mateo Controlling and handling of the GuC interrupts is Gen specific. Create virtual functions to avoid redundant runtime Gen checks. Gen-specific versions of these functions will follow. Signed-off-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Cc: Rodrigo Vivi Cc: Tvrtko Ursuli

[Intel-gfx] [PATCH] drm/i915: add immutable zpos plane properties

2019-03-29 Thread Simon Ser
From: emersion This adds basic immutable support for the zpos property. The zpos increases from bottom to top: primary, sprites, cursor. Signed-off-by: Simon Ser --- This is based on a previous patch by Ville [1] that I wanted to review. Unfortunately the patch no longer applies, so here is a

Re: [Intel-gfx] [PATCH 20/30] drm/i915/guc: Make use of the SW counter field in the context descriptor

2019-03-29 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-03-29 22:11:08) > From: Oscar Mateo > > The new context descriptor format contains two assignable fields: > the SW Context ID (technically 11 bits, but practically limited to 2032 > entries due to some being reserved for future use by the GuC) and the > SW Counter (

Re: [Intel-gfx] [PATCH 28/30] drm/i915/guc: Correctly handle GuC interrupts on Gen11

2019-03-29 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-03-29 22:11:16) > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 3dd971c09d52..c1b4fbd5f496 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -573,6 +573,44 @@ static void gen9_disable_g

Re: [Intel-gfx] [PATCH v4] drm/i915/icl: Fix clockgating issue when using scalers

2019-03-29 Thread Sripada, Radhakrishna
On Fri, 2019-03-29 at 20:39 +0200, Ville Syrjälä wrote: > On Thu, Mar 28, 2019 at 10:35:19AM -0700, Radhakrishna Sripada wrote: > > Fixes the clock-gating issue when pipe scaling is enabled. > > (Lineage #2006604312) > > > > V2: Fix typo in headline(Chris) > > Handle the non double buffered na

[Intel-gfx] [PATCH v2] drm/i915/guc: Retry GuC load for all load failures

2019-03-29 Thread Robert M. Fosha
Currently we only retry to load GuC firmware if the load fails due to timeout. On Gen9 GuC loading may fail for different reasons, not just hang/timeout. Direction from the GuC team is to retry for all cases of GuC load failure on Gen9, not just for timeout. Bugzilla: https://bugs.freedesktop.org/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC 32.0.3

2019-03-29 Thread Patchwork
== Series Details == Series: GuC 32.0.3 URL : https://patchwork.freedesktop.org/series/58760/ State : warning == Summary == $ dim checkpatch origin/drm-tip 07625b512895 drm/i915/guc: Don't allow GuC submission on pre-Gen11 a79bbfbbcaeb drm/i915/guc: Simplify preparation of GuC parameter block

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GuC 32.0.3

2019-03-29 Thread Patchwork
== Series Details == Series: GuC 32.0.3 URL : https://patchwork.freedesktop.org/series/58760/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Don't allow GuC submission on pre-Gen11 Okay! Commit: drm/i915/guc: Simplify preparation of GuC

[Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-03-29 Thread John . C . Harrison
From: John Harrison With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that the request itself must be engine agnostic - any direct register writes must be relative to the engi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add immutable zpos plane properties

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: add immutable zpos plane properties URL : https://patchwork.freedesktop.org/series/58761/ State : warning == Summary == $ dim checkpatch origin/drm-tip a8460dd85471 drm/i915: add immutable zpos plane properties -:75: WARNING:NO_AUTHOR_SIGN_OFF: Missing Si

[Intel-gfx] ✗ Fi.CI.BAT: failure for GuC 32.0.3

2019-03-29 Thread Patchwork
== Series Details == Series: GuC 32.0.3 URL : https://patchwork.freedesktop.org/series/58760/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5840 -> Patchwork_12637 Summary --- **FAILURE** Serious unknown changes c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add immutable zpos plane properties

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: add immutable zpos plane properties URL : https://patchwork.freedesktop.org/series/58761/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5840 -> Patchwork_12638 Summary --- **FAI

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GuC 32.0.3

2019-03-29 Thread Chris Wilson
Quoting Patchwork (2019-03-30 00:34:48) > Suppressed > > The following results come from untrusted machines, tests, or statuses. > They do not affect the overall result. > > * igt@gem_exec_gttfill@basic: > - {fi-icl-guc}: NOTRUN -> SKIP What CI doesn't say is that in th

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Retry GuC load for all load failures (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Retry GuC load for all load failures (rev2) URL : https://patchwork.freedesktop.org/series/58758/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840 -> Patchwork_12639 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine relative MMIO (rev3)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Engine relative MMIO (rev3) URL : https://patchwork.freedesktop.org/series/57117/ State : warning == Summary == $ dim checkpatch origin/drm-tip a3f3b4a23cc5 drm/i915: Engine relative MMIO -:89: ERROR:SPACING: space prohibited after that open parenthesis '

[Intel-gfx] [PATCH v5 3/3] drm/i915/icl: Fix clockgating issue when using scalers

2019-03-29 Thread Radhakrishna Sripada
Fixes the clock-gating issue when pipe scaling is enabled. (Lineage #2006604312) V2: Fix typo in headline(Chris) Handle the non double buffered nature of the register(Ville) V3: Fix checkpatch warning. BAT failure for V2 on gen3 looks unrelated. V4: Split the icl and skl wa's(Ville) V5: Split

[Intel-gfx] [PATCH v5 2/3] drm/i915: Fix the inconsistent RMW in WA 827

2019-03-29 Thread Radhakrishna Sripada
RMW is used only in the disable path. Using it in enable path for consistency. Suggested-by: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH v5 1/3] drm/i915: Rename skl_wa_clkgating to the actual WA

2019-03-29 Thread Radhakrishna Sripada
No functional change. Renaming the function to reflect the specific WA. Suggested-by: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Engine relative MMIO (rev3)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Engine relative MMIO (rev3) URL : https://patchwork.freedesktop.org/series/57117/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840 -> Patchwork_12640 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Retry GuC load for all load failures URL : https://patchwork.freedesktop.org/series/58758/ State : success == Summary == CI Bug Log - changes from CI_DRM_5839_full -> Patchwork_12636_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev5)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix clockgating issue when using scalars (rev5) URL : https://patchwork.freedesktop.org/series/58081/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840 -> Patchwork_12641 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Retry GuC load for all load failures (rev2) URL : https://patchwork.freedesktop.org/series/58758/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840_full -> Patchwork_12639_full Su

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Engine relative MMIO (rev3)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Engine relative MMIO (rev3) URL : https://patchwork.freedesktop.org/series/57117/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840_full -> Patchwork_12640_full Summary --- **S

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev5)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix clockgating issue when using scalars (rev5) URL : https://patchwork.freedesktop.org/series/58081/ State : success == Summary == CI Bug Log - changes from CI_DRM_5840_full -> Patchwork_12641_full

Re: [Intel-gfx] [PATCH v4 4/8] drm/i915: vgpu context submission pv optimization

2019-03-29 Thread Chris Wilson
Quoting Xiaolin Zhang (2019-03-29 13:32:40) > It is performance optimization to override the actual submisison backend > in order to eliminate execlists csb process and reduce mmio trap numbers > for workload submission without contextswith interrupt by talking with > GVT via PV submisison notifica

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Finish the GAMMA_LUT stuff

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Finish the GAMMA_LUT stuff URL : https://patchwork.freedesktop.org/series/58698/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5832_full -> Patchwork_12623_full Summary --- **FA

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev5)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev5) URL : https://patchwork.freedesktop.org/series/58052/ State : success == Summary == CI Bug Log - changes from CI_DRM_5832_full -> Patchwork_12624_full

Re: [Intel-gfx] [PATCH] drm/i915: adding state checker for gamma lut values

2019-03-29 Thread Jani Nikula
On Thu, 28 Mar 2019, Matt Roper wrote: > I agree with Jani's feedback and have a couple other comments inline below. Thanks Matt, good stuff here. One naming note below. > What does the "internal" in this name refer to? I think just something > like i9xx_get_gamma_config() would be sufficient >

Re: [Intel-gfx] [PATCH 0/4] Device id consolidation

2019-03-29 Thread Tvrtko Ursulin
On 28/03/2019 09:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-28 09:23:24) On 26/03/2019 07:40, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Series removes device id checks from i915_drv.h macros and consolidates them to i915_pciids.h as the main "database", while making intel_devi

[Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Daniel Vetter
Interpreting it as a 0.16 fixed point means we can't accurately represent 1.0. Which is one of the values we really should be able to represent. Since most (all?) luts have lower precision this will only affect rounding of 0x. Cc: Uma Shankar Cc: Ville Syrjälä Cc: Shashank Sharma Cc: "Kuma

Re: [Intel-gfx] [PATCH v8 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-29 Thread Jani Nikula
On Wed, 27 Mar 2019, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Concept of a sub-platform already exist in our code (like ULX and ULT > platform variants and similar),implemented via the macros which check a > list of device ids to determine a match. > > With this patch we consolidate devic

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block

2019-03-29 Thread Chris Wilson
We may use HW semaphores to schedule nearly-ready work such that they are already spinning on the GPU waiting for the completion on another engine. However, we don't want for that spinning task to actually block any real work should it be scheduled. v2: No typeof autos v3: Don't cheat, check gen8

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Add 10bit LUT for ilk/snb

2019-03-29 Thread Maarten Lankhorst
Op 28-03-2019 om 22:05 schreef Ville Syrjala: > From: Ville Syrjälä > > Plop in support for 10bit LUT on ilk/snb. > > There is no split gamma mode on these platforms, so we have > to choose between degamma and gamma. That could be a runtime choice > but for now let's just advertize the gamma as ha

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Patchwork
== Series Details == Series: drm/gamma: Clarify gamma lut uapi URL : https://patchwork.freedesktop.org/series/58718/ State : success == Summary == CI Bug Log - changes from CI_DRM_5835 -> Patchwork_12626 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Don't use split gamma when we don't have to

2019-03-29 Thread Ville Syrjälä
On Thu, Mar 28, 2019 at 05:16:03PM -0700, Matt Roper wrote: > On Thu, Mar 28, 2019 at 11:05:01PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Using the split gamma mode when we don't have to has the annoying > > requirement of loading a linear LUT to the unused half. Instead > > le

Re: [Intel-gfx] RMW considered harmful (was: Re: [PATCH 2/2] drm/i915/icl: Enable TRANSCODER PORT SYNC for tiled displays across separate ports)

2019-03-29 Thread Jani Nikula
On Thu, 28 Mar 2019, Manasi Navare wrote: > On Thu, Mar 28, 2019 at 11:18:56AM +0200, Jani Nikula wrote: >> On Fri, 22 Mar 2019, Manasi Navare wrote: >> > On Fri, Mar 22, 2019 at 09:28:01PM +0200, Jani Nikula wrote: >> >> On Fri, 22 Mar 2019, Ville Syrjälä wrote: >> >> > On Fri, Mar 22, 2019 at

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Finish the GAMMA_LUT stuff

2019-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2019 at 08:34:03AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Finish the GAMMA_LUT stuff > URL : https://patchwork.freedesktop.org/series/58698/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5832_full -> Patchwork_12623_full

Re: [Intel-gfx] [v6 02/13] drm: Parse HDR metadata info from EDID

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: HDR metadata block is introduced in CEA-861.3 spec. Parsing the same to get the panel's HDR metadata. v2: Rebase and added Ville's POC changes to the patch. v3: No Change v4: Addressed Shashank's review comments Signed-off-by: Uma Shankar --- drive

[Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-03-29 Thread Masahiro Yamada
Currently, the Kbuild core manipulates header search paths in a crazy way [1]. To fix this mess, I want all Makefiles to add explicit $(srctree)/ to the search paths in the srctree. Some Makefiles are already written in that way, but not all. The goal of this work is to make the notation consisten

Re: [Intel-gfx] [v6 07/13] drm/i915: Write HDR infoframe and send to panel

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: Enable writing of HDR metadata infoframe to panel. The data will be provid by usersapace compositors, based on blending policies and passsed to driver through a blob property. v2: Rebase v3: Fixed a warning message v4: Addressed Shashank's review comme

Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-03-29 Thread james qian wang (Arm Technology China)
On Fri, Mar 29, 2019 at 08:32:41PM +0900, Masahiro Yamada wrote: > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are already written in > t

Re: [Intel-gfx] [PATCH v8 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-29 Thread Tvrtko Ursulin
On 29/03/2019 09:54, Jani Nikula wrote: On Wed, 27 Mar 2019, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With

Re: [Intel-gfx] [v6 12/13] drm/i915: Set Infoframe for non modeset case for HDR

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: HDR metadata requires a infoframe to be set. Due to fastset, full modeset is not performed hence adding it to update_pipe to handle that. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_ddi.c | 13 + 1 file changed, 13 insertions

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: prefix header search paths with $(srctree)/ (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: drm: prefix header search paths with $(srctree)/ (rev2) URL : https://patchwork.freedesktop.org/series/56020/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: prefix header search paths with $(srctree)/ - +./arch/x86/inc

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: move the edram detection out of uncore init

2019-03-29 Thread Chris Wilson
Quoting Patchwork (2019-03-29 05:40:25) > == Series Details == > > Series: drm/i915: move the edram detection out of uncore init > URL : https://patchwork.freedesktop.org/series/58684/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_5831_full -> Patchwork_12621_full >

Re: [Intel-gfx] [v6 13/13] video/hdmi: Add const variants for drm infoframe

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: Added the const version of infoframe for DRM metadata for HDR. Signed-off-by: Uma Shankar --- drivers/video/hdmi.c | 63 ++-- include/linux/hdmi.h | 5 + 2 files changed, 66 insertions(+), 2 delet

[Intel-gfx] [PATCH 1/2] drm/i915: Fix GCMAX color register programming

2019-03-29 Thread Uma Shankar
GC MAX register is used to program values from 1.0 to less than 3.0. A different register was used instead of the intended one. Fixed the same. Currently limiting it to 1.0 due to ABI limitations. Reported-by: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_color.c | 22

[Intel-gfx] [PATCH 0/2] Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Uma Shankar
Register offsets used to program GC max were not correct. This series fixes the same, also limits the values to accurately clamp at 1.0. Also added support to program EXT2 GC Max needed for values from 3.0 to 7.0. Limiting it again to 1.0 due to ABI limitations. Uma Shankar (2): drm/i915: Fix GC

[Intel-gfx] [PATCH 2/2] drm/i915: Program EXT2 GC MAX registers

2019-03-29 Thread Uma Shankar
EXT2 GC MAX registers are introduced from Gen10+ to program values from 3.0 to 7.0. Enabled the same, but currently limiting it to 1.0 as userspace ABI is limited at that currently. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h| 1 + drivers/gpu/drm/i915/intel_color.c | 28

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Don't use split gamma when we don't have to

2019-03-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, March 29, 2019 4:17 PM >To: Roper, Matthew D >Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma >Subject: Re: [PATCH 2/6] drm/i915: Don't use split gamma when we don't have to > >On Thu, Mar 2

Re: [Intel-gfx] [v6 10/13] drm/i915: Enable infoframes on GLK+ for HDR

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: From: Ville Syrjälä This patch enables infoframes on GLK+ to be used to send HDR metadata to HDMI sink. v2: Addressed Shashank's review comment. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/i915_reg.h | 4 +++

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Patchwork
== Series Details == Series: drm/gamma: Clarify gamma lut uapi URL : https://patchwork.freedesktop.org/series/58718/ State : success == Summary == CI Bug Log - changes from CI_DRM_5835_full -> Patchwork_12626_full Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Patchwork
== Series Details == Series: Fixed GC MAX register programming for gamma luts URL : https://patchwork.freedesktop.org/series/58734/ State : warning == Summary == $ dim checkpatch origin/drm-tip ecab4c425422 drm/i915: Fix GCMAX color register programming ca881c02da68 drm/i915: Program EXT2 GC M

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: prefix header search paths with $(srctree)/ (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: drm: prefix header search paths with $(srctree)/ (rev2) URL : https://patchwork.freedesktop.org/series/56020/ State : success == Summary == CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12627 Summary --

Re: [Intel-gfx] [v6 11/13] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-03-29 Thread Sharma, Shashank
On 3/20/2019 4:18 PM, Uma Shankar wrote: This patch enables modeset whenever HDR metadata needs to be updated to sink. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_atomic.c | 15 ++- drivers/gpu/drm/i915/intel_hdmi.c | 4 2 fil

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Patchwork
== Series Details == Series: Fixed GC MAX register programming for gamma luts URL : https://patchwork.freedesktop.org/series/58734/ State : success == Summary == CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12628 Summary --- **

Re: [Intel-gfx] [PATCH v8 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-29 Thread Jani Nikula
On Fri, 29 Mar 2019, Tvrtko Ursulin wrote: > On 29/03/2019 09:54, Jani Nikula wrote: >> On Wed, 27 Mar 2019, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> Concept of a sub-platform already exist in our code (like ULX and ULT >>> platform variants and similar),implemented via the macros

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix GCMAX color register programming

2019-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2019 at 06:19:18PM +0530, Uma Shankar wrote: > GC MAX register is used to program values from 1.0 to > less than 3.0. A different register was used instead of > the intended one. Fixed the same. > > Currently limiting it to 1.0 due to ABI limitations. > > Reported-by: Ville Syrjäl

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Program EXT2 GC MAX registers

2019-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2019 at 06:19:19PM +0530, Uma Shankar wrote: > EXT2 GC MAX registers are introduced from Gen10+ to > program values from 3.0 to 7.0. Enabled the same, but > currently limiting it to 1.0 as userspace ABI is limited > at that currently. > > Signed-off-by: Uma Shankar > --- > driver

[Intel-gfx] [PATCH] drm/i915/execlists: Enable coarse preemption boundaries for gen8

2019-03-29 Thread Chris Wilson
When we introduced preemption, we chose to keep it disabled for gen8 as supporting preemption inside GPGPU user batches required various w/a in userspace. Since then, the desire to preempt long queues of requests between batches (e.g. within busywaiting semaphores) has grown. So allow arbitration w

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Don't use split gamma when we don't have to

2019-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2019 at 12:47:02PM +0200, Ville Syrjälä wrote: > On Thu, Mar 28, 2019 at 05:16:03PM -0700, Matt Roper wrote: > > On Thu, Mar 28, 2019 at 11:05:01PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Using the split gamma mode when we don't have to has the annoying >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix GCMAX color register programming

2019-03-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, March 29, 2019 6:40 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, >Maarten >Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix GCMAX color register

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Program EXT2 GC MAX registers

2019-03-29 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, March 29, 2019 6:41 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, >Maarten >Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Program EXT2 GC MAX regist

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Enable coarse preemption boundaries for gen8

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Enable coarse preemption boundaries for gen8 URL : https://patchwork.freedesktop.org/series/58738/ State : warning == Summary == $ dim checkpatch origin/drm-tip 678a3d72d2b3 drm/i915/execlists: Enable coarse preemption boundaries for gen8 -:21:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/execlists: Enable coarse preemption boundaries for gen8

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Enable coarse preemption boundaries for gen8 URL : https://patchwork.freedesktop.org/series/58738/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Enable coarse preemption boundaries f

[Intel-gfx] [v2 1/2] drm/i915: Fix GCMAX color register programming

2019-03-29 Thread Uma Shankar
GC MAX register is used to program values from 1.0 to less than 3.0. A different register was used instead of the intended one. Fixed the same. Currently limiting it to 1.0 due to ABI limitations. v2: Updated the 1.0 programming and aligned as per GLK, based on Ville's feedback. Reported-by: Vil

[Intel-gfx] [v2 2/2] drm/i915: Program EXT2 GC MAX registers

2019-03-29 Thread Uma Shankar
EXT2 GC MAX registers are introduced from Gen10+ to program values from 3.0 to 7.0. Enabled the same, but currently limiting it to 1.0 as userspace ABI is limited at that currently. v2: Updated the 1.0 programming and aligned as per GLK, also added GLK along with GEN10+ check, as per Ville's feedb

[Intel-gfx] [v2 0/2] Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Uma Shankar
Register offsets used to program GC max were not correct. This series fixes the same, also limits the values to accurately clamp at 1.0. Also added support to program EXT2 GC Max needed for values from 3.0 to 7.0. Limiting it again to 1.0 due to ABI limitations. v2: Addressed Ville's review commen

Re: [Intel-gfx] [v6 12/13] drm/i915: Set Infoframe for non modeset case for HDR

2019-03-29 Thread Ville Syrjälä
On Wed, Mar 20, 2019 at 04:18:25PM +0530, Uma Shankar wrote: > HDR metadata requires a infoframe to be set. Due to fastset, > full modeset is not performed hence adding it to update_pipe > to handle that. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/intel_ddi.c | 13 +

[Intel-gfx] [PATCH v2 2/6] drm/i915: Don't use split gamma when we don't have to

2019-03-29 Thread Ville Syrjala
From: Ville Syrjälä Using the split gamma mode when we don't have to has the annoying requirement of loading a linear LUT to the unused half. Instead let's make life simpler by switching to the 10bit gamma mode and duplicating each entry. This also allows us to load the software gamma LUT into t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Enable coarse preemption boundaries for gen8

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Enable coarse preemption boundaries for gen8 URL : https://patchwork.freedesktop.org/series/58738/ State : success == Summary == CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12629 Summa

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Enable coarse preemption boundaries for gen8

2019-03-29 Thread Chris Wilson
Quoting Patchwork (2019-03-29 14:16:21) > == Series Details == > > Series: drm/i915/execlists: Enable coarse preemption boundaries for gen8 > URL : https://patchwork.freedesktop.org/series/58738/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12629 >

Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-03-29 Thread Liviu Dudau
On Fri, Mar 29, 2019 at 08:32:41PM +0900, Masahiro Yamada wrote: > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are already written in > t

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Liviu Dudau
On Fri, Mar 29, 2019 at 10:20:27AM +0100, Daniel Vetter wrote: > Interpreting it as a 0.16 fixed point means we can't accurately > represent 1.0. Which is one of the values we really should be able to > represent. > > Since most (all?) luts have lower precision this will only affect > rounding of

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Lionel Landwerlin
On 29/03/2019 09:20, Daniel Vetter wrote: Interpreting it as a 0.16 fixed point means we can't accurately represent 1.0. Which is one of the values we really should be able to represent. Since most (all?) luts have lower precision this will only affect rounding of 0x. Cc: Uma Shankar Cc: V

Re: [Intel-gfx] [v2 0/2] Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Lionel Landwerlin
On 29/03/2019 14:29, Uma Shankar wrote: Register offsets used to program GC max were not correct. This series fixes the same, also limits the values to accurately clamp at 1.0. Also added support to program EXT2 GC Max needed for values from 3.0 to 7.0. Limiting it again to 1.0 due to ABI limitat

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Ville Syrjälä
On Fri, Mar 29, 2019 at 10:20:27AM +0100, Daniel Vetter wrote: > Interpreting it as a 0.16 fixed point means we can't accurately > represent 1.0. Which is one of the values we really should be able to > represent. > > Since most (all?) luts have lower precision this will only affect > rounding of

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixed GC MAX register programming for gamma luts (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: Fixed GC MAX register programming for gamma luts (rev2) URL : https://patchwork.freedesktop.org/series/58734/ State : warning == Summary == $ dim checkpatch origin/drm-tip 88164253880f drm/i915: Fix GCMAX color register programming cad25ef86aee drm/i915: Program EX

Re: [Intel-gfx] [v2 0/2] Fixed GC MAX register programming for gamma luts

2019-03-29 Thread Shankar, Uma
>-Original Message- >From: Landwerlin, Lionel G >Sent: Friday, March 29, 2019 8:00 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten > >Subject: Re: [Intel-gfx] [v2 0/2] Fixed GC MAX register programming for gamma >luts > >On 29/03/2019 14:29

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixed GC MAX register programming for gamma luts (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: Fixed GC MAX register programming for gamma luts (rev2) URL : https://patchwork.freedesktop.org/series/58734/ State : success == Summary == CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12630 Summary --

Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

2019-03-29 Thread Randy Dunlap
On 3/28/19 8:18 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190328: > > The pidfd tree lost its build failures. > on x86_64, when # CONFIG_ACPI is not set/enabled: ld: drivers/gpu/drm/i915/intel_panel.o: in function `intel_backlight_device_register': intel_panel.c:(.text+0x2c49)

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Matt Roper
On Fri, Mar 29, 2019 at 10:20:27AM +0100, Daniel Vetter wrote: > Interpreting it as a 0.16 fixed point means we can't accurately > represent 1.0. Which is one of the values we really should be able to > represent. > > Since most (all?) luts have lower precision this will only affect > rounding of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Finish the GAMMA_LUT stuff (rev2)

2019-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Finish the GAMMA_LUT stuff (rev2) URL : https://patchwork.freedesktop.org/series/58698/ State : success == Summary == CI Bug Log - changes from CI_DRM_5837 -> Patchwork_12631 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH v4 4/8] drm/i915: vgpu context submission pv optimization

2019-03-29 Thread Chris Wilson
Quoting Xiaolin Zhang (2019-03-29 13:32:40) > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 2f78829..28e8ee0 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -37,6 +37,7 @@ > #include "i915_drv.h" > #include "i915

[Intel-gfx] [PATCH] drm/i915: Move the decision to use the breadcrumb tasklet to the backend

2019-03-29 Thread Chris Wilson
Use the engine->flags to store whether we want to kick the submission tasklet on receipt of a breadcrumb interrupt, so that this decision can be made by the submission backend and not dependent on a limited feature test within the interrupt handler. This should make it easier to adapt different sub

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Philippe CORNU
On 3/29/19 10:20 AM, Daniel Vetter wrote: > Interpreting it as a 0.16 fixed point means we can't accurately > represent 1.0. Which is one of the values we really should be able to > represent. > > Since most (all?) luts have lower precision this will only affect > rounding of 0x. > > Cc: Um

Re: [Intel-gfx] [PATCH v4 0/8] i915 vgpu PV to improve vgpu performance

2019-03-29 Thread Chris Wilson
Quoting Xiaolin Zhang (2019-03-29 13:32:36) > To improve vgpu performance, it could implement some PV optimization > such as to reduce the mmio access trap numbers or eliminate certain piece > of HW emulation within guest driver to reduce vm exit/vm enter cost. Where's the CI for this patchset? Th

  1   2   >