[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain

2019-03-21 Thread Chris Wilson
32 is too many for the likes of kbl, and in order to insert that many requests into the ring requires us to declare the first few hung -- understandably a slow and unexpected process. Instead, measure the size of a singe requests and use that to estimate the upper bound on the chain length we can u

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Mark up preemption tests for hang detection

2019-03-21 Thread Chris Wilson
Use the igt_live_test framework for detecting whether an unwanted hang occurred during test execution, and report failure if it does. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 38 -- 1 file changed, 35 insertions(+), 3 deletions(-) diff --g

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3)

2019-03-21 Thread Saarinen, Jani
Finally, now need shards data ;). > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Patchwork > Sent: torstai 21. maaliskuuta 2019 8.34 > To: Ville Syrjala > Cc: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] ✓ Fi.CI.BAT: succe

[Intel-gfx] [PATCH] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. Secondary aspect of this is that we undo the arbitrary fetching and potential flushing of all pages for a set-domain(.w

Re: [Intel-gfx] [PATCH] drm/i915/ehl: All EHL ports are combo phys (v2)

2019-03-21 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Bob-Paauwe/drm-i915-ehl-All-EHL-ports-are-combo-phys-v2/20190321-145619 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x000-201911 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the

[Intel-gfx] [PATCH] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Dan Carpenter
The mock_context() function returns NULL on error, it doesn't return error pointers. Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") Signed-off-by: Dan Carpenter --- .../gpu/drm/i915/selftests/i915_gem_context.c | 4 +- drivers/staging/erofs/unzip_vle.c | 70 +

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain URL : https://patchwork.freedesktop.org/series/58323/ State : success == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12541 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915: Skip object locking around a no-op set-domain ioctl URL : https://patchwork.freedesktop.org/series/58325/ State : warning == Summary == $ dim checkpatch origin/drm-tip e968397bb2a0 drm/i915: Skip object locking around a no-op set-domain ioctl -:15: WARNIN

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Mika Kuoppala
Dan Carpenter writes: > The mock_context() function returns NULL on error, it doesn't return > error pointers. > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > Signed-off-by: Dan Carpenter > --- > .../gpu/drm/i915/selftests/i915_gem_context.c | 4 +- > drivers/stagi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915: Skip object locking around a no-op set-domain ioctl URL : https://patchwork.freedesktop.org/series/58325/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12542 Summary

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
Quoting Patchwork (2019-03-21 09:04:59) > == Series Details == > > Series: drm/i915: Skip object locking around a no-op set-domain ioctl > URL : https://patchwork.freedesktop.org/series/58325/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12542 > ==

Re: [Intel-gfx] [PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-21 Thread Maarten Lankhorst
Op 20-03-2019 om 19:22 schreef Sean Paul: > On Tue, Mar 19, 2019 at 01:17:02PM +0100, Maarten Lankhorst wrote: >> There has unfortunately been a conflict with the following 3 commits: >> >> commit e9961ab95af81b8d29054361cd5f0c575102cf87 >> Author: Ayan Kumar Halder >> Date: Fri Nov 9 17:21:12 2

Re: [Intel-gfx] [PATCH] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
Quoting Chris Wilson (2019-03-21 08:05:32) > If we are already in the desired write domain of a set-domain ioctl, > then there is nothing for us to do and we can quickly return back to > userspace, avoiding any lock contention. > > Secondary aspect of this is that we undo the arbitrary fetching an

[Intel-gfx] [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.

2019-03-21 Thread Maarten Lankhorst
Now that we can rotate 64 bpp formats, we need to add the rotation case. This wasn't caught by CI or me, because the rotated formats were skipping because the rotated watermarks exceeded the allocation limits. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 3 +++ 1 file c

[Intel-gfx] [PATCH 2/2] drm/i915: Reject Yf tiling for 8cpp formats

2019-03-21 Thread Maarten Lankhorst
This was missing in the original addition of those formats, but in PLANE_SIZE description it's mentioned that 8 cpp formats are not valid with Yf tiling. Reject this case properly. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 4 ++-- 1 file changed, 2 insertions(+),

[Intel-gfx] [PATCH] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. Secondary aspect of this is that we undo the arbitrary fetching and potential flushing of all pages for a set-domain(.w

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
Quoting Chris Wilson (2019-03-21 09:11:30) > Quoting Patchwork (2019-03-21 09:04:59) > > == Series Details == > > > > Series: drm/i915: Skip object locking around a no-op set-domain ioctl > > URL : https://patchwork.freedesktop.org/series/58325/ > > State : failure > > > > == Summary == > > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Dan Carpenter
On Thu, Mar 21, 2019 at 10:58:40AM +0200, Mika Kuoppala wrote: > Dan Carpenter writes: > > > The mock_context() function returns NULL on error, it doesn't return > > error pointers. > > > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > > Signed-off-by: Dan Carpenter >

[Intel-gfx] [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Dan Carpenter
The mock_context() function returns NULL on error, it doesn't return error pointers. Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") Signed-off-by: Dan Carpenter --- V2: I accidentally sent a bunch of unrelated stuff... diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() URL : https://patchwork.freedesktop.org/series/58337/ State : success == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12543 ===

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark up preemption tests for hang detection

2019-03-21 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-03-20 11:34:56) > Use the igt_live_test framework for detecting whether an unwanted hang > occurred during test execution, and report failure if it does. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-03-21 Thread Lisovskiy, Stanislav
On Wed, 2019-03-20 at 23:46 +0200, Ville Syrjala wrote: > +static void cnl_get_dram_timings(struct drm_i915_private *dev_priv, > +const struct dram_info *dram, > +struct intel_dram_timings *t) > +{ > + u32 val; > + > + if (

[Intel-gfx] [PATCH v3] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0

[Intel-gfx] [PATCH v4] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0

Re: [Intel-gfx] Time for execbuf3 ?

2019-03-21 Thread Joonas Lahtinen
Quoting Lionel Landwerlin (2019-03-19 18:39:52) > Hi all, > > There are couple of extensions coming up for our userspace drivers (anv/i965) > where we need to add additional parameters to execbuf : > > - VK_KHR_timeline_semaphore : supplying u64 points together with syncobjs > [1] > -

Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-21 Thread Jani Nikula
On Wed, 20 Mar 2019, Chris Wilson wrote: > gcc-4.8 and older dislike the use of __builtin_constant_p() within a > constant expression context, and so we must use the magical > __is_constexpr() instead. > > For example, with gcc-4.8.5: > ../drivers/gpu/drm/i915/i915_reg.h:167:27: error: first argum

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Mika Kuoppala
Dan Carpenter writes: > The mock_context() function returns NULL on error, it doesn't return > error pointers. > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > --- > V2: I accidentally sent a bunch of unrela

Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-21 Thread Chris Wilson
Quoting Jani Nikula (2019-03-21 09:50:25) > On Wed, 20 Mar 2019, Chris Wilson wrote: > > gcc-4.8 and older dislike the use of __builtin_constant_p() within a > > constant expression context, and so we must use the magical > > __is_constexpr() instead. > > > > For example, with gcc-4.8.5: > > ../dr

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Extract ilk_color_check()

2019-03-21 Thread Ville Syrjälä
On Wed, Mar 20, 2019 at 03:49:31PM -0700, Matt Roper wrote: > On Mon, Mar 18, 2019 at 06:13:15PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > With everything else moved out of the way only ilk+ > > remains using _intel_color_check(). Streamline the logic > > into ilk_color_check().

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark up preemption tests for hang detection

2019-03-21 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-03-21 09:32:46) > Quoting Chris Wilson (2019-03-20 11:34:56) > > Use the igt_live_test framework for detecting whether an unwanted hang > > occurred during test execution, and report failure if it does. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Joonas Lah

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reject Yf tiling for 8cpp formats

2019-03-21 Thread Ville Syrjälä
On Thu, Mar 21, 2019 at 10:15:46AM +0100, Maarten Lankhorst wrote: > This was missing in the original addition of those formats, but in > PLANE_SIZE description it's mentioned that 8 cpp formats are not > valid with Yf tiling. Reject this case properly. > > Signed-off-by: Maarten Lankhorst > ---

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.

2019-03-21 Thread Ville Syrjälä
On Thu, Mar 21, 2019 at 10:15:45AM +0100, Maarten Lankhorst wrote: > Now that we can rotate 64 bpp formats, we need to add the rotation case. > This wasn't caught by CI or me, because the rotated formats were skipping > because the rotated watermarks exceeded the allocation limits. > > Signed-off-

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-03-21 Thread Ville Syrjälä
On Thu, Mar 21, 2019 at 09:34:00AM +, Lisovskiy, Stanislav wrote: > On Wed, 2019-03-20 at 23:46 +0200, Ville Syrjala wrote: > > +static void cnl_get_dram_timings(struct drm_i915_private *dev_priv, > > +const struct dram_info *dram, > > +

[Intel-gfx] [PATCH v2 2/3] drm/i915: Remove redundant device id from IS_IRONLAKE_M macro

2019-03-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin IS_IRONLAKE_M can use the already defined intel_device_info.is_mobile for this platform, so remove the instance of Ironlake's mobile device id from the header file and replace it with an IS_MOBILE check. v2: * Improved commit text. (Chris) Signed-off-by: Tvrtko Ursulin Su

Re: [Intel-gfx] [v6 03/13] drm: Parse Colorimetry data block from EDID

2019-03-21 Thread Brian Starkey
Hi Uma, On Wed, Mar 20, 2019 at 04:18:16PM +0530, Uma Shankar wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. > While code which parses these parts (patches 2 and 3) out of EDID could be useful - it doesn't seem to actua

Re: [Intel-gfx] [v6 01/13] drm: Add HDR source metadata property

2019-03-21 Thread Brian Starkey
Hi Uma, On Wed, Mar 20, 2019 at 04:18:14PM +0530, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > v2: Rebase and modified the metadata structure elements > as per Ville's POC changes.

Re: [Intel-gfx] [v6 06/13] drm: Enable HDR infoframe support

2019-03-21 Thread Brian Starkey
On Wed, Mar 20, 2019 at 04:18:19PM +0530, Uma Shankar wrote: > Enable Dynamic Range and Mastering Infoframe for HDR > content, which is defined in CEA 861.3 spec. > > The metadata will be computed based on blending > policy in userspace compositors and passed as a connector > property blob to driv

Re: [Intel-gfx] [v6 05/13] drm: Implement HDR output metadata set and get property handling

2019-03-21 Thread Brian Starkey
Hi, On Wed, Mar 20, 2019 at 04:18:18PM +0530, Uma Shankar wrote: > This patch implements get() and set() functions for HDR output > metadata property.The blob data is received from userspace and > saved in connector state, the same is returned as blob in get > property call to userspace. > > v2:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reject Yf tiling for 8cpp formats

2019-03-21 Thread Maarten Lankhorst
Op 21-03-2019 om 11:27 schreef Ville Syrjälä: > On Thu, Mar 21, 2019 at 10:15:46AM +0100, Maarten Lankhorst wrote: >> This was missing in the original addition of those formats, but in >> PLANE_SIZE description it's mentioned that 8 cpp formats are not >> valid with Yf tiling. Reject this case prop

[Intel-gfx] [PATCH] drm/i915/guc: Support for extended GuC notification messages

2019-03-21 Thread Michal Wajdeczko
GuC may send notification messages with payload larger than single u32. Prepare driver to accept longer messages. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Vinay Belgaumkar Cc: Michal Winiarski Cc: Tomasz Lis --- drivers/gpu/drm/i915/intel_guc.c| 14 +++--- d

Re: [Intel-gfx] [v6 13/13] video/hdmi: Add const variants for drm infoframe

2019-03-21 Thread Brian Starkey
Hi, On Wed, Mar 20, 2019 at 04:18:26PM +0530, Uma Shankar wrote: > Added the const version of infoframe for DRM metadata > for HDR. > > Signed-off-by: Uma Shankar Unless there's a strong reason not to, I think this can be squashed into patch 6. > --- > drivers/video/hdmi.c | 63 > +++

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add missing scanline case for 8 cpp watermarks. URL : https://patchwork.freedesktop.org/series/58342/ State : success == Summary == CI Bug Log - changes from CI_DRM_5787 -> Patchwork_12544 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Skip object locking around a no-op set-domain ioctl (rev4)

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915: Skip object locking around a no-op set-domain ioctl (rev4) URL : https://patchwork.freedesktop.org/series/58325/ State : warning == Summary == $ dim checkpatch origin/drm-tip f18176be40dd drm/i915: Skip object locking around a no-op set-domain ioctl -:19:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() (rev2)

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() (rev2) URL : https://patchwork.freedesktop.org/series/58337/ State : success == Summary == CI Bug Log - changes from CI_DRM_5787 -> Patchwork_12545 ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.

2019-03-21 Thread Maarten Lankhorst
Op 21-03-2019 om 11:29 schreef Ville Syrjälä: > On Thu, Mar 21, 2019 at 10:15:45AM +0100, Maarten Lankhorst wrote: >> Now that we can rotate 64 bpp formats, we need to add the rotation case. >> This wasn't caught by CI or me, because the rotated formats were skipping >> because the rotated watermar

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip object locking around a no-op set-domain ioctl (rev4)

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915: Skip object locking around a no-op set-domain ioctl (rev4) URL : https://patchwork.freedesktop.org/series/58325/ State : success == Summary == CI Bug Log - changes from CI_DRM_5787 -> Patchwork_12546 S

[Intel-gfx] [PATCH 2/6] drm/i915: Pick the first mode from EDID as the fixed mode when there is no preferred mode

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä Some monitors apparently forget to mark any mode as preferred in the EDID. In this particular case we have a very generic looking ID "PNP Model 0 Serial Number 4" / "LVDS 800x600" so a specific quirk doesn't seem particularly wise. Also the quirk we have (EDID_QUIRK_FIRST_DETA

[Intel-gfx] [PATCH 3/6] drm/i915: Refactor VBT fixed mode handling

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä LVDS and eDP have essentially the same code for grabbing the fixed mode from VBT. Pull that code to a common location. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c| 11 ++- drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH 1/6] drm/i915: Refactor EDID fixed mode search

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä Both LVDS and eDP have the same code to look up the preferred mode from the connector probed_modes list. Move the code to a common location. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c| 13 +++-- drivers/gpu/drm/i915/intel_drv.h | 2 ++ d

[Intel-gfx] [PATCH 5/6] drm/i915: Stop hand rolling drm_mode_match()

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä Utilize drm_mode_match() instead of hand rolling it when looking for the DRRS downclock mode. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_panel.c | 49 +++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 6/6] drm/i915: Clean up EDID downclock mode lookup

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä Rename intel_find_panel_downclock() to intel_panel_edid_downclock_mode() to make it clear it's looking for the downclock mode in the EDID. And while at it polish the implementation a bit as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c| 4 +---

[Intel-gfx] [PATCH 4/6] drm/i915: Adjust DSI fixed mode handling

2019-03-21 Thread Ville Syrjala
From: Ville Syrjälä DSI has its own convoluted way of grabbing the fixed mode from the VBT. Change it to follow the path laid out by LVDS/eDP. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/icl_dsi.c | 14 ++ drivers/gpu/drm/i915/intel_dsi.h | 1 - drivers/gpu/drm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2)

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2) URL : https://patchwork.freedesktop.org/series/58123/ State : warning == Summary == $ dim checkpatch origin/drm-tip 777e1e26f8a9 drm/i915: Split Pineview device info int

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2)

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2) URL : https://patchwork.freedesktop.org/series/58123/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Split Pineview d

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier()

2019-03-21 Thread Chris Wilson
Quoting Mika Kuoppala (2019-03-21 10:01:13) > Dan Carpenter writes: > > > The mock_context() function returns NULL on error, it doesn't return > > error pointers. > > > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > > Signed-off-by: Dan Carpenter > > Reviewed-by: Mik

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3)

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3) URL : https://patchwork.freedesktop.org/series/58299/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5785_full -> Patchwork_12540_full ==

[Intel-gfx] [PATCH 1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Chris Wilson
When we return pages to the system, we ensure that they are marked as being in the CPU domain since any external access is uncontrolled and we must assume the worst. This means that we need to always flush the pages on acquisition if we need to use them on the GPU, and from the beginning have used

[Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl/dsi: Ungate clocks if gated

2019-03-21 Thread Kulkarni, Vandita
> -Original Message- > From: Shankar, Uma > Sent: Wednesday, March 20, 2019 5:19 PM > To: Kulkarni, Vandita ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani ; Chauhan, Madhav > > Subject: RE: [PATCH 1/2] drm/i915/icl/dsi: Ungate clocks if gated > > > > >-Original Message---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2)

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile (rev2) URL : https://patchwork.freedesktop.org/series/58123/ State : success == Summary == CI Bug Log - changes from CI_DRM_5787 -> Patchwork_12547

Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable sequence

2019-03-21 Thread Kulkarni, Vandita
> -Original Message- > From: Deak, Imre > Sent: Wednesday, March 20, 2019 4:38 PM > To: Kulkarni, Vandita > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable > sequence > > On Wed, Mar 20, 2019 at 03:38:59PM +05

Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable sequence

2019-03-21 Thread Kulkarni, Vandita
> -Original Message- > From: Shankar, Uma > Sent: Wednesday, March 20, 2019 5:32 PM > To: Deak, Imre ; Kulkarni, Vandita > > Cc: Nikula, Jani ; intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable > sequence > > > > >-Original

[Intel-gfx] [CI 1/4] drm/i915: Separate GEM context construction and registration to userspace

2019-03-21 Thread Chris Wilson
In later patches, it became apparent that userspace can see a partially constructed GEM context and begin using it before it was ready, to much hilarity. Close this window of opportunity by lifting the registration of the context with userspace (the insertion of the context into the filp's idr) to

[Intel-gfx] [CI 4/4] drm/i915: Stop storing the context name as the timeline name

2019-03-21 Thread Chris Wilson
The timeline->name is only used for convenience in pretty printing the i915_request.fence->ops->get_timeline_name() and it is just as convenient to pull it from the gem_context directly. The few instances of its use inside GEM_TRACE() has proven more of a nuisance than helpful, so not worth saving

[Intel-gfx] [CI 2/4] drm/i915: Introduce a mutex for file_priv->context_idr

2019-03-21 Thread Chris Wilson
Define a mutex for the exclusive use of interacting with the per-file context-idr, that was previously guarded by struct_mutex. This allows us to reduce the coverage of struct_mutex, with a view to removing the last bits coordinating GEM context later. (In the short term, we avoid taking struct_mut

[Intel-gfx] [CI 3/4] drm/i915: Stop storing ctx->user_handle

2019-03-21 Thread Chris Wilson
The user_handle need only be known by userspace for it to lookup the context via the idr; internally we have no use for it. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 5 ++-- drivers/gpu/drm/i915/i915_gem_context.c | 23 +++

Re: [Intel-gfx] Time for execbuf3 ?

2019-03-21 Thread Lionel Landwerlin
On 21/03/2019 09:46, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2019-03-19 18:39:52) Hi all, There are couple of extensions coming up for our userspace drivers (anv/i965) where we need to add additional parameters to execbuf : - VK_KHR_timeline_semaphore : supplying u64 points toge

Re: [Intel-gfx] Time for execbuf3 ?

2019-03-21 Thread Maarten Lankhorst
Op 19-03-2019 om 18:20 schreef Chris Wilson: > Quoting Lionel Landwerlin (2019-03-19 16:39:52) >> Hi all, >> >> There are couple of extensions coming up for our userspace drivers (anv/i965) >> where we need to add additional parameters to execbuf : >> >> - VK_KHR_timeline_semaphore : supplying

Re: [Intel-gfx] Time for execbuf3 ?

2019-03-21 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-03-21 14:08:39) > Mostly it's just about having the ability to extend it. > I can't really tell you up front what we're going to need until we do :) Yup. My takeaway is that the uAPI debugability is something that has never been taken seriously (-EINVAL!). And that

Re: [Intel-gfx] [PATCH 12/18] drm/i915: Allow userspace to clone contexts on creation

2019-03-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-20 13:13:45) > > On 19/03/2019 11:57, Chris Wilson wrote: > > A usecase arose out of handling context recovery in mesa, whereby they > > wish to recreate a context with fresh logical state but preserving all > > other details of the original. Currently, they create

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Expand subslice mask

2019-03-21 Thread Summers, Stuart
On Wed, 2019-03-20 at 11:48 -0700, Stuart Summers wrote: > Currently, the subslice_mask runtime parameter is stored as an > array of subslices per slice. Expand the subslice mask array to > better match what is presented to userspace through the > I915_QUERY_TOPOLOGY_INFO ioctl. The index into this

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Pick the first mode from EDID as the fixed mode when there is no preferred mode

2019-03-21 Thread Adam Jackson
On Thu, 2019-03-21 at 15:24 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Some monitors apparently forget to mark any mode as preferred in the > EDID. In this particular case we have a very generic looking ID > "PNP Model 0 Serial Number 4" / "LVDS 800x600" so a specific quirk > doesn't s

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Load balancing across a virtual engine

2019-03-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-20 15:59:14) > > On 19/03/2019 11:57, Chris Wilson wrote: > > static void execlists_dequeue(struct intel_engine_cs *engine) > > { > > struct intel_engine_execlists * const execlists = &engine->execlists; > > @@ -691,6 +805,37 @@ static void execlists_deque

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Support for extended GuC notification messages

2019-03-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Support for extended GuC notification messages URL : https://patchwork.freedesktop.org/series/58352/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5788 -> Patchwork_12548 Summary -

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Load balancing across a virtual engine

2019-03-21 Thread Tvrtko Ursulin
On 21/03/2019 15:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-20 15:59:14) On 19/03/2019 11:57, Chris Wilson wrote: static void execlists_dequeue(struct intel_engine_cs *engine) { struct intel_engine_execlists * const execlists = &engine->execlists; @@ -691,6 +805,37 @

Re: [Intel-gfx] [PATCH 12/18] drm/i915: Allow userspace to clone contexts on creation

2019-03-21 Thread Tvrtko Ursulin
On 21/03/2019 14:38, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-20 13:13:45) On 19/03/2019 11:57, Chris Wilson wrote: A usecase arose out of handling context recovery in mesa, whereby they wish to recreate a context with fresh logical state but preserving all other details of the ori

Re: [Intel-gfx] [PATCH 15/18] drm/i915: Load balancing across a virtual engine

2019-03-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-21 15:13:59) > > On 21/03/2019 15:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-03-20 15:59:14) > >> > >> On 19/03/2019 11:57, Chris Wilson wrote: > >>> +static void virtual_submission_tasklet(unsigned long data) > >>> +{ > >>> + struct virtual_engine

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58357/ State : failure == Summary == Applying: drm/i915: Flush pages on acquisition Using index info to reconstruct a base tree... M drivers/gpu/drm

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Refactor EDID fixed mode search

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Refactor EDID fixed mode search URL : https://patchwork.freedesktop.org/series/58356/ State : success == Summary == CI Bug Log - changes from CI_DRM_5788 -> Patchwork_12549 S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Chris Wilson
Quoting Patchwork (2019-03-21 15:37:25) > == Series Details == > > Series: series starting with [1/2] drm/i915: Flush pages on acquisition > URL : https://patchwork.freedesktop.org/series/58357/ > State : failure > > == Summary == > > Applying: drm/i915: Flush pages on acquisition > Using inde

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] drm/i915: Separate GEM context construction and registration to userspace

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Separate GEM context construction and registration to userspace URL : https://patchwork.freedesktop.org/series/58361/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Separat

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2019-03-21 Thread Imre Deak
On Thu, Mar 21, 2019 at 12:32:47AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on > glk/cnl when audio power is enabled > URL : https://patchwork.freedesktop.org/series/58273/ > State : failure > > == Summary == > > C

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] drm/i915: Separate GEM context construction and registration to userspace

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Separate GEM context construction and registration to userspace URL : https://patchwork.freedesktop.org/series/58361/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5788 -> Patchwork_12551 ===

[Intel-gfx] [PATCH 1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Chris Wilson
When we return pages to the system, we ensure that they are marked as being in the CPU domain since any external access is uncontrolled and we must assume the worst. This means that we need to always flush the pages on acquisition if we need to use them on the GPU, and from the beginning have used

[Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Chris Wilson
If we are already in the desired write domain of a set-domain ioctl, then there is nothing for us to do and we can quickly return back to userspace, avoiding any lock contention. By recognising that the write_domain is always a subset of the read_domains, and excluding the no-op case of requiring 0

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Skip object locking around a no-op set-domain ioctl

2019-03-21 Thread Matthew Auld
On Thu, 21 Mar 2019 at 13:43, Chris Wilson wrote: > > If we are already in the desired write domain of a set-domain ioctl, > then there is nothing for us to do and we can quickly return back to > userspace, avoiding any lock contention. By recognising that the > write_domain is always a subset of

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain URL : https://patchwork.freedesktop.org/series/58323/ State : success == Summary == CI Bug Log - changes from CI_DRM_5785_full -> Patchwork_12541_full =

[Intel-gfx] [PULL] drm-misc-next

2019-03-21 Thread Sean Paul
Hi Da.*, Here's the first 5.2 PR from -misc. There's a bit of everything in the PR, enjoy! drm-misc-next-2019-03-21: drm-misc-next for 5.2: UAPI Changes: - Add Colorspace connector property (Uma) - fourcc: Several new YUV formats from ARM (Brian & Ayan) - fourcc: Fix merge conflicts between new

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Refactor EDID fixed mode search

2019-03-21 Thread Chris Wilson
Quoting Ville Syrjala (2019-03-21 13:24:41) > From: Ville Syrjälä > > Both LVDS and eDP have the same code to look up the preferred mode > from the connector probed_modes list. Move the code to a common > location. > > Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson -Chris _

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Refactor VBT fixed mode handling

2019-03-21 Thread Chris Wilson
Quoting Ville Syrjala (2019-03-21 13:24:43) > From: Ville Syrjälä > > LVDS and eDP have essentially the same code for grabbing the > fixed mode from VBT. Pull that code to a common location. > > Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson -Chris _

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Clean up EDID downclock mode lookup

2019-03-21 Thread Chris Wilson
Quoting Ville Syrjala (2019-03-21 13:24:46) > From: Ville Syrjälä > > Rename intel_find_panel_downclock() to intel_panel_edid_downclock_mode() > to make it clear it's looking for the downclock mode in the EDID. > And while at it polish the implementation a bit as well. > > Signed-off-by: Ville S

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Stop hand rolling drm_mode_match()

2019-03-21 Thread Chris Wilson
Quoting Ville Syrjala (2019-03-21 13:24:45) > From: Ville Syrjälä > > Utilize drm_mode_match() instead of hand rolling it when > looking for the DRRS downclock mode. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_panel.c | 49 +++--- > 1 file change

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Adjust DSI fixed mode handling

2019-03-21 Thread Chris Wilson
Quoting Ville Syrjala (2019-03-21 13:24:44) > From: Ville Syrjälä > > DSI has its own convoluted way of grabbing the fixed mode from > the VBT. Change it to follow the path laid out by LVDS/eDP. That was scarier than the actual code changes. > Signed-off-by: Ville Syrjälä Reviewed-by: Chris W

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58367/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1808bbb9ff2 drm/i915: Flush pages on acquisition a231feabd20f drm/i915: Skip object

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Flush pages on acquisition

2019-03-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58367/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Flush pages on acquisition -drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Stop hand rolling drm_mode_match()

2019-03-21 Thread Ville Syrjälä
On Thu, Mar 21, 2019 at 05:23:30PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2019-03-21 13:24:45) > > From: Ville Syrjälä > > > > Utilize drm_mode_match() instead of hand rolling it when > > looking for the DRRS downclock mode. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers

[Intel-gfx] [PATCH] drm/i915/guc: GuC suspend path cleanup

2019-03-21 Thread Sujaritha Sundaresan
Adding a call to intel_uc_suspend in i915_gem_suspend, which is a common point for the suspend/resume and hibernate paths. This fixes an unbalanced call that causes issues with the CTB register/deregister. Cc: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Michal Wajdeczko Signed-off-by: Sujaritha

[Intel-gfx] [PATCH v1 1/1] drm/i915/sleftests: live_execlists subtest faster

2019-03-21 Thread Yokoyama, Caz
It took 35-120sec because some of engines hang up and reset. I guess too many requests are accumulated for all prime numbers up to 32 and detected as hangup. By adding wait, requests are processed on each prime number and not accumulated. The test runs for 8.5sec. Change-Id: I0d3732a202fef90d192fb

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915/sleftests: live_execlists subtest faster

2019-03-21 Thread Chris Wilson
Quoting Yokoyama, Caz (2019-03-21 17:38:21) > It took 35-120sec because some of engines hang up and reset. > I guess too many requests are accumulated for all > prime numbers up to 32 and detected as hangup. > By adding wait, requests are processed on each prime number and not > accumulated. The te

Re: [Intel-gfx] [PATCH] drm/i915/guc: GuC suspend path cleanup

2019-03-21 Thread Daniele Ceraolo Spurio
On 3/21/19 10:14 AM, Sujaritha Sundaresan wrote: Adding a call to intel_uc_suspend in i915_gem_suspend, which is a common point for the suspend/resume and hibernate paths. This fixes an unbalanced call that causes issues with the CTB register/deregister. Cc: Daniele Ceraolo Spurio Cc: Chris W

  1   2   3   >