[Intel-gfx] [PATCH] drm/i915/ehl: All EHL ports are combo phys (v2)

2019-03-20 Thread Bob Paauwe
Unlike ICL, all of the output ports are combo phys so just return true in intel_port_is_combophy for all EHL ports to indicate that. v2: Return false in intel_port_is_tc since no EHL ports are TC. (Jose) Cc: Jose Souza Signed-off-by: Bob Paauwe Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915/ehl: All EHL ports are combo phys (v2)

2019-03-20 Thread Souza, Jose
On Wed, 2019-03-20 at 14:15 -0700, Bob Paauwe wrote: > Unlike ICL, all of the output ports are combo phys so just return > true in intel_port_is_combophy for all EHL ports to indicate that. > > v2: Return false in intel_port_is_tc since no EHL ports are TC. > (Jose) Reviewed-by: José Roberto de S

[Intel-gfx] [PATCH 1/2] drm/i915: Turn dram_info.num_channels into a bitmask

2019-03-20 Thread Ville Syrjala
From: Ville Syrjälä We want to know out which channels are actually occupied so that later on we can read the memory timings from the right registers. To that end convert num_channels into a bitmask. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 28 +++-

[Intel-gfx] [PATCH 2/2] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-03-20 Thread Ville Syrjala
From: Ville Syrjälä ICL has so many planes that it can easily exceed the maximum effective memory bandwidth of the system. We must therefore check that we don't exceed that limit. The algorithm is very magic number heavy and lacks sufficient explanation for now. We also have no sane way to query

[Intel-gfx] [PATCH libdrm] intel: Add support for CML

2019-03-20 Thread Anusha
Add PCI IDS for CML. Sync the iDS with that of kernel. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- intel/i915_pciids.h | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/intel/i915_pciids.h b/intel/i915_pciids.h index d2fad7b0..3c960703 1

[Intel-gfx] [i-g-t] lib: Add PCI IDs for Comet Lake

2019-03-20 Thread Anusha
From: Anusha Srivatsa Sync PCI IDs with that of kernel. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- lib/i915_pciids.h | 28 +++- lib/intel_device_info.c | 2 ++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/lib/i915_pciids.h b/lib/i91

Re: [Intel-gfx] [i-g-t] lib: Add PCI IDs for Comet Lake

2019-03-20 Thread Souza, Jose
Please sync(copy) the whole file, there is other PCI id additions in kernel that are missed in here, the same for your lib drm patch. On Wed, 2019-03-20 at 15:00 -0700, Anusha wrote: > From: Anusha Srivatsa > > Sync PCI IDs with that of kernel. > > Cc: Lucas De Marchi > Signed-off-by: Anusha S

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Extract check_luts()

2019-03-20 Thread Matt Roper
On Wed, Mar 20, 2019 at 05:31:07PM +0200, Ville Syrjälä wrote: > On Wed, Mar 20, 2019 at 08:14:56AM -0700, Matt Roper wrote: > > On Wed, Mar 20, 2019 at 04:41:31PM +0200, Ville Syrjälä wrote: > > > On Tue, Mar 19, 2019 at 02:59:38PM -0700, Matt Roper wrote: > > > > On Mon, Mar 18, 2019 at 06:13:08P

[Intel-gfx] ✗ Fi.CI.BAT: failure for lib: Add PCI IDs for Comet Lake

2019-03-20 Thread Patchwork
== Series Details == Series: lib: Add PCI IDs for Comet Lake URL : https://patchwork.freedesktop.org/series/58302/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5784 -> IGTPW_2674 Summary --- **FAILURE** Serious u

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Extract ilk_color_check()

2019-03-20 Thread Matt Roper
On Mon, Mar 18, 2019 at 06:13:15PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > With everything else moved out of the way only ilk+ > remains using _intel_color_check(). Streamline the logic > into ilk_color_check(). > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Skip the linear degamma LUT load on ICL+

2019-03-20 Thread Matt Roper
On Mon, Mar 18, 2019 at 06:13:17PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Don't load the linear degamma LUT on ICL. The hardware no longer > has any silly linkages between the CSC enable and degamma LUT > enable so the degamma LUT is only needed when it's actually > enabled. > > A

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV

2019-03-20 Thread Matt Roper
On Mon, Mar 18, 2019 at 06:13:16PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We now bypass the legacy LUT when it's not needed, so > no point in filling it up with a linear LUT. > > Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_color.c |

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Extract bdw_color_check()

2019-03-20 Thread Matt Roper
On Mon, Mar 18, 2019 at 06:13:14PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Provide a separate .color_check() for BDW+ where we currently > provide the split gamma mode etc. > > Signed-off-by: Ville Syrjälä Patches #5-7: Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/int

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths URL : https://patchwork.freedesktop.org/series/58295/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4cfa03897df drm/i915: use intel_uncore in fw get/put internal

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths URL : https://patchwork.freedesktop.org/series/58295/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: use intel_uncore in fw ge

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/9] drm/i915/ehl: Add EHL platform info and PCI IDs (rev3)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/ehl: Add EHL platform info and PCI IDs (rev3) URL : https://patchwork.freedesktop.org/series/57959/ State : failure == Summary == Applying: drm/i915/ehl: Add EHL platform info and PCI IDs Using index info to reconstruct a base t

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths URL : https://patchwork.freedesktop.org/series/58295/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5784 -> Patchwork_12534 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim checkpatch origin/drm-tip cf425d8d7a31 drm/i915: Turn dram_info.num_channels into a bitmask 8d

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Turn dram_info.num_channels int

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Enable transition watermarks for glk (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Enable transition watermarks for glk (rev2) URL : https://patchwork.freedesktop.org/series/56859/ State : success == Summary == CI Bug Log - changes from CI_DRM_5784 -> Patchwork_12536 ==

[Intel-gfx] [PATCH i-g-t] i915/gem_sparseobject: Add sparse object IGT tests

2019-03-20 Thread Chris Wilson
From: "Venkata Sandeep, Dhanalakota" Sparse object is a proxy object that can link the pages from other objects. Typical use case are huge continuos framebuffer that is too big to handle scanout. Sparse object can used as any other regular object after the pages from source object are linked. Thi

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask URL : https://patchwork.freedesktop.org/series/58299/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5784 -> Patchwork_12537 ===

Re: [Intel-gfx] [PATCH 02/18] drm/i915: Flush pages on acquisition

2019-03-20 Thread Chris Wilson
Quoting Chris Wilson (2019-03-20 12:35:51) > The cost of the extra flushes is a worry, but not enough for me to be > concerned about. I think the convention that get_pages == coherent on > gpu improves quite a bit of our internal rummaging around and prevents > the ABI nightmare of mmap_gtt/mmap_of

Re: [Intel-gfx] [PATCH v2 09/10] drm/i915: add uncore flags

2019-03-20 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-03-19 18:35:42) > Save some uncore properties to avoid having to jump back to > dev_priv every time > > Signed-off-by: Daniele Ceraolo Spurio > Cc: Paulo Zanoni I wanted to push "always use flags" separately just to have a better look at whether we survived,

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled URL : https://patchwork.freedesktop.org/series/58273/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5781_full -> Patchwork_12531_full =

[Intel-gfx] [PATCH v2] drm/i915/icl: Fix clockgating issue when using scalers

2019-03-20 Thread Radhakrishna Sripada
Fixes the clock-gating issue when pipe scaling is enabled. (Lineage #2006604312) V2: Fix typo in headline(Chris) Handle the non double buffered nature of the register(Ville) Cc: Chris Wilson Cc: Ville Syrjala Cc: Rodrigo Vivi Cc: Aditya Swarup Signed-off-by: Radhakrishna Sripada --- dri

Re: [Intel-gfx] [i-g-t] lib: Add PCI IDs for Comet Lake

2019-03-20 Thread Lucas De Marchi
On Wed, Mar 20, 2019 at 03:26:54PM -0700, Jose Souza wrote: Please sync(copy) the whole file, there is other PCI id additions in kernel that are missed in here, the same for your lib drm patch. and the commit message should be that you are synchronizing the kernel header. See e.g. b2920f54 ("li

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Fix clockgating issue when using scalars (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix clockgating issue when using scalars (rev2) URL : https://patchwork.freedesktop.org/series/58081/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5e6d81755e1a drm/i915/icl: Fix clockgating issue when using scalers -:55: CHECK:PARENTH

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Fix clockgating issue when using scalars (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix clockgating issue when using scalars (rev2) URL : https://patchwork.freedesktop.org/series/58081/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12538 Summary

[Intel-gfx] [PULL] gvt-fixes

2019-03-20 Thread Zhenyu Wang
Hi, Sorry that I might miss 5.1-rc1 window as I was in full day event during this week. Here's re-generated gvt-fixes against drm-intel-fixes. This contains fixes for newer version of Windows driver, e.g fixing parser for MI_FLUSH_DW command and fixed windows font render error, with other stable

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2) URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim checkpatch origin/drm-tip f4885c7c00de drm/i915: Turn dram_info.num_channels into a bit

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2) URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Turn dram_info.num_chann

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev2) URL : https://patchwork.freedesktop.org/series/58299/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12539

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3) URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim checkpatch origin/drm-tip 77f4b2fd475a drm/i915: Turn dram_info.num_channels into a bit

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3) URL : https://patchwork.freedesktop.org/series/58299/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Turn dram_info.num_chann

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915: Enable transition watermarks for glk (rev2)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Enable transition watermarks for glk (rev2) URL : https://patchwork.freedesktop.org/series/56859/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5784_full -> Patchwork_12536_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3)

2019-03-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Turn dram_info.num_channels into a bitmask (rev3) URL : https://patchwork.freedesktop.org/series/58299/ State : success == Summary == CI Bug Log - changes from CI_DRM_5785 -> Patchwork_12540

<    1   2