Re: [Intel-gfx] [PATCH 11/22] drm/i915: Introduce a mutex for file_priv->context_idr

2019-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-18 16:28:35) > > On 18/03/2019 09:51, Chris Wilson wrote: > > Define a mutex for the exclusive use of interacting with the per-file > > context-idr, that was previously guarded by struct_mutex. This allows us > > to reduce the coverage of struct_mutex, with a view t

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Introduce a mutex for file_priv->context_idr

2019-03-18 Thread Tvrtko Ursulin
On 18/03/2019 16:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-18 16:28:35) On 18/03/2019 09:51, Chris Wilson wrote: Define a mutex for the exclusive use of interacting with the per-file context-idr, that was previously guarded by struct_mutex. This allows us to reduce the coverage

Re: [Intel-gfx] [PATCH 10/22] drm/i915: Separate GEM context construction and registration to userspace

2019-03-18 Thread Tvrtko Ursulin
On 18/03/2019 16:32, Chris Wilson wrote: Quoting Chris Wilson (2019-03-18 16:30:58) Quoting Tvrtko Ursulin (2019-03-18 16:22:12) On 18/03/2019 09:51, Chris Wilson wrote: +static int gem_context_register(struct i915_gem_context *ctx, + struct drm_i915_file_private

[Intel-gfx] Xorg "intel" driver uses DRI2 by default instead of DRI3 ?

2019-03-18 Thread bubbleguuum
Hi list, driver version used: 2.99.917+git8674.25c9a2fcc-2.1 Xorg: 1.20.4 Is there a reason why the "intel" Xorg driver uses DRI2 by default instead of DRI3 ? If you want DRI3 you need to use Option "DRI" "3". Using DRI2 cause problems with compositors such as compton, in partocular is causes

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-18 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 04:05:12PM -0700, Vanshidhar Konda wrote: > On Fri, Mar 15, 2019 at 02:43:46PM -0700, Rodrigo Vivi wrote: > > On Fri, Mar 15, 2019 at 02:39:25PM -0700, Rodrigo Vivi wrote: > > > On Fri, Mar 15, 2019 at 02:31:40PM -0700, Rodrigo Vivi wrote: > > > > On Fri, Mar 15, 2019 at 01:

[Intel-gfx] [PATCH 1/6] drm/i915: Reorder gen3/4 swizzle detection logic

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä g33/i964g/g45 are the exceptional cases when it comes to the swizzle detectiong. Let's reorder the code to handle them first and let everything else be handled by the else branch. This allows us to unset .is_mobile for the desktop PNV variant (which supposedly must follow the

[Intel-gfx] [PATCH 2/6] drm/i915: Introduce i9xx_has_pfit()

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä Make the code self-documenting by introducing i9xx_has_pfit(). Also make PNV an exceptional case so that we can unset .is_mobile for the desktop variant. Cc: Tvrtko Ursulin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 12 ++-- 1 file chan

[Intel-gfx] [PATCH 3/6] drm/i915: Introduce i9xx_has_pps()

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä Add a small helper to determine if we have the panel power sequencer or not. We'll make PNV an exceptional case so that we can unset .is_mobile for the desktop variant. Cc: Tvrtko Ursulin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 10 +-

[Intel-gfx] [PATCH 5/6] drm/i915: Use HPLLVCO_MOBILE for all PNVs

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä To allow unsetting .is_mobile for the desktop variant of PNV fix up the cdclk code to select the mobile HPLLVCO register for both PNV variants. Cc: Tvrtko Ursulin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_cdclk.c | 3 ++- 1 file changed, 2 insertions(+),

[Intel-gfx] [PATCH 4/6] drm/i915: Introduce i915_has_asle()

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä We want to allow the desktop PNV to not have .is_mobile set. To that end let's add a small helper to determine if the platform has the ASLE interrupt (or equivalent). Supposdely both PNV variants have it. Cc: Tvrtko Ursulin Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/

[Intel-gfx] [PATCH 6/6] drm/i915: Clean up gen2 DPLL readout

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä The current gen2 DPLL readout code: * assumes i845/i865 have LVDS which is not true * assumes only pipe B can drive LVDS (true, but makes the code appear a bit magical) * hard to parse in general Clean it up by checking for i85x (the only gen2 platform with LVDS) and reusin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915: Flush pages on acquisition

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58122/ State : warning == Summary == $ dim checkpatch origin/drm-tip db0c17ac314c drm/i915: Flush pages on acquisition 2f0c66c9e084 drm/i915: Move intel

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/22] drm/i915: Flush pages on acquisition

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58122/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Flush pages on acquisition -drivers/gpu/drm/i9

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/22] drm/i915: Flush pages on acquisition

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915: Flush pages on acquisition URL : https://patchwork.freedesktop.org/series/58122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12496 Summ

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Handle YUV subpixel support better

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Handle YUV subpixel support better URL : https://patchwork.freedesktop.org/series/58130/ State : warning == Summary == $ dim checkpatch origin/drm-tip 383e00c03163 drm/i915: Handle YUV subpixel support better -:7: WARNING:COMMIT_MESSAGE: Missing commit de

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Handle YUV subpixel support better

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Handle YUV subpixel support better URL : https://patchwork.freedesktop.org/series/58130/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Handle YUV subpixel support better +drivers/gpu/drm/i915/intel_spri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle YUV subpixel support better

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Handle YUV subpixel support better URL : https://patchwork.freedesktop.org/series/58130/ State : success == Summary == CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12497 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ensure minimum CDCLK requirement for audio

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure minimum CDCLK requirement for audio URL : https://patchwork.freedesktop.org/series/58132/ State : warning == Summary == $ dim checkpatch origin/drm-tip f5ea7a63eeb3 drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled -:60: CHECK:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Ensure minimum CDCLK requirement for audio

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure minimum CDCLK requirement for audio URL : https://patchwork.freedesktop.org/series/58132/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

Re: [Intel-gfx] [PATCH 13/17] drm/rockchip: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-18 Thread Heiko Stübner
Am Freitag, 1. März 2019, 13:56:23 CET schrieb Maarten Lankhorst: > Convert rockchip to using __drm_atomic_helper_crtc_reset(), instead of > writing its own version. Instead of open coding > destroy_state(), call it directly for freeing the old state. > > Signed-off-by: Maarten Lankhorst > Cc: Sa

Re: [Intel-gfx] [RFC 07/10] drm/i915: move regs pointer inside the uncore structure

2019-03-18 Thread Daniele Ceraolo Spurio
On 3/15/19 1:50 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-03-13 23:13:16) This will allow futher simplifications in the uncore handling. RFC: if we want to keep the pointer logically separate from the uncore, we could also move both the regs pointer and the uncore struct in

Re: [Intel-gfx] [PATCH] drm/i915: Handle YUV subpixel support better

2019-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2019 at 04:13:57PM +0100, Maarten Lankhorst wrote: > Op 18-03-2019 om 15:18 schreef Ville Syrjälä: > > On Mon, Mar 18, 2019 at 03:07:18PM +0100, Maarten Lankhorst wrote: > >> Signed-off-by: Maarten Lankhorst > >> --- > >> drivers/gpu/drm/i915/intel_sprite.c | 29 ++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ensure minimum CDCLK requirement for audio

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure minimum CDCLK requirement for audio URL : https://patchwork.freedesktop.org/series/58132/ State : success == Summary == CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12498 Summary ---

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915: Skip modeset for cdclk changes if possible

2019-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2019 at 04:34:35PM +0200, Imre Deak wrote: > @@ -2137,6 +2194,44 @@ void intel_set_cdclk(struct drm_i915_private *dev_priv, > } > } > > +/** > + * intel_set_cdclk_pre_plane_update - Push the CDCLK state to the hardware > + * @dev_priv: i915 device > + * @cdclk_state: new CD

Re: [Intel-gfx] [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-18 Thread Lucas De Marchi
On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote: On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote: The caller already knows what platform that is and what register should be used. Instead of keep adding if/else chains on a leaf functions, let the caller pass the regi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3)

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3) URL : https://patchwork.freedesktop.org/series/58052/ State : warning == Summary == $ dim checkpatch origin/drm-tip 443b208a11ff drm/i915: Move intel_engine_mask_t around for use by

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3)

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3) URL : https://patchwork.freedesktop.org/series/58052/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Move intel_engine_mask_t aroun

Re: [Intel-gfx] [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote: > On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote: > >On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote: > >> The caller already knows what platform that is and what register should > >> be used. Instead of

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-18 Thread Lucas De Marchi
On Mon, Mar 18, 2019 at 07:09:59AM +, Tvrtko Ursulin wrote: On 15/03/2019 18:40, Lucas De Marchi wrote: On Fri, Mar 15, 2019 at 05:31:05PM +, Tvrtko Ursulin wrote: On 15/03/2019 17:12, Lucas De Marchi wrote: On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: From: Tvrtk

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3)

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3) URL : https://patchwork.freedesktop.org/series/58052/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12499 ==

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915: Skip modeset for cdclk changes if possible

2019-03-18 Thread Imre Deak
On Mon, Mar 18, 2019 at 08:37:33PM +0200, Ville Syrjälä wrote: > On Mon, Mar 18, 2019 at 04:34:35PM +0200, Imre Deak wrote: > > @@ -2137,6 +2194,44 @@ void intel_set_cdclk(struct drm_i915_private > > *dev_priv, > > } > > } > > > > +/** > > + * intel_set_cdclk_pre_plane_update - Push the CDC

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stick to kernel fixed size types

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: stick to kernel fixed size types URL : https://patchwork.freedesktop.org/series/58135/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12500 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH] drm/i915/psr: remove drmP.h include that crept in

2019-03-18 Thread Souza, Jose
On Mon, 2019-03-18 at 18:04 +0200, Jani Nikula wrote: > We've been free of deprecated drmP.h includes for a while, but one > crept > in. Fend it off. Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_psr.c | 1 - >

[Intel-gfx] [PATCH 2/2] drm/i915/cml: Introduce Comet Lake PCH

2019-03-18 Thread Anusha
From: Anusha Srivatsa Comet Lake PCH is based off of Cannon Point(CNP). Add PCI ID for Comet Lake PCH. v2: Code cleanup (DK) v3: Comment cleanup (Jani) Cc: Jani Nikula Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 1/2] drm/i915/cml: Add CML PCI IDS

2019-03-18 Thread Anusha
From: Anusha Srivatsa Comet Lake is a Intel Processor containing Gen9 Intel HD Graphics. This patch adds the initial set of PCI IDs. Comet Lake comes off of Coffee Lake - adding the IDs to Coffee Lake ID list. More support and features will be in the patches that follow. v2: Split IDs according

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check()

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Clean up intel_color_check() URL : https://patchwork.freedesktop.org/series/58137/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Extract check_luts() Okay! Commit: drm/i915: Turn intel_color_check() in

[Intel-gfx] [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä Make things look a bit nicer by passing dev_priv to intel_is_dual_link_lvds(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 28 drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_lvds.c| 4 ++

[Intel-gfx] [PATCH 1/3] drm/i915: Add some missing curly braces

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä Sprinkle some curly braces in accordance with the coding style. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: remove drmP.h include that crept in

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915/psr: remove drmP.h include that crept in URL : https://patchwork.freedesktop.org/series/58136/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12501 Summary --- *

[Intel-gfx] [PATCH 2/3] drm/i915: Polish intel_get_lvds_encoder()

2019-03-18 Thread Ville Syrjala
From: Ville Syrjälä Pass dev_priv to intel_get_lvds_encoder() and polish the implementation a bit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_lvds.c | 13 +++-- 3 files changed, 9 ins

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Polish intel_get_lvds_encoder()

2019-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2019 at 10:26:52PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Pass dev_priv to intel_get_lvds_encoder() and polish the > implementation a bit. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_dp.c | 2 +- > drivers/g

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add some missing curly braces

2019-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2019 at 10:26:51PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Sprinkle some curly braces in accordance with the coding style. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 11 +++ > 1 file changed

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()

2019-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2019 at 10:26:53PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Make things look a bit nicer by passing dev_priv to > intel_is_dual_link_lvds(). > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 28 ++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clean up intel_color_check()

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Clean up intel_color_check() URL : https://patchwork.freedesktop.org/series/58137/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12502 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()

2019-03-18 Thread Michal Wajdeczko
Make things look a bit nicer by passing dev_priv to In other places we are changing naming from dev_priv to i915. Can we do the same here ? ~Michal ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listin

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Split Pineview device info into desktop and mobile URL : https://patchwork.freedesktop.org/series/58123/ State : success == Summary == CI Bug Log - changes from CI_DRM_5765_full -> Patchwork_12495_full =

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()

2019-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2019 at 09:45:16PM +0100, Michal Wajdeczko wrote: > > Make things look a bit nicer by passing dev_priv to > > In other places we are changing naming from dev_priv to i915. > Can we do the same here ? The display code uses dev_priv quite consistently,. We could go for i915 I suppos

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Introduce a mutex for file_priv->context_idr

2019-03-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-18 16:45:41) > > On 18/03/2019 16:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-03-18 16:28:35) > >> > >> On 18/03/2019 09:51, Chris Wilson wrote: > >>> Define a mutex for the exclusive use of interacting with the per-file > >>> context-idr, that was prev

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-18 Thread Sripada, Radhakrishna
On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote: > Scalars as opposed to vector instructions? EU clock gating issues > with > certain shaders? > Hi Chris, The scalers mentioned for this WA around are specific to display scaling. They are not related to EU clock gating. -Radhakrishna(RK) Sr

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-18 Thread Chris Wilson
Quoting Sripada, Radhakrishna (2019-03-18 21:19:29) > On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote: > > Scalars as opposed to vector instructions? EU clock gating issues > > with > > certain shaders? > > > Hi Chris, > > The scalers mentioned for this WA around are specific to display > s

[Intel-gfx] [CI 1/2] drm/i915: Lock the gem_context->active_list while dropping the link

2019-03-18 Thread Chris Wilson
On unpinning the intel_context, we remove it from the active list inside the GEM context. This list is supposed to be guarded by the GEM context mutex, so remember to take it! Fixes: 7e3d9a59410d ("drm/i915: Track active engines within a context") Signed-off-by: Chris Wilson Reviewed-by: Tvrtko U

[Intel-gfx] [CI 2/2] drm/i915: Hold a reference to the active HW context

2019-03-18 Thread Chris Wilson
For virtual engines, we need to keep the HW context alive while it remains in use. For regular HW contexts, they are created and kept alive until the end of the GEM context. For simplicity, generalise the requirements and keep an active reference to each HW context. Signed-off-by: Chris Wilson Re

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

2019-03-18 Thread Rodrigo Siqueira
On 03/18, Ville Syrjälä wrote: > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > The kms_flip test relies on VBlank support, and this situation may > > exclude some virtual drivers to take advantage of this set of tests. > > This commit adds a mechanism that checks if a module

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

2019-03-18 Thread Chris Wilson
Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > On 03/18, Ville Syrjälä wrote: > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > > The kms_flip test relies on VBlank support, and this situation may > > > exclude some virtual drivers to take advantage of this set of tests. >

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

2019-03-18 Thread Rodrigo Siqueira
On 03/18, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > > On 03/18, Ville Syrjälä wrote: > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > > > The kms_flip test relies on VBlank support, and this situation may > > > > exclude some virtual drivers t

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

2019-03-18 Thread Chris Wilson
Quoting Rodrigo Siqueira (2019-03-18 21:53:42) > On 03/18, Chris Wilson wrote: > > Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > > > On 03/18, Ville Syrjälä wrote: > > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > > > > The kms_flip test relies on VBlank support, and

Re: [Intel-gfx] [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-18 Thread Lucas De Marchi
On Mon, Mar 18, 2019 at 08:53:23PM +0200, Ville Syrjälä wrote: On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote: On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote: >On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote: >> The caller already knows what platfo

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support

2019-03-18 Thread Rodrigo Siqueira
On 03/18, Liviu Dudau wrote: > On Wed, Mar 06, 2019 at 06:30:05PM -0300, Rodrigo Siqueira wrote: > > Hi Liviu, > > > > I’m using your patchset to guide my implementation of writeback in the > > VKMS, so, first of all, thanks :) > > > > During my work, I noticed that you’re setting the drmSetClien

Re: [Intel-gfx] [igt-dev] [PATCH V5 i-g-t] tests/kms_flip: Skip VBlank tests in modules without VBlank

2019-03-18 Thread Rodrigo Siqueira
On 03/18, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2019-03-18 21:53:42) > > On 03/18, Chris Wilson wrote: > > > Quoting Rodrigo Siqueira (2019-03-18 21:35:44) > > > > On 03/18, Ville Syrjälä wrote: > > > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote: > > > > > > The km

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-18 Thread Sripada, Radhakrishna
On Mon, 2019-03-18 at 15:30 +0200, Ville Syrjälä wrote: > On Fri, Mar 15, 2019 at 03:18:38PM -0700, Radhakrishna Sripada wrote: > > Fixes the clock-gating issue when pipe scaling is enabled. > > (Lineage #2006604312) > > > > Cc: Rodrigo Vivi > > Cc: Anusha Srivatsa > > Cc: Aditya Swarup > > Sig

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-18 Thread Sripada, Radhakrishna
On Mon, 2019-03-18 at 21:22 +, Chris Wilson wrote: > Quoting Sripada, Radhakrishna (2019-03-18 21:19:29) > > On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote: > > > Scalars as opposed to vector instructions? EU clock gating issues > > > with > > > certain shaders? > > > > > > > Hi Chris,

Re: [Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-18 Thread Rodrigo Vivi
Hi Shaobo, n Mon, Mar 18, 2019 at 05:01:10PM -0600, Shaobo He wrote: > Hello everyone, > > My name is Shaobo He and I am a graduate student at University of Utah. I am > using a static analysis tool to search for null pointer dereferences and > came across a potentially invalid memory access in t

Re: [Intel-gfx] [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-18 Thread Lucas De Marchi
On Mon, Mar 18, 2019 at 08:53:23PM +0200, Ville Syrjälä wrote: On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote: On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote: >On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote: >> The caller already knows what platfo

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection logic URL : https://patchwork.freedesktop.org/series/58139/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12503 ===

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add support for retrying hotplug

2019-03-18 Thread José Roberto de Souza
From: Imre Deak There is some scenarios that we are aware that sink probe can fail, so lets add the infrastructure to let hotplug() hook to request another probe after some time. v2: Handle shared HPD pins (Imre) Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Signed-off-by: Jani Nikul

[Intel-gfx] [PATCH v2 2/2] drm/i915: Enable hotplug retry

2019-03-18 Thread José Roberto de Souza
Right now we are aware of two cases that needs another hotplug retry: - Unpowered type-c dongles - HDMI slow unplug Both have a complete explanation in the code to schedule another run of the hotplug handler. It could have more checks to just trigger the retry in those two specific cases but why

Re: [Intel-gfx] Potential NULL pointer dereference in intel_crt_get_edid

2019-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2019 at 05:39:48PM -0600, Shaobo He wrote: > Hi Rodrigo, > > Sorry I'm a bit lost here. May I ask where the `WARN` is? along with the return NULL struct i2c_adapter *intel_gmbus_get_adapte() if (WARN_ON(!intel_gmbus_is_valid_pin(dev_priv, pin))) return NULL; > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev5)

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev5) URL : https://patchwork.freedesktop.org/series/57900/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12504

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Keep plane watermarks enabled more aggressively

2019-03-18 Thread Matt Roper
On Tue, Mar 12, 2019 at 10:58:41PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we disable all the watermarks above the selected max > level for every plane. That would mean that the cursor's watermarks > may also get modified when another plane causes the selected > max waterm

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Move some variables to tighter scope

2019-03-18 Thread Matt Roper
On Tue, Mar 12, 2019 at 10:58:42PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Clean up skl_allocate_pipe_ddb() a bit by moving the 'wm' variable > to tighter scope. We'll also consitify it where appropriate. > > Cc: Neel Desai > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Don't pass pipe_wm around so much

2019-03-18 Thread Matt Roper
On Tue, Mar 12, 2019 at 10:58:43PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > {skl,icl}_build_plane_wm() don't need to be passed the pipe_wm, so > don't. And skl_build_pipe_wm() can easily dig it out itself. > > Cc: Neel Desai > Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Inline skl_build_pipe_wm() into its only caller

2019-03-18 Thread Matt Roper
On Tue, Mar 12, 2019 at 10:58:44PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > skl_build_pipe_wm() is quite pointless now. Just inline it into I think you actually mean skl_update_pipe_wm(), right? The code change looks good, so with an updated commit message, Reviewed-by: Matt Roper

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/cml: Add CML PCI IDS

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS URL : https://patchwork.freedesktop.org/series/58147/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2e242bf601c6 drm/i915/cml: Add CML PCI IDS -:44: ERROR:COMPLEX_MACRO: Macros with complex va

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/cml: Add CML PCI IDS

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS URL : https://patchwork.freedesktop.org/series/58147/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/cml: Add CML PCI IDS Okay! Commit: drm/i915/cml: Introd

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-intel tree

2019-03-18 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/intel_hdmi.c between commit: fbf08556ed43 ("drm/i915: Precompute HDMI infoframes") from the drm-intel tree and commit: 2f146b78d5a9 ("drm/i915: Attach colorspace property and enable modeset")

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/cml: Add CML PCI IDS

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS URL : https://patchwork.freedesktop.org/series/58147/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12505 Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Add some missing curly braces

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add some missing curly braces URL : https://patchwork.freedesktop.org/series/58148/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12506 Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Handle YUV subpixel support better

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Handle YUV subpixel support better URL : https://patchwork.freedesktop.org/series/58130/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5767_full -> Patchwork_12497_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Lock the gem_context->active_list while dropping the link

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Lock the gem_context->active_list while dropping the link URL : https://patchwork.freedesktop.org/series/58151/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12507 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: Add support for retrying hotplug

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Add support for retrying hotplug URL : https://patchwork.freedesktop.org/series/58156/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add support for retrying hotplug -drive

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Add support for retrying hotplug

2019-03-18 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Add support for retrying hotplug URL : https://patchwork.freedesktop.org/series/58156/ State : success == Summary == CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12508 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Ensure minimum CDCLK requirement for audio

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure minimum CDCLK requirement for audio URL : https://patchwork.freedesktop.org/series/58132/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5767_full -> Patchwork_12498_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3)

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3) URL : https://patchwork.freedesktop.org/series/58052/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768_full -> Patchwork_12499_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: stick to kernel fixed size types

2019-03-18 Thread Patchwork
== Series Details == Series: drm/i915: stick to kernel fixed size types URL : https://patchwork.freedesktop.org/series/58135/ State : success == Summary == CI Bug Log - changes from CI_DRM_5768_full -> Patchwork_12500_full Summary ---

<    1   2