[Intel-gfx] [PATCH 09/12] drm/i914: s/l_info/dimm_l/ etc.

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Rename the dimm info structs for clarity. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 18 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/dr

[Intel-gfx] [PATCH 03/12] drm/i915: Polish skl_is_16gb_dimm()

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Pass the dimm struct to skl_is_16gb_dimm() rather than passing each value separately. And let's replace the hardcoded set of values with some simple arithmetic. Also fix the byte vs. bit inconsistency in the debug message, and polish the wording otherwise as well. Signed-off

[Intel-gfx] [PATCH 07/12] drm/i915: Use dram_dimm_info more

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Reduce the code duplication a bit by sharing the same code for parsing both DIMMs on a channel. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 44 ++--- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 04/12] drm/i915: Extract BXT DIMM helpers

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Polish the bxt DIMM parsing by extracting a few small helpers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 79 ++--- 1 file changed, 52 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/

[Intel-gfx] [PATCH 06/12] drm/i915: Extract DIMM info on GLK too

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä The BXT code for parsing DIMM info works for GLK too. Let's dig it out even if we might not need it immediately. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH 08/12] drm/i915: Generalize intel_is_dram_symmetric()

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Decouple intel_is_dram_symmetric() from the raw register values by comparing just the dram_channel_info structs. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git

[Intel-gfx] [PATCH 10/12] drm/i915: Clean up intel_get_dram_info() a bit

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Remove the pointless zero initialization of bunch of things (the thing is kzalloc()ed). Also throw out the mostly useless on-stack string. I think it'll be clear enough from the logs that 0 means unknown. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 1

[Intel-gfx] [PATCH 11/12] drm/i915: Extract DIMM info on cnl+

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä We'll need information about the memory configuration on cnl+ too. Extend the code to parse the slightly changed register layout. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 69 - drivers/gpu/drm/i915/i915_reg.h | 17 ++

[Intel-gfx] [PATCH 12/12] drm/i915: Read out memory type

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä We'll need to know the memory type in the system for some bandwidth limitations and whatnot. Let's read that out on gen9+. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 83 +++-- drivers/gpu/drm/i915/i915_drv.h | 7 +++ driv

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Fix DRAM size reporting for BXT

2019-02-25 Thread Chris Wilson
Quoting Ville Syrjala (2019-02-25 20:29:00) > From: Ville Syrjälä > > The BXT DUNIT register tells us the size of each DRAM device > in Gb. We want to report the size of the whole DIMM in GB, so > that it matches how we report it for non-LP platforms. > > Signed-off-by: Ville Syrjälä > --- > d

Re: [Intel-gfx] [PATCH 1/3] drm/i915/icl: move MG pll hw_state readout

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 03:23:22PM -0800, Lucas De Marchi wrote: > Let the MG plls have their own hooks since it shares very little with > other PLL types. It's also better so the platform info contains the info > if the PLL is for MG PHY rather than relying on the PLL ids. > > Signed-off-by: Luca

Re: [Intel-gfx] [PATCH 3/3] drm/i915/icl: decouple dpll ids from type

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 03:23:24PM -0800, Lucas De Marchi wrote: > Use the first 3 bits of dpll_info.platform_flags to mark the type of the > PLL instead of relying on the IDs. This is more future proof for > allowing the same set of functions to be reused, even if the IDs change. > > The warning

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Fix DRAM size reporting for BXT

2019-02-25 Thread Ville Syrjälä
On Mon, Feb 25, 2019 at 08:35:08PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2019-02-25 20:29:00) > > From: Ville Syrjälä > > > > The BXT DUNIT register tells us the size of each DRAM device > > in Gb. We want to report the size of the whole DIMM in GB, so > > that it matches how we rep

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Fix DRAM size reporting for BXT

2019-02-25 Thread Chris Wilson
Quoting Ville Syrjälä (2019-02-25 20:48:10) > On Mon, Feb 25, 2019 at 08:35:08PM +, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-02-25 20:29:00) > > > From: Ville Syrjälä > > > > > > The BXT DUNIT register tells us the size of each DRAM device > > > in Gb. We want to report the size of

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Polish DRAM information readout code

2019-02-25 Thread Patchwork
== Series Details == Series: Polish DRAM information readout code URL : https://patchwork.freedesktop.org/series/57213/ State : warning == Summary == $ dim checkpatch origin/drm-tip 00f769077034 drm/i915: Store DIMM rank information as a number 6000a48eb1cf drm/i915: Extract functions to deriv

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Patchwork
== Series Details == Series: drm/tinydrm: Remove tinydrm_device URL : https://patchwork.freedesktop.org/series/57197/ State : success == Summary == CI Bug Log - changes from CI_DRM_5658_full -> Patchwork_12297_full Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Polish DRAM information readout code

2019-02-25 Thread Patchwork
== Series Details == Series: Polish DRAM information readout code URL : https://patchwork.freedesktop.org/series/57213/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Store DIMM rank information as a number -O:drivers/gpu/drm/i915/i915_drv.c:

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Fix DRAM size reporting for BXT

2019-02-25 Thread Ville Syrjälä
On Mon, Feb 25, 2019 at 08:57:45PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2019-02-25 20:48:10) > > On Mon, Feb 25, 2019 at 08:35:08PM +, Chris Wilson wrote: > > > Quoting Ville Syrjala (2019-02-25 20:29:00) > > > > From: Ville Syrjälä > > > > > > > > The BXT DUNIT register tells

[Intel-gfx] ✓ Fi.CI.BAT: success for Polish DRAM information readout code

2019-02-25 Thread Patchwork
== Series Details == Series: Polish DRAM information readout code URL : https://patchwork.freedesktop.org/series/57213/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659 -> Patchwork_12301 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 3/3] drm/i915/icl: decouple dpll ids from type

2019-02-25 Thread Lucas De Marchi
On Mon, Feb 25, 2019 at 10:45:34PM +0200, Ville Syrjälä wrote: On Fri, Feb 22, 2019 at 03:23:24PM -0800, Lucas De Marchi wrote: Use the first 3 bits of dpll_info.platform_flags to mark the type of the PLL instead of relying on the IDs. This is more future proof for allowing the same set of funct

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Disable PSR2 while getting pipe CRC

2019-02-25 Thread Souza, Jose
On Fri, 2019-02-22 at 22:14 -0800, Dhinakaran Pandiyan wrote: > On Sat, 2019-02-23 at 02:48 +, Souza, Jose wrote: > > On Fri, 2019-02-22 at 18:13 -0800, Dhinakaran Pandiyan wrote: > > > On Wed, 2019-02-13 at 18:02 -0800, José Roberto de Souza wrote: > > > > As stated in CRC_CTL spec, after PSR

Re: [Intel-gfx] [PATCH 1/2] drm/i915: remove unused bits from Panel Power Sequence State

2019-02-25 Thread Lucas De Marchi
On Mon, Feb 25, 2019 at 09:28:06PM +0200, Ville Syrjälä wrote: On Fri, Feb 22, 2019 at 04:34:48PM -0800, Lucas De Marchi wrote: No change in behavior. Just removing the unused bits since it makes it easier to compare them on new platforms and one of them was wrong (PP_SEQUENCE_STATE_ON_S1_0 vs t

Re: [Intel-gfx] [PATCH 1/3] drm/i915/icl: move MG pll hw_state readout

2019-02-25 Thread Lucas De Marchi
On Mon, Feb 25, 2019 at 10:42:12PM +0200, Ville Syrjälä wrote: On Fri, Feb 22, 2019 at 03:23:22PM -0800, Lucas De Marchi wrote: Let the MG plls have their own hooks since it shares very little with other PLL types. It's also better so the platform info contains the info if the PLL is for MG PHY

[Intel-gfx] [PATCH v2] drm/i915: extract AUX mask assignment to separate function

2019-02-25 Thread Lucas De Marchi
No change in behavior, this only allows to more easily follow the flow of gen8_de_irq_handler without the mask assignments for each platform. This also re-organizes the branches a little bit, so the one-off case for CNL_WITH_PORT_F is separate from the generic gen >= 11. v2: rename de_port_iir_aux

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno URL : https://patchwork.freedesktop.org/series/57203/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659_full -> Patchwork_12298_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: extract AUX mask assignment to separate function (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: extract AUX mask assignment to separate function (rev2) URL : https://patchwork.freedesktop.org/series/57119/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659 -> Patchwork_12302 Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Infoframe precompute/check (rev7)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Infoframe precompute/check (rev7) URL : https://patchwork.freedesktop.org/series/49983/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659_full -> Patchwork_12299_full Summary ---

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-25 Thread Joonas Lahtinen
Quoting Dave Airlie (2019-02-25 12:24:48) > On Tue, 19 Feb 2019 at 23:32, Joonas Lahtinen > wrote: > > > > + dri-devel mailing list, especially for the buddy allocator part > > > > Quoting Dave Airlie (2019-02-15 02:47:07) > > > On Fri, 15 Feb 2019 at 00:57, Matthew Auld wrote: > > > > > > > > In

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Yet another if/else sort of newer to older platforms. (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Yet another if/else sort of newer to older platforms. (rev2) URL : https://patchwork.freedesktop.org/series/57112/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659_full -> Patchwork_12300_full ===

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-25 Thread Alex Deucher
On Mon, Feb 25, 2019 at 9:35 PM Joonas Lahtinen wrote: > > Quoting Dave Airlie (2019-02-25 12:24:48) > > On Tue, 19 Feb 2019 at 23:32, Joonas Lahtinen > > wrote: > > > > > > + dri-devel mailing list, especially for the buddy allocator part > > > > > > Quoting Dave Airlie (2019-02-15 02:47:07) > >

[Intel-gfx] ✓ Fi.CI.IGT: success for Polish DRAM information readout code

2019-02-25 Thread Patchwork
== Series Details == Series: Polish DRAM information readout code URL : https://patchwork.freedesktop.org/series/57213/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659_full -> Patchwork_12301_full Summary --- **SU

Re: [Intel-gfx] [PATCH v6 1/3] drm: Add CRTC background color property (v5)

2019-02-25 Thread Maarten Lankhorst
Hey, Op 21-02-2019 om 01:28 schreef Matt Roper: > Some display controllers can be programmed to present non-black colors > for pixels not covered by any plane (or pixels covered by the > transparent regions of higher planes). Compositors that want a UI with > a solid color background can potentia

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Tvrtko Ursulin
On 25/02/2019 18:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-02-25 17:59:40) On 25/02/2019 16:23, Chris Wilson wrote: static inline struct i915_priolist *to_priolist(struct rb_node *rb) { return rb_entry(rb, struct i915_priolist, node); @@ -2206,6 +2212,10 @@ static u32

[Intel-gfx] [PATCH 04/10] drm/i915: Add HDCP SRM Blob parsing

2019-02-25 Thread Ramalingam C
This patch adds a drm blob property to selected connectors. And also adds capability to parse the new HDCP1.4 srm blob passed through cp_srm_property. The revocated KSV list and their counts are stored in the intel_hdcp. This list should be used for revocation check of BKSVs in first stage HDCP au

[Intel-gfx] [PATCH 03/10] drm: Add CP System Renewability Msg Property

2019-02-25 Thread Ramalingam C
This patch adds a drm blob property to the selected connector. This property will be used to pass the SRM Blob ID from userspace to kernel. Revocated ksv list from SRM Table will be used by the kernel in the HDCP authentication. Kernel doesn't validate the incoming SRM table or store it in non-vo

[Intel-gfx] [PATCH 01/10] drm: Add CP content type property

2019-02-25 Thread Ramalingam C
This patch adds a DRM ENUM property to the selected connectors. This property is used for pass the protected content's type from userspace to kernel HDCP authentication. Type of the stream is decided by the protected content providers as Type 0/1. Type 0 content can be rendered on any HDCP protec

[Intel-gfx] [PATCH 02/10] drm/i915: Attach content type property

2019-02-25 Thread Ramalingam C
Attaches the content type property for HDCP2.2 capable connectors. Implements the update of content type from property and apply the restriction on HDCP version selection. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_ddi.c | 21 +++-- drivers/gpu/drm/i915/intel_dr

Re: [Intel-gfx] [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190225] [cannot apply to v5.0-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] [PATCH 00/10] HDCP2.2 Phase II

2019-02-25 Thread Ramalingam C
HDCP2.2 phase-II mojorly adds below features: Addition of three connector properties CP_Content_Type CP_SRM CP_Downstream_Info parsing for HDCP1.4 and 2.2 SRM Blobs Once HDCP1.4/2.2 authentication is completed gathering the all

[Intel-gfx] [PATCH 10/10] drm/i915: debugfs: HDCP2.2 capability read

2019-02-25 Thread Ramalingam C
Adding the HDCP2.2 capability of HDCP src and sink info into debugfs entry "i915_hdcp_sink_capability" This helps the userspace tests to skip the HDCP2.2 test on non HDCP2.2 sinks. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_debugfs.c | 13 +++-- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 07/10] drm: Add CP downstream_info property

2019-02-25 Thread Ramalingam C
This patch adds CP downstream info blob property to the connectors. This enables the Userspace to read the information of HDCP authenticated downstream topology. Driver will updated this blob with all downstream information at the end of the authentication. Userspace need this informations to con

[Intel-gfx] [PATCH 06/10] drm/i915: SRM parsing and revocation check for HDCP2

2019-02-25 Thread Ramalingam C
SRM blob with hdcp2 id is parsed and parsed list of revoked ids is used in the authentication process to identify the compromised HDCP sinks. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 86 +-- include/drm/drm_hdcp.h| 20 +++

[Intel-gfx] [PATCH 05/10] drm/i915: Add revocation check on HDCP1.4 Ksvs

2019-02-25 Thread Ramalingam C
KSV list revocated by DCP LLC is provided as SRM Blob to kernel. Which is parsed and stored in intel_hdcp->revocated_ksv_list. This patch adds the revocation check for BKSV and KSV_FIFO in HDCP1.4 authentication. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 67 +++

[Intel-gfx] [PATCH 09/10] drm/i915: Populate downstream info for HDCP2.2

2019-02-25 Thread Ramalingam C
Populates the downstream info for HDCP2.2 encryption also. On success of encryption Blob is updated. Additional two variable are added to downstream info blob. Such as ver_in_force and content type. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 29 +

[Intel-gfx] [PATCH 08/10] drm/i915: Populate downstream info for HDCP1.4

2019-02-25 Thread Ramalingam C
Implements drm blob property cp_downstream_info property on HDCP capable connectors. Downstream topology info is gathered across authentication stages and stored in intel_hdcp. When HDCP authentication is complete, new blob with latest downstream topology information is updated to cp_downstream_in

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-26 07:34:37) > > On 25/02/2019 18:40, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-02-25 17:59:40) > >> > >> On 25/02/2019 16:23, Chris Wilson wrote: > >>>static inline struct i915_priolist *to_priolist(struct rb_node *rb) > >>>{ > >>>return

[Intel-gfx] [PATCH v2] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Chris Wilson
To determine whether an engine has 'stuck', we simply check whether or not is still on the same seqno for several seconds. To keep this simple mechanism intact over the loss of a global seqno, we can simply add a new global heartbeat seqno instead. As we cannot know the sequence in which requests w

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Tvrtko Ursulin
On 26/02/2019 07:49, Chris Wilson wrote: To determine whether an engine has 'stuck', we simply check whether or not is still on the same seqno for several seconds. To keep this simple mechanism intact over the loss of a global seqno, we can simply add a new global heartbeat seqno instead. As we

<    1   2