Re: [Intel-gfx] [PATCH 1/4] drm/i915/psr: Only lookup for enabled CRTCs when forcing a fastset

2019-02-25 Thread Maarten Lankhorst
Op 23-02-2019 om 03:02 schreef Dhinakaran Pandiyan: > On Fri, 2019-02-22 at 16:33 -0800, Souza, Jose wrote: >> On Fri, 2019-02-22 at 16:27 -0800, Pandiyan, Dhinakaran wrote: >>> On Wed, 2019-02-13 at 18:02 -0800, José Roberto de Souza wrote: Forcing a specific CRTC to the eDP connector was cau

Re: [Intel-gfx] [PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-25 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 05:12:09AM +, C, Ramalingam wrote: > Tomas, > > Lkp issue is complaining about the header drm/i915_mei_hdcp_interface.h, > Which is already merged in drm-tip through below commit. So don’t think > this is a genuine issue. May be this build was tried in different tree, >

[Intel-gfx] [PATCH v6 3/3] drm/qxl: remove conflicting framebuffers earlier

2019-02-25 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5

[Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

2019-02-25 Thread Gerd Hoffmann
v6: buildfix. Gerd Hoffmann (3): drm: move i915_kick_out_vgacon to vgaarb drm/fb-helper: call vga_remove_vgacon automatically. drm/qxl: remove conflicting framebuffers earlier include/drm/drm_fb_helper.h | 14 +--- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v6 1/3] drm: move i915_kick_out_vgacon to vgaarb

2019-02-25 Thread Gerd Hoffmann
Also rename it to vga_remove_vgacon and add kerneldoc text. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 35 +- drivers/gpu/vga/vgaarb.c| 48

[Intel-gfx] [PATCH v6 2/3] drm/fb-helper: call vga_remove_vgacon automatically.

2019-02-25 Thread Gerd Hoffmann
Add vga_remove_vgacon() call to drm_fb_helper_remove_conflicting_pci_framebuffers(). Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- include/drm/drm_fb_helper.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2) URL : https://patchwork.freedesktop.org/series/57086/ State : warning == Summary == $ dim checkpatch origin/drm-tip bfa4e81d85e2 drm: move i915_kick_out_vgacon to vgaarb -:94: ERROR:CODE_INDENT: code indent shou

[Intel-gfx] ✓ Fi.CI.BAT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2) URL : https://patchwork.freedesktop.org/series/57086/ State : success == Summary == CI Bug Log - changes from CI_DRM_5657 -> Patchwork_12294 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev2) URL : https://patchwork.freedesktop.org/series/57037/ State : warning == Summary == $ dim checkpatch origin/drm-tip 28035a8723cc mei: bus: whitelist hdcp client 5eb2c31723c1 misc/mei/hdcp: Client driver for HDCP application -:82:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2 (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev2) URL : https://patchwork.freedesktop.org/series/57037/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: mei: bus: whitelist hdcp client Okay! Commit: misc/mei/hdcp: Client driver for HDCP ap

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Implement HDCP2.2 (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev2) URL : https://patchwork.freedesktop.org/series/57037/ State : success == Summary == CI Bug Log - changes from CI_DRM_5657 -> Patchwork_12295 Summary --- **SUCCESS** N

[Intel-gfx] ✓ Fi.CI.IGT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2) URL : https://patchwork.freedesktop.org/series/57086/ State : success == Summary == CI Bug Log - changes from CI_DRM_5657_full -> Patchwork_12294_full Summar

Re: [Intel-gfx] [PATCH] drm/i915: Call MG_DP_MODE() macro with the right parameters order

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Lucas De Marchi wrote: > On Fri, Feb 22, 2019 at 12:24 PM José Roberto de Souza > wrote: >> >> The commit that this patch fixes changed the order of the parameters >> of MG_DP_MODE() but din't update the callers, breaking type-c on ICL. > > ugh... > >> >> Fixes: 58106b7d816e

Re: [Intel-gfx] [PATCH 38/46] drm/i915: Allow a context to define its set of engines

2019-02-25 Thread Tvrtko Ursulin
On 06/02/2019 13:03, Chris Wilson wrote: Over the last few years, we have debated how to extend the user API to support an increase in the number of engines, that may be sparse and even be heterogeneous within a class (not all video decoders created equal). We settled on using (class, instance)

Re: [Intel-gfx] [PATCH 38/46] drm/i915: Allow a context to define its set of engines

2019-02-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-25 10:41:28) > > On 06/02/2019 13:03, Chris Wilson wrote: > > +static int > > +get_engines(struct i915_gem_context *ctx, > > + struct drm_i915_gem_context_param *args) > > +{ > > + struct i915_context_param_engines *local; > > + unsigned int n, count

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for retrying hotplug

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, José Roberto de Souza wrote: > From: Imre Deak > > There is some scenarios that we are aware that sink probe can fail, > so lets add the infrastructure to let hotplug() hook to request > another probe after some time. See also http://patchwork.freedesktop.org/patch/msgid/20

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Implement HDCP2.2 (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev2) URL : https://patchwork.freedesktop.org/series/57037/ State : success == Summary == CI Bug Log - changes from CI_DRM_5657_full -> Patchwork_12295_full Summary --- **SUCC

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for retrying hotplug

2019-02-25 Thread Imre Deak
On Mon, Feb 25, 2019 at 01:02:45PM +0200, Jani Nikula wrote: > On Fri, 22 Feb 2019, José Roberto de Souza wrote: > > From: Imre Deak > > > > There is some scenarios that we are aware that sink probe can fail, > > so lets add the infrastructure to let hotplug() hook to request > > another probe af

[Intel-gfx] [RFT i-g-t] lib/intel_batchbuffer: Gen9 media spin function can work on newer gens?

2019-02-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin ... lets see ... Signed-off-by: Tvrtko Ursulin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109288 Cc: Matthew Auld Cc: Tony Ye --- lib/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_b

[Intel-gfx] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11

2019-02-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Do not use it on older gens. Signed-off-by: Tvrtko Ursulin Cc: Tony Ye --- lib/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index b2169a1aa145..6e6bcdeba8a6 100644 --- a/lib/intel

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11

2019-02-25 Thread Tvrtko Ursulin
On 25/02/2019 11:55, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Do not use it on older gens. Signed-off-by: Tvrtko Ursulin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612 Regards, Tvrtko Cc: Tony Ye --- lib/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH] drm/i915: Sort ctx workarounds init from newer to older platforms.

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Rodrigo Vivi wrote: > On Fri, Feb 22, 2019 at 10:32:25AM +, Chris Wilson wrote: >> Quoting Rodrigo Vivi (2019-02-21 23:14:52) >> > No functional change. Just a reorg to match the preferred >> > behavior. >> > >> > Cc: Tvrtko Ursulin >> > Cc: Ville Syrjälä >> > Cc: Lucas

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Generalize pci quirks

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > Add support for multiple independent pci quirk tables. > I want to reuse the quirk table approach for some > watermark quirks but I prefer to keep the details in > one place rather than spreading them all over. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use intel_apply_pci_quirks() to apply ILK+ wm quirks

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the newly introduced intel_apply_pci_quirks() to clean up > the way we apply the ilk+ watermark quirks. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_pm.c | 20 ++-- > 1 file changed, 1

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Restrict SNB LP3+ disable to Thinkpad X220 tablet

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > The only machine we know for sure to require the LP3+ disable > is the Lenovo Thinkpad X220 tablet. Originally in commit > 03981c6ebec4 ("drm/i915: Disable LP3 watermarks on all SNB > machines") I disabled LP3+ watermarks on all

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Disable LP1+ watermarks on Lenovo Thinkpad T431s

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > Lenovo Thinkpad T431s (ivb) apparently can't handle LP1+ watermarks > being enabled. It underruns severly enough that the screen is > unusable. The latency values and watemarks look as expected. > And sadly updating the BIOS to t

[Intel-gfx] [PATCH 1/3] drm: Add support for out-of-band hotplug notification

2019-02-25 Thread Hans de Goede
On some hardware a hotplug event notification may come from outside the display driver / device. One example of this is laptops with hybrid graphics where one or more outputs are connected to the discrete GPU only. In this case if the discrete GPU is fully powered down to save power, a hotplug to

[Intel-gfx] [PATCH 2/3] i915: Add support for out-of-bound hotplug events

2019-02-25 Thread Hans de Goede
On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything being ha

[Intel-gfx] [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Hans de Goede
Hi All, On some Cherry Trail devices, DisplayPort over Type-C is supported through a USB-PD microcontroller (e.g. a fusb302) + a mux to switch the superspeed datalines between USB-3 and DP (e.g. a pi3usb30532). The kernel in this case does the PD/alt-mode negotiation itself, rather then everything

[Intel-gfx] [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Hans de Goede
Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 34 1 file changed, 23 insertions(+), 11 deletions(-) di

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Generalize pci quirks

2019-02-25 Thread Jani Nikula
On Mon, 25 Feb 2019, Jani Nikula wrote: > On Fri, 22 Feb 2019, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Add support for multiple independent pci quirk tables. >> I want to reuse the quirk table approach for some >> watermark quirks but I prefer to keep the details in >> one place rather

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use intel_apply_pci_quirks() to apply ILK+ wm quirks

2019-02-25 Thread Ville Syrjälä
On Mon, Feb 25, 2019 at 03:14:52PM +0200, Jani Nikula wrote: > On Fri, 22 Feb 2019, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use the newly introduced intel_apply_pci_quirks() to clean up > > the way we apply the ilk+ watermark quirks. > > > > Signed-off-by: Ville Syrjälä > > --- > >

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915: Add engine reset count in get-reset-stats ioctl

2019-02-25 Thread Tvrtko Ursulin
On 21/02/2019 02:58, Carlos Santa wrote: From: Michel Thierry Users/tests relying on the total reset count will start seeing a smaller number since most of the hangs can be handled by engine reset. Note that if reset engine x, context a running on engine y will be unaware and unaffected. To s

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Generalize pci quirks

2019-02-25 Thread Ville Syrjälä
On Mon, Feb 25, 2019 at 03:28:18PM +0200, Jani Nikula wrote: > On Mon, 25 Feb 2019, Jani Nikula wrote: > > On Fri, 22 Feb 2019, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> Add support for multiple independent pci quirk tables. > >> I want to reuse the quirk table approach for some >

Re: [Intel-gfx] BUG: KASAN: use-after-free in intel_hdmi_destroy+0x79/0x80

2019-02-25 Thread Jani Nikula
On Fri, 22 Feb 2019, Randy Dunlap wrote: > This is 5.0-rc7 on an old Toshiba Portege laptop. > No hdmi or other external video. > > Linux dragon.dunlab 5.0.0-rc7mod #3 SMP PREEMPT Wed Feb 20 00:05:17 PST 2019 > x86_64 x86_64 x86_64 GNU/Linux > > on openSUSE LEAP 15.0 distro. > > Full boot log is

Re: [Intel-gfx] [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Greg Kroah-Hartman
On Mon, Feb 25, 2019 at 02:20:37PM +0100, Hans de Goede wrote: > Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load > drm/kms drivers know about DisplayPort over Type-C hotplug events. > > Signed-off-by: Hans de Goede > --- > drivers/usb/typec/altmodes/displayport.c | 34

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow platforms without eDP transcoder

2019-02-25 Thread Kahola, Mika
Looks allright. On Fri, 2019-02-22 at 15:02 -0800, Lucas De Marchi wrote: > Define a HAS_TRANSCODER_EDP() macro that checks if we have defined an > offset for this transcoder. This allows platforms to be defined > without > eDP transcoder. > > Cc: Mika Kahola > Cc: Imre Deak > Cc: Rodrigo Vivi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Patchwork
== Series Details == Series: Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers URL : https://patchwork.freedesktop.org/series/57187/ State : warning == Summary == $ dim checkpatch origin/drm-tip 88c00a57f29f drm: Add support for out-of-band hotplug notification -:106:

[Intel-gfx] [PATCH v3 1/7] drm/drv: Hold ref on parent device during drm_device lifetime

2019-02-25 Thread Noralf Trønnes
This makes it safe to access drm_device->dev after the parent device has been removed/unplugged. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 53e8f4e

[Intel-gfx] [PATCH v3 2/7] drm: Add devm_drm_dev_init()

2019-02-25 Thread Noralf Trønnes
This adds a resource managed (devres) version of drm_dev_init(). v2: Remove devm_drm_dev_register() since we can't touch hw in devm release functions and drivers want to disable hw on driver module unload (Daniel Vetter, Greg KH) Cc: Daniel Vetter Cc: Greg KH Signed-off-by: Noralf Trønn

[Intel-gfx] [PATCH v3 0/7] drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Noralf Trønnes
This patchset is part of the effort to remove tinydrm.ko. It removes struct tinydrm_device and tinydrm.h. Only one change in this version and that is expanding the driver example. The drm_dev_unplug() dependency series has been applied together with some patches from the previous version. I've c

[Intel-gfx] [PATCH v3 3/7] drm/drv: DOC: Add driver example code

2019-02-25 Thread Noralf Trønnes
Add driver example that shows how devm_drm_dev_init() can be used. v2: Expand docs (Sam, Daniel) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 132 ++ 1 file changed, 132 insertions(+) diff --git a/drivers/gpu/drm/drm

[Intel-gfx] [PATCH v3 7/7] drm/tinydrm: Use drm_dev_enter/exit()

2019-02-25 Thread Noralf Trønnes
This protects device resources from use after device removal. There are 3 ways for driver-device unbinding to happen: - The driver module is unloaded causing the driver to be unregistered. This can't happen as long as there are open file handles because a reference is taken on the module. - Th

[Intel-gfx] [PATCH v3 6/7] drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Noralf Trønnes
No more users left so it can go alongside its helpers. Update the tinydrm docs description and remove todo entry. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg Acked-by: Daniel Vetter --- Documentation/gpu/tinydrm.rst | 32 ++-- Documentation/gpu/todo.rst

[Intel-gfx] [PATCH v3 4/7] drm/tinydrm/repaper: Drop using tinydrm_device

2019-02-25 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add a driver release callback. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/tinydrm/repaper.c | 84 ++- 1 file changed, 61 insertions(+),

[Intel-gfx] [PATCH v3 5/7] drm/tinydrm: Drop using tinydrm_device

2019-02-25 Thread Noralf Trønnes
Use devm_drm_dev_init() and drop using tinydrm_device. v2: devm_drm_dev_register() was dropped so add driver release callbacks. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/hx8357d.c | 40 +-- drivers/gpu/drm/tinydrm/ili9225.c | 40 +-- drivers/gpu/drm/tinydrm/i

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Patchwork
== Series Details == Series: Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers URL : https://patchwork.freedesktop.org/series/57187/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: Add support for out-of-band hotplug notifi

Re: [Intel-gfx] BUG: KASAN: use-after-free in intel_hdmi_destroy+0x79/0x80

2019-02-25 Thread Hans Verkuil
Hi Jani, On 2/25/19 2:40 PM, Jani Nikula wrote: On Fri, 22 Feb 2019, Randy Dunlap wrote: This is 5.0-rc7 on an old Toshiba Portege laptop. No hdmi or other external video. Linux dragon.dunlab 5.0.0-rc7mod #3 SMP PREEMPT Wed Feb 20 00:05:17 PST 2019 x86_64 x86_64 x86_64 GNU/Linux on openSUSE

Re: [Intel-gfx] [PATCH v2 0/3] Make DRM DSC helpers more generally usable

2019-02-25 Thread Christian König
Am 21.02.19 um 21:19 schrieb David Francis: drm_dsc could use some work so that drm drivers other than i915 can make use of it their own DSC implementations Move rc compute, a function that forms part of the DSC spec, into drm. Update it to DSC 1.2. Also split the PPS packing and SDP header init

Re: [Intel-gfx] BUG: KASAN: use-after-free in intel_hdmi_destroy+0x79/0x80

2019-02-25 Thread Jani Nikula
On Mon, 25 Feb 2019, Hans Verkuil wrote: > Hi Jani, > > On 2/25/19 2:40 PM, Jani Nikula wrote: >> On Fri, 22 Feb 2019, Randy Dunlap wrote: >>> This is 5.0-rc7 on an old Toshiba Portege laptop. >>> No hdmi or other external video. >>> >>> Linux dragon.dunlab 5.0.0-rc7mod #3 SMP PREEMPT Wed Feb 20

[Intel-gfx] ✓ Fi.CI.BAT: success for Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Patchwork
== Series Details == Series: Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers URL : https://patchwork.freedesktop.org/series/57187/ State : success == Summary == CI Bug Log - changes from CI_DRM_5658 -> Patchwork_12296 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Patchwork
== Series Details == Series: drm/tinydrm: Remove tinydrm_device URL : https://patchwork.freedesktop.org/series/57197/ State : warning == Summary == $ dim checkpatch origin/drm-tip 686f06d66ef6 drm/drv: Hold ref on parent device during drm_device lifetime 979fb6bd33a0 drm: Add devm_drm_dev_init

Re: [Intel-gfx] [PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-25 Thread Jani Nikula
On Thu, 21 Feb 2019, David Francis wrote: > Native 420 and 422 transfer modes are new in DSC1.2 > > In these modes, each two pixels of a slice are treated as one > pixel, so the slice width is half as large (round down) for > the purposes of calucating the groups per line and chunk size > in bytes

Re: [Intel-gfx] [PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-25 Thread Winkler, Tomas
> On Mon, Feb 25, 2019 at 05:12:09AM +, C, Ramalingam wrote: > > Tomas, > > > > Lkp issue is complaining about the header > > drm/i915_mei_hdcp_interface.h, Which is already merged in drm-tip > > through below commit. So don’t think this is a genuine issue. May be > > this build was tried in di

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/pm_rpm: Enable PC8+ residency test for ICL and GEN9.

2019-02-25 Thread Imre Deak
On Thu, Feb 21, 2019 at 10:37:57PM +0530, Anshuman Gupta wrote: > Enabled has_pc8 global for ICL and Gen9. > Added PC8+ residency test for display enabled case as well. > > Signed-off-by: Anshuman Gupta > --- > tests/pm_rpm.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/tinydrm: Remove tinydrm_device

2019-02-25 Thread Patchwork
== Series Details == Series: drm/tinydrm: Remove tinydrm_device URL : https://patchwork.freedesktop.org/series/57197/ State : success == Summary == CI Bug Log - changes from CI_DRM_5658 -> Patchwork_12297 Summary --- **SUCCESS** N

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Restrict SNB LP3+ disable to Thinkpad X220 tablet

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 05:52:51PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The only machine we know for sure to require the LP3+ disable > is the Lenovo Thinkpad X220 tablet. Originally in commit > 03981c6ebec4 ("drm/i915: Disable LP3 watermarks on all SNB > machines") I disabled LP

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Restrict SNB LP3+ disable to Thinkpad X220 tablet

2019-02-25 Thread Ville Syrjälä
On Mon, Feb 25, 2019 at 05:45:38PM +0200, Ville Syrjälä wrote: > On Fri, Feb 22, 2019 at 05:52:51PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The only machine we know for sure to require the LP3+ disable > > is the Lenovo Thinkpad X220 tablet. Originally in commit > > 03981c6ebe

Re: [Intel-gfx] [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2019-02-25 Thread Hans de Goede
Hi, On 25-02-19 15:06, Greg Kroah-Hartman wrote: On Mon, Feb 25, 2019 at 02:20:37PM +0100, Hans de Goede wrote: Use the new drm_kms_call_oob_hotplug_notifier_chain() function to load s/load/let/ fixed in my tree. drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off

[Intel-gfx] [PATCH 3/4] drm/i915: Remove i915_request.global_seqno

2019-02-25 Thread Chris Wilson
Having weaned the interrupt handling off using a single global execution queue, we no longer need to emit a global_seqno. Note that we still have a few assumptions about execution order along engine timelines, but this removes the most obvious artefact! Signed-off-by: Chris Wilson --- drivers/gp

[Intel-gfx] [PATCH 1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Chris Wilson
To determine whether an engine has 'stuck', we simply check whether or not is still on the same seqno for several seconds. To keep this simple mechanism intact over the loss of a global seqno, we can simply add a new global heartbeat seqno instead. As we cannot know the sequence in which requests w

[Intel-gfx] [PATCH 4/4] drm/i915/selftests: Exercise resetting during non-user payloads

2019-02-25 Thread Chris Wilson
In selftests/live_hangcheck, we have a lot of tests for resetting simple spinners, but nothing quite prepared us for how the GPU reacted to triggering a reset outside of the safe spinner. These two subtests fill the ring with plain old empty, non-spinning requests, and then triggers a reset. Withou

[Intel-gfx] [PATCH 2/4] drm/i915: Remove access to global seqno in the HWSP

2019-02-25 Thread Chris Wilson
Stop accessing the HWSP to read the global seqno, and stop tracking the mirror in the engine's execution timeline -- it is unused. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gpu_error.c | 4 -- drivers/gpu/drm/i915/i915_gpu_error.h |

Re: [Intel-gfx] [PATCH] drm/i915: Yet another if/else sort of newer to older platforms.

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 02:11:12PM -0800, Rodrigo Vivi wrote: > No functional change. Just a reorg to match the preferred > behavior. > > When rebasing internal branch on top of latest sort I noticed > few more cases that needs to get reordered. > > Let's do in a bundle this time and hoping there

Re: [Intel-gfx] [PATCH 7/7] drm/i915/perf: add flushing ioctl

2019-02-25 Thread Joonas Lahtinen
Quoting Lionel Landwerlin (2019-02-04 17:30:12) > On 22/01/2019 16:25, Joonas Lahtinen wrote: > > Quoting Lionel Landwerlin (2019-01-16 17:36:22) > >> With the currently available parameters for the i915-perf stream, > >> there are still situations that are not well covered : > >> > >> If an applic

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno URL : https://patchwork.freedesktop.org/series/57203/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0e4e62c64045 drm/i915: Replace global_seqno with a hangch

[Intel-gfx] [PATCH v3 0/9] drm/i915: Infoframe precompute/check

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Simply a rebase on top of latest drm-tip. The one important change was the adjustment of .compute_config() return value from bool to int. All r-b'd/acked so should be good to land if CI is still agreeable. Ville Syrjälä (9): drm/i915: Add the missing HDMI gamut metadata pac

[Intel-gfx] [PATCH v3 1/9] drm/i915: Add the missing HDMI gamut metadata packet stuff

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä We have definitions and low level code for everything except the gamut metadata HDMI packet. Add the missing bits. Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_reg.h | 8 +--- drivers/gpu/drm/i915/intel_hdmi.c | 12 ++

[Intel-gfx] [PATCH v3 6/9] drm/i915/sdvo: Precompute HDMI infoframes

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä As with regular HDMI encoders, let's precompute the infoframes (actually just AVI infoframe for the time being) with SDVO HDMI encoders. v2: Drop the WARN_ON() from drm_hdmi_avi_infoframe_from_display_mode() return since that could genuinely fail due to user asking fo

[Intel-gfx] [PATCH v3 2/9] drm/i915: Return the mask of enabled infoframes from ->inforame_enabled()

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä We want to start tracking which infoframes are enabled, so let's replace the boolean flag with a bitmask. We'll abstract the bitmask so that it's not platform dependent. That will allow us to examine the bitmask later in platform independent code. v2: Don't map VIDEO_DIP_ENA

[Intel-gfx] [PATCH v3 7/9] drm/i915/sdvo: Read out HDMI infoframes

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Read the HDMI infoframes from the hbuf and unpack them into the crtc state. Well, actually just AVI infoframe for now but let's write the infoframe readout code in a more generic fashion in case we expand this later. Note that Daniel was sceptical about the benefit if this a

[Intel-gfx] [PATCH v3 9/9] drm/i915: Include infoframes in the crtc state dump

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Dump out the infoframes in the normal crtc state dump. TODO: Try to better integrate the infoframe dumps with drm state dumps Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 26 ++ 1 file cha

[Intel-gfx] [PATCH v3 3/9] drm/i915: Store mask of enabled infoframes in the crtc state

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Store the mask of enabled infoframes in the crtc state. We'll start with just the readout for HDMI encoder, and we'll expand this to compute the bitmask in .compute_config() later. SDVO will also follow later. Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- dri

[Intel-gfx] [PATCH v3 8/9] drm/i915: Check infoframe state in intel_pipe_config_compare()

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Check the infoframes and infoframe enable state when comparing two crtc states. We'll use the infoframe logging functions from video/hdmi.c to show the infoframes as part of the state dump. TODO: Try to better integrate the infoframe dumps with drm state dumps v2: drm

[Intel-gfx] [PATCH v3 5/9] drm/i915: Read out HDMI infoframes

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Add code to read the infoframes from the video DIP and unpack them into the crtc state. v2: Make the read funcs return void (Daniel) Drop the duplicate infoframe enabled checks (Daniel) Add a FIXME for lspcon infoframe readout Signed-off-by: Ville Syrjälä Reviewed-b

[Intel-gfx] [PATCH v3 4/9] drm/i915: Precompute HDMI infoframes

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Store the infoframes in the crtc state and precompute them in .compute_config(). While precomputing we'll also fill out the inforames.enable bitmask appropriately. v2: Drop the null packet stuff (Daniel) Add a FIXME for lspcon v3: .compute_config() now returns int Signed

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Remove i915_request.global_seqno

2019-02-25 Thread Tvrtko Ursulin
On 25/02/2019 16:23, Chris Wilson wrote: Having weaned the interrupt handling off using a single global execution queue, we no longer need to emit a global_seqno. Note that we still have a few assumptions about execution order along engine timelines, but this removes the most obvious artefact!

Re: [Intel-gfx] [PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-25 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 03:13:04PM +, Winkler, Tomas wrote: > > On Mon, Feb 25, 2019 at 05:12:09AM +, C, Ramalingam wrote: > > > Tomas, > > > > > > Lkp issue is complaining about the header > > > drm/i915_mei_hdcp_interface.h, Which is already merged in drm-tip > > > through below commit. S

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno URL : https://patchwork.freedesktop.org/series/57203/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659 -> Patchwork_12298

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Tvrtko Ursulin
On 25/02/2019 16:23, Chris Wilson wrote: To determine whether an engine has 'stuck', we simply check whether or not is still on the same seqno for several seconds. To keep this simple mechanism intact over the loss of a global seqno, we can simply add a new global heartbeat seqno instead. As we

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Infoframe precompute/check (rev7)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Infoframe precompute/check (rev7) URL : https://patchwork.freedesktop.org/series/49983/ State : warning == Summary == $ dim checkpatch origin/drm-tip f1e068bf9522 drm/i915: Add the missing HDMI gamut metadata packet stuff -:45: WARNING:LONG_LINE: line ove

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Infoframe precompute/check (rev7)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Infoframe precompute/check (rev7) URL : https://patchwork.freedesktop.org/series/49983/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add the missing HDMI gamut metadata packet stuff Okay! Commit: drm/

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Make user contexts bannable again!

2019-02-25 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 6095868a271d drm/i915: Complete kerneldoc for struct i915_gem_context. The bot has tested the following trees: v4.20.11, v4.19.24, v4.14.102. v4.20.11: Failed to apply! Possible d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Infoframe precompute/check (rev7)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Infoframe precompute/check (rev7) URL : https://patchwork.freedesktop.org/series/49983/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659 -> Patchwork_12299 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_switch: Use minimum qlen over all engines and measure switches

2019-02-25 Thread Caz Yokoyama
Chris, By your patch, measure_qlen() reports how many gem_execbuf() can be executed(queue length) within timeout of the slowest engine, correct? Run time becomes 95 sec which is less than half. -caz On Sat, 2019-02-23 at 01:34 +, Chris Wilson wrote: > Not all engines are created equal, and ou

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_switch: Use minimum qlen over all engines and measure switches

2019-02-25 Thread Chris Wilson
Quoting Caz Yokoyama (2019-02-25 18:28:34) > Chris, > By your patch, measure_qlen() reports how many gem_execbuf() can be > executed(queue length) within timeout of the slowest engine, correct? More or less, yes. -Chris ___ Intel-gfx mailing list Intel-g

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Replace global_seqno with a hangcheck heartbeat seqno

2019-02-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-25 17:59:40) > > On 25/02/2019 16:23, Chris Wilson wrote: > > static inline struct i915_priolist *to_priolist(struct rb_node *rb) > > { > > return rb_entry(rb, struct i915_priolist, node); > > @@ -2206,6 +2212,10 @@ static u32 *gen8_emit_fini_breadcrumb(st

Re: [Intel-gfx] [PATCH v2 3/3] drm/dsc: Split DSC PPS and SDP header initialisations

2019-02-25 Thread Manasi Navare
On Thu, Feb 21, 2019 at 03:20:01PM -0500, David Francis wrote: > The DP 1.4 spec defines the SDP header and SDP contents for > a Picture Parameter Set (PPS) that must be sent in advance > of DSC transmission to define the encoding characteristics. > > This was done in one struct, drm_dsc_pps_infof

Re: [Intel-gfx] [PATCH] drm/i915: Yet another if/else sort of newer to older platforms.

2019-02-25 Thread Rodrigo Vivi
On Mon, Feb 25, 2019 at 06:32:51PM +0200, Ville Syrjälä wrote: > On Fri, Feb 22, 2019 at 02:11:12PM -0800, Rodrigo Vivi wrote: > > No functional change. Just a reorg to match the preferred > > behavior. > > > > When rebasing internal branch on top of latest sort I noticed > > few more cases that n

[Intel-gfx] [PATCH] drm/i915: Yet another if/else sort of newer to older platforms.

2019-02-25 Thread Rodrigo Vivi
No functional change. Just a reorg to match the preferred behavior. When rebasing internal branch on top of latest sort I noticed few more cases that needs to get reordered. Let's do in a bundle this time and hoping there's no other missing places. v2: Check for HSW/BDW ULT before generic IS_HAS

Re: [Intel-gfx] [PATCH] drm/i915: extract AUX mask assignment to separate function

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 03:59:54PM -0800, Lucas De Marchi wrote: > No change in behavior, this only allows to more easily follow the flow > of gen8_de_irq_handler without the mask assignments for each platform. > This also re-organizes the branches a little bit, so the one-off case > for CNL_WITH_P

Re: [Intel-gfx] [PATCH 1/2] drm/i915: remove unused bits from Panel Power Sequence State

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 04:34:48PM -0800, Lucas De Marchi wrote: > No change in behavior. Just removing the unused bits since it makes it > easier to compare them on new platforms and one of them was wrong > (PP_SEQUENCE_STATE_ON_S1_0 vs the supposedly correct name > PP_SEQUENCE_STATE_ON_S1_1) > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: don't check internal state in PP_STATUS

2019-02-25 Thread Ville Syrjälä
On Fri, Feb 22, 2019 at 04:34:49PM -0800, Lucas De Marchi wrote: > Instead of checking the bits that give the internal machine state we can > simply rely on the information from the other bits: 1) on or off, > 2) transitioning or not. > > Bit 31 has the "Panel Power On Status" > Bits 29:28 has the

[Intel-gfx] ✓ Fi.CI.IGT: success for Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-25 Thread Patchwork
== Series Details == Series: Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers URL : https://patchwork.freedesktop.org/series/57187/ State : success == Summary == CI Bug Log - changes from CI_DRM_5658_full -> Patchwork_12296_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Yet another if/else sort of newer to older platforms. (rev2)

2019-02-25 Thread Patchwork
== Series Details == Series: drm/i915: Yet another if/else sort of newer to older platforms. (rev2) URL : https://patchwork.freedesktop.org/series/57112/ State : success == Summary == CI Bug Log - changes from CI_DRM_5659 -> Patchwork_12300

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-25 Thread Dave Airlie
On Tue, 19 Feb 2019 at 23:32, Joonas Lahtinen wrote: > > + dri-devel mailing list, especially for the buddy allocator part > > Quoting Dave Airlie (2019-02-15 02:47:07) > > On Fri, 15 Feb 2019 at 00:57, Matthew Auld wrote: > > > > > > In preparation for upcoming devices with device local memory,

[Intel-gfx] [PATCH 01/12] drm/i915: Store DIMM rank information as a number

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Life will be easier later if we have the ranks stored as a bare number. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 92 +++-- drivers/gpu/drm/i915/i915_drv.h | 11 ++-- 2 files changed, 45 insertions(+), 58 deletions(-) di

[Intel-gfx] [PATCH 02/12] drm/i915: Extract functions to derive SKL+ DIMM info

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Make the code less repetitive by extracting a few small helpers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 68 + 1 file changed, 43 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/driver

[Intel-gfx] [PATCH 05/12] drm/i915: Fix DRAM size reporting for BXT

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä The BXT DUNIT register tells us the size of each DRAM device in Gb. We want to report the size of the whole DIMM in GB, so that it matches how we report it for non-LP platforms. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 9 - 1 file changed,

[Intel-gfx] [PATCH 00/12] Polish DRAM information readout code

2019-02-25 Thread Ville Syrjala
From: Ville Syrjälä Try to pimp up the DRAM information readut code a bit. This is prep work for some DRAM bandwidth limit checks we'll be needing. Ville Syrjälä (12): drm/i915: Store DIMM rank information as a number drm/i915: Extract functions to derive SKL+ DIMM info drm/i915: Polish sk

  1   2   >