Re: [Intel-gfx] [PATCH v11 08/42] drm/i915: MEI interface definition

2019-02-08 Thread C, Ramalingam
On 2/8/2019 1:18 AM, Daniel Vetter wrote: On Thu, Feb 07, 2019 at 08:40:08PM +0100, Daniel Vetter wrote: On Thu, Feb 07, 2019 at 02:33:57AM +0530, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. v2: Adjust to the new interface changes. [T

Re: [Intel-gfx] [PATCH v2 07/13] drm/i915: Populate gamma_mode for all platforms

2019-02-08 Thread Maarten Lankhorst
Op 07-02-2019 om 17:27 schreef Ville Syrjälä: > On Thu, Feb 07, 2019 at 04:49:47PM +0100, Maarten Lankhorst wrote: >> Op 05-02-2019 om 17:08 schreef Ville Syrjala: >>> From: Ville Syrjälä >>> >>> On pre-HSW gamma mode is configured via PIPECONF. The bits are >>> the same except shifted up, so we c

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-02-08 Thread Daniel Vetter
On Fri, Feb 8, 2019 at 2:38 AM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from drivers/gpu/drm/arm/display/komeda/komeda_drv.c:13: > drivers/gpu/drm/arm/display/komeda/komeda_kms.h

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-02-08 Thread Daniel Vetter
On Fri, Feb 08, 2019 at 12:27:44PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/i915/intel_display.c > > between commit: > > 9f58892ea996 ("drm/i915: Pull all the reset functionality together into > i915_r

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Rebuild signal handler in child

2019-02-08 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-02-07 23:03:08) > Make sure that the SIGARLM handler is captured so that we don't > accidentally shoot ourselves in the foot instead of merely waking up the > execbuf. > > Signed-off-by: Chris Wilson Warming up the context ahead of time is reasonable for super low SKUs

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Rebuild signal handler in child

2019-02-08 Thread Chris Wilson
Quoting Joonas Lahtinen (2019-02-08 08:59:53) > Quoting Chris Wilson (2019-02-07 23:03:08) > > Make sure that the SIGARLM handler is captured so that we don't > > accidentally shoot ourselves in the foot instead of merely waking up the > > execbuf. > > > > Signed-off-by: Chris Wilson > > Warming

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-02-08 Thread Stephen Rothwell
Hi Daniel, On Fri, 8 Feb 2019 09:53:33 +0100 Daniel Vetter wrote: > > There isn't a "below" afaics Oops :-( However the merge diff is not very enlightening in this case anyway. It makes more sense to look at the final result when I finish up in a while. -- Cheers, Stephen Rothwell pgp

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Force the GPU reset upon wedging

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > When declaring the GPU wedged, we do need to hit the GPU with the reset > hammer so that its state matches our presumed state during cleanup. If > the reset fails, it fails, and we may be unhappy but wedged. However, if > we are testing our wedge/unwedged handling, the desy

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-02-08 Thread Daniel Vetter
On Fri, Feb 8, 2019 at 10:26 AM Stephen Rothwell wrote: > > Hi Daniel, > > On Fri, 8 Feb 2019 09:53:33 +0100 Daniel Vetter wrote: > > > > There isn't a "below" afaics > > Oops :-( However the merge diff is not very enlightening in this case > anyway. It makes more sense to look at the fina

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > On wedging, we mark all executing requests as complete and all pending > requests completed as soon as they are ready. Before unwedging though we > wish to flush those pending requests prior to restoring default > execution, and so we must wait. Do so interruptibly as we do

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Force the GPU reset upon wedging

2019-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-08 09:31:48) > Chris Wilson writes: > > > When declaring the GPU wedged, we do need to hit the GPU with the reset > > hammer so that its state matches our presumed state during cleanup. If > > the reset fails, it fails, and we may be unhappy but wedged. However, if

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2019-02-08 Thread Maxime Ripard
Hi Stephen, On Fri, Feb 08, 2019 at 12:32:04PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_probe': > drivers/gpu/drm/sun

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Rebuild signal handler in child

2019-02-08 Thread Joonas Lahtinen
+ Petri for the fact that igt_fork is actually igt_forkoontula and messes up set up signal handlers when transitioning to child. Quoting Chris Wilson (2019-02-08 11:01:55) > Quoting Joonas Lahtinen (2019-02-08 08:59:53) > > Quoting Chris Wilson (2019-02-07 23:03:08) > > > Make sure that the SIGARL

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Wait for old resets before applying debugfs/i915_wedged

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > Since we use the debugfs to recover the device after modifying the > i915.reset parameter, we need to be sure that we apply the reset and not > piggy-back onto a concurrent one in order for the parameter to take > effect. > > Signed-off-by: Chris Wilson > --- > drivers/gp

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-08 09:46:01) > Chris Wilson writes: > > > On wedging, we mark all executing requests as complete and all pending > > requests completed as soon as they are ready. Before unwedging though we > > wish to flush those pending requests prior to restoring default > > exec

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Wait for old resets before applying debugfs/i915_wedged

2019-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-08 09:56:59) > Chris Wilson writes: > > > Since we use the debugfs to recover the device after modifying the > > i915.reset parameter, we need to be sure that we apply the reset and not > > piggy-back onto a concurrent one in order for the parameter to take > > effe

[Intel-gfx] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), and dumping of JSON formatted records (-J), also to standard out. The first mode is selected automatically when non-interactive standard out is detected. Signed-off-by: Tvrtko Urs

Re: [Intel-gfx] [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-08 10:26:12) > From: Tvrtko Ursulin > > Two new output modes are added: listing of text data to standard out (-l > on the command line), and dumping of JSON formatted records (-J), also to > standard out. Any chance of interactive with yaml^W json to file? -Chris

Re: [Intel-gfx] [PATCH 2/4] components: multiple components for a device

2019-02-08 Thread Russell King - ARM Linux admin
On Fri, Feb 08, 2019 at 12:27:57AM +0100, Daniel Vetter wrote: > Component framework is extended to support multiple components for > a struct device. These will be matched with different masters based on > its sub component value. > > We are introducing this, as I915 needs two different component

Re: [Intel-gfx] [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-08 10:26:12) > +static unsigned int json_indent_level; > + > +static const char *json_indent[] = { > + "", > + "\t", > + "\t\t", > + "\t\t\t", > + "\t\t\t\t", > + "\t\t\t\t\t", > +}; > + > +#define ARRAY_SIZE(arr) (sizeof(arr)/size

Re: [Intel-gfx] [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Tvrtko Ursulin
On 08/02/2019 10:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-02-08 10:26:12) From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), and dumping of JSON formatted records (-J), also to standard out. Any chance of interacti

Re: [Intel-gfx] [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-08 10:52:19) > > On 08/02/2019 10:33, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-02-08 10:26:12) > >> From: Tvrtko Ursulin > >> > >> Two new output modes are added: listing of text data to standard out (-l > >> on the command line), and dumping of JSON fo

Re: [Intel-gfx] [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Tvrtko Ursulin
On 08/02/2019 10:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-02-08 10:52:19) On 08/02/2019 10:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-02-08 10:26:12) From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), an

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child

2019-02-08 Thread Chris Wilson
Still the blighted Starting subtest: pi-ringfull-bsd child 0 died with signal 14, Alarm clock Subtest pi-ringfull-bsd: FAIL (0.133s) So let's make sure our timer cannot fire later on during exit. References https://bugs.freedesktop.org/show_bug.cgi?id=109584 Signed-off-by: Chris Wilson Cc: Joon

Re: [Intel-gfx] [PATCH 2/4] components: multiple components for a device

2019-02-08 Thread Greg Kroah-Hartman
On Fri, Feb 08, 2019 at 12:27:57AM +0100, Daniel Vetter wrote: > Component framework is extended to support multiple components for > a struct device. These will be matched with different masters based on > its sub component value. > > We are introducing this, as I915 needs two different component

Re: [Intel-gfx] [PATCH 1/4] component: Add documentation

2019-02-08 Thread Greg Kroah-Hartman
On Fri, Feb 08, 2019 at 12:27:56AM +0100, Daniel Vetter wrote: > While typing these I think doing an s/component_master/aggregate/ > would be useful: > - it's shorter :-) > - I think component/aggregate is much more meaningful naming than > component/puppetmaster or something like that. At least

[Intel-gfx] [IGT 2/2] tools/intel_gpu_top: Add file output capability

2019-02-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new -o command switch enables logging to a file. Signed-off-by: Tvrtko Ursulin References: https://bugs.freedesktop.org/show_bug.cgi?id=108689 Cc: Eero Tamminen Cc: 3.1...@ukr.net Cc: Chris Wilson --- man/intel_gpu_top.rst | 18 - tools/intel_gpu_top.c | 63

[Intel-gfx] [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), and dumping of JSON formatted records (-J), also to standard out. The first mode is selected automatically when non-interactive standard out is detected. Example of text output:

Re: [Intel-gfx] [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-08 12:03:50) > From: Tvrtko Ursulin > > Two new output modes are added: listing of text data to standard out (-l > on the command line), and dumping of JSON formatted records (-J), also to > standard out. > > The first mode is selected automatically when non-inter

Re: [Intel-gfx] [IGT 2/2] tools/intel_gpu_top: Add file output capability

2019-02-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-08 12:03:51) > From: Tvrtko Ursulin > > A new -o command switch enables logging to a file. > > Signed-off-by: Tvrtko Ursulin > References: https://bugs.freedesktop.org/show_bug.cgi?id=108689 > Cc: Eero Tamminen > Cc: 3.1...@ukr.net > Cc: Chris Wilson > -

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Shankar, Uma
>> >> >-Original Message- >> >> >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >> >> >Sent: Tuesday, February 5, 2019 10:02 PM >> >> >To: Shankar, Uma >> >> >Cc: intel-gfx@lists.freedesktop.org; >> >> >dri-de...@lists.freedesktop.org; Syrjala, Ville >> >> >; Lankhorst, Maarten

Re: [Intel-gfx] [PATCH 13/13] drm/i915: Remove the fragile array index -> link rate mapping

2019-02-08 Thread Ville Syrjälä
On Thu, Feb 07, 2019 at 03:11:59PM -0800, Lucas De Marchi wrote: > On Thu, Feb 7, 2019 at 9:33 AM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > Rather than try to maintain some magic relationship between the link > > rates and the index into the wrpll params array let's just store >

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_scheduler: Disable alarm before exiting child

2019-02-08 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-02-08 13:41:09) > Still the blighted > > Starting subtest: pi-ringfull-bsd > child 0 died with signal 14, Alarm clock > Subtest pi-ringfull-bsd: FAIL (0.133s) > > So let's make sure our timer cannot fire later on during exit. This starts to reek like broken libc. The

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Sharma, Shashank
Regards Shashank > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Shankar, Uma > Sent: Friday, February 8, 2019 5:45 PM > To: Ville Syrjälä > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville > ; dri- > de...@lists.freedesktop.org;

[Intel-gfx] [PATCH 2/3] drm/i915/opregion: rvda is relative from opregion base in opregion 2.1+

2019-02-08 Thread Jani Nikula
Starting from opregion version 2.1 (roughly corresponding to ICL+) the RVDA field is relative from the beginning of opregion, not absolute address. Fix the error path while at it. v2: Make relative vs. absolute conditional on the opregion version, bumped for the purpose. Turned out there are

[Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

2019-02-08 Thread Jani Nikula
The u32 version field encodes major version in the high word. We've been checking for version >= 0.2. Add opregion version logging while at it. Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB") Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/g

[Intel-gfx] [PATCH 3/3] HACK: drm/i915/opregion: ICL should have opregion 2.1+ and relative rvda

2019-02-08 Thread Jani Nikula
Temporary CI workaround before proper opregion version bump propagates to the machines. Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_opregion

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Ville Syrjälä
On Fri, Feb 08, 2019 at 12:36:25PM +, Sharma, Shashank wrote: > Regards > Shashank > > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of > > Shankar, Uma > > Sent: Friday, February 8, 2019 5:45 PM > > To: Ville Syrjälä > > Cc:

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Sharma, Shashank
Regards Shashank On 2/8/2019 6:22 PM, Ville Syrjälä wrote: On Fri, Feb 08, 2019 at 12:36:25PM +, Sharma, Shashank wrote: Regards Shashank -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Shankar, Uma Sent: Friday, February 8, 2019 5

Re: [Intel-gfx] Fixes that failed to apply to v5.0-rc5

2019-02-08 Thread Aditya Swarup
On Tue, Feb 05, 2019 at 03:42:05PM +0200, Jani Nikula wrote: > > The following commits have been marked as Cc: stable or fixing something > in v5.0-rc5 or earlier, but failed to cherry-pick to > drm-intel-fixes. Please see if they are worth backporting, and please do > so if they are. > > Failed

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Ville Syrjälä
On Fri, Feb 08, 2019 at 06:36:39PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > On 2/8/2019 6:22 PM, Ville Syrjälä wrote: > > On Fri, Feb 08, 2019 at 12:36:25PM +, Sharma, Shashank wrote: > >> Regards > >> Shashank > >> > >>> -Original Message- > >>> From: Intel-gfx [mail

Re: [Intel-gfx] [IGT 1/2] tools/intel_gpu_top: Add support for stdout logging

2019-02-08 Thread Eero Tamminen
Hi, On 8.2.2019 14.03, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Two new output modes are added: listing of text data to standard out (-l on the command line), and dumping of JSON formatted records (-J), also to standard out. The first mode is selected automatically when non-interactive stan

[Intel-gfx] [PATCH] drm/i915: Protect i915_active iterators from the shrinker

2019-02-08 Thread Chris Wilson
If we allocate while iterating the rbtree of active nodes, we may hit the shrinker and so retire the i915_active reap the rbtree. Modifying the rbtree as we iterate is not good behaviour, so acquire the i915_active first to keep the tree intact whenever we allocate. Fixes: a42375af0a30 ("drm/i915:

[Intel-gfx] [PATCH 3/7] drm/i915: preparations for enabling P010, P012, P016 formats

2019-02-08 Thread swati2 . sharma
From: Juha-Pekka Heikkila Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 27 +-

[Intel-gfx] [PATCH 2/7] drm/i915: Add P010, P012, P016 plane control definitions

2019-02-08 Thread swati2 . sharma
From: Juha-Pekka Heikkila Add needed plane control flag definitions for P010, P012 and P016 formats. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h i

[Intel-gfx] [PATCH 6/7] drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions

2019-02-08 Thread swati2 . sharma
From: Swati Sharma Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and 16 bits) Signed-off-by: Swati Sharma Reviewed-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/dr

[Intel-gfx] [PATCH 5/7] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-02-08 Thread swati2 . sharma
From: Swati Sharma The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits. LSB 6 bits are filled with

[Intel-gfx] [PATCH 7/7] drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

2019-02-08 Thread swati2 . sharma
From: Swati Sharma In this patch, apart from enabling Y2xx and Y4xx pixel formats P0xx pixel formats are added too for ICL. Signed-off-by: Swati Sharma Reviewed-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 30 ++ drivers/gpu/drm/i915/intel_sprite.c | 60

[Intel-gfx] [PATCH 4/7] drm/i915: enable P010, P012, P016 formats for primary and sprite planes

2019-02-08 Thread swati2 . sharma
From: Juha-Pekka Heikkila Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_sprite.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/

[Intel-gfx] [PATCH 1/7] drm: Add P010, P012, P016 format definitions and fourcc

2019-02-08 Thread swati2 . sharma
From: Juha-Pekka Heikkila Add P010 definition, semi-planar yuv format where each component is 16 bits 10 msb containing color value. First come Y plane [10:6] followed by 2x2 subsampled Cr:Cb plane [10:6:10:6] Add P012 definition, semi-planar yuv format where each component is 16 bits 12 msb con

[Intel-gfx] [PATCH 0/7] Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats

2019-02-08 Thread swati2 . sharma
From: Swati Sharma In this patch series, Juha Pekka's patch series for Gen10+ P0xx formats https://patchwork.freedesktop.org/series/56053/ is combined with Swati's https://patchwork.freedesktop.org/series/55035/ for Gen11+ pixel formats (Y2xx and Y4xx). P0xx pixel formats are enabled from GLK wh

[Intel-gfx] [PATCH v2 0/2] drm/drv: Rework drm_dev_unplug() (was: Remove drm_dev_unplug())

2019-02-08 Thread Noralf Trønnes
This series makes drm_dev_unplug() compatible with the upcoming devm_drm_dev_init(), fixes a double drm_dev_unregister() situation and simplifies the drm_device ref handling wrt to the last fd closed after unregister. The first version of this patchset removed drm_dev_unplug(), see here for the di

[Intel-gfx] [PATCH v2 1/2] drm: Fix drm_release() and device unplug

2019-02-08 Thread Noralf Trønnes
If userspace has open fd(s) when drm_dev_unplug() is run, it will result in drm_dev_unregister() being called twice. First in drm_dev_unplug() and then later in drm_release() through the call to drm_put_dev(). Since userspace already holds a ref on drm_device through the drm_minor, it's not necess

[Intel-gfx] [PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

2019-02-08 Thread Noralf Trønnes
This makes it possible to use drm_dev_unplug() with the upcoming devm_drm_dev_init() which will do drm_dev_put() in its release callback. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: Dave Airlie Cc: Sean Paul Cc: Oleksandr Andrushchenko Cc: Daniel Vetter Signed-off-by:

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Sharma, Shashank
Regards Shashank On 2/8/2019 7:00 PM, Ville Syrjälä wrote: On Fri, Feb 08, 2019 at 06:36:39PM +0530, Sharma, Shashank wrote: Regards Shashank On 2/8/2019 6:22 PM, Ville Syrjälä wrote: On Fri, Feb 08, 2019 at 12:36:25PM +, Sharma, Shashank wrote: Regards Shashank -Original Message

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/opregion: fix version check

2019-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/opregion: fix version check URL : https://patchwork.freedesktop.org/series/56395/ State : warning == Summary == $ dim checkpatch origin/drm-tip d6761937ae7b drm/i915/opregion: fix version check 7b8f0501093b drm/i915/opregion: rvd

Re: [Intel-gfx] [PATCH v4 1/3] drm/fourcc: Add 64 bpp half float formats

2019-02-08 Thread Maarten Lankhorst
Op 06-02-2019 om 19:02 schreef Kevin Strasser: > Add 64 bpp 16:16:16:16 half float pixel formats. Each 16 bit component is > formatted in IEEE-754 half-precision float (binary16) 1:5:10 > MSb-sign:exponent:fraction form. > > This patch attempts to address the feedback provided when 2 of these > for

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/opregion: fix version check

2019-02-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/opregion: fix version check URL : https://patchwork.freedesktop.org/series/56395/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5567 -> Patchwork_12175 Summar

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Serialise resets with wedging

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > Prevent concurrent set-wedge with ongoing resets (and vice versa) by > taking the same wedge_mutex around both operations. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_reset.c | 68 ++- > 1 fil

Re: [Intel-gfx] [PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

2019-02-08 Thread Oleksandr Andrushchenko
On 2/8/19 4:01 PM, Noralf Trønnes wrote: This makes it possible to use drm_dev_unplug() with the upcoming devm_drm_dev_init() which will do drm_dev_put() in its release callback. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: Dave Airlie Cc: Sean Paul Cc: Oleksandr Andru

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Ville Syrjälä
On Fri, Feb 08, 2019 at 07:36:24PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > On 2/8/2019 7:00 PM, Ville Syrjälä wrote: > > On Fri, Feb 08, 2019 at 06:36:39PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> On 2/8/2019 6:22 PM, Ville Syrjälä wrote: > >>> On

[Intel-gfx] [PATCH i-g-t 1/2] kms_fence_pin_leak: Ask for the GPU before use

2019-02-08 Thread Chris Wilson
Check that the GPU even exists before submitting a batch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109589 Signed-off-by: Chris Wilson --- tests/kms_fence_pin_leak.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_fence_pin_leak.c b/tests/kms_fence_pin_leak.c index 62c

[Intel-gfx] [PATCH i-g-t 2/2] kms_fence_pin_leak: Move beneath i915/

2019-02-08 Thread Chris Wilson
kms_fence_pin_leak tests smooth sharp edges that are i915 specific (and requires using GEM to do so). It doesn't belong in the general paddock of all driver tests, so move it into the i915/ stable. Signed-off-by: Chris Wilson Cc: Arkadiusz Hiler Cc: Petri Latvala --- tests/Makefile.sources

Re: [Intel-gfx] [PATCH i-g-t v4 0/5] DC states igt tests patch series

2019-02-08 Thread Imre Deak
Hi, On Fri, Feb 01, 2019 at 09:42:57PM +0530, Anshuman Gupta wrote: > This patch series adds new tests to validate Display C states. > DC states like DC5 and DC6 are validated during PSR entry/exit > and during DPMS on/off cycle. > Sending new revision of patch series after addressing review comme

Re: [Intel-gfx] [PATCH i-g-t v4 1/5] lib/igt_pm: Moves Dmc_loaded() function into library

2019-02-08 Thread Imre Deak
On Fri, Feb 01, 2019 at 09:42:58PM +0530, Anshuman Gupta wrote: > From: Jyoti Yadav > > It will be used by new test pm_dc.c which will validate Display C States. > So moving the same to igt_pm library. > > v2: Simplify the comment section. > v3: Remove . from the subject line. > v4: Rebased and

Re: [Intel-gfx] [PATCH] drm/i915: Don't claim an unstarted request was guilty

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > If we haven't even begun executing the payload of the stalled request, > then we should not claim that its userspace context was guilty of > submitting a hanging batch. > > v2: Check for context corruption before trying to restart. > v3: Preserve semaphores on skipping requ

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/icl: Implement half float formats

2019-02-08 Thread Maarten Lankhorst
Op 06-02-2019 om 19:02 schreef Kevin Strasser: > 64 bpp half float formats are supported on hdr planes only and are subject > to the following restrictions: > * 90/270 rotation not supported > * Yf Tiling not supported > * Frame Buffer Compression not supported > * Color Keying not supporte

Re: [Intel-gfx] [PATCH v4 0/3] Support 64 bpp half float formats

2019-02-08 Thread Maarten Lankhorst
Op 06-02-2019 om 19:02 schreef Kevin Strasser: > This series defines new formats and adds implementation to the i915 driver. > Since posting v1 I have removed the pixel normalize property, as it's not > needed > for basic functionality. Also, I have been working on adding support to > userspace, b

Re: [Intel-gfx] [PATCH i-g-t v4 2/5] tests/pm_dc: Added new test to verify Display C States

2019-02-08 Thread Imre Deak
On Fri, Feb 01, 2019 at 09:42:59PM +0530, Anshuman Gupta wrote: > From: Jyoti Yadav > > Currently this test validates DC5 upon PSR entry for supported platforms. > Added new file for compilation inside Makefile and Meson. > > v2: Used the debugfs entry for DC counters instead of Registers. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Protect i915_active iterators from the shrinker

2019-02-08 Thread Patchwork
== Series Details == Series: drm/i915: Protect i915_active iterators from the shrinker URL : https://patchwork.freedesktop.org/series/56401/ State : success == Summary == CI Bug Log - changes from CI_DRM_5567 -> Patchwork_12176 Summary

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_fence_pin_leak: Move beneath i915/

2019-02-08 Thread Petri Latvala
On Fri, Feb 08, 2019 at 02:44:58PM +, Chris Wilson wrote: > kms_fence_pin_leak tests smooth sharp edges that are i915 specific (and > requires using GEM to do so). It doesn't belong in the general paddock > of all driver tests, so move it into the i915/ stable. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t v4 5/5] tests/pm_dc: Added test for DC6 during DPMS

2019-02-08 Thread Imre Deak
On Fri, Feb 01, 2019 at 09:43:02PM +0530, Anshuman Gupta wrote: > From: Jyoti Yadav > > Added new subtest for DC6 entry during DPMS on/off cycle. > During DPMS on/off cycle DC6 counter is incremented. > > v2: Renamed the subtest name. > v3: Rebased. > v4: Rebased and address review comment. > >

Re: [Intel-gfx] [PATCH] drm/i915: Don't claim an unstarted request was guilty

2019-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-08 14:47:13) > Chris Wilson writes: > > > If we haven't even begun executing the payload of the stalled request, > > then we should not claim that its userspace context was guilty of > > submitting a hanging batch. > > > > v2: Check for context corruption before try

Re: [Intel-gfx] [PATCH 5/7] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-02-08 Thread Maarten Lankhorst
Op 08-02-2019 om 14:47 schreef swati2.sha...@intel.com: > From: Swati Sharma > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > allocated 16 bits each. Thus each pixel occupies 32bit. > > Y210: For each component, va

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, February 8, 2019 8:08 PM >To: Sharma, Shashank >Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >Syrjala, Ville ; dri-de...@lists.freedesktop.org; >Lankhorst, >Maarten >Subject: Re: [Inte

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-02-08 09:46:01) >> Chris Wilson writes: >> >> > On wedging, we mark all executing requests as complete and all pending >> > requests completed as soon as they are ready. Before unwedging though we >> > wish to flush those pending requests prior

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

2019-02-08 Thread Jani Nikula
On Fri, 08 Feb 2019, Jani Nikula wrote: > The u32 version field encodes major version in the high word. We've been > checking for version >= 0.2. > > Add opregion version logging while at it. > > Fixes: 04ebaadb9f2d ("drm/i915/opregion: handle VBT sizes bigger than 6 KB") > Cc: Ville Syrjälä > Cc

Re: [Intel-gfx] [PATCH 1/3] drm/i915/opregion: fix version check

2019-02-08 Thread Imre Deak
On Fri, Feb 08, 2019 at 05:09:51PM +0200, Jani Nikula wrote: > On Fri, 08 Feb 2019, Jani Nikula wrote: > > The u32 version field encodes major version in the high word. We've been > > checking for version >= 0.2. > > > > Add opregion version logging while at it. > > > > Fixes: 04ebaadb9f2d ("drm/i

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2019-02-08 15:07:55) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2019-02-08 09:46:01) > >> Chris Wilson writes: > >> > >> > On wedging, we mark all executing requests as complete and all pending > >> > requests completed as soon as they are ready. Before unwedging

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats

2019-02-08 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats URL : https://patchwork.freedesktop.org/series/56402/ State : warning == Summary == $ dim checkpatch origin/drm-tip 38dc7fc809e3 drm: Add P010, P012, P016 format definitions and fourcc -:28: WARNING:LONG_LI

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats

2019-02-08 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats URL : https://patchwork.freedesktop.org/series/56402/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: Add P010, P012, P016 format definitions and fourcc Okay!

Re: [Intel-gfx] [PATCH 2/4] components: multiple components for a device

2019-02-08 Thread Daniel Vetter
On Fri, Feb 08, 2019 at 10:28:49AM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 08, 2019 at 12:27:57AM +0100, Daniel Vetter wrote: > > Component framework is extended to support multiple components for > > a struct device. These will be matched with different masters based on > > its

Re: [Intel-gfx] [RFC 1/6] drm/i915/dp: Support DP ports YUV 4:2:0 output to GEN11

2019-02-08 Thread Maarten Lankhorst
Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > Bspec describes that GEN10 only supports capability of YUV 4:2:0 output to > HDMI port and GEN11 supports capability of YUV 4:2:0 output to both DP and > HDMI ports. > > Signed-off-by: Gwan-gyeong Mun > --- > drivers/gpu/drm/i915/intel_dp.c | 3 ++

Re: [Intel-gfx] [PATCH 1/4] component: Add documentation

2019-02-08 Thread Daniel Vetter
On Fri, Feb 08, 2019 at 12:51:23PM +0100, Greg Kroah-Hartman wrote: > On Fri, Feb 08, 2019 at 12:27:56AM +0100, Daniel Vetter wrote: > > While typing these I think doing an s/component_master/aggregate/ > > would be useful: > > - it's shorter :-) > > - I think component/aggregate is much more meani

Re: [Intel-gfx] [RFC 6/6] drm/i915/dp: Update pipe_bpp for DP YCbCr4:2:0 outputs

2019-02-08 Thread Maarten Lankhorst
Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > pipe_bpp value was assumed RGB therefore it was multiplied with 3. > But YCbCr 4:2:0 requires multiplier value to 1.5 therefore it divides > pipe_bpp to 2. > - RGB bpp = bpc x 3 > - YCbCr 4:2:0 bpp = bpc x 1.5 > > Signed-off-by: Gwan-gyeong Mun >

Re: [Intel-gfx] [RFC 4/6] drm/i915/dp: Program VSC Header and DB for Pixel Encoding/Colorimetry Format

2019-02-08 Thread Maarten Lankhorst
Op 31-01-2019 om 22:10 schreef Gwan-gyeong Mun: > Function intel_pixel_encoding_setup_vsc handles vsc header and data block > setup for pixel encoding / colorimetry format. > > Setup VSC header and data block in function intel_pixel_encoding_setup_vsc > for pixel encoding / colorimetry format as pe

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats

2019-02-08 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx and Y4xx (packed) pixel formats URL : https://patchwork.freedesktop.org/series/56402/ State : success == Summary == CI Bug Log - changes from CI_DRM_5567 -> Patchwork_12177 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Don't claim an unstarted request was guilty

2019-02-08 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-02-08 14:47:13) >> Chris Wilson writes: >> >> > If we haven't even begun executing the payload of the stalled request, >> > then we should not claim that its userspace context was guilty of >> > submitting a hanging batch. >> > >> > v2: Check f

Re: [Intel-gfx] [v11 1/4] drm: Add HDMI colorspace property

2019-02-08 Thread Ville Syrjälä
On Fri, Feb 08, 2019 at 03:03:34PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Friday, February 8, 2019 8:08 PM > >To: Sharma, Shashank > >Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > >Syrjala, Ville

Re: [Intel-gfx] [PATCH 2/4] components: multiple components for a device

2019-02-08 Thread Daniel Vetter
On Fri, Feb 8, 2019 at 4:23 PM Daniel Vetter wrote: > > On Fri, Feb 08, 2019 at 10:28:49AM +, Russell King - ARM Linux admin > wrote: > > On Fri, Feb 08, 2019 at 12:27:57AM +0100, Daniel Vetter wrote: > > > Component framework is extended to support multiple components for > > > a struct devi

[Intel-gfx] [CI 1/7] drm/i915: Defer removing fence register tracking to rpm wakeup

2019-02-08 Thread Chris Wilson
Currently, we may simultaneously release the fence register from both fence_update() and i915_gem_restore_fences(). This is dangerous, so defer the bookkeeping entirely to i915_gem_restore_fences() when the device is asleep. Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Cc: Mika Kuoppal

[Intel-gfx] [CI 4/7] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-08 Thread Chris Wilson
On wedging, we mark all executing requests as complete and all pending requests completed as soon as they are ready. Before unwedging though we wish to flush those pending requests prior to restoring default execution, and so we must wait. Do so uninterruptibly as we do not provide the EINTR gracef

[Intel-gfx] [CI 7/7] drm/i915: Don't claim an unstarted request was guilty

2019-02-08 Thread Chris Wilson
If we haven't even begun executing the payload of the stalled request, then we should not claim that its userspace context was guilty of submitting a hanging batch. v2: Check for context corruption before trying to restart. v3: Preserve semaphores on skipping requests (need to keep the timelines i

[Intel-gfx] [CI 2/7] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-08 Thread Chris Wilson
Previously, we were able to rely on the recursive properties of struct_mutex to allow us to serialise revoking mmaps and reacquiring the FENCE registers with them being clobbered over a global device reset. I then proceeded to throw out the baby with the bath water in order to pursue a struct_mutex

[Intel-gfx] [CI 6/7] drm/i915: Serialise resets with wedging

2019-02-08 Thread Chris Wilson
Prevent concurrent set-wedge with ongoing resets (and vice versa) by taking the same wedge_mutex around both operations. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_reset.c | 68 ++- 1 file changed, 40 insertions(+), 28 deleti

[Intel-gfx] [CI 3/7] drm/i915: Force the GPU reset upon wedging

2019-02-08 Thread Chris Wilson
When declaring the GPU wedged, we do need to hit the GPU with the reset hammer so that its state matches our presumed state during cleanup. If the reset fails, it fails, and we may be unhappy but wedged. However, if we are testing our wedge/unwedged handling, the desync carries over into the next t

[Intel-gfx] [CI 5/7] drm/i915: Wait for old resets before applying debugfs/i915_wedged

2019-02-08 Thread Chris Wilson
Since we use the debugfs to recover the device after modifying the i915.reset parameter, we need to be sure that we apply the reset and not piggy-back onto a concurrent one in order for the parameter to take effect. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 1/4] component: Add documentation

2019-02-08 Thread Daniel Vetter
On Fri, Feb 8, 2019 at 4:29 PM Daniel Vetter wrote: > > On Fri, Feb 08, 2019 at 12:51:23PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Feb 08, 2019 at 12:27:56AM +0100, Daniel Vetter wrote: > > > While typing these I think doing an s/component_master/aggregate/ > > > would be useful: > > > - it's

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drv: Rework drm_dev_unplug() (was: Remove drm_dev_unplug())

2019-02-08 Thread Patchwork
== Series Details == Series: drm/drv: Rework drm_dev_unplug() (was: Remove drm_dev_unplug()) URL : https://patchwork.freedesktop.org/series/56404/ State : success == Summary == CI Bug Log - changes from CI_DRM_5567 -> Patchwork_12178 Summar

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915: Defer removing fence register tracking to rpm wakeup

2019-02-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915: Defer removing fence register tracking to rpm wakeup URL : https://patchwork.freedesktop.org/series/56412/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Defer removing fen

  1   2   3   >