[Intel-gfx] [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

Delay the drm_modeset_acquire_init() until after we check for an allocation failure so that we can return immediately upon error without having to unwind. WARNING: lock held when returning to user space! 4.20.0+ #174 Not tainted syz-executor556/8153

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

== Series Details == Series: drm: Reorder set_property_atomic to avoid returning with an active ww_ctx URL : https://patchwork.freedesktop.org/series/54547/ State : success == Summary == CI Bug Log - changes from CI_DRM_5349 -> Patchwork_11169 =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

== Series Details == Series: drm: Reorder set_property_atomic to avoid returning with an active ww_ctx URL : https://patchwork.freedesktop.org/series/54547/ State : success == Summary == CI Bug Log - changes from CI_DRM_5349_full -> Patchwork_11169_full ===

Re: [Intel-gfx] [PATCH v2] drm: un-inline drm_legacy_findmap()

Hi Jani, Thank you for the patch. On Friday, 28 December 2018 15:04:46 EET Jani Nikula wrote: > Also include drm_hashtab.h and add struct drm_device forward declaration > in drm_legacy.h to make it more self-contained. Make it easier to drop > drmP.h includes. > > v2: avoid including drm_device.

Re: [Intel-gfx] [PATCH 3/6] drm: include idr.h from drm_file.h

Hi Jani, Thank you for the patch. On Thursday, 27 December 2018 14:56:38 EET Jani Nikula wrote: > Make it easier to drop drmP.h includes. How about explaining why idr.h is needed ? "drm_file.h embeds idr structures in DRM-specific structures. Include the corresponding header to make drm_file.h

Re: [Intel-gfx] [PATCH 4/6] drm: include types.h from drm_hdcp.h

Hi Jani, Thank you for the patch. On Thursday, 27 December 2018 14:56:39 EET Jani Nikula wrote: > Make it easier to drop drmP.h includes. Same comment as for the previous patches, let's explain the reason. "drm_hdcp.h uses kernel integer types, make it self-contained by including linux/kernel.

Re: [Intel-gfx] [PATCH v2] drm: forward declare struct drm_file in drm_syncobj.h

Hi Jani, Thank you for the patch. On Friday, 28 December 2018 10:28:15 EET Jani Nikula wrote: > Make it easier to drop drmP.h includes. Switch from "" to <> includes > while at it. > > v2: forward declare instead of including drm_file.h (Daniel) Reviewed-by: Laurent Pinchart but with the same