As amd_uvd_resume() accesses the uvd ring, it must be initialised first
or else we trigger errors like:
[5.595963] [drm] Found UVD firmware Version: 1.87 Family ID: 17
[5.595969] [drm] PSP loading UVD firmware
[5.596266] [ cut here ]
[5.596268] ODEBUG: asser
== Series Details ==
Series: drm/amdgpu: Reorder uvd ring init before uvd resume
URL : https://patchwork.freedesktop.org/series/52601/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150 -> Patchwork_10836 =
== Summary - SUCCESS ==
No regressions found.
External URL:
Quoting Jani Nikula (2018-11-15 14:01:22)
> Reduce bloat in one of the bigger header files. Fix some indentation
> while at it. No functional changes.
>
> Signed-off-by: Jani Nikula
Do add include guards. Then this is:
Reviewed-by: Joonas Lahtinen
Regards, Joonas
_
Quoting Jani Nikula (2018-11-15 14:01:23)
> While at it, conform to kernel spacing (i.e. no space) after cast. No
> functional changes.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@l
Quoting Jani Nikula (2018-11-15 14:01:24)
> No need to use a compound statement enclosed in parenthesis where a C99
> compound literal will do. No functional changes.
>
> Signed-off-by: Jani Nikula
Out of curiosity, did this have an effect on asm generation?
Presumably not.
Reviewed-by: Joonas
Quoting Jani Nikula (2018-11-15 14:01:25)
> Simply return the condition. No functional changes.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freed
On 14/11/2018 13:22, Ville Syrjälä wrote:
On Wed, Nov 14, 2018 at 12:08:06PM +, Lionel Landwerlin wrote:
We've been dealing a number of 32/64 bits flags issues lately :
- 085603287452fc ("drm/i915: Compare user's 64b GTT offset even on 32b")
- c58281056a8b26 ("drm/i915: Mark up GTT size
On Fri, 16 Nov 2018, Joonas Lahtinen wrote:
> Quoting Jani Nikula (2018-11-15 14:01:22)
>> Reduce bloat in one of the bigger header files. Fix some indentation
>> while at it. No functional changes.
>>
>> Signed-off-by: Jani Nikula
>
> Do add include guards. Then this is:
D'oh!
> Reviewed-by:
Quoting Jani Nikula (2018-11-15 12:01:24)
> No need to use a compound statement enclosed in parenthesis where a C99
> compound literal will do. No functional changes.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_fixed.h | 6 +-
> 1 file changed, 1 insertion(+), 5 deletion
On Fri, 16 Nov 2018, Joonas Lahtinen wrote:
> Quoting Jani Nikula (2018-11-15 14:01:24)
>> No need to use a compound statement enclosed in parenthesis where a C99
>> compound literal will do. No functional changes.
>>
>> Signed-off-by: Jani Nikula
>
> Out of curiosity, did this have an effect on
Quoting Jani Nikula (2018-11-15 14:01:26)
> Clean up fixed point temp variable initialization, use the more
> conventional tmp name for temp variables, add empty lines before
> return. No functional changes.
>
> Signed-off-by: Jani Nikula
> static inline uint_fixed_16_16_t clamp_u64_to_fixed1
On Fri, Nov 16, 2018 at 10:43:39AM +, Lionel Landwerlin wrote:
> On 14/11/2018 13:22, Ville Syrjälä wrote:
> > On Wed, Nov 14, 2018 at 12:08:06PM +, Lionel Landwerlin wrote:
> >> We've been dealing a number of 32/64 bits flags issues lately :
> >>
> >> - 085603287452fc ("drm/i915: Compare
Quoting Lionel Landwerlin (2018-11-09 19:51:17)
> I think we have some interest in reviving this for the performance query
> use case.
How are performance queries related?
Regards, Joonas
> Is that on anybody's todo list?
>
> Thanks,
>
> -
> Lionel
>
> On 14/03/2018 09:37, Chris Wilson wrote
On 16/11/2018 11:14, Joonas Lahtinen wrote:
Quoting Lionel Landwerlin (2018-11-09 19:51:17)
I think we have some interest in reviving this for the performance query
use case.
How are performance queries related?
People want performance measured at a given frequency (usually max).
Regards
== Series Details ==
Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2)
URL : https://patchwork.freedesktop.org/series/52440/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150 -> Patchwork_10837 =
== Summary - SUCCESS ==
No regressions found.
Externa
== Series Details ==
Series: drm/amdgpu: Reorder uvd ring init before uvd resume
URL : https://patchwork.freedesktop.org/series/52601/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150_full -> Patchwork_10836_full =
== Summary - SUCCESS ==
No regressions found.
==
Quoting Chris Wilson (2018-11-02 18:12:12)
> Since capturing the error state requires fiddling around with the GGTT
> to read arbitrary buffers and is itself run under stop_machine(), it
> deadlocks the machine (effectively a hard hang) when run in conjunction
> with Broxton's VTd workaround to ser
Reduce bloat in one of the bigger header files. Fix some indentation
while at it. No functional changes.
v2: Add include guards (Joonas)
Reviewed-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 139 +--
drivers/gpu/drm/i915
Simply return the condition. No functional changes.
Reviewed-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_fixed.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_fixed.h
b/drivers/gpu/drm/i915/i915_fixed.h
index d
Clean up fixed point temp variable initialization, use the more
conventional tmp name for temp variables, add empty lines before
return. No functional changes.
Reviewed-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_fixed.h | 77 +---
No need to use a compound statement enclosed in parenthesis where a C99
compound literal will do. No functional changes.
Reviewed-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_fixed.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers
While at it, conform to kernel spacing (i.e. no space) after cast. No
functional changes.
Reviewed-by: Joonas Lahtinen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_fixed.h | 61 +++
1 file changed, 29 insertions(+), 32 deletions(-)
diff --git a/d
== Series Details ==
Series: series starting with [v2,1/5] drm/i915: extract fixed point math to
i915_fixed.h
URL : https://patchwork.freedesktop.org/series/52608/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8b6b415c312d drm/i915: extract fixed point math to i915_fixed.h
-:1
== Series Details ==
Series: series starting with [v2,1/5] drm/i915: extract fixed point math to
i915_fixed.h
URL : https://patchwork.freedesktop.org/series/52608/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: extract fixed point math to i9
Quoting Lionel Landwerlin (2018-10-23 13:07:07)
> The way our hardware is designed doesn't seem to let us use the
> MI_RECORD_PERF_COUNT command without setting up a circular buffer.
>
> In the case where the user didn't request OA reports to be available
> through the i915 perf stream, we can set
== Series Details ==
Series: series starting with [v2,1/5] drm/i915: extract fixed point math to
i915_fixed.h
URL : https://patchwork.freedesktop.org/series/52608/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150 -> Patchwork_10838 =
== Summary - SUCCESS ==
No regress
== Series Details ==
Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2)
URL : https://patchwork.freedesktop.org/series/52440/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150 -> Patchwork_10839 =
== Summary - SUCCESS ==
No regressions found.
Externa
== Series Details ==
Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2)
URL : https://patchwork.freedesktop.org/series/52440/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150_full -> Patchwork_10837_full =
== Summary - WARNING ==
Minor unknown changes
Userspace portion is still missing.
This reverts commit cd956bfcd0f58d20485ac0a785415f7d9327a95f.
Cc: Lionel Landwerlin
Cc: Matthew Auld
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/i915_perf.c | 99 +++-
drivers/
Userspace portion is still missing.
This reverts commit 9fa6e2f7609fdbb7d6f86be86371a5719bec0376.
Cc: Lionel Landwerlin
Cc: Matthew Auld
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_perf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/dr
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/perf: add a parameter to
control the size of OA buffer"
URL : https://patchwork.freedesktop.org/series/52612/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b808c374682f Revert "drm/i915/perf: add a parame
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/perf: add a parameter to
control the size of OA buffer"
URL : https://patchwork.freedesktop.org/series/52612/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: Revert "drm/i915/perf
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/perf: add a parameter to
control the size of OA buffer"
URL : https://patchwork.freedesktop.org/series/52612/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5150 -> Patchwork_10840 =
== Summary - FAILU
Quoting Xu, Terrence (2018-10-19 10:04:47)
> Platform Support:
>
> -Server platforms: Intel(r) Xeon(r) E3_v4, E3_v5 and E3_v6 with Intel
> Graphics processor
>
> -Client platforms: Intel(r) Core(tm) 5th generation (code name:
> Broadwell),
> 6th generation (code name: Skylake), 7th gener
Hide the enable_gvt modparam in the default scenario where
support has not been compiled in.
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: Chris Wilson
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_params.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_para
Quoting Joonas Lahtinen (2018-11-16 14:44:47)
> Hide the enable_gvt modparam in the default scenario where
> support has not been compiled in.
>
> Cc: Zhenyu Wang
> Cc: Zhi Wang
> Cc: Chris Wilson
> Signed-off-by: Joonas Lahtinen
Alternative would be to move the param into a gvt-only file.c
Quoting Chris Wilson (2018-10-12 14:56:21)
> Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
> objects was flawed due to the simple fact that we do not always know the
> swizzling for a particular page (due to the swizzling varying based on
> location in certain unbalanced con
Quoting Chris Wilson (2018-10-09 14:12:59)
> If we have released no firmware yet for a platform, stop scaring the
> consumer and merely note its expected absence.
>
> Signed-off-by: Chris Wilson
> Cc: Petri Latvala
Reviewed-by: Joonas Lahtinen
Regards, Joonas
_
== Series Details ==
Series: drm/i915: Hide enable_gvt modparam when not compiled in
URL : https://patchwork.freedesktop.org/series/52616/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5151 -> Patchwork_10841 =
== Summary - SUCCESS ==
No regressions found.
External UR
On Friday, November 16, 2018 7:02:04 AM PST Joonas Lahtinen wrote:
> Quoting Chris Wilson (2018-10-12 14:56:21)
> > Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
> > objects was flawed due to the simple fact that we do not always know the
> > swizzling for a particular page
== Series Details ==
Series: series starting with [1/3] drm/i915/icl: Release TC ports when
unloading or suspending driver
URL : https://patchwork.freedesktop.org/series/52195/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5152 -> Patchwork_10842 =
== Summary - SUCCESS ==
On Fri, Nov 16, 2018 at 02:07:26PM +0200, Jani Nikula wrote:
> While at it, conform to kernel spacing (i.e. no space) after cast. No
> functional changes.
could we do a sed or cocinelle patch for a massive update on this?
>
> Reviewed-by: Joonas Lahtinen
> Signed-off-by: Jani Nikula
> ---
> d
On Thu, Nov 15, 2018 at 11:48:06AM -0800, clinton.a.tay...@intel.com wrote:
> From: Clint Taylor
>
> The calibration RCOMP value in PORT_TX_DW6 in stored in dev_priv during
> driver init. Use this value instead of reading the register again as the
> power well for PORTA RCOMP register may not be
On Thu, Nov 15, 2018 at 11:48:06AM -0800, clinton.a.tay...@intel.com wrote:
> From: Clint Taylor
>
> The calibration RCOMP value in PORT_TX_DW6 in stored in dev_priv during
> driver init. Use this value instead of reading the register again as the
> power well for PORTA RCOMP register may not be
== Series Details ==
Series: drm/dp_mst: Improve VCPI helpers, use in nouveau (rev6)
URL : https://patchwork.freedesktop.org/series/51412/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5152 -> Patchwork_10843 =
== Summary - SUCCESS ==
No regressions found.
External UR
Noralf Trønnes writes:
> This adds functionality to the CMA helper which ensures that the kernel
> virtual address is set on the CMA GEM object also for imported buffers.
>
> The drivers have been audited to ensure that none set ->vaddr on imported
> buffers, making the conditional dma_buf_vunmap
== Series Details ==
Series: series starting with [v2,1/5] drm/i915: extract fixed point math to
i915_fixed.h
URL : https://patchwork.freedesktop.org/series/52608/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150_full -> Patchwork_10838_full =
== Summary - SUCCESS ==
== Series Details ==
Series: drm/i915: Disable LP3 watermarks on all SNB machines (rev2)
URL : https://patchwork.freedesktop.org/series/52440/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5150_full -> Patchwork_10839_full =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: drm/i915: Hide enable_gvt modparam when not compiled in
URL : https://patchwork.freedesktop.org/series/52616/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5151_full -> Patchwork_10841_full =
== Summary - WARNING ==
Minor unknown changes comi
So we don't ever have to worry about drivers touching drm_dp_mst_port
structs without verifying them and crashing again.
Lyude Paul (6):
drm/dp_mst: Add drm_dp_get_payload_info()
drm/nouveau: Use drm_dp_get_payload_info() for getting payload/vcpi
drm/nouveau: Stop reading port->mgr in nv50_m
Originally we started storing pointers to the drm_dp_mst_port struct for
each intel_connector as void* to stop people from trying to dereference
them. Now that we've removed the public struct definition for
drm_dp_mst_port however, it's no longer possible to dereference the port
structure even when
mstc->port isn't validated here so it could be null or worse when we
access it. And drivers aren't ever supposed to be looking at it's
contents anyway. Plus, we can already get the MST manager from
&mstc->mstm->mgr.
Signed-off-by: Lyude Paul
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/nouveau
Some hardware (nvidia hardware in particular) needs to be notified of
the exact VCPI and payload settings that the topology manager decided on
for each mstb port. Since there isn't currently any way to get this
information without going through port (which drivers are very much not
supposed to do b
It hasn't been OK to access any of the contents of struct
drm_dp_mst_port without validating the port first for quite a long time
now, since a drm_dp_mst_port structure can be freed at any given moment
in time outside of the driver's contorl. Any kind of information a
driver needs from drm_dp_mst_p
Same as the previous commit, but for nv50_mstc_detect() this time.
Signed-off-by: Lyude Paul
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouve
Currently, nouveau tries to go through the drm_dp_mst_port structures
itself in order to retrieve the relevant payload and VCPI information
that it needs to report to the GPU. This is wrong: mstc->port could be
destroyed at any point, and additionally the payload could be changed at
any point becau
Like it was done in commit 9e180d9991dc ("drm/i915: Downgrade unknown
firmware warnings") for huc and guc: downgrade CSR firmware warnings. If
we have released no firmware yet for a platform, stop scaring the
consumer and merely note its expected absence.
By simply removing the warning and early r
Before commit d8a5b7d79fb7 ("drm/i915/csr: keep max firmware size together
with firmare name and version") it was possible to load the firmware for
testing purposes via parameter. Let's use the size of the last known
platform to recover that behavior.
Cc: Jani Nikula
Cc: Rodrigo Vivi
Signed-off-
== Series Details ==
Series: Remove all bad dp_mst_port uses and hide struct def
URL : https://patchwork.freedesktop.org/series/52636/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5154 -> Patchwork_10844 =
== Summary - SUCCESS ==
No regressions found.
External URL:
== Series Details ==
Series: series starting with [1/2] drm/i915: allow to load DMC firmware on next
gen
URL : https://patchwork.freedesktop.org/series/52639/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5154 -> Patchwork_10845 =
== Summary - FAILURE ==
Serious unknown
60 matches
Mail list logo
