[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry. (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry. (rev2) URL : https://patchwork.freedesktop.org/series/49800/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10317_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH] [intel-gfx] drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry.

2018-10-02 Thread Chris Wilson
Quoting Jyoti Yadav (2018-10-02 05:42:27) > DC5 and DC6 counter register tells about residency of DC5 and DC6. > These registers are same for SKL and ICL. > > v2 : Remove csr_version check. > Added generic check regarding DC counters for Gen9 onwards. (Rodrigo) > > Signed-off-by: Jyoti Yada

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) URL : https://patchwork.freedesktop.org/series/49312/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10318 = == Summary - SUCCESS == No regressions found. External URL: https:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) URL : https://patchwork.freedesktop.org/series/49312/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10319 = == Summary - SUCCESS == No regressions found. External URL: https:

Re: [Intel-gfx] [PATCH 17/18] drm/i915: Check infoframe state in intel_pipe_config_compare()

2018-10-02 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 11:35:05PM +0300, Ville Syrjälä wrote: > On Mon, Sep 24, 2018 at 06:12:27PM +0200, Daniel Vetter wrote: > > On Thu, Sep 20, 2018 at 09:51:44PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Check the infoframes and infoframe enable state when comparing t

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-02 Thread Joonas Lahtinen
Quoting Antonio Argenziano (2018-10-01 22:53:46) > Fair enough. > > Acked-by: Antonio Argenziano > > for the series. Please, read the following chapters (they're applicable for the patch tag meanings in IGT, too): https://www.kernel.org/doc/html/v4.18/process/submitting-patches.html#when-to-us

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) URL : https://patchwork.freedesktop.org/series/49312/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10318_full = == Summary - WARNING == Minor unknown changes coming with Pa

[Intel-gfx] [PATCH] drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Chris Wilson
Previously we hesitated in adding the hw probe for the actual GPU frequency for rps_boost as it is quite cumbersome, but given some surprising HW behaviour it would be useful to know both the RPS boost state and the actual HW state in one location. Reported-by: Tomi Sarvela Signed-off-by: Chris W

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Restore vblank interrupts earlier

2018-10-02 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 05:29:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Plane sanitation needs vblank interrupts (on account of CxSR disable). > So let's restore vblank interrupts earlier. > > v2: Make it actually build > > Cc: sta...@vger.kernel.org > Cc: Dennis > Tested-by:

Re: [Intel-gfx] [PATCH] drm/i915: fix wrong error number report

2018-10-02 Thread Andi Shyti
> > struct intel_device_info *device_info; > > struct drm_i915_private *i915; > > + int err; > > > > i915 = kzalloc(sizeof(*i915), GFP_KERNEL); > > if (!i915) > > return NULL; > > Ahem. oh yes :) Thanks, Andi ___

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/intel_csr.c Added ICL Stepping info. (rev2)

2018-10-02 Thread Imre Deak
On Thu, Sep 06, 2018 at 12:15:30AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/intel_csr.c Added ICL Stepping info. (rev2) > URL : https://patchwork.freedesktop.org/series/49058/ > State : success Thanks for the patch pushed to -dinq. For the future: for the one line de

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-02 Thread Tvrtko Ursulin
On 01/10/2018 20:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-01 17:41:00) On 01/10/2018 17:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-01 17:15:24) + len = sizeof(struct drm_i915_query_engine_info) + + I915_NUM_ENGINES * sizeof(struct drm_i915_engine

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't clear the cookie on dorbell destroy

2018-10-02 Thread Michal Wajdeczko
On Mon, 01 Oct 2018 22:17:54 +0200, Daniele Ceraolo Spurio wrote: If the HW has not processed the db invalidation request yet, clearing the cookie can generate a db ring. We clear the cookie when we (re-)allocate the doorbell so no need to do it on destroy as well as no one is going to look a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) URL : https://patchwork.freedesktop.org/series/49312/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10319_full = == Summary - WARNING == Minor unknown changes coming with Pa

[Intel-gfx] [PATCH v2] drm/i915: fix wrong error number report

2018-10-02 Thread Andi Shyti
During driver load it's considered that the i915_driver_create() function fails only in case of insufficient memory. Indeed, in case of failure of i915_driver_create(), the load function returns indiscriminately -ENOMEM ignoring the real cause of failure. In i915_driver_create() get the consistent

[Intel-gfx] [PATCH xf86-video-intel v1] sna: Added AYUV format support for textured and sprite video adapters.

2018-10-02 Thread Stanislav Lisovskiy
sna/gen9+: Had to split out wm_kernel from the sna_composite_op flags, otherwise new shader kernels go beyond existing flags field. Signed-off-by: Stanislav Lisovskiy --- src/render_program/Makefile.am| 2 + .../exa_wm_src_sample_argb_ayuv.g8a | 60 + .../exa

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 10:05:11) > > On 01/10/2018 20:39, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-01 17:41:00) > >> > >> On 01/10/2018 17:24, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-10-01 17:15:24) > + len = sizeof(struct drm_i915_query_engine_

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not get aux power for disconnected DP ports

2018-10-02 Thread Imre Deak
On Wed, Sep 26, 2018 at 10:42:25PM +, Souza, Jose wrote: > On Tue, 2018-09-25 at 15:17 +0300, Ville Syrjälä wrote: > > On Mon, Sep 24, 2018 at 06:16:49PM -0700, José Roberto de Souza > > wrote: > > > For ICL type-c ports there is a aux power restriction, it can only > > > be > > > enabled while

[Intel-gfx] Backports for drm-intel-next-fixes

2018-10-02 Thread Joonas Lahtinen
The following patches with Fixes: do not cleanly apply to drm-intel-next-fixes: 47658556da85 ("drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect()") Please provide a backported patch ASAP, if they are relevant to be backported. If they should not be included in drm-intel-next-fixes, p

Re: [Intel-gfx] [PATCH] drm/i915: Add plane alpha blending support, v2.

2018-10-02 Thread Maarten Lankhorst
Op 23-08-18 om 00:57 schreef Matt Roper: > On Wed, Aug 15, 2018 at 12:34:05PM +0200, Maarten Lankhorst wrote: >> Add plane alpha blending support with the different blend modes. >> This has been tested on a icl to show the correct results, >> on earlier platforms small rounding errors cause issues.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info URL : https://patchwork.freedesktop.org/series/50431/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4913 -> Patchwork_10320 = == Summary - SUCCESS == No regres

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: init GuC descriptors after GuC load

2018-10-02 Thread Michal Wajdeczko
On Mon, 01 Oct 2018 22:17:53 +0200, Daniele Ceraolo Spurio wrote: GuC stores some data in there, which might be stale after a reset. We already reset the WQ head and tail, but more things are being moved to the descriptor with the interface updates. Instead of trying to track them one by one,

Re: [Intel-gfx] [PATCH] drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 09:36, Chris Wilson wrote: Previously we hesitated in adding the hw probe for the actual GPU frequency for rps_boost as it is quite cumbersome, but given some surprising HW behaviour it would be useful to know both the RPS boost state and the actual HW state in one location. Repor

Re: [Intel-gfx] [PATCH] drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 12:02:26) > > On 02/10/2018 09:36, Chris Wilson wrote: > > Previously we hesitated in adding the hw probe for the actual GPU > > frequency for rps_boost as it is quite cumbersome, but given some > > surprising HW behaviour it would be useful to know both the RPS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix wrong error number report (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915: fix wrong error number report (rev2) URL : https://patchwork.freedesktop.org/series/50406/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4913 -> Patchwork_10321 = == Summary - SUCCESS == No regressions found. External URL: https

[Intel-gfx] [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-10-02 Thread Stanislav Lisovskiy
v5: This is YUV444 packed format same as AYUV, but without alpha, as supported by i915. v6: Removed unneeded initializer for new XYUV format. v7: Added is_yuv field initialization according to latest drm_fourcc format structure initialization changes. v8: Edited commit message to be more

[Intel-gfx] [PATCH v10 2/2] drm/i915: Adding YUV444 packed format support for skl+

2018-10-02 Thread Stanislav Lisovskiy
PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification. v2: Edited commit message, removed redundant whitespaces. v3: Fixed fallthrough logic for the format switch cases. v4: Yet again fixed fallthrough logic, to reuse code from other case labels. v5: Started to use

[Intel-gfx] [PATCH v10 0/2] Add XYUV format support

2018-10-02 Thread Stanislav Lisovskiy
Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+). Stanislav Lisovskiy (2): drm: Introduce new DRM_FORMAT_XYUV drm/i915: Adding YUV444 packed format support for skl+ drivers/gpu/drm/drm_fourcc.c | 1 + drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH v2] drm/i915: fix wrong error number report

2018-10-02 Thread Chris Wilson
Quoting Andi Shyti (2018-10-02 10:20:47) > During driver load it's considered that the i915_driver_create() > function fails only in case of insufficient memory. Indeed, in > case of failure of i915_driver_create(), the load function > returns indiscriminately -ENOMEM ignoring the real cause of > f

[Intel-gfx] [PATCH i-g-t] igt/kms_busy: Flush request queue when re-enabling hangcheck

2018-10-02 Thread Chris Wilson
Enabling hangcheck only takes effect at the start of a new request queue. Before we re-enable hangcheck after our poking around, we therefore need to wait until the gpu is idle otherwise the next test will start without hangcheck and subsequently hang forever. Signed-off-by: Chris Wilson Cc: Petr

[Intel-gfx] [PATCH v2] drm/i915: Show actual alongside requested frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Chris Wilson
Previously we hesitated in adding the hw probe for the actual GPU frequency for rps_boost as it is quite cumbersome, but given some surprising HW behaviour it would be useful to know both the RPS boost state and the actual HW state in one location. v2: vlv/chv needs more tlc Reported-by: Tomi Sar

Re: [Intel-gfx] [PATCH v2] drm/i915: Show actual alongside requested frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 12:32, Chris Wilson wrote: Previously we hesitated in adding the hw probe for the actual GPU frequency for rps_boost as it is quite cumbersome, but given some surprising HW behaviour it would be useful to know both the RPS boost state and the actual HW state in one location. v2: v

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add XYUV format support (rev7)

2018-10-02 Thread Patchwork
== Series Details == Series: Add XYUV format support (rev7) URL : https://patchwork.freedesktop.org/series/48007/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7ef74de686fe drm: Introduce new DRM_FORMAT_XYUV -:30: WARNING:LONG_LINE: line over 100 characters #30: FILE: drivers/g

Re: [Intel-gfx] [PATCH v4 19/25] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-02 Thread Imre Deak
Thanks, found the note now. So all the EDP/MIPI VDSC regs and functionality are in PG2. On Mon, Oct 01, 2018 at 09:32:48PM +0300, Runyan, Arthur J wrote: > The power domains printed inside the register description are out of date. > The bspec text page on power wells has a note about that and it

Re: [Intel-gfx] [PATCH v2] drm/i915: Show actual alongside requested frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 12:41:18) > > On 02/10/2018 12:32, Chris Wilson wrote: > > Previously we hesitated in adding the hw probe for the actual GPU > > frequency for rps_boost as it is quite cumbersome, but given some > > surprising HW behaviour it would be useful to know both the RPS

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Replace some open-coded i915_map_coherent_type()

2018-10-02 Thread Tvrtko Ursulin
On 01/10/2018 20:44, Chris Wilson wrote: A few callsites where deciding on using WC or WB maps based on HAS_LLC(), so replace them with the equivalent helper function i915_map_coherent_type(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +-- drivers/

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_busy: Flush request queue when re-enabling hangcheck

2018-10-02 Thread Petri Latvala
On Tue, Oct 02, 2018 at 12:26:01PM +0100, Chris Wilson wrote: > Enabling hangcheck only takes effect at the start of a new request > queue. Before we re-enable hangcheck after our poking around, we > therefore need to wait until the gpu is idle otherwise the next test > will start without hangcheck

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add XYUV format support (rev7)

2018-10-02 Thread Patchwork
== Series Details == Series: Add XYUV format support (rev7) URL : https://patchwork.freedesktop.org/series/48007/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4914 -> Patchwork_10322 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10322 absolutel

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use the correct crtc when sanitizing plane mapping

2018-10-02 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 05:31:20PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > When we decide that a plane is attached to the wrong pipe we try > to turn off said plane. However we are passing around the crtc we > think that the plane is supposed to be using rather than the crtc > it is

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to incomplete zlib streams (albeit intact due to the use of Z_SYNC_FLUSH) resulting in the occasi

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Clean up early plane debugs

2018-10-02 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 05:31:27PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Print the plane hw state readout results in the common format > we already use for pipes and encoders. Also print some clearer > debug messages when we disable planes during the early phases > of state readou

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info (rev2) URL : https://patchwork.freedesktop.org/series/50431/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4914 -> Patchwork_10323 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > > On 01/10/2018 20:44, Chris Wilson wrote: > > The final call to zlib_deflate(Z_FINISH) may require more output > > space to be allocated and so needs to re-invoked. Failure to do so in > > the current code leads to incomplete zlib streams (albeit int

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Clear the error PTE just once on finish

2018-10-02 Thread Tvrtko Ursulin
On 01/10/2018 20:44, Chris Wilson wrote: We do not need to continually clear our dedicated PTE for error capture as it will be updated and invalidated to the next object. Only at the end do we wish to be sure that the PTE doesn't point back to any buffer. Signed-off-by: Chris Wilson --- driv

[Intel-gfx] [PATCH v2] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to incomplete zlib streams (albeit intact due to the use of Z_SYNC_FLUSH) resulting in the occasional short object capture. v2: Check agains

Re: [Intel-gfx] [PATCH v2] drm/i915: fix wrong error number report

2018-10-02 Thread Chris Wilson
Quoting Chris Wilson (2018-10-02 12:18:49) > Quoting Andi Shyti (2018-10-02 10:20:47) > > During driver load it's considered that the i915_driver_create() > > function fails only in case of insufficient memory. Indeed, in > > case of failure of i915_driver_create(), the load function > > returns in

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be allocated and so needs to re-invoked. Failure to do so in the current code leads to incom

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 14:13:14) > > On 02/10/2018 13:24, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > >> > >> On 01/10/2018 20:44, Chris Wilson wrote: > >>> The final call to zlib_deflate(Z_FINISH) may require more output > >>> space to be allocated and so ne

[Intel-gfx] [PATCH] drm/i915/selftests: Hold task_struct ref for smoking kthread

2018-10-02 Thread Chris Wilson
As the kthread may terminate itself, the parent must hold a task_struct reference for it to call kthread_stop(). <4> [498.827675] stack segment: [#1] PREEMPT SMP PTI <4> [498.827683] CPU: 0 PID: 3872 Comm: drv_selftest Tainted: G U 4.19.0-rc6-CI-CI_DRM_4915+ #1 <4> [498.827686

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type() (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type() (rev2) URL : https://patchwork.freedesktop.org/series/50408/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Handle incomplete Z_FINISH for compressed

[Intel-gfx] [PATCH 03/18] drm: Extract drm_atomic_state_helper.[hc]

2018-10-02 Thread Daniel Vetter
We already have a separate overview doc for this, makes sense to untangle it from the overall atomic helpers. v2: Rebase v3: Rebase more. Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-kms-helpers.rst | 19 +- drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm

[Intel-gfx] [PATCH 00/18] atomic helper cleanups

2018-10-02 Thread Daniel Vetter
Hi all, Here's a pile of atomic helper cleanups. Big chunk is shredding the transitional helpers, I don't think they're useful anymore. armada is converted, vboxvideo is getting converted as we speak for 4.20, anything that's left is probably better to just move over to a simple display pipe drive

[Intel-gfx] [PATCH 01/18] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-02 Thread Daniel Vetter
For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic ones. v2: amdgpu uses ->best_encoder internally, give it a local copy. It might be a good idea to

[Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-02 Thread Daniel Vetter
The core _does_ the call to drm_atomic_commit for you. That's pretty much the entire point of having the fancy new atomic_set/get_prop callbacks. Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 -- 1 file c

[Intel-gfx] [PATCH 06/18] drm/atomic: Improve docs for drm_atomic_state->allow_modeset

2018-10-02 Thread Daniel Vetter
Motivated by vmwgfx digging around in core uapi bits it shouldn't dig around in. Signed-off-by: Daniel Vetter --- include/drm/drm_atomic.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index d6adebcd6ea4..c09ecaf

[Intel-gfx] [PATCH 02/18] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder

2018-10-02 Thread Daniel Vetter
It's the default. The exported version was kinda a transition state, before we made this the default. To stop new atomic drivers from using it (instead of just relying on the default) let's unexport it. Signed-off-by: Daniel Vetter Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Sean Paul Cc: D

[Intel-gfx] [PATCH 05/18] drm/vmwgfx: Don't look at state->allow_modeset

2018-10-02 Thread Daniel Vetter
That's purely for the uapi layer to implement the ALLOW_MODESET flag. Drivers should instead look at the state, e.g. through drm_atomic_crtc_needs_modeset(), which vmwgfx already does. Also remove the confusing comment, since checking allow_modeset is at best a micro optimization. Signed-off-by:

[Intel-gfx] [PATCH 07/18] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-10-02 Thread Daniel Vetter
The idea behind allowing drivers to override legacy ioctls (instead of using the generic implementations unconditionally) is to handle bugs in old driver-specific userspace. Like e.g. vmw_kms_set_config does, to work around some vmwgfx userspace not clearing its ioctl structs properly. But you can

[Intel-gfx] [PATCH 08/18] drm/arcpgu: Drop transitional hooks

2018-10-02 Thread Daniel Vetter
These do absolutely nothing for atomic drivers. Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index 965cda48dc13..26cb2800f3ad 1006

[Intel-gfx] [PATCH 10/18] drm/arcpgu: Use drm_atomic_helper_shutdown

2018-10-02 Thread Daniel Vetter
drm_plane_helper_disable is a non-atomic drivers only function, and will blow up (since no one passes the locking context it needs). Atomic drivers which want to quiescent their hw on unload should use drm_atomic_helper_shutdown() instead. Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- dr

[Intel-gfx] [PATCH 09/18] drm/atmel: Drop transitional hooks

2018-10-02 Thread Daniel Vetter
These do absolutely nothing for atomic drivers. Signed-off-by: Daniel Vetter Cc: Boris Brezillon Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: linux-arm-ker...@lists.infradead.org --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] Backports for drm-intel-next-fixes

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 12:56:02PM +0300, Joonas Lahtinen wrote: > The following patches with Fixes: do not cleanly apply > to drm-intel-next-fixes: > > 47658556da85 ("drm/i915/dp: Do not grab crtc modeset lock in > intel_dp_detect()") > > Please provide a backported patch ASAP, if they are rele

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 14:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:13:14) On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris Wilson wrote: The final call to zlib_deflate(Z_FINISH) may require more output space to be

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type() (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type() (rev2) URL : https://patchwork.freedesktop.org/series/50408/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4915 -> Patchwork_10324 = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-02 14:46:10) > > On 02/10/2018 14:22, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-02 14:13:14) > >> > >> On 02/10/2018 13:24, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-10-02 13:20:05) > > On 01/10/2018 20:44, Chris Wilson wrote: >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Hold task_struct ref for smoking kthread

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Hold task_struct ref for smoking kthread URL : https://patchwork.freedesktop.org/series/50441/ State : warning == Summary == $ dim checkpatch origin/drm-tip 35b442e8bb4d drm/i915/selftests: Hold task_struct ref for smoking kthread -:10: WARNING:

Re: [Intel-gfx] [PATCH 02/18] drm/atomic-helper: Unexport drm_atomic_helper_best_encoder

2018-10-02 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday, 2 October 2018 16:35:10 EEST Daniel Vetter wrote: > It's the default. The exported version was kinda a transition state, > before we made this the default. > > To stop new atomic drivers from using it (instead of just relying on > the default) let'

[Intel-gfx] [PATCH 1/4] drm/i915/gen8: Disable master intr before reading

2018-10-02 Thread Mika Kuoppala
Disable master interrupt before reading level indications. This will close a race where we get a level indication between reading and disabling, generating an extra interrupt where we could have avoided one. Further, as the reading acts also as a post, replace the write/post on the irq reset with

[Intel-gfx] [PATCH 3/4] drm/i915/icl: Disable master intr before reading

2018-10-02 Thread Mika Kuoppala
Disable master interrupt before reading level indications. This will close a race where we get a level indication between reading and disabling, generating an extra interrupt where we could have avoided one. Further, as the reading acts also as a post, replace the write/post on the irq reset with

[Intel-gfx] [PATCH 4/4] drm/i915/icl: Handle GT interrupts after enabling master

2018-10-02 Thread Mika Kuoppala
Don't keep master disabled while we handle the current interrupts. This should help a little on latency of generating the next interrupt. Suggested-by: Chris Wilson Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_irq.c | 4 +--- 1 file changed, 1 insertion(+), 3 del

[Intel-gfx] [PATCH 2/4] drm/i915/icl: No need to ack intr through master control

2018-10-02 Thread Mika Kuoppala
All other master control register bits, except the enable, are read only and they are level indications of the second level interrupt status. Only touch enable bit and rectify the comment. Cc: Chris Wilson Cc: Dhinakaran Pandiyan Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Hold task_struct ref for smoking kthread

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Hold task_struct ref for smoking kthread URL : https://patchwork.freedesktop.org/series/50441/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4915 -> Patchwork_10325 = == Summary - WARNING == Minor unknown changes coming wi

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use the correct crtc when sanitizing plane mapping

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 02:11:34PM +0200, Daniel Vetter wrote: > On Mon, Oct 01, 2018 at 05:31:20PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > When we decide that a plane is attached to the wrong pipe we try > > to turn off said plane. However we are passing around the crtc we >

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states

2018-10-02 Thread Tvrtko Ursulin
On 02/10/2018 14:52, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:46:10) On 02/10/2018 14:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 14:13:14) On 02/10/2018 13:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-02 13:20:05) On 01/10/2018 20:44, Chris Wil

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/gen8: Disable master intr before reading

2018-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/gen8: Disable master intr before reading URL : https://patchwork.freedesktop.org/series/50446/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4915 -> Patchwork_10326 = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Clean up early plane debugs

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 02:21:32PM +0200, Daniel Vetter wrote: > On Mon, Oct 01, 2018 at 05:31:27PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Print the plane hw state readout results in the common format > > we already use for pipes and encoders. Also print some clearer > > debu

Re: [Intel-gfx] [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

2018-10-02 Thread Alexandru-Cosmin Gheorghe
Hi, How is this going on, anything holding it back from getting merged ? I'm interested in adding/using P010, [1] Thank you, Alex Gheorghe [1] https://lists.freedesktop.org/archives/dri-devel/2018-August/186963.html On Thu, Aug 30, 2018 at 03:41:11PM +0300, Juha-Pekka Heikkila wrote: > Add P010

Re: [Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:12PM +0200, Daniel Vetter wrote: > The core _does_ the call to drm_atomic_commit for you. That's pretty > much the entire point of having the fancy new atomic_set/get_prop > callbacks. > > Signed-off-by: Daniel Vetter > Cc: VMware Graphics > Cc: Sinclair Yeh > Cc:

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gen8: Disable master intr before reading

2018-10-02 Thread Chris Wilson
Quoting Mika Kuoppala (2018-10-02 15:05:49) > Disable master interrupt before reading level indications. > This will close a race where we get a level indication between > reading and disabling, generating an extra interrupt where we > could have avoided one. > > Further, as the reading acts also

Re: [Intel-gfx] [PATCH 3/4] drm/i915/icl: Disable master intr before reading

2018-10-02 Thread Chris Wilson
Quoting Mika Kuoppala (2018-10-02 15:05:51) > Disable master interrupt before reading level indications. > This will close a race where we get a level indication between > reading and disabling, generating an extra interrupt where we > could have avoided one. > > Further, as the reading acts also

Re: [Intel-gfx] [PATCH 4/4] drm/i915/icl: Handle GT interrupts after enabling master

2018-10-02 Thread Chris Wilson
Quoting Mika Kuoppala (2018-10-02 15:05:52) > Don't keep master disabled while we handle the current > interrupts. This should help a little on latency of > generating the next interrupt. > > Suggested-by: Chris Wilson > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

2018-10-02 Thread Alexandru-Cosmin Gheorghe
Hi, On Tue, Oct 02, 2018 at 02:15:42PM +0300, Stanislav Lisovskiy wrote: > v5: This is YUV444 packed format same as AYUV, but without alpha, > as supported by i915. > > v6: Removed unneeded initializer for new XYUV format. > > v7: Added is_yuv field initialization according to latest > d

[Intel-gfx] [PATCH i-g-t] lib/kms: Handle no connectors for igt_enable_connectors()

2018-10-02 Thread Chris Wilson
Take the device fd from the caller as to which card we should try and enable connectors for (or else we may not enable the right connectors for the test!) and fail gracefully if there is no kms support on the device. Signed-off-by: Chris Wilson --- lib/igt_kms.c| 10 +++--- l

Re: [Intel-gfx] [PATCH 09/18] drm/atmel: Drop transitional hooks

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:17PM +0200, Daniel Vetter wrote: > These do absolutely nothing for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: linux-arm-ker...@lists.infradead.org Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 08/18] drm/arcpgu: Drop transitional hooks

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:16PM +0200, Daniel Vetter wrote: > These do absolutely nothing for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Alexey Brodkin > --- > drivers/gpu/drm/arc/arcpgu_crtc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/arc/arcpgu_

[Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Handle no-KMS gracefully

2018-10-02 Thread Chris Wilson
If KMS is not supported, drmGetResources() will return NULL so be careful not to dereference it. However, we still insist that runtime pm works, so keep on testing. Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 71 +++--- 1 file changed, 44 insertio

Re: [Intel-gfx] [PATCH 10/18] drm/arcpgu: Use drm_atomic_helper_shutdown

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:18PM +0200, Daniel Vetter wrote: > drm_plane_helper_disable is a non-atomic drivers only function, and > will blow up (since no one passes the locking context it needs). > > Atomic drivers which want to quiescent their hw on unload should > use drm_atomic_helper_shutd

Re: [Intel-gfx] [PATCH 06/18] drm/atomic: Improve docs for drm_atomic_state->allow_modeset

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:14PM +0200, Daniel Vetter wrote: > Motivated by vmwgfx digging around in core uapi bits it shouldn't dig > around in. > > Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä > --- > include/drm/drm_atomic.h | 10 +- > 1 file changed, 9 insertions(+),

Re: [Intel-gfx] [PATCH 03/18] drm: Extract drm_atomic_state_helper.[hc]

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 03:35:11PM +0200, Daniel Vetter wrote: > We already have a separate overview doc for this, makes sense to > untangle it from the overall atomic helpers. > > v2: Rebase > > v3: Rebase more. Hopefully the rebases didn't leave any code changes behind... Too lazy to read in

Re: [Intel-gfx] [PATCH] drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 12:11:51PM +0100, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-10-02 12:02:26) > > > > On 02/10/2018 09:36, Chris Wilson wrote: > > > Previously we hesitated in adding the hw probe for the actual GPU > > > frequency for rps_boost as it is quite cumbersome, but given s

Re: [Intel-gfx] [PATCH] drm/i915: Show actual along side request frequency in debugfs/i915_rps_boost_info

2018-10-02 Thread Chris Wilson
Quoting Ville Syrjälä (2018-10-02 16:46:55) > On Tue, Oct 02, 2018 at 12:11:51PM +0100, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-02 12:02:26) > > > > > > On 02/10/2018 09:36, Chris Wilson wrote: > > > > Previously we hesitated in adding the hw probe for the actual GPU > > > > freque

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Handle no-KMS gracefully

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 04:36:07PM +0100, Chris Wilson wrote: > If KMS is not supported, drmGetResources() will return NULL so be > careful not to dereference it. However, we still insist that runtime pm > works, so keep on testing. > > Signed-off-by: Chris Wilson Reviewed-by: Ville Syrjälä >

Re: [Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-02 Thread Thomas Hellstrom
On 10/02/2018 05:15 PM, Ville Syrjälä wrote: > On Tue, Oct 02, 2018 at 03:35:12PM +0200, Daniel Vetter wrote: >> The core _does_ the call to drm_atomic_commit for you. That's pretty >> much the entire point of having the fancy new atomic_set/get_prop >> callbacks. >> >> Signed-off-by: Daniel Vetter

Re: [Intel-gfx] [PATCH 07/18] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

2018-10-02 Thread Thomas Hellstrom
Hi, Daniel, On 10/02/2018 03:35 PM, Daniel Vetter wrote: > The idea behind allowing drivers to override legacy ioctls (instead of > using the generic implementations unconditionally) is to handle bugs > in old driver-specific userspace. Like e.g. vmw_kms_set_config does, > to work around some vmwg

Re: [Intel-gfx] [PATCH 04/18] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property

2018-10-02 Thread Ville Syrjälä
On Tue, Oct 02, 2018 at 04:36:31PM +, Thomas Hellstrom wrote: > On 10/02/2018 05:15 PM, Ville Syrjälä wrote: > > On Tue, Oct 02, 2018 at 03:35:12PM +0200, Daniel Vetter wrote: > >> The core _does_ the call to drm_atomic_commit for you. That's pretty > >> much the entire point of having the fanc

[Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v6)

2018-10-02 Thread Bob Paauwe
48 bit ppgtt device configuration is really just extended address range full ppgtt and may actually be something other than 48 bits. Change HAS_FULL_48BIT_PPGTT() to HAS_4LVL_PPGTT() to better describe that a 4 level walk table extended range PPGTT is being used. Add a new device info field that s

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW

2018-10-02 Thread Dhinakaran Pandiyan
On Mon, 2018-10-01 at 15:17 -0700, Rodrigo Vivi wrote: > On Thu, Sep 27, 2018 at 11:11:17PM -0700, Dhinakaran Pandiyan wrote: > > We have new tests and fixes in place since the feature was last > > disabled. Try again for gen-9+ hardware and enable only PSR1 by > > default as > > a first step. > >

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-10-02 Thread Chris Wilson
Quoting Bob Paauwe (2018-09-14 16:51:34) > On Thu, 13 Sep 2018 20:22:14 +0300 > Ville Syrjälä wrote: > > > On Thu, Sep 13, 2018 at 10:12:06AM -0700, Bob Paauwe wrote: > > > On Thu, 13 Sep 2018 20:05:54 +0300 > > > Ville Syrjälä wrote: > > > > > > > On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bo

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v6)

2018-10-02 Thread Chris Wilson
Quoting Bob Paauwe (2018-10-02 18:39:14) > 48 bit ppgtt device configuration is really just extended address > range full ppgtt and may actually be something other than 48 bits. > > Change HAS_FULL_48BIT_PPGTT() to HAS_4LVL_PPGTT() to better > describe that a 4 level walk table extended range PPGT

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix wrong error number report (rev2)

2018-10-02 Thread Patchwork
== Series Details == Series: drm/i915: fix wrong error number report (rev2) URL : https://patchwork.freedesktop.org/series/50406/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4913_full -> Patchwork_10321_full = == Summary - SUCCESS == No regressions found. == Known

  1   2   >