[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/execlists: Delay updating ring register state after resume

2018-09-14 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/execlists: Delay updating ring register state after resume URL : https://patchwork.freedesktop.org/series/49708/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4825_full -> Patchwork_10191_full = == Summary

Re: [Intel-gfx] [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR

2018-09-14 Thread Bowman, Casey G
Tested-by: Casey Bowman -Original Message- From: Pandiyan, Dhinakaran Sent: Thursday, September 13, 2018 5:18 PM To: intel-gfx@lists.freedesktop.org Cc: Souza, Jose ; Deak, Imre ; Pandiyan, Dhinakaran ; Atwood, Matthew S ; Yadav, Jyoti R ; Bowman, Casey G Subject: [PATCH] drm/i915/ps

Re: [Intel-gfx] [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.

2018-09-14 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 04:05:37PM -0700, Anusha Srivatsa wrote: > Add missing MODULE_FIRMWARE while loading DMC ICL. > > v2: Add Fixes tag. (Rodrigo) > > Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.") > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa Reviewed-by: Rodrigo V

[Intel-gfx] [PATCH i-g-t v13 2/2] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2018-09-14 Thread Tvrtko Ursulin
From: Lionel Landwerlin Verify that the per-context dynamic SSEU uAPI works as expected. To achieve that, in the absence of a better mechamism, we read the value of PWR_CLK_STATE register, or use MI_SET_PREDICATE on platforms before Cannonlake. This register is written to by the GPU on context

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v13 2/2] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2018-09-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-14 17:04:38) > +static uint32_t * > +fill_relocation(uint32_t *batch, > + struct drm_i915_gem_relocation_entry *reloc, > + uint32_t gem_handle, uint32_t delta, /* in bytes */ > + uint32_t offset, /* in dwords */ > +

Re: [Intel-gfx] [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable functionality

2018-09-14 Thread Ville Syrjälä
On Fri, Sep 14, 2018 at 12:24:12PM +0530, Vandita Kulkarni wrote: > From: Madhav Chauhan > > In Gen11, DPLL 0 and 1 are shared between DDI and DSI. > Most of the steps for enabling DPLL are common across DDI > and DSI. This patch makes icl_dpll_enable() generic which > will be used by all the enc

Re: [Intel-gfx] [RFC 3/3] drm/i915/icl: Calculate DPLL params for DSI

2018-09-14 Thread Ville Syrjälä
On Fri, Sep 14, 2018 at 12:24:14PM +0530, Vandita Kulkarni wrote: > From: Madhav Chauhan > > This patch calculate various DPLL dividers and > parameters for DSI encoder and adjust AFE clock > for DSI. For DSI, 8x clock is AFE clock. > > v2: Extend haswell_crtc_compute_clock() for Gen11 DSI > v3:

[Intel-gfx] [PATCH 0/6] Per context dynamic (sub)slice power-gating

2018-09-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More review feedback, some fixes and some refactoring due drm-tip changes. Lionel Landwerlin (2): drm/i915: Record the sseu configuration per-context & engine drm/i915/perf: lock powergating configuration to default when active Tvrtko Ursulin (4): drm/i915/execlists:

[Intel-gfx] [PATCH 2/6] drm/i915: Record the sseu configuration per-context & engine

2018-09-14 Thread Tvrtko Ursulin
From: Lionel Landwerlin We want to expose the ability to reconfigure the slices, subslice and eu per context and per engine. To facilitate that, store the current configuration on the context for each engine, which is initially set to the device default upon creation. v2: record sseu configurati

[Intel-gfx] [PATCH 3/6] drm/i915/perf: lock powergating configuration to default when active

2018-09-14 Thread Tvrtko Ursulin
From: Lionel Landwerlin If some of the contexts submitting workloads to the GPU have been configured to shutdown slices/subslices, we might loose the NOA configurations written in the NOA muxes. One possible solution to this problem is to reprogram the NOA muxes when we switch to a new context.

[Intel-gfx] [PATCH 1/6] drm/i915/execlists: Move RPCS setup to context pin

2018-09-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Configuring RPCS in context image just before pin is sufficient and will come extra handy in one of the following patches. v2: * Split image setup a bit differently. (Chris Wilson) v3: * Update context image after reset as well - otherwise the application of pinned def

[Intel-gfx] [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-09-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to allow userspace to reconfigure the subslice configuration for its own use case. To do so, we expose a context parameter to allow adjustment of the RPCS register stored within the context image (and currently not accessible via LRI). If the context is adjusted befor

[Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existance between per-context SSEU and OA

2018-09-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake users like media stack will have issues if we lock to the full device configuration. Instead lock to a subset of (sub)slices which are currently a known working configuration for all users. Sign

[Intel-gfx] [PATCH 4/6] drm/i915: Add timeline barrier support

2018-09-14 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Timeline barrier allows serialization between different timelines. After calling i915_timeline_set_barrier with a request, all following submissions on this timeline will be set up as depending on this request, or barrier. Once the barrier has been completed it automatically

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v13 2/2] tests/gem_ctx_sseu: Dynamic (sub)slice programming tests

2018-09-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-14 17:04:38) > +static igt_spin_t * > +__post_set(int fd, unsigned int flags, uint32_t ctx, igt_spin_t *spin, > + unsigned int expected) > +{ > + bool busy_reset = (flags & TEST_BUSY) && > + (flags & (TEST_RESET | TEST_HANG)); >

Re: [Intel-gfx] [PATCH 1/6] drm/i915/execlists: Move RPCS setup to context pin

2018-09-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-14 17:09:27) > From: Tvrtko Ursulin > > Configuring RPCS in context image just before pin is sufficient and will > come extra handy in one of the following patches. > > v2: > * Split image setup a bit differently. (Chris Wilson) > > v3: > * Update context image

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-09-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-14 17:09:31) > +static int > +gen8_modify_rpcs_gpu(struct intel_context *ce, > +struct intel_engine_cs *engine, > +struct intel_sseu sseu) > +{ > + struct drm_i915_private *i915 = engine->i915; > + struct i915_reque

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2)

2018-09-14 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2) URL : https://patchwork.freedesktop.org/series/49682/ State : failure == Summary == Applying: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR error: corrupt patch at line 27 error: could not bui

Re: [Intel-gfx] [PATCH] drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-14 Thread Souza, Jose
On Fri, 2018-09-14 at 09:15 +0100, Chris Wilson wrote: > Quoting José Roberto de Souza (2018-09-13 23:13:41) > > All DRM_CLIENT capabilities are tied to KMS support, so returning > > -ENOTSUPP when KMS is not supported. > > The posix errno is ENOTSUP (ENOTSUPP is internal). Now since we have > no

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Include fence-hint for timeout warning (rev3)

2018-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Include fence-hint for timeout warning (rev3) URL : https://patchwork.freedesktop.org/series/20264/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4825_full -> Patchwork_10192_full = == Summary - FAILURE == Serious unknown changes co

Re: [Intel-gfx] [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR

2018-09-14 Thread Souza, Jose
On Thu, 2018-09-13 at 17:18 -0700, Dhinakaran Pandiyan wrote: > PSR requires AUX IO power well to be enabled. This was already in > place > for CNL, extend this for ICL too. Not enabling the power well results > in > the aux error interrupts when the hardware exits PSR. > Reviewed-by: José Robert

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev3)

2018-09-14 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev3) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1c5fbd789ec4 drm/i915/execlists: Move RPCS setup to context pin 7bdb7605a619 drm/i915: Record the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev3)

2018-09-14 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev3) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/execlists: Move RPCS setup to context pin Okay! Commit: drm/i915: Record the sseu co

[Intel-gfx] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev3)

2018-09-14 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev3) URL : https://patchwork.freedesktop.org/series/48194/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4827 -> Patchwork_10195 = == Summary - SUCCESS == No regressions found. External URL: h

Re: [Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-14 Thread Chris Wilson
Quoting Chris Wilson (2018-09-13 20:20:50) > If the ioctl is not supported on a particular piece of HW/driver > combination, report ENOTSUP (aka EOPNOTSUPP) so that it can be easily > distinguished from both the lack of the ioctl and from a regular invalid > parameter. > > v2: Across all the kms i

Re: [Intel-gfx] [PATCH] drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-14 Thread Chris Wilson
Quoting Souza, Jose (2018-09-14 17:30:59) > On Fri, 2018-09-14 at 09:15 +0100, Chris Wilson wrote: > > Quoting José Roberto de Souza (2018-09-13 23:13:41) > > > @@ -306,6 +306,9 @@ drm_setclientcap(struct drm_device *dev, void > > > *data, struct drm_file *file_priv) > > > { > > > struct d

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

2018-09-14 Thread Juha-Pekka Heikkilä
Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30: On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote: On Fri, Sep 14, 2018 at 01:36:32PM +, Lisovskiy, Stanislav wrote: On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote: Introduced new XYUV scan-in format for framebuffer a

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Live tests emit requests and so require rpm

2018-09-14 Thread Chris Wilson
As we emit requests or touch HW directly for some of the live tests, the requirement is that we hold the rpm wakeref before doing so. We want a mix of granularity since we will want to test runtime suspend, so try to mark up only the critical sections where we need rpm for the live test. Signed-of

[Intel-gfx] [PATCH 2/2] drm/i915: Park the GPU on module load

2018-09-14 Thread Chris Wilson
Once we have flushed the first request through the system to both load a context and record the default state; tell the GPU to park and idle itself, putting itself immediately (hopefully at least) into a powersaving state, and allowing ourselves to start from known state after setting up all our bo

Re: [Intel-gfx] [PATCH] drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-14 Thread Daniel Vetter
On Fri, Sep 14, 2018 at 7:04 PM, Chris Wilson wrote: > Quoting Souza, Jose (2018-09-14 17:30:59) >> On Fri, 2018-09-14 at 09:15 +0100, Chris Wilson wrote: >> > Quoting José Roberto de Souza (2018-09-13 23:13:41) >> > > @@ -306,6 +306,9 @@ drm_setclientcap(struct drm_device *dev, void >> > > *data,

Re: [Intel-gfx] [PATCH] drm: Return -ENOTSUPP in drm_setclientcap() when driver do not support KMS

2018-09-14 Thread Daniel Vetter
On Fri, Sep 14, 2018 at 10:02 PM, Daniel Vetter wrote: > On Fri, Sep 14, 2018 at 7:04 PM, Chris Wilson > wrote: >> Quoting Souza, Jose (2018-09-14 17:30:59) >>> On Fri, 2018-09-14 at 09:15 +0100, Chris Wilson wrote: >>> > Quoting José Roberto de Souza (2018-09-13 23:13:41) >>> > > @@ -306,6 +306

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/selftests: Live tests emit requests and so require rpm

2018-09-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Live tests emit requests and so require rpm URL : https://patchwork.freedesktop.org/series/49736/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4828 -> Patchwork_10196 = == Summary - FAILURE ==

[Intel-gfx] [PATCH i-g-t 4/5] lib/kms: Skip no-op display updates

2018-09-14 Thread Chris Wilson
If the display is disabled (e.g. the driver has disabled the KMS interface) there is nothing to do so avoid failing. Signed-off-by: Chris Wilson --- lib/igt_kms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 9710bcae1..dedc81344 100644 --- a/lib/i

[Intel-gfx] [PATCH i-g-t 5/5] igt: Require a display (KMS enabled) for KMS tests

2018-09-14 Thread Chris Wilson
Simple rule of thumb, if a kms_* test calls igt_display_init() in its global fixture, skip the entire test if the driver has disabled KMS. Signed-off-by: Chris Wilson --- tests/drm_read.c | 2 +- tests/kms_atomic.c| 3 +-- tests/kms_atomic_interruptible.c | 4 +-

[Intel-gfx] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-09-14 Thread Chris Wilson
If the driver doesn't support the getfb iface (e.g. because KMS has been disabled), the ioctls will fail with ENOTSUP. This is expected, so skip the test as nothing useful can be learnt. Signed-off-by: Chris Wilson --- tests/kms_getfb.c | 40 ++-- 1 file chang

[Intel-gfx] [PATCH i-g-t 3/5] lib: Report if kms is enabled on the display

2018-09-14 Thread Chris Wilson
Some drivers may have disabled KMS or there may simply nothing attached to the device. In either case KMS is unusable and we may prefer to skip. Signed-off-by: Chris Wilson --- lib/igt_kms.c | 14 -- lib/igt_kms.h | 3 ++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --gi

[Intel-gfx] [PATCH i-g-t 2/5] igt/prime_vgem: Skip flip if no display

2018-09-14 Thread Chris Wilson
We try flipping a vgem surface onto a i915 scanout. However, if there is no display we want to disable the kms interface, including the addfb ioctl. On such systems the call to kms_addfb will naturally fail and the test cannot be run. Signed-off-by: Chris Wilson --- tests/prime_vgem.c | 11

[Intel-gfx] ✗ Fi.CI.IGT: failure for Per context dynamic (sub)slice power-gating (rev3)

2018-09-14 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev3) URL : https://patchwork.freedesktop.org/series/48194/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4827_full -> Patchwork_10195_full = == Summary - FAILURE == Serious unknown changes coming

Re: [Intel-gfx] [PATCH v2] drm/i915: reword documentation of possible pci_device_id struct

2018-09-14 Thread Lucas De Marchi
On Wed, Sep 5, 2018 at 1:21 PM Lucas De Marchi wrote: > > Document it like a real struct for ease of copy and paste, remove > comment of C99 compatibility and document that in some cases the first 2 > fields can be u16. > > v2: - remove mention to (non-existent) PCI_DEVICE_ANY and better explain >

<    1   2