[Intel-gfx] [PATCH] drm/i915: Flush the tasklet when checking for idle

2018-09-13 Thread Chris Wilson
In order to reduce latency when checking for idle we kick the tasklet directly. Sometimes this is not enough as it is queued on another cpu and so to improve the accuracy of this idle-check (and so to reduce latency overall by avoiding another pass, or worse declaring a timeout!) wait for the taskl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush the tasklet when checking for idle

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Flush the tasklet when checking for idle URL : https://patchwork.freedesktop.org/series/49616/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10165 = == Summary - SUCCESS == No regressions found. External URL: h

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for i915/oa: Simplify updating contexts

2018-09-13 Thread Tvrtko Ursulin
On 12/09/2018 17:58, Patchwork wrote: == Series Details == Series: i915/oa: Simplify updating contexts URL : https://patchwork.freedesktop.org/series/49569/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10158 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-13 Thread Tvrtko Ursulin
On 12/09/2018 16:50, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-12 16:29:30) /* * The OA register config is setup through the context image. This image * might be written to by the GPU on context switch (in particular on @@ -1833,7 +1727,7 @@ static int ge

Re: [Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 09:54:15) > > On 12/09/2018 16:50, Chris Wilson wrote: > > By feeding a request, you ensure the reconfig is loaded again. +1 for > > having it turn off when idle (and not instrument the kernel context at > > all)! > > > > Still I follow your logic that this shou

Re: [Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-13 Thread Chris Wilson
Quoting Chris Wilson (2018-09-13 09:58:59) > Quoting Tvrtko Ursulin (2018-09-13 09:54:15) > > > > On 12/09/2018 16:50, Chris Wilson wrote: > > > By feeding a request, you ensure the reconfig is loaded again. +1 for > > > having it turn off when idle (and not instrument the kernel context at > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Flush the tasklet when checking for idle

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Flush the tasklet when checking for idle URL : https://patchwork.freedesktop.org/series/49616/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813_full -> Patchwork_10165_full = == Summary - SUCCESS == No regressions found. == K

[Intel-gfx] [PATCH] drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Chris Wilson
If there is not a display (and so no CRTCs) then there is no upper limit to the framebuffer pitch imposed by the CRTC. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_disp

Re: [Intel-gfx] [PATH i-g-t v12 2/2] tests: add slice power programming test

2018-09-13 Thread Tvrtko Ursulin
On 12/09/2018 12:53, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-11 15:42:10) + last_with_engines = -1; + for (class = 0; class < ~0; class++) { + for (instance = 0; instance < ~0; instance++) { + int ret; + + sseu.cl

Re: [Intel-gfx] [PATH i-g-t v12 2/2] tests: add slice power programming test

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 11:38:47) > > On 12/09/2018 12:53, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-09-11 15:42:10) > > I would also suggest a reset test here. Both reset when idle, and by > > hangcheck/forced-reset of the spinner & active context. > > > > And across suspen

Re: [Intel-gfx] [PATCH] drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 11:39:23AM +0100, Chris Wilson wrote: > If there is not a display (and so no CRTCs) then there is no upper limit > to the framebuffer pitch imposed by the CRTC. Should we still allow you to create framebuffers in that case? If yes then my plan to also query the planes whic

Re: [Intel-gfx] [PATCH] drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjälä (2018-09-13 11:56:56) > On Thu, Sep 13, 2018 at 11:39:23AM +0100, Chris Wilson wrote: > > If there is not a display (and so no CRTCs) then there is no upper limit > > to the framebuffer pitch imposed by the CRTC. > > Should we still allow you to create framebuffers in that ca

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion

2018-09-13 Thread Tvrtko Ursulin
On 12/09/2018 17:40, Chris Wilson wrote: Under mempressure, our goal is to allow ourselves sufficient time to reclaim the RCU protected slabs without overly penalizing our clients. Currently, we use a 1 jiffie wait if the client is still active as a means of throttling the allocations, but we ca

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Remove fb pitch limit for no display URL : https://patchwork.freedesktop.org/series/49625/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10166 = == Summary - SUCCESS == No regressions found. External URL: https

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 12:16:42) > > On 12/09/2018 17:40, Chris Wilson wrote: > > Under mempressure, our goal is to allow ourselves sufficient time to > > reclaim the RCU protected slabs without overly penalizing our clients. > > Currently, we use a 1 jiffie wait if the client is still

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion

2018-09-13 Thread Tvrtko Ursulin
On 13/09/2018 12:18, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-13 12:16:42) On 12/09/2018 17:40, Chris Wilson wrote: Under mempressure, our goal is to allow ourselves sufficient time to reclaim the RCU protected slabs without overly penalizing our clients. Currently, we use a 1 jiff

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 12:29:46) > > On 13/09/2018 12:18, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-09-13 12:16:42) > >> > >> On 12/09/2018 17:40, Chris Wilson wrote: > >>> Under mempressure, our goal is to allow ourselves sufficient time to > >>> reclaim the RCU protected s

Re: [Intel-gfx] [PATCH] drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 12:05:49PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-09-13 11:56:56) > > On Thu, Sep 13, 2018 at 11:39:23AM +0100, Chris Wilson wrote: > > > If there is not a display (and so no CRTCs) then there is no upper limit > > > to the framebuffer pitch imposed by the

Re: [Intel-gfx] [PATCH] drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjälä (2018-09-13 13:26:48) > On Thu, Sep 13, 2018 at 12:05:49PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjälä (2018-09-13 11:56:56) > > > On Thu, Sep 13, 2018 at 11:39:23AM +0100, Chris Wilson wrote: > > > > If there is not a display (and so no CRTCs) then there is no upper

Re: [Intel-gfx] [RFC PATCH] drm/i915: split GVT as separated module

2018-09-13 Thread Jani Nikula
On Thu, 13 Sep 2018, Zhenyu Wang wrote: > Joonas requested if we could move GVT into separated module. > Then obvious requirement is to export i915 functions that GVT > currently use. So this one blindly trys to export all of them > for people to review. Some of them are already only for GVT now.

[Intel-gfx] [PATCH i-g-t] igt/prime_vgem: Skip flip if no display

2018-09-13 Thread Chris Wilson
We try flipping a vgem surface onto a i915 scanout. However, if there is no display we want to disable the kms interface, including the addfb ioctl. On such systems the call to kms_addfb will naturally fail and the test cannot be run. Signed-off-by: Chris Wilson --- tests/prime_vgem.c | 11

[Intel-gfx] [PULL] drm-misc-next

2018-09-13 Thread Sean Paul
Hi Dave, Coming to you from stormy North Carolina! It looks like Florence will wrap right around us, so hopefully no drm-misc service interruptions will occur in the next week :-) Quite a lot of activity this week, both in volume and UAPI. Two of the line items in UAPI section are functionality c

[Intel-gfx] [PATCH 1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Chris Wilson
For finding the panel fitter and PLL for a particular modeset is a part of that modeset and should be included with the reset of the DRM_DEBUG_KMS. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] HAX: force i915.disable_display=1

2018-09-13 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 6c4d4a21474b..3d9fa6bb8f2b 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_param

[Intel-gfx] [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently

2018-09-13 Thread Chris Wilson
Convert the interface (except for the drm core callback) to accept drm_i915_private as that is our native type of the majority of operations. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c| 10 +-- drivers/gpu/drm/i915/intel_drv.h | 28 +++ drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 3/4] drm/i915: Disable displays at the user's request

2018-09-13 Thread Chris Wilson
If the user passes i915.disable_display=1 we want to disable all the displays and associated HW like the powerwells on their behalf. Instead of short circuiting the HW probe, let it run and setup all the bookkeeping for the known HW. Afterwards, instead of taking over the BIOS fb and installing the

[Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä We wish to control certain driver_features flags on a per-device basis while still sharing a single drm_driver instance across all the devices. To that end introduce device.driver_features. By default it will be set to ~0 to not impose any limits beyond driver.driver_features.

[Intel-gfx] [PATCH 2/2] drm/i915: Clear DRIVER_ATOMIC on a per-device basis

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Currently we're clearing DRIVER_ATOMIC in driver.driver_features for older platforms. This will not work correctly should we ever have a system with and old and new GPU in it. While that is not possible currently let's make the code more correct and use the per-device driver_f

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove fb pitch limit for no display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Remove fb pitch limit for no display URL : https://patchwork.freedesktop.org/series/49625/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816_full -> Patchwork_10166_full = == Summary - WARNING == Minor unknown changes coming with P

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Disable displays at the user's request

2018-09-13 Thread Chris Wilson
Quoting Chris Wilson (2018-09-13 14:16:28) > + /* > +* After completing our HW probe; tear it all down again (at the > +* user's request)! > +* > +* Along side the CRTCs and connectors, there is a medley of > +* auxiliary HW which control various powerw

[Intel-gfx] [PATCH i-g-t 2/2] lib: Skip drmModeReources()

2018-09-13 Thread Chris Wilson
An alternative to requiring the display is to mark the attached display as empty (no available CRTC, no outputs) and let the tests skip if they required any output. This allows the binary to open the display once in its global fixture, even if it doesn't use the display in every subtest and so avoi

[Intel-gfx] [PATCH i-g-t 1/2] lib: Require drmModeResources()

2018-09-13 Thread Chris Wilson
If modesetting is not supported, the drmModeGetResources() call will fail with -EINVAL (or -ENOTSUPP). As no displays are connected, skip. Signed-off-by: Chris Wilson --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3e0a07b

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 14:16:21) > From: Ville Syrjälä > > We wish to control certain driver_features flags on a per-device basis > while still sharing a single drm_driver instance across all the > devices. To that end introduce device.driver_features. By default > it will be set to ~0

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Clear DRIVER_ATOMIC on a per-device basis

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 14:16:22) > From: Ville Syrjälä > > Currently we're clearing DRIVER_ATOMIC in driver.driver_features > for older platforms. This will not work correctly should we ever > have a system with and old and new GPU in it. While that is not > possible currently let's ma

Re: [Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-13 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 10:29:42AM +0100, Chris Wilson wrote: > If the ioctl is not supported on a particular piece of HW/driver > combination, report ENOTSUPP so that it can be easily distinguished from > both the lack of the ioctl and from a regular invalid parameter. > > v2: Across all the kms

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : warning == Summary == $ dim checkpatch origin/drm-tip b7501effb8ce drm/i915: Mark up a couple of KMS debug messages as

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Mark up a couple of KMS debug messages as such Oka

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We wish to control certain driver_features flags on a per-device basis > while still sharing a single drm_driver instance across all the > devices. To that end introduce device.driver_features. By default > i

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such URL : https://patchwork.freedesktop.org/series/49641/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10167 = == Summary - FAILURE == Serious

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-13 Thread Imre Deak
On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote: > On Wed, 12 Sep 2018 15:18:47 +0200, > Imre Deak wrote: > > > > +Takashi > > > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > > Hi Kumar, Takashi, > > > > > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Introduce per-device driver_features URL : https://patchwork.freedesktop.org/series/49639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10168 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We wish to control certain driver_features flags on a per-device basis > > while still sharing a single drm_driver instance across all th

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 15:54:37 +0200, Imre Deak wrote: > > On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote: > > On Wed, 12 Sep 2018 15:18:47 +0200, > > Imre Deak wrote: > > > > > > +Takashi > > > > > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > > > Hi Kumar, Takash

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Michel Dänzer
On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: >> On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> We wish to control certain driver_features flags on a per-device basis >>> while still sh

[Intel-gfx] [PATCH] drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Use I915_GTT_PAGE_SIZE when talking about GTT pages rather than physical pages. There are some PAGE_SHIFTs left though. Not sure if we want to introduce I915_GTT_PAGE_SHIFT or what? Cc: Chris Wilson Suggested-by: Chris Wilson # at least some of it :) Signed-off-by: Ville S

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 04:52:34PM +0200, Michel Dänzer wrote: > On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > >> On Thu, Sep 13, 2018 at 04:16:21PM +0300, Ville Syrjala wrote: > >>> From: Ville Syrjälä > >>> > >>> We wish to con

[Intel-gfx] [PATH i-g-t] igt_sysfs: Avoid double closing the fd in igt_sysfs_scanf

2018-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin fdopen takes ownership of the fd so only one flavour of closing it is needed. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c index 9012cc73f6e3..d323b81dd986 100644 -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8d4f7a2b425b drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power

Re: [Intel-gfx] [igt-dev] [PATH i-g-t] igt_sysfs: Avoid double closing the fd in igt_sysfs_scanf

2018-09-13 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-13 16:06:13) > From: Tvrtko Ursulin > > fdopen takes ownership of the fd so only one flavour of closing it is > needed. Indeed, I always seem to get burned by this. One day I might remember... Who am I kidding? :) > Signed-off-by: Tvrtko Ursulin Reviewed-by: Ch

Re: [Intel-gfx] [PATCH] drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 16:04:05) > From: Ville Syrjälä > > Use I915_GTT_PAGE_SIZE when talking about GTT pages rather than > physical pages. Yup, these are all concerned with GTT units so we prefer I915_GTT_PAGE_SIZE. > There are some PAGE_SHIFTs left though. Not sure if we want to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10169 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : warning == Summary == $ dim checkpatch origin/drm-tip f7ce7c3fcf8c drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE -:16: WARNING:COMMIT_L

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: Introduce per-device driver_features URL : https://patchwork.freedesktop.org/series/49639/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816_full -> Patchwork_10168_full = == Summary - SUCCESS == No regression

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10170 = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Bruno Prémont
On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > On Wed, 12 Sep 2018 19:46:58 +0200, > Ville Syrjälä wrote: > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > > Hi, > > > > > > I have a system with multiple monitors and would like to send > > > notification sound

Re: [Intel-gfx] [REGRESSION 4.19-rc2] sometimes hangs with black screen when resuming from suspend or hibernation (was: Re: Linux 4.19-rc2)

2018-09-13 Thread Martin Steigerwald
Ville Syrjälä - 12.09.18, 19:10: > On Tue, Sep 11, 2018 at 12:17:05PM +0200, Martin Steigerwald wrote: > > Cc´d Intel Gfx mailing list, in case somebody there knows something: > > > > Cc´d Thorsten for regression tracking… forgot initially. Can also > > open bug report at a later time but so far I

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 09:25:37 +0200, Bruno Prémont wrote: > > On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > > On Wed, 12 Sep 2018 19:46:58 +0200, > > Ville Syrjälä wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > > > Hi, > > > > > > > > I have a s

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev8) URL : https://patchwork.freedesktop.org/series/42459/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4816_full -> Patchwork_10169_full = == Summary - SUCCESS == No r

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Patchwork
== Series Details == Series: i915, HDMI/DP audio with multiple monitors URL : https://patchwork.freedesktop.org/series/49647/ State : warning == Summary == $ dim checkpatch origin/drm-tip a3ce8c6aec87 i915, HDMI/DP audio with multiple monitors -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwra

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce per-device driver_features

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 06:06:01PM +0300, Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 04:52:34PM +0200, Michel Dänzer wrote: > > On 2018-09-13 4:29 p.m., Ville Syrjälä wrote: > > > On Thu, Sep 13, 2018 at 03:50:01PM +0200, Daniel Vetter wrote: > > >> On Thu, Sep 13, 2018 at 04:16:21PM +0300, Vil

[Intel-gfx] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä We now have per-device driver_features, so let's use that to disable atomic only for pre-nv50. Cc: Ben Skeggs Cc: Lyude Paul Cc: nouv...@lists.freedesktop.org Cc: Daniel Vetter Reviewed-by: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- driv

[Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Disable atomic on a per-device basis instead of for all devices. Made possible by the new device.driver_features thing. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: Michel Dänzer Suggested-by: Michel Dänzer Signed-off-by: Vil

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Patchwork
== Series Details == Series: i915, HDMI/DP audio with multiple monitors URL : https://patchwork.freedesktop.org/series/49647/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4816 -> Patchwork_10171 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_101

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Michel Dänzer
On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > From: Ville Syrjälä > > Disable atomic on a per-device basis instead of for all devices. > Made possible by the new device.driver_features thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: Harry Wentland >

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Alex Deucher
On Thu, Sep 13, 2018 at 12:39 PM Michel Dänzer wrote: > > On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Disable atomic on a per-device basis instead of for all devices. > > Made possible by the new device.driver_features thing. > > > > Cc: Alex Deucher > > Cc: "Ch

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Bob Paauwe
On Wed, 12 Sep 2018 17:10:58 +0100 Chris Wilson wrote: > Quoting Bob Paauwe (2018-09-12 17:04:30) > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > index 43ed8b28aeaa..33d7225edbbb 100644 > > --- a/drivers/gpu/drm/i915/se

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > On Wed, 12 Sep 2018 17:10:58 +0100 > Chris Wilson wrote: > > > Quoting Bob Paauwe (2018-09-12 17:04:30) > > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > >

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Bob Paauwe
On Thu, 13 Sep 2018 20:05:54 +0300 Ville Syrjälä wrote: > On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > > On Wed, 12 Sep 2018 17:10:58 +0100 > > Chris Wilson wrote: > > > > > Quoting Bob Paauwe (2018-09-12 17:04:30) > > > > diff --git a/drivers/gpu/drm/i915/selftests/mock_ge

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 10:12:06AM -0700, Bob Paauwe wrote: > On Thu, 13 Sep 2018 20:05:54 +0300 > Ville Syrjälä wrote: > > > On Thu, Sep 13, 2018 at 10:02:57AM -0700, Bob Paauwe wrote: > > > On Wed, 12 Sep 2018 17:10:58 +0100 > > > Chris Wilson wrote: > > > > > > > Quoting Bob Paauwe (2018-0

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/nouveau: Disable atomic support on a per-device basis URL : https://patchwork.freedesktop.org/series/49650/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10172 = == Summary - FAILURE == Seriou

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Use coherent writes into the context image

2018-09-13 Thread Chris Wilson
That we use a WB mapping for updating the RING_TAIL register inside the context image even on !llc machines has been a source of consternation for every reader. It appears to work on bsw+, but it may just have been that we have been incredibly bad at detecting the errors. v2: With extra enthusiasm

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Chris Wilson
Now that we reload both RING_HEAD and RING_TAIL when rebinding the context, we do not need to scrub those registers immediately on resume. v2: Handle the perma-pinned contexts. v3: Set RING_TAIL on context-pin so that we always have known state in the context image for the ring registers and all p

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10173 = == Summary - WARNING == Minor unknown changes coming with P

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Tvrtko Ursulin
On 13/09/2018 18:32, Chris Wilson wrote: Now that we reload both RING_HEAD and RING_TAIL when rebinding the context, we do not need to scrub those registers immediately on resume. v2: Handle the perma-pinned contexts. v3: Set RING_TAIL on context-pin so that we always have known state in the co

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume URL : https://patchwork.freedesktop.org/series/49654/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/execlists: Delay updating ring register

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume URL : https://patchwork.freedesktop.org/series/49654/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4817 -> Patchwork_10174 = == Summary - FAILURE ==

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-13 Thread Ville Syrjälä
On Thu, Sep 13, 2018 at 12:40:20PM -0400, Alex Deucher wrote: > On Thu, Sep 13, 2018 at 12:39 PM Michel Dänzer wrote: > > > > On 2018-09-13 6:31 p.m., Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Disable atomic on a per-device basis instead of for all devices. > > > Made possible by

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE URL : https://patchwork.freedesktop.org/series/49645/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4817_full -> Patchwork_10173_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-13 Thread Chris Wilson
If the ioctl is not supported on a particular piece of HW/driver combination, report ENOTSUP (aka EOPNOTSUPP) so that it can be easily distinguished from both the lack of the ioctl and from a regular invalid parameter. v2: Across all the kms ioctls we had a mixture of reporting EINVAL, ENODEV and

[Intel-gfx] [PATCH v3] drm/i915/execlists: Use coherent writes into the context image

2018-09-13 Thread Chris Wilson
That we use a WB mapping for updating the RING_TAIL register inside the context image even on !llc machines has been a source of consternation for every reader. It appears to work on bsw+, but it may just have been that we have been incredibly bad at detecting the errors. v2: With extra enthusiasm

[Intel-gfx] [PATCH] drm/i915/icl: Enable DC9 as lowest possible state during screen-off

2018-09-13 Thread Anusha Srivatsa
From: Animesh Manna ICL supports DC5, DC6, and DC9. Enable DC9 during screen-off, and enable DC5/6 when appropriate. v2: (James Ausmus) - Also handle ICL as GEN9_LP in i915_drm_suspend_late and i915_drm_suspend_early - Add DC9 to gen9_dc_mask for ICL - Re-order GEN checks for newest platfo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Differentiate the lack of an interface from invalid parameter (rev4)

2018-09-13 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter (rev4) URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4818 -> Patchwork_10175 = == Summary - SUCCESS == No regressions fo

[Intel-gfx] [PATCH v2 2/5] drm/i915: Add a new "remapped" gtt_view

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä To overcome display engine stride limits we'll want to remap the pages in the GTT. To that end we need a new gtt_view type which is just like the "rotated" type except not rotated. v2: Use intel_remapped_plane_info base type s/unused/unused_mbz/ (Chris) Separate BUILD

[Intel-gfx] [PATCH v2 1/5] drm/i915: Decouple SKL stride units from intel_fb_stride_alignment()

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä In the future framebuffer stride alignment requirements won't exactly match the units in which skl+ plane stride is specified. So extract the code for the skl+ stuff into a separate helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 28 +

[Intel-gfx] [PATCH v2 5/5] drm/i915: Bump gen4+ fb size limits to 32kx32k

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä With gtt remapping in place we can use arbitraily large framebuffers. Let's bump the limits as high as we can (32k-1). Going beyond that would require switching our s16.16 src coordinate representation to something with more spare bits. Signed-off-by: Ville Syrjälä --- driv

[Intel-gfx] [PATCH v2 4/5] drm/i915: Bump gen4+ fb stride limit to 256KiB

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä With gtt remapping plugged in we can simply raise the stride limit on gen4+. Let's just arbitraily pick 256 KiB as the limit. No remapping CCS because the virtual address of each page actually matters due to the new hash mode (WaCompressedResourceDisplayNewHashMode:skl,kbl et

[Intel-gfx] [PATCH v2 0/5] drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä Lots of prep stuff for the GTT remapping already landed, so now we're left with just the real meat: the remapped vma and actually constructing it. I spotted that I kinda busted up the skl+ stride_mult stuff for linear buffers in the BIOS fb takeover path so I included a fix f

[Intel-gfx] [PATCH v2 3/5] drm/i915: Overcome display engine stride limits via GTT remapping

2018-09-13 Thread Ville Syrjala
From: Ville Syrjälä The display engine stride limits are getting in our way. On SKL+ we are limited to 8k pixels, which is easily exceeded with three 4k displays. To overcome this limitation we can remap the pages in the GTT to provide the display engine with a view of memory with a smaller strid

Re: [Intel-gfx] [PATCH] drm/i915/icl: Enable DC9 as lowest possible state during screen-off

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 12:31:09PM -0700, Anusha Srivatsa wrote: > From: Animesh Manna > > ICL supports DC5, DC6, and DC9. Enable DC9 during screen-off, and enable > DC5/6 when appropriate. > > v2: (James Ausmus) > - Also handle ICL as GEN9_LP in i915_drm_suspend_late and >i915_drm_suspend_

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Overcome display engine stride limits via GTT remapping

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:38) > +static void > +intel_plane_remap_gtt(struct intel_plane_state *plane_state) > +{ > + struct drm_i915_private *dev_priv = > + to_i915(plane_state->base.plane->dev); > + struct drm_framebuffer *fb = plane_state->base.fb; > +

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2) URL : https://patchwork.freedesktop.org/series/49654/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/execlists: Delay updating ring re

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Bump gen4+ fb stride limit to 256KiB

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:39) > From: Ville Syrjälä > > With gtt remapping plugged in we can simply raise the stride > limit on gen4+. Let's just arbitraily pick 256 KiB as the limit. > > No remapping CCS because the virtual address of each page actually > matters due to the new ha

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Add a new "remapped" gtt_view

2018-09-13 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-13 21:01:37) > diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c > b/drivers/gpu/drm/i915/selftests/i915_vma.c > index ffa74290e054..4fc49c27f13c 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_vma.c > +++ b/drivers/gpu/drm/i915/selftests/i915_vma.c > @@ -395

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Delay updating ring register state after resume (rev2) URL : https://patchwork.freedesktop.org/series/49654/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819 -> Patchwork_10176 = == Summary - WAR

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] lib: Require drmModeResources()

2018-09-13 Thread Souza, Jose
On Thu, 2018-09-13 at 14:24 +0100, Chris Wilson wrote: > If modesetting is not supported, the drmModeGetResources() call will > fail with -EINVAL (or -ENOTSUPP). As no displays are connected, skip. This one sounds better than the second patch to me. I just sent this patch together with other patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2)

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Enable DC9 as lowest possible state during screen-off (rev2) URL : https://patchwork.freedesktop.org/series/49447/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4819 -> Patchwork_10177 = == Summary - SUCCESS == No regressions f

Re: [Intel-gfx] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis

2018-09-13 Thread Lyude Paul
Hm, one nitpick here. Since /sys/kernel/debug/dri/*/state creation depends on the driver supporting atomic, maybe it would be good to make it so that we set DRIVER_ATOMIC in the driver_stub structure, then disable it per-device depending on the nouveau_atomic setting + hw support. That way we can a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: drm/i915: GTT remapping for display URL : https://patchwork.freedesktop.org/series/49663/ State : warning == Summary == $ dim checkpatch origin/drm-tip b24877977210 drm/i915: Decouple SKL stride units from intel_fb_stride_alignment() 7a895a3a3d0d drm/i91

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: drm/i915: GTT remapping for display

2018-09-13 Thread Patchwork
== Series Details == Series: drm/i915: drm/i915: GTT remapping for display URL : https://patchwork.freedesktop.org/series/49663/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Decouple SKL stride units from intel_fb_stride_alignment() Okay! Commit: drm/i915: Add a

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Mark up a couple of KMS debug messages as such

2018-09-13 Thread Rodrigo Vivi
On Thu, Sep 13, 2018 at 02:16:26PM +0100, Chris Wilson wrote: > For finding the panel fitter and PLL for a particular modeset is a part > of that modeset and should be included with the reset of the > DRM_DEBUG_KMS. > > Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi > --- > drivers/gpu

  1   2   >