Re: [Intel-gfx] [PATCH v5 00/13] ICELAKE DSI DRIVER

2018-09-12 Thread Jani Nikula
On Wed, 12 Sep 2018, Madhav Chauhan wrote: > On 9/12/2018 1:05 AM, Jani Nikula wrote: >> On Tue, 10 Jul 2018, Madhav Chauhan wrote: >>> From ICELAKE platform onwards, new MIPI DSI IP controller is integrated to >>> GPU/Display Engine and same could be extended for future Intel platforms as >>>

Re: [Intel-gfx] [PATCH] drm/i915/ringbuffer: Reload PDs harder on byt/bcs

2018-09-12 Thread Chris Wilson
Quoting Chris Wilson (2018-09-11 08:43:32) > Quoting Chris Wilson (2018-09-10 14:08:08) > > Baytrail takes a little more convincing that it needs to actually reload > > its Page Directoy (ppGTT) before the context switch, so repeat it until > > it gets the message. Once again the arbitrary values h

Re: [Intel-gfx] [PATCH 4/7] drm/i915/perf: lock powergating configuration to default when active

2018-09-12 Thread Tvrtko Ursulin
On 11/09/2018 21:11, Lionel Landwerlin wrote: On 10/09/2018 14:44, Tvrtko Ursulin wrote: On 07/09/2018 10:55, Lionel Landwerlin wrote: On 07/09/2018 10:39, Tvrtko Ursulin wrote: On 07/09/2018 10:23, Lionel Landwerlin wrote: On 07/09/2018 09:26, Tvrtko Ursulin wrote: On 06/09/2018 11:36,

Re: [Intel-gfx] [PATCH] drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB

2018-09-12 Thread Chris Wilson
Quoting Ville Syrjala (2018-09-11 17:54:57) > From: Ville Syrjälä > > If we have framebuffers that are >= 4GiB in size we will overflow > the fb size check in intel_fill_fb_info(). > > Currently that is only possible with NV12 and CCS as offsets[1] > may be anything between 0 and 0x. ofs

[Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Chris Wilson
If the ioctl is not supported on a particular piece of HW/driver combination, report ENODEV so that it can be easily distinguished from both the lack of the ioctl and from a regular invalid parameter. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Ville Syrjälä --- drivers/gpu/drm/drm_frame

Re: [Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 10:27 AM, Chris Wilson wrote: > If the ioctl is not supported on a particular piece of HW/driver > combination, report ENODEV so that it can be easily distinguished from > both the lack of the ioctl and from a regular invalid parameter. > > Signed-off-by: Chris Wilson > Cc

Re: [Intel-gfx] [igt-dev] [PATH i-g-t] igt: Test tagging support

2018-09-12 Thread Tvrtko Ursulin
On 07/09/2018 12:43, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-07 12:14:20) From: Tvrtko Ursulin Proposal to add test tags as a replacement for separate test list which can be difficult to maintain and get out of date. Putting this maintanenace inline with tests makes it easier to

Re: [Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Chris Wilson
Quoting Daniel Vetter (2018-09-12 09:39:30) > On Wed, Sep 12, 2018 at 10:27 AM, Chris Wilson > wrote: > > If the ioctl is not supported on a particular piece of HW/driver > > combination, report ENODEV so that it can be easily distinguished from > > both the lack of the ioctl and from a regular i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4808 -> Patchwork_10148 = == Summary - WARNING == Minor unknown changes com

Re: [Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 10:50 AM, Chris Wilson wrote: > Quoting Daniel Vetter (2018-09-12 09:39:30) >> On Wed, Sep 12, 2018 at 10:27 AM, Chris Wilson >> wrote: >> > If the ioctl is not supported on a particular piece of HW/driver >> > combination, report ENODEV so that it can be easily distingui

Re: [Intel-gfx] [PATCH v5 02/13] drm/i915/icl: DSI vswing programming sequence

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 12:20 AM, Jani Nikula wrote: On Tue, 10 Jul 2018, Madhav Chauhan wrote: This patch setup voltage swing before enabling combo PHY DDI (shared with DSI). Note that DSI voltage swing programming is for high speed data buffers. HW automatically handles the voltage swing for the low pow

Re: [Intel-gfx] [PATCH v5 03/13] drm/i915/icl: Enable DDI Buffer

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 12:24 AM, Jani Nikula wrote: On Tue, 10 Jul 2018, Madhav Chauhan wrote: This patch enables DDI buffer by writing to DDI_BUF_CTL register and wait for DDI status to be *not idle* for a port. v2: Rebase Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/icl_dsi.c | 22 ++

Re: [Intel-gfx] [igt-dev] [PATH i-g-t] igt: Test tagging support

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-12 09:48:00) > > On 07/09/2018 12:43, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-09-07 12:14:20) > >> From: Tvrtko Ursulin > >> > >> Proposal to add test tags as a replacement for separate test > >> list which can be difficult to maintain and get out of d

Re: [Intel-gfx] [PATCH v5 02/13] drm/i915/icl: DSI vswing programming sequence

2018-09-12 Thread Jani Nikula
On Wed, 12 Sep 2018, Madhav Chauhan wrote: > On 9/12/2018 12:20 AM, Jani Nikula wrote: >> On Tue, 10 Jul 2018, Madhav Chauhan wrote: >>> This patch setup voltage swing before enabling >>> combo PHY DDI (shared with DSI). >>> Note that DSI voltage swing programming is for >>> high speed data buffe

Re: [Intel-gfx] [PATCH v5 06/13] drm/i915/icl: Define data/clock lanes dphy timing registers

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 12:44 AM, Jani Nikula wrote: On Tue, 10 Jul 2018, Madhav Chauhan wrote: This patch defines DSI_CLK_TIMING_PARAM, DPHY_CLK_TIMING_PARAM, DSI_DATA_TIMING_PARAM, DPHY_DATA_TIMING_PARAM register used in dphy programming. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_r

Re: [Intel-gfx] [PATCH v5 03/13] drm/i915/icl: Enable DDI Buffer

2018-09-12 Thread Jani Nikula
On Wed, 12 Sep 2018, Madhav Chauhan wrote: > On 9/12/2018 12:24 AM, Jani Nikula wrote: >> On Tue, 10 Jul 2018, Madhav Chauhan wrote: >>> This patch enables DDI buffer by writing to DDI_BUF_CTL >>> register and wait for DDI status to be *not idle* for a >>> port. >>> >>> v2: Rebase >>> >>> Signed-

Re: [Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Chris Wilson
Quoting Daniel Vetter (2018-09-12 10:02:47) > On Wed, Sep 12, 2018 at 10:50 AM, Chris Wilson > wrote: > > Quoting Daniel Vetter (2018-09-12 09:39:30) > >> On Wed, Sep 12, 2018 at 10:27 AM, Chris Wilson > >> wrote: > >> > If the ioctl is not supported on a particular piece of HW/driver > >> > co

Re: [Intel-gfx] [PATCH v5 08/13] drm/i915/icl: Define TA_TIMING_PARAM registers

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 12:53 AM, Jani Nikula wrote: On Tue, 10 Jul 2018, Madhav Chauhan wrote: This patch defines DSI_TA_TIMING_PARAM and DPHY_TA_TIMING_PARAM registers used in dphy programming. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 14 ++ 1 file changed, 14

Re: [Intel-gfx] [PATCH v5 09/13] drm/i915/icl: Program TA_TIMING_PARAM registers

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 12:56 AM, Jani Nikula wrote: On Fri, 20 Jul 2018, "Chauhan, Madhav" wrote: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Thursday, July 19, 2018 9:51 PM To: Chauhan, Madhav Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; Zanoni, Pa

[Intel-gfx] [PATCH v2] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Chris Wilson
If the ioctl is not supported on a particular piece of HW/driver combination, report ENOTSUPP so that it can be easily distinguished from both the lack of the ioctl and from a regular invalid parameter. v2: Across all the kms ioctls we had a mixture of reporting EINVAL, ENODEV and a few ENOTSUPP (

[Intel-gfx] [PATCH v3] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Chris Wilson
If the ioctl is not supported on a particular piece of HW/driver combination, report ENOTSUPP so that it can be easily distinguished from both the lack of the ioctl and from a regular invalid parameter. v2: Across all the kms ioctls we had a mixture of reporting EINVAL, ENODEV and a few ENOTSUPP (

[Intel-gfx] [PATH i-g-t 1/2] intel: Be consistent with test results on simulation

2018-09-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tests which call intel_require_memory currently always skip on simulation, unless they fail first due insufficient memory. This can create different outcomes depending on the simulation environment so move the simulation skip to the start of the function for 100% consistency

[Intel-gfx] [PATH i-g-t 2/2] core: Show backtrace from igt_skip_on_simulation

2018-09-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin igt_skip_on_simulation is called both directly from tests but also from library helpers. In the latter case especially the logged caller name is useless since it is always the helper itself. What we instead want to know is who is the caller. Trivial approach would be to move

Re: [Intel-gfx] [PATCH v5 12/13] drm/i915/icl: Define TRANS_DSI_FUNC_CONF register

2018-09-12 Thread Madhav Chauhan
On 9/12/2018 1:00 AM, Jani Nikula wrote: On Tue, 10 Jul 2018, Madhav Chauhan wrote: This patch defines transcoder function configuration registers and its bitfields for both DSI ports. Used while programming/enabling DSI transcoder. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH v5 11/13] drm/i915/icl: Add macros for MMIO of DSI transcoder registers

2018-09-12 Thread Madhav Chauhan
On 7/19/2018 9:52 PM, Ville Syrjälä wrote: On Tue, Jul 10, 2018 at 03:10:12PM +0530, Madhav Chauhan wrote: This patch adds _MMIO_DSI and _DSI_TRANS macros for accessing DSI transcoder registers. Credits-to: Jani N Cc: Jani Nikula Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_

Re: [Intel-gfx] [PATCH v5 09/13] drm/i915/icl: Program TA_TIMING_PARAM registers

2018-09-12 Thread Jani Nikula
On Wed, 12 Sep 2018, Madhav Chauhan wrote: > On 9/12/2018 12:56 AM, Jani Nikula wrote: >> On Fri, 20 Jul 2018, "Chauhan, Madhav" wrote: -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Thursday, July 19, 2018 9:51 PM To: Chauhan, Madh

Re: [Intel-gfx] [PATCH 01/26] drm/i915/ringbuffer: Reload PDs harder on byt/bcs

2018-09-12 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-11 14:57:45) > Baytrail takes a little more convincing that it needs to actually reload > its Page Directoy (ppGTT) before the context switch, so repeat it until > it gets the message. Once again the arbitrary values here are > empirically derived. > > Bugzilla: https

Re: [Intel-gfx] [PATCH v5 12/13] drm/i915/icl: Define TRANS_DSI_FUNC_CONF register

2018-09-12 Thread Jani Nikula
On Wed, 12 Sep 2018, Madhav Chauhan wrote: > On 9/12/2018 1:00 AM, Jani Nikula wrote: >> On Tue, 10 Jul 2018, Madhav Chauhan wrote: >> The convention is to define macros for field values that you can OR >> directly in place instead of requiring a shift. Please stick to the >> conventions. Use _SH

Re: [Intel-gfx] [PATCH] drm/i915/ringbuffer: Reload PDs harder on byt/bcs

2018-09-12 Thread Chris Wilson
Quoting Chris Wilson (2018-09-10 14:08:08) > Baytrail takes a little more convincing that it needs to actually reload > its Page Directoy (ppGTT) before the context switch, so repeat it until > it gets the message. Once again the arbitrary values here are > empirically derived. > > Bugzilla: https

Re: [Intel-gfx] [PATCH 02/26] drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G

2018-09-12 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-11 14:57:46) > If the caller supplies more than 4G of objects and than one that has to > be in the low 4G, it is possible for the low 4G to be full before we > attempt to find room for the last object that must be there. As we don't > reorder the two types, every pass

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Differentiate the lack of an interface from invalid parameter (rev3)

2018-09-12 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter (rev3) URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4808 -> Patchwork_10149 = == Summary - SUCCESS == No regressions fo

[Intel-gfx] [CI] drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G

2018-09-12 Thread Chris Wilson
If the caller supplies more than 4G of objects and than one that has to be in the low 4G, it is possible for the low 4G to be full before we attempt to find room for the last object that must be there. As we don't reorder the two types, every pass hits the same problem and we fail with ENOSPC. Howe

[Intel-gfx] [PATCH v2 3/4] drm/i915/icl: Preparations for enabling Y210, Y212, Y216 formats

2018-09-12 Thread Swati Sharma
From: Vidya Srinivas Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_display.c | 15 +++ drivers/gpu/drm/i915/intel_sprite.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH v2 0/4] Enable Y210, Y212, Y216 formats for ICL

2018-09-12 Thread Swati Sharma
These patches enable packed format YUV422-Y210, Y212 and Y216 for 10, 12 and 16 bit respectively for ICL. For user space component IGT:WIP v2: addressed review comments of mahesh and alexandru hdr handling of these 64 bit pixel format not inscope of this series Vidya Srinivas (4): drm

[Intel-gfx] [PATCH v2 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

2018-09-12 Thread Swati Sharma
From: Vidya Srinivas The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies a DWORD. Y210:Valid data occupies MSB 10 bits. LSB 6 bits are filled with zeroes. Y212:Valid data occ

[Intel-gfx] [PATCH v2 2/4] drm/i915/icl: Add Y210, Y212, Y216 plane control definitions

2018-09-12 Thread Swati Sharma
From: Vidya Srinivas Added needed plane control flag definitions for Y210, Y212 and Y216 formats. Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/

[Intel-gfx] [PATCH v2 4/4] drm/i915/icl: Enable Y210, Y212, Y216 format for primary and sprite planes

2018-09-12 Thread Swati Sharma
From: Vidya Srinivas In this patch, a list for icl specific pixel formats is created in which Y210, Y212 and Y216 pixel formats are added along with legacy pixel formats for primary and sprite plane. Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_disp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G URL : https://patchwork.freedesktop.org/series/49548/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809 -> Patchwork_10150 = == Summary - SUCCESS == No regressions foun

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Y210, Y212, Y216 formats for ICL (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: Enable Y210, Y212, Y216 formats for ICL (rev2) URL : https://patchwork.freedesktop.org/series/48729/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7d34116618f8 drm: Add Y210, Y212, Y216 format definitions and fourcc -:38: WARNING:LONG_LINE: line ove

[Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
If we try and fail to allocate a i915_request, we apply some backpressure on the clients to throttle the memory allocations coming from i915.ko. Currently, we wait until completely idle, but this is far too heavy and leads to some situations where the only escape is to declare a client hung and res

[Intel-gfx] [PATCH i-g-t] igt/gem_exec_await: Flush vm caches between runs

2018-09-12 Thread Chris Wilson
On allocating a request, we apply some backpressure if we fail to allocate a request. The backpressure we apply involves waiting for the device to idle, causing a stall on the clients (trying to throttle heavy allocators) and as we may be inside a plugged critical section, the only way to idle the

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Y210, Y212, Y216 formats for ICL (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: Enable Y210, Y212, Y216 formats for ICL (rev2) URL : https://patchwork.freedesktop.org/series/48729/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4809 -> Patchwork_10151 = == Summary - FAILURE == Serious unknown changes coming with Patchwork

[Intel-gfx] ✓ Fi.CI.BAT: success for add LG panel to dpcd quirk database (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: add LG panel to dpcd quirk database (rev2) URL : https://patchwork.freedesktop.org/series/49413/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809 -> Patchwork_10152 = == Summary - SUCCESS == No regressions found. External URL: https://p

Re: [Intel-gfx] [PATH i-g-t v12 2/2] tests: add slice power programming test

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-11 15:42:10) > + last_with_engines = -1; > + for (class = 0; class < ~0; class++) { > + for (instance = 0; instance < ~0; instance++) { > + int ret; > + > + sseu.class = class; > +

Re: [Intel-gfx] [PATH i-g-t 1/2] intel: Be consistent with test results on simulation

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-12 10:33:05) > From: Tvrtko Ursulin > > Tests which call intel_require_memory currently always skip on simulation, > unless they fail first due insufficient memory. This can create different > outcomes depending on the simulation environment so move the simulation

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Limit the backpressure for i915_request allocation URL : https://patchwork.freedesktop.org/series/49555/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809 -> Patchwork_10153 = == Summary - SUCCESS == No regressions found. Extern

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/icl: Add Y210, Y212, Y216 plane control definitions

2018-09-12 Thread Juha-Pekka Heikkila
On 12.09.2018 13:32, Swati Sharma wrote: From: Vidya Srinivas Added needed plane control flag definitions for Y210, Y212 and Y216 formats. Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

Re: [Intel-gfx] [PATCH v2 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

2018-09-12 Thread Juha-Pekka Heikkila
On 12.09.2018 13:32, Swati Sharma wrote: From: Vidya Srinivas The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies a DWORD. Just to be clear I wouldn't use 'DWORD' here but

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Differentiate the lack of an interface from invalid parameter (rev3)

2018-09-12 Thread Patchwork
== Series Details == Series: drm: Differentiate the lack of an interface from invalid parameter (rev3) URL : https://patchwork.freedesktop.org/series/49536/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4808_full -> Patchwork_10149_full = == Summary - SUCCESS == No regr

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

2018-09-12 Thread Ville Syrjälä
On Tue, Sep 11, 2018 at 06:19:56PM -0700, José Roberto de Souza wrote: > Without this gem will not be able to turn off DC states to redunce > interruption latency when no sink is being driven by driver. Do we know that for sure this is still required? Some kind of test results to confirm would be

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add POWER_DOMAIN_GT_IRQ to ICL DC_OFF_POWER_DOMAINS

2018-09-12 Thread Chris Wilson
Quoting Ville Syrjälä (2018-09-12 13:48:42) > On Tue, Sep 11, 2018 at 06:19:56PM -0700, José Roberto de Souza wrote: > > Without this gem will not be able to turn off DC states to redunce > > interruption latency when no sink is being driven by driver. > > Do we know that for sure this is still re

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-12 Thread Imre Deak
Hi Kumar, Takashi, On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote: > From: Ville Syrjälä > > CDCLK has to be at least twice the BLCK regardless of audio. Audio > driver has to probe using this hook and increase the clock even in > absence of any display. > > v2: Use atomic refcount

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-12 Thread Imre Deak
+Takashi On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > Hi Kumar, Takashi, > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote: > > From: Ville Syrjälä > > > > CDCLK has to be at least twice the BLCK regardless of audio. Audio > > driver has to probe using this hook an

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/icl: Enable Y210, Y212, Y216 format for primary and sprite planes

2018-09-12 Thread Juha-Pekka Heikkila
On 12.09.2018 13:32, Swati Sharma wrote: From: Vidya Srinivas In this patch, a list for icl specific pixel formats is created in which Y210, Y212 and Y216 pixel formats are added along with legacy pixel formats for primary and sprite plane. Signed-off-by: Swati Sharma Signed-off-by: Vidya Sri

[Intel-gfx] ✓ Fi.CI.BAT: success for Add XYUV format support (rev6)

2018-09-12 Thread Patchwork
== Series Details == Series: Add XYUV format support (rev6) URL : https://patchwork.freedesktop.org/series/48007/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4810 -> Patchwork_10154 = == Summary - WARNING == Minor unknown changes coming with Patchwork_10154 need to be

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Tvrtko Ursulin
On 12/09/2018 12:11, Chris Wilson wrote: If we try and fail to allocate a i915_request, we apply some backpressure on the clients to throttle the memory allocations coming from i915.ko. Currently, we wait until completely idle, but this is far too heavy and leads to some situations where the onl

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-12 14:34:16) > > On 12/09/2018 12:11, Chris Wilson wrote: > > If we try and fail to allocate a i915_request, we apply some > > backpressure on the clients to throttle the memory allocations coming > > from i915.ko. Currently, we wait until completely idle, but this

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-12 14:34:16) > > On 12/09/2018 12:11, Chris Wilson wrote: > > If we try and fail to allocate a i915_request, we apply some > > backpressure on the clients to throttle the memory allocations coming > > from i915.ko. Currently, we wait until completely idle, but this

Re: [Intel-gfx] [PATCH v4 02/25] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-09-12 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: *

Re: [Intel-gfx] [igt-dev] [PATH i-g-t] igt: Test tagging support

2018-09-12 Thread Tvrtko Ursulin
On 12/09/2018 10:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-12 09:48:00) On 07/09/2018 12:43, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-07 12:14:20) From: Tvrtko Ursulin Proposal to add test tags as a replacement for separate test list which can be difficult to maint

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-12 Thread Ville Syrjälä
On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > Hi Kumar, Takashi, > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote: > > From: Ville Syrjälä > > > > CDCLK has to be at least twice the BLCK regardless of audio. Audio > > driver has to probe using this hook and increase

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Tvrtko Ursulin
On 12/09/2018 14:38, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-12 14:34:16) On 12/09/2018 12:11, Chris Wilson wrote: If we try and fail to allocate a i915_request, we apply some backpressure on the clients to throttle the memory allocations coming from i915.ko. Currently, we wait un

[Intel-gfx] [STABLE v4.18 BACKPORT] drm/i915: set DP Main Stream Attribute for color range on DDI platforms

2018-09-12 Thread Jani Nikula
commit 6209c285e7a5e68dbcdf8fd2456c6dd68433806b upstream. Since Haswell we have no color range indication either in the pipe or port registers for DP. Instead, there's a separate register for setting the DP Main Stream Attributes (MSA) directly. The MSA register definition makes no references to c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: set DP Main Stream Attribute for color range on DDI platforms (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: set DP Main Stream Attribute for color range on DDI platforms (rev2) URL : https://patchwork.freedesktop.org/series/48145/ State : failure == Summary == Applying: drm/i915: set DP Main Stream Attribute for color range on DDI platforms Using index info t

Re: [Intel-gfx] [PATCH v4 04/25] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-09-12 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC si

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Reorder execobject[] to insert non-48b objects into the low 4G URL : https://patchwork.freedesktop.org/series/49548/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809_full -> Patchwork_10150_full = == Summary - WARNING == Minor unk

[Intel-gfx] [PATCH 2/2] drm/i915: Restrict wait to client's timeline on i915_request alloc failure

2018-09-12 Thread Chris Wilson
Let's try not to overly penalize the unlucky client by making them wait for others to complete their work, and only apply the ratelimit if they themselves have outstanding work. Still, we apply global reclaim to the client (we need to scavenge some memory for it) so it doesn't got away completely s

[Intel-gfx] [PATCH 1/2] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
If we try and fail to allocate a i915_request, we apply some backpressure on the clients to throttle the memory allocations coming from i915.ko. Currently, we wait until completely idle, but this is far too heavy and leads to some situations where the only escape is to declare a client hung and res

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 3:42 PM, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-09-12 14:34:16) >> >> On 12/09/2018 12:11, Chris Wilson wrote: >> > If we try and fail to allocate a i915_request, we apply some >> > backpressure on the clients to throttle the memory allocations coming >> > from

Re: [Intel-gfx] [PATCH] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
Quoting Daniel Vetter (2018-09-12 15:47:21) > On Wed, Sep 12, 2018 at 3:42 PM, Chris Wilson > wrote: > > Quoting Tvrtko Ursulin (2018-09-12 14:34:16) > >> > >> On 12/09/2018 12:11, Chris Wilson wrote: > >> > If we try and fail to allocate a i915_request, we apply some > >> > backpressure on the c

[Intel-gfx] [PATCH] drm/i915/dp: fix shifting by a negative number of bits

2018-09-12 Thread Gustavo A. R. Silva
Function intel_port_to_tc() returns PORT_TC_NONE on error, which is a negative value -1. In case PORT_TC_NONE is returned, there is an undefined behavior when shifting by a negative number of bits in both DP_PHY_MODE_STATUS_NOT_SAFE and P_PHY_MODE_STATUS_COMPLETED macros. Fix this by adding sanity

[Intel-gfx] [PATCH] drm/i915: Restrict wait to client's timeline on i915_request alloc failure

2018-09-12 Thread Chris Wilson
Let's try not to overly penalize the unlucky client by making them wait for others to complete their work, and only apply the ratelimit if they themselves have outstanding work. Still, we apply global reclaim to the client (we need to scavenge some memory for it) so it doesn't got away completely s

Re: [Intel-gfx] [PATCH 00/13] drm/i915: Display gtt remapping prep stuff

2018-09-12 Thread Ville Syrjälä
On Fri, Sep 07, 2018 at 06:24:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > A reposting of all the reviewed prep stuff for the gtt remapping. > > Changes since the first posting: > - fix the ilk+ x-tiled stride to be 32k > - split out some unrelated changes (those were already pushe

[Intel-gfx] ✓ Fi.CI.IGT: success for add LG panel to dpcd quirk database (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: add LG panel to dpcd quirk database (rev2) URL : https://patchwork.freedesktop.org/series/49413/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809_full -> Patchwork_10152_full = == Summary - SUCCESS == No regressions found. == Known iss

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: fix shifting by a negative number of bits

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915/dp: fix shifting by a negative number of bits URL : https://patchwork.freedesktop.org/series/49565/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4812 -> Patchwork_10156 = == Summary - SUCCESS == No regressions found. External URL

[Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can remove the update-via-batch-buffer code path, which is basically an effective duplicate of update-via-context-image path, if we notice that after we have idled the GPU, we can update the context image even of the kernel context directly. (Update-via-batch-buffer path e

Re: [Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-12 Thread Lionel Landwerlin
On 12/09/2018 16:29, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We can remove the update-via-batch-buffer code path, which is basically an effective duplicate of update-via-context-image path, if we notice that after we have idled the GPU, we can update the context image even of the kernel cont

Re: [Intel-gfx] [PATCH] i915/oa: Simplify updating contexts

2018-09-12 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-12 16:29:30) > /* > * The OA register config is setup through the context image. This > image > * might be written to by the GPU on context switch (in particular on > @@ -1833,7 +1727,7 @@ static int gen8_configure_all_contexts(struct > dr

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Limit the backpressure for i915_request allocation URL : https://patchwork.freedesktop.org/series/49555/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4809_full -> Patchwork_10153_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-12 Thread Bob Paauwe
48 bit ppgtt device configuration is really just extended address range full ppgtt and may actually be something other than 48 bits. Change USES_FULL_48BIT_PPGTT() to USES_4LVL_PPGTT() to better describe that a 4 level walk table extended range PPGTT is being used. Add a new device info field that

Re: [Intel-gfx] [PATCH] drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB

2018-09-12 Thread Ville Syrjälä
On Wed, Sep 12, 2018 at 09:13:07AM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2018-09-11 17:54:57) > > From: Ville Syrjälä > > > > If we have framebuffers that are >= 4GiB in size we will overflow > > the fb size check in intel_fill_fb_info(). > > > > Currently that is only possible wit

Re: [Intel-gfx] [PATCH] drm/i915: Make 48bit full ppgtt configuration generic (v4)

2018-09-12 Thread Chris Wilson
Quoting Bob Paauwe (2018-09-12 17:04:30) > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > index 43ed8b28aeaa..33d7225edbbb 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++ b/drivers/gpu/drm/i915/selftests/mo

[Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-12 Thread Bruno Prémont
Hi, I have a system with multiple monitors and would like to send notification sounds to the monitor on which corresponding window is visible. For a workstation and a tiny computer things look different: - workstation (Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz): 00:02.0 VGA compatible controller [

Re: [Intel-gfx] [REGRESSION 4.19-rc2] sometimes hangs with black screen when resuming from suspend or hibernation (was: Re: Linux 4.19-rc2)

2018-09-12 Thread Martin Steigerwald
Cc´d Intel Gfx mailing list, in case somebody there knows something: Cc´d Thorsten for regression tracking… forgot initially. Can also open bug report at a later time but so far I cannot provide many details about the issue. Rafael J. Wysocki - 11.09.18, 10:17: > On Tue, Sep 11, 2018 at 10:01 A

Re: [Intel-gfx] [PATCH] drm: Differentiate the lack of an interface from invalid parameter

2018-09-12 Thread Christian König
Am 12.09.2018 um 11:12 schrieb Chris Wilson: Quoting Daniel Vetter (2018-09-12 10:02:47) On Wed, Sep 12, 2018 at 10:50 AM, Chris Wilson wrote: Quoting Daniel Vetter (2018-09-12 09:39:30) On Wed, Sep 12, 2018 at 10:27 AM, Chris Wilson wrote: If the ioctl is not supported on a particular piec

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Limit the backpressure for i915_request allocation (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Limit the backpressure for i915_request allocation (rev2) URL : https://patchwork.freedesktop.org/series/49564/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10157 = == Summary - SUCCESS ==

[Intel-gfx] [PATCH 2/3] drm/i915: Restrict wait to client's timeline on i915_request alloc failure

2018-09-12 Thread Chris Wilson
Let's try not to overly penalize the unlucky client by making them wait for others to complete their work, and only apply the ratelimit if they themselves have outstanding work. Still, we apply global reclaim to the client (we need to scavenge some memory for it) so it doesn't got away completely s

[Intel-gfx] [PATCH 3/3] drm/i915: Wait for the previous RCU grace period, not request completion

2018-09-12 Thread Chris Wilson
Under mempressure, our goal is to allow ourselves sufficient time to reclaim the RCU protected slabs without overly penalizing our clients. Currently, we use a 1 jiffie wait if the client is still active as a means of throttling the allocations, but we can instead wait for the end of the RCU grace

[Intel-gfx] [PATCH 1/3] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Chris Wilson
If we try and fail to allocate a i915_request, we apply some backpressure on the clients to throttle the memory allocations coming from i915.ko. Currently, we wait until completely idle, but this is far too heavy and leads to some situations where the only escape is to declare a client hung and res

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/oa: Simplify updating contexts

2018-09-12 Thread Patchwork
== Series Details == Series: i915/oa: Simplify updating contexts URL : https://patchwork.freedesktop.org/series/49569/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10158 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

Re: [Intel-gfx] [REGRESSION 4.19-rc2] sometimes hangs with black screen when resuming from suspend or hibernation (was: Re: Linux 4.19-rc2)

2018-09-12 Thread Ville Syrjälä
On Tue, Sep 11, 2018 at 12:17:05PM +0200, Martin Steigerwald wrote: > Cc´d Intel Gfx mailing list, in case somebody there knows something: > > Cc´d Thorsten for regression tracking… forgot initially. Can also open > bug report at a later time but so far I cannot provide many details > about the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename full ppgtt configuration to be more generic (rev4)

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Rename full ppgtt configuration to be more generic (rev4) URL : https://patchwork.freedesktop.org/series/49021/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10159 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Limit the backpressure for i915_request allocation

2018-09-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Limit the backpressure for i915_request allocation URL : https://patchwork.freedesktop.org/series/49572/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10160 = == Summary - SUCCESS == No

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-12 Thread Ville Syrjälä
On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > Hi, > > I have a system with multiple monitors and would like to send > notification sounds to the monitor on which corresponding > window is visible. > > For a workstation and a tiny computer things look different: > - workstation

Re: [Intel-gfx] [PATCH v5 11/13] drm/i915/icl: Add macros for MMIO of DSI transcoder registers

2018-09-12 Thread Ville Syrjälä
On Wed, Sep 12, 2018 at 03:06:41PM +0530, Madhav Chauhan wrote: > On 7/19/2018 9:52 PM, Ville Syrjälä wrote: > > On Tue, Jul 10, 2018 at 03:10:12PM +0530, Madhav Chauhan wrote: > >> This patch adds _MMIO_DSI and _DSI_TRANS macros for accessing > >> DSI transcoder registers. > >> > >> Credits-to: Ja

[Intel-gfx] [PATCH v2] drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB

2018-09-12 Thread Ville Syrjala
From: Ville Syrjälä If we have framebuffers that are >= 4GiB in size we will overflow the fb size check in intel_fill_fb_info(). Currently that is only possible with NV12 and CCS as offsets[1] may be anything between 0 and 0x. offsets[0] is currently required to be 0 so we can't hit the

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-12 Thread Takashi Iwai
On Wed, 12 Sep 2018 19:46:58 +0200, Ville Syrjälä wrote: > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > Hi, > > > > I have a system with multiple monitors and would like to send > > notification sounds to the monitor on which corresponding > > window is visible. > > > > F

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB (rev2) URL : https://patchwork.freedesktop.org/series/49495/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Fix a potential integer overflow with framebu

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-12 Thread Takashi Iwai
On Wed, 12 Sep 2018 15:18:47 +0200, Imre Deak wrote: > > +Takashi > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > Hi Kumar, Takashi, > > > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote: > > > From: Ville Syrjälä > > > > > > CDCLK has to be at least twice the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB (rev2)

2018-09-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB (rev2) URL : https://patchwork.freedesktop.org/series/49495/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4813 -> Patchwork_10161 = == Summary - SUCCESS == No

  1   2   >