Re: [Intel-gfx] [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against

2018-09-05 Thread Pandiyan, Dhinakaran
On Wed, 2018-09-05 at 12:51 +0200, Maarten Lankhorst wrote: > Op 05-09-18 om 12:22 schreef Ville Syrjälä: > > On Tue, Sep 04, 2018 at 08:54:03PM +, Pandiyan, Dhinakaran > > wrote: > > > On Tue, 2018-09-04 at 19:12 +0100, Chris Wilson wrote: > > > > Quoting Ville Syrjälä (2018-09-04 19:06:29) >

Re: [Intel-gfx] [PATCH 2/7] drm: Drop drmP.h from drm_connector.c

2018-09-05 Thread Sam Ravnborg
On Wed, Sep 05, 2018 at 03:57:06PM +0200, Daniel Vetter wrote: > Only needed minimal changes in drm_internal.h (for the drm_ioctl_t > type and a few forward declarations), plus a few missing includes in > drm_connector.c. > > Yay, the last stage of the drm header cleanup can finally commence! > >

Re: [Intel-gfx] [PATCH 2/7] drm: Drop drmP.h from drm_connector.c

2018-09-05 Thread Daniel Vetter
On Wed, Sep 5, 2018 at 7:12 PM, Sam Ravnborg wrote: > On Wed, Sep 05, 2018 at 03:57:06PM +0200, Daniel Vetter wrote: >> Only needed minimal changes in drm_internal.h (for the drm_ioctl_t >> type and a few forward declarations), plus a few missing includes in >> drm_connector.c. >> >> Yay, the last

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bdw: Increase IPS disable timeout to 100ms

2018-09-05 Thread Imre Deak
On Wed, Sep 05, 2018 at 12:44:37PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bdw: Increase IPS disable timeout to 100ms > URL : https://patchwork.freedesktop.org/series/49175/ > State : success Pushed, thanks for the review. > > == Summary == > > = CI Bug Log - chan

[Intel-gfx] [PATCH] [intel-gfx] drm/i915/intel_csr.c Added ICL Stepping info.

2018-09-05 Thread Jyoti Yadav
As DMC Package contain DMC FW for multiple steppings including default stepping. This patch will help to load FW for that particular stepping, if FW for that stepping is available, instead of loading default FW. v2 : Fix formatting issue. Signed-off-by: Jyoti Yadav Reviewed-by: Imre Deak --- d

Re: [Intel-gfx] [PATCH libdrm v2 5/5] intel: get gen once for gen >= 9

2018-09-05 Thread Lucas De Marchi
On Wed, Aug 29, 2018 at 03:31:11PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-29 01:35:32) > > We don't need to call IS_GEN() for each gen >= 9: we can rather use the > > new intel_is_genx() helper to iterate the pciids array once. > > > > Signed-off-by: Lucas De Marchi > > ---

[Intel-gfx] [PATCH] drm: Update todo.rst

2018-09-05 Thread Daniel Vetter
- drmP.h is now fully split up. - vkms is happening (and will gain its own todo and docs under a new vkms.rst file real soon) - legacy cruft is completely hidden now, drm_vblank.c is split out from drm_irq.c now. I've decided to drop the task to split out drm_legacy.ko, partially because Dave

[Intel-gfx] [PATCH] drm/amdgpu: Remove default best_encoder hook from DC

2018-09-05 Thread Daniel Vetter
For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic ones. v2: amdgpu uses ->best_encoder internally, give it a local copy. It might be a good idea to

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/7] drm: Add drm/drm_util.h header file

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm: Add drm/drm_util.h header file URL : https://patchwork.freedesktop.org/series/49184/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4772_full -> Patchwork_10093_full = == Summary - SUCCESS == No regressions foun

[Intel-gfx] [PULL] drm-intel-fixes

2018-09-05 Thread Rodrigo Vivi
Hi Dave, Here goes drm-intel-fixes-2018-09-05: The critical fix here on display side is the DP MST regression one. But this pull also include fixes for DP SST, small VDSC register fix and GVT's bucked with "BXT fixes, two guest warning fixes, dmabuf format mod fix and one for recent multiple VM t

[Intel-gfx] [PATCH libdrm v3 2/5] intel: make gen11 use generic gen macro

2018-09-05 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + intel/intel_chipset.h | 27 ++- 2 files changed, 3 insertions(+), 25 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 545819ae..a960b756 100644 --- a/intel/intel_chipset.c +++ b/

[Intel-gfx] [PATCH libdrm v3 0/5] intel: rework how we add PCI IDs

2018-09-05 Thread Lucas De Marchi
Adding PCI IDs to different projects is a boring manual task that motivated me to create this series. The idea is to centralize the IDs in the kernel header and let other projects copy it. Initially my plan was to convert all gens, back to gen2, but that proved slightly difficult since there are s

[Intel-gfx] [PATCH libdrm v3 4/5] intel: make gen9 use generic gen macro

2018-09-05 Thread Lucas De Marchi
The 2 PCI IDs that are used for the command line overrid mechanism were left defined. The rest can be gone and then we just use the kernel defines. Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 5 ++ intel/intel_chipset.h | 187 +- 2 files c

[Intel-gfx] [PATCH libdrm v3 3/5] intel: make gen10 use generic gen macro

2018-09-05 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + intel/intel_chipset.h | 34 +- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index a960b756..a627928e 100644 --- a/intel/intel_chipset.c

[Intel-gfx] [PATCH libdrm v3 1/5] intel: add generic functions to check PCI ID

2018-09-05 Thread Lucas De Marchi
This will allow platforms to reuse kernel IDs instead of manually keeping them in sync. In most of the cases we only need to extend IS_9XX(). Current platforms that fit this requirement can be ported over to use this macro. Right now it's a nop since it doesn't have any PCI ID added. The i915_pci

[Intel-gfx] [PATCH libdrm v3 5/5] intel: get gen once for gen >= 9

2018-09-05 Thread Lucas De Marchi
We don't need to call IS_GEN() for each gen >= 9: we can rather use the new intel_is_genx() helper to iterate the pciids array once. Signed-off-by: Lucas De Marchi --- intel/intel_bufmgr_gem.c | 8 +--- intel/intel_decode.c | 8 ++-- 2 files changed, 3 insertions(+), 13 deletions(-)

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move final cleanup of drm_i915_private to i915_driver_destroy

2018-09-05 Thread Michal Wajdeczko
On Wed, 05 Sep 2018 16:09:21 +0200, Chris Wilson wrote: Introduce a complementary function to i915_driver_create() to undo all that is created. Suggested-by: Michal Wajdeczko Signed-off-by: Chris Wilson Cc: Michal Wajdeczko Reviewed-by: Michal Wajdeczko ~Michal ___

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/intel_csr.c Added ICL Stepping info. (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/i915/intel_csr.c Added ICL Stepping info. (rev2) URL : https://patchwork.freedesktop.org/series/49058/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4773 -> Patchwork_10098 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm: Add drm/drm_util.h header file (rev2) URL : https://patchwork.freedesktop.org/series/49184/ State : warning == Summary == $ dim checkpatch origin/drm-tip ef536308c993 drm: Add drm/drm_util.h header file -:144: WARNING:FILE_PATH_CHANG

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm: Add drm/drm_util.h header file (rev2) URL : https://patchwork.freedesktop.org/series/49184/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: Add drm/drm_util.h header file -drivers/gpu/drm/i915/selftests/../i915

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-05 Thread Srivatsa, Anusha
>-Original Message- >From: Vivi, Rodrigo >Sent: Monday, September 3, 2018 10:27 PM >To: Deak, Imre >Cc: Srivatsa, Anusha ; Nikula, Jani >; intel-gfx@lists.freedesktop.org; Zanoni, Paulo R > >Subject: Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake. > >On Mon, Sep 03,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm: Add drm/drm_util.h header file (rev2) URL : https://patchwork.freedesktop.org/series/49184/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4773 -> Patchwork_10099 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/amdgpu: Remove default best_encoder hook from DC (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/amdgpu: Remove default best_encoder hook from DC (rev2) URL : https://patchwork.freedesktop.org/series/49194/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8405889a997b drm/amdgpu: Remove default best_encoder hook from DC -:104: WARNING:NO_AUTHO

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/amdgpu: Remove default best_encoder hook from DC (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/amdgpu: Remove default best_encoder hook from DC (rev2) URL : https://patchwork.freedesktop.org/series/49194/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/amdgpu: Remove default best_encoder hook from DC -drivers/gpu/drm/amd/amdgpu/../d

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Attach the pci match data to the device upon creation

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Attach the pci match data to the device upon creation URL : https://patchwork.freedesktop.org/series/49187/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4772_full -> Patchwork_10094_full = == Summary - WARN

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/amdgpu: Remove default best_encoder hook from DC (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/amdgpu: Remove default best_encoder hook from DC (rev2) URL : https://patchwork.freedesktop.org/series/49194/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4773 -> Patchwork_10100 = == Summary - SUCCESS == No regressions found. Externa

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-05 Thread Rodrigo Vivi
On Wed, Sep 05, 2018 at 11:55:32AM -0700, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Vivi, Rodrigo > >Sent: Monday, September 3, 2018 10:27 PM > >To: Deak, Imre > >Cc: Srivatsa, Anusha ; Nikula, Jani > >; intel-gfx@lists.freedesktop.org; Zanoni, Paulo R > > > >Subject: Re

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-05 Thread Srivatsa, Anusha
>-Original Message- >From: Vivi, Rodrigo >Sent: Wednesday, September 5, 2018 12:31 PM >To: Srivatsa, Anusha >Cc: Deak, Imre ; Nikula, Jani ; >intel-gfx@lists.freedesktop.org; Zanoni, Paulo R >Subject: Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake. > >On Wed, Sep 05

Re: [Intel-gfx] [PATCH 2/7] drm: Drop drmP.h from drm_connector.c

2018-09-05 Thread Sam Ravnborg
> > > 2) patch revision info belongs outside the changelog part - no? > > If it's information worth writing it's information worth recording. In > drm we're pretty much ok with whatever you feel like, and most people > include the patch revision in the commit message. Too many cases where > criti

[Intel-gfx] [PATCH] firmware/dmc/icl: Add MODULE_FIRMWARE()

2018-09-05 Thread Anusha Srivatsa
Add missing MODULE_FIRMWARE while loading DMC on Icelake. Rebased on top of https://patchwork.freedesktop.org/patch/246153/ Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.IGT: failure for Per context dynamic (sub)slice power-gating (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev2) URL : https://patchwork.freedesktop.org/series/48194/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4772_full -> Patchwork_10095_full = == Summary - FAILURE == Serious unknown changes coming

Re: [Intel-gfx] [PATCH libdrm v3 0/5] intel: rework how we add PCI IDs

2018-09-05 Thread Chris Wilson
Quoting Lucas De Marchi (2018-09-05 19:31:55) > Adding PCI IDs to different projects is a boring manual task that > motivated me to create this series. The idea is to centralize the IDs in > the kernel header and let other projects copy it. > > Initially my plan was to convert all gens, back to ge

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-09-05 Thread Manasi Navare
Gaurav, Please find my review comments below. Caught them when I tested your patch on DSC sink. On Tue, Jul 31, 2018 at 02:07:11PM -0700, Manasi Navare wrote: > From: Gaurav K Singh > > This patches does the following: > > 1. This patch defines all the DSC parameters as per the VESA > DSC spec

[Intel-gfx] [PATCH v5 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp

2018-09-05 Thread Radhakrishna Sripada
Use the newly added "max bpc" connector property to limit pipe bpp. V3: Use drm_connector_state to access the "max bpc" property V4: Initialize the drm property, add suuport to DP(Ville) V5: Use the property in the connector and fix CI failure(Ville) Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Kisho

[Intel-gfx] [PATCH v5 1/2] drm: Add connector property to limit max bpc

2018-09-05 Thread Radhakrishna Sripada
At times 12bpc HDMI cannot be driven due to faulty cables, dongles level shifters etc. To workaround them we may need to drive the output at a lower bpc. Currently the user space does not have a way to limit the bpc. The default bpc to be programmed is decided by the driver and is run against conne

[Intel-gfx] [PATCH v2] drm/i915: reword documentation of possible pci_device_id struct

2018-09-05 Thread Lucas De Marchi
Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16. v2: - remove mention to (non-existent) PCI_DEVICE_ANY and better explain use of __u16 in first 2 fields Cc: Chris Wilson Signed-off-

[Intel-gfx] [PULL] drm-misc-next

2018-09-05 Thread Sean Paul
Hi Dave, Here's the latest from -misc-next. This PR includes last weeks as well, I've added both summaries below for your convenience. This week was quite busy, guess everyone is back to work now! This pull features a nice mix of new hw support and code cleanup, with the headliner being udmabuf.

[Intel-gfx] [PATCH] drm/i915/execlists: Reset CSB pointers on canceling requests (wedging)

2018-09-05 Thread Chris Wilson
The prior assumption was that we did not need to reset the CSB on wedging when cancelling the outstanding requests as it would be cleaned up in the subsequent reset prior to restarting the GPU. However, what was not accounted for was that in performing the reset, we would try to process the outstan

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-09-05 Thread Manasi Navare
One more fix below which was the cause of all the artifacts On Wed, Sep 05, 2018 at 01:04:48PM -0700, Manasi Navare wrote: > Gaurav, > > Please find my review comments below. Caught them when I tested > your patch on DSC sink. > > On Tue, Jul 31, 2018 at 02:07:11PM -0700, Manasi Navare wrote: >

[Intel-gfx] [PATCH] drm/i915/execlists: Reset CSB pointers on canceling requests (wedging)

2018-09-05 Thread Chris Wilson
The prior assumption was that we did not need to reset the CSB on wedging when cancelling the outstanding requests as it would be cleaned up in the subsequent reset prior to restarting the GPU. However, what was not accounted for was that in performing the reset, we would try to process the outstan

[Intel-gfx] [PATCH i-g-t v2] Add support for forcing specific module

2018-09-05 Thread Rodrigo Siqueira
This commit adds a new option for forcing the use of a specific driver indicated via an environment variable. Changes since V1: Petri: - Use an environment variable instead of command line - Refactor the loop in __search_and_open to accept forced module - Don't try to load kernel modules Sign

[Intel-gfx] ✗ Fi.CI.BAT: failure for firmware/dmc/icl: Add MODULE_FIRMWARE()

2018-09-05 Thread Patchwork
== Series Details == Series: firmware/dmc/icl: Add MODULE_FIRMWARE() URL : https://patchwork.freedesktop.org/series/49229/ State : failure == Summary == Applying: firmware/dmc/icl: Add MODULE_FIRMWARE() Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/intel_csr.c Fal

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm: Add connector property to limit max bpc

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm: Add connector property to limit max bpc URL : https://patchwork.freedesktop.org/series/49230/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2c48291891eb drm: Add connector property to limit max bpc 44f00038f508 dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm: Add connector property to limit max bpc

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm: Add connector property to limit max bpc URL : https://patchwork.freedesktop.org/series/49230/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775 -> Patchwork_10102 = == Summary - SUCCESS == No regressions f

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: make field unsigned (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: make field unsigned (rev2) URL : https://patchwork.freedesktop.org/series/48818/ State : warning == Summary == $ dim checkpatch origin/drm-tip c39485603dc4 drm/i915: make field unsigned 6ee99a76cca9 drm/i915: reword documentatio

Re: [Intel-gfx] [PATCH v2 16/23] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-09-05 Thread Manasi Navare
Gaurav, I needed to make following changes to teh RC parameter values during testing to get this to work: On Tue, Jul 31, 2018 at 02:07:12PM -0700, Manasi Navare wrote: > From: Gaurav K Singh > > This computation of RC params happens in the atomic commit phase > during compute_config() to valid

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: make field unsigned (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: make field unsigned (rev2) URL : https://patchwork.freedesktop.org/series/48818/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775 -> Patchwork_10103 = == Summary - SUCCESS == No regressions found. Ext

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: make field unsigned (rev2)

2018-09-05 Thread Lucas De Marchi
On Wed, Sep 05, 2018 at 09:05:40PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: make field unsigned (rev2) > URL : https://patchwork.freedesktop.org/series/48818/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > c39485

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp

2018-09-05 Thread Daniel Vetter
On Wed, Sep 05, 2018 at 01:12:00PM -0700, Radhakrishna Sripada wrote: > Use the newly added "max bpc" connector property to limit pipe bpp. > > V3: Use drm_connector_state to access the "max bpc" property > V4: Initialize the drm property, add suuport to DP(Ville) > V5: Use the property in the con

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl (rev3)

2018-09-05 Thread Patchwork
== Series Details == Series: drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl (rev3) URL : https://patchwork.freedesktop.org/series/49150/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4772_full -> Patchwork_10097_full = == Summary - WARNING == Minor unk

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Reset CSB pointers on canceling requests (wedging) (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Reset CSB pointers on canceling requests (wedging) (rev2) URL : https://patchwork.freedesktop.org/series/49232/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775 -> Patchwork_10104 = == Summary - SUCCESS == No regression

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] Add support for forcing specific module

2018-09-05 Thread Chris Wilson
Quoting Rodrigo Siqueira (2018-09-05 21:38:27) > This commit adds a new option for forcing the use of a specific driver > indicated via an environment variable. > > Changes since V1: > Petri: > - Use an environment variable instead of command line > - Refactor the loop in __search_and_open to a

Re: [Intel-gfx] [igt-dev] [PATH i-g-t 2/2] tests: add slice power programming test

2018-09-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-05 15:25:44) > +static bool > +kernel_has_per_context_sseu_support(int fd) > +{ > + struct drm_i915_gem_context_param_sseu sseu = { }; > + struct drm_i915_gem_context_param arg = > + { .param = I915_CONTEXT_PARAM_SSEU, > + .v

Re: [Intel-gfx] [PATCH] firmware/dmc/icl: Add MODULE_FIRMWARE()

2018-09-05 Thread Rodrigo Vivi
On Wed, Sep 05, 2018 at 12:50:35PM -0700, Anusha Srivatsa wrote: > Add missing MODULE_FIRMWARE while loading DMC on Icelake. > > Rebased on top of https://patchwork.freedesktop.org/patch/246153/ What about a Fixes after the patch gets pushed? so with message removed or replaced by a proper fixes

Re: [Intel-gfx] [PATCH libdrm v3 0/5] intel: rework how we add PCI IDs

2018-09-05 Thread Rodrigo Vivi
On Wed, Sep 05, 2018 at 08:56:44PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-09-05 19:31:55) > > Adding PCI IDs to different projects is a boring manual task that > > motivated me to create this series. The idea is to centralize the IDs in > > the kernel header and let other projec

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/icl: Update result lines in correspondence with result blocks

2018-09-05 Thread Rodrigo Vivi
The subject here is marked as icl, but the code seems to all platforms what am I missing? But also I didn't check spec yet on this particular case On Wed, Sep 05, 2018 at 02:32:39PM +0530, Karthik B S wrote: > As the result blocks for WM1-WM7 are always kept higher than the > level below the pre

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/icl: Avoid Gen10 watermark workarounds in Gen11

2018-09-05 Thread Rodrigo Vivi
On Wed, Sep 05, 2018 at 02:32:38PM +0530, Karthik B S wrote: > Display Workarounds #1125 and #1126 are intended for Gen10 and > below platforms. These workarounds can be avoided in Gen11. > > The result blocks for WM1-WM7 should be atleast as high as the level below > the current level(Part of Dis

[Intel-gfx] [PATCH i-g-t 4/5] lib/igt_fb: Check for stride before creating cairo surface

2018-09-05 Thread Deepak Rawat
Cairo surface creation will fail if stride of provided buffer is not same as expected by cairo. This fails for vmwgfx odd length framebuffer as in vmwgfx stride is always width * bpp. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_fb.c

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms: Don't check crtc state for vmwgfx legacy set_crtc

2018-09-05 Thread Deepak Rawat
For a Xorg bug vmwgfx has a kernel workaround which reset the value of mode::type. This will cause crtc state not to match what is expected. Signed-off-by: Deepak Rawat --- tests/kms_atomic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/kms_atomic.c b/tests/kms

[Intel-gfx] [PATCH i-g-t 0/5] vmwgfx as a new driver for igt-gpu-tools

2018-09-05 Thread Deepak Rawat
Hi, With this patch series adding vmwgfx as new driver for igt-gpu-tools and some changes to make kms_atomic test case work for vmwgfx. For now the main motivation for this was page-flip with damage test case to test the new plane property FB_DAMAGE_CLIPS. However, will be adding more vmwgfx speci

[Intel-gfx] [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device

2018-09-05 Thread Deepak Rawat
Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. Signed-off-by: Deepak Rawat --- lib/drmtest.c | 9 - lib/drmtest.h | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index bfa2e0f0..563d5b8b 100644 --- a/lib/drmtest.c

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers

2018-09-05 Thread Deepak Rawat
vmwgfx does not support GEM interface so calling gem_close on vmwgfx results in error. Call dumb destroy IOCTL in case have dumb buffer. Signed-off-by: Deepak Rawat --- lib/igt_fb.c | 5 - lib/igt_kms.c | 15 +++ lib/igt_kms.h | 1 + 3 files changed, 20 insertions(+), 1 deleti

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property

2018-09-05 Thread Deepak Rawat
Some simple test cases to use FB_DAMAGE_CLIPS plane property. Signed-off-by: Deepak Rawat Cc: dri-de...@lists.freedesktop.org Cc: Daniel Vetter Cc: Lukasz Spintzyk Cc: Rob Clark Cc: Daniel Stone Cc: Noralf Trønnes Cc: Dave Airlie --- lib/igt_kms.c | 1 + lib/igt_kms.h |

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/intel_csr.c Added ICL Stepping info. (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/i915/intel_csr.c Added ICL Stepping info. (rev2) URL : https://patchwork.freedesktop.org/series/49058/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4773_full -> Patchwork_10098_full = == Summary - SUCCESS == No regressions found. ==

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm: Add drm/drm_util.h header file (rev2) URL : https://patchwork.freedesktop.org/series/49184/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4773_full -> Patchwork_10099_full = == Summary - SUCCESS == No regressio

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/amdgpu: Remove default best_encoder hook from DC (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/amdgpu: Remove default best_encoder hook from DC (rev2) URL : https://patchwork.freedesktop.org/series/49194/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4773_full -> Patchwork_10100_full = == Summary - FAILURE == Serious unknown change

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Decode memdev info and bandwidth and implemnt latency WA (rev4)

2018-09-05 Thread Rodrigo Vivi
On Fri, Aug 31, 2018 at 11:22:01AM -, Patchwork wrote: > == Series Details == > > Series: Decode memdev info and bandwidth and implemnt latency WA (rev4) > URL : https://patchwork.freedesktop.org/series/46481/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 441057

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/2] drm: Add connector property to limit max bpc

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm: Add connector property to limit max bpc URL : https://patchwork.freedesktop.org/series/49230/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775_full -> Patchwork_10102_full = == Summary - SUCCESS == No reg

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: make field unsigned (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: make field unsigned (rev2) URL : https://patchwork.freedesktop.org/series/48818/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775_full -> Patchwork_10103_full = == Summary - SUCCESS == No regressions fou

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Reset CSB pointers on canceling requests (wedging) (rev2)

2018-09-05 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Reset CSB pointers on canceling requests (wedging) (rev2) URL : https://patchwork.freedesktop.org/series/49232/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4775_full -> Patchwork_10104_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-09-05 Thread Jani Nikula
On Wed, 05 Sep 2018, Rodrigo Vivi wrote: > On Wed, Sep 05, 2018 at 12:07:43PM +0300, Joonas Lahtinen wrote: >> Was not the decision that we only gate the MODULE_FIRMWARE line until >> the firmware is in linux-firmware.git? >> >> So it should be no harm to support loading firmwares that are availa

[Intel-gfx] [PATCH] drm/i915: add LG eDP panel to quirk database

2018-09-05 Thread Lee, Shawn C
The N value was computed by kernel driver that based on synchronous clock mode. But only specific N value (0x8000) would be acceptable for LG LP140WF6-SPM1 eDP panel which is running at asynchronous clock mode. With the other N value, Tcon will enter BITS mode and display black screen. Add this pan

<    1   2