Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-15 Thread Tvrtko Ursulin
On 14/08/2018 19:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 19:49:46) On 13/08/2018 10:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13 10:11:44) On 13/08/2018 09:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13 09:02:18) From: Lionel Landwerlin Abstr

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Mika Kuoppala
Chris Wilson writes: > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear > it on the per-engine exit path as we know that either we skipped the > reset and so need the cancellation, or the reset was su

Re: [Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-15 Thread Petri Latvala
On 08/14/2018 08:29 PM, Lucas De Marchi wrote: On Fri, Aug 03, 2018 at 12:07:43PM +0300, Petri Latvala wrote: On Thu, Aug 02, 2018 at 03:09:37PM -0700, Lucas De Marchi wrote: I was grepping for shard as the tests run on CI, but the only occurrence was this one which seems to be a typo since i

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-15 09:52:18) > Chris Wilson writes: > > > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear > > it on the per-engine exit path as we know that either we skipped the > >

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-15 09:52:18) >> Chris Wilson writes: >> >> > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted >> > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear >> > it on the per-engine exit path as we know

Re: [Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-15 Thread Daniel Vetter
On Tue, Aug 14, 2018 at 10:29:02AM -0700, Lucas De Marchi wrote: > On Fri, Aug 03, 2018 at 12:07:43PM +0300, Petri Latvala wrote: > > On Thu, Aug 02, 2018 at 03:09:37PM -0700, Lucas De Marchi wrote: > > > I was grepping for shard as the tests run on CI, but the only occurrence > > > was this one wh

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-08-15 Thread Tvrtko Ursulin
On 14/08/2018 19:53, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 19:44:09) On 14/08/2018 15:59, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 15:40:58) From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case. To do so

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-15 10:08:09) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-08-15 09:52:18) > >> Chris Wilson writes: > >> > >> > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > >> > in RING_MI_MODE resulting in the engine hanging. Uncondition

[Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module

2018-08-15 Thread Chris Wilson
Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload") Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c index 65489bcdb..a4f9f783e 100644 --- a/tests/pm_rpm.c +++ b/tests/pm_rpm.c

[Intel-gfx] [PATCH] drm/i915: Skip repeated calls to i915_gem_set_wedged()

2018-08-15 Thread Chris Wilson
If we already wedged, i915_gem_set_wedged() becomes a complicated no-op. v2: Make sure the double set-wedged is synchronous, a parallel call should not return before the driver is indeed wedged. References: https://bugs.freedesktop.org/show_bug.cgi?id=107343 Signed-off-by: Chris Wilson Cc: Mika

[Intel-gfx] [PATCH] drm/i915: Skip repeated calls to i915_gem_set_wedged()

2018-08-15 Thread Chris Wilson
If we already wedged, i915_gem_set_wedged() becomes a complicated no-op. v2: Make sure the double set-wedged is synchronous, a parallel call should not return before the driver is indeed wedged. v3: Use a real mutex (and fingers crossed that lockdep is ok!) References: https://bugs.freedesktop.or

Re: [Intel-gfx] [PATCH] drm/i915: Skip repeated calls to i915_gem_set_wedged()

2018-08-15 Thread Chris Wilson
Quoting Chris Wilson (2018-08-15 10:25:37) > If we already wedged, i915_gem_set_wedged() becomes a complicated no-op. > > v2: Make sure the double set-wedged is synchronous, a parallel call > should not return before the driver is indeed wedged. > > References: https://bugs.freedesktop.org/show_b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev6)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev6) URL : https://patchwork.freedesktop.org/series/47067/ State : warning == Summary == $ dim checkpatch origin/drm-tip d5ec539e7d20 drm/i915: Skip repeated calls to i915_gem_set_wedged() -:52: WARNING:MEMOR

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Chris Wilson
Quoting Antonio Argenziano (2018-08-15 00:50:43) > > > On 10/08/18 04:01, Chris Wilson wrote: > > This exercises a special case that may be of interest, waiting for a > > context that may be preempted in order to reduce the wait. > > > > Signed-off-by: Chris Wilson > > --- > > + cyc

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev6)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev6) URL : https://patchwork.freedesktop.org/series/47067/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4670 -> Patchwork_9947 = == Summary - FAILURE == Serious unknown changes coming

[Intel-gfx] [PATCH] drm/i915: Add plane alpha blending support, v2.

2018-08-15 Thread Maarten Lankhorst
Add plane alpha blending support with the different blend modes. This has been tested on a icl to show the correct results, on earlier platforms small rounding errors cause issues. But this already happens case with fully transparant or fully opaque RGB fb's. The recommended HW workaround is t

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-15 Thread Lionel Landwerlin
On 15/08/18 09:49, Tvrtko Ursulin wrote: On 14/08/2018 19:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 19:49:46) On 13/08/2018 10:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13 10:11:44) On 13/08/2018 09:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-15 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-08-15 11:50:55) > On 15/08/18 09:49, Tvrtko Ursulin wrote: > > > > On 14/08/2018 19:57, Chris Wilson wrote: > >> Quoting Tvrtko Ursulin (2018-08-14 19:49:46) > >>> > >>> On 13/08/2018 10:16, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-08-13 10:11:44) > >>

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module

2018-08-15 Thread Imre Deak
On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote: > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after > module reload") > Signed-off-by: Chris Wilson > --- > tests/pm_rpm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module

2018-08-15 Thread Chris Wilson
Quoting Imre Deak (2018-08-15 12:01:31) > On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote: > > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after > > module reload") > > Signed-off-by: Chris Wilson > > --- > > tests/pm_rpm.c | 2 ++ > > 1 file changed, 2 inserti

[Intel-gfx] [PATCH] RFT: Do we detect WA_TAIL?

2018-08-15 Thread Chris Wilson
--- drivers/gpu/drm/i915/intel_lrc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 3f90c74038ef..fff2fbb6bac5 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c

[Intel-gfx] [PATCH i-g-t] igt/gem_ctx_switch: Show the combined ctx-switch latency

2018-08-15 Thread Chris Wilson
Since we submit from several processes to the same engine for the forked tests, the total number of context switches is the sum of each process and needs to be combined together to compute the individual cs latency. Signed-off-by: Chris Wilson --- tests/gem_ctx_switch.c | 27

Re: [Intel-gfx] [CI 2/2] drm/i915/perf: reuse intel_lrc ctx regs macro

2018-08-15 Thread Lionel Landwerlin
On 15/08/18 11:56, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-08-15 11:50:55) On 15/08/18 09:49, Tvrtko Ursulin wrote: On 14/08/2018 19:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 19:49:46) On 13/08/2018 10:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-13 10

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_switch: Show the combined ctx-switch latency

2018-08-15 Thread Chris Wilson
Quoting Chris Wilson (2018-08-15 12:15:53) > + if (ncpus > 1) { > + unsigned long total; Imagine the hidden = 0 here. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/int

[Intel-gfx] [PATCH] drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Imre Deak
The case where the firmware isn't specified for a platform (although runtime PM works only with DMC on this platform) is the same case where the firmware is specified but can't be loaded for some reason. Hence we need to get a display init power domain ref in the first case too to keep the refcount

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-08-15 Thread Imre Deak
On Mon, Aug 13, 2018 at 11:45:32PM -0500, Anusha Srivatsa wrote: > Add Support to load DMC on Icelake. > > While at it, also add support to load the firmware > during system resume. > > v2: load firmware during system resume.(Imre) > > v3: enable has_csr for icelake.(Jyoti) > > Cc: Jyoti Yadav

Re: [Intel-gfx] [PATCH] drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Chris Wilson
Quoting Imre Deak (2018-08-15 12:30:16) > The case where the firmware isn't specified for a platform (although > runtime PM works only with DMC on this platform) is the same case where > the firmware is specified but can't be loaded for some reason. Hence we > need to get a display init power domai

Re: [Intel-gfx] [PATCH] drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Chris Wilson
Quoting Chris Wilson (2018-08-15 12:35:29) > Quoting Imre Deak (2018-08-15 12:30:16) > > The case where the firmware isn't specified for a platform (although > > runtime PM works only with DMC on this platform) is the same case where > > the firmware is specified but can't be loaded for some reason

Re: [Intel-gfx] [PATCH] drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Imre Deak
On Wed, Aug 15, 2018 at 12:38:00PM +0100, Chris Wilson wrote: > Quoting Chris Wilson (2018-08-15 12:35:29) > > Quoting Imre Deak (2018-08-15 12:30:16) > > > The case where the firmware isn't specified for a platform (although > > > runtime PM works only with DMC on this platform) is the same case w

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-08-15 Thread Tvrtko Ursulin
On 14/08/2018 16:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-08-14 15:40:58) +static int +i915_gem_context_reconfigure_sseu(struct i915_gem_context *ctx, + struct intel_engine_cs *engine, + struct intel_sseu sseu) +{ +

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-08-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-08-15 12:51:28) > > On 14/08/2018 16:22, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-08-14 15:40:58) > > Looks like we should be able to hook this up to a selftest to confirm > > the modification does land in the target context image, and a SRM to > > confirm

Re: [Intel-gfx] [PATCH 5/8] drm/i915/perf: lock powergating configuration to default when active

2018-08-15 Thread Tvrtko Ursulin
On 14/08/2018 15:59, Lionel Landwerlin wrote: Hey Tvrtko, Thanks for taking over this series. I've been talking to developers using the i915/perf interface and from their point of view, they expect the system to be in a stable configuration when doing measurements. One issue with this patc

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add plane alpha blending support, v2.

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Add plane alpha blending support, v2. URL : https://patchwork.freedesktop.org/series/48243/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/intel_displa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFT: Do we detect WA_TAIL?

2018-08-15 Thread Patchwork
== Series Details == Series: RFT: Do we detect WA_TAIL? URL : https://patchwork.freedesktop.org/series/48247/ State : warning == Summary == $ dim checkpatch origin/drm-tip ea2011cc92cd RFT: Do we detect WA_TAIL? -:32: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 0 w

[Intel-gfx] ✓ Fi.CI.BAT: success for RFT: Do we detect WA_TAIL?

2018-08-15 Thread Patchwork
== Series Details == Series: RFT: Do we detect WA_TAIL? URL : https://patchwork.freedesktop.org/series/48247/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9949 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesk

Re: [Intel-gfx] [PATCH] RFT: Do we detect WA_TAIL?

2018-08-15 Thread Chris Wilson
Quoting Chris Wilson (2018-08-15 12:13:51) The answer is no. So either our wait-for-ack is the ultimate panacea, or we just don't have the right pattern to trigger the bug. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.f

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PM refcounting w/o DMC firmware URL : https://patchwork.freedesktop.org/series/48252/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1e467be0103c drm/i915: Fix PM refcounting w/o DMC firmware -:44: CHECK:COMPARISON_TO_NULL: Comparison t

Re: [Intel-gfx] [PATCH] RFT: Do we detect WA_TAIL?

2018-08-15 Thread Chris Wilson
Quoting Chris Wilson (2018-08-15 13:23:12) > Quoting Chris Wilson (2018-08-15 12:13:51) > > The answer is no. So either our wait-for-ack is the ultimate panacea, or > we just don't have the right pattern to trigger the bug. Fwiw, the small batch sizes for gem_concurrent_blit were good at hitting

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_switch: Show the combined ctx-switch latency

2018-08-15 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Chris Wilson (2018-08-15 12:15:53) >> + if (ncpus > 1) { >> + unsigned long total; > > Imagine the hidden = 0 here. I did. With imagination realized, Perhaps on some rainy day someone will move elapsed into lib. Reviewed-by: Mika Kuoppala -M

[Intel-gfx] [PATCH] drm/i915/selftests: Basic stress test for rapid context switching

2018-08-15 Thread Chris Wilson
We need to exercise the HW and submission paths for switching contexts rapidly to check that features such as execlists' wa_tail are adequate. Plus it's an interesting baseline latency metric. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/selftests/i915_gem_context.c | 185 ++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PM refcounting w/o DMC firmware URL : https://patchwork.freedesktop.org/series/48252/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9950 = == Summary - SUCCESS == No regressions found. External URL: https:/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Basic stress test for rapid context switching

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Basic stress test for rapid context switching URL : https://patchwork.freedesktop.org/series/48255/ State : warning == Summary == $ dim checkpatch origin/drm-tip a5421de087ad drm/i915/selftests: Basic stress test for rapid context switching -:12

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/selftests: Basic stress test for rapid context switching

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Basic stress test for rapid context switching URL : https://patchwork.freedesktop.org/series/48255/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/selftests: Basic stress test for rapid context switching +./include/li

[Intel-gfx] [PATCH] drm/i915: Skip repeated calls to i915_gem_set_wedged()

2018-08-15 Thread Chris Wilson
If we already wedged, i915_gem_set_wedged() becomes a complicated no-op. v2: Make sure the double set-wedged is synchronous, a parallel call should not return before the driver is indeed wedged. v3: Use a real mutex (and fingers crossed that lockdep is ok!) v4: Fix incorrect conversion to return f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Basic stress test for rapid context switching

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Basic stress test for rapid context switching URL : https://patchwork.freedesktop.org/series/48255/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9951 = == Summary - SUCCESS == No regressions found. Ex

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7) URL : https://patchwork.freedesktop.org/series/47067/ State : warning == Summary == $ dim checkpatch origin/drm-tip a2eac6ecd61d drm/i915: Skip repeated calls to i915_gem_set_wedged() -:53: WARNING:MEMOR

[Intel-gfx] [PATCH v2] drm/i915: Fix PM refcounting w/o DMC firmware

2018-08-15 Thread Imre Deak
The case where the firmware isn't specified for a platform (although runtime PM works only with DMC on this platform) is the same case where the firmware is specified but can't be loaded for some reason. Hence we need to get a display init power domain ref in the first case too to keep the refcount

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7) URL : https://patchwork.freedesktop.org/series/47067/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9952 = == Summary - SUCCESS == No regressions found. Extern

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix PM refcounting w/o DMC firmware (rev2)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PM refcounting w/o DMC firmware (rev2) URL : https://patchwork.freedesktop.org/series/48252/ State : warning == Summary == $ dim checkpatch origin/drm-tip a4a5d48f719b drm/i915: Fix PM refcounting w/o DMC firmware -:48: CHECK:COMPARISON_TO_NULL: Compa

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Chris Wilson
In the sequence <0>[ 531.960431] drv_self-48067 527402570us : intel_gpu_reset: engine_mask=1, ret=0, retry=0 <0>[ 531.960431] drv_self-48067 527402571us : execlists_reset: rcs0 request global=115de, current=71133 <0>[ 531.960431] drv_self-48067d..1 527402571us : execlists

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Reset queue_priority on cancellation

2018-08-15 Thread Chris Wilson
If we have an available execlists port, the queue_priority should be INT_MIN to allow immediate direct submission. As we clear the ports in execlists_cancel_port_requests(), we should then reset queue_priority to show the available space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/inte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PM refcounting w/o DMC firmware (rev2)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PM refcounting w/o DMC firmware (rev2) URL : https://patchwork.freedesktop.org/series/48252/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9953 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PATCH] drm/i915/execlists: Include reset depth in traces

2018-08-15 Thread Chris Wilson
Show the reset depth (the tasklet disable count) in the GEM_TRACE to indicate when we might not expect tasklets to be flushed. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lrc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48262/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9954 = == Summary - SUCCESS ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48262/ State : warning == Summary == $ dim checkpatch origin/drm-tip e625d55cbe74 drm/i915/execlists: Assert the queue is no

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PM refcounting w/o DMC firmware (rev2)

2018-08-15 Thread Imre Deak
On Wed, Aug 15, 2018 at 01:46:01PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix PM refcounting w/o DMC firmware (rev2) > URL : https://patchwork.freedesktop.org/series/48252/ > State : success Pushed to -dinq, thanks for the review. > > == Summary == > > = CI Bug

[Intel-gfx] [PATCH 2/4] drm/i915/execlists: Reset queue_priority on cancellation

2018-08-15 Thread Chris Wilson
If we have an available execlists port, the queue_priority should be INT_MIN to allow immediate direct submission. As we clear the ports in execlists_cancel_port_requests(), we should then reset queue_priority to show the available space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH 3/4] drm/i915/execlists: Include reset depth in traces

2018-08-15 Thread Chris Wilson
Show the reset depth (the tasklet disable count) in the GEM_TRACE to indicate when we might not expect tasklets to be flushed. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_submission.c | 3 ++- drivers/gpu/drm/i915/intel_lrc.c| 6 -- 2 files changed, 6 insertion

[Intel-gfx] [PATCH 1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Chris Wilson
In the sequence <0>[ 531.960431] drv_self-48067 527402570us : intel_gpu_reset: engine_mask=1, ret=0, retry=0 <0>[ 531.960431] drv_self-48067 527402571us : execlists_reset: rcs0 request global=115de, current=71133 <0>[ 531.960431] drv_self-48067d..1 527402571us : execlists

[Intel-gfx] [PATCH 4/4] drm/i915/execlists: Use direct submission to restart HW after reset

2018-08-15 Thread Chris Wilson
We can bypass ksoftirqd for restarting our submission queue after a GPU reset and so avoid any inscrutable delays. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_submission.c | 24 + drivers/gpu/drm/i915/intel_lrc.c| 2 +- 2 files changed, 25 inse

[Intel-gfx] ✓ Fi.CI.IGT: success for RFT: Do we detect WA_TAIL?

2018-08-15 Thread Patchwork
== Series Details == Series: RFT: Do we detect WA_TAIL? URL : https://patchwork.freedesktop.org/series/48247/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9949_full = == Summary - SUCCESS == No regressions found. == Known issues == Here ar

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Include reset depth in traces

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Include reset depth in traces URL : https://patchwork.freedesktop.org/series/48263/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9955 = == Summary - SUCCESS == No regressions found. External URL: htt

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Basic stress test for rapid context switching

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Basic stress test for rapid context switching URL : https://patchwork.freedesktop.org/series/48255/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9951_full = == Summary - SUCCESS == No regressions fo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48269/ State : warning == Summary == $ dim checkpatch origin/drm-tip 472fc90cb853 drm/i915/execlists: Assert the queue is no

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48269/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4672 -> Patchwork_9956 = == Summary - SUCCESS ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Skip repeated calls to i915_gem_set_wedged() (rev7) URL : https://patchwork.freedesktop.org/series/47067/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9952_full = == Summary - FAILURE == Serious unknown chang

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix PM refcounting w/o DMC firmware (rev2)

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PM refcounting w/o DMC firmware (rev2) URL : https://patchwork.freedesktop.org/series/48252/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9953_full = == Summary - WARNING == Minor unknown changes coming w

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48262/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9954_full = == Summary - FAI

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Antonio Argenziano
On 15/08/18 03:26, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 00:50:43) On 10/08/18 04:01, Chris Wilson wrote: This exercises a special case that may be of interest, waiting for a context that may be preempted in order to reduce the wait. Signed-off-by: Chris Wilson --- +

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Chris Wilson
Quoting Antonio Argenziano (2018-08-15 18:20:10) > > > On 15/08/18 03:26, Chris Wilson wrote: > > Quoting Antonio Argenziano (2018-08-15 00:50:43) > >> > >> > >> On 10/08/18 04:01, Chris Wilson wrote: > >>> This exercises a special case that may be of interest, waiting for a > >>> context that ma

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Include reset depth in traces

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Include reset depth in traces URL : https://patchwork.freedesktop.org/series/48263/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9955_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake.

2018-08-15 Thread Srivatsa, Anusha
>-Original Message- >From: Deak, Imre >Sent: Wednesday, August 15, 2018 4:35 AM >To: Srivatsa, Anusha >Cc: intel-gfx@lists.freedesktop.org; Yadav, Jyoti R ; >Vivi, Rodrigo ; Zanoni, Paulo R > >Subject: Re: [PATCH 1/1] firmware/dmc/icl: load v1.07 on icelake. > >On Mon, Aug 13, 2018 at 11

[Intel-gfx] [PATCH] drm/i915: Remove useless error return from intel_init_mocs_engine()

2018-08-15 Thread Chris Wilson
As the only error is for a programming error in constructing the static tables describing the register values, replace the error code propagation with an assert. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lrc.c | 6 +- drivers/gpu/drm/i915/intel_mocs.c | 11 +++ dri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove useless error return from intel_init_mocs_engine()

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove useless error return from intel_init_mocs_engine() URL : https://patchwork.freedesktop.org/series/48276/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673 -> Patchwork_9957 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/execlists: Assert the queue is non-empty on unsubmitting URL : https://patchwork.freedesktop.org/series/48269/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4672_full -> Patchwork_9956_full = == Summary - SUC

Re: [Intel-gfx] [PATCHv3] lib/ratelimit: Lockless ratelimiting

2018-08-15 Thread Petr Mladek
On Tue 2018-07-03 23:56:28, Dmitry Safonov wrote: > Currently ratelimit_state is protected with spin_lock. If the .lock is > taken at the moment of ___ratelimit() call, the message is suppressed to > make ratelimiting robust. > > That results in the following issue issue: > CPU0

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Only skip connector output for disable_display

2018-08-15 Thread Imre Deak
On Sun, Aug 12, 2018 at 11:36:32PM +0100, Chris Wilson wrote: > We want to add no connectors, encoders or crtcs if the display is > disabled, but we still need to hook up any existing HW so that we can > power it down. > > Signed-off-by: Chris Wilson Yes, otherwise the dependent power domains ar

[Intel-gfx] [CI] drm/i915: Only skip connector output for disable_display

2018-08-15 Thread Chris Wilson
We want to add no connectors, encoders or crtcs if the display is disabled, but we still need to hook up any existing HW so that we can power it down. Signed-off-by: Chris Wilson Reviewed-by: Imre Deak --- I think it's better to trickle this one in by itself rather than send the series of 3 patc

Re: [Intel-gfx] [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-15 Thread Imre Deak
On Wed, Aug 08, 2018 at 03:16:11PM -0700, Paulo Zanoni wrote: > Use the same coding pattern as we use in the other functions of the > same file: just call lookup_power_well() directly in the only caller. > > Cc: Imre Deak > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_runtime_

Re: [Intel-gfx] [PATCH 01/20] drm: Let userspace check if driver supports modeset

2018-08-15 Thread Souza, Jose
Ping series review On Wed, 2018-08-08 at 17:15 -0700, José Roberto de Souza wrote: > GPU accelerators usually don't have display block or the display > driver part can be disabled when building driver(for servers it saves > some resources) so it is important let userspace check this > capability t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only skip connector output for disable_display

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Only skip connector output for disable_display URL : https://patchwork.freedesktop.org/series/48283/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673 -> Patchwork_9958 = == Summary - SUCCESS == No regressions found. External UR

Re: [Intel-gfx] [PULL] gvt-next-fixes

2018-08-15 Thread Rodrigo Vivi
On Tue, Aug 14, 2018 at 03:31:40PM +0800, Zhenyu Wang wrote: > > Hi, > > This is initial gvt fixes for 4.19 with some accumulated fixes, > pls check details below. pulled, thanks. > > Thanks > -- > The following changes since commit 3237c0dbe21f8d2ca2feaa3891aff3619873cd30: > > drm/i915/kvm

[Intel-gfx] [PATCH i-g-t 2/2] igt/pm_rpm: Avoid at_exit_drm_fd

2018-08-15 Thread Chris Wilson
Keep the drm_fd owned by pm_rpm as we need to relinquish all ownership of the device in order to unload the module. Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c index c0212ed70..f0781617c 10

[Intel-gfx] [PATCH i-g-t 1/2] igt/pm_rpm: Close local fd before trying to unload module

2018-08-15 Thread Chris Wilson
Make sure everything we open in setup_environment() is paired to teardown_environment(). Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload") Signed-off-by: Chris Wilson --- tests/pm_rpm.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletion

Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-15 Thread Rodrigo Vivi
On Tue, Aug 14, 2018 at 11:26:19AM +0200, Maarten Lankhorst wrote: > Op 13-08-18 om 20:15 schreef Pandiyan, Dhinakaran: > > On Mon, 2018-08-13 at 09:47 -0700, Rodrigo Vivi wrote: > >> On Mon, Aug 13, 2018 at 03:47:20PM +0200, Maarten Lankhorst wrote: > >>> Op 11-08-18 om 02:50 schreef Dhinakaran Pa

Re: [Intel-gfx] [PATCH 1/6] drm: Let userspace check if driver supports modeset

2018-08-15 Thread Rodrigo Vivi
On Tue, Jul 17, 2018 at 09:04:45PM +0100, Chris Wilson wrote: > Quoting Souza, Jose (2018-07-17 18:02:17) > > On Tue, 2018-07-17 at 08:28 +0100, Chris Wilson wrote: > > > Quoting José Roberto de Souza (2018-07-16 23:38:36) > > > > GPU accelerators usually don't have display block or the display > >

Re: [Intel-gfx] [PATCH 1/6] drm: Let userspace check if driver supports modeset

2018-08-15 Thread Souza, Jose
On Wed, 2018-08-15 at 14:15 -0700, Rodrigo Vivi wrote: > On Tue, Jul 17, 2018 at 09:04:45PM +0100, Chris Wilson wrote: > > Quoting Souza, Jose (2018-07-17 18:02:17) > > > On Tue, 2018-07-17 at 08:28 +0100, Chris Wilson wrote: > > > > Quoting José Roberto de Souza (2018-07-16 23:38:36) > > > > > GPU

Re: [Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-15 Thread Lucas De Marchi
On Wed, Aug 15, 2018 at 2:09 AM Daniel Vetter wrote: > > On Tue, Aug 14, 2018 at 10:29:02AM -0700, Lucas De Marchi wrote: > > On Fri, Aug 03, 2018 at 12:07:43PM +0300, Petri Latvala wrote: > > > On Thu, Aug 02, 2018 at 03:09:37PM -0700, Lucas De Marchi wrote: > > > > I was grepping for shard as th

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless error return from intel_init_mocs_engine()

2018-08-15 Thread Rodrigo Vivi
On Wed, Aug 15, 2018 at 07:42:51PM +0100, Chris Wilson wrote: > As the only error is for a programming error in constructing the static > tables describing the register values, replace the error code > propagation with an assert. > > Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi > ---

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless error return from intel_init_mocs_engine()

2018-08-15 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-08-15 23:19:50) > On Wed, Aug 15, 2018 at 07:42:51PM +0100, Chris Wilson wrote: > > As the only error is for a programming error in constructing the static > > tables describing the register values, replace the error code > > propagation with an assert. > > > > Signed-of

Re: [Intel-gfx] [PATCH] [drm][i915] Increase LSPCON timeout

2018-08-15 Thread Rodrigo Vivi
On Mon, Aug 13, 2018 at 07:51:33PM +0200, Fredrik Schön wrote: First of all we need to fix the commit subject: drm/i915: Increase LSPCON timeout (this can be done when merging, no need to resend) > 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to > settle. This causes dr

Re: [Intel-gfx] [PATCH] [drm][i915] Increase LSPCON timeout

2018-08-15 Thread Rodrigo Vivi
On Wed, Aug 15, 2018 at 03:39:40PM -0700, Rodrigo Vivi wrote: > On Mon, Aug 13, 2018 at 07:51:33PM +0200, Fredrik Schön wrote: > > First of all we need to fix the commit subject: > > drm/i915: Increase LSPCON timeout > > (this can be done when merging, no need to resend) > > > 100 ms is not eno

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt/gem_sync: Exercise sync after context switch

2018-08-15 Thread Antonio Argenziano
On 15/08/18 10:24, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 18:20:10) On 15/08/18 03:26, Chris Wilson wrote: Quoting Antonio Argenziano (2018-08-15 00:50:43) On 10/08/18 04:01, Chris Wilson wrote: This exercises a special case that may be of interest, waiting for a con

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove useless error return from intel_init_mocs_engine()

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Remove useless error return from intel_init_mocs_engine() URL : https://patchwork.freedesktop.org/series/48276/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673_full -> Patchwork_9957_full = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Only skip connector output for disable_display

2018-08-15 Thread Patchwork
== Series Details == Series: drm/i915: Only skip connector output for disable_display URL : https://patchwork.freedesktop.org/series/48283/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673_full -> Patchwork_9958_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH 1/2] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-15 Thread Dhinakaran Pandiyan
We print the last attempted entry and last exit timestamps only when IRQ debug is requested. This check was missed when new debug flags were added in 'commit c44301fce614 ("drm/i915: Allow control of PSR at runtime through debugfs, v6") Cc: Maarten Lankhorst Signed-off-by: Dhinakaran Pandiyan Re

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Mask PSR irq bits when re-enabling interrupts.

2018-08-15 Thread Dhinakaran Pandiyan
gen8_de_irq_postinstall() wasn't masking the IRQ bit before passing the debug flag to psr_irq_control(). This check was missed when new debug bits were defined in 'commit c44301fce614 ("drm/i915: Allow control of PSR at runtime through debugfs, v6")'. Instead of ANDing the irq bit in all the calle

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit URL : https://patchwork.freedesktop.org/series/48291/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4676 -> Patchwork_9959 = == Summary - SUCCESS == No reg

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-15 Thread Dhinakaran Pandiyan
On Mon, 2018-08-13 at 18:10 +, Pandiyan, Dhinakaran wrote: > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > wrote: > > > CI runs show PSR2 does not go to IDLE with selective update > > > enabled > > > on > > > all PSR

Re: [Intel-gfx] linux-next: manual merge of the mfd tree with the drm-intel tree

2018-08-15 Thread Stephen Rothwell
Hi all, On Thu, 26 Jul 2018 15:10:06 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the mfd tree got a conflict in: > > drivers/gpu/drm/i915/intel_display.h > > between commit: > > 6075546f57f8 ("drm/i915/icl: store the port type for TC ports") > > from the drm-intel tree

  1   2   >