[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [v7,1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source() URL : https://patchwork.freedesktop.org/series/45436/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9430_full = == Summar

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add power well support

2018-06-26 Thread Paulo Zanoni
Em Ter, 2018-06-26 às 17:22 +0300, Imre Deak escreveu: > Add the definition for ICL power wells and their mapping to power > domains. On ICL there are 3 power well control registers, we'll > select > the correct one based on higher bits of the power well ID. The offset > for the control and status

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc()

2018-06-26 Thread Patchwork
== Series Details == Series: drm/atomic-helper: Use old/new state in drm_atomic_helper_commit_planes_on_crtc() URL : https://patchwork.freedesktop.org/series/45440/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9431_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through

2018-06-26 Thread Gustavo A. R. Silva
Hi Jani, On 06/21/2018 03:03 AM, Jani Nikula wrote: > On Wed, 20 Jun 2018, "Gustavo A. R. Silva" wrote: >> On 06/20/2018 02:06 PM, Rodrigo Vivi wrote: >>> On Wed, Jun 20, 2018 at 08:31:00AM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases

[Intel-gfx] [PATCH v4] drm/i915: Fix assert_plane() warning on bootup with external display

2018-06-26 Thread Azhar Shaikh
On KBL, WHL RVPs, booting up with an external display connected, triggers below warning, when the BiOS brings up the external display too. This warning is not seen during hotplug. [3.615226] [ cut here ] [3.619829] plane 1A assertion failure (expected on, current of

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: mark expected switch fall-through (rev2)

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: mark expected switch fall-through (rev2) URL : https://patchwork.freedesktop.org/series/45088/ State : failure == Summary == Applying: drm/i915: mark expected switch fall-through error: patch failed: drivers/gpu/drm/i915/i915_utils.h:40 error: drivers/gpu

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix assert_plane() warning on bootup with external display (rev4)

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fix assert_plane() warning on bootup with external display (rev4) URL : https://patchwork.freedesktop.org/series/44909/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] driv

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45443/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4382_full -> Patchwork_9432_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_943

Re: [Intel-gfx] [PATCH v7 1/5] drm/i915/psr: Remove intel_crtc_state parameter from disable_source()

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 13:16 -0700, José Roberto de Souza wrote: > It was only used in VLV/CHV so after the removal of the PSR support > for those platforms it is not necessary any more. > > v7: Rebased > Pushed this to -dinq, thanks for your patience. > Reviewed-by: Dhinakaran Pandiyan > Cc: Ro

Re: [Intel-gfx] [PATCH] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Lucas De Marchi
On Tue, Jun 26, 2018 at 1:56 PM Anusha Srivatsa wrote: > > This patch addresses Interrupts from south display engine (SDE). > > ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. > Introduce these registers and their intended values. > > Introduce icp_irq_handler(). > > The icp_irq_post

[Intel-gfx] [PATCH] ALSA: hda - Handle pm failure during hotplug

2018-06-26 Thread Chris Wilson
Obtaining the runtime pm wakeref can fail, especially in a hotplug scenario where i915.ko has been unloaded. If we do not catch the failure, we end up with an unbalanced pm. References: 222bde03881c ("ALSA: hda - Fix mutex deadlock at HDMI/DP hotplug") Signed-off-by: Chris Wilson Cc: Ville Syrjäl

Re: [Intel-gfx] [PATCH] ALSA: hda - Handle pm failure during hotplug

2018-06-26 Thread Takashi Iwai
On Wed, 27 Jun 2018 08:25:32 +0200, Chris Wilson wrote: > > Obtaining the runtime pm wakeref can fail, especially in a hotplug > scenario where i915.ko has been unloaded. If we do not catch the > failure, we end up with an unbalanced pm. > > References: 222bde03881c ("ALSA: hda - Fix mutex deadlo

Re: [Intel-gfx] [PATCH 00/20] ICELAKE DSI DRIVER

2018-06-26 Thread Chauhan, Madhav
> -Original Message- > From: Chauhan, Madhav > Sent: Friday, June 15, 2018 3:51 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Zanoni, Paulo R > ; Shankar, Uma ; Vivi, > Rodrigo ; Chauhan, Madhav > > Subject: [PATCH 00/20] ICELAKE DSI DRIVER > > From ICELAKE platform onward

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v6,1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [v6,1/2] drm/i915/psr: Lockless version of psr_wait_for_idle URL : https://patchwork.freedesktop.org/series/45375/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4376_full -> Patchwork_9419_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH] Revert "net/sch_generic: Shut up noise"

2018-06-26 Thread Daniel Vetter
On Mon, Jun 25, 2018 at 10:34 PM, Chris Wilson wrote: > Quoting Daniel Vetter (2018-06-25 17:07:54) >> On Tue, May 29, 2018 at 09:15:22AM +0200, Daniel Vetter wrote: >> > This reverts commit c5cab0d5fc9aa1cf14c7bc7ea88c80155e46e22f. >> > >> > Jani believes the noise is gone, so let's see whether i

Re: [Intel-gfx] [PATCH] Revert "net/sch_generic: Shut up noise"

2018-06-26 Thread Chris Wilson
Quoting Daniel Vetter (2018-06-26 09:06:48) > On Mon, Jun 25, 2018 at 10:34 PM, Chris Wilson > wrote: > > Quoting Daniel Vetter (2018-06-25 17:07:54) > >> On Tue, May 29, 2018 at 09:15:22AM +0200, Daniel Vetter wrote: > >> > This reverts commit c5cab0d5fc9aa1cf14c7bc7ea88c80155e46e22f. > >> > > >

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Daniel Vetter
On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > This is a lockless version of the exisiting psr_wait_for_idle(). > We want to wait for PSR to idle out inside intel_pipe_update_start. > At the time of a pipe update, we should never race with any psr > enable or disable code, which is a

Re: [Intel-gfx] [PATCH] drm/i915/psr: Kill useless function pointers.

2018-06-26 Thread Daniel Vetter
On Mon, Jun 25, 2018 at 10:25:36PM -0700, Rodrigo Vivi wrote: > At some point we introduced the function pointers > on PSR code to help with VLV/CHV separation logic > because it had a different HW implementation from PSR. > > Since all converged to HSW PSR and we dropped the > VLV/CHV support, le

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/6] lib/igt_kms: Add writeback support in lib/

2018-06-26 Thread Liviu Dudau
Hi Maarten, Thanks for reviewing this! As this patch is quite old, I agree that it needs a refresh in order to catch up with the latest igt. I will take your feedback and come up with an update in the near future. Best regards, Liviu On Mon, Jun 25, 2018 at 02:19:46PM +0200, Maarten Lankhorst wr

Re: [Intel-gfx] [PATCH 08/10] drm/i915/crc: implement get_crc_sources callback

2018-06-26 Thread Daniel Vetter
On Tue, Jun 26, 2018 at 11:52:57AM +0530, Mahesh Kumar wrote: > This patch implements get_crc_sources callback, which returns list of > all the valid crc sources supported by driver in current platform. > > Signed-off-by: Mahesh Kumar > --- > drivers/gpu/drm/i915/intel_display.c | 1 + > drive

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/6] kms_writeback: Add initial writeback tests

2018-06-26 Thread Liviu Dudau
On Mon, Jun 25, 2018 at 02:48:47PM +0200, Maarten Lankhorst wrote: > Op 01-03-18 om 18:38 schreef Liviu Dudau: > > From: Brian Starkey > > > > Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and > > WRITEBACK_FB_ID properties on writeback connectors, ensuring their > > behaviour

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Chris Wilson
Quoting Daniel Vetter (2018-06-26 09:26:57) > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > > This is a lockless version of the exisiting psr_wait_for_idle(). > > We want to wait for PSR to idle out inside intel_pipe_update_start. > > At the time of a pipe update, we should never ra

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace {un/reference} with {put, get} functions

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Replace {un/reference} with {put, get} functions URL : https://patchwork.freedesktop.org/series/44932/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4376 -> Patchwork_9421 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] [PATCH v2 2/2] drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.

2018-06-26 Thread Dhinakaran Pandiyan
Depending whether PSR1 or PSR2 was configured, we print a warning if the corresponding control mmio indicated PSR was erroneously enabled. As Chris pointed out, it makes more sense to check for both the mmio's since we expect neither PSR1 nor PSR2 to be enabled when psr_activate() is called. v2: R

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/31] drm/i915: Defer modeset cleanup to a secondary task

2018-06-26 Thread Chris Wilson
Quoting Patchwork (2018-06-25 15:44:34) > == Possible new issues == > > Here are the unknown changes that may have been introduced in > Patchwork_9411_full: > > === IGT changes === > > Possible regressions > > igt@perf_pmu@enable-race-rcs0: > shard-apl: PAS

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/psr: Fix race in intel_psr_work() (rev2)

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/psr: Fix race in intel_psr_work() (rev2) URL : https://patchwork.freedesktop.org/series/45316/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4377 -> Patchwork_9422 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace {un/reference} with {put, get} functions

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Replace {un/reference} with {put, get} functions URL : https://patchwork.freedesktop.org/series/44932/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4376_full -> Patchwork_9421_full = == Summary - WARNING == Minor unknown changes co

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ddi: Get AUX power domain for DP main link too (rev2)

2018-06-26 Thread Imre Deak
On Fri, Jun 22, 2018 at 04:12:29AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ddi: Get AUX power domain for DP main link too (rev2) > URL : https://patchwork.freedesktop.org/series/45188/ > State : success Pushed to -dinq, thanks for the reviews. > > == Summary == >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-06-26 Thread Tvrtko Ursulin
On 25/06/2018 21:02, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-06-25 18:25:46) From: Tvrtko Ursulin This Kconfig option was added to protect the implementation specific internals from user expectations but so far it was mostly hassle. Remove it so it is possible to debug request submi

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-06-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-06-26 11:46:51) > > On 25/06/2018 21:02, Chris Wilson wrote: > > If we know what is wanted can we define that better in terms of > > dma_fence and leave lowlevel for debugging (or think of how we achieve > > the same with generic bpf? kprobes)? Hmm, I wonder how far we

Re: [Intel-gfx] [PATCH 04/31] drm/i915/execlists: Pull CSB reset under the timeline.lock

2018-06-26 Thread Tvrtko Ursulin
On 25/06/2018 10:48, Chris Wilson wrote: In the following patch, we will process the CSB events under the timeline.lock and not serailiased by the tasklet. This also means that we Typo in serialised. will need to protect access to common variables such as execlists->csb_head with the timelin

Re: [Intel-gfx] [PATCH 04/31] drm/i915/execlists: Pull CSB reset under the timeline.lock

2018-06-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-06-26 11:59:05) > > On 25/06/2018 10:48, Chris Wilson wrote: > > In the following patch, we will process the CSB events under the > > timeline.lock and not serailiased by the tasklet. This also means that we > > Typo in serialised. > > > will need to protect access t

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-06-26 Thread Tvrtko Ursulin
On 26/06/2018 11:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-06-26 11:46:51) On 25/06/2018 21:02, Chris Wilson wrote: If we know what is wanted can we define that better in terms of dma_fence and leave lowlevel for debugging (or think of how we achieve the same with generic bpf? kpro

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/psr: Fix race in intel_psr_work() (rev2)

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/psr: Fix race in intel_psr_work() (rev2) URL : https://patchwork.freedesktop.org/series/45316/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4377_full -> Patchwork_9422_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH 21/24] drm/i915/icl: implement the legacy HPD {dis, }connect flow for HDMI

2018-06-26 Thread Mika Kahola
the patch looks fine to me.   On Mon, 2018-05-21 at 17:25 -0700, Paulo Zanoni wrote: > Just like DP, HDMI needs to implement these flows. The side effect is > that HDMI is now going to rely on the ISR bits, just like DP. > Reviewed-by: Mika Kahola   > Signed-off-by: Paulo Zanoni > [Rodrigo: non-

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-06-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-06-26 12:24:51) > > On 26/06/2018 11:55, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-06-26 11:46:51) > >> > >> On 25/06/2018 21:02, Chris Wilson wrote: > >>> If we know what is wanted can we define that better in terms of > >>> dma_fence and leave lowlevel for

[Intel-gfx] [PATCH v4] drm/i915/execlists: Pull CSB reset under the timeline.lock

2018-06-26 Thread Chris Wilson
In the following patch, we will process the CSB events under the timeline.lock and not serialised by the tasklet. This also means that we will need to protect access to common variables such as execlists->csb_head with the timeline.lock during reset. v2: Move sync_irq to avoid deadlocks between ta

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/31] drm/i915: Defer modeset cleanup to a secondary task (rev2)

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [01/31] drm/i915: Defer modeset cleanup to a secondary task (rev2) URL : https://patchwork.freedesktop.org/series/45325/ State : failure == Summary == Applying: drm/i915: Defer modeset cleanup to a secondary task Using index info to reconstruc

Re: [Intel-gfx] [PATCH v2 1/4] drm: Add P010, P012, P016 format definitions and fourcc

2018-06-26 Thread Maarten Lankhorst
Op 12-06-18 om 13:16 schreef Juha-Pekka Heikkila: > Add P010 definition, semi-planar yuv format where each component > is 16 bits 10 msb containing color value. First come Y plane [10:6] > followed by 2x2 subsampled Cr:Cb plane [10:6:10:6] > > Add P012 definition, semi-planar yuv format where each

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Add P010, P012, P016 plane control definitions

2018-06-26 Thread Maarten Lankhorst
Op 12-06-18 om 13:16 schreef Juha-Pekka Heikkila: > Add needed plane control flag definitions for P010, P012 and > P016 formats. > > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/6] kms_writeback: Add initial writeback tests

2018-06-26 Thread Maarten Lankhorst
Op 26-06-18 om 10:38 schreef Liviu Dudau: > On Mon, Jun 25, 2018 at 02:48:47PM +0200, Maarten Lankhorst wrote: >> Op 01-03-18 om 18:38 schreef Liviu Dudau: >>> From: Brian Starkey >>> >>> Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and >>> WRITEBACK_FB_ID properties on write

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix assert_plane() warning on bootup with external display

2018-06-26 Thread Ville Syrjälä
On Mon, Jun 25, 2018 at 05:33:05PM -0700, Azhar Shaikh wrote: > On KBL, WHL RVPs, booting up with an external display connected, triggers > below warning, when the BiOS brings up the external display too. > This warning is not seen during hotplug. > > [3.615226] [ cut here ]---

Re: [Intel-gfx] [PATCH v2 00/12] drm: Add generic fbdev emulation

2018-06-26 Thread Noralf Trønnes
Den 21.06.2018 19.19, skrev Noralf Trønnes: Den 21.06.2018 09.14, skrev Daniel Vetter: On Wed, Jun 20, 2018 at 05:28:10PM +0200, Noralf Trønnes wrote: Den 20.06.2018 15.52, skrev Noralf Trønnes: Den 20.06.2018 11.34, skrev Daniel Vetter: On Mon, Jun 18, 2018 at 04:17:27PM +0200, Noralf Trøn

Re: [Intel-gfx] [PATCH v2 00/12] drm: Add generic fbdev emulation

2018-06-26 Thread Daniel Vetter
On Tue, Jun 26, 2018 at 3:41 PM, Noralf Trønnes wrote: > > Den 21.06.2018 19.19, skrev Noralf Trønnes: >> >> >> Den 21.06.2018 09.14, skrev Daniel Vetter: >>> >>> On Wed, Jun 20, 2018 at 05:28:10PM +0200, Noralf Trønnes wrote: Den 20.06.2018 15.52, skrev Noralf Trønnes: > > Den 2

[Intel-gfx] [PATCH] drm/i915/icl: Add power well support

2018-06-26 Thread Imre Deak
Add the definition for ICL power wells and their mapping to power domains. On ICL there are 3 power well control registers, we'll select the correct one based on higher bits of the power well ID. The offset for the control and status flags within this register is based on the lower bits of the ID a

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: enable P010, P012, P016 formats for primary and sprite planes

2018-06-26 Thread Maarten Lankhorst
Op 12-06-18 om 13:16 schreef Juha-Pekka Heikkila: > Enabling of P010, P012 and P016 formats. These formats will > extend NV12 for larger bit depths. > > Signed-off-by: Juha-Pekka Heikkila Patch series looks good. Reviewed-by: Maarten Lankhorst I only wish we had IGT support already, I'll poke u

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : warning == Summary == $ dim checkpatch origin/drm-tip 409dfff082a1 drm/i915/icl: Add power well support -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-06-26 Thread Atwood, Matthew S
ill uprev by EOD From: Navare, Manasi D Sent: Monday, June 25, 2018 5:39 PM To: Atwood, Matthew S Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo; ble...@chromium.org; Zanoni, Paulo R Subject: Re: [Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
On 2018-06-15 03:52 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > To pick the correct MST encoder i915 wants to know which crtc is going > to be feeding us. To that end let's pass the crtc to the .best_encoder() > hook. The atomic variant already knows the crtc via the connector state, > but

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9424 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Daniel Vetter
On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > To pick the correct MST encoder i915 wants to know which crtc is going > to be feeding us. To that end let's pass the crtc to the .best_encoder() > hook. The atomic variant already knows the crtc via the conn

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed URL : https://patchwork.freedesktop.org/series/45349/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9425 = == Summary - SUCCESS == No r

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Ville Syrjälä
On Tue, Jun 26, 2018 at 05:23:25PM +0200, Daniel Vetter wrote: > On Fri, Jun 15, 2018 at 10:52:21PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To pick the correct MST encoder i915 wants to know which crtc is going > > to be feeding us. To that end let's pass the crtc to the .best

Re: [Intel-gfx] [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
On 2018-06-26 11:01 AM, Harry Wentland wrote: > On 2018-06-15 03:52 PM, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> To pick the correct MST encoder i915 wants to know which crtc is going >> to be feeding us. To that end let's pass the crtc to the .best_encoder() >> hook. The atomic variant a

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote: > Depending whether PSR1 or PSR2 was configured, we print a warning if the > corresponding control mmio indicated PSR was erroneously enabled. As > Chris pointed out, it makes more sense to check for both the mmio's > since we exp

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Add power well support

2018-06-26 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add power well support URL : https://patchwork.freedesktop.org/series/45409/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9424_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_94

[Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Dmitry Safonov
Currently ratelimit_state is protected with spin_lock. If the .lock is taken at the moment of ___ratelimit() call, the message is suppressed to make ratelimiting robust. That results in the following issue issue: CPU0 CPU1 -- ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : warning == Summary == $ dim checkpatch origin/drm-tip a8dce76165a9 lib/ratelimit: Lockless ratelimiting -:74: ERROR:ASSIGN_IN_IF: do not use assignment in if conditio

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed

2018-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block enabling FBC until flips have been completed URL : https://patchwork.freedesktop.org/series/45349/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9425_full = == Summary - WARNING

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9426 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Andy Shevchenko
On Tue, Jun 26, 2018 at 7:24 PM, Dmitry Safonov wrote: > Currently ratelimit_state is protected with spin_lock. If the .lock is > taken at the moment of ___ratelimit() call, the message is suppressed to > make ratelimiting robust. > > That results in the following issue issue: > CPU0

Re: [Intel-gfx] [PATCH] drm/i915/psr: Kill useless function pointers.

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:27:49AM +0200, Daniel Vetter wrote: > On Mon, Jun 25, 2018 at 10:25:36PM -0700, Rodrigo Vivi wrote: > > At some point we introduced the function pointers > > on PSR code to help with VLV/CHV separation logic > > because it had a different HW implementation from PSR. > >

[Intel-gfx] [RFC][PATCH] Makefile: globally enable VLA warning

2018-06-26 Thread Kees Cook
This is the patch I've got prepared now that fixes for all VLAs have been sent to maintainers (some are still under review/adjustment, but there aren't any unexplored cases left). My intention would be to have this land at the end of the next merge window after all the pending VLA patches have land

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Paulo Zanoni
Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > So far we got an AUX power domain reference only for the duration > > of > > DP > > AUX transfers. However, the following suggests that we also need > > these > > for main link functio

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Dmitry Safonov
Hi Andy, thanks for the review, On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote [..] > > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init) > > {\ > > - .lock = > > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ > > name is now redundant, isn'

[Intel-gfx] [PATCH 0/8] drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Daniel pointed out that there should be a way to do what userspace does and not require any .best_encoder() stuff in the fb-helper. So this series does just that. Well, most of the series is actually just extra polish that happened by accident. But the real thing is in there s

[Intel-gfx] [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Instead of using the .best_encoder() hook to figure out whether a given connector+crtc combo will work, let's instead do what userspace does and just iterate over all the encoders for the connector, and then check each crtc against each encoder's possible_crtcs bitmask. Cc: D

[Intel-gfx] [PATCH 4/8] drm/amdgpu: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: amd-...@lists.freedesktop.o

[Intel-gfx] [PATCH 3/8] drm: Add drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add a convenience macro for iterating connector->encoder_ids[]. Isolates the users from the implementation details. Also use ARRAY_SIZE() when populating the array to avoid spreading knowledge about the array size all over. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/

[Intel-gfx] [PATCH 2/8] drm/i915: Nuke intel_mst_best_encoder()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä With the fb-helper no longer relying on the non-atomic .best_encoder() we can eliminate the hook from the MST encoder. Cc: Dhinakaran Pandiyan Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp_mst.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[Intel-gfx] [PATCH 5/8] drm/msm: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- d

[Intel-gfx] [PATCH 6/8] drm/nouveau: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/nouveau/nouveau_conn

[Intel-gfx] [PATCH 7/8] drm/radeon: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: amd-...@lists.freedesktop.o

[Intel-gfx] [PATCH 8/8] drm/tilcdc: Use drm_for_each_connector_encoder_ids()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_for_each_connector_encoder_ids() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/tilcdc/tilcdc_external.c | 5 +++--

Re: [Intel-gfx] [PATCH 1/8] drm/fb-helper: Eliminate the .best_encoder() usage

2018-06-26 Thread Alex Deucher
On Tue, Jun 26, 2018 at 1:47 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of using the .best_encoder() hook to figure out whether a given > connector+crtc combo will work, let's instead do what userspace does and > just iterate over all the encoders for the connector, and then check

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove delayed FBC activation.

2018-06-26 Thread Ville Syrjälä
On Mon, Jun 25, 2018 at 06:37:58PM +0200, Maarten Lankhorst wrote: > The only time we should start FBC is when we have waited a vblank > after the atomic update. What about front buffer tracking? Is this going to leave FBC permanently disabled unless there are flips/plane updates? I think there a

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Imre Deak
On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote: > Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > > So far we got an AUX power domain reference only for the duration > > > of > > > DP > > > AUX transfers. However, th

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: Makefile: globally enable VLA warning - +drivers/gpu/drm/ati_pcigart.c:184:52:expected unsigned int [un

[Intel-gfx] ✓ Fi.CI.BAT: success for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9427 = == Summary - SUCCESS == No regressions found. External URL: https://patchwo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Patchwork
== Series Details == Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess URL : https://patchwork.freedesktop.org/series/45422/ State : warning == Summary == $ dim checkpatch origin/drm-tip eebb696c2139 drm/fb-helper: Eliminate the .best_encoder() usage b75ca3e84ab2 drm/i91

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Patchwork
== Series Details == Series: lib/ratelimit: Lockless ratelimiting URL : https://patchwork.freedesktop.org/series/45416/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9426_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_94

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Srivatsa, Anusha
From: Zanoni, Paulo R Sent: Monday, June 25, 2018 4:17 PM To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org Cc: Pandiyan, Dhinakaran Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support Em Qua, 2018-06-20 às 14:36 -0700, Anusha Sriv

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Second attempt at fixing the fb-helper .best_encoder() mess

2018-06-26 Thread Patchwork
== Series Details == Series: drm: Second attempt at fixing the fb-helper .best_encoder() mess URL : https://patchwork.freedesktop.org/series/45422/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4381 -> Patchwork_9428 = == Summary - SUCCESS == No regressions found. Ext

Re: [Intel-gfx] [PATCHv2] lib/ratelimit: Lockless ratelimiting

2018-06-26 Thread Andy Shevchenko
On Tue, Jun 26, 2018 at 8:46 PM, Dmitry Safonov wrote: > On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote >> > #define RATELIMIT_STATE_INIT(name, interval_init, burst_init) >> > {\ >> > - .lock = >> > __RAW_SPIN_LOCK_UNLOCKED(name.lock), \ >> >> n

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 10:26 +0200, Daniel Vetter wrote: > On Mon, Jun 25, 2018 at 10:57:23PM -0700, Tarun Vyas wrote: > > > > This is a lockless version of the exisiting psr_wait_for_idle(). > > We want to wait for PSR to idle out inside intel_pipe_update_start. > > At the time of a pipe update, w

Re: [Intel-gfx] [PATCH v3] drm/i915/ddi: Get AUX power domain for DP main link too

2018-06-26 Thread Manasi Navare
On Tue, Jun 26, 2018 at 09:03:48PM +0300, Imre Deak wrote: > On Tue, Jun 26, 2018 at 10:40:26AM -0700, Paulo Zanoni wrote: > > Em Seg, 2018-06-25 às 16:55 -0700, Souza, Jose escreveu: > > > On Thu, 2018-06-21 at 21:44 +0300, Imre Deak wrote: > > > > So far we got an AUX power domain reference only

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.

2018-06-26 Thread Dhinakaran Pandiyan
On Tue, 2018-06-26 at 08:50 -0700, Rodrigo Vivi wrote: > On Tue, Jun 26, 2018 at 02:05:22AM -0700, Dhinakaran Pandiyan wrote: > > > > Depending whether PSR1 or PSR2 was configured, we print a warning > > if the > > corresponding control mmio indicated PSR was erroneously enabled. > > As > > Chris

[Intel-gfx] [PATCH 01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_plane_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic.c| 4 ++-- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- include/drm/drm_plane.h | 14 -- 4 files changed, 16

[Intel-gfx] [PATCH 02/10] drm: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Mostly performed with coccinelle: @@ @@ - (1< --- drivers/gpu/drm/drm_crtc.c | 4 ++-- drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.

[Intel-gfx] [PATCH 05/10] drm/i915: Use drm_plane_mask() & co.

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_{plane,crtc,encoder,connector}_mask() where appropriate. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 14 +++--- drivers/gpu/drm/i915/intel_display.h | 4 ++-- drivers/gpu/drm/i915/intel_dpll_mgr.c | 6 +++--- 3 files changed,

[Intel-gfx] [PATCH 06/10] drm/imx: Use drm_plane_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_plane_mask() where appropriate. Cc: Philipp Zabel Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c index e83af0f

[Intel-gfx] [PATCH 03/10] drm: Add drm_encoder_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_encoder_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic_helper.c | 10 +- include/drm/drm_encoder.h | 16 ++-- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/d

[Intel-gfx] [PATCH 09/10] drm/vc4: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Eric Anholt Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vc4/vc4_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index dcadf793ee

[Intel-gfx] [PATCH 08/10] drm/sun4i: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Maxime Ripard Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- drivers/gpu/drm/sun4i/sun4i_lvds.c | 2 +- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 07/10] drm/rockchip: Use drm_crtc_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_crtc_mask() where appropriate. Cc: Sandy Huang Cc: "Heiko Stübner" Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drive

[Intel-gfx] [PATCH 04/10] drm: Add drm_connector_mask()

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Add drm_connector_mask() which returns the 1< --- drivers/gpu/drm/drm_atomic.c | 6 +++--- include/drm/drm_connector.h | 8 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 684c9d3a1d6c

[Intel-gfx] [PATCH 10/10] drm/vmwgfx: Use drm_plane_mask() & co.

2018-06-26 Thread Ville Syrjala
From: Ville Syrjälä Use drm_{plane,connector}_mask() where appropriate. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwg

[Intel-gfx] ✗ Fi.CI.IGT: failure for Makefile: globally enable VLA warning

2018-06-26 Thread Patchwork
== Series Details == Series: Makefile: globally enable VLA warning URL : https://patchwork.freedesktop.org/series/45421/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4381_full -> Patchwork_9427_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Paulo Zanoni
Em Ter, 2018-06-26 às 11:32 -0700, Srivatsa, Anusha escreveu: > > From: Zanoni, Paulo R > Sent: Monday, June 25, 2018 4:17 PM > To: Srivatsa, Anusha; intel-gfx@lists.freedesktop.org > Cc: Pandiyan, Dhinakaran > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/i

Re: [Intel-gfx] [PATCH 01/10] drm: Add drm_plane_mask()

2018-06-26 Thread Rodrigo Vivi
On Tue, Jun 26, 2018 at 10:47:07PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add drm_plane_mask() which returns the 1< We already have an identical drm_crtc_mask() for crtcs. > > Mostly performed with coccinelle: > @@ > @@ > - (1< + drm_plane_mask( > ...) > - ) > > @@ > @@ > - 1<

  1   2   >