Re: [Intel-gfx] DRM Inquiry

2018-06-13 Thread Jani Nikula
On Wed, 13 Jun 2018, John Sledge wrote: > I like to understand how the DRM_DP_AUX_CHARDEV=y kick off. Try 'git grep DRM_DP_AUX_CHARDEV' in your kernel git repo, and see how it affects conditional compilation. This list isn't kernel development 101. You still didn't say what your end goal is. Fo

Re: [Intel-gfx] Problems in intel_panel_fitter.1

2018-06-13 Thread Jani Nikula
On Tue, 12 Jun 2018, e...@thyrsus.com wrote: > This is automatically generated email about markup problems in a man > page for which you appear to be responsible. If you are not the right > person or list, please tell me so I can correct my database. > > See http://catb.org/~esr/doclifter/bugs.htm

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Only keep gen6 page directories pinned while active

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Only keep gen6 page directories pinned while active URL : https://patchwork.freedesktop.org/series/44649/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9281_full = == Summary - WARNING == Minor unknown cha

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Enable KVMGT for BXT

2018-06-13 Thread Tomi Sarvela
On 06/13/2018 09:30 AM, Chris Wilson wrote: Quoting Zhenyu Wang (2018-06-13 04:44:12) On 2018.06.11 10:09:52 +0100, Chris Wilson wrote: Quoting Patchwork (2018-06-11 10:05:46) == Series Details == Series: drm/i915/gvt: Enable KVMGT for BXT URL : https://patchwork.freedesktop.org/series/4455

[Intel-gfx] [PATCH] drm/i915/psr: Adds psrwake options for all platforms

2018-06-13 Thread vathsala nagaraju
From: Vathsala Nagaraju Adds new psrwake options defined in the below table. PlatformPSR wake options vbt version KBL/CFL/WHL All SKL All PV releases (Check for 203+ might help but cannot be foolproof) BXT Uses old interpretation. CNL/ICL+All GLK

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Jani Nikula
On Tue, 12 Jun 2018, Rodrigo Vivi wrote: > Do we really want BIT everywhere?! I think I'd go for everywhere except part of a register field value: #define SINGLE_BIT_OKAY BIT(25) #define FIELD_SHIFT 20 #define FIELD_MASK (0xf << 20) #define FIELD_FOO_PLEASE_NO

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-13 Thread Arkadiusz Hiler
On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula wrote: > >> > >> On Thu, 31 May 2018, Lucas De Marchi wrote: > >> > On Thu, May 31, 2018 at 02:56:21PM +0300, Jani Nikula wrote: > >> >> Virtu

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Adds psrwake options for all platforms (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/psr: Adds psrwake options for all platforms (rev2) URL : https://patchwork.freedesktop.org/series/44601/ State : warning == Summary == $ dim checkpatch origin/drm-tip e6bea8c90022 drm/i915/psr: Adds psrwake options for all platforms -:36: CHECK:PARENTHESIS

Re: [Intel-gfx] DRM Inquiry

2018-06-13 Thread John Sledge
Hi Jani, The end goal was already achieve by the advice you gave the DRM_DP_AUX_CHARDEV.I just like to extend my knowledge into DRM such as a scenario having a kernel version that doesn't have the DRM_DP_AUX_CHARDEV yet. Would it possible to implement specific DRM_DP_AUX_CHARDEV to it. Thanks,J

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Adds psrwake options for all platforms (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/psr: Adds psrwake options for all platforms (rev2) URL : https://patchwork.freedesktop.org/series/44601/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9282 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Adds psrwake options for all platforms (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/psr: Adds psrwake options for all platforms (rev2) URL : https://patchwork.freedesktop.org/series/44601/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9282_full = == Summary - WARNING == Minor unknown changes c

Re: [Intel-gfx] [PATCH v2] drm/i915: add support for perf configuration queries

2018-06-13 Thread Joonas Lahtinen
Quoting Lionel Landwerlin (2018-06-12 19:54:41) > Listing configurations at the moment is supported only through sysfs. > This might cause issues for applications wanting to list > configurations from a container where sysfs isn't available. > > This change adds a way to query the number of config

[Intel-gfx] [PATCH] drm/i915: make plane func structs const

2018-06-13 Thread Jani Nikula
No reason not to be const. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2c16c3a3cdea..4bb8c12c333f 100644 --- a/driv

Re: [Intel-gfx] [PATCH] drm/i915/psr: Adds psrwake options for all platforms

2018-06-13 Thread Ville Syrjälä
On Tue, Jun 12, 2018 at 10:49:09AM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > Adds new psrwake options defined in the below table. > Platform PSR wake options vbt version > KBL/CFL/WHL All > SKL All PV releases (Check for 203+ might help but cannot be > foolpr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make plane func structs const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915: make plane func structs const URL : https://patchwork.freedesktop.org/series/44685/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9283 = == Summary - SUCCESS == No regressions found. External URL: https://patch

[Intel-gfx] [PATCH] drm/i915/opregion: move acpi notifier to dev_priv

2018-06-13 Thread Jani Nikula
Get rid of the silly static variable. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_opregion.c | 31 --- drivers/gpu/drm/i915/intel_opregion.h | 1 + 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b

Re: [Intel-gfx] [PATCH] drm/i915/opregion: move acpi notifier to dev_priv

2018-06-13 Thread Chris Wilson
Quoting Jani Nikula (2018-06-13 12:39:27) > Get rid of the silly static variable. > > Signed-off-by: Jani Nikula Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

[Intel-gfx] [PATCH] drm/i915: make skl plane and planar format tables const

2018-06-13 Thread Jani Nikula
No reason not to be const. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_sprite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 344c0e709b19..412782f3b065 100644 --- a/drivers/g

[Intel-gfx] [PATCH] drm/i915/perf: make oa format tables const

2018-06-13 Thread Jani Nikula
No reason not to be const. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 881a992305ec..447407fee3b8 100644 --- a/drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH] drm/i915/perf: make oa format tables const

2018-06-13 Thread Lionel Landwerlin
On 13/06/18 12:49, Jani Nikula wrote: No reason not to be const. Signed-off-by: Jani Nikula Reviewed-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: make plane func structs const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915: make plane func structs const URL : https://patchwork.freedesktop.org/series/44685/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9283_full = == Summary - WARNING == Minor unknown changes coming with Patchwork

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/opregion: move acpi notifier to dev_priv

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/opregion: move acpi notifier to dev_priv URL : https://patchwork.freedesktop.org/series/44694/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9284 = == Summary - WARNING == Minor unknown changes coming with Patchwork

Re: [Intel-gfx] [PATCH] drm/i915: make skl plane and planar format tables const

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 02:46:20PM +0300, Jani Nikula wrote: > No reason not to be const. > > Signed-off-by: Jani Nikula Or we can go with https://patchwork.freedesktop.org/patch/226880/ > --- > drivers/gpu/drm/i915/intel_sprite.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Intel-gfx] [PATCH] drm/i915: make plane func structs const

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 01:24:22PM +0300, Jani Nikula wrote: > No reason not to be const. > > Signed-off-by: Jani Nikula https://patchwork.freedesktop.org/patch/226875/ > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/

Re: [Intel-gfx] [PATCH v4 0/2] Enable Dynamic cdclk and HDA together on GLK

2018-06-13 Thread Ville Syrjälä
On Tue, Jun 12, 2018 at 02:58:45PM -0700, Abhay Kumar wrote: > Patches needed to change cdclk to 2*BCLK before accessing HDA Codec. > > Ville Syrjälä (2): > drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled > drm/i915: Shut off PW2 when changing cdclk on glk Patchwork is p

Re: [Intel-gfx] [PATCH v3 01/12] drm/i915: Constify all plane_funcs structs

2018-06-13 Thread Jani Nikula
On Fri, 01 Jun 2018, Ville Syrjala wrote: > From: Ville Syrjälä > > plane_funcs can be cosnt. Make them so. > > v2: Rebase due to per-platforms plane_funcs > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > 1 file changed, 3

Re: [Intel-gfx] [PATCH] drm/i915: make plane func structs const

2018-06-13 Thread Jani Nikula
On Wed, 13 Jun 2018, Ville Syrjälä wrote: > On Wed, Jun 13, 2018 at 01:24:22PM +0300, Jani Nikula wrote: >> No reason not to be const. >> >> Signed-off-by: Jani Nikula > > https://patchwork.freedesktop.org/patch/226875/ Okay, rb on that. BR, Jani. > >> --- >> drivers/gpu/drm/i915/intel_disp

Re: [Intel-gfx] [PATCH] drm/i915: make skl plane and planar format tables const

2018-06-13 Thread Jani Nikula
On Wed, 13 Jun 2018, Ville Syrjälä wrote: > On Wed, Jun 13, 2018 at 02:46:20PM +0300, Jani Nikula wrote: >> No reason not to be const. >> >> Signed-off-by: Jani Nikula > > Or we can go with > https://patchwork.freedesktop.org/patch/226880/ Fine by me. BR, Jani. > >> --- >> drivers/gpu/drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make skl plane and planar format tables const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915: make skl plane and planar format tables const URL : https://patchwork.freedesktop.org/series/44696/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9285 = == Summary - WARNING == Minor unknown changes coming with Pat

Re: [Intel-gfx] [PATCH v9 7/7] drm/i915: add a sysfs entry to let users set sseu configs

2018-06-13 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2018-06-12 15:02:07) > > On 12/06/2018 11:52, Lionel Landwerlin wrote: > > On 12/06/18 11:37, Chris Wilson wrote: > >> Quoting Lionel Landwerlin (2018-06-12 11:33:34) > >>> On 12/06/18 10:20, Joonas Lahtinen wrote: > Quoting Chris Wilson (2018-06-11 18:02:37) > > Q

Re: [Intel-gfx] [PATCH] drm/i915: Make closing request flush mandatory

2018-06-13 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-06-12 13:51:35) > For symmetry, simplicity and ensuring the request is always truly idle > upon its completion, always emit the closing flush prior to emitting the > request breadcrumb. Previously, we would only emit the flush if we had > started a user batch, but this ju

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: make oa format tables const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/perf: make oa format tables const URL : https://patchwork.freedesktop.org/series/44697/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9286 = == Summary - SUCCESS == No regressions found. External URL: https://pa

Re: [Intel-gfx] [PATCH i-g-t] [RFC] Add support to force specific module load

2018-06-13 Thread Petri Latvala
On Tue, May 29, 2018 at 09:45:20PM -0300, Rodrigo Siqueira wrote: > This patch adds a new option to force the use of a module specified from > the command line. The force command expects a module name which will be > used on the target test (changing the standard behavior). This feature > can be u

Re: [Intel-gfx] [PATCH] drm/i915: Make closing request flush mandatory

2018-06-13 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-06-13 13:54:01) > Quoting Chris Wilson (2018-06-12 13:51:35) > > For symmetry, simplicity and ensuring the request is always truly idle > > upon its completion, always emit the closing flush prior to emitting the > > request breadcrumb. Previously, we would only emit t

Re: [Intel-gfx] [PATCH] drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI

2018-06-13 Thread Maarten Lankhorst
Op 24-05-18 om 14:54 schreef Ville Syrjala: > From: Ville Syrjälä > > When encountering a connector with the scaling mode property both > intel and modesetting ddxs sometimes add tons of DBLSCAN modes > to the output's mode list. The idea presumably being that since the > output will be going thro

[Intel-gfx] [PATCH 3/5] drm/i915: Make the hexdump row offset visually distinct

2018-06-13 Thread Chris Wilson
Currently we use %08x for the row offset, and %08x for the binary contents of the buffer. This makes it very easily to confuse the two, so switch to using [%04x] for the start-of-row offset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_engine_cs.c | 2 +- 1 file changed, 1 insertio

[Intel-gfx] [PATCH 2/5] drm/i915: Dump the ringbuffer of the active request for debugging

2018-06-13 Thread Chris Wilson
Sometimes we need to see what instructions we emitted for a request to try and gather a glimmer of insight into what the GPU is doing when it stops responding. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_engine_cs.c | 35 ++ 1 file changed, 30 insertions(+)

[Intel-gfx] [PATCH 5/5] drm/i915/gtt: Only keep gen6 page directories pinned while active

2018-06-13 Thread Chris Wilson
In order to be able to evict the gen6 ppgtt, we have to unpin it at some point. We can simply use our context activity tracking to know when the ppgtt is no longer in use by hardware, and so only keep it pinned while being used a request. For the kernel_context (and thus aliasing_ppgtt), it remain

[Intel-gfx] [PATCH 4/5] drm/i915: Show CCID in engine dumps

2018-06-13 Thread Chris Wilson
For debugging context issues, knowing what context the GPU is loading/using is helpful. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c in

[Intel-gfx] [PATCH 1/5] drm/i915: Supply the extended state flags for forced context load

2018-06-13 Thread Chris Wilson
Provide the extended state (or resource streamer bits for Haswell) flags when doing a forced restore of the current context by temporarily loading the kernel context. Fixes: 1fc719d13ac0 ("drm/i915/ringbuffer: Brute force context restore") Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Mika

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/opregion: move acpi notifier to dev_priv

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/opregion: move acpi notifier to dev_priv URL : https://patchwork.freedesktop.org/series/44694/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9284_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Supply the extended state flags for forced context load

2018-06-13 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Supply the extended state flags for forced context load URL : https://patchwork.freedesktop.org/series/44703/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4310 -> Patchwork_9287 = == Summary - FAILURE ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: make skl plane and planar format tables const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915: make skl plane and planar format tables const URL : https://patchwork.freedesktop.org/series/44696/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9285_full = == Summary - WARNING == Minor unknown changes comin

[Intel-gfx] [PATCH 1/2] drm/i915: Disallow interlaced modes on g4x DP outputs

2018-06-13 Thread Ville Syrjala
From: Ville Syrjälä Looks like interlaced DP output doesn't work on g4x either. Not all that surprising considering we already established that interlaced DP output is busted on VLV/CHV. Cc: sta...@vger.kernel.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 fil

[Intel-gfx] [PATCH 2/2] drm/i915: Turn off g4x DP port in .post_disable()

2018-06-13 Thread Ville Syrjala
From: Ville Syrjälä While Bspec doesn't list a specific sequence for turning off the DP port on g4x we are getting an underrun if the port is disabled in the .disable() hook. Looks like the pipe stops when the port stops, and by that time the plane disable may not have completed yet. Also the pla

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Disallow interlaced modes on g4x DP outputs

2018-06-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Disallow interlaced modes on g4x DP outputs URL : https://patchwork.freedesktop.org/series/44705/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4310 -> Patchwork_9288 = == Summary - WARNING == Minor unkno

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: make oa format tables const

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/perf: make oa format tables const URL : https://patchwork.freedesktop.org/series/44697/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9286_full = == Summary - WARNING == Minor unknown changes coming with Patchw

[Intel-gfx] Patch "x86/cpufeature: Remove cpu_has_clflush" has been added to the 4.4-stable tree

2018-06-13 Thread gregkh
This is a note to let you know that I've just added the patch titled x86/cpufeature: Remove cpu_has_clflush to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-cpufeature-re

[Intel-gfx] Patch "x86/mm/pat, x86/cpufeature: Remove cpu_has_pat" has been added to the 4.4-stable tree

2018-06-13 Thread gregkh
This is a note to let you know that I've just added the patch titled x86/mm/pat, x86/cpufeature: Remove cpu_has_pat to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-mm-pa

[Intel-gfx] ✗ Fi.CI.BAT: failure for Patch "x86/cpufeature: Remove cpu_has_clflush" has been added to the 4.4-stable tree

2018-06-13 Thread Patchwork
== Series Details == Series: Patch "x86/cpufeature: Remove cpu_has_clflush" has been added to the 4.4-stable tree URL : https://patchwork.freedesktop.org/series/44707/ State : failure == Summary == Applying: Patch "x86/cpufeature: Remove cpu_has_clflush" has been added to the 4.4-stable tree

[Intel-gfx] ✗ Fi.CI.BAT: failure for Patch "x86/mm/pat, x86/cpufeature: Remove cpu_has_pat" has been added to the 4.4-stable tree

2018-06-13 Thread Patchwork
== Series Details == Series: Patch "x86/mm/pat, x86/cpufeature: Remove cpu_has_pat" has been added to the 4.4-stable tree URL : https://patchwork.freedesktop.org/series/44708/ State : failure == Summary == Applying: Patch "x86/mm/pat, x86/cpufeature: Remove cpu_has_pat" has been added to the

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Paulo Zanoni
Em Qua, 2018-06-13 às 11:07 +0300, Jani Nikula escreveu: > On Tue, 12 Jun 2018, Rodrigo Vivi wrote: > > Do we really want BIT everywhere?! > > I think I'd go for everywhere except part of a register field value: > While I completely agree with your reasoning, this means we'll kinda always want

Re: [Intel-gfx] [PATCH] drm/i915/psr: Adds psrwake options for all platforms

2018-06-13 Thread Dhinakaran Pandiyan
On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote: > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" m> wrote: > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote: > > > > > > On Tue, 12 Jun 2018, vathsala nagaraju > > om> wrote: > > > > > > > > From: Vathsala Nagaraju > > > > > > > > Adds new psrw

[Intel-gfx] [PATCH 3/5] drm/i915/ddi: Check transcoder instead of port when setting HDMI infoframe

2018-06-13 Thread Imre Deak
The only requirement by BSpec for setting the HDMI infoframes is on DDI platforms to do that before enabling the HDMI transcoder function, see VIDEO_DIP_CTL bit 16. Accordingly check for the transcoder function disabled state instead of the port's disabled state on DDI platforms. This is needed by

[Intel-gfx] [PATCH 0/5] drm/i915/icl: Fix HDMI infoframe setting

2018-06-13 Thread Imre Deak
On ICL setting the HDMI infoframe requires the pipe clock to be enabled, this patchset makes sure this is the case both during enabling and disabling the output. After discussing with Ville, the only constraint seems to be wrt. other platforms is that the infoframe is set when the transcoder funct

[Intel-gfx] [PATCH 5/5] drm/i915/ddi: Removed unused var from hsw_write_infoframe()

2018-06-13 Thread Imre Deak
Cc: Vandita Kulkarni Cc: Paulo Zanoni Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_hdmi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 29d586f5cedb..bd928e83dfc7 100644 --- a/driv

[Intel-gfx] [PATCH 1/5] drm/i915/ddi: s/crtc->config/old_crtc_state in haswell_crtc_disable()

2018-06-13 Thread Imre Deak
crtc->config points to the old crtc state at the point display.crtc_disable() is called, so use the more descriptive pointer instead. Cc: Vandita Kulkarni Cc: Paulo Zanoni Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 inserti

[Intel-gfx] [PATCH 2/5] drm/i915/ddi: Push pipe clock enabling to encoders

2018-06-13 Thread Imre Deak
On ICL the pipe clock needs to be enabled before setting the HDMI infoframe, but these steps are in the reverse order atm. Move the pipe clock enabling to the encoders, so reordering of the two steps can be done in a clean way. No functional change. Cc: Vandita Kulkarni Cc: Paulo Zanoni Cc: Vil

[Intel-gfx] [PATCH 4/5] drm/i915/ddi: Set HDMI infoframes with pipe clocks enabled

2018-06-13 Thread Imre Deak
On ICL for setting the HDMI infoframe the pipe clock needs to be enabled, otherwise accessing the VIDEO_DIP_CTL register will hang the machine. Cc: Vandita Kulkarni Cc: Paulo Zanoni Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_ddi.c | 10 +- 1 file changed

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-13 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler wrote: > > On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > > On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula wrote: > > >> > > >> On Thu, 31 May 2018, Lucas De Marchi wrote: > > >> > On T

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Fix HDMI infoframe setting

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix HDMI infoframe setting URL : https://patchwork.freedesktop.org/series/44709/ State : failure == Summary == Applying: drm/i915/ddi: s/crtc->config/old_crtc_state in haswell_crtc_disable() Applying: drm/i915/ddi: Push pipe clock enabling to encoders

Re: [Intel-gfx] [PATCH] drm/i915/psr: Adds psrwake options for all platforms

2018-06-13 Thread Dhinakaran Pandiyan
On Wed, 2018-06-13 at 10:32 -0700, Dhinakaran Pandiyan wrote: > On Wed, 2018-06-13 at 09:41 +0300, Jani Nikula wrote: > > > > On Wed, 13 Jun 2018, "Nagaraju, Vathsala" > co > > m> wrote: > > > > > > > > > On 6/12/2018 2:30 PM, Jani Nikula wrote: > > > > > > > > > > > > On Tue, 12 Jun 2018, va

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-13 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 10:09 AM Lucas De Marchi wrote: > > On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler > wrote: > > > > On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > > > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > > > On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula > > > >

[Intel-gfx] [PATCH v2 2/5] drm/i915/ddi: Push pipe clock enabling to encoders

2018-06-13 Thread Imre Deak
On ICL the pipe clock needs to be enabled before setting the HDMI infoframe, but these steps are in the reverse order atm. Move the pipe clock enabling to the encoders, so reordering of the two steps can be done in a clean way. No functional change. v2: - Rebased on drm-tip. Cc: Vandita Kulkarni

Re: [Intel-gfx] [PATCH 1/5] drm/i915/ddi: s/crtc->config/old_crtc_state in haswell_crtc_disable()

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 08:07:06PM +0300, Imre Deak wrote: > crtc->config points to the old crtc state at the point > display.crtc_disable() is called, so use the more descriptive pointer > instead. I see one more crtc->config in there. Either way Reviewed-by: Ville Syrjälä > > Cc: Vandita Kul

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/ddi: Push pipe clock enabling to encoders

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 08:27:46PM +0300, Imre Deak wrote: > On ICL the pipe clock needs to be enabled before setting the HDMI > infoframe, but these steps are in the reverse order atm. Move the pipe > clock enabling to the encoders, so reordering of the two steps can be > done in a clean way. > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915/ddi: Check transcoder instead of port when setting HDMI infoframe

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 08:07:08PM +0300, Imre Deak wrote: > The only requirement by BSpec for setting the HDMI infoframes is on DDI > platforms to do that before enabling the HDMI transcoder function, see > VIDEO_DIP_CTL bit 16. Accordingly check for the transcoder function > disabled state instea

Re: [Intel-gfx] [PATCH 4/5] drm/i915/ddi: Set HDMI infoframes with pipe clocks enabled

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 08:07:09PM +0300, Imre Deak wrote: > On ICL for setting the HDMI infoframe the pipe clock needs to be > enabled, otherwise accessing the VIDEO_DIP_CTL register will hang the > machine. > > Cc: Vandita Kulkarni > Cc: Paulo Zanoni > Cc: Ville Syrjälä > Signed-off-by: Imre

Re: [Intel-gfx] [PATCH 5/5] drm/i915/ddi: Removed unused var from hsw_write_infoframe()

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 08:07:10PM +0300, Imre Deak wrote: > Cc: Vandita Kulkarni > Cc: Paulo Zanoni > Cc: Ville Syrjälä > Signed-off-by: Imre Deak Looks like I forgot to remove it in ffc85daba535 ("drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+") Reviewed-by: Ville Syrjälä > --- > drivers

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI

2018-06-13 Thread Ville Syrjälä
On Thu, May 24, 2018 at 04:30:10PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI > URL : https://patchwork.freedesktop.org/series/43698/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4230_full -> Pat

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix HDMI infoframe setting (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix HDMI infoframe setting (rev2) URL : https://patchwork.freedesktop.org/series/44709/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4310 -> Patchwork_9292 = == Summary - WARNING == Minor unknown changes coming with Patchwork_9

Re: [Intel-gfx] [PATCH] drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI

2018-06-13 Thread Ville Syrjälä
On Wed, Jun 13, 2018 at 04:48:29PM +0200, Maarten Lankhorst wrote: > Op 24-05-18 om 14:54 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > When encountering a connector with the scaling mode property both > > intel and modesetting ddxs sometimes add tons of DBLSCAN modes > > to the output's

[Intel-gfx] [PATCH v4 1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-06-13 Thread Abhay Kumar
From: Ville Syrjälä CDCLK has to be at least twice the BLCK regardless of audio. Audio driver has to probe using this hook and increase the clock even in absence of any display. v2: Use atomic refcount for get_power, put_power so that we can call each once(Abhay). v3: Reset power well 2 to a

[Intel-gfx] [PATCH v4 3/4] drm/i915: Lock gmbus/aux mutexes while changing cdclk

2018-06-13 Thread Abhay Kumar
From: Ville Syrjälä gmbus/aux may be clocked by cdclk, thus we should make sure no transfers are ongoing while the cdclk frequency is being changed. We do that by simply grabbing all the gmbus/aux mutexes. No one else should be holding any more than one of those at a time so the lock ordering her

[Intel-gfx] [PATCH v4 0/4] Enable Dynamic cdclk and HDA together on GLK

2018-06-13 Thread Abhay Kumar
Patches needed to change cdclk to 2*BCLK before accessing HDA Codec. Ville Syrjälä (4): drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled drm/i915: Introduce for_each_intel_dp() drm/i915: Lock gmbus/aux mutexes while changing cdclk drm/i915: Shut off PW2 when changing c

[Intel-gfx] [PATCH v4 2/4] drm/i915: Introduce for_each_intel_dp()

2018-06-13 Thread Abhay Kumar
From: Ville Syrjälä Add a convenience macro for iterating DP encoders. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.h | 4 drivers/gpu/drm/i915/intel_dp.c | 38 +++- drivers/gpu/drm/i915/intel_drv.h | 14 + 3 fil

[Intel-gfx] [PATCH v4 4/4] drm/i915: Shut off PW2 when changing cdclk on glk

2018-06-13 Thread Abhay Kumar
From: Ville Syrjälä Apparently the audio hardware gets confused if it's powered up when change the cdclk frequency. Force PW2 (which is where audio lives) off when we do the cdclk reprogramming. This is a rather big hack. If something is using PW2 when we do this things wil break. I don't think

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Dynamic cdclk and HDA together on GLK

2018-06-13 Thread Patchwork
== Series Details == Series: Enable Dynamic cdclk and HDA together on GLK URL : https://patchwork.freedesktop.org/series/44713/ State : warning == Summary == $ dim checkpatch origin/drm-tip 08c10018dfc7 drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled -:54: CHECK:SPACING:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Dynamic cdclk and HDA together on GLK

2018-06-13 Thread Patchwork
== Series Details == Series: Enable Dynamic cdclk and HDA together on GLK URL : https://patchwork.freedesktop.org/series/44713/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled -O:drivers/gpu/drm/i915/intel_

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Dynamic cdclk and HDA together on GLK

2018-06-13 Thread Patchwork
== Series Details == Series: Enable Dynamic cdclk and HDA together on GLK URL : https://patchwork.freedesktop.org/series/44713/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4311 -> Patchwork_9293 = == Summary - SUCCESS == No regressions found. External URL: https://

[Intel-gfx] [PATCH] drm/i915/psr: Kill delays when activating psr back.

2018-06-13 Thread Rodrigo Vivi
The immediate enabling was actually not an issue for the HW perspective for core platforms that have HW tracking. HW will wait few identical idle frames before transitioning to actual psr active anyways. Now that we removed VLV/CHV out of the picture completely we can safely remove any delays. No

Re: [Intel-gfx] [CI 1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Paulo Zanoni
Em Ter, 2018-06-12 às 11:37 -0700, Manasi Navare escreveu: > On Tue, Jun 12, 2018 at 03:15:53PM +0300, Ville Syrjälä wrote: > > On Mon, Jun 11, 2018 at 03:26:54PM -0700, Paulo Zanoni wrote: > > > From: Manasi Navare > > > > > > For ICL, on Combo PHY the allowed max rates are: > > > - HBR3 8.1 eD

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

2018-06-13 Thread Dhinakaran Pandiyan
On Tue, 2018-06-05 at 22:45 +, Souza, Jose wrote: > On Tue, 2018-05-22 at 16:58 -0700, Dhinakaran Pandiyan wrote: > > > > On Thu, 2018-05-17 at 15:21 -0700, José Roberto de Souza wrote: > > > > > > eDP spec states that sink device will do a short pulse in HPD > > > line when there is a PSR/PS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Kill delays when activating psr back.

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/psr: Kill delays when activating psr back. URL : https://patchwork.freedesktop.org/series/44715/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4311 -> Patchwork_9294 = == Summary - WARNING == Minor unknown changes coming with Patchwo

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

2018-06-13 Thread Souza, Jose
On Wed, 2018-06-13 at 13:17 -0700, Dhinakaran Pandiyan wrote: > On Tue, 2018-06-05 at 22:45 +, Souza, Jose wrote: > > On Tue, 2018-05-22 at 16:58 -0700, Dhinakaran Pandiyan wrote: > > > > > > On Thu, 2018-05-17 at 15:21 -0700, José Roberto de Souza wrote: > > > > > > > > eDP spec states that

Re: [Intel-gfx] [CI 1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Manasi Navare
On Wed, Jun 13, 2018 at 12:42:20PM -0700, Paulo Zanoni wrote: > Em Ter, 2018-06-12 às 11:37 -0700, Manasi Navare escreveu: > > On Tue, Jun 12, 2018 at 03:15:53PM +0300, Ville Syrjälä wrote: > > > On Mon, Jun 11, 2018 at 03:26:54PM -0700, Paulo Zanoni wrote: > > > > From: Manasi Navare > > > > > >

Re: [Intel-gfx] [CI 1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Paulo Zanoni
Em Qua, 2018-06-13 às 13:15 -0700, Manasi Navare escreveu: > On Wed, Jun 13, 2018 at 12:42:20PM -0700, Paulo Zanoni wrote: > > Em Ter, 2018-06-12 às 11:37 -0700, Manasi Navare escreveu: > > > On Tue, Jun 12, 2018 at 03:15:53PM +0300, Ville Syrjälä wrote: > > > > On Mon, Jun 11, 2018 at 03:26:54PM -

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Disallow interlaced modes on g4x DP outputs

2018-06-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Disallow interlaced modes on g4x DP outputs URL : https://patchwork.freedesktop.org/series/44705/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4310_full -> Patchwork_9288_full = == Summary - WARNING == M

Re: [Intel-gfx] [PATCH 15/24] drm/i915/icl: compute the TBT PLL registers

2018-06-13 Thread Paulo Zanoni
Em Sex, 2018-06-08 às 13:19 -0700, Srivatsa, Anusha escreveu: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > Behalf Of > > Paulo Zanoni > > Sent: Monday, May 21, 2018 5:26 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Zanoni, Paulo R

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink

2018-06-13 Thread Dhinakaran Pandiyan
On Wed, 2018-06-13 at 20:02 +, Souza, Jose wrote: > On Wed, 2018-06-13 at 13:17 -0700, Dhinakaran Pandiyan wrote: > > > > On Tue, 2018-06-05 at 22:45 +, Souza, Jose wrote: > > > > > > On Tue, 2018-05-22 at 16:58 -0700, Dhinakaran Pandiyan wrote: > > > > > > > > > > > > On Thu, 2018-05-1

[Intel-gfx] [PATCH v2 15/24] drm/i915/icl: compute the TBT PLL registers

2018-06-13 Thread Paulo Zanoni
Use the hardcoded tables provided by our spec. v2: - SSC stays disabled. - Use intel_port_is_tc(). Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dpll

[Intel-gfx] [PATCH V2] drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.

2018-06-13 Thread clinton . a . taylor
From: Clint Taylor On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal. When measured on a scope the highspeed lines of the HDMI clock turn off for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC a

[Intel-gfx] ✗ Fi.CI.BAT: failure for More ICL display patches (rev12)

2018-06-13 Thread Patchwork
== Series Details == Series: More ICL display patches (rev12) URL : https://patchwork.freedesktop.org/series/43546/ State : failure == Summary == Applying: drm/i915/icl: Extend AUX F interrupts to ICL Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_irq.c Fallin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2) URL : https://patchwork.freedesktop.org/series/6/ State : warning == Summary == $ dim checkpatch origin/drm-tip 40e1ef81c43c drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -:30: CHECK:SPACING:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2) URL : https://patchwork.freedesktop.org/series/6/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftest

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix HDMI infoframe setting (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix HDMI infoframe setting (rev2) URL : https://patchwork.freedesktop.org/series/44709/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4310_full -> Patchwork_9292_full = == Summary - WARNING == Minor unknown changes coming with P

Re: [Intel-gfx] [RFC PATCH] drm/i915/guc: New interface files for GuC starting in Gen11

2018-06-13 Thread Oscar Mateo Lozano
On 5/29/2018 7:59 AM, Michal Wajdeczko wrote: Hi, On Fri, 25 May 2018 23:59:35 +0200, Oscar Mateo wrote: GuC interface has been redesigned (or cleaned up, rather) starting with Gen11, as a stepping stone towards a new branching strategy that helps maintain backwards compatibility with previ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2)

2018-06-13 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev2) URL : https://patchwork.freedesktop.org/series/6/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4311 -> Patchwork_9296 = == Summary - SUCCESS == No regressions found. Externa

Re: [Intel-gfx] [PATCH 04/24] drm/i915/icl: Support for TC North Display interrupts

2018-06-13 Thread Lucas De Marchi
+Chris On Mon, May 21, 2018 at 05:25:38PM -0700, Paulo Zanoni wrote: > From: Dhinakaran Pandiyan > > The hotplug interrupts for the ports can be routed to either North > Display or South Display depending on the output mode. DP Alternate or > DP over TBT outputs will have hotplug interrupts rout

Re: [Intel-gfx] [PATCH 05/24] drm/i915/icp: Add Interrupt Support

2018-06-13 Thread Lucas De Marchi
On Tue, May 29, 2018 at 05:04:58PM -0700, Lucas De Marchi wrote: > On Thu, May 24, 2018 at 05:43:24PM -0700, Lucas De Marchi wrote: > > On Thu, May 24, 2018 at 05:45:43PM -0700, Dhinakaran Pandiyan wrote: > > > On Thu, 2018-05-24 at 16:53 -0700, Lucas De Marchi wrote: > > > > On Mon, May 21, 2018 a

  1   2   >