[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr : Add psr1 live status (rev5)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915/psr : Add psr1 live status (rev5) URL : https://patchwork.freedesktop.org/series/42021/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4237 -> Patchwork_9115 = == Summary - SUCCESS == No regressions found. External URL: https://pa

Re: [Intel-gfx] [PATCH] gpu: Consistently use octal not symbolic permissions

2018-05-25 Thread Jani Nikula
On Thu, 24 May 2018, Joe Perches wrote: > On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote: >> On Thu, 24 May 2018, Joe Perches wrote: >> > There is currently a mixture of octal and symbolic permissions uses >> > in files in drivers/gpu/drm and one file in drivers/gpu. >> > >> > There are ~2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Set idle frame count based on sink synchronization latency

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915/psr: Set idle frame count based on sink synchronization latency URL : https://patchwork.freedesktop.org/series/43742/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4236_full -> Patchwork_9113_full = == Summary - WARNING == Minor unkn

Re: [Intel-gfx] [PATCH 1/2] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Tvrtko Ursulin
On 24/05/2018 17:13, Lionel Landwerlin wrote: On 24/05/18 17:07, Tvrtko Ursulin wrote: On 24/05/2018 16:53, Lionel Landwerlin wrote: On 24/05/18 16:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Instead of using the engine->id, use uabi_class:instance pairs in trace- points including eng

Re: [Intel-gfx] [PATCH] drm/i915/psr: Set idle frame count based on sink synchronization latency

2018-05-25 Thread Jani Nikula
On Thu, 24 May 2018, Dhinakaran Pandiyan wrote: > DPCD 2009h "Synchronization latency in sink" has bits that tell us the > maximum number of frames sink can take to resynchronize to source timing > when exiting PSR. More importantly, as per eDP 1.4b, this is the "Minimum > number of frames followi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prepare GEM for suspend earlier (rev4)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Prepare GEM for suspend earlier (rev4) URL : https://patchwork.freedesktop.org/series/43575/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4237 -> Patchwork_9116 = == Summary - WARNING == Minor unknown changes coming with Patchwork_

Re: [Intel-gfx] [PATCH 1/2] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-25 08:11:41) > > On 24/05/2018 17:13, Lionel Landwerlin wrote: > > On 24/05/18 17:07, Tvrtko Ursulin wrote: > >> > >> On 24/05/2018 16:53, Lionel Landwerlin wrote: > >>> On 24/05/18 16:04, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Instead of u

[Intel-gfx] [PATCH i-g-t v2] tests/drv_suspend: Suspend under memory pressure

2018-05-25 Thread Chris Wilson
Recently we discovered that we have a race between swapping and suspend in our resume path (we might be trying to page in an object after disabling the block devices). Let's try to exercise that by exhausting all of system memory before suspend. v2: Explicitly share the large memory area on forkin

Re: [Intel-gfx] [PATCH] drm/edid: Fix up edid_cea_modes[] formatting

2018-05-25 Thread Jani Nikula
On Thu, 24 May 2018, Ville Syrjala wrote: > From: Ville Syrjälä > > Fix up a bunch of bad indentation and insconsistent comments > in edid_cea_modes[]. > > v2: Instead of stripping the aspect ratio comments let's > add them to all modes > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nik

Re: [Intel-gfx] DRM Inquiry

2018-05-25 Thread John Sledge
Hi Jani, I seek 0-800 and here's what I get, all 11 0A in hex. Not sure if this is the brightness value of the display. I also did a test, when I disconnect the DP to the display and execute the dd commands, it would say error reading 'dev/drm_dp_aux1': Connection timed out. So I think my displ

[Intel-gfx] [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id. Move the two pieces of context data together for redability. Binary records are left as is, that is both fields remaing under the existing name a

[Intel-gfx] [PATCH 1/3] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info. This will be more readable, more future proof and more stable for userspace consumption. v2: * Use u16 for class and instance. (Chris Wilson) Signed-off-by: Tvrtko Ursul

[Intel-gfx] [PATCH 3/3] drm/i915/trace: Context field needs to be 64-bit wide

2018-05-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Underlaying field is u64 so the tracepoint needs to be as well. Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson --- drivers/gpu/drm/i915/i915_trace.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr : Add psr1 live status (rev5)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915/psr : Add psr1 live status (rev5) URL : https://patchwork.freedesktop.org/series/42021/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4237_full -> Patchwork_9115_full = == Summary - WARNING == Minor unknown changes coming with Patchw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Tvrtko Ursulin
On 24/05/2018 17:00, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-24 16:48:45) On 24/05/2018 16:33, Chris Wilson wrote: But what we call ctx here isn't really context, but timeline; how about if we switch to the fence=%llx:%d representation we've mostly settled on for the debug message

Re: [Intel-gfx] DRM Inquiry

2018-05-25 Thread Jani Nikula
On Fri, 25 May 2018, John Sledge wrote: > Hi Jani, > I seek 0-800 and here's what I get, all 11 0A in hex. Not sure if this is the > brightness value of the display. I also did a test, when I disconnect the DP > to the display and execute the dd commands, it would say error reading > 'dev/drm_

Re: [Intel-gfx] [PATCH v4] drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset

2018-05-25 Thread Tvrtko Ursulin
On 24/05/2018 14:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-24 14:34:41) On 19/05/2018 10:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-18 15:42:00) On 18/05/2018 15:13, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-18 13:36:52) On 18/05/2018 13:28, Chris Wil

Re: [Intel-gfx] [PATCH 2/2] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-25 09:30:29) > > On 24/05/2018 17:00, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-05-24 16:48:45) > >> > >> On 24/05/2018 16:33, Chris Wilson wrote: > >>> But what we call ctx here isn't really context, but timeline; how about > >>> if we switch to the fenc

[Intel-gfx] libdrm to read/write drm_dpcd helper functions.

2018-05-25 Thread lester magtagad
Hello everyone, I am new to DRM and linux, I started reading developers guide and research on my own. I don't know where to start on how to communicate the DP helper functions (drm_dp_dpcd_read, drm_dp_dpcd_readb, drm_dp_dpcd_write, drm_dp_dpcd_writeb), what will I include(#include) in my main

Re: [Intel-gfx] [PATCH 3/3] drm/i915/trace: Context field needs to be 64-bit wide

2018-05-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-25 09:26:42) > From: Tvrtko Ursulin > > Underlaying field is u64 so the tracepoint needs to be as well. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_trace.h | 20 ++-- > 1 file changed, 10 inse

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs URL : https://patchwork.freedesktop.org/series/43763/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238 -> Patchwork_9117 = == Summary - WARNING == Minor un

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Prepare GEM for suspend earlier (rev4)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Prepare GEM for suspend earlier (rev4) URL : https://patchwork.freedesktop.org/series/43575/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4237_full -> Patchwork_9116_full = == Summary - FAILURE == Serious unknown changes coming wit

[Intel-gfx] [PATCH] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Chris Wilson
In order to prepare the GPU for sleeping, we may want to submit commands to it. This is a complicated process that may even require some swapping in from shmemfs, if the GPU was in the wrong state. As such, we need to do this preparation step synchronously before the rest of the system has started

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with drm/i915/gtt: Avoid calling non-existent allocate_va_range (rev2)

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with drm/i915/gtt: Avoid calling non-existent allocate_va_range (rev2) URL : https://patchwork.freedesktop.org/series/42448/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4238 -> Patchwork_9118 = == Summary - FAILURE == Serio

[Intel-gfx] [PATCH 02/18] drm/i915: Switch to kernel context before idling at runtime

2018-05-25 Thread Chris Wilson
We can reduce our exposure to random neutrinos by resting on the kernel context having flushed out the user contexts to system memory and beyond. The corollary is that we then we require two passes through the idle handler to go to sleep, which on a truly idle system involves an extra pass through

[Intel-gfx] [PATCH 05/18] drm/i915: Only sanitize GEM from late suspend

2018-05-25 Thread Chris Wilson
During testing we encounter a conflict between SUSPEND_TEST_DEVICES and disabling reset (gem_eio/suspend). This results in the device continuing on without being reset, but since it has gone through HW sanitization to account for the suspend/resume cycle, we have to assume the device has been reset

[Intel-gfx] [PATCH 07/18] drm/i915: Be irqsafe inside reset

2018-05-25 Thread Chris Wilson
As we want to be able to call i915_reset_engine and co from a softirq or timer context, we need to be irqsafe at all timers. So we have to forgo the simple spin_lock_irq for the full spin_lock_irqsave. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 6 -- 1 file changed, 4

[Intel-gfx] RFC avoiding ksoftirqd for first submission

2018-05-25 Thread Chris Wilson
The series is still in flux as we depend on getting the bug fixes resolved at the head of the series first. But I wanted to present this before the w/e so you all have some reading material! -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.

[Intel-gfx] [PATCH 04/18] drm/i915: After reset on sanitization, reset the engine backends

2018-05-25 Thread Chris Wilson
As we reset the GPU on suspend/resume, we also do need to reset the engine state tracking so call into the engine backends. This is especially important so that we can also sanitize the state tracking across resume. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 24 +++

[Intel-gfx] [PATCH 09/18] drm/i915/execlists: Reset the CSB head tracking on reset/sanitization

2018-05-25 Thread Chris Wilson
We can avoid the mmio read of the CSB pointers after reset based on the knowledge that the HW always start writing at entry 0 in the CSB buffer. We need to reset our CSB head tracking after GPU reset (and on sanitization after resume) so that we are expecting to read from entry 0. Signed-off-by: C

[Intel-gfx] [PATCH 10/18] drm/i915/execlists: Pull submit after dequeue under timeline lock

2018-05-25 Thread Chris Wilson
In the next patch, we will begin processing the CSB from inside the interrupt handler. This means that updating the execlists->port[] will no longer be locked by the tasklet but by the engine->timeline.lock instead. Pull dequeue and submit under the same lock for protection. (An alternative, future

[Intel-gfx] [PATCH 11/18] drm/i915/execlists: Pull CSB reset under the timeline.lock

2018-05-25 Thread Chris Wilson
In the following patch, we will process the CSB interrupt under the timeline.lock and not under the tasklet lock. This also means that we will need to protect access to common variables such as execlists->csb_head with the timeline.lock during reset. Signed-off-by: Chris Wilson --- drivers/gpu/d

[Intel-gfx] [PATCH 14/18] drm/i915/execlists: Direct submission of new requests (avoid tasklet/ksoftirqd)

2018-05-25 Thread Chris Wilson
Back in commit 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half"), we came to the conclusion that running our CSB processing and ELSP submission from inside the irq handler was a bad idea. A really bad idea as we could impose nearly 1s latency on other users of the system, on av

[Intel-gfx] [PATCH 01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Chris Wilson
In order to prepare the GPU for sleeping, we may want to submit commands to it. This is a complicated process that may even require some swapping in from shmemfs, if the GPU was in the wrong state. As such, we need to do this preparation step synchronously before the rest of the system has started

[Intel-gfx] [PATCH 17/18] drm/i915: Move engine request retirement to intel_engine_cs

2018-05-25 Thread Chris Wilson
In the next patch, we will move ownership of the fence reference to the submission backend and will want to drop its final reference when retiring it from the submission backend. We will also need a catch up when parking the engine to cleanup any residual entries in the engine timeline. In short, m

[Intel-gfx] [PATCH 06/18] drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset

2018-05-25 Thread Chris Wilson
Inside the live_hangcheck (reset) selftests, we occasionally see failures like <7>[ 239.094840] i915_gem_set_wedged rcs0 <7>[ 239.094843] i915_gem_set_wedged current seqno 19a98, last 19a9a, hangcheck 0 [5158 ms] <7>[ 239.094846] i915_gem_set_wedged Reset count: 6239 (global 1) <7>[ 239.0

[Intel-gfx] [PATCH 15/18] drm/i915: Move rate-limiting request retire to after submission

2018-05-25 Thread Chris Wilson
Our long standing defense against a single client from flooding the system with requests (causing mempressure and stalls across the whole system) is to retire the old request on every allocation. (By retiring the oldest, we try to keep returning requests back to the system in a steady flow.) This a

[Intel-gfx] [PATCH 13/18] drm/i915/execlists: Unify CSB access pointers

2018-05-25 Thread Chris Wilson
Following the removal of the last workarounds, the only CSB mmio access is for the old vGPU interface. The mmio registers presented by vGPU do not require forcewake and can be treated as ordinary volatile memory, i.e. they behave just like the HWSP access just at a different location. We can reduce

[Intel-gfx] [PATCH 12/18] drm/i915/execlists: Process one CSB interrupt at a time

2018-05-25 Thread Chris Wilson
In the next patch, we will process the CSB events directly from the CS interrupt handler, being called for each interrupt. Hence, we will no longer have the need for a loop until the has-interrupt bit is clear, and in the meantime can remove that small optimisation. Signed-off-by: Chris Wilson --

[Intel-gfx] [PATCH 16/18] drm/i915: Wait for engines to idle before retiring

2018-05-25 Thread Chris Wilson
In the next patch, we will start to defer retiring the request from the engine list if it is still active on the submission backend. To preserve the semantics that after wait-for-idle completes the system is idle and fully retired, we need to therefore wait for the backends to idle before calling i

[Intel-gfx] [PATCH 03/18] drm/i915: "Race-to-idle" after switching to the kernel context

2018-05-25 Thread Chris Wilson
During suspend we want to flush out all active contexts and their rendering. To do so we queue a request from the kernel's context, once we know that request is done, we know the GPU is completely idle. To speed up that switch bump the GPU clocks. Switching to the kernel context prior to idling is

[Intel-gfx] [PATCH 08/18] drm/i915/execlists: Wait for ELSP submission on restart

2018-05-25 Thread Chris Wilson
After a reset, we will ensure that there is at least one request submitted to HW to ensure that a context is loaded for powersaving. Let's wait for this submission via a tasklet to complete before we drop our forcewake, ensuring the system is ready for rc6 before we let it possible sleep. Signed-o

[Intel-gfx] [PATCH 18/18] drm/i915: Hold request reference for submission until retirement

2018-05-25 Thread Chris Wilson
Currently the async submission backends (guc and execlists) hold a extra reference to the requests being processed as they are not serialised with request retirement. If we instead, prevent the request being dropped from the engine timeline until after submission has finished processing the request

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prepare GEM for suspend earlier (rev5)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Prepare GEM for suspend earlier (rev5) URL : https://patchwork.freedesktop.org/series/43575/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238 -> Patchwork_9119 = == Summary - SUCCESS == No regressions found. External URL: http

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [01/18] drm/i915: Prepare GEM for suspend earlier URL : https://patchwork.freedesktop.org/series/43765/ State : warning == Summary == $ dim checkpatch origin/drm-tip f6ebcbc1316a drm/i915: Prepare GEM for suspend earlier 14c41b87a902 drm/i915:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [01/18] drm/i915: Prepare GEM for suspend earlier URL : https://patchwork.freedesktop.org/series/43765/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Prepare GEM for suspend earlier Okay! Commit: drm/i915: Switch

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [01/18] drm/i915: Prepare GEM for suspend earlier URL : https://patchwork.freedesktop.org/series/43765/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238 -> Patchwork_9120 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/3] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Lionel Landwerlin
On 25/05/18 09:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Instead of using the engine->id, use uabi_class:instance pairs in trace- points including engine info. This will be more readable, more future proof and more stable for userspace consumption. v2: * Use u16 for class and instance.

Re: [Intel-gfx] [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Lionel Landwerlin
On 25/05/18 09:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id. Move the two pieces of context data together for redability. Binary records are left as is, that is bo

Re: [Intel-gfx] [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Lionel Landwerlin
On 25/05/18 11:28, Lionel Landwerlin wrote: On 25/05/18 09:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id. Move the two pieces of context data together for redabilit

Re: [Intel-gfx] [PATCH] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Ville Syrjälä
On Fri, May 25, 2018 at 10:26:29AM +0100, Chris Wilson wrote: > In order to prepare the GPU for sleeping, we may want to submit commands > to it. This is a complicated process that may even require some swapping > in from shmemfs, if the GPU was in the wrong state. As such, we need to > do this pre

Re: [Intel-gfx] [PATCH] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Chris Wilson
Quoting Ville Syrjälä (2018-05-25 11:51:13) > On Fri, May 25, 2018 at 10:26:29AM +0100, Chris Wilson wrote: > > In order to prepare the GPU for sleeping, we may want to submit commands > > to it. This is a complicated process that may even require some swapping > > in from shmemfs, if the GPU was i

Re: [Intel-gfx] [PATCH v4 30/41] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-05-25 Thread Ramalingam C
On Thursday 24 May 2018 01:36 PM, Daniel Vetter wrote: On Mon, May 21, 2018 at 06:23:49PM +0530, Ramalingam C wrote: Initialize HDCP2.2 support. This includes the mei interface initialization along with required notifier registration. v2: mei interface handle is protected with mutex. [Chri

Re: [Intel-gfx] [PATCH 02/24] drm/i915/icl: GSE interrupt moves from DE_MISC to GU_MISC

2018-05-25 Thread Mika Kuoppala
Dhinakaran Pandiyan writes: > On Thu, 2018-05-24 at 12:22 +0300, Mika Kuoppala wrote: >> Paulo Zanoni writes: >> >> > >> > From: Dhinakaran Pandiyan >> > >> > The Graphics System Event(GSE) interrupt bit has a new location in >> > the >> > GU_MISC_INTERRUPT_{IIR, ISR, IMR, IER} registers. Si

Re: [Intel-gfx] [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Tvrtko Ursulin
On 25/05/2018 11:28, Lionel Landwerlin wrote: On 25/05/18 09:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id. Move the two pieces of context data together for redabi

[Intel-gfx] [PATCH i-g-t 2/2] tests/drv_suspend: Suspend under memory pressure

2018-05-25 Thread Chris Wilson
Recently we discovered that we have a race between swapping and suspend in our resume path (we might be trying to page in an object after disabling the block devices). Let's try to exercise that by exhausting all of system memory before suspend. v2: Explicitly share the large memory area on forkin

[Intel-gfx] [PATCH v5] drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c

2018-05-25 Thread Michal Wajdeczko
Some functions already use i915 name instead of dev_priv. Let's rename this param in all remaining functions, except those that still use legacy macros. v2: don't forget about function descriptions (Sagar) v3: rebased v4: rebased v5: rebased, pulled out from the series Signed-off-by: Michal Wajde

[Intel-gfx] [PATCH i-g-t 1/2] lib: Prioritise oom targetting our children.

2018-05-25 Thread Chris Wilson
We are not nice parents and would sacrifice any one of our children so that the core process can report the failure neatly. Signed-off-by: Chris Wilson --- lib/igt_core.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index

Re: [Intel-gfx] [PATCH 03/18] drm/i915: "Race-to-idle" after switching to the kernel context

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > During suspend we want to flush out all active contexts and their > rendering. To do so we queue a request from the kernel's context, once > we know that request is done, we know the GPU is completely idle. To > speed up that switch bump the GPU clocks. > > Switching to the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich

2018-05-25 Thread Tvrtko Ursulin
On 25/05/2018 13:13, Tvrtko Ursulin wrote: On 25/05/2018 11:28, Lionel Landwerlin wrote: On 25/05/18 09:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the string tracepoint representation we ended up with the engine sandwiched between context hardware id and context fence id. Move the t

Re: [Intel-gfx] [PATCH 03/18] drm/i915: "Race-to-idle" after switching to the kernel context

2018-05-25 Thread Chris Wilson
Quoting Mika Kuoppala (2018-05-25 13:22:55) > Chris Wilson writes: > > > During suspend we want to flush out all active contexts and their > > rendering. To do so we queue a request from the kernel's context, once > > we know that request is done, we know the GPU is completely idle. To > > speed

Re: [Intel-gfx] [PATCH 08/18] drm/i915/execlists: Wait for ELSP submission on restart

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > After a reset, we will ensure that there is at least one request > submitted to HW to ensure that a context is loaded for powersaving. > Let's wait for this submission via a tasklet to complete before we drop > our forcewake, ensuring the system is ready for rc6 before we l

Re: [Intel-gfx] [PATCH 5/9] drm/fb-helper: Add generic fbdev emulation .fb_probe function

2018-05-25 Thread Noralf Trønnes
Den 24.05.2018 11.16, skrev Daniel Vetter: On Wed, May 23, 2018 at 04:34:07PM +0200, Noralf Trønnes wrote: This is the first step in getting generic fbdev emulation. A drm_fb_helper_funcs.fb_probe function is added which uses the DRM client API to get a framebuffer backed by a dumb buffer. A t

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Wait for ELSP submission on restart

2018-05-25 Thread Chris Wilson
Quoting Chris Wilson (2018-05-22 11:19:37) > After a reset, we will ensure that there is at least one request > submitted to HW to ensure that a context is loaded for powersaving. > Let's wait for this submission via a tasklet to complete before we drop > our forcewake, ensuring the system is ready

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915/uc: Trivial s/dev_priv/i915 in intel_uc.c URL : https://patchwork.freedesktop.org/series/43770/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238 -> Patchwork_9121 = == Summary - SUCCESS == No regressions found. External URL: ht

Re: [Intel-gfx] [PATCH v4] drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset

2018-05-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-25 09:36:18) > > On 24/05/2018 14:40, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-05-24 14:34:41) > >> > >> On 19/05/2018 10:04, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-05-18 15:42:00) > > On 18/05/2018 15:13, Chris Wilson wrote: >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs URL : https://patchwork.freedesktop.org/series/43763/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238_full -> Patchwork_9117_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH 01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > In order to prepare the GPU for sleeping, we may want to submit commands > to it. This is a complicated process that may even require some swapping > in from shmemfs, if the GPU was in the wrong state. As such, we need to > do this preparation step synchronously before the

Re: [Intel-gfx] [PATCH 04/18] drm/i915: After reset on sanitization, reset the engine backends

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > As we reset the GPU on suspend/resume, we also do need to reset the > engine state tracking so call into the engine backends. This is > especially important so that we can also sanitize the state tracking > across resume. > > Signed-off-by: Chris Wilson > --- > drivers/gp

Re: [Intel-gfx] [PATCH 04/18] drm/i915: After reset on sanitization, reset the engine backends

2018-05-25 Thread Chris Wilson
Quoting Mika Kuoppala (2018-05-25 14:13:19) > Chris Wilson writes: > > > As we reset the GPU on suspend/resume, we also do need to reset the > > engine state tracking so call into the engine backends. This is > > especially important so that we can also sanitize the state tracking > > across resu

Re: [Intel-gfx] [PATCH 04/18] drm/i915: After reset on sanitization, reset the engine backends

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-05-25 14:13:19) >> Chris Wilson writes: >> >> > As we reset the GPU on suspend/resume, we also do need to reset the >> > engine state tracking so call into the engine backends. This is >> > especially important so that we can also sanitize the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Prepare GEM for suspend earlier (rev5)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Prepare GEM for suspend earlier (rev5) URL : https://patchwork.freedesktop.org/series/43575/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4238_full -> Patchwork_9119_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH 02/18] drm/i915: Switch to kernel context before idling at runtime

2018-05-25 Thread Mika Kuoppala
Chris Wilson writes: > We can reduce our exposure to random neutrinos by resting on the kernel > context having flushed out the user contexts to system memory and > beyond. The corollary is that we then we require two passes through the > idle handler to go to sleep, which on a truly idle system

Re: [Intel-gfx] [PATCH] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Chris Wilson
Quoting Ville Syrjälä (2018-05-25 11:51:13) > On Fri, May 25, 2018 at 10:26:29AM +0100, Chris Wilson wrote: > > In order to prepare the GPU for sleeping, we may want to submit commands > > to it. This is a complicated process that may even require some swapping > > in from shmemfs, if the GPU was i

Re: [Intel-gfx] [PATCH] drm/edid: Fix up edid_cea_modes[] formatting

2018-05-25 Thread Alex Deucher
On Thu, May 24, 2018 at 3:20 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Fix up a bunch of bad indentation and insconsistent comments inconsistent With that fixed: Reviewed-by: Alex Deucher > in edid_cea_modes[]. > > v2: Instead of stripping the aspect ratio comments let's > add th

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/18] drm/i915: Prepare GEM for suspend earlier

2018-05-25 Thread Patchwork
== Series Details == Series: series starting with [01/18] drm/i915: Prepare GEM for suspend earlier URL : https://patchwork.freedesktop.org/series/43765/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4238_full -> Patchwork_9120_full = == Summary - FAILURE == Serious unkn

Re: [Intel-gfx] [PATCH] drm/edid: Fix up edid_cea_modes[] formatting

2018-05-25 Thread Ville Syrjälä
On Fri, May 25, 2018 at 10:21:20AM -0400, Alex Deucher wrote: > On Thu, May 24, 2018 at 3:20 PM, Ville Syrjala > wrote: > > From: Ville Syrjälä > > > > Fix up a bunch of bad indentation and insconsistent comments > > inconsistent Dang. Pulled the trigger on dim mere seconds before seeing your r

[Intel-gfx] [PATCH] drm/i915: Remove stale asserts from i915_gem_find_active_request()

2018-05-25 Thread Chris Wilson
Since we use i915_gem_find_active_request() from inside intel_engine_dump() and may call that at any time, we do not guarantee that the engine is paused nor that the signal kthreads and irq handler are suspended, so we cannot assert that the breadcrumb doesn't advance and that the irq hasn't happen

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Try to suppress more spurious PCH underruns on ILK-IVB

2018-05-25 Thread Ville Syrjälä
On Thu, May 24, 2018 at 10:19:02PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2018-05-24 20:04:05) > > From: Ville Syrjälä > > > > My ILK seems to generate a spurious PCH underrun with most interlaced > > HDMI modes. Add a second vblank wait to avoid it. > > Fwiw, a second vblank becaus

Re: [Intel-gfx] [PATCH v4 1/1] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-25 Thread Ville Syrjälä
On Fri, May 18, 2018 at 06:01:38PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > VBT seems to have some bits to tell us whether the internal LVDS port > has something hooked up. In theory one might expect the VBT to not have > a child device for the LVDS port if there's no panel hooked up

[Intel-gfx] [PATCH i-g-t] igt/perf_pmu: Flush to idle after hang

2018-05-25 Thread Chris Wilson
We may not idle immediately after a hang, and indeed may send a pulse down the pipeline periodically to become idle. Rather than make a flimsy assumption about how long we need to sleep before the system idles, wait for the system to declare itself idle; flushing it to idle in the process! Signed-

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Try to suppress more spurious PCH underruns on ILK-IVB

2018-05-25 Thread Jani Nikula
On Fri, 25 May 2018, Ville Syrjälä wrote: > On Thu, May 24, 2018 at 10:19:02PM +0100, Chris Wilson wrote: >> Quoting Ville Syrjala (2018-05-24 20:04:05) >> > From: Ville Syrjälä >> > >> > My ILK seems to generate a spurious PCH underrun with most interlaced >> > HDMI modes. Add a second vblank w

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify ilk-ivb underrun suppression

2018-05-25 Thread Chris Wilson
Quoting Ville Syrjala (2018-05-24 20:04:06) > From: Ville Syrjälä > > Let's suppress the underruns around every modeset sequence instead > of trying to avoid it. Planes are disabled at this point anyway so > we don't really gain anything from keeping the underrun reporting > enabled. Also for PCH

Re: [Intel-gfx] [PATCH v6 7/7] drm/i915: add a sysfs entry to let users set sseu configs

2018-05-25 Thread Lionel Landwerlin
On 24/05/18 11:39, Tvrtko Ursulin wrote: --- a/drivers/gpu/drm/i915/i915_gem_context.c +++ b/drivers/gpu/drm/i915/i915_gem_context.c @@ -981,7 +981,8 @@ int i915_gem_context_setparam_ioctl(struct drm_device *dev, void *data,   break;   }   -    if (!capable(C

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify ilk-ivb underrun suppression

2018-05-25 Thread Ville Syrjälä
On Fri, May 25, 2018 at 04:20:07PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2018-05-24 20:04:06) > > From: Ville Syrjälä > > > > Let's suppress the underruns around every modeset sequence instead > > of trying to avoid it. Planes are disabled at this point anyway so > > we don't really

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Try to suppress more spurious PCH underruns on ILK-IVB

2018-05-25 Thread Ville Syrjälä
On Fri, May 25, 2018 at 06:19:17PM +0300, Jani Nikula wrote: > On Fri, 25 May 2018, Ville Syrjälä wrote: > > On Thu, May 24, 2018 at 10:19:02PM +0100, Chris Wilson wrote: > >> Quoting Ville Syrjala (2018-05-24 20:04:05) > >> > From: Ville Syrjälä > >> > > >> > My ILK seems to generate a spurious

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove stale asserts from i915_gem_find_active_request()

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915: Remove stale asserts from i915_gem_find_active_request() URL : https://patchwork.freedesktop.org/series/43781/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4242 -> Patchwork_9122 = == Summary - WARNING == Minor unknown changes comi

[Intel-gfx] [PATCH] drm/i915/icl: fix icl_unmap/map_plls_to_ports

2018-05-25 Thread Lucas De Marchi
From: Mahesh Kumar All connectors may not have best_encoder attached, so don't dereference encoder pointer for each connector. Fixes: c27e917e2bda (drm/i915/icl: add basic support for the ICL clocks) Signed-off-by: Mahesh Kumar Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_ddi.c

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify ilk-ivb underrun suppression

2018-05-25 Thread Chris Wilson
Quoting Ville Syrjälä (2018-05-25 16:43:42) > On Fri, May 25, 2018 at 04:20:07PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2018-05-24 20:04:06) > > > From: Ville Syrjälä > > > > > > Let's suppress the underruns around every modeset sequence instead > > > of trying to avoid it. Planes

Re: [Intel-gfx] DRM Inquiry

2018-05-25 Thread Taylor, Clinton A
Looks like the seek=%d in the sprintf is not working. 0x11 0x0A are being returned by the monitor from DPCD’s 0x and 0x0001 repeatedly. The first is DPCD revision (1.1) and the second is maximum Link Rate (0x0a) which is 2.7 Gbps. You might want to do a printf of call to make sure seek is be

Re: [Intel-gfx] [PATCH 06/24] drm/i915/ICL: Add register definition for DFLEXDPMLE

2018-05-25 Thread Lucas De Marchi
On Thu, May 24, 2018 at 05:26:38PM -0700, Paulo Zanoni wrote: > Em Seg, 2018-05-21 às 17:25 -0700, Paulo Zanoni escreveu: > > From: Manasi Navare > > > > DFLEXDPMLE register is required to tell the FIA hardware which > > main links of DP are enabled on TCC Connectors. FIA uses this > > informatio

Re: [Intel-gfx] [PATCH 25/24] drm/i915/icl: fix gmbus gpio pin mapping

2018-05-25 Thread Ville Syrjälä
On Thu, May 24, 2018 at 05:36:37PM -0700, Lucas De Marchi wrote: > On Thu, May 24, 2018 at 04:42:36PM -0700, Paulo Zanoni wrote: > > From: Mahesh Kumar > > > > ICP has GPIO pin 1/2 mapped to combo-phy ports & GPIO pins 9/10/11/12 > > mapped to tc ports[1-4]. > > This patch defines GPIOCTL registe

Re: [Intel-gfx] [PATCH 25/24] drm/i915/icl: fix gmbus gpio pin mapping

2018-05-25 Thread Lucas De Marchi
On Fri, May 25, 2018 at 07:24:07PM +0300, Ville Syrjälä wrote: > On Thu, May 24, 2018 at 05:36:37PM -0700, Lucas De Marchi wrote: > > On Thu, May 24, 2018 at 04:42:36PM -0700, Paulo Zanoni wrote: > > > From: Mahesh Kumar > > > > > > ICP has GPIO pin 1/2 mapped to combo-phy ports & GPIO pins 9/10/

Re: [Intel-gfx] [PATCH 07/24] drm/i915/icl: Add DDI HDMI level selection for ICL

2018-05-25 Thread Lucas De Marchi
On Mon, May 21, 2018 at 05:25:41PM -0700, Paulo Zanoni wrote: > From: Manasi Navare > > This patch adds a proper HDMI DDI entry level for vswing > programming sequences on ICL. > > Spec doesn't specify any default for HDMI tables, > so let's pick the last entry as the default for now > to stay c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: fix icl_unmap/map_plls_to_ports (rev2)

2018-05-25 Thread Patchwork
== Series Details == Series: drm/i915/icl: fix icl_unmap/map_plls_to_ports (rev2) URL : https://patchwork.freedesktop.org/series/43510/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4242 -> Patchwork_9123 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 06/24] drm/i915/ICL: Add register definition for DFLEXDPMLE

2018-05-25 Thread Manasi Navare
On Fri, May 25, 2018 at 09:14:57AM -0700, Lucas De Marchi wrote: > On Thu, May 24, 2018 at 05:26:38PM -0700, Paulo Zanoni wrote: > > Em Seg, 2018-05-21 às 17:25 -0700, Paulo Zanoni escreveu: > > > From: Manasi Navare > > > > > > DFLEXDPMLE register is required to tell the FIA hardware which > > >

[Intel-gfx] [PATCH] drm/i915/pmu: Measure sampler intervals

2018-05-25 Thread Chris Wilson
hrtimer is not reliable enough to assume fixed intervals, and so even coarse accuracy (in the face of kasan and similar heavy debugging) we need to measure the actual interval between sample. While using a single timestamp to compute the interval does not allow very fine accuracy (consider the imp

Re: [Intel-gfx] DRM Inquiry

2018-05-25 Thread Jani Nikula
On Fri, 25 May 2018, "Taylor, Clinton A" wrote: > Looks like the seek=%d in the sprintf is not working. Yeah. Try skip=%d instead. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Measure sampler intervals

2018-05-25 Thread Tvrtko Ursulin
On 25/05/2018 18:11, Chris Wilson wrote: hrtimer is not reliable enough to assume fixed intervals, and so even coarse accuracy (in the face of kasan and similar heavy debugging) we need to measure the actual interval between sample. It doesn't even average out to something acceptable under suc

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Measure sampler intervals

2018-05-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-25 18:31:35) > > On 25/05/2018 18:11, Chris Wilson wrote: > > hrtimer is not reliable enough to assume fixed intervals, and so even > > coarse accuracy (in the face of kasan and similar heavy debugging) we > > need to measure the actual interval between sample. > >

  1   2   >